Cyclic0007/ruff
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ty] Early return in Type::has_relation_to_impl for Type variants that are always mutually disjoint

Browse Source
This commit is contained in:
Alex Waygood
2026-01-05 15:45:49 +00:00
parent 4712503c6d
commit 288ade8381
2 changed files with 129 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

139
crates/ty_python_semantic/src/types/relation.rs
View File

@@ -357,6 +357,124 @@ impl<'db> Type<'db> {
}
match (self, target) {
// These branches here are quick optimisations to exclude
// fully static variants that we know are always mutually disjoint.
(
Type::BooleanLiteral(..)
| Type::IntLiteral(..)
| Type::StringLiteral(..)
| Type::BytesLiteral(..)
| Type::EnumLiteral(..)
| Type::WrapperDescriptor(..)
| Type::ModuleLiteral(..)
| Type::ClassLiteral(..)
| Type::SpecialForm(..),
Type::BooleanLiteral(..)
| Type::IntLiteral(..)
| Type::StringLiteral(..)
| Type::BytesLiteral(..)
| Type::EnumLiteral(..)
| Type::WrapperDescriptor(..)
| Type::ModuleLiteral(..)
| Type::ClassLiteral(..)
| Type::SpecialForm(..),
) => ConstraintSet::from(self == target),
(
Type::TypeIs(..)
| Type::TypeGuard(..)
| Type::BoundSuper(_)
| Type::PropertyInstance(_),
Type::LiteralString,
)
| (
Type::LiteralString,
Type::TypeIs(..)
| Type::TypeGuard(..)
| Type::BoundSuper(_)
| Type::PropertyInstance(_),
)
| (
Type::TypedDict(..),
Type::LiteralString
| Type::TypeIs(..)
| Type::TypeGuard(..)
| Type::BoundSuper(_)
| Type::PropertyInstance(_),
)
| (
Type::TypeGuard(..) | Type::LiteralString | Type::TypeIs(..),
Type::TypedDict(..) | Type::BoundSuper(_) | Type::PropertyInstance(_),
)
| (
Type::TypeIs(..)
| Type::TypeGuard(..)
| Type::LiteralString
| Type::TypedDict(..)
| Type::BoundSuper(_)
| Type::PropertyInstance(_),
Type::ClassLiteral(..)
| Type::BooleanLiteral(..)
| Type::IntLiteral(..)
| Type::BytesLiteral(..)
| Type::EnumLiteral(..)
| Type::WrapperDescriptor(..)
| Type::ModuleLiteral(..)
| Type::SpecialForm(..)
| Type::SubclassOf(..),
)
| (
Type::ClassLiteral(..)
| Type::BooleanLiteral(..)
| Type::IntLiteral(..)
| Type::BytesLiteral(..)
| Type::EnumLiteral(..)
| Type::WrapperDescriptor(..)
| Type::ModuleLiteral(..)
| Type::SubclassOf(_)
| Type::SpecialForm(..),
Type::TypeIs(..)
| Type::TypeGuard(..)
| Type::LiteralString
| Type::TypedDict(..)
| Type::BoundSuper(_)
| Type::PropertyInstance(_),
)
| (
Type::SubclassOf(..) | Type::GenericAlias(..),
Type::BooleanLiteral(..)
| Type::IntLiteral(..)
| Type::StringLiteral(..)
| Type::LiteralString
| Type::BytesLiteral(..)
| Type::EnumLiteral(..)
| Type::FunctionLiteral(..)
| Type::BoundMethod(..)
| Type::KnownBoundMethod(..)
| Type::WrapperDescriptor(..)
| Type::TypedDict(..)
| Type::ModuleLiteral(..)
| Type::BoundSuper(_)
| Type::PropertyInstance(_),
)
| (
Type::BooleanLiteral(..)
| Type::IntLiteral(..)
| Type::StringLiteral(..)
| Type::LiteralString
| Type::BytesLiteral(..)
| Type::EnumLiteral(..)
| Type::FunctionLiteral(..)
| Type::BoundMethod(..)
| Type::KnownBoundMethod(..)
| Type::TypedDict(..)
| Type::WrapperDescriptor(..)
| Type::ModuleLiteral(..)
| Type::BoundSuper(_)
| Type::PropertyInstance(_),
Type::SubclassOf(..) | Type::GenericAlias(..),
) => ConstraintSet::from(false),
// Everything is a subtype of `object`.
(_, Type::NominalInstance(instance)) if instance.is_object() => {
ConstraintSet::from(true)
@@ -840,27 +958,6 @@ impl<'db> Type<'db> {
)
}
// No literal type is a subtype of any other literal type, unless they are the same
// type (which is handled above). This case is not necessary from a correctness
// perspective (the fallback cases below will handle it correctly), but it is important
// for performance of simplifying large unions of literal types.
(
Type::StringLiteral(_)
| Type::IntLiteral(_)
| Type::BytesLiteral(_)
| Type::ClassLiteral(_)
| Type::FunctionLiteral(_)
| Type::ModuleLiteral(_)
| Type::EnumLiteral(_),
Type::StringLiteral(_)
| Type::IntLiteral(_)
| Type::BytesLiteral(_)
| Type::ClassLiteral(_)
| Type::FunctionLiteral(_)
| Type::ModuleLiteral(_)
| Type::EnumLiteral(_),
) => ConstraintSet::from(false),
(Type::Callable(self_callable), Type::Callable(other_callable)) => relation_visitor
.visit((self, target, relation), || {
self_callable.has_relation_to_impl(