From 2de8455e43efc55b2ed302c0bdf4e59744338504 Mon Sep 17 00:00:00 2001 From: Carl Meyer Date: Sat, 15 Mar 2025 08:47:50 -0700 Subject: [PATCH] [red-knot] LSP: only emit WARN logs from non-red-knot sources (#16760) Currently the red-knot LSP server emits any log messages of level `INFO` or higher from non-red-knot crates. This makes its output quite verbose, because Salsa emits an `INFO` level message every time it executes a query. I use red-knot as LSP with neovim, and this spams the log file quite a lot. It seems like a better default to only emit `WARN` or higher messages from non-red-knot sources. I confirmed that this fixes the nvim LSP log spam. --- crates/red_knot_server/src/logging.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/red_knot_server/src/logging.rs b/crates/red_knot_server/src/logging.rs index 701e8b697e..bde8c57d09 100644 --- a/crates/red_knot_server/src/logging.rs +++ b/crates/red_knot_server/src/logging.rs @@ -102,7 +102,7 @@ impl tracing_subscriber::layer::Filter for LogLevelFilter { let filter = if meta.target().starts_with("red_knot") { self.filter.trace_level() } else { - tracing::Level::INFO + tracing::Level::WARN }; meta.level() <= &filter