From 3fcbe8bde6ec5ea211a0d3954240952e4c97124b Mon Sep 17 00:00:00 2001 From: Andrew Gallant Date: Wed, 17 Sep 2025 11:46:42 -0400 Subject: [PATCH] [ty] Remove TODO about using a non-panicking lookup method Ref https://github.com/astral-sh/ruff/pull/20439#discussion_r2355082049 Ref https://github.com/astral-sh/ruff/pull/18455#discussion_r2126833137 --- crates/ty_python_semantic/src/semantic_model.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/crates/ty_python_semantic/src/semantic_model.rs b/crates/ty_python_semantic/src/semantic_model.rs index 2452e15f57..11ea272246 100644 --- a/crates/ty_python_semantic/src/semantic_model.rs +++ b/crates/ty_python_semantic/src/semantic_model.rs @@ -267,10 +267,6 @@ impl<'db> SemanticModel<'db> { fn scope(&self, node: ast::AnyNodeRef<'_>) -> Option { let index = semantic_index(self.db, self.file); - // TODO: We currently use `try_expression_scope_id` here as a hotfix for [1]. - // Revert this to use `expression_scope_id` once a proper fix is in place. - // - // [1] https://github.com/astral-sh/ty/issues/572 match node { ast::AnyNodeRef::Identifier(identifier) => index.try_expression_scope_id(identifier), node => match node.as_expr_ref() {