[ty] Fix incorrect narrowing for if type(x) == y (#22531)

2026-01-12 12:26:47 +00:00
parent e15f88ff21
commit 5a3deee353
2 changed files with 10 additions and 5 deletions
--- a/crates/ty_python_semantic/src/types/narrow.rs
+++ b/crates/ty_python_semantic/src/types/narrow.rs
@@ -1220,10 +1220,10 @@ impl<'db, 'ast> NarrowingConstraintsBuilder<'db, 'ast> {
                        _ => continue,
                    };

-                    let is_positive = if is_positive {
-                        op == &ast::CmpOp::Is
-                    } else {
-                        op == &ast::CmpOp::IsNot
+                    let is_positive = match op {
+                        ast::CmpOp::Is => is_positive,
+                        ast::CmpOp::IsNot => !is_positive,
+                        _ => continue,
                    };

                    // `else`-branch narrowing for `if type(x) is Y` can only be done