Cyclic0007/ruff
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ty] Add tests for else branches of hasattr() narrowing (#18067)

Browse Source 
## Summary

This addresses @sharkdp's post-merge review in
https://github.com/astral-sh/ruff/pull/18053#discussion_r2086190617

## Test Plan

`cargo test -p ty_python_semantic`
This commit is contained in:
Alex Waygood
2025-05-13 09:57:53 -04:00
committed by GitHub
parent 5913997c72
commit 5bf5f3682a
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
crates/ty_python_semantic/resources/mdtest/narrow/hasattr.md
View File

@@ -15,12 +15,24 @@ def f(x: Foo):
if hasattr(x, "spam"):
reveal_type(x) # revealed: Foo & <Protocol with members 'spam'>
reveal_type(x.spam) # revealed: object
else:
reveal_type(x) # revealed: Foo & ~<Protocol with members 'spam'>
# TODO: should error and reveal `Unknown`
reveal_type(x.spam) # revealed: @Todo(map_with_boundness: intersections with negative contributions)
if hasattr(x, "not-an-identifier"):
reveal_type(x) # revealed: Foo
else:
reveal_type(x) # revealed: Foo
def y(x: Bar):
if hasattr(x, "spam"):
reveal_type(x) # revealed: Never
reveal_type(x.spam) # revealed: Never
else:
reveal_type(x) # revealed: Bar
# error: [unresolved-attribute]
reveal_type(x.spam) # revealed: Unknown
```