Cyclic0007/ruff
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ty] Fix a bug with "all_submodule_names_for_package" API

Browse Source 
The names of the submodules returned should be *complete*. This
is the contract of `Module::name`. However, we were previously
only returning the basename of the submodule.
This commit is contained in:
Andrew Gallant
2025-09-16 13:05:33 -04:00
committed by Andrew Gallant
parent cf16fc4aa4
commit 6ec52991cb
3 changed files with 21 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
crates/ty_python_semantic/src/module_resolver/module.rs
View File

@@ -203,7 +203,9 @@ fn all_submodule_names_for_package<'db>(
})
.filter_map(|entry| {
let stem = entry.path().file_stem()?;
let name = ModuleName::new(stem)?;
let mut name = module.name(db).clone();
name.extend(&ModuleName::new(stem)?);
let (kind, file) = if entry.file_type().is_directory() {
(
ModuleKind::Package,
@@ -239,7 +241,9 @@ fn all_submodule_names_for_package<'db>(
})
.filter_map(|entry| {
let stem = entry.path().file_stem()?;
let name = ModuleName::new(stem)?;
let mut name = module.name(db).clone();
name.extend(&ModuleName::new(stem)?);
let (kind, file) = if entry.file_type().is_directory() {
(
ModuleKind::Package,