From 737fcfd79eb33b5a8bacf00ac27cfc81f1fcfbef Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Sun, 3 Mar 2024 17:54:53 -0800 Subject: [PATCH] Remove trailing space from `CapWords` message (#10220) --- crates/ruff/tests/lint.rs | 2 +- .../rules/pep8_naming/rules/invalid_class_name.rs | 2 +- ...ter__rules__pep8_naming__tests__N801_N801.py.snap | 12 +++++------- ...ep8_naming__tests__ignore_names_N801_N801.py.snap | 6 ++---- 4 files changed, 9 insertions(+), 13 deletions(-) diff --git a/crates/ruff/tests/lint.rs b/crates/ruff/tests/lint.rs index 05a93c4d6e..900fc5382f 100644 --- a/crates/ruff/tests/lint.rs +++ b/crates/ruff/tests/lint.rs @@ -849,7 +849,7 @@ fn deprecated_config_option_overridden_via_cli() { success: false exit_code: 1 ----- stdout ----- - -:1:7: N801 Class name `lowercase` should use CapWords convention + -:1:7: N801 Class name `lowercase` should use CapWords convention Found 1 error. ----- stderr ----- diff --git a/crates/ruff_linter/src/rules/pep8_naming/rules/invalid_class_name.rs b/crates/ruff_linter/src/rules/pep8_naming/rules/invalid_class_name.rs index ad9749e3ab..edcccf663d 100644 --- a/crates/ruff_linter/src/rules/pep8_naming/rules/invalid_class_name.rs +++ b/crates/ruff_linter/src/rules/pep8_naming/rules/invalid_class_name.rs @@ -44,7 +44,7 @@ impl Violation for InvalidClassName { #[derive_message_formats] fn message(&self) -> String { let InvalidClassName { name } = self; - format!("Class name `{name}` should use CapWords convention ") + format!("Class name `{name}` should use CapWords convention") } } diff --git a/crates/ruff_linter/src/rules/pep8_naming/snapshots/ruff_linter__rules__pep8_naming__tests__N801_N801.py.snap b/crates/ruff_linter/src/rules/pep8_naming/snapshots/ruff_linter__rules__pep8_naming__tests__N801_N801.py.snap index 66c139e033..976d069204 100644 --- a/crates/ruff_linter/src/rules/pep8_naming/snapshots/ruff_linter__rules__pep8_naming__tests__N801_N801.py.snap +++ b/crates/ruff_linter/src/rules/pep8_naming/snapshots/ruff_linter__rules__pep8_naming__tests__N801_N801.py.snap @@ -1,39 +1,37 @@ --- source: crates/ruff_linter/src/rules/pep8_naming/mod.rs --- -N801.py:1:7: N801 Class name `bad` should use CapWords convention +N801.py:1:7: N801 Class name `bad` should use CapWords convention | 1 | class bad: | ^^^ N801 2 | pass | -N801.py:5:7: N801 Class name `_bad` should use CapWords convention +N801.py:5:7: N801 Class name `_bad` should use CapWords convention | 5 | class _bad: | ^^^^ N801 6 | pass | -N801.py:9:7: N801 Class name `bad_class` should use CapWords convention +N801.py:9:7: N801 Class name `bad_class` should use CapWords convention | 9 | class bad_class: | ^^^^^^^^^ N801 10 | pass | -N801.py:13:7: N801 Class name `Bad_Class` should use CapWords convention +N801.py:13:7: N801 Class name `Bad_Class` should use CapWords convention | 13 | class Bad_Class: | ^^^^^^^^^ N801 14 | pass | -N801.py:17:7: N801 Class name `BAD_CLASS` should use CapWords convention +N801.py:17:7: N801 Class name `BAD_CLASS` should use CapWords convention | 17 | class BAD_CLASS: | ^^^^^^^^^ N801 18 | pass | - - diff --git a/crates/ruff_linter/src/rules/pep8_naming/snapshots/ruff_linter__rules__pep8_naming__tests__ignore_names_N801_N801.py.snap b/crates/ruff_linter/src/rules/pep8_naming/snapshots/ruff_linter__rules__pep8_naming__tests__ignore_names_N801_N801.py.snap index f594606b62..9a910411de 100644 --- a/crates/ruff_linter/src/rules/pep8_naming/snapshots/ruff_linter__rules__pep8_naming__tests__ignore_names_N801_N801.py.snap +++ b/crates/ruff_linter/src/rules/pep8_naming/snapshots/ruff_linter__rules__pep8_naming__tests__ignore_names_N801_N801.py.snap @@ -1,7 +1,7 @@ --- source: crates/ruff_linter/src/rules/pep8_naming/mod.rs --- -N801.py:4:7: N801 Class name `stillBad` should use CapWords convention +N801.py:4:7: N801 Class name `stillBad` should use CapWords convention | 2 | pass 3 | @@ -10,7 +10,7 @@ N801.py:4:7: N801 Class name `stillBad` should use CapWords convention 5 | pass | -N801.py:10:7: N801 Class name `STILL_BAD` should use CapWords convention +N801.py:10:7: N801 Class name `STILL_BAD` should use CapWords convention | 8 | pass 9 | @@ -18,5 +18,3 @@ N801.py:10:7: N801 Class name `STILL_BAD` should use CapWords convention | ^^^^^^^^^ N801 11 | pass | - -