Cyclic0007/ruff
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ty] Shrink size of AstNodeRef (#20028)

Browse Source 
## Summary

Removes the `module_ptr` field from `AstNodeRef` in release mode, and
change `NodeIndex` to a `NonZeroU32` to reduce the size of
`Option<AstNodeRef<_>>` fields.

I believe CI runs in debug mode, so this won't show up in the memory
report, but this reduces memory by ~2% in release mode.
This commit is contained in:
Ibraheem Ahmed
2025-08-22 17:03:22 -04:00
committed by GitHub
parent 886c4e4773
commit 7abc41727b
648 changed files with 19641 additions and 20364 deletions
Download Patch File Download Diff File Expand all files Collapse all files

104
crates/ruff_python_parser/tests/snapshots/valid_syntax@statement__assert.py.snap
View File

@@ -7,20 +7,20 @@ input_file: crates/ruff_python_parser/resources/valid/statement/assert.py
```
Module(
ModModule {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 0..186,
body: [
Assert(
StmtAssert {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 0..12,
test: Compare(
ExprCompare {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 7..12,
left: NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 7..8,
value: Int(
1,
@@ -33,7 +33,7 @@ Module(
comparators: [
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 11..12,
value: Int(
2,
@@ -48,15 +48,15 @@ Module(
),
Assert(
StmtAssert {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 13..26,
test: Call(
ExprCall {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 20..26,
func: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 20..24,
id: Name("call"),
ctx: Load,
@@ -64,7 +64,7 @@ Module(
),
arguments: Arguments {
range: 24..26,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
args: [],
keywords: [],
},
@@ -75,17 +75,17 @@ Module(
),
Assert(
StmtAssert {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 27..41,
test: BoolOp(
ExprBoolOp {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 34..41,
op: And,
values: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 34..35,
id: Name("a"),
ctx: Load,
@@ -93,7 +93,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 40..41,
id: Name("b"),
ctx: Load,
@@ -107,30 +107,28 @@ Module(
),
Assert(
StmtAssert {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 42..60,
test: Lambda(
ExprLambda {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 49..60,
parameters: Some(
Parameters {
range: 56..57,
node_index: AtomicNodeIndex(
0,
),
node_index: NodeIndex(None),
posonlyargs: [],
args: [
ParameterWithDefault {
range: 56..57,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
parameter: Parameter {
range: 56..57,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
name: Identifier {
id: Name("x"),
range: 56..57,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
annotation: None,
},
@@ -144,7 +142,7 @@ Module(
),
body: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 59..60,
id: Name("y"),
ctx: Load,
@@ -157,15 +155,15 @@ Module(
),
Assert(
StmtAssert {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 61..75,
test: Await(
ExprAwait {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 68..75,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 74..75,
id: Name("x"),
ctx: Load,
@@ -178,22 +176,22 @@ Module(
),
Assert(
StmtAssert {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 76..99,
test: If(
ExprIf {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 83..99,
test: BooleanLiteral(
ExprBooleanLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 88..92,
value: true,
},
),
body: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 83..84,
id: Name("x"),
ctx: Load,
@@ -201,7 +199,7 @@ Module(
),
orelse: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 98..99,
id: Name("y"),
ctx: Load,
@@ -214,11 +212,11 @@ Module(
),
Assert(
StmtAssert {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 101..118,
test: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 108..109,
id: Name("x"),
ctx: Load,
@@ -227,13 +225,13 @@ Module(
msg: Some(
StringLiteral(
ExprStringLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 111..118,
value: StringLiteralValue {
inner: Single(
StringLiteral {
range: 111..118,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
value: "error",
flags: StringLiteralFlags {
quote_style: Double,
@@ -250,11 +248,11 @@ Module(
),
Assert(
StmtAssert {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 119..140,
test: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 126..127,
id: Name("x"),
ctx: Load,
@@ -263,26 +261,24 @@ Module(
msg: Some(
Lambda(
ExprLambda {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 129..140,
parameters: Some(
Parameters {
range: 136..137,
node_index: AtomicNodeIndex(
0,
),
node_index: NodeIndex(None),
posonlyargs: [],
args: [
ParameterWithDefault {
range: 136..137,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
parameter: Parameter {
range: 136..137,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
name: Identifier {
id: Name("x"),
range: 136..137,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
annotation: None,
},
@@ -296,7 +292,7 @@ Module(
),
body: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 139..140,
id: Name("y"),
ctx: Load,
@@ -309,11 +305,11 @@ Module(
),
Assert(
StmtAssert {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 141..158,
test: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 148..149,
id: Name("x"),
ctx: Load,
@@ -322,11 +318,11 @@ Module(
msg: Some(
Await(
ExprAwait {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 151..158,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 157..158,
id: Name("x"),
ctx: Load,
@@ -339,11 +335,11 @@ Module(
),
Assert(
StmtAssert {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 159..185,
test: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 166..167,
id: Name("x"),
ctx: Load,
@@ -352,18 +348,18 @@ Module(
msg: Some(
If(
ExprIf {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 169..185,
test: BooleanLiteral(
ExprBooleanLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 174..178,
value: true,
},
),
body: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 169..170,
id: Name("x"),
ctx: Load,
@@ -371,7 +367,7 @@ Module(
),
orelse: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 184..185,
id: Name("y"),
ctx: Load,