Cyclic0007/ruff
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ty] Shrink size of AstNodeRef (#20028)

Browse Source 
## Summary

Removes the `module_ptr` field from `AstNodeRef` in release mode, and
change `NodeIndex` to a `NonZeroU32` to reduce the size of
`Option<AstNodeRef<_>>` fields.

I believe CI runs in debug mode, so this won't show up in the memory
report, but this reduces memory by ~2% in release mode.
This commit is contained in:
Ibraheem Ahmed
2025-08-22 17:03:22 -04:00
committed by GitHub
parent 886c4e4773
commit 7abc41727b
648 changed files with 19641 additions and 20364 deletions
Download Patch File Download Diff File Expand all files Collapse all files

250
crates/ruff_python_parser/tests/snapshots/valid_syntax@statement__assignment.py.snap
View File

@@ -7,17 +7,17 @@ input_file: crates/ruff_python_parser/resources/valid/statement/assignment.py
```
Module(
ModModule {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 0..729,
body: [
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 0..13,
targets: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 0..1,
id: Name("x"),
ctx: Store,
@@ -26,12 +26,12 @@ Module(
],
value: Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 4..13,
elts: [
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 5..6,
value: Int(
1,
@@ -40,7 +40,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 8..9,
value: Int(
2,
@@ -49,7 +49,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 11..12,
value: Int(
3,
@@ -65,17 +65,17 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 15..33,
targets: [
Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 15..21,
elts: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 16..17,
id: Name("x"),
ctx: Store,
@@ -83,7 +83,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 19..20,
id: Name("y"),
ctx: Store,
@@ -97,12 +97,12 @@ Module(
],
value: Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 24..33,
elts: [
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 25..26,
value: Int(
1,
@@ -111,7 +111,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 28..29,
value: Int(
2,
@@ -120,7 +120,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 31..32,
value: Int(
3,
@@ -136,17 +136,17 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 35..53,
targets: [
List(
ExprList {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 35..41,
elts: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 36..37,
id: Name("x"),
ctx: Store,
@@ -154,7 +154,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 39..40,
id: Name("y"),
ctx: Store,
@@ -167,12 +167,12 @@ Module(
],
value: Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 44..53,
elts: [
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 45..46,
value: Int(
1,
@@ -181,7 +181,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 48..49,
value: Int(
2,
@@ -190,7 +190,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 51..52,
value: Int(
3,
@@ -206,16 +206,16 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 55..70,
targets: [
Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 55..58,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 55..56,
id: Name("x"),
ctx: Load,
@@ -224,7 +224,7 @@ Module(
attr: Identifier {
id: Name("y"),
range: 57..58,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Store,
},
@@ -232,12 +232,12 @@ Module(
],
value: Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 61..70,
elts: [
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 62..63,
value: Int(
1,
@@ -246,7 +246,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 65..66,
value: Int(
2,
@@ -255,7 +255,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 68..69,
value: Int(
3,
@@ -271,16 +271,16 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 72..88,
targets: [
Subscript(
ExprSubscript {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 72..76,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 72..73,
id: Name("x"),
ctx: Load,
@@ -288,7 +288,7 @@ Module(
),
slice: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 74..75,
id: Name("y"),
ctx: Load,
@@ -300,12 +300,12 @@ Module(
],
value: Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 79..88,
elts: [
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 80..81,
value: Int(
1,
@@ -314,7 +314,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 83..84,
value: Int(
2,
@@ -323,7 +323,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 86..87,
value: Int(
3,
@@ -339,17 +339,17 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 90..109,
targets: [
Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 90..97,
elts: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 91..92,
id: Name("x"),
ctx: Store,
@@ -357,11 +357,11 @@ Module(
),
Starred(
ExprStarred {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 94..96,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 95..96,
id: Name("y"),
ctx: Store,
@@ -378,12 +378,12 @@ Module(
],
value: Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 100..109,
elts: [
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 101..102,
value: Int(
1,
@@ -392,7 +392,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 104..105,
value: Int(
2,
@@ -401,7 +401,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 107..108,
value: Int(
3,
@@ -417,17 +417,17 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 259..280,
targets: [
List(
ExprList {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 259..268,
elts: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 260..261,
id: Name("x"),
ctx: Store,
@@ -435,7 +435,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 263..264,
id: Name("y"),
ctx: Store,
@@ -443,7 +443,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 266..267,
id: Name("z"),
ctx: Store,
@@ -456,12 +456,12 @@ Module(
],
value: List(
ExprList {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 271..280,
elts: [
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 272..273,
value: Int(
1,
@@ -470,7 +470,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 275..276,
value: Int(
2,
@@ -479,7 +479,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 278..279,
value: Int(
3,
@@ -494,17 +494,17 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 282..303,
targets: [
Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 282..291,
elts: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 283..284,
id: Name("x"),
ctx: Store,
@@ -512,7 +512,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 286..287,
id: Name("y"),
ctx: Store,
@@ -520,7 +520,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 289..290,
id: Name("z"),
ctx: Store,
@@ -534,12 +534,12 @@ Module(
],
value: Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 294..303,
elts: [
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 295..296,
value: Int(
1,
@@ -548,7 +548,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 298..299,
value: Int(
2,
@@ -557,7 +557,7 @@ Module(
),
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 301..302,
value: Int(
3,
@@ -573,16 +573,16 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 304..313,
targets: [
Subscript(
ExprSubscript {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 304..308,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 304..305,
id: Name("x"),
ctx: Load,
@@ -590,7 +590,7 @@ Module(
),
slice: NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 306..307,
value: Int(
0,
@@ -603,7 +603,7 @@ Module(
],
value: NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 311..313,
value: Int(
42,
@@ -614,16 +614,16 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 410..419,
targets: [
Subscript(
ExprSubscript {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 410..414,
value: NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 410..411,
value: Int(
5,
@@ -632,7 +632,7 @@ Module(
),
slice: NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 412..413,
value: Int(
0,
@@ -645,7 +645,7 @@ Module(
],
value: NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 417..419,
value: Int(
42,
@@ -656,16 +656,16 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 420..433,
targets: [
Subscript(
ExprSubscript {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 420..426,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 420..421,
id: Name("x"),
ctx: Load,
@@ -673,12 +673,12 @@ Module(
),
slice: Slice(
ExprSlice {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 422..425,
lower: Some(
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 422..423,
value: Int(
1,
@@ -689,7 +689,7 @@ Module(
upper: Some(
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 424..425,
value: Int(
2,
@@ -706,12 +706,12 @@ Module(
],
value: List(
ExprList {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 429..433,
elts: [
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 430..432,
value: Int(
42,
@@ -726,16 +726,16 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 529..542,
targets: [
Subscript(
ExprSubscript {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 529..535,
value: NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 529..530,
value: Int(
5,
@@ -744,12 +744,12 @@ Module(
),
slice: Slice(
ExprSlice {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 531..534,
lower: Some(
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 531..532,
value: Int(
1,
@@ -760,7 +760,7 @@ Module(
upper: Some(
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 533..534,
value: Int(
2,
@@ -777,12 +777,12 @@ Module(
],
value: List(
ExprList {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 538..542,
elts: [
NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 539..541,
value: Int(
42,
@@ -797,16 +797,16 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 544..556,
targets: [
Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 544..551,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 544..547,
id: Name("foo"),
ctx: Load,
@@ -815,7 +815,7 @@ Module(
attr: Identifier {
id: Name("bar"),
range: 548..551,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Store,
},
@@ -823,7 +823,7 @@ Module(
],
value: NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 554..556,
value: Int(
42,
@@ -834,22 +834,22 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 658..670,
targets: [
Attribute(
ExprAttribute {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 658..665,
value: StringLiteral(
ExprStringLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 658..663,
value: StringLiteralValue {
inner: Single(
StringLiteral {
range: 658..663,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
value: "foo",
flags: StringLiteralFlags {
quote_style: Double,
@@ -864,7 +864,7 @@ Module(
attr: Identifier {
id: Name("y"),
range: 664..665,
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
},
ctx: Store,
},
@@ -872,7 +872,7 @@ Module(
],
value: NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 668..670,
value: Int(
42,
@@ -883,12 +883,12 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 672..680,
targets: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 672..675,
id: Name("foo"),
ctx: Store,
@@ -897,7 +897,7 @@ Module(
],
value: NumberLiteral(
ExprNumberLiteral {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 678..680,
value: Int(
42,
@@ -908,12 +908,12 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 682..695,
targets: [
List(
ExprList {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 682..684,
elts: [],
ctx: Store,
@@ -922,16 +922,16 @@ Module(
],
value: Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 687..695,
elts: [
Starred(
ExprStarred {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 688..693,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 689..693,
id: Name("data"),
ctx: Load,
@@ -949,12 +949,12 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 696..709,
targets: [
Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 696..698,
elts: [],
ctx: Store,
@@ -964,16 +964,16 @@ Module(
],
value: Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 701..709,
elts: [
Starred(
ExprStarred {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 702..707,
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 703..707,
id: Name("data"),
ctx: Load,
@@ -991,17 +991,17 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 710..719,
targets: [
Tuple(
ExprTuple {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 710..714,
elts: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 710..711,
id: Name("a"),
ctx: Store,
@@ -1009,7 +1009,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 713..714,
id: Name("b"),
ctx: Store,
@@ -1023,7 +1023,7 @@ Module(
],
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 717..719,
id: Name("ab"),
ctx: Load,
@@ -1033,12 +1033,12 @@ Module(
),
Assign(
StmtAssign {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 720..729,
targets: [
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 720..721,
id: Name("a"),
ctx: Store,
@@ -1046,7 +1046,7 @@ Module(
),
Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 724..725,
id: Name("b"),
ctx: Store,
@@ -1055,7 +1055,7 @@ Module(
],
value: Name(
ExprName {
node_index: AtomicNodeIndex(..),
node_index: NodeIndex(None),
range: 728..729,
id: Name("c"),
ctx: Load,