From 80efb01e5d95dcaf00cec493e0060b1102236bee Mon Sep 17 00:00:00 2001
From: Douglas Creager <dcreager@dcreager.net>
Date: Thu, 6 Feb 2025 12:57:47 -0500
Subject: [PATCH] Hide the thread-local buffer better

---
 crates/ruff_metrics/src/json.rs | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/crates/ruff_metrics/src/json.rs b/crates/ruff_metrics/src/json.rs
index f52d03da60..02b150396f 100644
--- a/crates/ruff_metrics/src/json.rs
+++ b/crates/ruff_metrics/src/json.rs
@@ -82,10 +82,6 @@ struct Metric {
     value: AtomicU64,
 }
 
-thread_local! {
-    static BUFFERS: RefCell<String> = RefCell::new(String::new());
-}
-
 impl Metric {
     fn new(key: &Key, dest: Arc<Mutex<dyn Write + Send>>) -> Metric {
         let mut json = Map::default();
@@ -108,6 +104,11 @@ impl Metric {
     where
         F: FnOnce(&mut String),
     {
+        // Render into a thread-local String buffer, and then output the resulting line in a single
+        // call. This ensures that the output from multiple threads does not get intermingled.
+        thread_local! {
+            static BUFFERS: RefCell<String> = RefCell::new(String::new());
+        }
         BUFFERS.with(|buffer| {
             let mut buffer = buffer.borrow_mut();
             buffer.clear();