From 8eb8d2556539c62babaf5e9f7b1a978184174f65 Mon Sep 17 00:00:00 2001 From: Carl Meyer Date: Fri, 29 Aug 2025 11:37:29 -0700 Subject: [PATCH] [ty] add six ecosystem projects to good.txt (#20157) ## Summary These projects all check successfully now. (Pandas still takes 9s, as the comment in `bad.txt` said, but I don't think this is slow enough to exclude it; mypy-primer overall still runs in 4 minutes, faster than e.g. the test suite on Windows.) ## Test Plan mypy-primer CI. --- crates/ty_python_semantic/resources/primer/bad.txt | 7 ------- crates/ty_python_semantic/resources/primer/good.txt | 6 ++++++ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/crates/ty_python_semantic/resources/primer/bad.txt b/crates/ty_python_semantic/resources/primer/bad.txt index 5d17114127..d9da06edd3 100644 --- a/crates/ty_python_semantic/resources/primer/bad.txt +++ b/crates/ty_python_semantic/resources/primer/bad.txt @@ -1,9 +1,6 @@ Tanjun # too many iterations altair # too many iterations (uses packaging) -antidote # hangs / slow (single threaded) -artigraph # cycle panics (value_type_) arviz # too many iterations on versions of arviz newer than https://github.com/arviz-devs/arviz/commit/3205b82bb4d6097c31f7334d7ac51a6de37002d0 -core # cycle panics (value_type_) cpython # too many cycle iterations graphql-core # stack overflow hydpy # too many iterations @@ -12,9 +9,6 @@ jax # too many iterations mypy # too many iterations (self-recursive type alias) nox # too many iterations (uses packaging) packaging # too many iterations -pandas # slow (9s) -pandas-stubs # panics on versions of pandas-stubs newer than https://github.com/pandas-dev/pandas-stubs/commit/bf1221eb7ea0e582c30fe233d1f4f5713fce376b - # Panicked at crates/ty_python_semantic/src/types/type_ordering.rs:207:13 when checking `/tmp/mypy_primer/projects/pandas-stubs/tests/test_indexes.py`: `internal error: entered unreachable code: our type representation does not permit nested unions` pandera # too many iterations pip # vendors packaging, see above pylint # cycle panics (self-recursive type alias) @@ -25,4 +19,3 @@ spack # slow, success, but mypy-primer hangs processing the output spark # too many iterations steam.py # hangs (single threaded) streamlit # too many iterations (uses packaging) -xarray # too many iterations diff --git a/crates/ty_python_semantic/resources/primer/good.txt b/crates/ty_python_semantic/resources/primer/good.txt index c3d283b08b..2c1694edd9 100644 --- a/crates/ty_python_semantic/resources/primer/good.txt +++ b/crates/ty_python_semantic/resources/primer/good.txt @@ -10,8 +10,10 @@ aioredis aiortc alectryon alerta +antidote anyio apprise +artigraph async-utils asynq attrs @@ -27,6 +29,7 @@ cloud-init colour com2ann comtypes +core cwltool dacite dd-trace-py @@ -66,6 +69,8 @@ openlibrary operator optuna paasta +pandas +pandas-stubs paroxython parso pegen @@ -114,6 +119,7 @@ urllib3 vision websockets werkzeug +xarray xarray-dataclasses yarl zipp