From 9cb5ce750e9dead53eb8235e8cfb7cff653a1cd2 Mon Sep 17 00:00:00 2001 From: Micha Reiser Date: Fri, 8 Sep 2023 13:39:50 +0200 Subject: [PATCH] Remove IO based lints from linter benchmark (#7240) --- crates/ruff_benchmark/benches/linter.rs | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/crates/ruff_benchmark/benches/linter.rs b/crates/ruff_benchmark/benches/linter.rs index 950d9cac88..7dbd97209f 100644 --- a/crates/ruff_benchmark/benches/linter.rs +++ b/crates/ruff_benchmark/benches/linter.rs @@ -1,7 +1,8 @@ use ruff::linter::lint_only; +use ruff::settings::rule_table::RuleTable; use ruff::settings::{flags, Settings}; use ruff::source_kind::SourceKind; -use ruff::RuleSelector; +use ruff::{registry::Rule, RuleSelector}; use ruff_benchmark::criterion::{ criterion_group, criterion_main, BenchmarkGroup, BenchmarkId, Criterion, Throughput, }; @@ -78,8 +79,14 @@ fn benchmark_default_rules(criterion: &mut Criterion) { } fn benchmark_all_rules(criterion: &mut Criterion) { + let mut rules: RuleTable = RuleSelector::All.into_iter().collect(); + + // Disable IO based rules because it is a source of flakiness + rules.disable(Rule::ShebangMissingExecutableFile); + rules.disable(Rule::ShebangNotExecutable); + let settings = Settings { - rules: RuleSelector::All.into_iter().collect(), + rules, ..Settings::default() };