[syntax-errors] Invalid syntax in annotations (#17101)
Summary
--
This PR detects the use of invalid syntax in annotation scopes,
including
`yield` and `yield from` expressions and named expressions. I combined a
few
different types of CPython errors here, but I think the resulting error
messages
still make sense and are even preferable to what CPython gives. For
example, we
report `yield expression cannot be used in a type annotation` for both
of these:
```pycon
>>> def f[T](x: (yield 1)): ...
File "<python-input-26>", line 1
def f[T](x: (yield 1)): ...
^^^^^^^
SyntaxError: yield expression cannot be used within the definition of a generic
>>> def foo() -> (yield x): ...
File "<python-input-28>", line 1
def foo() -> (yield x): ...
^^^^^^^
SyntaxError: 'yield' outside function
```
Fixes https://github.com/astral-sh/ruff/issues/11118.
Test Plan
--
New inline tests, along with some updates to existing tests.
This commit is contained in:
@@ -1891,7 +1891,6 @@ impl<'src> Parser<'src> {
|
||||
// test_ok function_def_valid_return_expr
|
||||
// def foo() -> int | str: ...
|
||||
// def foo() -> lambda x: x: ...
|
||||
// def foo() -> (yield x): ...
|
||||
// def foo() -> int if True else str: ...
|
||||
|
||||
// test_err function_def_invalid_return_expr
|
||||
@@ -2986,7 +2985,6 @@ impl<'src> Parser<'src> {
|
||||
// test_ok param_with_annotation
|
||||
// def foo(arg: int): ...
|
||||
// def foo(arg: lambda x: x): ...
|
||||
// def foo(arg: (yield x)): ...
|
||||
// def foo(arg: (x := int)): ...
|
||||
|
||||
// test_err param_with_invalid_annotation
|
||||
|
||||
Reference in New Issue
Block a user