From d8151f0239b509343481efa2db7c7c9d8c2ea2dc Mon Sep 17 00:00:00 2001 From: GiGaGon <107241144+MeGaGiGaGon@users.noreply.github.com> Date: Fri, 1 Aug 2025 05:49:58 -0700 Subject: [PATCH] [`refurb`] Make example error out-of-the-box (`FURB164`) (#19673) ## Summary Part of #18972 This PR makes [unnecessary-from-float (FURB164)](https://docs.astral.sh/ruff/rules/unnecessary-from-float/#unnecessary-from-float-furb164)'s example error out-of-the-box. [Old example](https://play.ruff.rs/807ef72f-9671-408d-87ab-8b8bad65b33f) ```py Decimal.from_float(4.2) Decimal.from_float(float("inf")) Fraction.from_float(4.2) Fraction.from_decimal(Decimal("4.2")) ``` [New example](https://play.ruff.rs/303680d1-8a68-4b6c-a5fd-d79c56eb0f88) ```py from decimal import Decimal from fractions import Fraction Decimal.from_float(4.2) Decimal.from_float(float("inf")) Fraction.from_float(4.2) Fraction.from_decimal(Decimal("4.2")) ``` The "Use instead" section also had imports added, and one of the fixed examples was slightly wrong and needed modification. ## Test Plan N/A, no functionality/tests affected --- .../src/rules/refurb/rules/unnecessary_from_float.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/crates/ruff_linter/src/rules/refurb/rules/unnecessary_from_float.rs b/crates/ruff_linter/src/rules/refurb/rules/unnecessary_from_float.rs index 03986fe1f3..dfa074a55a 100644 --- a/crates/ruff_linter/src/rules/refurb/rules/unnecessary_from_float.rs +++ b/crates/ruff_linter/src/rules/refurb/rules/unnecessary_from_float.rs @@ -26,6 +26,9 @@ use crate::{Applicability, Edit, Fix, FixAvailability, Violation}; /// /// ## Example /// ```python +/// from decimal import Decimal +/// from fractions import Fraction +/// /// Decimal.from_float(4.2) /// Decimal.from_float(float("inf")) /// Fraction.from_float(4.2) @@ -34,10 +37,13 @@ use crate::{Applicability, Edit, Fix, FixAvailability, Violation}; /// /// Use instead: /// ```python +/// from decimal import Decimal +/// from fractions import Fraction +/// /// Decimal(4.2) /// Decimal("inf") /// Fraction(4.2) -/// Fraction(Decimal(4.2)) +/// Fraction(Decimal("4.2")) /// ``` /// /// ## Fix safety