Cyclic0007/ruff
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove escaped mac/windows eol from AST string value (#7724)

Browse Source 
## Summary

This PR fixes the bug where the value of a string node type includes the
escaped mac/windows newline character.

Note that the token value still includes them, it's only removed when
parsing the string content.

## Test Plan

Add new test cases for the string node type to check that the escapes
aren't being included in the string value.

fixes: #7723
This commit is contained in:
Dhruv Manilawala
2023-10-01 07:37:59 +05:30
committed by GitHub
parent 488ec54d21
commit e72d617f4b
4 changed files with 103 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
crates/ruff_python_parser/src/snapshots/ruff_python_parser__string__tests__string_parser_escaped_mac_eol.snap Normal file
View File

@@ -0,0 +1,23 @@
---
source: crates/ruff_python_parser/src/string.rs
expression: parse_ast
---
[
Expr(
StmtExpr {
range: 0..18,
value: Constant(
ExprConstant {
range: 0..18,
value: Str(
StringConstant {
value: "text more text",
unicode: false,
implicit_concatenated: false,
},
),
},
),
},
),
]

23
crates/ruff_python_parser/src/snapshots/ruff_python_parser__string__tests__string_parser_escaped_unix_eol.snap Normal file
View File

@@ -0,0 +1,23 @@
---
source: crates/ruff_python_parser/src/string.rs
expression: parse_ast
---
[
Expr(
StmtExpr {
range: 0..18,
value: Constant(
ExprConstant {
range: 0..18,
value: Str(
StringConstant {
value: "text more text",
unicode: false,
implicit_concatenated: false,
},
),
},
),
},
),
]

23
crates/ruff_python_parser/src/snapshots/ruff_python_parser__string__tests__string_parser_escaped_windows_eol.snap Normal file
View File

@@ -0,0 +1,23 @@
---
source: crates/ruff_python_parser/src/string.rs
expression: parse_ast
---
[
Expr(
StmtExpr {
range: 0..19,
value: Constant(
ExprConstant {
range: 0..19,
value: Str(
StringConstant {
value: "text more text",
unicode: false,
implicit_concatenated: false,
},
),
},
),
},
),
]