c9dff5c7d5
## Summary Garbage collect ASTs once we are done checking a given file. Queries with a cross-file dependency on the AST will reparse the file on demand. This reduces ty's peak memory usage by ~20-30%. The primary change of this PR is adding a `node_index` field to every AST node, that is assigned by the parser. `ParsedModule` can use this to create a flat index of AST nodes any time the file is parsed (or reparsed). This allows `AstNodeRef` to simply index into the current instance of the `ParsedModule`, instead of storing a pointer directly. The indices are somewhat hackily (using an atomic integer) assigned by the `parsed_module` query instead of by the parser directly. Assigning the indices in source-order in the (recursive) parser turns out to be difficult, and collecting the nodes during semantic indexing is impossible as `SemanticIndex` does not hold onto a specific `ParsedModuleRef`, which the pointers in the flat AST are tied to. This means that we have to do an extra AST traversal to assign and collect the nodes into a flat index, but the small performance impact (~3% on cold runs) seems worth it for the memory savings. Part of https://github.com/astral-sh/ty/issues/214.
69 lines
2.0 KiB
Rust
69 lines
2.0 KiB
Rust
use ruff_formatter::{FormatRuleWithOptions, format_args, write};
|
|
use ruff_python_ast::MatchCase;
|
|
|
|
use crate::expression::maybe_parenthesize_expression;
|
|
use crate::expression::parentheses::Parenthesize;
|
|
use crate::pattern::maybe_parenthesize_pattern;
|
|
use crate::prelude::*;
|
|
use crate::statement::clause::{ClauseHeader, clause_body, clause_header};
|
|
use crate::statement::suite::SuiteKind;
|
|
|
|
#[derive(Default)]
|
|
pub struct FormatMatchCase {
|
|
last_suite_in_statement: bool,
|
|
}
|
|
|
|
impl FormatRuleWithOptions<MatchCase, PyFormatContext<'_>> for FormatMatchCase {
|
|
type Options = bool;
|
|
|
|
fn with_options(mut self, options: Self::Options) -> Self {
|
|
self.last_suite_in_statement = options;
|
|
self
|
|
}
|
|
}
|
|
|
|
impl FormatNodeRule<MatchCase> for FormatMatchCase {
|
|
fn fmt_fields(&self, item: &MatchCase, f: &mut PyFormatter) -> FormatResult<()> {
|
|
let MatchCase {
|
|
range: _,
|
|
node_index: _,
|
|
pattern,
|
|
guard,
|
|
body,
|
|
} = item;
|
|
|
|
let comments = f.context().comments().clone();
|
|
let dangling_item_comments = comments.dangling(item);
|
|
|
|
let format_guard = guard.as_deref().map(|guard| {
|
|
format_with(|f| {
|
|
write!(f, [space(), token("if"), space()])?;
|
|
|
|
maybe_parenthesize_expression(guard, item, Parenthesize::IfBreaksParenthesized)
|
|
.fmt(f)
|
|
})
|
|
});
|
|
|
|
write!(
|
|
f,
|
|
[
|
|
clause_header(
|
|
ClauseHeader::MatchCase(item),
|
|
dangling_item_comments,
|
|
&format_args![
|
|
token("case"),
|
|
space(),
|
|
maybe_parenthesize_pattern(pattern, item),
|
|
format_guard
|
|
],
|
|
),
|
|
clause_body(
|
|
body,
|
|
SuiteKind::other(self.last_suite_in_statement),
|
|
dangling_item_comments
|
|
),
|
|
]
|
|
)
|
|
}
|
|
}
|