Cyclic0007/ruff
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
30bec3fcfa01c044ea232aae9d3c69b59f422d30
ruff/crates/ruff_python_formatter/tests/snapshots
History
Micha Reiser 30bec3fcfa Only omit optinal parens if the expression ends or starts with a parenthesized expression 
<!--
Thank you for contributing to Ruff! To help us out with reviewing, please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title?
- Does this pull request include references to any relevant issues?
-->

## Summary

This PR matches Black' behavior where it only omits the optional parentheses if the expression starts or ends with a parenthesized expression:

```python
a + [aaa, bbb, cccc] * c # Don't omit
[aaa, bbb, cccc] + a * c # Split
a + c * [aaa, bbb, ccc] # Split 
```

<!-- What's the purpose of the change? What does it do, and why? -->

## Test Plan

This improves the Jaccard index from 0.945 to 0.946
2023-07-11 17:05:25 +02:00
..
black_compatibility@conditional_expression.py.snap
Format ExprIfExp (ternary operator) (#5597)
2023-07-07 19:11:52 +00:00
black_compatibility@miscellaneous__blackd_diff.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@miscellaneous__debug_visitor.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
black_compatibility@miscellaneous__decorators.py.snap
Format ExpressionStarred nodes (#5654)
2023-07-11 06:08:08 +00:00
black_compatibility@miscellaneous__docstring_no_string_normalization.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@miscellaneous__docstring_preview_no_string_normalization.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@miscellaneous__force_pyi.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
black_compatibility@miscellaneous__long_strings_flag_disabled.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
black_compatibility@miscellaneous__power_op_newline.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@miscellaneous__string_quotes.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@py_36__numeric_literals_skip_underscores.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@py_36__numeric_literals.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@py_37__python37.py.snap
Improve comprehension line break beheavior
2023-07-11 16:51:24 +02:00
black_compatibility@py_38__pep_570.py.snap
Change lambda dummy to NOT_YET_IMPLEMENTED_lambda (#5687)
2023-07-11 13:16:18 +00:00
black_compatibility@py_38__pep_572.py.snap
Change lambda dummy to NOT_YET_IMPLEMENTED_lambda (#5687)
2023-07-11 13:16:18 +00:00
black_compatibility@py_38__python38.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
black_compatibility@py_39__pep_572_py39.py.snap
Format named expressions (walrus operator) (#5642)
2023-07-10 12:32:15 +00:00
black_compatibility@py_39__python39.py.snap
Format named expressions (walrus operator) (#5642)
2023-07-10 12:32:15 +00:00
black_compatibility@py_310__pattern_matching_complex.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@py_310__pattern_matching_extras.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
black_compatibility@py_310__pattern_matching_generic.py.snap
Format StmtAugAssign (#5655)
2023-07-11 09:06:23 +02:00
black_compatibility@py_310__pattern_matching_simple.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@py_310__pattern_matching_style.py.snap
Don't add a magic trailing comma for a single entry (#5463)
2023-07-03 21:48:44 +02:00
black_compatibility@py_310__pep_572_py310.py.snap
Format named expressions (walrus operator) (#5642)
2023-07-10 12:32:15 +00:00
black_compatibility@py_310__remove_newline_after_match.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@py_310__starred_for_target.py.snap
Format ExpressionStarred nodes (#5654)
2023-07-11 06:08:08 +00:00
black_compatibility@simple_cases__attribute_access_on_number_literals.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__bracketmatch.py.snap
Change lambda dummy to NOT_YET_IMPLEMENTED_lambda (#5687)
2023-07-11 13:16:18 +00:00
black_compatibility@simple_cases__class_methods_new_line.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__collections.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
black_compatibility@simple_cases__comment_after_escaped_newline.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__comments2.py.snap
Improve comprehension line break beheavior
2023-07-11 16:51:24 +02:00
black_compatibility@simple_cases__comments4.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
black_compatibility@simple_cases__comments6.py.snap
Format ExpressionStarred nodes (#5654)
2023-07-11 06:08:08 +00:00
black_compatibility@simple_cases__comments9.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__comments_non_breaking_space.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
black_compatibility@simple_cases__composition_no_trailing_comma.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
black_compatibility@simple_cases__composition.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
black_compatibility@simple_cases__docstring_preview.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__docstring.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__empty_lines.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
black_compatibility@simple_cases__expression.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
black_compatibility@simple_cases__fmtonoff2.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
black_compatibility@simple_cases__fmtonoff3.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__fmtonoff4.py.snap
Don't add a magic trailing comma for a single entry (#5463)
2023-07-03 21:48:44 +02:00
black_compatibility@simple_cases__fmtonoff5.py.snap
Don't add a magic trailing comma for a single entry (#5463)
2023-07-03 21:48:44 +02:00
black_compatibility@simple_cases__fmtonoff.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
black_compatibility@simple_cases__fmtskip2.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__fmtskip3.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__fmtskip5.py.snap
Improve comprehension line break beheavior
2023-07-11 16:51:24 +02:00
black_compatibility@simple_cases__fmtskip7.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__fmtskip8.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__fmtskip.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__fstring.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__function2.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
black_compatibility@simple_cases__function.py.snap
Improve comprehension line break beheavior
2023-07-11 16:51:24 +02:00
black_compatibility@simple_cases__import_spacing.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
black_compatibility@simple_cases__power_op_spacing.py.snap
Improve comprehension line break beheavior
2023-07-11 16:51:24 +02:00
black_compatibility@simple_cases__remove_await_parens.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
black_compatibility@simple_cases__remove_except_parens.py.snap
Format raise statement (#5595)
2023-07-10 21:23:49 +02:00
black_compatibility@simple_cases__remove_for_brackets.py.snap
Change lambda dummy to NOT_YET_IMPLEMENTED_lambda (#5687)
2023-07-11 13:16:18 +00:00
black_compatibility@simple_cases__remove_newline_after_code_block_open.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
black_compatibility@simple_cases__remove_parens.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__return_annotation_brackets.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
black_compatibility@simple_cases__slices.py.snap
Change lambda dummy to NOT_YET_IMPLEMENTED_lambda (#5687)
2023-07-11 13:16:18 +00:00
black_compatibility@simple_cases__string_prefixes.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__torture.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
black_compatibility@simple_cases__trailing_comma_optional_parens3.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
black_compatibility@simple_cases__trailing_commas_in_leading_parts.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
black_compatibility@simple_cases__tupleassign.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
black_compatibility@simple_cases__whitespace.py.snap
Update Black tests (#5438)
2023-06-30 06:32:50 +00:00
format@carriage_return__string.py.snap
Normalize '\r' in string literals to '\n'
2023-06-30 10:13:23 +02:00
format@expression__annotated_assign.py.snap
Format target: annotation = value? expressions (#5661)
2023-07-11 16:40:28 +02:00
format@expression__attribute.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
format@expression__binary.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
format@expression__boolean_operation.py.snap
Format call expressions (without call chaining) (#5341)
2023-06-27 09:29:40 +00:00
format@expression__call.py.snap
Improve comprehension line break beheavior
2023-07-11 16:51:24 +02:00
format@expression__compare.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
format@expression__dict.py.snap
Fix typos found by codespell (#5607)
2023-07-08 12:33:18 +02:00
format@expression__if.py.snap
Fix find_only_token_in_range with expression parentheses (#5645)
2023-07-10 15:55:19 +02:00
format@expression__list_comp.py.snap
Improve comprehension line break beheavior
2023-07-11 16:51:24 +02:00
format@expression__list.py.snap
Don't add a magic trailing comma for a single entry (#5463)
2023-07-03 21:48:44 +02:00
format@expression__named_expr.py.snap
Format named expressions (walrus operator) (#5642)
2023-07-10 12:32:15 +00:00
format@expression__slice.py.snap
Format call expressions (without call chaining) (#5341)
2023-06-27 09:29:40 +00:00
format@expression__starred.py.snap
Format ExpressionStarred nodes (#5654)
2023-07-11 06:08:08 +00:00
format@expression__string.py.snap
Fix typos found by codespell (#5607)
2023-07-08 12:33:18 +02:00
format@expression__tuple.py.snap
Format raise statement (#5595)
2023-07-10 21:23:49 +02:00
format@expression__unary.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
format@skip_magic_trailing_comma.py.snap
Fix typos found by codespell (#5607)
2023-07-08 12:33:18 +02:00
format@statement__ann_assign.py.snap
Format StmtAugAssign (#5655)
2023-07-11 09:06:23 +02:00
format@statement__assign.py.snap
Add tests for skip magic trailing comma
2023-06-26 14:15:55 +02:00
format@statement__break.py.snap
Add tests for skip magic trailing comma
2023-06-26 14:15:55 +02:00
format@statement__class_definition.py.snap
Fix invalid syntax for binary expression in unary op (#5370)
2023-06-29 08:09:26 +02:00
format@statement__delete.py.snap
Format delete statement (#5169)
2023-07-11 08:36:26 +02:00
format@statement__for.py.snap
Add tests for skip magic trailing comma
2023-06-26 14:15:55 +02:00
format@statement__function.py.snap
Add tests for skip magic trailing comma
2023-06-26 14:15:55 +02:00
format@statement__if.py.snap
Add tests for skip magic trailing comma
2023-06-26 14:15:55 +02:00
format@statement__import_from.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
format@statement__import.py.snap
Format import statements (#5493)
2023-07-04 07:07:20 +00:00
format@statement__raise.py.snap
Prefer expanding parenthesized expressions before operands
2023-07-11 14:07:39 +02:00
format@statement__try.py.snap
Fix formatter StmtTry test (#5568)
2023-07-06 18:23:53 +00:00
format@statement__while.py.snap
Format call expressions (without call chaining) (#5341)
2023-06-27 09:29:40 +00:00
format@statement__with.py.snap
Format ExpressionStarred nodes (#5654)
2023-07-11 06:08:08 +00:00
format@trivia.py.snap
Add tests for skip magic trailing comma
2023-06-26 14:15:55 +02:00