678b0c2d39
## Summary This PR generalize the idea that we may want to emit diagnostics for invalid or incompatible configuration values similar to how we already do it for `rules`. This PR introduces a new `Settings` struct that is similar to `Options` but, unlike `Options`, are fields have their default values filled in and they use a representation optimized for reads. The diagnostics created during loading the `Settings` are stored on the `Project` so that we can emit them when calling `check`. The motivation for this work is that it simplifies adding new settings. That's also why I went ahead and added the `terminal.error-on-warning` setting to demonstrate how new settings are added. ## Test Plan Existing tests, new CLI test.
95 lines
2.3 KiB
Rust
95 lines
2.3 KiB
Rust
use anyhow::Result;
|
|
use std::sync::Arc;
|
|
use zip::CompressionMethod;
|
|
|
|
use red_knot_python_semantic::lint::{LintRegistry, RuleSelection};
|
|
use red_knot_python_semantic::{
|
|
default_lint_registry, Db, Program, ProgramSettings, PythonPlatform, PythonVersion,
|
|
SearchPathSettings,
|
|
};
|
|
use ruff_db::files::{File, Files};
|
|
use ruff_db::system::{OsSystem, System, SystemPathBuf};
|
|
use ruff_db::vendored::{VendoredFileSystem, VendoredFileSystemBuilder};
|
|
use ruff_db::{Db as SourceDb, Upcast};
|
|
|
|
static EMPTY_VENDORED: std::sync::LazyLock<VendoredFileSystem> = std::sync::LazyLock::new(|| {
|
|
let mut builder = VendoredFileSystemBuilder::new(CompressionMethod::Stored);
|
|
builder.add_file("stdlib/VERSIONS", "\n").unwrap();
|
|
builder.finish().unwrap()
|
|
});
|
|
|
|
#[salsa::db]
|
|
#[derive(Default, Clone)]
|
|
pub struct ModuleDb {
|
|
storage: salsa::Storage<Self>,
|
|
files: Files,
|
|
system: OsSystem,
|
|
rule_selection: Arc<RuleSelection>,
|
|
}
|
|
|
|
impl ModuleDb {
|
|
/// Initialize a [`ModuleDb`] from the given source root.
|
|
pub fn from_src_roots(
|
|
src_roots: Vec<SystemPathBuf>,
|
|
python_version: PythonVersion,
|
|
) -> Result<Self> {
|
|
let search_paths = SearchPathSettings::new(src_roots);
|
|
|
|
let db = Self::default();
|
|
Program::from_settings(
|
|
&db,
|
|
ProgramSettings {
|
|
python_version,
|
|
python_platform: PythonPlatform::default(),
|
|
search_paths,
|
|
},
|
|
)?;
|
|
|
|
Ok(db)
|
|
}
|
|
}
|
|
|
|
impl Upcast<dyn SourceDb> for ModuleDb {
|
|
fn upcast(&self) -> &(dyn SourceDb + 'static) {
|
|
self
|
|
}
|
|
fn upcast_mut(&mut self) -> &mut (dyn SourceDb + 'static) {
|
|
self
|
|
}
|
|
}
|
|
|
|
#[salsa::db]
|
|
impl SourceDb for ModuleDb {
|
|
fn vendored(&self) -> &VendoredFileSystem {
|
|
&EMPTY_VENDORED
|
|
}
|
|
|
|
fn system(&self) -> &dyn System {
|
|
&self.system
|
|
}
|
|
|
|
fn files(&self) -> &Files {
|
|
&self.files
|
|
}
|
|
}
|
|
|
|
#[salsa::db]
|
|
impl Db for ModuleDb {
|
|
fn is_file_open(&self, file: File) -> bool {
|
|
!file.path(self).is_vendored_path()
|
|
}
|
|
|
|
fn rule_selection(&self) -> Arc<RuleSelection> {
|
|
self.rule_selection.clone()
|
|
}
|
|
|
|
fn lint_registry(&self) -> &LintRegistry {
|
|
default_lint_registry()
|
|
}
|
|
}
|
|
|
|
#[salsa::db]
|
|
impl salsa::Database for ModuleDb {
|
|
fn salsa_event(&self, _event: &dyn Fn() -> salsa::Event) {}
|
|
}
|