c9dff5c7d5
## Summary Garbage collect ASTs once we are done checking a given file. Queries with a cross-file dependency on the AST will reparse the file on demand. This reduces ty's peak memory usage by ~20-30%. The primary change of this PR is adding a `node_index` field to every AST node, that is assigned by the parser. `ParsedModule` can use this to create a flat index of AST nodes any time the file is parsed (or reparsed). This allows `AstNodeRef` to simply index into the current instance of the `ParsedModule`, instead of storing a pointer directly. The indices are somewhat hackily (using an atomic integer) assigned by the `parsed_module` query instead of by the parser directly. Assigning the indices in source-order in the (recursive) parser turns out to be difficult, and collecting the nodes during semantic indexing is impossible as `SemanticIndex` does not hold onto a specific `ParsedModuleRef`, which the pointers in the flat AST are tied to. This means that we have to do an extra AST traversal to assign and collect the nodes into a flat index, but the small performance impact (~3% on cold runs) seems worth it for the memory savings. Part of https://github.com/astral-sh/ty/issues/214.
55 lines
1.4 KiB
Rust
55 lines
1.4 KiB
Rust
use ruff_formatter::write;
|
|
use ruff_python_ast::StmtRaise;
|
|
|
|
use crate::comments::SourceComment;
|
|
use crate::expression::maybe_parenthesize_expression;
|
|
use crate::expression::parentheses::Parenthesize;
|
|
use crate::{has_skip_comment, prelude::*};
|
|
|
|
#[derive(Default)]
|
|
pub struct FormatStmtRaise;
|
|
|
|
impl FormatNodeRule<StmtRaise> for FormatStmtRaise {
|
|
fn fmt_fields(&self, item: &StmtRaise, f: &mut PyFormatter) -> FormatResult<()> {
|
|
let StmtRaise {
|
|
range: _,
|
|
node_index: _,
|
|
exc,
|
|
cause,
|
|
} = item;
|
|
|
|
token("raise").fmt(f)?;
|
|
|
|
if let Some(value) = exc {
|
|
write!(
|
|
f,
|
|
[
|
|
space(),
|
|
maybe_parenthesize_expression(value, item, Parenthesize::Optional)
|
|
]
|
|
)?;
|
|
}
|
|
|
|
if let Some(value) = cause {
|
|
write!(
|
|
f,
|
|
[
|
|
space(),
|
|
token("from"),
|
|
space(),
|
|
maybe_parenthesize_expression(value, item, Parenthesize::Optional)
|
|
]
|
|
)?;
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
fn is_suppressed(
|
|
&self,
|
|
trailing_comments: &[SourceComment],
|
|
context: &PyFormatContext,
|
|
) -> bool {
|
|
has_skip_comment(trailing_comments, context.source())
|
|
}
|
|
}
|