konstin
d4cfe1f2a7
Break before slice colon
**Summary** Break slices at the colon first, since the colon is separator with the lowest precedence and we're in a parenthesized context.
**Input**
```python
section_header_data = byte_array[byte_begin_index + byte_step_index * event_index : byte_begin_index + byte_step_index * (event_index + 1)]
```
**Black**
```python
section_header_data = byte_array[
byte_begin_index
+ byte_step_index * event_index : byte_begin_index
+ byte_step_index * (event_index + 1)
]
```
**Current formatting**
```python
section_header_data = byte_array[
byte_begin_index + byte_step_index * event_index : byte_begin_index
+ byte_step_index * (event_index + 1)
]
```
**Proposed formatting**
```python
section_header_data = byte_array[
byte_begin_index + byte_step_index * event_index
: byte_begin_index + byte_step_index * (event_index + 1)
]
```
This is another intentional black deviation, but i find it a clear style improvement.
This is consistent with adding a step:
```python
section_header_data2 = byte_array[
byte_begin_index + byte_step_index * event_index
: byte_begin_index + byte_step_index
: section_size
]
```
As-is, this regresses trailing colon comments:
**in**
```python
c1 = "c"[
1: # e
# f
2
]
```
**out**
```python
c1 = "c"[
1
: # e
# f
2
]
```
Fixes #7316
**Test Plan** Added the fixtures above.
2023-09-13 12:11:53 +02:00
..
2023-09-12 12:00:11 -04:00
2023-09-13 08:45:46 +00:00
2023-09-11 14:09:33 -05:00
2023-08-08 16:51:37 -04:00
2023-09-12 12:00:11 -04:00
2023-09-11 18:08:00 -05:00
2023-09-01 13:56:44 +00:00
2023-09-08 06:51:26 +00:00
2023-07-04 14:27:23 +00:00
2023-09-11 12:28:39 -05:00
2023-09-12 18:29:03 +05:30
2023-09-13 09:01:49 +00:00
2023-09-13 08:45:46 +00:00
2023-09-13 12:11:53 +02:00
2023-08-27 14:12:51 -04:00
2023-08-25 17:42:57 +00:00
2023-09-11 19:12:46 +00:00
2023-08-01 19:29:42 +02:00
2023-08-29 14:45:09 -04:00
2023-09-07 08:19:25 +00:00
2023-09-07 08:19:25 +00:00
2023-08-27 14:12:51 -04:00
2023-09-11 15:09:47 +02:00
2023-08-28 06:44:56 +00:00
2023-09-08 06:51:26 +00:00
2023-09-11 12:28:39 -05:00