e017b039df
<!-- Thank you for contributing to Ruff/ty! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? (Please prefix with `[ty]` for ty pull requests.) - Does this pull request include references to any relevant issues? --> ## Summary Resolves https://github.com/astral-sh/ty/issues/1464 We sort the completions before we add the unimported ones, meaning that imported completions show up before unimported ones. This is also spoken about in https://github.com/astral-sh/ty/issues/1274, and this is probably a duplicate of that. @AlexWaygood mentions this [here](https://github.com/astral-sh/ty/issues/1274#issuecomment-3345942698) too. ## Test Plan Add a test showing even if an unimported completion "should" (alphabetically before) come first, we favor the imported one.
1009 B
1009 B
| 1 | name | file | index | rank |
|---|---|---|---|---|
| 2 | auto-import-skips-current-module | main.py | 0 | 1 |
| 3 | fstring-completions | main.py | 0 | 1 |
| 4 | higher-level-symbols-preferred | main.py | 0 | |
| 5 | higher-level-symbols-preferred | main.py | 1 | 1 |
| 6 | import-deprioritizes-dunder | main.py | 0 | 1 |
| 7 | import-deprioritizes-sunder | main.py | 0 | 1 |
| 8 | import-deprioritizes-type_check_only | main.py | 0 | 1 |
| 9 | import-deprioritizes-type_check_only | main.py | 1 | 1 |
| 10 | import-deprioritizes-type_check_only | main.py | 2 | 1 |
| 11 | import-deprioritizes-type_check_only | main.py | 3 | 2 |
| 12 | import-deprioritizes-type_check_only | main.py | 4 | 3 |
| 13 | internal-typeshed-hidden | main.py | 0 | 5 |
| 14 | none-completion | main.py | 0 | 11 |
| 15 | numpy-array | main.py | 0 | |
| 16 | numpy-array | main.py | 1 | 1 |
| 17 | object-attr-instance-methods | main.py | 0 | 1 |
| 18 | object-attr-instance-methods | main.py | 1 | 1 |
| 19 | raise-uses-base-exception | main.py | 0 | 2 |
| 20 | scope-existing-over-new-import | main.py | 0 | 13 |
| 21 | scope-prioritize-closer | main.py | 0 | 2 |
| 22 | scope-simple-long-identifier | main.py | 0 | 1 |
| 23 | tstring-completions | main.py | 0 | 1 |
| 24 | ty-extensions-lower-stdlib | main.py | 0 | 8 |
| 25 | type-var-typing-over-ast | main.py | 0 | 3 |
| 26 | type-var-typing-over-ast | main.py | 1 | 277 |