Cyclic0007/wolfssl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #9646 from rlm2002/coverity

Browse Source 
20260112 Coverity: update macros and add length checks
This commit is contained in:
Sean Parkinson
2026-01-16 09:20:01 +10:00
committed by GitHub
parent 16e45f94ae b4344c17cc
commit fabe0c090a
4 changed files with 58 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/tls.c
View File

@@ -6972,8 +6972,10 @@ int TLSX_SupportedVersions_Parse(const WOLFSSL* ssl, const byte* input,
int set = 0;
/* Must contain a length and at least one version. */
if (length < OPAQUE8_LEN + OPAQUE16_LEN || (length & 1) != 1)
if (length < OPAQUE8_LEN + OPAQUE16_LEN || (length & 1) != 1
|| length > MAX_SV_EXT_LEN) {
return BUFFER_ERROR;
}
len = *input;
@@ -9963,10 +9965,13 @@ int TLSX_KeyShare_Parse_ClientHello(const WOLFSSL* ssl,
if (length < OPAQUE16_LEN)
return BUFFER_ERROR;
/* ClientHello contains zero or more key share entries. */
/* ClientHello contains zero or more key share entries. Limits extension
* length to 2^16-1 and subtracting 4 bytes for header size per RFC 8446 */
ato16(input, &len);
if (len != length - OPAQUE16_LEN)
if ((len != length - OPAQUE16_LEN) ||
length > (MAX_EXT_DATA_LEN - HELLO_EXT_SZ)) {
return BUFFER_ERROR;
}
offset += OPAQUE16_LEN;
while (offset < (int)length) {