Cyclic0007/ruff
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix PR comments

Browse Source
This commit is contained in:
Ankit Chaurasia
2025-01-15 12:20:02 +05:45
committed by Wei Lee
parent 9b9540c3cd
commit 8a7ec4c0a3
2 changed files with 363 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
crates/ruff_linter/src/rules/airflow/rules/removal_in_3.rs
View File

@@ -319,18 +319,15 @@ fn check_class_attribute(checker: &mut Checker, attribute_expr: &ExprAttribute)
/// print("access invalid key", context.get("conf"))
/// ```
fn check_context_get(checker: &mut Checker, call_expr: &ExprCall) {
if is_task_context_referenced(checker, &call_expr.func) {
return;
}
add_context_diagnostics(checker, &call_expr.func);
let Expr::Attribute(ExprAttribute { value, attr, .. }) = &*call_expr.func else {
return;
};
if !value
.as_name_expr()
.is_some_and(|name| matches!(name.id.as_str(), "context" | "kwargs"))
{
if !value.as_name_expr().is_some_and(|name| {
matches!(name.id.as_str(), "context" | "kwargs") || name.id.as_str().starts_with("**")
}) {
return;
}
@@ -961,33 +958,45 @@ fn is_airflow_builtin_or_provider(segments: &[&str], module: &str, symbol_suffix
}
}
fn is_task_context_referenced(checker: &mut Checker, expr: &Expr) -> bool {
fn uses_removed_context_keys(checker: &mut Checker) -> bool {
let parents: Vec<_> = checker.semantic().current_statements().collect();
for stmt in parents {
if let Stmt::FunctionDef(function_def) = stmt {
if is_decorated_with(checker, function_def) {
let arguments = extract_task_function_arguments(function_def);
let Stmt::FunctionDef(function_def) = stmt else {
continue;
};
for deprecated_arg in REMOVED_CONTEXT_KEYS {
if arguments.contains(&deprecated_arg.to_string()) {
checker.diagnostics.push(Diagnostic::new(
Airflow3Removal {
deprecated: deprecated_arg.to_string(),
replacement: Replacement::None,
},
expr.range(),
));
return true;
}
}
}
if !has_task_decorator(checker, function_def) {
continue;
}
let arguments = extract_task_function_arguments(function_def);
if arguments
.iter()
.any(|arg| REMOVED_CONTEXT_KEYS.contains(&arg.as_str()))
{
return true;
}
}
false
}
fn add_context_diagnostics(checker: &mut Checker, expr: &Expr) {
if uses_removed_context_keys(checker) {
for removed_key in REMOVED_CONTEXT_KEYS {
checker.diagnostics.push(Diagnostic::new(
Airflow3Removal {
deprecated: removed_key.to_string(),
replacement: Replacement::None,
},
expr.range(),
));
}
}
}
fn extract_task_function_arguments(stmt: &StmtFunctionDef) -> Vec<String> {
let mut arguments = Vec::new();
@@ -1002,7 +1011,7 @@ fn extract_task_function_arguments(stmt: &StmtFunctionDef) -> Vec<String> {
arguments
}
fn is_decorated_with(checker: &mut Checker, stmt: &StmtFunctionDef) -> bool {
fn has_task_decorator(checker: &mut Checker, stmt: &StmtFunctionDef) -> bool {
stmt.decorator_list.iter().any(|decorator| {
checker
.semantic()

329
crates/ruff_linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR302_AIR302_context.py.snap
View File

@@ -404,6 +404,15 @@ AIR302_context.py:111:39: AIR302 `yesterday_ds_nodash` is removed in Airflow 3.0
113 | @task
|
AIR302_context.py:115:5: AIR302 `conf` is removed in Airflow 3.0
|
113 | @task
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
| ^^^^^ AIR302
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:115:5: AIR302 `execution_date` is removed in Airflow 3.0
|
113 | @task
@@ -413,6 +422,106 @@ AIR302_context.py:115:5: AIR302 `execution_date` is removed in Airflow 3.0
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:115:5: AIR302 `next_ds` is removed in Airflow 3.0
|
113 | @task
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
| ^^^^^ AIR302
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:115:5: AIR302 `next_ds_nodash` is removed in Airflow 3.0
|
113 | @task
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
| ^^^^^ AIR302
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:115:5: AIR302 `next_execution_date` is removed in Airflow 3.0
|
113 | @task
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
| ^^^^^ AIR302
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:115:5: AIR302 `prev_ds` is removed in Airflow 3.0
|
113 | @task
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
| ^^^^^ AIR302
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:115:5: AIR302 `prev_ds_nodash` is removed in Airflow 3.0
|
113 | @task
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
| ^^^^^ AIR302
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:115:5: AIR302 `prev_execution_date` is removed in Airflow 3.0
|
113 | @task
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
| ^^^^^ AIR302
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:115:5: AIR302 `prev_execution_date_success` is removed in Airflow 3.0
|
113 | @task
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
| ^^^^^ AIR302
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:115:5: AIR302 `tomorrow_ds` is removed in Airflow 3.0
|
113 | @task
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
| ^^^^^ AIR302
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:115:5: AIR302 `yesterday_ds` is removed in Airflow 3.0
|
113 | @task
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
| ^^^^^ AIR302
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:115:5: AIR302 `yesterday_ds_nodash` is removed in Airflow 3.0
|
113 | @task
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
| ^^^^^ AIR302
116 | print("access invalid key", context.get("conf"))
|
AIR302_context.py:116:5: AIR302 `conf` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:5: AIR302 `execution_date` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
@@ -423,6 +532,116 @@ AIR302_context.py:116:5: AIR302 `execution_date` is removed in Airflow 3.0
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:5: AIR302 `next_ds` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:5: AIR302 `next_ds_nodash` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:5: AIR302 `next_execution_date` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:5: AIR302 `prev_ds` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:5: AIR302 `prev_ds_nodash` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:5: AIR302 `prev_execution_date` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:5: AIR302 `prev_execution_date_success` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:5: AIR302 `tomorrow_ds` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:5: AIR302 `yesterday_ds` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:5: AIR302 `yesterday_ds_nodash` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `conf` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `execution_date` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
@@ -433,6 +652,116 @@ AIR302_context.py:116:33: AIR302 `execution_date` is removed in Airflow 3.0
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `next_ds` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `next_ds_nodash` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `next_execution_date` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `prev_ds` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `prev_ds_nodash` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `prev_execution_date` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `prev_execution_date_success` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `tomorrow_ds` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `yesterday_ds` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:33: AIR302 `yesterday_ds_nodash` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:116:45: AIR302 `conf` is removed in Airflow 3.0
|
114 | def access_invalid_argument_task_out_of_dag(execution_date, **context):
115 | print("execution date", execution_date)
116 | print("access invalid key", context.get("conf"))
| ^^^^^^ AIR302
117 |
118 | @task(task_id="print_the_context")
|
AIR302_context.py:122:22: AIR302 `conf` is removed in Airflow 3.0
|
120 | """Print the Airflow context and ds variable from the context."""