Approximate SemanticIndex hash maps

.github/actionlint.yaml

@@ -1,9 +0,0 @@
-# Configuration for the actionlint tool, which we run via pre-commit
-# to verify the correctness of the syntax in our GitHub Actions workflows.
-
-self-hosted-runner:
-  # Various runners we use that aren't recognized out-of-the-box by actionlint:
-  labels:
-    - depot-ubuntu-latest-8
-    - depot-ubuntu-22.04-16
-    - windows-latest-xlarge

.github/renovate.json5

@@ -45,7 +45,7 @@
       groupName: "Artifact GitHub Actions dependencies",
       matchManagers: ["github-actions"],
       matchDatasources: ["gitea-tags", "github-tags"],
-      matchPackageNames: ["actions/.*-artifact"],
+      matchPackagePatterns: ["actions/.*-artifact"],
       description: "Weekly update of artifact-related GitHub Actions dependencies",
     },
     {
@@ -61,7 +61,7 @@
     {
       // Disable updates of `zip-rs`; intentionally pinned for now due to ownership change
       // See: https://github.com/astral-sh/uv/issues/3642
-      matchPackageNames: ["zip"],
+      matchPackagePatterns: ["zip"],
       matchManagers: ["cargo"],
       enabled: false,
     },
@@ -70,7 +70,7 @@
       // with `mkdocs-material-insider`.
       // See: https://squidfunk.github.io/mkdocs-material/insiders/upgrade/
       matchManagers: ["pip_requirements"],
-      matchPackageNames: ["mkdocs-material"],
+      matchPackagePatterns: ["mkdocs-material"],
       enabled: false,
     },
     {
@@ -87,13 +87,13 @@
     {
       groupName: "Monaco",
       matchManagers: ["npm"],
-      matchPackageNames: ["monaco"],
+      matchPackagePatterns: ["monaco"],
       description: "Weekly update of the Monaco editor",
     },
     {
       groupName: "strum",
       matchManagers: ["cargo"],
-      matchPackageNames: ["strum"],
+      matchPackagePatterns: ["strum"],
       description: "Weekly update of strum dependencies",
     },
     {

.github/workflows/build-binaries.yml

@@ -53,7 +53,7 @@ jobs:
           args: --out dist
       - name: "Test sdist"
         run: |
-          pip install dist/"${PACKAGE_NAME}"-*.tar.gz --force-reinstall
+          pip install dist/${PACKAGE_NAME}-*.tar.gz --force-reinstall
           "${MODULE_NAME}" --help
           python -m "${MODULE_NAME}" --help
       - name: "Upload sdist"
@@ -125,7 +125,7 @@ jobs:
           args: --release --locked --out dist
       - name: "Test wheel - aarch64"
         run: |
-          pip install dist/"${PACKAGE_NAME}"-*.whl --force-reinstall
+          pip install dist/${PACKAGE_NAME}-*.whl --force-reinstall
           ruff --help
           python -m ruff --help
       - name: "Upload wheels"
@@ -186,7 +186,7 @@ jobs:
         if: ${{ !startsWith(matrix.platform.target, 'aarch64') }}
         shell: bash
         run: |
-          python -m pip install dist/"${PACKAGE_NAME}"-*.whl --force-reinstall
+          python -m pip install dist/${PACKAGE_NAME}-*.whl --force-reinstall
           "${MODULE_NAME}" --help
           python -m "${MODULE_NAME}" --help
       - name: "Upload wheels"
@@ -236,7 +236,7 @@ jobs:
       - name: "Test wheel"
         if: ${{ startsWith(matrix.target, 'x86_64') }}
         run: |
-          pip install dist/"${PACKAGE_NAME}"-*.whl --force-reinstall
+          pip install dist/${PACKAGE_NAME}-*.whl --force-reinstall
           "${MODULE_NAME}" --help
           python -m "${MODULE_NAME}" --help
       - name: "Upload wheels"

.github/workflows/build-docker.yml

@@ -48,13 +48,11 @@ jobs:
 
       - name: Check tag consistency
         if: ${{ inputs.plan != '' && !fromJson(inputs.plan).announcement_tag_is_implicit }}
-        env:
-          TAG: ${{ inputs.plan != '' && fromJson(inputs.plan).announcement_tag || 'dry-run' }}
         run: |
           version=$(grep "version = " pyproject.toml | sed -e 's/version = "\(.*\)"/\1/g')
-          if [ "${TAG}" != "${version}" ]; then
+          if [ "${{ fromJson(inputs.plan).announcement_tag }}" != "${version}" ]; then
             echo "The input tag does not match the version from pyproject.toml:" >&2
-            echo "${TAG}" >&2
+            echo "${{ fromJson(inputs.plan).announcement_tag }}" >&2
             echo "${version}" >&2
             exit 1
           else
@@ -144,7 +142,6 @@ jobs:
         # The printf will expand the base image with the `<RUFF_BASE_IMG>@sha256:<sha256> ...` for each sha256 in the directory
         # The final command becomes `docker buildx imagetools create -t tag1 -t tag2 ... <RUFF_BASE_IMG>@sha256:<sha256_1> <RUFF_BASE_IMG>@sha256:<sha256_2> ...`
         run: |
-          # shellcheck disable=SC2046
           docker buildx imagetools create \
             $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \
             $(printf "${RUFF_BASE_IMG}@sha256:%s " *)
@@ -177,8 +174,6 @@ jobs:
 
       - name: Generate Dynamic Dockerfile Tags
         shell: bash
-        env:
-          TAG_VALUE: ${{ fromJson(inputs.plan).announcement_tag }}
         run: |
           set -euo pipefail
 
@@ -199,8 +194,8 @@ jobs:
           # Loop through all base tags and append its docker metadata pattern to the list
           # Order is on purpose such that the label org.opencontainers.image.version has the first pattern with the full version
           IFS=','; for TAG in ${BASE_TAGS}; do
-            TAG_PATTERNS="${TAG_PATTERNS}type=pep440,pattern={{ version }},suffix=-${TAG},value=${TAG_VALUE}\n"
-            TAG_PATTERNS="${TAG_PATTERNS}type=pep440,pattern={{ major }}.{{ minor }},suffix=-${TAG},value=${TAG_VALUE}\n"
+            TAG_PATTERNS="${TAG_PATTERNS}type=pep440,pattern={{ version }},suffix=-${TAG},value=${{ fromJson(inputs.plan).announcement_tag }}\n"
+            TAG_PATTERNS="${TAG_PATTERNS}type=pep440,pattern={{ major }}.{{ minor }},suffix=-${TAG},value=${{ fromJson(inputs.plan).announcement_tag }}\n"
             TAG_PATTERNS="${TAG_PATTERNS}type=raw,value=${TAG}\n"
           done
 
@@ -291,8 +286,6 @@ jobs:
         # The final command becomes `docker buildx imagetools create -t tag1 -t tag2 ... <RUFF_BASE_IMG>@sha256:<sha256_1> <RUFF_BASE_IMG>@sha256:<sha256_2> ...`
         run: |
           readarray -t lines <<< "$DOCKER_METADATA_OUTPUT_ANNOTATIONS"; annotations=(); for line in "${lines[@]}"; do annotations+=(--annotation "$line"); done
-
-          # shellcheck disable=SC2046
           docker buildx imagetools create \
             "${annotations[@]}" \
             $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \

.github/workflows/ci.yaml

@@ -290,9 +290,7 @@ jobs:
           file: "Cargo.toml"
           field: "workspace.package.rust-version"
       - name: "Install Rust toolchain"
-        env:
-          MSRV: ${{ steps.msrv.outputs.value }}
-        run: rustup default "${MSRV}"
+        run: rustup default ${{ steps.msrv.outputs.value }}
       - name: "Install mold"
         uses: rui314/setup-mold@v1
       - name: "Install cargo nextest"
@@ -308,8 +306,7 @@ jobs:
         shell: bash
         env:
           NEXTEST_PROFILE: "ci"
-          MSRV: ${{ steps.msrv.outputs.value }}
-        run: cargo "+${MSRV}" insta test --all-features --unreferenced reject --test-runner nextest
+        run: cargo +${{ steps.msrv.outputs.value }} insta test --all-features --unreferenced reject --test-runner nextest
 
   cargo-fuzz-build:
     name: "cargo fuzz build"
@@ -349,7 +346,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           persist-credentials: false
-      - uses: astral-sh/setup-uv@v5
+      - uses: astral-sh/setup-uv@v4
       - uses: actions/download-artifact@v4
         name: Download Ruff binary to test
         id: download-cached-binary
@@ -357,18 +354,16 @@ jobs:
           name: ruff
           path: ruff-to-test
       - name: Fuzz
-        env:
-          DOWNLOAD_PATH: ${{ steps.download-cached-binary.outputs.download-path }}
         run: |
           # Make executable, since artifact download doesn't preserve this
-          chmod +x "${DOWNLOAD_PATH}/ruff"
+          chmod +x ${{ steps.download-cached-binary.outputs.download-path }}/ruff
 
           (
             uvx \
-            --python="${PYTHON_VERSION}" \
+            --python=${{ env.PYTHON_VERSION }} \
             --from=./python/py-fuzzer \
             fuzz \
-            --test-executable="${DOWNLOAD_PATH}/ruff" \
+            --test-executable=${{ steps.download-cached-binary.outputs.download-path }}/ruff \
             --bin=ruff \
             0-500
           )
@@ -386,7 +381,7 @@ jobs:
       - name: "Install Rust toolchain"
         run: rustup component add rustfmt
       - uses: Swatinem/rust-cache@v2
-      - run: ./scripts/add_rule.py --name DoTheThing --prefix F --code 999 --linter pyflakes
+      - run: ./scripts/add_rule.py --name DoTheThing --prefix PL --code C0999 --linter pylint
       - run: cargo check
       - run: cargo fmt --all --check
       - run: |
@@ -434,72 +429,64 @@ jobs:
 
       - name: Run `ruff check` stable ecosystem check
         if: ${{ needs.determine_changes.outputs.linter == 'true' }}
-        env:
-          DOWNLOAD_PATH: ${{ steps.ruff-target.outputs.download-path }}
         run: |
           # Make executable, since artifact download doesn't preserve this
-          chmod +x ./ruff "${DOWNLOAD_PATH}/ruff"
+          chmod +x ./ruff ${{ steps.ruff-target.outputs.download-path }}/ruff
 
           # Set pipefail to avoid hiding errors with tee
           set -eo pipefail
 
-          ruff-ecosystem check ./ruff "${DOWNLOAD_PATH}/ruff" --cache ./checkouts --output-format markdown | tee ecosystem-result-check-stable
+          ruff-ecosystem check ./ruff ${{ steps.ruff-target.outputs.download-path }}/ruff --cache ./checkouts --output-format markdown | tee ecosystem-result-check-stable
 
-          cat ecosystem-result-check-stable > "$GITHUB_STEP_SUMMARY"
+          cat ecosystem-result-check-stable > $GITHUB_STEP_SUMMARY
           echo "### Linter (stable)"  > ecosystem-result
           cat ecosystem-result-check-stable >> ecosystem-result
           echo "" >> ecosystem-result
 
       - name: Run `ruff check` preview ecosystem check
         if: ${{ needs.determine_changes.outputs.linter == 'true' }}
-        env:
-          DOWNLOAD_PATH: ${{ steps.ruff-target.outputs.download-path }}
         run: |
           # Make executable, since artifact download doesn't preserve this
-          chmod +x ./ruff "${DOWNLOAD_PATH}/ruff"
+          chmod +x ./ruff ${{ steps.ruff-target.outputs.download-path }}/ruff
 
           # Set pipefail to avoid hiding errors with tee
           set -eo pipefail
 
-          ruff-ecosystem check ./ruff "${DOWNLOAD_PATH}/ruff" --cache ./checkouts --output-format markdown --force-preview | tee ecosystem-result-check-preview
+          ruff-ecosystem check ./ruff ${{ steps.ruff-target.outputs.download-path }}/ruff --cache ./checkouts --output-format markdown --force-preview | tee ecosystem-result-check-preview
 
-          cat ecosystem-result-check-preview > "$GITHUB_STEP_SUMMARY"
+          cat ecosystem-result-check-preview > $GITHUB_STEP_SUMMARY
           echo "### Linter (preview)" >> ecosystem-result
           cat ecosystem-result-check-preview >> ecosystem-result
           echo "" >> ecosystem-result
 
       - name: Run `ruff format` stable ecosystem check
         if: ${{ needs.determine_changes.outputs.formatter == 'true' }}
-        env:
-          DOWNLOAD_PATH: ${{ steps.ruff-target.outputs.download-path }}
         run: |
           # Make executable, since artifact download doesn't preserve this
-          chmod +x ./ruff "${DOWNLOAD_PATH}/ruff"
+          chmod +x ./ruff ${{ steps.ruff-target.outputs.download-path }}/ruff
 
           # Set pipefail to avoid hiding errors with tee
           set -eo pipefail
 
-          ruff-ecosystem format ./ruff "${DOWNLOAD_PATH}/ruff" --cache ./checkouts --output-format markdown | tee ecosystem-result-format-stable
+          ruff-ecosystem format ./ruff ${{ steps.ruff-target.outputs.download-path }}/ruff --cache ./checkouts --output-format markdown | tee ecosystem-result-format-stable
 
-          cat ecosystem-result-format-stable > "$GITHUB_STEP_SUMMARY"
+          cat ecosystem-result-format-stable > $GITHUB_STEP_SUMMARY
           echo "### Formatter (stable)" >> ecosystem-result
           cat ecosystem-result-format-stable >> ecosystem-result
           echo "" >> ecosystem-result
 
       - name: Run `ruff format` preview ecosystem check
         if: ${{ needs.determine_changes.outputs.formatter == 'true' }}
-        env:
-          DOWNLOAD_PATH: ${{ steps.ruff-target.outputs.download-path }}
         run: |
           # Make executable, since artifact download doesn't preserve this
-          chmod +x ./ruff "${DOWNLOAD_PATH}/ruff"
+          chmod +x ./ruff ${{ steps.ruff-target.outputs.download-path }}/ruff
 
           # Set pipefail to avoid hiding errors with tee
           set -eo pipefail
 
-          ruff-ecosystem format ./ruff "${DOWNLOAD_PATH}/ruff" --cache ./checkouts --output-format markdown --force-preview | tee ecosystem-result-format-preview
+          ruff-ecosystem format ./ruff ${{ steps.ruff-target.outputs.download-path }}/ruff --cache ./checkouts --output-format markdown --force-preview | tee ecosystem-result-format-preview
 
-          cat ecosystem-result-format-preview > "$GITHUB_STEP_SUMMARY"
+          cat ecosystem-result-format-preview > $GITHUB_STEP_SUMMARY
           echo "### Formatter (preview)" >> ecosystem-result
           cat ecosystem-result-format-preview >> ecosystem-result
           echo "" >> ecosystem-result
@@ -554,7 +541,7 @@ jobs:
           args: --out dist
       - name: "Test wheel"
         run: |
-          pip install --force-reinstall --find-links dist "${PACKAGE_NAME}"
+          pip install --force-reinstall --find-links dist ${{ env.PACKAGE_NAME }}
           ruff --help
           python -m ruff --help
       - name: "Remove wheels from cache"
@@ -583,14 +570,13 @@ jobs:
           key: pre-commit-${{ hashFiles('.pre-commit-config.yaml') }}
       - name: "Run pre-commit"
         run: |
-          echo '```console' > "$GITHUB_STEP_SUMMARY"
+          echo '```console' > $GITHUB_STEP_SUMMARY
           # Enable color output for pre-commit and remove it for the summary
-          # Use --hook-stage=manual to enable slower pre-commit hooks that are skipped by default
-          SKIP=cargo-fmt,clippy,dev-generate-all pre-commit run --all-files --show-diff-on-failure --color=always --hook-stage=manual | \
-            tee >(sed -E 's/\x1B\[([0-9]{1,2}(;[0-9]{1,2})*)?[mGK]//g' >> "$GITHUB_STEP_SUMMARY") >&1
-          exit_code="${PIPESTATUS[0]}"
-          echo '```' >> "$GITHUB_STEP_SUMMARY"
-          exit "$exit_code"
+          SKIP=cargo-fmt,clippy,dev-generate-all pre-commit run --all-files --show-diff-on-failure --color=always | \
+            tee >(sed -E 's/\x1B\[([0-9]{1,2}(;[0-9]{1,2})*)?[mGK]//g' >> $GITHUB_STEP_SUMMARY) >&1
+          exit_code=${PIPESTATUS[0]}
+          echo '```' >> $GITHUB_STEP_SUMMARY
+          exit $exit_code
 
   docs:
     name: "mkdocs"
@@ -613,7 +599,7 @@ jobs:
       - name: "Install Rust toolchain"
         run: rustup show
       - name: Install uv
-        uses: astral-sh/setup-uv@v5
+        uses: astral-sh/setup-uv@v4
       - uses: Swatinem/rust-cache@v2
       - name: "Install Insiders dependencies"
         if: ${{ env.MKDOCS_INSIDERS_SSH_KEY_EXISTS == 'true' }}
@@ -651,7 +637,7 @@ jobs:
       - name: "Run checks"
         run: scripts/formatter_ecosystem_checks.sh
       - name: "Github step summary"
-        run: cat target/formatter-ecosystem/stats.txt > "$GITHUB_STEP_SUMMARY"
+        run: cat target/formatter-ecosystem/stats.txt > $GITHUB_STEP_SUMMARY
       - name: "Remove checkouts from cache"
         run: rm -r target/formatter-ecosystem
 
@@ -690,13 +676,11 @@ jobs:
           just install
 
       - name: Run ruff-lsp tests
-        env:
-          DOWNLOAD_PATH: ${{ steps.ruff-target.outputs.download-path }}
         run: |
           # Setup development binary
           pip uninstall --yes ruff
-          chmod +x "${DOWNLOAD_PATH}/ruff"
-          export PATH="${DOWNLOAD_PATH}:${PATH}"
+          chmod +x ${{ steps.ruff-target.outputs.download-path }}/ruff
+          export PATH=${{ steps.ruff-target.outputs.download-path }}:$PATH
           ruff version
 
           just test

.github/workflows/daily_fuzz.yaml

@@ -34,7 +34,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           persist-credentials: false
-      - uses: astral-sh/setup-uv@v5
+      - uses: astral-sh/setup-uv@v4
       - name: "Install Rust toolchain"
         run: rustup show
       - name: "Install mold"
@@ -46,7 +46,6 @@ jobs:
         run: cargo build --locked
       - name: Fuzz
         run: |
-          # shellcheck disable=SC2046
           (
             uvx \
             --python=3.12 \
@@ -73,6 +72,6 @@ jobs:
               owner: "astral-sh",
               repo: "ruff",
               title: `Daily parser fuzz failed on ${new Date().toDateString()}`,
-              body: "Run listed here: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}",
+              body: "Runs listed here: https://github.com/astral-sh/ruff/actions/workflows/daily_fuzz.yml",
               labels: ["bug", "parser", "fuzzer"],
             })

.github/workflows/daily_property_tests.yaml

@@ -1,71 +0,0 @@
-name: Daily property test run
-
-on:
-  workflow_dispatch:
-  schedule:
-    - cron: "0 12 * * *"
-  pull_request:
-    paths:
-      - ".github/workflows/daily_property_tests.yaml"
-
-permissions:
-  contents: read
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
-  cancel-in-progress: true
-
-env:
-  CARGO_INCREMENTAL: 0
-  CARGO_NET_RETRY: 10
-  CARGO_TERM_COLOR: always
-  RUSTUP_MAX_RETRIES: 10
-  FORCE_COLOR: 1
-
-jobs:
-  property_tests:
-    name: Property tests
-    runs-on: ubuntu-latest
-    timeout-minutes: 20
-    # Don't run the cron job on forks:
-    if: ${{ github.repository == 'astral-sh/ruff' || github.event_name != 'schedule' }}
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          persist-credentials: false
-      - name: "Install Rust toolchain"
-        run: rustup show
-      - name: "Install mold"
-        uses: rui314/setup-mold@v1
-      - uses: Swatinem/rust-cache@v2
-      - name: Build Red Knot
-        # A release build takes longer (2 min vs 1 min), but the property tests run much faster in release
-        # mode (1.5 min vs 14 min), so the overall time is shorter with a release build.
-        run: cargo build --locked --release --package red_knot_python_semantic --tests
-      - name: Run property tests
-        shell: bash
-        run: |
-          export QUICKCHECK_TESTS=100000
-          for _ in {1..5}; do
-            cargo test --locked --release --package red_knot_python_semantic -- --ignored types::property_tests::stable
-          done
-
-  create-issue-on-failure:
-    name: Create an issue if the daily property test run surfaced any bugs
-    runs-on: ubuntu-latest
-    needs: property_tests
-    if: ${{ github.repository == 'astral-sh/ruff' && always() && github.event_name == 'schedule' && needs.property_tests.result == 'failure' }}
-    permissions:
-      issues: write
-    steps:
-      - uses: actions/github-script@v7
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            await github.rest.issues.create({
-              owner: "astral-sh",
-              repo: "ruff",
-              title: `Daily property test run failed on ${new Date().toDateString()}`,
-              body: "Run listed here: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}",
-              labels: ["bug", "red-knot", "testing"],
-            })

.github/workflows/pr-comment.yaml

@@ -10,11 +10,12 @@ on:
         description: The ecosystem workflow that triggers the workflow run
         required: true
 
+permissions:
+  pull-requests: write
+
 jobs:
   comment:
     runs-on: ubuntu-latest
-    permissions:
-      pull-requests: write
     steps:
       - uses: dawidd6/action-download-artifact@v7
         name: Download pull request number
@@ -29,7 +30,7 @@ jobs:
         run: |
           if [[ -f pr-number ]]
           then
-            echo "pr-number=$(<pr-number)" >> "$GITHUB_OUTPUT"
+            echo "pr-number=$(<pr-number)" >> $GITHUB_OUTPUT
           fi
 
       - uses: dawidd6/action-download-artifact@v7
@@ -65,9 +66,9 @@ jobs:
           cat pr/ecosystem/ecosystem-result >> comment.txt
           echo "" >> comment.txt
 
-          echo 'comment<<EOF' >> "$GITHUB_OUTPUT"
-          cat comment.txt >> "$GITHUB_OUTPUT"
-          echo 'EOF' >> "$GITHUB_OUTPUT"
+          echo 'comment<<EOF' >> $GITHUB_OUTPUT
+          cat comment.txt >> $GITHUB_OUTPUT
+          echo 'EOF' >> $GITHUB_OUTPUT
 
       - name: Find existing comment
         uses: peter-evans/find-comment@v3

.github/workflows/publish-docs.yml

@@ -33,9 +33,8 @@ jobs:
           python-version: 3.12
 
       - name: "Set docs version"
-        env:
-          version: ${{ (inputs.plan != '' && fromJson(inputs.plan).announcement_tag) || inputs.ref }}
         run: |
+          version="${{ (inputs.plan != '' && fromJson(inputs.plan).announcement_tag) || inputs.ref }}"
           # if version is missing, use 'latest'
           if [ -z "$version" ]; then
             echo "Using 'latest' as version"
@@ -45,8 +44,8 @@ jobs:
           # Use version as display name for now
           display_name="$version"
 
-          echo "version=$version" >> "$GITHUB_ENV"
-          echo "display_name=$display_name" >> "$GITHUB_ENV"
+          echo "version=$version" >> $GITHUB_ENV
+          echo "display_name=$display_name" >> $GITHUB_ENV
 
       - name: "Set branch name"
         run: |
@@ -56,8 +55,8 @@ jobs:
           # characters disallowed in git branch names with hyphens
           branch_display_name="$(echo "${display_name}" | tr -c '[:alnum:]._' '-' | tr -s '-')"
 
-          echo "branch_name=update-docs-$branch_display_name-$timestamp" >> "$GITHUB_ENV"
-          echo "timestamp=$timestamp" >> "$GITHUB_ENV"
+          echo "branch_name=update-docs-$branch_display_name-$timestamp" >> $GITHUB_ENV
+          echo "timestamp=$timestamp" >> $GITHUB_ENV
 
       - name: "Add SSH key"
         if: ${{ env.MKDOCS_INSIDERS_SSH_KEY_EXISTS == 'true' }}
@@ -113,7 +112,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.ASTRAL_DOCS_PAT }}
         run: |
           # set the PR title
-          pull_request_title="Update ruff documentation for ${display_name}"
+          pull_request_title="Update ruff documentation for "${display_name}""
 
           # Delete any existing pull requests that are open for this version
           # by checking against pull_request_title because the new PR will
@@ -125,12 +124,10 @@ jobs:
           git push origin "${branch_name}"
 
           # create the PR
-          gh pr create \
-            --base=main \
-            --head="${branch_name}" \
-            --title="${pull_request_title}" \
-            --body="Automated documentation update for ${display_name}" \
-            --label="documentation"
+          gh pr create --base main --head "${branch_name}" \
+            --title "$pull_request_title" \
+            --body "Automated documentation update for "${display_name}"" \
+            --label "documentation"
 
       - name: "Merge Pull Request"
         if: ${{ inputs.plan != '' && !fromJson(inputs.plan).announcement_tag_is_implicit }}

.github/workflows/publish-pypi.yml

@@ -22,7 +22,7 @@ jobs:
       id-token: write
     steps:
       - name: "Install uv"
-        uses: astral-sh/setup-uv@v5
+        uses: astral-sh/setup-uv@v4
       - uses: actions/download-artifact@v4
         with:
           pattern: wheels-*

.github/workflows/sync_typeshed.yaml

@@ -59,7 +59,7 @@ jobs:
         run: |
           cd ruff
           git push --force origin typeshedbot/sync-typeshed
-          gh pr list --repo "$GITHUB_REPOSITORY" --head typeshedbot/sync-typeshed --json id --jq length | grep 1 && exit 0 # exit if there is existing pr
+          gh pr list --repo $GITHUB_REPOSITORY --head typeshedbot/sync-typeshed --json id --jq length | grep 1 && exit 0 # exit if there is existing pr
           gh pr create --title "Sync vendored typeshed stubs" --body "Close and reopen this PR to trigger CI" --label "internal"
 
   create-issue-on-failure:

.github/zizmor.yml

@@ -1,12 +0,0 @@
-# Configuration for the zizmor static analysis tool, run via pre-commit in CI
-# https://woodruffw.github.io/zizmor/configuration/
-#
-# TODO: can we remove the ignores here so that our workflows are more secure?
-rules:
-  dangerous-triggers:
-    ignore:
-      - pr-comment.yaml
-  cache-poisoning:
-    ignore:
-      - build-docker.yml
-      - publish-playground.yml

.markdownlint.yaml

@@ -21,11 +21,3 @@ MD014: false
 MD024:
   # Allow when nested under different parents e.g. CHANGELOG.md
   siblings_only: true
-
-# MD046/code-block-style
-#
-# Ignore this because it conflicts with the code block style used in content
-# tabs of mkdocs-material which is to add a blank line after the content title.
-#
-# Ref: https://github.com/astral-sh/ruff/pull/15011#issuecomment-2544790854
-MD046: false

.pre-commit-config.yaml

@@ -2,7 +2,6 @@ fail_fast: false
 
 exclude: |
   (?x)^(
-    .github/workflows/release.yml|
     crates/red_knot_vendored/vendor/.*|
     crates/red_knot_workspace/resources/.*|
     crates/ruff_linter/resources/.*|
@@ -23,12 +22,13 @@ repos:
       - id: validate-pyproject
 
   - repo: https://github.com/executablebooks/mdformat
-    rev: 0.7.21
+    rev: 0.7.19
     hooks:
       - id: mdformat
         additional_dependencies:
-          - mdformat-mkdocs==4.0.0
-          - mdformat-footnote==0.1.1
+          - mdformat-mkdocs
+          - mdformat-admon
+          - mdformat-footnote
         exclude: |
           (?x)^(
             docs/formatter/black\.md
@@ -59,7 +59,7 @@ repos:
           - black==24.10.0
 
   - repo: https://github.com/crate-ci/typos
-    rev: v1.29.4
+    rev: v1.28.2
     hooks:
       - id: typos
 
@@ -73,7 +73,7 @@ repos:
         pass_filenames: false # This makes it a lot faster
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.8.6
+    rev: v0.8.2
     hooks:
       - id: ruff-format
       - id: ruff
@@ -88,37 +88,18 @@ repos:
       - id: prettier
         types: [yaml]
 
-  # zizmor detects security vulnerabilities in GitHub Actions workflows.
-  # Additional configuration for the tool is found in `.github/zizmor.yml`
   - repo: https://github.com/woodruffw/zizmor-pre-commit
-    rev: v1.0.0
+    rev: v0.8.0
     hooks:
       - id: zizmor
+        # `release.yml` is autogenerated by `dist`; security issues need to be fixed there
+        # (https://opensource.axo.dev/cargo-dist/)
+        exclude: .github/workflows/release.yml
 
   - repo: https://github.com/python-jsonschema/check-jsonschema
     rev: 0.30.0
     hooks:
       - id: check-github-workflows
 
-  # `actionlint` hook, for verifying correct syntax in GitHub Actions workflows.
-  # Some additional configuration for `actionlint` can be found in `.github/actionlint.yaml`.
-  - repo: https://github.com/rhysd/actionlint
-    rev: v1.7.6
-    hooks:
-      - id: actionlint
-        stages:
-          # This hook is disabled by default, since it's quite slow.
-          # To run all hooks *including* this hook, use `uvx pre-commit run -a --hook-stage=manual`.
-          # To run *just* this hook, use `uvx pre-commit run -a actionlint --hook-stage=manual`.
-          - manual
-        args:
-          - "-ignore=SC2129" # ignorable stylistic lint from shellcheck
-          - "-ignore=SC2016" # another shellcheck lint: seems to have false positives?
-        additional_dependencies:
-          # actionlint has a shellcheck integration which extracts shell scripts in `run:` steps from GitHub Actions
-          # and checks these with shellcheck. This is arguably its most useful feature,
-          # but the integration only works if shellcheck is installed
-          - "github.com/wasilibs/go-shellcheck/cmd/shellcheck@v0.10.0"
-
 ci:
   skip: [cargo-fmt, dev-generate-all]

BREAKING_CHANGES.md

@@ -1,9 +1,5 @@
 # Breaking Changes
 
-## 0.9.0
-
-Ruff now formats your code according to the 2025 style guide. As a result, your code might now get formatted differently. See the [changelog](./CHANGELOG.md#090) for a detailed list of changes.
-
 ## 0.8.0
 
 - **Default to Python 3.9**

CHANGELOG.md

@@ -1,208 +1,5 @@
 # Changelog
 
-## 0.9.1
-
-### Preview features
-
-- \[`pycodestyle`\] Run `too-many-newlines-at-end-of-file` on each cell in notebooks (`W391`) ([#15308](https://github.com/astral-sh/ruff/pull/15308))
-- \[`ruff`\] Omit diagnostic for shadowed private function parameters in `used-dummy-variable` (`RUF052`) ([#15376](https://github.com/astral-sh/ruff/pull/15376))
-
-### Rule changes
-
-- \[`flake8-bugbear`\] Improve `assert-raises-exception` message (`B017`) ([#15389](https://github.com/astral-sh/ruff/pull/15389))
-
-### Formatter
-
-- Preserve trailing end-of line comments for the last string literal in implicitly concatenated strings ([#15378](https://github.com/astral-sh/ruff/pull/15378))
-
-### Server
-
-- Fix a bug where the server and client notebooks were out of sync after reordering cells ([#15398](https://github.com/astral-sh/ruff/pull/15398))
-
-### Bug fixes
-
-- \[`flake8-pie`\] Correctly remove wrapping parentheses (`PIE800`) ([#15394](https://github.com/astral-sh/ruff/pull/15394))
-- \[`pyupgrade`\] Handle comments and multiline expressions correctly (`UP037`) ([#15337](https://github.com/astral-sh/ruff/pull/15337))
-
-## 0.9.0
-
-Check out the [blog post](https://astral.sh/blog/ruff-v0.9.0) for a migration guide and overview of the changes!
-
-### Breaking changes
-
-Ruff now formats your code according to the 2025 style guide. As a result, your code might now get formatted differently. See the formatter section for a detailed list of changes.
-
-This release doesn’t remove or remap any existing stable rules.
-
-### Stabilization
-
-The following rules have been stabilized and are no longer in preview:
-
-- [`stdlib-module-shadowing`](https://docs.astral.sh/ruff/rules/stdlib-module-shadowing/) (`A005`).
-    This rule has also been renamed: previously, it was called `builtin-module-shadowing`.
-- [`builtin-lambda-argument-shadowing`](https://docs.astral.sh/ruff/rules/builtin-lambda-argument-shadowing/) (`A006`)
-- [`slice-to-remove-prefix-or-suffix`](https://docs.astral.sh/ruff/rules/slice-to-remove-prefix-or-suffix/) (`FURB188`)
-- [`boolean-chained-comparison`](https://docs.astral.sh/ruff/rules/boolean-chained-comparison/) (`PLR1716`)
-- [`decimal-from-float-literal`](https://docs.astral.sh/ruff/rules/decimal-from-float-literal/) (`RUF032`)
-- [`post-init-default`](https://docs.astral.sh/ruff/rules/post-init-default/) (`RUF033`)
-- [`useless-if-else`](https://docs.astral.sh/ruff/rules/useless-if-else/) (`RUF034`)
-
-The following behaviors have been stabilized:
-
-- [`pytest-parametrize-names-wrong-type`](https://docs.astral.sh/ruff/rules/pytest-parametrize-names-wrong-type/) (`PT006`): Detect [`pytest.parametrize`](https://docs.pytest.org/en/7.1.x/how-to/parametrize.html#parametrize) calls outside decorators and calls with keyword arguments.
-- [`module-import-not-at-top-of-file`](https://docs.astral.sh/ruff/rules/module-import-not-at-top-of-file/) (`E402`): Ignore [`pytest.importorskip`](https://docs.pytest.org/en/7.1.x/reference/reference.html#pytest-importorskip) calls between import statements.
-- [`mutable-dataclass-default`](https://docs.astral.sh/ruff/rules/mutable-dataclass-default/) (`RUF008`) and [`function-call-in-dataclass-default-argument`](https://docs.astral.sh/ruff/rules/function-call-in-dataclass-default-argument/) (`RUF009`): Add support for [`attrs`](https://www.attrs.org/en/stable/).
-- [`bad-version-info-comparison`](https://docs.astral.sh/ruff/rules/bad-version-info-comparison/) (`PYI006`): Extend the rule to check non-stub files.
-
-The following fixes or improvements to fixes have been stabilized:
-
-- [`redundant-numeric-union`](https://docs.astral.sh/ruff/rules/redundant-numeric-union/) (`PYI041`)
-- [`duplicate-union-members`](https://docs.astral.sh/ruff/rules/duplicate-union-member/) (`PYI016`)
-
-### Formatter
-
-This release introduces the new 2025 stable style ([#13371](https://github.com/astral-sh/ruff/issues/13371)), stabilizing the following changes:
-
-- Format expressions in f-string elements ([#7594](https://github.com/astral-sh/ruff/issues/7594))
-- Alternate quotes for strings inside f-strings ([#13860](https://github.com/astral-sh/ruff/pull/13860))
-- Preserve the casing of hex codes in f-string debug expressions ([#14766](https://github.com/astral-sh/ruff/issues/14766))
-- Choose the quote style for each string literal in an implicitly concatenated f-string rather than for the entire string ([#13539](https://github.com/astral-sh/ruff/pull/13539))
-- Automatically join an implicitly concatenated string into a single string literal if it fits on a single line ([#9457](https://github.com/astral-sh/ruff/issues/9457))
-- Remove the [`ISC001`](https://docs.astral.sh/ruff/rules/single-line-implicit-string-concatenation/) incompatibility warning ([#15123](https://github.com/astral-sh/ruff/pull/15123))
-- Prefer parenthesizing the `assert` message over breaking the assertion expression ([#9457](https://github.com/astral-sh/ruff/issues/9457))
-- Automatically parenthesize over-long `if` guards in `match` `case` clauses ([#13513](https://github.com/astral-sh/ruff/pull/13513))
-- More consistent formatting for `match` `case` patterns ([#6933](https://github.com/astral-sh/ruff/issues/6933))
-- Avoid unnecessary parentheses around return type annotations ([#13381](https://github.com/astral-sh/ruff/pull/13381))
-- Keep the opening parentheses on the same line as the `if` keyword for comprehensions where the condition has a leading comment ([#12282](https://github.com/astral-sh/ruff/pull/12282))
-- More consistent formatting for `with` statements with a single context manager for Python 3.8 or older ([#10276](https://github.com/astral-sh/ruff/pull/10276))
-- Correctly calculate the line-width for code blocks in docstrings when using `max-doc-code-line-length = "dynamic"` ([#13523](https://github.com/astral-sh/ruff/pull/13523))
-
-### Preview features
-
-- \[`flake8-bugbear`\] Implement `class-as-data-structure` (`B903`) ([#9601](https://github.com/astral-sh/ruff/pull/9601))
-- \[`flake8-type-checking`\] Apply `quoted-type-alias` more eagerly in `TYPE_CHECKING` blocks and ignore it in stubs (`TC008`) ([#15180](https://github.com/astral-sh/ruff/pull/15180))
-- \[`pylint`\] Ignore `eq-without-hash` in stub files (`PLW1641`) ([#15310](https://github.com/astral-sh/ruff/pull/15310))
-- \[`pyupgrade`\] Split `UP007` into two individual rules: `UP007` for `Union` and `UP045` for `Optional` (`UP007`, `UP045`) ([#15313](https://github.com/astral-sh/ruff/pull/15313))
-- \[`ruff`\] New rule that detects classes that are both an enum and a `dataclass` (`RUF049`) ([#15299](https://github.com/astral-sh/ruff/pull/15299))
-- \[`ruff`\] Recode `RUF025` to `RUF037` (`RUF037`) ([#15258](https://github.com/astral-sh/ruff/pull/15258))
-
-### Rule changes
-
-- \[`flake8-builtins`\] Ignore [`stdlib-module-shadowing`](https://docs.astral.sh/ruff/rules/stdlib-module-shadowing/) in stub files(`A005`) ([#15350](https://github.com/astral-sh/ruff/pull/15350))
-- \[`flake8-return`\] Add support for functions returning `typing.Never` (`RET503`) ([#15298](https://github.com/astral-sh/ruff/pull/15298))
-
-### Server
-
-- Improve the observability by removing the need for the ["trace" value](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#traceValue) to turn on or off logging. The server logging is solely controlled using the [`logLevel` server setting](https://docs.astral.sh/ruff/editors/settings/#loglevel)
-    which defaults to `info`. This addresses the issue where users were notified about an error and told to consult the log, but it didn’t contain any messages. ([#15232](https://github.com/astral-sh/ruff/pull/15232))
-- Ignore diagnostics from other sources for code action requests ([#15373](https://github.com/astral-sh/ruff/pull/15373))
-
-### CLI
-
-- Improve the error message for `--config key=value` when the `key` is for a table and it’s a simple `value`
-
-### Bug fixes
-
-- \[`eradicate`\] Ignore metadata blocks directly followed by normal blocks (`ERA001`) ([#15330](https://github.com/astral-sh/ruff/pull/15330))
-- \[`flake8-django`\] Recognize other magic methods (`DJ012`) ([#15365](https://github.com/astral-sh/ruff/pull/15365))
-- \[`pycodestyle`\] Avoid false positives related to type aliases (`E252`) ([#15356](https://github.com/astral-sh/ruff/pull/15356))
-- \[`pydocstyle`\] Avoid treating newline-separated sections as sub-sections (`D405`) ([#15311](https://github.com/astral-sh/ruff/pull/15311))
-- \[`pyflakes`\] Remove call when removing final argument from `format` (`F523`) ([#15309](https://github.com/astral-sh/ruff/pull/15309))
-- \[`refurb`\] Mark fix as unsafe when the right-hand side is a string (`FURB171`) ([#15273](https://github.com/astral-sh/ruff/pull/15273))
-- \[`ruff`\] Treat `)` as a regex metacharacter (`RUF043`, `RUF055`) ([#15318](https://github.com/astral-sh/ruff/pull/15318))
-- \[`ruff`\] Parenthesize the `int`-call argument when removing the `int` call would change semantics (`RUF046`) ([#15277](https://github.com/astral-sh/ruff/pull/15277))
-
-## 0.8.6
-
-### Preview features
-
-- \[`format`\]: Preserve multiline implicit concatenated strings in docstring positions ([#15126](https://github.com/astral-sh/ruff/pull/15126))
-- \[`ruff`\] Add rule to detect empty literal in deque call (`RUF025`) ([#15104](https://github.com/astral-sh/ruff/pull/15104))
-- \[`ruff`\] Avoid reporting when `ndigits` is possibly negative (`RUF057`) ([#15234](https://github.com/astral-sh/ruff/pull/15234))
-
-### Rule changes
-
-- \[`flake8-todos`\] remove issue code length restriction (`TD003`) ([#15175](https://github.com/astral-sh/ruff/pull/15175))
-- \[`pyflakes`\] Ignore errors in `@no_type_check` string annotations (`F722`, `F821`) ([#15215](https://github.com/astral-sh/ruff/pull/15215))
-
-### CLI
-
-- Show errors for attempted fixes only when passed `--verbose` ([#15237](https://github.com/astral-sh/ruff/pull/15237))
-
-### Bug fixes
-
-- \[`ruff`\] Avoid syntax error when removing int over multiple lines (`RUF046`) ([#15230](https://github.com/astral-sh/ruff/pull/15230))
-- \[`pyupgrade`\] Revert "Add all PEP-585 names to `UP006` rule" ([#15250](https://github.com/astral-sh/ruff/pull/15250))
-
-## 0.8.5
-
-### Preview features
-
-- \[`airflow`\] Extend names moved from core to provider (`AIR303`) ([#15145](https://github.com/astral-sh/ruff/pull/15145), [#15159](https://github.com/astral-sh/ruff/pull/15159), [#15196](https://github.com/astral-sh/ruff/pull/15196), [#15216](https://github.com/astral-sh/ruff/pull/15216))
-- \[`airflow`\] Extend rule to check class attributes, methods, arguments (`AIR302`) ([#15054](https://github.com/astral-sh/ruff/pull/15054), [#15083](https://github.com/astral-sh/ruff/pull/15083))
-- \[`fastapi`\] Update `FAST002` to check keyword-only arguments ([#15119](https://github.com/astral-sh/ruff/pull/15119))
-- \[`flake8-type-checking`\] Disable `TC006` and `TC007` in stub files ([#15179](https://github.com/astral-sh/ruff/pull/15179))
-- \[`pylint`\] Detect nested methods correctly (`PLW1641`) ([#15032](https://github.com/astral-sh/ruff/pull/15032))
-- \[`ruff`\] Detect more strict-integer expressions (`RUF046`) ([#14833](https://github.com/astral-sh/ruff/pull/14833))
-- \[`ruff`\] Implement `falsy-dict-get-fallback` (`RUF056`) ([#15160](https://github.com/astral-sh/ruff/pull/15160))
-- \[`ruff`\] Implement `unnecessary-round` (`RUF057`) ([#14828](https://github.com/astral-sh/ruff/pull/14828))
-
-### Rule changes
-
-- Visit PEP 764 inline `TypedDict` keys as non-type-expressions ([#15073](https://github.com/astral-sh/ruff/pull/15073))
-- \[`flake8-comprehensions`\] Skip `C416` if comprehension contains unpacking ([#14909](https://github.com/astral-sh/ruff/pull/14909))
-- \[`flake8-pie`\] Allow `cast(SomeType, ...)` (`PIE796`) ([#15141](https://github.com/astral-sh/ruff/pull/15141))
-- \[`flake8-simplify`\] More precise inference for dictionaries (`SIM300`) ([#15164](https://github.com/astral-sh/ruff/pull/15164))
-- \[`flake8-use-pathlib`\] Catch redundant joins in `PTH201` and avoid syntax errors ([#15177](https://github.com/astral-sh/ruff/pull/15177))
-- \[`pycodestyle`\] Preserve original value format (`E731`) ([#15097](https://github.com/astral-sh/ruff/pull/15097))
-- \[`pydocstyle`\] Split on first whitespace character (`D403`) ([#15082](https://github.com/astral-sh/ruff/pull/15082))
-- \[`pyupgrade`\] Add all PEP-585 names to `UP006` rule ([#5454](https://github.com/astral-sh/ruff/pull/5454))
-
-### Configuration
-
-- \[`flake8-type-checking`\] Improve flexibility of `runtime-evaluated-decorators` ([#15204](https://github.com/astral-sh/ruff/pull/15204))
-- \[`pydocstyle`\] Add setting to ignore missing documentation for `*args` and `**kwargs` parameters (`D417`) ([#15210](https://github.com/astral-sh/ruff/pull/15210))
-- \[`ruff`\] Add an allowlist for `unsafe-markup-use` (`RUF035`) ([#15076](https://github.com/astral-sh/ruff/pull/15076))
-
-### Bug fixes
-
-- Fix type subscript on older python versions ([#15090](https://github.com/astral-sh/ruff/pull/15090))
-- Use `TypeChecker` for detecting `fastapi` routes ([#15093](https://github.com/astral-sh/ruff/pull/15093))
-- \[`pycodestyle`\] Avoid false positives and negatives related to type parameter default syntax (`E225`, `E251`) ([#15214](https://github.com/astral-sh/ruff/pull/15214))
-
-### Documentation
-
-- Fix incorrect doc in `shebang-not-executable` (`EXE001`) and add git+windows solution to executable bit ([#15208](https://github.com/astral-sh/ruff/pull/15208))
-- Rename rules currently not conforming to naming convention ([#15102](https://github.com/astral-sh/ruff/pull/15102))
-
-## 0.8.4
-
-### Preview features
-
-- \[`airflow`\] Extend `AIR302` with additional functions and classes ([#15015](https://github.com/astral-sh/ruff/pull/15015))
-- \[`airflow`\] Implement `moved-to-provider-in-3` for modules that has been moved to Airflow providers (`AIR303`) ([#14764](https://github.com/astral-sh/ruff/pull/14764))
-- \[`flake8-use-pathlib`\] Extend check for invalid path suffix to include the case `"."` (`PTH210`) ([#14902](https://github.com/astral-sh/ruff/pull/14902))
-- \[`perflint`\] Fix panic in `PERF401` when list variable is after the `for` loop ([#14971](https://github.com/astral-sh/ruff/pull/14971))
-- \[`perflint`\] Simplify finding the loop target in `PERF401` ([#15025](https://github.com/astral-sh/ruff/pull/15025))
-- \[`pylint`\] Preserve original value format (`PLR6104`) ([#14978](https://github.com/astral-sh/ruff/pull/14978))
-- \[`ruff`\] Avoid false positives for `RUF027` for typing context bindings ([#15037](https://github.com/astral-sh/ruff/pull/15037))
-- \[`ruff`\] Check for ambiguous pattern passed to `pytest.raises()` (`RUF043`) ([#14966](https://github.com/astral-sh/ruff/pull/14966))
-
-### Rule changes
-
-- \[`flake8-bandit`\] Check `S105` for annotated assignment ([#15059](https://github.com/astral-sh/ruff/pull/15059))
-- \[`flake8-pyi`\] More autofixes for `redundant-none-literal` (`PYI061`) ([#14872](https://github.com/astral-sh/ruff/pull/14872))
-- \[`pydocstyle`\] Skip leading whitespace for `D403` ([#14963](https://github.com/astral-sh/ruff/pull/14963))
-- \[`ruff`\] Skip `SQLModel` base classes for `mutable-class-default` (`RUF012`) ([#14949](https://github.com/astral-sh/ruff/pull/14949))
-
-### Bug
-
-- \[`perflint`\] Parenthesize walrus expressions in autofix for `manual-list-comprehension` (`PERF401`) ([#15050](https://github.com/astral-sh/ruff/pull/15050))
-
-### Server
-
-- Check diagnostic refresh support from client capability which enables dynamic configuration for various editors ([#15014](https://github.com/astral-sh/ruff/pull/15014))
-
 ## 0.8.3
 
 ### Preview features

CONTRIBUTING.md

@@ -467,7 +467,7 @@ cargo build --release && hyperfine --warmup 10 \
   "./target/release/ruff check ./crates/ruff_linter/resources/test/cpython/ --no-cache -e --select W505,E501"
 ```
 
-You can run `uv venv --project ./scripts/benchmarks`, activate the venv and then run `uv sync --project ./scripts/benchmarks` to create a working environment for the
+You can run `poetry install` from `./scripts/benchmarks` to create a working environment for the
 above. All reported benchmarks were computed using the versions specified by
 `./scripts/benchmarks/pyproject.toml` on Python 3.11.
 

Cargo.lock

@@ -117,9 +117,9 @@ dependencies = [
 
 [[package]]
 name = "anyhow"
-version = "1.0.95"
+version = "1.0.94"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "34ac096ce696dc2fcabef30516bb13c0a68a11d30131d3df6f04711467681b04"
+checksum = "c1fd03a028ef38ba2276dce7e33fcd6369c158a1bca17946c4b1b701891c1ff7"
 
 [[package]]
 name = "append-only-vec"
@@ -220,9 +220,9 @@ checksum = "7f839cdf7e2d3198ac6ca003fd8ebc61715755f41c1cad15ff13df67531e00ed"
 
 [[package]]
 name = "bstr"
-version = "1.11.3"
+version = "1.11.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "531a9155a481e2ee699d4f98f43c0ca4ff8ee1bfd55c31e9e98fb29d2b176fe0"
+checksum = "1a68f1f47cdf0ec8ee4b941b2eee2a80cb796db73118c0dd09ac63fbe405be22"
 dependencies = [
  "memchr",
  "regex-automata 0.4.8",
@@ -291,6 +291,12 @@ version = "1.0.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd"
 
+[[package]]
+name = "cfg_aliases"
+version = "0.1.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "fd16c4719339c4530435d38e511904438d07cce7950afa3718a84ac36c10e89e"
+
 [[package]]
 name = "cfg_aliases"
 version = "0.2.1"
@@ -308,9 +314,9 @@ dependencies = [
 
 [[package]]
 name = "chrono"
-version = "0.4.39"
+version = "0.4.38"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7e36cc9d416881d2e24f9a963be5fb1cd90966419ac844274161d10488b3e825"
+checksum = "a21f936df1771bf62b77f047b726c4625ff2e8aa607c01ec06e5a05bd8463401"
 dependencies = [
  "android-tzdata",
  "iana-time-zone",
@@ -407,7 +413,7 @@ dependencies = [
  "heck",
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -418,15 +424,15 @@ checksum = "f46ad14479a25103f283c0f10005961cf086d8dc42205bb44c46ac563475dca6"
 
 [[package]]
 name = "clearscreen"
-version = "4.0.1"
+version = "3.0.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8c41dc435a7b98e4608224bbf65282309f5403719df9113621b30f8b6f74e2f4"
+checksum = "2f8c93eb5f77c9050c7750e14f13ef1033a40a0aac70c6371535b6763a01438c"
 dependencies = [
- "nix",
+ "nix 0.28.0",
  "terminfo",
- "thiserror 2.0.9",
+ "thiserror 1.0.67",
  "which",
- "windows-sys 0.59.0",
+ "winapi",
 ]
 
 [[package]]
@@ -459,19 +465,19 @@ checksum = "acbf1af155f9b9ef647e42cdc158db4b64a1b61f743629225fde6f3e0be2a7c7"
 
 [[package]]
 name = "colored"
-version = "2.2.0"
+version = "2.1.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "117725a109d387c937a1533ce01b450cbde6b88abceea8473c4d7a85853cda3c"
+checksum = "cbf2150cce219b664a8a70df7a1f933836724b503f8a413af9365b4dcc4d90b8"
 dependencies = [
  "lazy_static",
- "windows-sys 0.59.0",
+ "windows-sys 0.48.0",
 ]
 
 [[package]]
 name = "compact_str"
-version = "0.8.1"
+version = "0.8.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3b79c4069c6cad78e2e0cdfcbd26275770669fb39fd308a752dc110e83b9af32"
+checksum = "6050c3a16ddab2e412160b31f2c871015704239bca62f72f6e5f0be631d3f644"
 dependencies = [
  "castaway",
  "cfg-if",
@@ -662,7 +668,7 @@ version = "3.4.5"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "90eeab0aa92f3f9b4e87f258c72b139c207d251f9cbc1080a0086b86a8870dd3"
 dependencies = [
- "nix",
+ "nix 0.29.0",
  "windows-sys 0.59.0",
 ]
 
@@ -687,7 +693,7 @@ dependencies = [
  "proc-macro2",
  "quote",
  "strsim 0.10.0",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -698,7 +704,7 @@ checksum = "a668eda54683121533a393014d8692171709ff57a7d61f187b6e782719f8933f"
 dependencies = [
  "darling_core",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -768,7 +774,16 @@ dependencies = [
  "glob",
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
+]
+
+[[package]]
+name = "dirs"
+version = "4.0.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "ca3aa72a6f96ea37bbc5aa912f6788242832f75369bdfdadcb0e38423f100059"
+dependencies = [
+ "dirs-sys 0.3.7",
 ]
 
 [[package]]
@@ -777,7 +792,18 @@ version = "5.0.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "44c45a9d03d6676652bcb5e724c7e988de1acad23a711b5217ab9cbecbec2225"
 dependencies = [
- "dirs-sys",
+ "dirs-sys 0.4.1",
+]
+
+[[package]]
+name = "dirs-sys"
+version = "0.3.7"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "1b1d1d91c932ef41c0f2663aa8b0ca0342d444d842c06914aa0a7e352d0bada6"
+dependencies = [
+ "libc",
+ "redox_users",
+ "winapi",
 ]
 
 [[package]]
@@ -800,7 +826,7 @@ checksum = "97369cbbc041bc366949bc74d34658d6cda5621039731c6310521892a3a20ae0"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -849,17 +875,11 @@ dependencies = [
  "regex",
 ]
 
-[[package]]
-name = "env_home"
-version = "0.1.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "c7f84e12ccf0a7ddc17a6c41c93326024c42920d7ee630d04950e6926645c0fe"
-
 [[package]]
 name = "env_logger"
-version = "0.11.6"
+version = "0.11.5"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "dcaee3d8e3cfc3fd92428d477bc97fc29ec8716d180c0d74c643bb26166660e0"
+checksum = "e13fa619b91fb2381732789fc5de83b45675e882f66623b7d8cb4f643017018d"
 dependencies = [
  "anstream",
  "anstyle",
@@ -903,9 +923,9 @@ checksum = "e8c02a5121d4ea3eb16a80748c74f5549a5665e4c21333c6098f283870fbdea6"
 
 [[package]]
 name = "fern"
-version = "0.7.1"
+version = "0.7.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "4316185f709b23713e41e3195f90edef7fb00c3ed4adc79769cf09cc762a3b29"
+checksum = "69ff9c9d5fb3e6da8ac2f77ab76fe7e8087d512ce095200f8f29ac5b656cf6dc"
 dependencies = [
  "log",
 ]
@@ -999,9 +1019,9 @@ dependencies = [
 
 [[package]]
 name = "glob"
-version = "0.3.2"
+version = "0.3.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a8d1add55171497b4705a648c6b583acafb01d58050a51727785f0b2c8e0a2b2"
+checksum = "d2fabcfbdc87f4758337ca535fb41a6d701b65693ce38287d856d1674551ec9b"
 
 [[package]]
 name = "globset"
@@ -1226,7 +1246,7 @@ checksum = "1ec89e9337638ecdc08744df490b221a7399bf8d164eb52a665454e60e075ad6"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -1345,14 +1365,14 @@ dependencies = [
 
 [[package]]
 name = "insta"
-version = "1.42.0"
+version = "1.41.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6513e4067e16e69ed1db5ab56048ed65db32d10ba5fc1217f5393f8f17d8b5a5"
+checksum = "7e9ffc4d4892617c50a928c52b2961cb5174b6fc6ebf252b2fac9d21955c48b8"
 dependencies = [
  "console",
  "globset",
+ "lazy_static",
  "linked-hash-map",
- "once_cell",
  "pest",
  "pest_derive",
  "regex",
@@ -1400,7 +1420,7 @@ dependencies = [
  "heck",
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -1442,15 +1462,6 @@ dependencies = [
  "either",
 ]
 
-[[package]]
-name = "itertools"
-version = "0.14.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "2b192c782037fadd9cfa75548310488aabdbf3d2da73885b31bd0abd03351285"
-dependencies = [
- "either",
-]
-
 [[package]]
 name = "itoa"
 version = "1.0.11"
@@ -1510,9 +1521,9 @@ checksum = "e2abad23fbc42b3700f2f279844dc832adb2b2eb069b2df918f455c4e18cc646"
 
 [[package]]
 name = "libc"
-version = "0.2.169"
+version = "0.2.167"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b5aba8db14291edd000dfcc4d620c7ebfb122c613afb886ca8803fa4e128a20a"
+checksum = "09d6582e104315a817dff97f75133544b2e094ee22447d2acf4a74e189ba06fc"
 
 [[package]]
 name = "libcst"
@@ -1536,7 +1547,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "a2ae40017ac09cd2c6a53504cb3c871c7f2b41466eac5bc66ba63f39073b467b"
 dependencies = [
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -1596,14 +1607,13 @@ checksum = "a7a70ba024b9dc04c27ea2f0c0548feb474ec5c54bba33a7f72f873a39d07b24"
 
 [[package]]
 name = "lsp-server"
-version = "0.7.8"
+version = "0.7.7"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "9462c4dc73e17f971ec1f171d44bfffb72e65a130117233388a0ebc7ec5656f9"
+checksum = "550446e84739dcaf6d48a4a093973850669e13e8a34d8f8d64851041be267cd9"
 dependencies = [
  "crossbeam-channel",
  "log",
  "serde",
- "serde_derive",
  "serde_json",
 ]
 
@@ -1636,9 +1646,9 @@ checksum = "2532096657941c2fea9c289d370a250971c689d4f143798ff67113ec042024a5"
 
 [[package]]
 name = "matchit"
-version = "0.8.6"
+version = "0.8.5"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "2f926ade0c4e170215ae43342bf13b9310a437609c81f29f86c5df6657582ef9"
+checksum = "bd0aa4b8ca861b08d68afc8702af3250776898c1508b278e1da9d01e01d4b45c"
 
 [[package]]
 name = "memchr"
@@ -1708,6 +1718,18 @@ dependencies = [
  "uuid",
 ]
 
+[[package]]
+name = "nix"
+version = "0.28.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "ab2156c4fce2f8df6c499cc1c763e4394b7482525bf2a9701c9d79d215f519e4"
+dependencies = [
+ "bitflags 2.6.0",
+ "cfg-if",
+ "cfg_aliases 0.1.1",
+ "libc",
+]
+
 [[package]]
 name = "nix"
 version = "0.29.0"
@@ -1716,7 +1738,7 @@ checksum = "71e2746dc3a24dd78b3cfcb7be93368c6de9963d30f43a6a73998a9cf4b17b46"
 dependencies = [
  "bitflags 2.6.0",
  "cfg-if",
- "cfg_aliases",
+ "cfg_aliases 0.2.1",
  "libc",
 ]
 
@@ -1992,7 +2014,7 @@ dependencies = [
  "pest_meta",
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -2139,7 +2161,7 @@ dependencies = [
  "newtype-uuid",
  "quick-xml",
  "strip-ansi-escapes",
- "thiserror 2.0.9",
+ "thiserror 2.0.6",
  "uuid",
 ]
 
@@ -2174,9 +2196,9 @@ dependencies = [
 
 [[package]]
 name = "quote"
-version = "1.0.38"
+version = "1.0.37"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "0e4dccaaaf89514f546c693ddc140f729f958c247918a13380cccc6078391acc"
+checksum = "b5b9d34b8991d19d98081b46eacdd8eb58c6f2b201139f7c5f643cc155a633af"
 dependencies = [
  "proc-macro2",
 ]
@@ -2266,11 +2288,10 @@ dependencies = [
  "compact_str",
  "countme",
  "dir-test",
- "drop_bomb",
  "hashbrown 0.15.2",
  "indexmap",
  "insta",
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "memchr",
  "ordermap",
  "quickcheck",
@@ -2284,7 +2305,6 @@ dependencies = [
  "ruff_python_literal",
  "ruff_python_parser",
  "ruff_python_stdlib",
- "ruff_python_trivia",
  "ruff_source_file",
  "ruff_text_size",
  "rustc-hash 2.1.0",
@@ -2294,7 +2314,7 @@ dependencies = [
  "static_assertions",
  "tempfile",
  "test-case",
- "thiserror 2.0.9",
+ "thiserror 2.0.6",
  "tracing",
 ]
 
@@ -2391,7 +2411,7 @@ dependencies = [
  "rustc-hash 2.1.0",
  "salsa",
  "serde",
- "thiserror 2.0.9",
+ "thiserror 2.0.6",
  "toml",
  "tracing",
 ]
@@ -2497,7 +2517,7 @@ dependencies = [
 
 [[package]]
 name = "ruff"
-version = "0.9.1"
+version = "0.8.3"
 dependencies = [
  "anyhow",
  "argfile",
@@ -2517,7 +2537,7 @@ dependencies = [
  "insta",
  "insta-cmd",
  "is-macro",
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "log",
  "mimalloc",
  "notify",
@@ -2544,7 +2564,7 @@ dependencies = [
  "strum",
  "tempfile",
  "test-case",
- "thiserror 2.0.9",
+ "thiserror 2.0.6",
  "tikv-jemallocator",
  "toml",
  "tracing",
@@ -2583,7 +2603,7 @@ dependencies = [
  "filetime",
  "glob",
  "globset",
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "regex",
  "ruff_macros",
  "seahash",
@@ -2614,7 +2634,7 @@ dependencies = [
  "salsa",
  "serde",
  "tempfile",
- "thiserror 2.0.9",
+ "thiserror 2.0.6",
  "tracing",
  "tracing-subscriber",
  "tracing-tree",
@@ -2632,7 +2652,7 @@ dependencies = [
  "imara-diff",
  "indicatif",
  "indoc",
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "libcst",
  "pretty_assertions",
  "rayon",
@@ -2716,7 +2736,7 @@ dependencies = [
 
 [[package]]
 name = "ruff_linter"
-version = "0.9.1"
+version = "0.8.3"
 dependencies = [
  "aho-corasick",
  "annotate-snippets 0.9.2",
@@ -2732,7 +2752,7 @@ dependencies = [
  "insta",
  "is-macro",
  "is-wsl",
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "libcst",
  "log",
  "memchr",
@@ -2745,7 +2765,6 @@ dependencies = [
  "regex",
  "ruff_cache",
  "ruff_diagnostics",
- "ruff_index",
  "ruff_macros",
  "ruff_notebook",
  "ruff_python_ast",
@@ -2767,7 +2786,7 @@ dependencies = [
  "strum",
  "strum_macros",
  "test-case",
- "thiserror 2.0.9",
+ "thiserror 2.0.6",
  "toml",
  "typed-arena",
  "unicode-normalization",
@@ -2780,11 +2799,11 @@ dependencies = [
 name = "ruff_macros"
 version = "0.0.0"
 dependencies = [
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "proc-macro2",
  "quote",
  "ruff_python_trivia",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -2792,7 +2811,7 @@ name = "ruff_notebook"
 version = "0.0.0"
 dependencies = [
  "anyhow",
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "rand",
  "ruff_diagnostics",
  "ruff_source_file",
@@ -2801,7 +2820,7 @@ dependencies = [
  "serde_json",
  "serde_with",
  "test-case",
- "thiserror 2.0.9",
+ "thiserror 2.0.6",
  "uuid",
 ]
 
@@ -2813,7 +2832,7 @@ dependencies = [
  "bitflags 2.6.0",
  "compact_str",
  "is-macro",
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "memchr",
  "ruff_cache",
  "ruff_macros",
@@ -2855,7 +2874,7 @@ dependencies = [
  "clap",
  "countme",
  "insta",
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "memchr",
  "regex",
  "ruff_cache",
@@ -2873,7 +2892,7 @@ dependencies = [
  "similar",
  "smallvec",
  "static_assertions",
- "thiserror 2.0.9",
+ "thiserror 2.0.6",
  "tracing",
 ]
 
@@ -2893,7 +2912,7 @@ name = "ruff_python_literal"
 version = "0.0.0"
 dependencies = [
  "bitflags 2.6.0",
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "ruff_python_ast",
  "unic-ucd-category",
 ]
@@ -2947,7 +2966,6 @@ dependencies = [
  "rustc-hash 2.1.0",
  "schemars",
  "serde",
- "smallvec",
 ]
 
 [[package]]
@@ -2962,7 +2980,7 @@ dependencies = [
 name = "ruff_python_trivia"
 version = "0.0.0"
 dependencies = [
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "ruff_source_file",
  "ruff_text_size",
  "unicode-ident",
@@ -3007,7 +3025,7 @@ dependencies = [
  "serde",
  "serde_json",
  "shellexpand",
- "thiserror 2.0.9",
+ "thiserror 2.0.6",
  "tracing",
  "tracing-subscriber",
 ]
@@ -3033,7 +3051,7 @@ dependencies = [
 
 [[package]]
 name = "ruff_wasm"
-version = "0.9.1"
+version = "0.8.3"
 dependencies = [
  "console_error_panic_hook",
  "console_log",
@@ -3067,7 +3085,7 @@ dependencies = [
  "globset",
  "ignore",
  "is-macro",
- "itertools 0.14.0",
+ "itertools 0.13.0",
  "log",
  "matchit",
  "path-absolutize",
@@ -3175,7 +3193,7 @@ checksum = "e86697c916019a8588c99b5fac3cead74ec0b4b819707a682fd4d23fa0ce1ba1"
 [[package]]
 name = "salsa"
 version = "0.18.0"
-source = "git+https://github.com/salsa-rs/salsa.git?rev=88a1d7774d78f048fbd77d40abca9ebd729fd1f0#88a1d7774d78f048fbd77d40abca9ebd729fd1f0"
+source = "git+https://github.com/salsa-rs/salsa.git?rev=254c749b02cde2fd29852a7463a33e800b771758#254c749b02cde2fd29852a7463a33e800b771758"
 dependencies = [
  "append-only-vec",
  "arc-swap",
@@ -3183,8 +3201,8 @@ dependencies = [
  "dashmap 6.1.0",
  "hashlink",
  "indexmap",
+ "lazy_static",
  "parking_lot",
- "rayon",
  "rustc-hash 2.1.0",
  "salsa-macro-rules",
  "salsa-macros",
@@ -3195,17 +3213,17 @@ dependencies = [
 [[package]]
 name = "salsa-macro-rules"
 version = "0.1.0"
-source = "git+https://github.com/salsa-rs/salsa.git?rev=88a1d7774d78f048fbd77d40abca9ebd729fd1f0#88a1d7774d78f048fbd77d40abca9ebd729fd1f0"
+source = "git+https://github.com/salsa-rs/salsa.git?rev=254c749b02cde2fd29852a7463a33e800b771758#254c749b02cde2fd29852a7463a33e800b771758"
 
 [[package]]
 name = "salsa-macros"
 version = "0.18.0"
-source = "git+https://github.com/salsa-rs/salsa.git?rev=88a1d7774d78f048fbd77d40abca9ebd729fd1f0#88a1d7774d78f048fbd77d40abca9ebd729fd1f0"
+source = "git+https://github.com/salsa-rs/salsa.git?rev=254c749b02cde2fd29852a7463a33e800b771758#254c749b02cde2fd29852a7463a33e800b771758"
 dependencies = [
  "heck",
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
  "synstructure",
 ]
 
@@ -3239,7 +3257,7 @@ dependencies = [
  "proc-macro2",
  "quote",
  "serde_derive_internals",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -3262,9 +3280,9 @@ checksum = "1c107b6f4780854c8b126e228ea8869f4d7b71260f962fefb57b996b8959ba6b"
 
 [[package]]
 name = "serde"
-version = "1.0.217"
+version = "1.0.215"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "02fc4265df13d6fa1d00ecff087228cc0a2b5f3c0e87e258d8b94a156e984c70"
+checksum = "6513c1ad0b11a9376da888e3e0baa0077f1aed55c17f50e7b2397136129fb88f"
 dependencies = [
  "serde_derive",
 ]
@@ -3282,13 +3300,13 @@ dependencies = [
 
 [[package]]
 name = "serde_derive"
-version = "1.0.217"
+version = "1.0.215"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5a9bf7cf98d04a2b28aead066b7496853d4779c9cc183c440dbac457641e19a0"
+checksum = "ad1e866f866923f252f05c889987993144fb74e722403468a4ebd70c3cd756c0"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -3299,14 +3317,14 @@ checksum = "330f01ce65a3a5fe59a60c82f3c9a024b573b8a6e875bd233fe5f934e71d54e3"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
 name = "serde_json"
-version = "1.0.134"
+version = "1.0.133"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d00f4175c42ee48b15416f6193a959ba3a0d67fc699a0db9ad12df9f83991c7d"
+checksum = "c7fceb2473b9166b2294ef05efcb65a3db80803f0b03ef86a5fc88a2b85ee377"
 dependencies = [
  "itoa",
  "memchr",
@@ -3322,7 +3340,7 @@ checksum = "6c64451ba24fc7a6a2d60fc75dd9c83c90903b19028d4eff35e88fc1e86564e9"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -3345,9 +3363,9 @@ dependencies = [
 
 [[package]]
 name = "serde_with"
-version = "3.12.0"
+version = "3.11.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d6b6f7f2fcb69f747921f79f3926bd1e203fce4fef62c268dd3abfb6d86029aa"
+checksum = "8e28bdad6db2b8340e449f7108f020b3b092e8583a9e3fb82713e1d4e71fe817"
 dependencies = [
  "serde",
  "serde_derive",
@@ -3356,14 +3374,14 @@ dependencies = [
 
 [[package]]
 name = "serde_with_macros"
-version = "3.12.0"
+version = "3.11.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8d00caa5193a3c8362ac2b73be6b9e768aa5a4b2f721d8f4b339600c3cb51f8e"
+checksum = "9d846214a9854ef724f3da161b426242d8de7c1fc7de2f89bb1efcb154dca79d"
 dependencies = [
  "darling",
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -3392,7 +3410,7 @@ version = "3.1.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "da03fa3b94cc19e3ebfc88c4229c49d8f08cdbd1228870a45f0ffdf84988e14b"
 dependencies = [
- "dirs",
+ "dirs 5.0.1",
 ]
 
 [[package]]
@@ -3477,7 +3495,7 @@ dependencies = [
  "proc-macro2",
  "quote",
  "rustversion",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -3499,9 +3517,9 @@ dependencies = [
 
 [[package]]
 name = "syn"
-version = "2.0.95"
+version = "2.0.90"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "46f71c0377baf4ef1cc3e3402ded576dccc315800fbc62dfc7fe04b009773b4a"
+checksum = "919d3b74a5dd0ccd15aeb8f93e7006bd9e14c295087c9896a110f490752bcf31"
 dependencies = [
  "proc-macro2",
  "quote",
@@ -3516,7 +3534,7 @@ checksum = "c8af7666ab7b6390ab78131fb5b0fce11d6b7a6951602017c35fa82800708971"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -3544,10 +3562,11 @@ dependencies = [
 
 [[package]]
 name = "terminfo"
-version = "0.9.0"
+version = "0.8.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d4ea810f0692f9f51b382fff5893887bb4580f5fa246fde546e0b13e7fcee662"
+checksum = "666cd3a6681775d22b200409aad3b089c5b99fb11ecdd8a204d9d62f8148498f"
 dependencies = [
+ "dirs 4.0.0",
  "fnv",
  "nom",
  "phf",
@@ -3578,7 +3597,7 @@ dependencies = [
  "cfg-if",
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -3589,7 +3608,7 @@ checksum = "5c89e72a01ed4c579669add59014b9a524d609c0c88c6a585ce37485879f6ffb"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
  "test-case-core",
 ]
 
@@ -3604,11 +3623,11 @@ dependencies = [
 
 [[package]]
 name = "thiserror"
-version = "2.0.9"
+version = "2.0.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f072643fd0190df67a8bab670c20ef5d8737177d6ac6b2e9a236cb096206b2cc"
+checksum = "8fec2a1820ebd077e2b90c4df007bebf344cd394098a13c563957d0afc83ea47"
 dependencies = [
- "thiserror-impl 2.0.9",
+ "thiserror-impl 2.0.6",
 ]
 
 [[package]]
@@ -3619,18 +3638,18 @@ checksum = "b607164372e89797d78b8e23a6d67d5d1038c1c65efd52e1389ef8b77caba2a6"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
 name = "thiserror-impl"
-version = "2.0.9"
+version = "2.0.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7b50fa271071aae2e6ee85f842e2e28ba8cd2c5fb67f11fcb1fd70b276f9e7d4"
+checksum = "d65750cab40f4ff1929fb1ba509e9914eb756131cef4210da8d5d700d26f6312"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -3752,7 +3771,7 @@ checksum = "395ae124c09f9e6918a2310af6038fba074bcf474ac352496d5910dd59a2226d"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -4022,7 +4041,7 @@ checksum = "6b91f57fe13a38d0ce9e28a03463d8d3c2468ed03d75375110ec71d93b449a08"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -4117,7 +4136,7 @@ dependencies = [
  "once_cell",
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
  "wasm-bindgen-shared",
 ]
 
@@ -4152,7 +4171,7 @@ checksum = "98c9ae5a76e46f4deecd0f0255cc223cfa18dc9b261213b8aa0c7b36f61b3f1d"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
  "wasm-bindgen-backend",
  "wasm-bindgen-shared",
 ]
@@ -4186,7 +4205,7 @@ checksum = "222ebde6ea87fbfa6bdd2e9f1fd8a91d60aee5db68792632176c4e16a74fc7d8"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -4220,12 +4239,12 @@ dependencies = [
 
 [[package]]
 name = "which"
-version = "7.0.1"
+version = "6.0.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "fb4a9e33648339dc1642b0e36e21b3385e6148e289226f657c809dee59df5028"
+checksum = "8211e4f58a2b2805adfbefbc07bab82958fc91e3836339b1ab7ae32465dce0d7"
 dependencies = [
  "either",
- "env_home",
+ "home",
  "rustix",
  "winsafe",
 ]
@@ -4489,7 +4508,7 @@ checksum = "28cc31741b18cb6f1d5ff12f5b7523e3d6eb0852bbbad19d73905511d9849b95"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
  "synstructure",
 ]
 
@@ -4510,7 +4529,7 @@ checksum = "9ce1b18ccd8e73a9321186f97e46f9f04b778851177567b1975109d26a08d2a6"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]
@@ -4530,7 +4549,7 @@ checksum = "0ea7b4a3637ea8669cedf0f1fd5c286a17f3de97b8dd5a70a6c167a1730e63a5"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
  "synstructure",
 ]
 
@@ -4559,7 +4578,7 @@ checksum = "6eafa6dfb17584ea3e2bd6e76e0cc15ad7af12b09abdd1ca55961bed9b1063c6"
 dependencies = [
  "proc-macro2",
  "quote",
- "syn 2.0.95",
+ "syn 2.0.90",
 ]
 
 [[package]]

Cargo.toml

@@ -55,7 +55,7 @@ camino = { version = "1.1.7" }
 chrono = { version = "0.4.35", default-features = false, features = ["clock"] }
 clap = { version = "4.5.3", features = ["derive"] }
 clap_complete_command = { version = "0.6.0" }
-clearscreen = { version = "4.0.0" }
+clearscreen = { version = "3.0.0" }
 codspeed-criterion-compat = { version = "2.6.0", default-features = false }
 colored = { version = "2.1.0" }
 console_error_panic_hook = { version = "0.1.7" }
@@ -89,7 +89,7 @@ insta = { version = "1.35.1" }
 insta-cmd = { version = "0.6.0" }
 is-macro = { version = "0.3.5" }
 is-wsl = { version = "0.4.0" }
-itertools = { version = "0.14.0" }
+itertools = { version = "0.13.0" }
 js-sys = { version = "0.3.69" }
 jod-thread = { version = "0.1.2" }
 libc = { version = "0.2.153" }
@@ -118,8 +118,7 @@ rand = { version = "0.8.5" }
 rayon = { version = "1.10.0" }
 regex = { version = "1.10.2" }
 rustc-hash = { version = "2.0.0" }
-# When updating salsa, make sure to also update the revision in `fuzz/Cargo.toml`
-salsa = { git = "https://github.com/salsa-rs/salsa.git", rev = "88a1d7774d78f048fbd77d40abca9ebd729fd1f0" }
+salsa = { git = "https://github.com/salsa-rs/salsa.git", rev = "254c749b02cde2fd29852a7463a33e800b771758" }
 schemars = { version = "0.8.16" }
 seahash = { version = "4.1.0" }
 serde = { version = "1.0.197", features = ["derive"] }

README.md

@@ -116,21 +116,12 @@ For more, see the [documentation](https://docs.astral.sh/ruff/).
 
 ### Installation
 
-Ruff is available as [`ruff`](https://pypi.org/project/ruff/) on PyPI.
-
-Invoke Ruff directly with [`uvx`](https://docs.astral.sh/uv/):
-
-```shell
-uvx ruff check   # Lint all files in the current directory.
-uvx ruff format  # Format all files in the current directory.
-```
-
-Or install Ruff with `uv` (recommended), `pip`, or `pipx`:
+Ruff is available as [`ruff`](https://pypi.org/project/ruff/) on PyPI:
 
 ```shell
 # With uv.
-uv tool install ruff@latest  # Install Ruff globally.
-uv add --dev ruff            # Or add Ruff to your project.
+uv add --dev ruff     # to add ruff to your project
+uv tool install ruff  # to install ruff globally
 
 # With pip.
 pip install ruff
@@ -149,8 +140,8 @@ curl -LsSf https://astral.sh/ruff/install.sh | sh
 powershell -c "irm https://astral.sh/ruff/install.ps1 | iex"
 
 # For a specific version.
-curl -LsSf https://astral.sh/ruff/0.9.1/install.sh | sh
-powershell -c "irm https://astral.sh/ruff/0.9.1/install.ps1 | iex"
+curl -LsSf https://astral.sh/ruff/0.8.3/install.sh | sh
+powershell -c "irm https://astral.sh/ruff/0.8.3/install.ps1 | iex"
 ```
 
 You can also install Ruff via [Homebrew](https://formulae.brew.sh/formula/ruff), [Conda](https://anaconda.org/conda-forge/ruff),
@@ -183,7 +174,7 @@ Ruff can also be used as a [pre-commit](https://pre-commit.com/) hook via [`ruff
 ```yaml
 - repo: https://github.com/astral-sh/ruff-pre-commit
   # Ruff version.
-  rev: v0.9.1
+  rev: v0.8.3
   hooks:
     # Run the linter.
     - id: ruff
@@ -205,7 +196,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: astral-sh/ruff-action@v3
+      - uses: astral-sh/ruff-action@v1
 ```
 
 ### Configuration<a id="configuration"></a>

crates/red_knot/src/main.rs

@@ -279,7 +279,7 @@ impl MainLoop {
         while let Ok(message) = self.receiver.recv() {
             match message {
                 MainLoopMessage::CheckWorkspace => {
-                    let db = db.clone();
+                    let db = db.snapshot();
                     let sender = self.sender.clone();
 
                     // Spawn a new task that checks the workspace. This needs to be done in a separate thread

crates/red_knot_python_semantic/Cargo.toml

@@ -20,14 +20,12 @@ ruff_python_stdlib = { workspace = true }
 ruff_source_file = { workspace = true }
 ruff_text_size = { workspace = true }
 ruff_python_literal = { workspace = true }
-ruff_python_trivia = { workspace = true }
 
 anyhow = { workspace = true }
 bitflags = { workspace = true }
 camino = { workspace = true }
 compact_str = { workspace = true }
 countme = { workspace = true }
-drop_bomb = { workspace = true }
 indexmap = { workspace = true }
 itertools = { workspace = true }
 ordermap = { workspace = true }
@@ -60,3 +58,4 @@ serde = ["ruff_db/serde", "dep:serde"]
 
 [lints]
 workspace = true
+

crates/red_knot_python_semantic/resources/mdtest/annotations/literal.md

@@ -9,6 +9,8 @@ from typing import Literal
 from enum import Enum
 
 mode: Literal["w", "r"]
+mode2: Literal["w"] | Literal["r"]
+union_var: Literal[Literal[Literal[1, 2, 3], "foo"], 5, None]
 a1: Literal[26]
 a2: Literal[0x1A]
 a3: Literal[-4]
@@ -17,6 +19,7 @@ a5: Literal[b"hello world"]
 a6: Literal[True]
 a7: Literal[None]
 a8: Literal[Literal[1]]
+a9: Literal[Literal["w"], Literal["r"], Literal[Literal["w+"]]]
 
 class Color(Enum):
     RED = 0
@@ -27,6 +30,9 @@ b1: Literal[Color.RED]
 
 def f():
     reveal_type(mode)  # revealed: Literal["w", "r"]
+    reveal_type(mode2)  # revealed: Literal["w", "r"]
+    # TODO: should be revealed: Literal[1, 2, 3, "foo", 5] | None
+    reveal_type(union_var)  # revealed: Literal[1, 2, 3, 5] | Literal["foo"] | None
     reveal_type(a1)  # revealed: Literal[26]
     reveal_type(a2)  # revealed: Literal[26]
     reveal_type(a3)  # revealed: Literal[-4]
@@ -35,6 +41,7 @@ def f():
     reveal_type(a6)  # revealed: Literal[True]
     reveal_type(a7)  # revealed: None
     reveal_type(a8)  # revealed: Literal[1]
+    reveal_type(a9)  # revealed: Literal["w", "r", "w+"]
     # TODO: This should be Color.RED
     reveal_type(b1)  # revealed: Literal[0]
 
@@ -54,63 +61,6 @@ invalid4: Literal[
 ]
 ```
 
-## Shortening unions of literals
-
-When a Literal is parameterized with more than one value, it’s treated as exactly to equivalent to
-the union of those types.
-
-```py
-from typing import Literal
-
-def x(
-    a1: Literal[Literal[Literal[1, 2, 3], "foo"], 5, None],
-    a2: Literal["w"] | Literal["r"],
-    a3: Literal[Literal["w"], Literal["r"], Literal[Literal["w+"]]],
-    a4: Literal[True] | Literal[1, 2] | Literal["foo"],
-):
-    reveal_type(a1)  # revealed: Literal[1, 2, 3, "foo", 5] | None
-    reveal_type(a2)  # revealed: Literal["w", "r"]
-    reveal_type(a3)  # revealed: Literal["w", "r", "w+"]
-    reveal_type(a4)  # revealed: Literal[True, 1, 2, "foo"]
-```
-
-## Display of heterogeneous unions of literals
-
-```py
-from typing import Literal, Union
-
-def foo(x: int) -> int:
-    return x + 1
-
-def bar(s: str) -> str:
-    return s
-
-class A: ...
-class B: ...
-
-def union_example(
-    x: Union[
-        # unknown type
-        # error: [unresolved-reference]
-        y,
-        Literal[-1],
-        Literal["A"],
-        Literal[b"A"],
-        Literal[b"\x00"],
-        Literal[b"\x07"],
-        Literal[0],
-        Literal[1],
-        Literal["B"],
-        Literal["foo"],
-        Literal["bar"],
-        Literal["B"],
-        Literal[True],
-        None,
-    ]
-):
-    reveal_type(x)  # revealed: Unknown | Literal[-1, "A", b"A", b"\x00", b"\x07", 0, 1, "B", "foo", "bar", True] | None
-```
-
 ## Detecting Literal outside typing and typing_extensions
 
 Only Literal that is defined in typing and typing_extension modules is detected as the special

crates/red_knot_python_semantic/resources/mdtest/annotations/literal_string.md

@@ -73,12 +73,12 @@ qux = (foo, bar)
 reveal_type(qux)  # revealed: tuple[Literal["foo"], Literal["bar"]]
 
 # TODO: Infer "LiteralString"
-reveal_type(foo.join(qux))  # revealed: @Todo(Attribute access on `StringLiteral` types)
+reveal_type(foo.join(qux))  # revealed: @Todo(call todo)
 
 template: LiteralString = "{}, {}"
 reveal_type(template)  # revealed: Literal["{}, {}"]
 # TODO: Infer `LiteralString`
-reveal_type(template.format(foo, bar))  # revealed: @Todo(Attribute access on `StringLiteral` types)
+reveal_type(template.format(foo, bar))  # revealed: @Todo(call todo)
 ```
 
 ### Assignability
@@ -107,7 +107,7 @@ def _(flag: bool):
     qux_2: Literal["qux"] = baz_2  # error: [invalid-assignment]
 
     baz_3 = "foo" if flag else 1
-    reveal_type(baz_3)  # revealed: Literal["foo", 1]
+    reveal_type(baz_3)  # revealed: Literal["foo"] | Literal[1]
     qux_3: LiteralString = baz_3  # error: [invalid-assignment]
 ```
 

crates/red_knot_python_semantic/resources/mdtest/annotations/never.md

@@ -47,9 +47,7 @@ def f():
 
 ## `typing.Never`
 
-`typing.Never` is only available in Python 3.11 and later.
-
-### Python 3.11
+`typing.Never` is only available in Python 3.11 and later:
 
 ```toml
 [environment]
@@ -59,17 +57,8 @@ python-version = "3.11"
 ```py
 from typing import Never
 
-reveal_type(Never)  # revealed: typing.Never
-```
+x: Never
 
-### Python 3.10
-
-```toml
-[environment]
-python-version = "3.10"
-```
-
-```py
-# error: [unresolved-import]
-from typing import Never
+def f():
+    reveal_type(x)  # revealed: Never
 ```

crates/red_knot_python_semantic/resources/mdtest/annotations/stdlib_typing_aliases.md

@@ -3,59 +3,43 @@
 The `typing` module has various aliases to other stdlib classes. These are a legacy feature, but
 still need to be supported by a type checker.
 
-## Correspondence
+## Currently unsupported
 
-All of the following symbols can be mapped one-to-one with the actual type:
+Support for most of these symbols is currently a TODO:
 
 ```py
 import typing
 
 def f(
-    list_bare: typing.List,
-    list_parametrized: typing.List[int],
-    dict_bare: typing.Dict,
-    dict_parametrized: typing.Dict[int, str],
-    set_bare: typing.Set,
-    set_parametrized: typing.Set[int],
-    frozen_set_bare: typing.FrozenSet,
-    frozen_set_parametrized: typing.FrozenSet[str],
-    chain_map_bare: typing.ChainMap,
-    chain_map_parametrized: typing.ChainMap[int],
-    counter_bare: typing.Counter,
-    counter_parametrized: typing.Counter[int],
-    default_dict_bare: typing.DefaultDict,
-    default_dict_parametrized: typing.DefaultDict[str, int],
-    deque_bare: typing.Deque,
-    deque_parametrized: typing.Deque[str],
-    ordered_dict_bare: typing.OrderedDict,
-    ordered_dict_parametrized: typing.OrderedDict[int, str],
+    a: typing.List,
+    b: typing.List[int],
+    c: typing.Dict,
+    d: typing.Dict[int, str],
+    e: typing.DefaultDict,
+    f: typing.DefaultDict[str, int],
+    g: typing.Set,
+    h: typing.Set[int],
+    i: typing.FrozenSet,
+    j: typing.FrozenSet[str],
+    k: typing.OrderedDict,
+    l: typing.OrderedDict[int, str],
+    m: typing.Counter,
+    n: typing.Counter[int],
 ):
-    reveal_type(list_bare)  # revealed: list
-    reveal_type(list_parametrized)  # revealed: list
-
-    reveal_type(dict_bare)  # revealed: dict
-    reveal_type(dict_parametrized)  # revealed: dict
-
-    reveal_type(set_bare)  # revealed: set
-    reveal_type(set_parametrized)  # revealed: set
-
-    reveal_type(frozen_set_bare)  # revealed: frozenset
-    reveal_type(frozen_set_parametrized)  # revealed: frozenset
-
-    reveal_type(chain_map_bare)  # revealed: ChainMap
-    reveal_type(chain_map_parametrized)  # revealed: ChainMap
-
-    reveal_type(counter_bare)  # revealed: Counter
-    reveal_type(counter_parametrized)  # revealed: Counter
-
-    reveal_type(default_dict_bare)  # revealed: defaultdict
-    reveal_type(default_dict_parametrized)  # revealed: defaultdict
-
-    reveal_type(deque_bare)  # revealed: deque
-    reveal_type(deque_parametrized)  # revealed: deque
-
-    reveal_type(ordered_dict_bare)  # revealed: OrderedDict
-    reveal_type(ordered_dict_parametrized)  # revealed: OrderedDict
+    reveal_type(a)  # revealed: @Todo(Unsupported or invalid type in a type expression)
+    reveal_type(b)  # revealed: @Todo(typing.List alias)
+    reveal_type(c)  # revealed: @Todo(Unsupported or invalid type in a type expression)
+    reveal_type(d)  # revealed: @Todo(typing.Dict alias)
+    reveal_type(e)  # revealed: @Todo(Unsupported or invalid type in a type expression)
+    reveal_type(f)  # revealed: @Todo(typing.DefaultDict[] alias)
+    reveal_type(g)  # revealed: @Todo(Unsupported or invalid type in a type expression)
+    reveal_type(h)  # revealed: @Todo(typing.Set alias)
+    reveal_type(i)  # revealed: @Todo(Unsupported or invalid type in a type expression)
+    reveal_type(j)  # revealed: @Todo(typing.FrozenSet alias)
+    reveal_type(k)  # revealed: @Todo(Unsupported or invalid type in a type expression)
+    reveal_type(l)  # revealed: @Todo(typing.OrderedDict alias)
+    reveal_type(m)  # revealed: @Todo(Unsupported or invalid type in a type expression)
+    reveal_type(n)  # revealed: @Todo(typing.Counter[] alias)
 ```
 
 ## Inheritance
@@ -65,63 +49,35 @@ The aliases can be inherited from. Some of these are still partially or wholly T
 ```py
 import typing
 
-####################
-### Built-ins
-
-class ListSubclass(typing.List): ...
+class A(typing.Dict): ...
 
 # TODO: should have `Generic`, should not have `Unknown`
-# revealed: tuple[Literal[ListSubclass], Literal[list], Unknown, Literal[object]]
-reveal_type(ListSubclass.__mro__)
+reveal_type(A.__mro__)  # revealed: tuple[Literal[A], Literal[dict], Unknown, Literal[object]]
 
-class DictSubclass(typing.Dict): ...
+class B(typing.List): ...
 
 # TODO: should have `Generic`, should not have `Unknown`
-# revealed: tuple[Literal[DictSubclass], Literal[dict], Unknown, Literal[object]]
-reveal_type(DictSubclass.__mro__)
+reveal_type(B.__mro__)  # revealed: tuple[Literal[B], Literal[list], Unknown, Literal[object]]
 
-class SetSubclass(typing.Set): ...
+class C(typing.Set): ...
 
 # TODO: should have `Generic`, should not have `Unknown`
-# revealed: tuple[Literal[SetSubclass], Literal[set], Unknown, Literal[object]]
-reveal_type(SetSubclass.__mro__)
+reveal_type(C.__mro__)  # revealed: tuple[Literal[C], Literal[set], Unknown, Literal[object]]
 
-class FrozenSetSubclass(typing.FrozenSet): ...
+class D(typing.FrozenSet): ...
 
 # TODO: should have `Generic`, should not have `Unknown`
-# revealed: tuple[Literal[FrozenSetSubclass], Literal[frozenset], Unknown, Literal[object]]
-reveal_type(FrozenSetSubclass.__mro__)
+reveal_type(D.__mro__)  # revealed: tuple[Literal[D], Literal[frozenset], Unknown, Literal[object]]
 
-####################
-### `collections`
+class E(typing.DefaultDict): ...
 
-class ChainMapSubclass(typing.ChainMap): ...
+reveal_type(E.__mro__)  # revealed: tuple[Literal[E], @Todo(Support for more typing aliases as base classes), Literal[object]]
 
-# TODO: Should be (ChainMapSubclass, ChainMap, MutableMapping, Mapping, Collection, Sized, Iterable, Container, Generic, object)
-# revealed: tuple[Literal[ChainMapSubclass], Literal[ChainMap], Unknown, Literal[object]]
-reveal_type(ChainMapSubclass.__mro__)
+class F(typing.OrderedDict): ...
 
-class CounterSubclass(typing.Counter): ...
+reveal_type(F.__mro__)  # revealed: tuple[Literal[F], @Todo(Support for more typing aliases as base classes), Literal[object]]
 
-# TODO: Should be (CounterSubclass, Counter, dict, MutableMapping, Mapping, Collection, Sized, Iterable, Container, Generic, object)
-# revealed: tuple[Literal[CounterSubclass], Literal[Counter], Unknown, Literal[object]]
-reveal_type(CounterSubclass.__mro__)
+class G(typing.Counter): ...
 
-class DefaultDictSubclass(typing.DefaultDict): ...
-
-# TODO: Should be (DefaultDictSubclass, defaultdict, dict, MutableMapping, Mapping, Collection, Sized, Iterable, Container, Generic, object)
-# revealed: tuple[Literal[DefaultDictSubclass], Literal[defaultdict], Unknown, Literal[object]]
-reveal_type(DefaultDictSubclass.__mro__)
-
-class DequeSubclass(typing.Deque): ...
-
-# TODO: Should be (DequeSubclass, deque, MutableSequence, Sequence, Reversible, Collection, Sized, Iterable, Container, Generic, object)
-# revealed: tuple[Literal[DequeSubclass], Literal[deque], Unknown, Literal[object]]
-reveal_type(DequeSubclass.__mro__)
-
-class OrderedDictSubclass(typing.OrderedDict): ...
-
-# TODO: Should be (OrderedDictSubclass, OrderedDict, dict, MutableMapping, Mapping, Collection, Sized, Iterable, Container, Generic, object)
-# revealed: tuple[Literal[OrderedDictSubclass], Literal[OrderedDict], Unknown, Literal[object]]
-reveal_type(OrderedDictSubclass.__mro__)
+reveal_type(G.__mro__)  # revealed: tuple[Literal[G], @Todo(Support for more typing aliases as base classes), Literal[object]]
 ```

crates/red_knot_python_semantic/resources/mdtest/annotations/string.md

@@ -105,7 +105,7 @@ def f1(
 from typing import Literal
 
 def f(v: Literal["a", r"b", b"c", "d" "e", "\N{LATIN SMALL LETTER F}", "\x67", """h"""]):
-    reveal_type(v)  # revealed: Literal["a", "b", b"c", "de", "f", "g", "h"]
+    reveal_type(v)  # revealed: Literal["a", "b", "de", "f", "g", "h"] | Literal[b"c"]
 ```
 
 ## Class variables

crates/red_knot_python_semantic/resources/mdtest/annotations/unsupported_special_forms.md

@@ -51,7 +51,7 @@ class D(TypeIs): ...  # error: [invalid-base]
 class E(Concatenate): ...  # error: [invalid-base]
 class F(Callable): ...
 
-reveal_type(F.__mro__)  # revealed: tuple[Literal[F], @Todo(Support for Callable as a base class), Literal[object]]
+reveal_type(F.__mro__)  # revealed: tuple[Literal[F], @Todo(Support for more typing aliases as base classes), Literal[object]]
 ```
 
 ## Subscriptability

crates/red_knot_python_semantic/resources/mdtest/assignment/annotations.md

@@ -33,6 +33,8 @@ b: tuple[int] = (42,)
 c: tuple[str, int] = ("42", 42)
 d: tuple[tuple[str, str], tuple[int, int]] = (("foo", "foo"), (42, 42))
 e: tuple[str, ...] = ()
+# TODO: we should not emit this error
+# error: [call-possibly-unbound-method] "Method `__class_getitem__` of type `Literal[tuple]` is possibly unbound"
 f: tuple[str, *tuple[int, ...], bytes] = ("42", b"42")
 g: tuple[str, Unpack[tuple[int, ...]], bytes] = ("42", b"42")
 h: tuple[list[int], list[int]] = ([], [])
@@ -122,10 +124,3 @@ class Foo: ...
 x = Foo()
 reveal_type(x)  # revealed: Foo
 ```
-
-## Annotated assignments in stub files are inferred correctly
-
-```pyi path=main.pyi
-x: int = 1
-reveal_type(x) # revealed: Literal[1]
-```

crates/red_knot_python_semantic/resources/mdtest/assignment/augmented.md

@@ -40,9 +40,9 @@ class C:
         return 42
 
 x = C()
-# error: [invalid-argument-type]
 x -= 1
 
+# TODO: should error, once operand type check is implemented
 reveal_type(x)  # revealed: int
 ```
 

crates/red_knot_python_semantic/resources/mdtest/attributes.md

@@ -1,6 +1,4 @@
-# Attributes
-
-Tests for attribute access on various kinds of types.
+# Class attributes
 
 ## Union of attributes
 
@@ -157,67 +155,3 @@ class Foo: ...
 
 reveal_type(Foo.__class__)  # revealed: Literal[type]
 ```
-
-## Function-literal attributes
-
-Most attribute accesses on function-literal types are delegated to `types.FunctionType`, since all
-functions are instances of that class:
-
-```py path=a.py
-def f(): ...
-
-reveal_type(f.__defaults__)  # revealed: @Todo(instance attributes)
-reveal_type(f.__kwdefaults__)  # revealed: @Todo(instance attributes)
-```
-
-Some attributes are special-cased, however:
-
-```py path=b.py
-def f(): ...
-
-reveal_type(f.__get__)  # revealed: @Todo(`__get__` method on functions)
-reveal_type(f.__call__)  # revealed: @Todo(`__call__` method on functions)
-```
-
-## Int-literal attributes
-
-Most attribute accesses on int-literal types are delegated to `builtins.int`, since all literal
-integers are instances of that class:
-
-```py path=a.py
-reveal_type((2).bit_length)  # revealed: @Todo(instance attributes)
-reveal_type((2).denominator)  # revealed: @Todo(instance attributes)
-```
-
-Some attributes are special-cased, however:
-
-```py path=b.py
-reveal_type((2).numerator)  # revealed: Literal[2]
-reveal_type((2).real)  # revealed: Literal[2]
-```
-
-## Literal `bool` attributes
-
-Most attribute accesses on bool-literal types are delegated to `builtins.bool`, since all literal
-bols are instances of that class:
-
-```py path=a.py
-reveal_type(True.__and__)  # revealed: @Todo(instance attributes)
-reveal_type(False.__or__)  # revealed: @Todo(instance attributes)
-```
-
-Some attributes are special-cased, however:
-
-```py path=b.py
-reveal_type(True.numerator)  # revealed: Literal[1]
-reveal_type(False.real)  # revealed: Literal[0]
-```
-
-## Bytes-literal attributes
-
-All attribute access on literal `bytes` types is currently delegated to `buitins.bytes`:
-
-```py
-reveal_type(b"foo".join)  # revealed: @Todo(instance attributes)
-reveal_type(b"foo".endswith)  # revealed: @Todo(instance attributes)
-```

crates/red_knot_python_semantic/resources/mdtest/binary/booleans.md

@@ -46,50 +46,3 @@ reveal_type(a | b)  # revealed: Literal[True]
 reveal_type(b | a)  # revealed: Literal[True]
 reveal_type(b | b)  # revealed: Literal[False]
 ```
-
-## Arithmetic with a variable
-
-```py
-a = True
-b = False
-
-def lhs_is_int(x: int):
-    reveal_type(x + a)  # revealed: int
-    reveal_type(x - a)  # revealed: int
-    reveal_type(x * a)  # revealed: int
-    reveal_type(x // a)  # revealed: int
-    reveal_type(x / a)  # revealed: float
-    reveal_type(x % a)  # revealed: int
-
-def rhs_is_int(x: int):
-    reveal_type(a + x)  # revealed: int
-    reveal_type(a - x)  # revealed: int
-    reveal_type(a * x)  # revealed: int
-    reveal_type(a // x)  # revealed: int
-    reveal_type(a / x)  # revealed: float
-    reveal_type(a % x)  # revealed: int
-
-def lhs_is_bool(x: bool):
-    reveal_type(x + a)  # revealed: int
-    reveal_type(x - a)  # revealed: int
-    reveal_type(x * a)  # revealed: int
-    reveal_type(x // a)  # revealed: int
-    reveal_type(x / a)  # revealed: float
-    reveal_type(x % a)  # revealed: int
-
-def rhs_is_bool(x: bool):
-    reveal_type(a + x)  # revealed: int
-    reveal_type(a - x)  # revealed: int
-    reveal_type(a * x)  # revealed: int
-    reveal_type(a // x)  # revealed: int
-    reveal_type(a / x)  # revealed: float
-    reveal_type(a % x)  # revealed: int
-
-def both_are_bool(x: bool, y: bool):
-    reveal_type(x + y)  # revealed: int
-    reveal_type(x - y)  # revealed: int
-    reveal_type(x * y)  # revealed: int
-    reveal_type(x // y)  # revealed: int
-    reveal_type(x / y)  # revealed: float
-    reveal_type(x % y)  # revealed: int
-```

crates/red_knot_python_semantic/resources/mdtest/binary/classes.md

@@ -1,27 +0,0 @@
-# Binary operations on classes
-
-## Union of two classes
-
-Unioning two classes via the `|` operator is only available in Python 3.10 and later.
-
-```toml
-[environment]
-python-version = "3.10"
-```
-
-```py
-class A: ...
-class B: ...
-
-reveal_type(A | B)  # revealed: UnionType
-```
-
-## Union of two classes (prior to 3.10)
-
-```py
-class A: ...
-class B: ...
-
-# error: "Operator `|` is unsupported between objects of type `Literal[A]` and `Literal[B]`"
-reveal_type(A | B)  # revealed: Unknown
-```

crates/red_knot_python_semantic/resources/mdtest/binary/custom.md

@@ -1,371 +0,0 @@
-# Custom binary operations
-
-## Class instances
-
-```py
-class Yes:
-    def __add__(self, other) -> Literal["+"]:
-        return "+"
-
-    def __sub__(self, other) -> Literal["-"]:
-        return "-"
-
-    def __mul__(self, other) -> Literal["*"]:
-        return "*"
-
-    def __matmul__(self, other) -> Literal["@"]:
-        return "@"
-
-    def __truediv__(self, other) -> Literal["/"]:
-        return "/"
-
-    def __mod__(self, other) -> Literal["%"]:
-        return "%"
-
-    def __pow__(self, other) -> Literal["**"]:
-        return "**"
-
-    def __lshift__(self, other) -> Literal["<<"]:
-        return "<<"
-
-    def __rshift__(self, other) -> Literal[">>"]:
-        return ">>"
-
-    def __or__(self, other) -> Literal["|"]:
-        return "|"
-
-    def __xor__(self, other) -> Literal["^"]:
-        return "^"
-
-    def __and__(self, other) -> Literal["&"]:
-        return "&"
-
-    def __floordiv__(self, other) -> Literal["//"]:
-        return "//"
-
-class Sub(Yes): ...
-class No: ...
-
-# Yes implements all of the dunder methods.
-reveal_type(Yes() + Yes())  # revealed: Literal["+"]
-reveal_type(Yes() - Yes())  # revealed: Literal["-"]
-reveal_type(Yes() * Yes())  # revealed: Literal["*"]
-reveal_type(Yes() @ Yes())  # revealed: Literal["@"]
-reveal_type(Yes() / Yes())  # revealed: Literal["/"]
-reveal_type(Yes() % Yes())  # revealed: Literal["%"]
-reveal_type(Yes() ** Yes())  # revealed: Literal["**"]
-reveal_type(Yes() << Yes())  # revealed: Literal["<<"]
-reveal_type(Yes() >> Yes())  # revealed: Literal[">>"]
-reveal_type(Yes() | Yes())  # revealed: Literal["|"]
-reveal_type(Yes() ^ Yes())  # revealed: Literal["^"]
-reveal_type(Yes() & Yes())  # revealed: Literal["&"]
-reveal_type(Yes() // Yes())  # revealed: Literal["//"]
-
-# Sub inherits Yes's implementation of the dunder methods.
-reveal_type(Sub() + Sub())  # revealed: Literal["+"]
-reveal_type(Sub() - Sub())  # revealed: Literal["-"]
-reveal_type(Sub() * Sub())  # revealed: Literal["*"]
-reveal_type(Sub() @ Sub())  # revealed: Literal["@"]
-reveal_type(Sub() / Sub())  # revealed: Literal["/"]
-reveal_type(Sub() % Sub())  # revealed: Literal["%"]
-reveal_type(Sub() ** Sub())  # revealed: Literal["**"]
-reveal_type(Sub() << Sub())  # revealed: Literal["<<"]
-reveal_type(Sub() >> Sub())  # revealed: Literal[">>"]
-reveal_type(Sub() | Sub())  # revealed: Literal["|"]
-reveal_type(Sub() ^ Sub())  # revealed: Literal["^"]
-reveal_type(Sub() & Sub())  # revealed: Literal["&"]
-reveal_type(Sub() // Sub())  # revealed: Literal["//"]
-
-# No does not implement any of the dunder methods.
-# error: [unsupported-operator] "Operator `+` is unsupported between objects of type `No` and `No`"
-reveal_type(No() + No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `-` is unsupported between objects of type `No` and `No`"
-reveal_type(No() - No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `*` is unsupported between objects of type `No` and `No`"
-reveal_type(No() * No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `@` is unsupported between objects of type `No` and `No`"
-reveal_type(No() @ No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `/` is unsupported between objects of type `No` and `No`"
-reveal_type(No() / No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `%` is unsupported between objects of type `No` and `No`"
-reveal_type(No() % No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `**` is unsupported between objects of type `No` and `No`"
-reveal_type(No() ** No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `<<` is unsupported between objects of type `No` and `No`"
-reveal_type(No() << No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `>>` is unsupported between objects of type `No` and `No`"
-reveal_type(No() >> No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `|` is unsupported between objects of type `No` and `No`"
-reveal_type(No() | No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `^` is unsupported between objects of type `No` and `No`"
-reveal_type(No() ^ No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `&` is unsupported between objects of type `No` and `No`"
-reveal_type(No() & No())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `//` is unsupported between objects of type `No` and `No`"
-reveal_type(No() // No())  # revealed: Unknown
-
-# Yes does not implement any of the reflected dunder methods.
-# error: [unsupported-operator] "Operator `+` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() + Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `-` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() - Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `*` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() * Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `@` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() @ Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `/` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() / Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `%` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() % Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `**` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() ** Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `<<` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() << Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `>>` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() >> Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `|` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() | Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `^` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() ^ Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `&` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() & Yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `//` is unsupported between objects of type `No` and `Yes`"
-reveal_type(No() // Yes())  # revealed: Unknown
-```
-
-## Subclass reflections override superclass dunders
-
-```py
-class Yes:
-    def __add__(self, other) -> Literal["+"]:
-        return "+"
-
-    def __sub__(self, other) -> Literal["-"]:
-        return "-"
-
-    def __mul__(self, other) -> Literal["*"]:
-        return "*"
-
-    def __matmul__(self, other) -> Literal["@"]:
-        return "@"
-
-    def __truediv__(self, other) -> Literal["/"]:
-        return "/"
-
-    def __mod__(self, other) -> Literal["%"]:
-        return "%"
-
-    def __pow__(self, other) -> Literal["**"]:
-        return "**"
-
-    def __lshift__(self, other) -> Literal["<<"]:
-        return "<<"
-
-    def __rshift__(self, other) -> Literal[">>"]:
-        return ">>"
-
-    def __or__(self, other) -> Literal["|"]:
-        return "|"
-
-    def __xor__(self, other) -> Literal["^"]:
-        return "^"
-
-    def __and__(self, other) -> Literal["&"]:
-        return "&"
-
-    def __floordiv__(self, other) -> Literal["//"]:
-        return "//"
-
-class Sub(Yes):
-    def __radd__(self, other) -> Literal["r+"]:
-        return "r+"
-
-    def __rsub__(self, other) -> Literal["r-"]:
-        return "r-"
-
-    def __rmul__(self, other) -> Literal["r*"]:
-        return "r*"
-
-    def __rmatmul__(self, other) -> Literal["r@"]:
-        return "r@"
-
-    def __rtruediv__(self, other) -> Literal["r/"]:
-        return "r/"
-
-    def __rmod__(self, other) -> Literal["r%"]:
-        return "r%"
-
-    def __rpow__(self, other) -> Literal["r**"]:
-        return "r**"
-
-    def __rlshift__(self, other) -> Literal["r<<"]:
-        return "r<<"
-
-    def __rrshift__(self, other) -> Literal["r>>"]:
-        return "r>>"
-
-    def __ror__(self, other) -> Literal["r|"]:
-        return "r|"
-
-    def __rxor__(self, other) -> Literal["r^"]:
-        return "r^"
-
-    def __rand__(self, other) -> Literal["r&"]:
-        return "r&"
-
-    def __rfloordiv__(self, other) -> Literal["r//"]:
-        return "r//"
-
-class No:
-    def __radd__(self, other) -> Literal["r+"]:
-        return "r+"
-
-    def __rsub__(self, other) -> Literal["r-"]:
-        return "r-"
-
-    def __rmul__(self, other) -> Literal["r*"]:
-        return "r*"
-
-    def __rmatmul__(self, other) -> Literal["r@"]:
-        return "r@"
-
-    def __rtruediv__(self, other) -> Literal["r/"]:
-        return "r/"
-
-    def __rmod__(self, other) -> Literal["r%"]:
-        return "r%"
-
-    def __rpow__(self, other) -> Literal["r**"]:
-        return "r**"
-
-    def __rlshift__(self, other) -> Literal["r<<"]:
-        return "r<<"
-
-    def __rrshift__(self, other) -> Literal["r>>"]:
-        return "r>>"
-
-    def __ror__(self, other) -> Literal["r|"]:
-        return "r|"
-
-    def __rxor__(self, other) -> Literal["r^"]:
-        return "r^"
-
-    def __rand__(self, other) -> Literal["r&"]:
-        return "r&"
-
-    def __rfloordiv__(self, other) -> Literal["r//"]:
-        return "r//"
-
-# Subclass reflected dunder methods take precedence over the superclass's regular dunders.
-reveal_type(Yes() + Sub())  # revealed: Literal["r+"]
-reveal_type(Yes() - Sub())  # revealed: Literal["r-"]
-reveal_type(Yes() * Sub())  # revealed: Literal["r*"]
-reveal_type(Yes() @ Sub())  # revealed: Literal["r@"]
-reveal_type(Yes() / Sub())  # revealed: Literal["r/"]
-reveal_type(Yes() % Sub())  # revealed: Literal["r%"]
-reveal_type(Yes() ** Sub())  # revealed: Literal["r**"]
-reveal_type(Yes() << Sub())  # revealed: Literal["r<<"]
-reveal_type(Yes() >> Sub())  # revealed: Literal["r>>"]
-reveal_type(Yes() | Sub())  # revealed: Literal["r|"]
-reveal_type(Yes() ^ Sub())  # revealed: Literal["r^"]
-reveal_type(Yes() & Sub())  # revealed: Literal["r&"]
-reveal_type(Yes() // Sub())  # revealed: Literal["r//"]
-
-# But for an unrelated class, the superclass regular dunders are used.
-reveal_type(Yes() + No())  # revealed: Literal["+"]
-reveal_type(Yes() - No())  # revealed: Literal["-"]
-reveal_type(Yes() * No())  # revealed: Literal["*"]
-reveal_type(Yes() @ No())  # revealed: Literal["@"]
-reveal_type(Yes() / No())  # revealed: Literal["/"]
-reveal_type(Yes() % No())  # revealed: Literal["%"]
-reveal_type(Yes() ** No())  # revealed: Literal["**"]
-reveal_type(Yes() << No())  # revealed: Literal["<<"]
-reveal_type(Yes() >> No())  # revealed: Literal[">>"]
-reveal_type(Yes() | No())  # revealed: Literal["|"]
-reveal_type(Yes() ^ No())  # revealed: Literal["^"]
-reveal_type(Yes() & No())  # revealed: Literal["&"]
-reveal_type(Yes() // No())  # revealed: Literal["//"]
-```
-
-## Classes
-
-Dunder methods defined in a class are available to instances of that class, but not to the class
-itself. (For these operators to work on the class itself, they would have to be defined on the
-class's type, i.e. `type`.)
-
-```py
-class Yes:
-    def __add__(self, other) -> Literal["+"]:
-        return "+"
-
-class Sub(Yes): ...
-class No: ...
-
-# error: [unsupported-operator] "Operator `+` is unsupported between objects of type `Literal[Yes]` and `Literal[Yes]`"
-reveal_type(Yes + Yes)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `+` is unsupported between objects of type `Literal[Sub]` and `Literal[Sub]`"
-reveal_type(Sub + Sub)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `+` is unsupported between objects of type `Literal[No]` and `Literal[No]`"
-reveal_type(No + No)  # revealed: Unknown
-```
-
-## Subclass
-
-```py
-class Yes:
-    def __add__(self, other) -> Literal["+"]:
-        return "+"
-
-class Sub(Yes): ...
-class No: ...
-
-def yes() -> type[Yes]:
-    return Yes
-
-def sub() -> type[Sub]:
-    return Sub
-
-def no() -> type[No]:
-    return No
-
-# error: [unsupported-operator] "Operator `+` is unsupported between objects of type `type[Yes]` and `type[Yes]`"
-reveal_type(yes() + yes())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `+` is unsupported between objects of type `type[Sub]` and `type[Sub]`"
-reveal_type(sub() + sub())  # revealed: Unknown
-# error: [unsupported-operator] "Operator `+` is unsupported between objects of type `type[No]` and `type[No]`"
-reveal_type(no() + no())  # revealed: Unknown
-```
-
-## Function literals
-
-```py
-def f():
-    pass
-
-# error: [unsupported-operator] "Operator `+` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f + f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `-` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f - f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `*` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f * f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `@` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f @ f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `/` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f / f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `%` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f % f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `**` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f**f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `<<` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f << f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `>>` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f >> f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `|` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f | f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `^` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f ^ f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `&` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f & f)  # revealed: Unknown
-# error: [unsupported-operator] "Operator `//` is unsupported between objects of type `Literal[f]` and `Literal[f]`"
-reveal_type(f // f)  # revealed: Unknown
-```

crates/red_knot_python_semantic/resources/mdtest/binary/integers.md

@@ -9,34 +9,6 @@ reveal_type(3 * -1)  # revealed: Literal[-3]
 reveal_type(-3 // 3)  # revealed: Literal[-1]
 reveal_type(-3 / 3)  # revealed: float
 reveal_type(5 % 3)  # revealed: Literal[2]
-
-# TODO: We don't currently verify that the actual parameter to int.__add__ matches the declared
-# formal parameter type.
-reveal_type(2 + "f")  # revealed: int
-
-def lhs(x: int):
-    reveal_type(x + 1)  # revealed: int
-    reveal_type(x - 4)  # revealed: int
-    reveal_type(x * -1)  # revealed: int
-    reveal_type(x // 3)  # revealed: int
-    reveal_type(x / 3)  # revealed: float
-    reveal_type(x % 3)  # revealed: int
-
-def rhs(x: int):
-    reveal_type(2 + x)  # revealed: int
-    reveal_type(3 - x)  # revealed: int
-    reveal_type(3 * x)  # revealed: int
-    reveal_type(-3 // x)  # revealed: int
-    reveal_type(-3 / x)  # revealed: float
-    reveal_type(5 % x)  # revealed: int
-
-def both(x: int):
-    reveal_type(x + x)  # revealed: int
-    reveal_type(x - x)  # revealed: int
-    reveal_type(x * x)  # revealed: int
-    reveal_type(x // x)  # revealed: int
-    reveal_type(x / x)  # revealed: float
-    reveal_type(x % x)  # revealed: int
 ```
 
 ## Power
@@ -49,11 +21,6 @@ largest_u32 = 4_294_967_295
 reveal_type(2**2)  # revealed: Literal[4]
 reveal_type(1 ** (largest_u32 + 1))  # revealed: int
 reveal_type(2**largest_u32)  # revealed: int
-
-def variable(x: int):
-    reveal_type(x**2)  # revealed: @Todo(return type)
-    reveal_type(2**x)  # revealed: @Todo(return type)
-    reveal_type(x**x)  # revealed: @Todo(return type)
 ```
 
 ## Division by Zero

crates/red_knot_python_semantic/resources/mdtest/boolean/short_circuit.md

@@ -32,10 +32,13 @@ def _(flag: bool):
 
 ```py
 if True or (x := 1):
-    # error: [unresolved-reference]
-    reveal_type(x)  # revealed: Unknown
+    # TODO: infer that the second arm is never executed, and raise `unresolved-reference`.
+    # error: [possibly-unresolved-reference]
+    reveal_type(x)  # revealed: Literal[1]
 
 if True and (x := 1):
+    # TODO: infer that the second arm is always executed, do not raise a diagnostic
+    # error: [possibly-unresolved-reference]
     reveal_type(x)  # revealed: Literal[1]
 ```
 

crates/red_knot_python_semantic/resources/mdtest/call/callable_instance.md

@@ -70,32 +70,3 @@ def _(flag: bool):
     # error: "Object of type `Literal[1] | Literal[__call__]` is not callable (due to union element `Literal[1]`)"
     reveal_type(a())  # revealed: Unknown | int
 ```
-
-## Call binding errors
-
-### Wrong argument type
-
-```py
-class C:
-    def __call__(self, x: int) -> int:
-        return 1
-
-c = C()
-
-# error: 15 [invalid-argument-type] "Object of type `Literal["foo"]` cannot be assigned to parameter 2 (`x`) of function `__call__`; expected type `int`"
-reveal_type(c("foo"))  # revealed: int
-```
-
-### Wrong argument type on `self`
-
-```py
-class C:
-    # TODO this definition should also be an error; `C` must be assignable to type of `self`
-    def __call__(self: int) -> int:
-        return 1
-
-c = C()
-
-# error: 13 [invalid-argument-type] "Object of type `C` cannot be assigned to parameter 1 (`self`) of function `__call__`; expected type `int`"
-reveal_type(c())  # revealed: int
-```

crates/red_knot_python_semantic/resources/mdtest/call/function.md

@@ -64,260 +64,3 @@ def _(flag: bool):
     # error: [possibly-unresolved-reference]
     reveal_type(foo())  # revealed: int
 ```
-
-## Wrong argument type
-
-### Positional argument, positional-or-keyword parameter
-
-```py
-def f(x: int) -> int:
-    return 1
-
-# error: 15 [invalid-argument-type] "Object of type `Literal["foo"]` cannot be assigned to parameter 1 (`x`) of function `f`; expected type `int`"
-reveal_type(f("foo"))  # revealed: int
-```
-
-### Positional argument, positional-only parameter
-
-```py
-def f(x: int, /) -> int:
-    return 1
-
-# error: 15 [invalid-argument-type] "Object of type `Literal["foo"]` cannot be assigned to parameter 1 (`x`) of function `f`; expected type `int`"
-reveal_type(f("foo"))  # revealed: int
-```
-
-### Positional argument, variadic parameter
-
-```py
-def f(*args: int) -> int:
-    return 1
-
-# error: 15 [invalid-argument-type] "Object of type `Literal["foo"]` cannot be assigned to parameter `*args` of function `f`; expected type `int`"
-reveal_type(f("foo"))  # revealed: int
-```
-
-### Keyword argument, positional-or-keyword parameter
-
-```py
-def f(x: int) -> int:
-    return 1
-
-# error: 15 [invalid-argument-type] "Object of type `Literal["foo"]` cannot be assigned to parameter `x` of function `f`; expected type `int`"
-reveal_type(f(x="foo"))  # revealed: int
-```
-
-### Keyword argument, keyword-only parameter
-
-```py
-def f(*, x: int) -> int:
-    return 1
-
-# error: 15 [invalid-argument-type] "Object of type `Literal["foo"]` cannot be assigned to parameter `x` of function `f`; expected type `int`"
-reveal_type(f(x="foo"))  # revealed: int
-```
-
-### Keyword argument, keywords parameter
-
-```py
-def f(**kwargs: int) -> int:
-    return 1
-
-# error: 15 [invalid-argument-type] "Object of type `Literal["foo"]` cannot be assigned to parameter `**kwargs` of function `f`; expected type `int`"
-reveal_type(f(x="foo"))  # revealed: int
-```
-
-### Correctly match keyword out-of-order
-
-```py
-def f(x: int = 1, y: str = "foo") -> int:
-    return 1
-
-# error: 15 [invalid-argument-type] "Object of type `Literal[2]` cannot be assigned to parameter `y` of function `f`; expected type `str`"
-# error: 20 [invalid-argument-type] "Object of type `Literal["bar"]` cannot be assigned to parameter `x` of function `f`; expected type `int`"
-reveal_type(f(y=2, x="bar"))  # revealed: int
-```
-
-## Too many positional arguments
-
-### One too many
-
-```py
-def f() -> int:
-    return 1
-
-# error: 15 [too-many-positional-arguments] "Too many positional arguments to function `f`: expected 0, got 1"
-reveal_type(f("foo"))  # revealed: int
-```
-
-### Two too many
-
-```py
-def f() -> int:
-    return 1
-
-# error: 15 [too-many-positional-arguments] "Too many positional arguments to function `f`: expected 0, got 2"
-reveal_type(f("foo", "bar"))  # revealed: int
-```
-
-### No too-many-positional if variadic is taken
-
-```py
-def f(*args: int) -> int:
-    return 1
-
-reveal_type(f(1, 2, 3))  # revealed: int
-```
-
-## Missing arguments
-
-### No defaults or variadic
-
-```py
-def f(x: int) -> int:
-    return 1
-
-# error: 13 [missing-argument] "No argument provided for required parameter `x` of function `f`"
-reveal_type(f())  # revealed: int
-```
-
-### With default
-
-```py
-def f(x: int, y: str = "foo") -> int:
-    return 1
-
-# error: 13 [missing-argument] "No argument provided for required parameter `x` of function `f`"
-reveal_type(f())  # revealed: int
-```
-
-### Defaulted argument is not required
-
-```py
-def f(x: int = 1) -> int:
-    return 1
-
-reveal_type(f())  # revealed: int
-```
-
-### With variadic
-
-```py
-def f(x: int, *y: str) -> int:
-    return 1
-
-# error: 13 [missing-argument] "No argument provided for required parameter `x` of function `f`"
-reveal_type(f())  # revealed: int
-```
-
-### Variadic argument is not required
-
-```py
-def f(*args: int) -> int:
-    return 1
-
-reveal_type(f())  # revealed: int
-```
-
-### Keywords argument is not required
-
-```py
-def f(**kwargs: int) -> int:
-    return 1
-
-reveal_type(f())  # revealed: int
-```
-
-### Multiple
-
-```py
-def f(x: int, y: int) -> int:
-    return 1
-
-# error: 13 [missing-argument] "No arguments provided for required parameters `x`, `y` of function `f`"
-reveal_type(f())  # revealed: int
-```
-
-## Unknown argument
-
-```py
-def f(x: int) -> int:
-    return 1
-
-# error: 20 [unknown-argument] "Argument `y` does not match any known parameter of function `f`"
-reveal_type(f(x=1, y=2))  # revealed: int
-```
-
-## Parameter already assigned
-
-```py
-def f(x: int) -> int:
-    return 1
-
-# error: 18 [parameter-already-assigned] "Multiple values provided for parameter `x` of function `f`"
-reveal_type(f(1, x=2))  # revealed: int
-```
-
-## Special functions
-
-Some functions require special handling in type inference. Here, we make sure that we still emit
-proper diagnostics in case of missing or superfluous arguments.
-
-### `reveal_type`
-
-```py
-from typing_extensions import reveal_type
-
-# error: [missing-argument] "No argument provided for required parameter `obj` of function `reveal_type`"
-reveal_type()  # revealed: Unknown
-
-# error: [too-many-positional-arguments] "Too many positional arguments to function `reveal_type`: expected 1, got 2"
-reveal_type(1, 2)  # revealed: Literal[1]
-```
-
-### `static_assert`
-
-```py
-from knot_extensions import static_assert
-
-# error: [missing-argument] "No argument provided for required parameter `condition` of function `static_assert`"
-# error: [static-assert-error]
-static_assert()
-
-# error: [too-many-positional-arguments] "Too many positional arguments to function `static_assert`: expected 2, got 3"
-static_assert(True, 2, 3)
-```
-
-### `len`
-
-```py
-# error: [missing-argument] "No argument provided for required parameter `obj` of function `len`"
-len()
-
-# error: [too-many-positional-arguments] "Too many positional arguments to function `len`: expected 1, got 2"
-len([], 1)
-```
-
-### Type API predicates
-
-```py
-from knot_extensions import is_subtype_of, is_fully_static
-
-# error: [missing-argument]
-is_subtype_of()
-
-# error: [missing-argument]
-is_subtype_of(int)
-
-# error: [too-many-positional-arguments]
-is_subtype_of(int, int, int)
-
-# error: [too-many-positional-arguments]
-is_subtype_of(int, int, int, int)
-
-# error: [missing-argument]
-is_fully_static()
-
-# error: [too-many-positional-arguments]
-is_fully_static(int, int)
-```

crates/red_knot_python_semantic/resources/mdtest/call/invalid_syntax.md

@@ -1,44 +0,0 @@
-# Invalid signatures
-
-## Multiple arguments with the same name
-
-We always map a keyword argument to the first parameter of that name.
-
-```py
-# error: [invalid-syntax] "Duplicate parameter "x""
-def f(x: int, x: str) -> int:
-    return 1
-
-# error: 13 [missing-argument] "No argument provided for required parameter `x` of function `f`"
-# error: 18 [parameter-already-assigned] "Multiple values provided for parameter `x` of function `f`"
-reveal_type(f(1, x=2))  # revealed: int
-```
-
-## Positional after non-positional
-
-When parameter kinds are given in an invalid order, we emit a diagnostic and implicitly reorder them
-to the valid order:
-
-```py
-# error: [invalid-syntax] "Parameter cannot follow var-keyword parameter"
-def f(**kw: int, x: str) -> int:
-    return 1
-
-# error: 15 [invalid-argument-type] "Object of type `Literal[1]` cannot be assigned to parameter 1 (`x`) of function `f`; expected type `str`"
-reveal_type(f(1))  # revealed: int
-```
-
-## Non-defaulted after defaulted
-
-We emit a syntax diagnostic for this, but it doesn't cause any problems for binding.
-
-```py
-# error: [invalid-syntax] "Parameter without a default cannot follow a parameter with a default"
-def f(x: int = 1, y: str) -> int:
-    return 1
-
-reveal_type(f(y="foo"))  # revealed: int
-# error: [invalid-argument-type] "Object of type `Literal["foo"]` cannot be assigned to parameter 1 (`x`) of function `f`; expected type `int`"
-# error: [missing-argument] "No argument provided for required parameter `y` of function `f`"
-reveal_type(f("foo"))  # revealed: int
-```

crates/red_knot_python_semantic/resources/mdtest/call/union.md

@@ -56,7 +56,7 @@ def _(flag: bool, flag2: bool):
     else:
         def f() -> int:
             return 1
-    # error: "Object of type `Literal[1, "foo"] | Literal[f]` is not callable (due to union elements Literal[1], Literal["foo"])"
+    # error: "Object of type `Literal[1] | Literal["foo"] | Literal[f]` is not callable (due to union elements Literal[1], Literal["foo"])"
     # revealed: Unknown | int
     reveal_type(f())
 ```
@@ -72,6 +72,6 @@ def _(flag: bool):
     else:
         f = "foo"
 
-    x = f()  # error: "Object of type `Literal[1, "foo"]` is not callable"
+    x = f()  # error: "Object of type `Literal[1] | Literal["foo"]` is not callable"
     reveal_type(x)  # revealed: Unknown
 ```

crates/red_knot_python_semantic/resources/mdtest/comparison/non_bool_returns.md

@@ -31,10 +31,10 @@ class C:
     def __lt__(self, other) -> C: ...
 
 x = A() < B() < C()
-reveal_type(x)  # revealed: A & ~AlwaysTruthy | B
+reveal_type(x)  # revealed: A | B
 
 y = 0 < 1 < A() < 3
-reveal_type(y)  # revealed: Literal[False] | A
+reveal_type(y)  # revealed: bool | A
 
 z = 10 < 0 < A() < B() < C()
 reveal_type(z)  # revealed: Literal[False]

crates/red_knot_python_semantic/resources/mdtest/comparison/unsupported.md

@@ -22,7 +22,7 @@ def _(flag: bool, flag1: bool, flag2: bool):
     reveal_type(d)  # revealed: bool
 
     int_literal_or_str_literal = 1 if flag else "foo"
-    # error: "Operator `in` is not supported for types `Literal[42]` and `Literal[1]`, in comparing `Literal[42]` with `Literal[1, "foo"]`"
+    # error: "Operator `in` is not supported for types `Literal[42]` and `Literal[1]`, in comparing `Literal[42]` with `Literal[1] | Literal["foo"]`"
     e = 42 in int_literal_or_str_literal
     reveal_type(e)  # revealed: bool
 

crates/red_knot_python_semantic/resources/mdtest/conditional/if_statement.md

@@ -115,35 +115,3 @@ def _(flag: bool, flag2: bool):
 
     reveal_type(y)  # revealed: Literal[2, 3, 4]
 ```
-
-## if-elif with assignment expressions in tests
-
-```py
-def check(x: int) -> bool:
-    return bool(x)
-
-if check(x := 1):
-    x = 2
-elif check(x := 3):
-    x = 4
-
-reveal_type(x)  # revealed: Literal[2, 3, 4]
-```
-
-## constraints apply to later test expressions
-
-```py
-def check(x) -> bool:
-    return bool(x)
-
-def _(flag: bool):
-    x = 1 if flag else None
-    y = 0
-
-    if x is None:
-        pass
-    elif check(y := x):
-        pass
-
-    reveal_type(y)  # revealed: Literal[0, 1]
-```

crates/red_knot_python_semantic/resources/mdtest/declaration/error.md

@@ -19,17 +19,14 @@ def _(flag: bool):
     x = 1  # error: [conflicting-declarations] "Conflicting declared types for `x`: str, int"
 ```
 
-## Incompatible declarations for 2 (out of 3) types
+## Partial declarations
 
 ```py
-def _(flag1: bool, flag2: bool):
-    if flag1:
-        x: str
-    elif flag2:
+def _(flag: bool):
+    if flag:
         x: int
 
-    # Here, the declared type for `x` is `int | str | Unknown`.
-    x = 1  # error: [conflicting-declarations] "Conflicting declared types for `x`: str, int"
+    x = 1  # error: [conflicting-declarations] "Conflicting declared types for `x`: Unknown, int"
 ```
 
 ## Incompatible declarations with bad assignment
@@ -45,31 +42,3 @@ def _(flag: bool):
     # error: [invalid-assignment]
     x = b"foo"
 ```
-
-## No errors
-
-Currently, we avoid raising the conflicting-declarations for the following cases:
-
-### Partial declarations
-
-```py
-def _(flag: bool):
-    if flag:
-        x: int
-
-    x = 1
-```
-
-### Partial declarations in try-except
-
-Refer to <https://github.com/astral-sh/ruff/issues/13966>
-
-```py
-def _():
-    try:
-        x: int = 1
-    except:
-        x = 2
-
-    x = 3
-```

crates/red_knot_python_semantic/resources/mdtest/directives/assert_type.md

@@ -1,145 +0,0 @@
-# `assert_type`
-
-## Basic
-
-```py
-from typing_extensions import assert_type
-
-def _(x: int):
-    assert_type(x, int)  # fine
-    assert_type(x, str)  # error: [type-assertion-failure]
-```
-
-## Narrowing
-
-The asserted type is checked against the inferred type, not the declared type.
-
-```toml
-[environment]
-python-version = "3.10"
-```
-
-```py
-from typing_extensions import assert_type
-
-def _(x: int | str):
-    if isinstance(x, int):
-        reveal_type(x)  # revealed: int
-        assert_type(x, int)  # fine
-```
-
-## Equivalence
-
-The actual type must match the asserted type precisely.
-
-```py
-from typing import Any, Type, Union
-from typing_extensions import assert_type
-
-# Subtype does not count
-def _(x: bool):
-    assert_type(x, int)  # error: [type-assertion-failure]
-
-def _(a: type[int], b: type[Any]):
-    assert_type(a, type[Any])  # error: [type-assertion-failure]
-    assert_type(b, type[int])  # error: [type-assertion-failure]
-
-# The expression constructing the type is not taken into account
-def _(a: type[int]):
-    assert_type(a, Type[int])  # fine
-```
-
-## Gradual types
-
-```py
-from typing import Any
-from typing_extensions import Literal, assert_type
-
-from knot_extensions import Unknown
-
-# Any and Unknown are considered equivalent
-def _(a: Unknown, b: Any):
-    reveal_type(a)  # revealed: Unknown
-    assert_type(a, Any)  # fine
-
-    reveal_type(b)  # revealed: Any
-    assert_type(b, Unknown)  # fine
-
-def _(a: type[Unknown], b: type[Any]):
-    # TODO: Should be `type[Unknown]`
-    reveal_type(a)  # revealed: @Todo(unsupported type[X] special form)
-    # TODO: Should be fine
-    assert_type(a, type[Any])  # error: [type-assertion-failure]
-
-    reveal_type(b)  # revealed: type[Any]
-    # TODO: Should be fine
-    assert_type(b, type[Unknown])  # error: [type-assertion-failure]
-```
-
-## Tuples
-
-Tuple types with the same elements are the same.
-
-```py
-from typing_extensions import assert_type
-
-from knot_extensions import Unknown
-
-def _(a: tuple[int, str, bytes]):
-    assert_type(a, tuple[int, str, bytes])  # fine
-
-    assert_type(a, tuple[int, str])  # error: [type-assertion-failure]
-    assert_type(a, tuple[int, str, bytes, None])  # error: [type-assertion-failure]
-    assert_type(a, tuple[int, bytes, str])  # error: [type-assertion-failure]
-
-def _(a: tuple[Any, ...], b: tuple[Unknown, ...]):
-    assert_type(a, tuple[Any, ...])  # fine
-    assert_type(a, tuple[Unknown, ...])  # fine
-
-    assert_type(b, tuple[Unknown, ...])  # fine
-    assert_type(b, tuple[Any, ...])  # fine
-```
-
-## Unions
-
-Unions with the same elements are the same, regardless of order.
-
-```toml
-[environment]
-python-version = "3.10"
-```
-
-```py
-from typing_extensions import assert_type
-
-def _(a: str | int):
-    assert_type(a, str | int)  # fine
-
-    # TODO: Order-independent union handling in type equivalence
-    assert_type(a, int | str)  # error: [type-assertion-failure]
-```
-
-## Intersections
-
-Intersections are the same when their positive and negative parts are respectively the same,
-regardless of order.
-
-```py
-from typing_extensions import assert_type
-
-from knot_extensions import Intersection, Not
-
-class A: ...
-class B: ...
-class C: ...
-class D: ...
-
-def _(a: A):
-    if isinstance(a, B) and not isinstance(a, C) and not isinstance(a, D):
-        reveal_type(a)  # revealed: A & B & ~C & ~D
-
-        assert_type(a, Intersection[A, B, Not[C], Not[D]])  # fine
-
-        # TODO: Order-independent intersection handling in type equivalence
-        assert_type(a, Intersection[B, A, Not[D], Not[C]])  # error: [type-assertion-failure]
-```

crates/red_knot_python_semantic/resources/mdtest/exception/basic.md

@@ -90,83 +90,3 @@ def foo(
         # TODO: should emit a diagnostic here:
         reveal_type(g)  # revealed: @Todo(full tuple[...] support)
 ```
-
-## Object raised is not an exception
-
-```py
-try:
-    raise AttributeError()  # fine
-except:
-    ...
-
-try:
-    raise FloatingPointError  # fine
-except:
-    ...
-
-try:
-    raise 1  # error: [invalid-raise]
-except:
-    ...
-
-try:
-    raise int  # error: [invalid-raise]
-except:
-    ...
-
-def _(e: Exception | type[Exception]):
-    raise e  # fine
-
-def _(e: Exception | type[Exception] | None):
-    raise e  # error: [invalid-raise]
-```
-
-## Exception cause is not an exception
-
-```py
-try:
-    raise EOFError() from GeneratorExit  # fine
-except:
-    ...
-
-try:
-    raise StopIteration from MemoryError()  # fine
-except:
-    ...
-
-try:
-    raise BufferError() from None  # fine
-except:
-    ...
-
-try:
-    raise ZeroDivisionError from False  # error: [invalid-raise]
-except:
-    ...
-
-try:
-    raise SystemExit from bool()  # error: [invalid-raise]
-except:
-    ...
-
-try:
-    raise
-except KeyboardInterrupt as e:  # fine
-    reveal_type(e)  # revealed: KeyboardInterrupt
-    raise LookupError from e  # fine
-
-try:
-    raise
-except int as e:  # error: [invalid-exception-caught]
-    reveal_type(e)  # revealed: Unknown
-    raise KeyError from e
-
-def _(e: Exception | type[Exception]):
-    raise ModuleNotFoundError from e  # fine
-
-def _(e: Exception | type[Exception] | None):
-    raise IndexError from e  # fine
-
-def _(e: int | None):
-    raise IndexError from e  # error: [invalid-raise]
-```

crates/red_knot_python_semantic/resources/mdtest/expression/attribute.md

@@ -17,7 +17,7 @@ def _(flag: bool):
 
     reveal_type(A.always_bound)  # revealed: Literal[1]
 
-    reveal_type(A.union)  # revealed: Literal[1, "abc"]
+    reveal_type(A.union)  # revealed: Literal[1] | Literal["abc"]
 
     # error: [possibly-unbound-attribute] "Attribute `possibly_unbound` on type `Literal[A]` is possibly unbound"
     reveal_type(A.possibly_unbound)  # revealed: Literal["abc"]

crates/red_knot_python_semantic/resources/mdtest/expression/boolean.md

@@ -10,8 +10,8 @@ def _(foo: str):
     reveal_type(False or "z")  # revealed: Literal["z"]
     reveal_type(False or True)  # revealed: Literal[True]
     reveal_type(False or False)  # revealed: Literal[False]
-    reveal_type(foo or False)  # revealed: str & ~AlwaysFalsy | Literal[False]
-    reveal_type(foo or True)  # revealed: str & ~AlwaysFalsy | Literal[True]
+    reveal_type(foo or False)  # revealed: str | Literal[False]
+    reveal_type(foo or True)  # revealed: str | Literal[True]
 ```
 
 ## AND
@@ -20,8 +20,8 @@ def _(foo: str):
 def _(foo: str):
     reveal_type(True and False)  # revealed: Literal[False]
     reveal_type(False and True)  # revealed: Literal[False]
-    reveal_type(foo and False)  # revealed: str & ~AlwaysTruthy | Literal[False]
-    reveal_type(foo and True)  # revealed: str & ~AlwaysTruthy | Literal[True]
+    reveal_type(foo and False)  # revealed: str | Literal[False]
+    reveal_type(foo and True)  # revealed: str | Literal[True]
     reveal_type("x" and "y" and "z")  # revealed: Literal["z"]
     reveal_type("x" and "y" and "")  # revealed: Literal[""]
     reveal_type("" and "y")  # revealed: Literal[""]

crates/red_knot_python_semantic/resources/mdtest/expression/if.md

@@ -7,7 +7,7 @@ def _(flag: bool):
     reveal_type(1 if flag else 2)  # revealed: Literal[1, 2]
 ```
 
-## Statically known conditions in if-expressions
+## Statically known branches
 
 ```py
 reveal_type(1 if True else 2)  # revealed: Literal[1]
@@ -31,9 +31,9 @@ The test inside an if expression should not affect code outside of the expressio
 def _(flag: bool):
     x: Literal[42, "hello"] = 42 if flag else "hello"
 
-    reveal_type(x)  # revealed: Literal[42, "hello"]
+    reveal_type(x)  # revealed: Literal[42] | Literal["hello"]
 
     _ = ... if isinstance(x, str) else ...
 
-    reveal_type(x)  # revealed: Literal[42, "hello"]
+    reveal_type(x)  # revealed: Literal[42] | Literal["hello"]
 ```

crates/red_knot_python_semantic/resources/mdtest/expression/len.md

@@ -119,7 +119,7 @@ class ZeroOrStr:
 reveal_type(len(Zero()))  # revealed: Literal[0]
 reveal_type(len(ZeroOrOne()))  # revealed: Literal[0, 1]
 reveal_type(len(ZeroOrTrue()))  # revealed: Literal[0, 1]
-reveal_type(len(OneOrFalse()))  # revealed: Literal[1, 0]
+reveal_type(len(OneOrFalse()))  # revealed: Literal[0, 1]
 
 # TODO: Emit a diagnostic
 reveal_type(len(OneOrFoo()))  # revealed: int

crates/red_knot_python_semantic/resources/mdtest/final.md

@@ -1,31 +0,0 @@
-# Tests for the `@typing(_extensions).final` decorator
-
-## Cannot subclass
-
-Don't do this:
-
-```py
-import typing_extensions
-from typing import final
-
-@final
-class A: ...
-
-class B(A): ...  # error: 9 [subclass-of-final-class] "Class `B` cannot inherit from final class `A`"
-
-@typing_extensions.final
-class C: ...
-
-class D(C): ...  # error: [subclass-of-final-class]
-class E: ...
-class F: ...
-class G: ...
-
-# fmt: off
-class H(
-    E,
-    F,
-    A,  # error: [subclass-of-final-class]
-    G,
-): ...
-```

crates/red_knot_python_semantic/resources/mdtest/import/basic.md

@@ -25,82 +25,3 @@ reveal_type(D)  # revealed: Literal[C]
 ```py path=b.py
 class C: ...
 ```
-
-## Nested
-
-```py
-import a.b
-
-reveal_type(a.b.C)  # revealed: Literal[C]
-```
-
-```py path=a/__init__.py
-```
-
-```py path=a/b.py
-class C: ...
-```
-
-## Deeply nested
-
-```py
-import a.b.c
-
-reveal_type(a.b.c.C)  # revealed: Literal[C]
-```
-
-```py path=a/__init__.py
-```
-
-```py path=a/b/__init__.py
-```
-
-```py path=a/b/c.py
-class C: ...
-```
-
-## Nested with rename
-
-```py
-import a.b as b
-
-reveal_type(b.C)  # revealed: Literal[C]
-```
-
-```py path=a/__init__.py
-```
-
-```py path=a/b.py
-class C: ...
-```
-
-## Deeply nested with rename
-
-```py
-import a.b.c as c
-
-reveal_type(c.C)  # revealed: Literal[C]
-```
-
-```py path=a/__init__.py
-```
-
-```py path=a/b/__init__.py
-```
-
-```py path=a/b/c.py
-class C: ...
-```
-
-## Unresolvable submodule imports
-
-```py
-# Topmost component resolvable, submodule not resolvable:
-import a.foo  # error: [unresolved-import] "Cannot resolve import `a.foo`"
-
-# Topmost component unresolvable:
-import b.foo  # error: [unresolved-import] "Cannot resolve import `b.foo`"
-```
-
-```py path=a/__init__.py
-```

crates/red_knot_python_semantic/resources/mdtest/import/conflicts.md

@@ -1,75 +0,0 @@
-# Conflicting attributes and submodules
-
-## Via import
-
-```py
-import a.b
-
-reveal_type(a.b)  # revealed: <module 'a.b'>
-```
-
-```py path=a/__init__.py
-b = 42
-```
-
-```py path=a/b.py
-```
-
-## Via from/import
-
-```py
-from a import b
-
-reveal_type(b)  # revealed: Literal[42]
-```
-
-```py path=a/__init__.py
-b = 42
-```
-
-```py path=a/b.py
-```
-
-## Via both
-
-```py
-import a.b
-from a import b
-
-reveal_type(b)  # revealed: <module 'a.b'>
-reveal_type(a.b)  # revealed: <module 'a.b'>
-```
-
-```py path=a/__init__.py
-b = 42
-```
-
-```py path=a/b.py
-```
-
-## Via both (backwards)
-
-In this test, we infer a different type for `b` than the runtime behavior of the Python interpreter.
-The interpreter will not load the submodule `a.b` during the `from a import b` statement, since `a`
-contains a non-module attribute named `b`. (See the [definition][from-import] of a `from...import`
-statement for details.) However, because our import tracking is flow-insensitive, we will see that
-`a.b` is imported somewhere in the file, and therefore assume that the `from...import` statement
-sees the submodule as the value of `b` instead of the integer.
-
-```py
-from a import b
-import a.b
-
-# Python would say `Literal[42]` for `b`
-reveal_type(b)  # revealed: <module 'a.b'>
-reveal_type(a.b)  # revealed: <module 'a.b'>
-```
-
-```py path=a/__init__.py
-b = 42
-```
-
-```py path=a/b.py
-```
-
-[from-import]: https://docs.python.org/3/reference/simple_stmts.html#the-import-statement

crates/red_knot_python_semantic/resources/mdtest/import/invalid_syntax.md

@@ -7,25 +7,3 @@ from import bar  # error: [invalid-syntax]
 
 reveal_type(bar)  # revealed: Unknown
 ```
-
-## Invalid nested module import
-
-TODO: This is correctly flagged as an error, but we could clean up the diagnostics that we report.
-
-```py
-# TODO: No second diagnostic
-# error: [invalid-syntax] "Expected ',', found '.'"
-# error: [unresolved-import] "Module `a` has no member `c`"
-from a import b.c
-
-# TODO: Should these be inferred as Unknown?
-reveal_type(b)  # revealed: <module 'a.b'>
-reveal_type(b.c)  # revealed: Literal[1]
-```
-
-```py path=a/__init__.py
-```
-
-```py path=a/b.py
-c = 1
-```

crates/red_knot_python_semantic/resources/mdtest/import/relative.md

@@ -121,44 +121,23 @@ X = 42
 ```
 
 ```py path=package/bar.py
-from . import foo
+# TODO: support submodule imports
+from . import foo  # error: [unresolved-import]
 
-reveal_type(foo.X)  # revealed: Literal[42]
+y = foo.X
+
+# TODO: should be `Literal[42]`
+reveal_type(y)  # revealed: Unknown
 ```
 
 ## Non-existent + bare to module
 
-This test verifies that we emit an error when we try to import a symbol that is neither a submodule
-nor an attribute of `package`.
-
 ```py path=package/__init__.py
 ```
 
 ```py path=package/bar.py
+# TODO: support submodule imports
 from . import foo  # error: [unresolved-import]
 
 reveal_type(foo)  # revealed: Unknown
 ```
-
-## Import submodule from self
-
-We don't currently consider `from...import` statements when building up the `imported_modules` set
-in the semantic index. When accessing an attribute of a module, we only consider it a potential
-submodule when that submodule name appears in the `imported_modules` set. That means that submodules
-that are imported via `from...import` are not visible to our type inference if you also access that
-submodule via the attribute on its parent package.
-
-```py path=package/__init__.py
-```
-
-```py path=package/foo.py
-X = 42
-```
-
-```py path=package/bar.py
-from . import foo
-import package
-
-# error: [unresolved-attribute] "Type `<module 'package'>` has no attribute `foo`"
-reveal_type(package.foo.X)  # revealed: Unknown
-```

crates/red_knot_python_semantic/resources/mdtest/import/tracking.md

@@ -1,100 +0,0 @@
-# Tracking imported modules
-
-These tests depend on how we track which modules have been imported. There are currently two
-characteristics of our module tracking that can lead to inaccuracies:
-
-- Imports are tracked on a per-file basis. At runtime, importing a submodule in one file makes that
-    submodule globally available via any reference to the containing package. We will flag an error
-    if a file tries to access a submodule without there being an import of that submodule _in that
-    same file_.
-
-    This is a purposeful decision, and not one we plan to change. If a module wants to re-export some
-    other module that it imports, there are ways to do that (tested below) that are blessed by the
-    typing spec and that are visible to our file-scoped import tracking.
-
-- Imports are tracked flow-insensitively: submodule accesses are allowed and resolved if that
-    submodule is imported _anywhere in the file_. This handles the common case where all imports are
-    grouped at the top of the file, and is easiest to implement. We might revisit this decision and
-    track submodule imports flow-sensitively, in which case we will have to update the assertions in
-    some of these tests.
-
-## Import submodule later in file
-
-This test highlights our flow-insensitive analysis, since we access the `a.b` submodule before it
-has been imported.
-
-```py
-import a
-
-# Would be an error with flow-sensitive tracking
-reveal_type(a.b.C)  # revealed: Literal[C]
-
-import a.b
-```
-
-```py path=a/__init__.py
-```
-
-```py path=a/b.py
-class C: ...
-```
-
-## Rename a re-export
-
-This test highlights how import tracking is local to each file, but specifically to the file where a
-containing module is first referenced. This allows the main module to see that `q.a` contains a
-submodule `b`, even though `a.b` is never imported in the main module.
-
-```py
-from q import a, b
-
-reveal_type(b)  # revealed: <module 'a.b'>
-reveal_type(b.C)  # revealed: Literal[C]
-
-reveal_type(a.b)  # revealed: <module 'a.b'>
-reveal_type(a.b.C)  # revealed: Literal[C]
-```
-
-```py path=a/__init__.py
-```
-
-```py path=a/b.py
-class C: ...
-```
-
-```py path=q.py
-import a as a
-import a.b as b
-```
-
-## Attribute overrides submodule
-
-Technically, either a submodule or a non-module attribute could shadow the other, depending on the
-ordering of when the submodule is loaded relative to the parent module's `__init__.py` file being
-evaluated. We have chosen to always have the submodule take priority. (This matches pyright's
-current behavior, and opposite of mypy's current behavior.)
-
-```py
-import sub.b
-import attr.b
-
-# In the Python interpreter, `attr.b` is Literal[1]
-reveal_type(sub.b)  # revealed: <module 'sub.b'>
-reveal_type(attr.b)  # revealed: <module 'attr.b'>
-```
-
-```py path=sub/__init__.py
-b = 1
-```
-
-```py path=sub/b.py
-```
-
-```py path=attr/__init__.py
-from . import b as _
-
-b = 1
-```
-
-```py path=attr/b.py
-```

crates/red_knot_python_semantic/resources/mdtest/intersection_types.md

@@ -1,747 +0,0 @@
-# Intersection types
-
-## Introduction
-
-This test suite covers certain properties of intersection types and makes sure that we can apply
-various simplification strategies. We use `Intersection` (`&`) and `Not` (`~`) to construct
-intersection types (note that we display negative contributions at the end; the order does not
-matter):
-
-```py
-from knot_extensions import Intersection, Not
-
-class P: ...
-class Q: ...
-
-def _(
-    i1: Intersection[P, Q],
-    i2: Intersection[P, Not[Q]],
-    i3: Intersection[Not[P], Q],
-    i4: Intersection[Not[P], Not[Q]],
-) -> None:
-    reveal_type(i1)  # revealed: P & Q
-    reveal_type(i2)  # revealed: P & ~Q
-    reveal_type(i3)  # revealed: Q & ~P
-    reveal_type(i4)  # revealed: ~P & ~Q
-```
-
-## Notation
-
-Throughout this document, we use the following types as representatives for certain equivalence
-classes.
-
-### Non-disjoint types
-
-We use `P`, `Q`, `R`, … to denote types that are non-disjoint:
-
-```py
-from knot_extensions import static_assert, is_disjoint_from
-
-class P: ...
-class Q: ...
-class R: ...
-
-static_assert(not is_disjoint_from(P, Q))
-static_assert(not is_disjoint_from(P, R))
-static_assert(not is_disjoint_from(Q, R))
-```
-
-Although `P` is not a subtype of `Q` and `Q` is not a subtype of `P`, the two types are not disjoint
-because it would be possible to create a class `S` that inherits from both `P` and `Q` using
-multiple inheritance. An instance of `S` would be a member of the `P` type _and_ the `Q` type.
-
-### Disjoint types
-
-We use `Literal[1]`, `Literal[2]`, … as examples of pairwise-disjoint types, and `int` as a joint
-supertype of these:
-
-```py
-from knot_extensions import static_assert, is_disjoint_from, is_subtype_of
-from typing import Literal
-
-static_assert(is_disjoint_from(Literal[1], Literal[2]))
-static_assert(is_disjoint_from(Literal[1], Literal[3]))
-static_assert(is_disjoint_from(Literal[2], Literal[3]))
-
-static_assert(is_subtype_of(Literal[1], int))
-static_assert(is_subtype_of(Literal[2], int))
-static_assert(is_subtype_of(Literal[3], int))
-```
-
-### Subtypes
-
-Finally, we use `A <: B <: C` and `A <: B1`, `A <: B2` to denote hierarchies of (proper) subtypes:
-
-```py
-from knot_extensions import static_assert, is_subtype_of, is_disjoint_from
-
-class A: ...
-class B(A): ...
-class C(B): ...
-
-static_assert(is_subtype_of(B, A))
-static_assert(is_subtype_of(C, B))
-static_assert(is_subtype_of(C, A))
-
-static_assert(not is_subtype_of(A, B))
-static_assert(not is_subtype_of(B, C))
-static_assert(not is_subtype_of(A, C))
-
-class B1(A): ...
-class B2(A): ...
-
-static_assert(is_subtype_of(B1, A))
-static_assert(is_subtype_of(B2, A))
-
-static_assert(not is_subtype_of(A, B1))
-static_assert(not is_subtype_of(A, B2))
-
-static_assert(not is_subtype_of(B1, B2))
-static_assert(not is_subtype_of(B2, B1))
-```
-
-## Structural properties
-
-This section covers structural properties of intersection types and documents some decisions on how
-to represent mixtures of intersections and unions.
-
-### Single-element unions
-
-If we have a union of a single element, we can simplify to that element. Similarly, we show an
-intersection with a single negative contribution as just the negation of that element.
-
-```py
-from knot_extensions import Intersection, Not
-
-class P: ...
-
-def _(
-    i1: Intersection[P],
-    i2: Intersection[Not[P]],
-) -> None:
-    reveal_type(i1)  # revealed: P
-    reveal_type(i2)  # revealed: ~P
-```
-
-### Flattening of nested intersections
-
-We eagerly flatten nested intersections types.
-
-```py
-from knot_extensions import Intersection, Not
-
-class P: ...
-class Q: ...
-class R: ...
-class S: ...
-
-def positive_contributions(
-    i1: Intersection[P, Intersection[Q, R]],
-    i2: Intersection[Intersection[P, Q], R],
-) -> None:
-    reveal_type(i1)  # revealed: P & Q & R
-    reveal_type(i2)  # revealed: P & Q & R
-
-def negative_contributions(
-    i1: Intersection[Not[P], Intersection[Not[Q], Not[R]]],
-    i2: Intersection[Intersection[Not[P], Not[Q]], Not[R]],
-) -> None:
-    reveal_type(i1)  # revealed: ~P & ~Q & ~R
-    reveal_type(i2)  # revealed: ~P & ~Q & ~R
-
-def mixed(
-    i1: Intersection[P, Intersection[Not[Q], R]],
-    i2: Intersection[Intersection[P, Not[Q]], R],
-    i3: Intersection[Not[P], Intersection[Q, Not[R]]],
-    i4: Intersection[Intersection[Q, Not[R]], Not[P]],
-) -> None:
-    reveal_type(i1)  # revealed: P & R & ~Q
-    reveal_type(i2)  # revealed: P & R & ~Q
-    reveal_type(i3)  # revealed: Q & ~P & ~R
-    reveal_type(i4)  # revealed: Q & ~R & ~P
-
-def multiple(
-    i1: Intersection[Intersection[P, Q], Intersection[R, S]],
-):
-    reveal_type(i1)  # revealed: P & Q & R & S
-
-def nested(
-    i1: Intersection[Intersection[Intersection[P, Q], R], S],
-    i2: Intersection[P, Intersection[Q, Intersection[R, S]]],
-):
-    reveal_type(i1)  # revealed: P & Q & R & S
-    reveal_type(i2)  # revealed: P & Q & R & S
-```
-
-### Union of intersections
-
-We always normalize our representation to a _union of intersections_, so when we add a _union to an
-intersection_, we distribute the union over the respective elements:
-
-```py
-from knot_extensions import Intersection, Not
-
-class P: ...
-class Q: ...
-class R: ...
-class S: ...
-
-def _(
-    i1: Intersection[P, Q | R | S],
-    i2: Intersection[P | Q | R, S],
-    i3: Intersection[P | Q, R | S],
-) -> None:
-    reveal_type(i1)  # revealed: P & Q | P & R | P & S
-    reveal_type(i2)  # revealed: P & S | Q & S | R & S
-    reveal_type(i3)  # revealed: P & R | Q & R | P & S | Q & S
-
-def simplifications_for_same_elements(
-    i1: Intersection[P, Q | P],
-    i2: Intersection[Q, P | Q],
-    i3: Intersection[P | Q, Q | R],
-    i4: Intersection[P | Q, P | Q],
-    i5: Intersection[P | Q, Q | P],
-) -> None:
-    #   P & (Q | P)
-    # = P & Q | P & P
-    # = P & Q | P
-    # = P
-    # (because P is a supertype of P & Q)
-    reveal_type(i1)  # revealed: P
-    # similar here:
-    reveal_type(i2)  # revealed: Q
-
-    #   (P | Q) & (Q | R)
-    # = P & Q | P & R | Q & Q | Q & R
-    # = P & Q | P & R | Q | Q & R
-    # = Q | P & R
-    # (again, because Q is a supertype of P & Q and of Q & R)
-    reveal_type(i3)  # revealed: Q | P & R
-
-    #   (P | Q) & (P | Q)
-    # = P & P | P & Q | Q & P | Q & Q
-    # = P | P & Q | Q
-    # = P | Q
-    reveal_type(i4)  # revealed: P | Q
-```
-
-### Negation distributes over union
-
-Distribution also applies to a negation operation. This is a manifestation of one of
-[De Morgan's laws], namely `~(P | Q) = ~P & ~Q`:
-
-```py
-from knot_extensions import Not
-from typing import Literal
-
-class P: ...
-class Q: ...
-class R: ...
-
-def _(i1: Not[P | Q], i2: Not[P | Q | R]) -> None:
-    reveal_type(i1)  # revealed: ~P & ~Q
-    reveal_type(i2)  # revealed: ~P & ~Q & ~R
-
-def example_literals(i: Not[Literal[1, 2]]) -> None:
-    reveal_type(i)  # revealed: ~Literal[1] & ~Literal[2]
-```
-
-### Negation of intersections
-
-The other of [De Morgan's laws], `~(P & Q) = ~P | ~Q`, also holds:
-
-```py
-from knot_extensions import Intersection, Not
-
-class P: ...
-class Q: ...
-class R: ...
-
-def _(
-    i1: Not[Intersection[P, Q]],
-    i2: Not[Intersection[P, Q, R]],
-) -> None:
-    reveal_type(i1)  # revealed: ~P | ~Q
-    reveal_type(i2)  # revealed: ~P | ~Q | ~R
-```
-
-### `Never` is dual to `object`
-
-`Never` represents the empty set of values, while `object` represents the set of all values, so
-`~Never` is equivalent to `object`, and `~object` is equivalent to `Never`. This is a manifestation
-of the [complement laws] of set theory.
-
-```py
-from knot_extensions import Intersection, Not
-from typing_extensions import Never
-
-def _(
-    not_never: Not[Never],
-    not_object: Not[object],
-) -> None:
-    reveal_type(not_never)  # revealed: object
-    reveal_type(not_object)  # revealed: Never
-```
-
-### Intersection of a type and its negation
-
-Continuing with more [complement laws], if we see both `P` and `~P` in an intersection, we can
-simplify to `Never`, even in the presence of other types:
-
-```py
-from knot_extensions import Intersection, Not
-from typing import Any
-
-class P: ...
-class Q: ...
-
-def _(
-    i1: Intersection[P, Not[P]],
-    i2: Intersection[Not[P], P],
-    i3: Intersection[P, Q, Not[P]],
-    i4: Intersection[Not[P], Q, P],
-    i5: Intersection[P, Any, Not[P]],
-    i6: Intersection[Not[P], Any, P],
-) -> None:
-    reveal_type(i1)  # revealed: Never
-    reveal_type(i2)  # revealed: Never
-    reveal_type(i3)  # revealed: Never
-    reveal_type(i4)  # revealed: Never
-    reveal_type(i5)  # revealed: Never
-    reveal_type(i6)  # revealed: Never
-```
-
-### Union of a type and its negation
-
-Similarly, if we have both `P` and `~P` in a _union_, we could simplify that to `object`. However,
-this is a rather costly operation which would require us to build the negation of each type that we
-add to a union, so this is not implemented at the moment.
-
-```py
-from knot_extensions import Intersection, Not
-
-class P: ...
-
-def _(
-    i1: P | Not[P],
-    i2: Not[P] | P,
-) -> None:
-    # These could be simplified to `object`
-    reveal_type(i1)  # revealed: P | ~P
-    reveal_type(i2)  # revealed: ~P | P
-```
-
-### Negation is an involution
-
-The final of the [complement laws] states that negating twice is equivalent to not negating at all:
-
-```py
-from knot_extensions import Not
-
-class P: ...
-
-def _(
-    i1: Not[P],
-    i2: Not[Not[P]],
-    i3: Not[Not[Not[P]]],
-    i4: Not[Not[Not[Not[P]]]],
-) -> None:
-    reveal_type(i1)  # revealed: ~P
-    reveal_type(i2)  # revealed: P
-    reveal_type(i3)  # revealed: ~P
-    reveal_type(i4)  # revealed: P
-```
-
-## Simplification strategies
-
-In this section, we present various simplification strategies that go beyond the structure of the
-representation.
-
-### `Never` in intersections
-
-If we intersect with `Never`, we can simplify the whole intersection to `Never`, even if there are
-dynamic types involved:
-
-```py
-from knot_extensions import Intersection, Not
-from typing_extensions import Never, Any
-
-class P: ...
-class Q: ...
-
-def _(
-    i1: Intersection[P, Never],
-    i2: Intersection[Never, P],
-    i3: Intersection[Any, Never],
-    i4: Intersection[Never, Not[Any]],
-) -> None:
-    reveal_type(i1)  # revealed: Never
-    reveal_type(i2)  # revealed: Never
-    reveal_type(i3)  # revealed: Never
-    reveal_type(i4)  # revealed: Never
-```
-
-### Simplifications using disjointness
-
-#### Positive contributions
-
-If we intersect disjoint types, we can simplify to `Never`, even in the presence of other types:
-
-```py
-from knot_extensions import Intersection, Not
-from typing import Literal, Any
-
-class P: ...
-
-def _(
-    i01: Intersection[Literal[1], Literal[2]],
-    i02: Intersection[Literal[2], Literal[1]],
-    i03: Intersection[Literal[1], Literal[2], P],
-    i04: Intersection[Literal[1], P, Literal[2]],
-    i05: Intersection[P, Literal[1], Literal[2]],
-    i06: Intersection[Literal[1], Literal[2], Any],
-    i07: Intersection[Literal[1], Any, Literal[2]],
-    i08: Intersection[Any, Literal[1], Literal[2]],
-) -> None:
-    reveal_type(i01)  # revealed: Never
-    reveal_type(i02)  # revealed: Never
-    reveal_type(i03)  # revealed: Never
-    reveal_type(i04)  # revealed: Never
-    reveal_type(i05)  # revealed: Never
-    reveal_type(i06)  # revealed: Never
-    reveal_type(i07)  # revealed: Never
-    reveal_type(i08)  # revealed: Never
-
-# `bool` is final and can not be subclassed, so `type[bool]` is equivalent to `Literal[bool]`, which
-# is disjoint from `type[str]`:
-def example_type_bool_type_str(
-    i: Intersection[type[bool], type[str]],
-) -> None:
-    reveal_type(i)  # revealed: Never
-```
-
-#### Positive and negative contributions
-
-If we intersect a type `X` with the negation of a disjoint type `Y`, we can remove the negative
-contribution `~Y`, as it necessarily overlaps with the positive contribution `X`:
-
-```py
-from knot_extensions import Intersection, Not
-from typing import Literal
-
-def _(
-    i1: Intersection[Literal[1], Not[Literal[2]]],
-    i2: Intersection[Not[Literal[2]], Literal[1]],
-    i3: Intersection[Literal[1], Not[Literal[2]], int],
-    i4: Intersection[Literal[1], int, Not[Literal[2]]],
-    i5: Intersection[int, Literal[1], Not[Literal[2]]],
-) -> None:
-    reveal_type(i1)  # revealed: Literal[1]
-    reveal_type(i2)  # revealed: Literal[1]
-    reveal_type(i3)  # revealed: Literal[1]
-    reveal_type(i4)  # revealed: Literal[1]
-    reveal_type(i5)  # revealed: Literal[1]
-
-# None is disjoint from int, so this simplification applies here
-def example_none(
-    i1: Intersection[int, Not[None]],
-    i2: Intersection[Not[None], int],
-) -> None:
-    reveal_type(i1)  # revealed: int
-    reveal_type(i2)  # revealed: int
-```
-
-### Simplifications using subtype relationships
-
-#### Positive type and positive subtype
-
-Subtypes are contained within their supertypes, so we can simplify intersections by removing
-superfluous supertypes:
-
-```py
-from knot_extensions import Intersection, Not
-from typing import Any
-
-class A: ...
-class B(A): ...
-class C(B): ...
-class Unrelated: ...
-
-def _(
-    i01: Intersection[A, B],
-    i02: Intersection[B, A],
-    i03: Intersection[A, C],
-    i04: Intersection[C, A],
-    i05: Intersection[B, C],
-    i06: Intersection[C, B],
-    i07: Intersection[A, B, C],
-    i08: Intersection[C, B, A],
-    i09: Intersection[B, C, A],
-    i10: Intersection[A, B, Unrelated],
-    i11: Intersection[B, A, Unrelated],
-    i12: Intersection[B, Unrelated, A],
-    i13: Intersection[A, Unrelated, B],
-    i14: Intersection[Unrelated, A, B],
-    i15: Intersection[Unrelated, B, A],
-    i16: Intersection[A, B, Any],
-    i17: Intersection[B, A, Any],
-    i18: Intersection[B, Any, A],
-    i19: Intersection[A, Any, B],
-    i20: Intersection[Any, A, B],
-    i21: Intersection[Any, B, A],
-) -> None:
-    reveal_type(i01)  # revealed: B
-    reveal_type(i02)  # revealed: B
-    reveal_type(i03)  # revealed: C
-    reveal_type(i04)  # revealed: C
-    reveal_type(i05)  # revealed: C
-    reveal_type(i06)  # revealed: C
-    reveal_type(i07)  # revealed: C
-    reveal_type(i08)  # revealed: C
-    reveal_type(i09)  # revealed: C
-    reveal_type(i10)  # revealed: B & Unrelated
-    reveal_type(i11)  # revealed: B & Unrelated
-    reveal_type(i12)  # revealed: B & Unrelated
-    reveal_type(i13)  # revealed: Unrelated & B
-    reveal_type(i14)  # revealed: Unrelated & B
-    reveal_type(i15)  # revealed: Unrelated & B
-    reveal_type(i16)  # revealed: B & Any
-    reveal_type(i17)  # revealed: B & Any
-    reveal_type(i18)  # revealed: B & Any
-    reveal_type(i19)  # revealed: Any & B
-    reveal_type(i20)  # revealed: Any & B
-    reveal_type(i21)  # revealed: Any & B
-```
-
-#### Negative type and negative subtype
-
-For negative contributions, this property is reversed. Here we can get remove superfluous
-_subtypes_:
-
-```py
-from knot_extensions import Intersection, Not
-from typing import Any
-
-class A: ...
-class B(A): ...
-class C(B): ...
-class Unrelated: ...
-
-def _(
-    i01: Intersection[Not[B], Not[A]],
-    i02: Intersection[Not[A], Not[B]],
-    i03: Intersection[Not[A], Not[C]],
-    i04: Intersection[Not[C], Not[A]],
-    i05: Intersection[Not[B], Not[C]],
-    i06: Intersection[Not[C], Not[B]],
-    i07: Intersection[Not[A], Not[B], Not[C]],
-    i08: Intersection[Not[C], Not[B], Not[A]],
-    i09: Intersection[Not[B], Not[C], Not[A]],
-    i10: Intersection[Not[B], Not[A], Unrelated],
-    i11: Intersection[Not[A], Not[B], Unrelated],
-    i12: Intersection[Not[A], Unrelated, Not[B]],
-    i13: Intersection[Not[B], Unrelated, Not[A]],
-    i14: Intersection[Unrelated, Not[A], Not[B]],
-    i15: Intersection[Unrelated, Not[B], Not[A]],
-    i16: Intersection[Not[B], Not[A], Any],
-    i17: Intersection[Not[A], Not[B], Any],
-    i18: Intersection[Not[A], Any, Not[B]],
-    i19: Intersection[Not[B], Any, Not[A]],
-    i20: Intersection[Any, Not[A], Not[B]],
-    i21: Intersection[Any, Not[B], Not[A]],
-) -> None:
-    reveal_type(i01)  # revealed: ~A
-    reveal_type(i02)  # revealed: ~A
-    reveal_type(i03)  # revealed: ~A
-    reveal_type(i04)  # revealed: ~A
-    reveal_type(i05)  # revealed: ~B
-    reveal_type(i06)  # revealed: ~B
-    reveal_type(i07)  # revealed: ~A
-    reveal_type(i08)  # revealed: ~A
-    reveal_type(i09)  # revealed: ~A
-    reveal_type(i10)  # revealed: Unrelated & ~A
-    reveal_type(i11)  # revealed: Unrelated & ~A
-    reveal_type(i12)  # revealed: Unrelated & ~A
-    reveal_type(i13)  # revealed: Unrelated & ~A
-    reveal_type(i14)  # revealed: Unrelated & ~A
-    reveal_type(i15)  # revealed: Unrelated & ~A
-    reveal_type(i16)  # revealed: Any & ~A
-    reveal_type(i17)  # revealed: Any & ~A
-    reveal_type(i18)  # revealed: Any & ~A
-    reveal_type(i19)  # revealed: Any & ~A
-    reveal_type(i20)  # revealed: Any & ~A
-    reveal_type(i21)  # revealed: Any & ~A
-```
-
-#### Negative type and multiple negative subtypes
-
-If there are multiple negative subtypes, all of them can be removed:
-
-```py
-from knot_extensions import Intersection, Not
-
-class A: ...
-class B1(A): ...
-class B2(A): ...
-
-def _(
-    i1: Intersection[Not[A], Not[B1], Not[B2]],
-    i2: Intersection[Not[A], Not[B2], Not[B1]],
-    i3: Intersection[Not[B1], Not[A], Not[B2]],
-    i4: Intersection[Not[B1], Not[B2], Not[A]],
-    i5: Intersection[Not[B2], Not[A], Not[B1]],
-    i6: Intersection[Not[B2], Not[B1], Not[A]],
-) -> None:
-    reveal_type(i1)  # revealed: ~A
-    reveal_type(i2)  # revealed: ~A
-    reveal_type(i3)  # revealed: ~A
-    reveal_type(i4)  # revealed: ~A
-    reveal_type(i5)  # revealed: ~A
-    reveal_type(i6)  # revealed: ~A
-```
-
-#### Negative type and positive subtype
-
-When `A` is a supertype of `B`, its negation `~A` is disjoint from `B`, so we can simplify the
-intersection to `Never`:
-
-```py
-from knot_extensions import Intersection, Not
-from typing import Any
-
-class A: ...
-class B(A): ...
-class C(B): ...
-class Unrelated: ...
-
-def _(
-    i1: Intersection[Not[A], B],
-    i2: Intersection[B, Not[A]],
-    i3: Intersection[Not[A], C],
-    i4: Intersection[C, Not[A]],
-    i5: Intersection[Unrelated, Not[A], B],
-    i6: Intersection[B, Not[A], Not[Unrelated]],
-    i7: Intersection[Any, Not[A], B],
-    i8: Intersection[B, Not[A], Not[Any]],
-) -> None:
-    reveal_type(i1)  # revealed: Never
-    reveal_type(i2)  # revealed: Never
-    reveal_type(i3)  # revealed: Never
-    reveal_type(i4)  # revealed: Never
-    reveal_type(i5)  # revealed: Never
-    reveal_type(i6)  # revealed: Never
-    reveal_type(i7)  # revealed: Never
-    reveal_type(i8)  # revealed: Never
-```
-
-## Non fully-static types
-
-### Negation of dynamic types
-
-`Any` represents the dynamic type, an unknown set of runtime values. The negation of that, `~Any`,
-is still an unknown set of runtime values, so `~Any` is equivalent to `Any`. We therefore eagerly
-simplify `~Any` to `Any` in intersections. The same applies to `Unknown`.
-
-```py
-from knot_extensions import Intersection, Not, Unknown
-from typing_extensions import Any, Never
-
-class P: ...
-
-def any(
-    i1: Not[Any],
-    i2: Intersection[P, Not[Any]],
-    i3: Intersection[Never, Not[Any]],
-) -> None:
-    reveal_type(i1)  # revealed: Any
-    reveal_type(i2)  # revealed: P & Any
-    reveal_type(i3)  # revealed: Never
-
-def unknown(
-    i1: Not[Unknown],
-    i2: Intersection[P, Not[Unknown]],
-    i3: Intersection[Never, Not[Unknown]],
-) -> None:
-    reveal_type(i1)  # revealed: Unknown
-    reveal_type(i2)  # revealed: P & Unknown
-    reveal_type(i3)  # revealed: Never
-```
-
-### Collapsing of multiple `Any`/`Unknown` contributions
-
-The intersection of an unknown set of runtime values with (another) unknown set of runtime values is
-still an unknown set of runtime values:
-
-```py
-from knot_extensions import Intersection, Not, Unknown
-from typing_extensions import Any
-
-class P: ...
-
-def any(
-    i1: Intersection[Any, Any],
-    i2: Intersection[P, Any, Any],
-    i3: Intersection[Any, P, Any],
-    i4: Intersection[Any, Any, P],
-) -> None:
-    reveal_type(i1)  # revealed: Any
-    reveal_type(i2)  # revealed: P & Any
-    reveal_type(i3)  # revealed: Any & P
-    reveal_type(i4)  # revealed: Any & P
-
-def unknown(
-    i1: Intersection[Unknown, Unknown],
-    i2: Intersection[P, Unknown, Unknown],
-    i3: Intersection[Unknown, P, Unknown],
-    i4: Intersection[Unknown, Unknown, P],
-) -> None:
-    reveal_type(i1)  # revealed: Unknown
-    reveal_type(i2)  # revealed: P & Unknown
-    reveal_type(i3)  # revealed: Unknown & P
-    reveal_type(i4)  # revealed: Unknown & P
-```
-
-### No self-cancellation
-
-Dynamic types do not cancel each other out. Intersecting an unknown set of values with the negation
-of another unknown set of values is not necessarily empty, so we keep the positive contribution:
-
-```py
-from knot_extensions import Intersection, Not, Unknown
-
-def any(
-    i1: Intersection[Any, Not[Any]],
-    i2: Intersection[Not[Any], Any],
-) -> None:
-    reveal_type(i1)  # revealed: Any
-    reveal_type(i2)  # revealed: Any
-
-def unknown(
-    i1: Intersection[Unknown, Not[Unknown]],
-    i2: Intersection[Not[Unknown], Unknown],
-) -> None:
-    reveal_type(i1)  # revealed: Unknown
-    reveal_type(i2)  # revealed: Unknown
-```
-
-### Mixed dynamic types
-
-We currently do not simplify mixed dynamic types, but might consider doing so in the future:
-
-```py
-from knot_extensions import Intersection, Not, Unknown
-
-def mixed(
-    i1: Intersection[Any, Unknown],
-    i2: Intersection[Any, Not[Unknown]],
-    i3: Intersection[Not[Any], Unknown],
-    i4: Intersection[Not[Any], Not[Unknown]],
-) -> None:
-    reveal_type(i1)  # revealed: Any & Unknown
-    reveal_type(i2)  # revealed: Any & Unknown
-    reveal_type(i3)  # revealed: Any & Unknown
-    reveal_type(i4)  # revealed: Any & Unknown
-```
-
-[complement laws]: https://en.wikipedia.org/wiki/Complement_(set_theory)
-[de morgan's laws]: https://en.wikipedia.org/wiki/De_Morgan%27s_laws

crates/red_knot_python_semantic/resources/mdtest/literal/ellipsis.md

@@ -1,23 +1,7 @@
 # Ellipsis literals
 
-## Python 3.9
-
-```toml
-[environment]
-python-version = "3.9"
-```
+## Simple
 
 ```py
-reveal_type(...)  # revealed: ellipsis
-```
-
-## Python 3.10
-
-```toml
-[environment]
-python-version = "3.10"
-```
-
-```py
-reveal_type(...)  # revealed: EllipsisType
+reveal_type(...)  # revealed: EllipsisType | ellipsis
 ```

crates/red_knot_python_semantic/resources/mdtest/loops/for.md

@@ -98,7 +98,7 @@ reveal_type(x)
 for x in (1, "a", b"foo"):
     pass
 
-# revealed: Literal[1, "a", b"foo"]
+# revealed: Literal[1] | Literal["a"] | Literal[b"foo"]
 # error: [possibly-unresolved-reference]
 reveal_type(x)
 ```

crates/red_knot_python_semantic/resources/mdtest/loops/while_loop.md

@@ -41,7 +41,7 @@ def _(flag: bool, flag2: bool):
         x = 3
 
     reveal_type(x)  # revealed: Literal[2, 3]
-    reveal_type(y)  # revealed: Literal[4, 1, 2]
+    reveal_type(y)  # revealed: Literal[1, 2, 4]
 ```
 
 ## Nested `while` loops

crates/red_knot_python_semantic/resources/mdtest/metaclass.md

@@ -170,35 +170,8 @@ def f(*args, **kwargs) -> int: ...
 
 class A(metaclass=f): ...
 
-# TODO: Should be `int`
-reveal_type(A)  # revealed: Literal[A]
-reveal_type(A.__class__)  # revealed: type[int]
-
-def _(n: int):
-    # error: [invalid-metaclass]
-    class B(metaclass=n): ...
-    # TODO: Should be `Unknown`
-    reveal_type(B)  # revealed: Literal[B]
-    reveal_type(B.__class__)  # revealed: type[Unknown]
-
-def _(flag: bool):
-    m = f if flag else 42
-
-    # error: [invalid-metaclass]
-    class C(metaclass=m): ...
-    # TODO: Should be `int | Unknown`
-    reveal_type(C)  # revealed: Literal[C]
-    reveal_type(C.__class__)  # revealed: type[Unknown]
-
-class SignatureMismatch: ...
-
-# TODO: Emit a diagnostic
-class D(metaclass=SignatureMismatch): ...
-
-# TODO: Should be `Unknown`
-reveal_type(D)  # revealed: Literal[D]
-# TODO: Should be `type[Unknown]`
-reveal_type(D.__class__)  # revealed: Literal[SignatureMismatch]
+# TODO should be `type[int]`
+reveal_type(A.__class__)  # revealed: @Todo(metaclass not a class)
 ```
 
 ## Cyclic

crates/red_knot_python_semantic/resources/mdtest/narrow/conditionals/is.md

@@ -56,7 +56,7 @@ def _(x_flag: bool, y_flag: bool):
 def _(flag1: bool, flag2: bool):
     x = None if flag1 else (1 if flag2 else True)
 
-    reveal_type(x)  # revealed: None | Literal[1, True]
+    reveal_type(x)  # revealed: None | Literal[1] | Literal[True]
     if x is None:
         reveal_type(x)  # revealed: None
     elif x is True:

crates/red_knot_python_semantic/resources/mdtest/narrow/isinstance.md

@@ -17,7 +17,7 @@ def _(flag: bool):
             reveal_type(x)  # revealed: Never
 
     if isinstance(x, (int, object)):
-        reveal_type(x)  # revealed: Literal[1, "a"]
+        reveal_type(x)  # revealed: Literal[1] | Literal["a"]
 ```
 
 ## `classinfo` is a tuple of types
@@ -30,7 +30,7 @@ def _(flag: bool, flag1: bool, flag2: bool):
     x = 1 if flag else "a"
 
     if isinstance(x, (int, str)):
-        reveal_type(x)  # revealed: Literal[1, "a"]
+        reveal_type(x)  # revealed: Literal[1] | Literal["a"]
     else:
         reveal_type(x)  # revealed: Never
 
@@ -43,19 +43,19 @@ def _(flag: bool, flag1: bool, flag2: bool):
     # No narrowing should occur if a larger type is also
     # one of the possibilities:
     if isinstance(x, (int, object)):
-        reveal_type(x)  # revealed: Literal[1, "a"]
+        reveal_type(x)  # revealed: Literal[1] | Literal["a"]
     else:
         reveal_type(x)  # revealed: Never
 
     y = 1 if flag1 else "a" if flag2 else b"b"
     if isinstance(y, (int, str)):
-        reveal_type(y)  # revealed: Literal[1, "a"]
+        reveal_type(y)  # revealed: Literal[1] | Literal["a"]
 
     if isinstance(y, (int, bytes)):
-        reveal_type(y)  # revealed: Literal[1, b"b"]
+        reveal_type(y)  # revealed: Literal[1] | Literal[b"b"]
 
     if isinstance(y, (str, bytes)):
-        reveal_type(y)  # revealed: Literal["a", b"b"]
+        reveal_type(y)  # revealed: Literal["a"] | Literal[b"b"]
 ```
 
 ## `classinfo` is a nested tuple of types
@@ -107,7 +107,7 @@ def _(flag: bool):
     x = 1 if flag else "foo"
 
     if isinstance(x, t):
-        reveal_type(x)  # revealed: Literal[1, "foo"]
+        reveal_type(x)  # revealed: Literal[1] | Literal["foo"]
 ```
 
 ## Do not use custom `isinstance` for narrowing
@@ -119,7 +119,7 @@ def _(flag: bool):
     x = 1 if flag else "a"
 
     if isinstance(x, int):
-        reveal_type(x)  # revealed: Literal[1, "a"]
+        reveal_type(x)  # revealed: Literal[1] | Literal["a"]
 ```
 
 ## Do support narrowing if `isinstance` is aliased
@@ -155,12 +155,12 @@ def _(flag: bool):
     # TODO: this should cause us to emit a diagnostic during
     # type checking
     if isinstance(x, "a"):
-        reveal_type(x)  # revealed: Literal[1, "a"]
+        reveal_type(x)  # revealed: Literal[1] | Literal["a"]
 
     # TODO: this should cause us to emit a diagnostic during
     # type checking
     if isinstance(x, "int"):
-        reveal_type(x)  # revealed: Literal[1, "a"]
+        reveal_type(x)  # revealed: Literal[1] | Literal["a"]
 ```
 
 ## Do not narrow if there are keyword arguments
@@ -169,15 +169,8 @@ def _(flag: bool):
 def _(flag: bool):
     x = 1 if flag else "a"
 
-    # error: [unknown-argument]
+    # TODO: this should cause us to emit a diagnostic
+    # (`isinstance` has no `foo` parameter)
     if isinstance(x, int, foo="bar"):
-        reveal_type(x)  # revealed: Literal[1, "a"]
-```
-
-## `type[]` types are narrowed as well as class-literal types
-
-```py
-def _(x: object, y: type[int]):
-    if isinstance(x, y):
-        reveal_type(x)  # revealed: int
+        reveal_type(x)  # revealed: Literal[1] | Literal["a"]
 ```

crates/red_knot_python_semantic/resources/mdtest/narrow/issubclass.md

@@ -90,19 +90,15 @@ def _(t: type[object]):
         if issubclass(t, B):
             reveal_type(t)  # revealed: type[A] & type[B]
     else:
-        reveal_type(t)  # revealed: type & ~type[A]
+        reveal_type(t)  # revealed: type[object] & ~type[A]
 ```
 
 ### Handling of `None`
 
-`types.NoneType` is only available in Python 3.10 and later:
-
-```toml
-[environment]
-python-version = "3.10"
-```
-
 ```py
+# TODO: this error should ideally go away once we (1) understand `sys.version_info` branches,
+# and (2) set the target Python version for this test to 3.10.
+# error: [possibly-unbound-import] "Member `NoneType` of module `types` is possibly unbound"
 from types import NoneType
 
 def _(flag: bool):
@@ -146,7 +142,7 @@ class A: ...
 
 t = object()
 
-# error: [invalid-argument-type]
+# TODO: we should emit a diagnostic here
 if issubclass(t, A):
     reveal_type(t)  # revealed: type[A]
 ```
@@ -160,7 +156,7 @@ branch:
 ```py
 t = 1
 
-# error: [invalid-argument-type]
+# TODO: we should emit a diagnostic here
 if issubclass(t, int):
     reveal_type(t)  # revealed: Never
 ```
@@ -234,15 +230,8 @@ def flag() -> bool: ...
 
 t = int if flag() else str
 
-# error: [unknown-argument]
+# TODO: this should cause us to emit a diagnostic
+# (`issubclass` has no `foo` parameter)
 if issubclass(t, int, foo="bar"):
     reveal_type(t)  # revealed: Literal[int, str]
 ```
-
-### `type[]` types are narrowed as well as class-literal types
-
-```py
-def _(x: type, y: type[int]):
-    if issubclass(x, y):
-        reveal_type(x)  # revealed: type[int]
-```

crates/red_knot_python_semantic/resources/mdtest/narrow/match.md

@@ -16,48 +16,3 @@ def _(flag: bool):
 
     reveal_type(y)  # revealed: Literal[0] | None
 ```
-
-## Class patterns
-
-```py
-def get_object() -> object: ...
-
-class A: ...
-class B: ...
-
-x = get_object()
-
-reveal_type(x)  # revealed: object
-
-match x:
-    case A():
-        reveal_type(x)  # revealed: A
-    case B():
-        # TODO could be `B & ~A`
-        reveal_type(x)  # revealed: B
-
-reveal_type(x)  # revealed: object
-```
-
-## Class pattern with guard
-
-```py
-def get_object() -> object: ...
-
-class A:
-    def y() -> int: ...
-
-class B: ...
-
-x = get_object()
-
-reveal_type(x)  # revealed: object
-
-match x:
-    case A() if reveal_type(x):  # revealed: A
-        pass
-    case B() if reveal_type(x):  # revealed: B
-        pass
-
-reveal_type(x)  # revealed: object
-```

crates/red_knot_python_semantic/resources/mdtest/narrow/truthiness.md

@@ -1,315 +0,0 @@
-# Narrowing For Truthiness Checks (`if x` or `if not x`)
-
-## Value Literals
-
-```py
-def foo() -> Literal[0, -1, True, False, "", "foo", b"", b"bar", None] | tuple[()]:
-    return 0
-
-x = foo()
-
-if x:
-    reveal_type(x)  # revealed: Literal[-1, True, "foo", b"bar"]
-else:
-    reveal_type(x)  # revealed: Literal[0, False, "", b""] | None | tuple[()]
-
-if not x:
-    reveal_type(x)  # revealed: Literal[0, False, "", b""] | None | tuple[()]
-else:
-    reveal_type(x)  # revealed: Literal[-1, True, "foo", b"bar"]
-
-if x and not x:
-    reveal_type(x)  # revealed: Never
-else:
-    reveal_type(x)  # revealed: Literal[0, "", b"", -1, "foo", b"bar"] | bool | None | tuple[()]
-
-if not (x and not x):
-    reveal_type(x)  # revealed: Literal[0, "", b"", -1, "foo", b"bar"] | bool | None | tuple[()]
-else:
-    reveal_type(x)  # revealed: Never
-
-if x or not x:
-    reveal_type(x)  # revealed: Literal[-1, "foo", b"bar", 0, "", b""] | bool | None | tuple[()]
-else:
-    reveal_type(x)  # revealed: Never
-
-if not (x or not x):
-    reveal_type(x)  # revealed: Never
-else:
-    reveal_type(x)  # revealed: Literal[-1, "foo", b"bar", 0, "", b""] | bool | None | tuple[()]
-
-if (isinstance(x, int) or isinstance(x, str)) and x:
-    reveal_type(x)  # revealed: Literal[-1, True, "foo"]
-else:
-    reveal_type(x)  # revealed: Literal[b"", b"bar", 0, False, ""] | None | tuple[()]
-```
-
-## Function Literals
-
-Basically functions are always truthy.
-
-```py
-def flag() -> bool:
-    return True
-
-def foo(hello: int) -> bytes:
-    return b""
-
-def bar(world: str, *args, **kwargs) -> float:
-    return 0.0
-
-x = foo if flag() else bar
-
-if x:
-    reveal_type(x)  # revealed: Literal[foo, bar]
-else:
-    reveal_type(x)  # revealed: Never
-```
-
-## Mutable Truthiness
-
-### Truthiness of Instances
-
-The boolean value of an instance is not always consistent. For example, `__bool__` can be customized
-to return random values, or in the case of a `list()`, the result depends on the number of elements
-in the list. Therefore, these types should not be narrowed by `if x` or `if not x`.
-
-```py
-class A: ...
-class B: ...
-
-def f(x: A | B):
-    if x:
-        reveal_type(x)  # revealed: A & ~AlwaysFalsy | B & ~AlwaysFalsy
-    else:
-        reveal_type(x)  # revealed: A & ~AlwaysTruthy | B & ~AlwaysTruthy
-
-    if x and not x:
-        reveal_type(x)  # revealed: A & ~AlwaysFalsy & ~AlwaysTruthy | B & ~AlwaysFalsy & ~AlwaysTruthy
-    else:
-        reveal_type(x)  # revealed: A & ~AlwaysTruthy | B & ~AlwaysTruthy | A & ~AlwaysFalsy | B & ~AlwaysFalsy
-
-    if x or not x:
-        reveal_type(x)  # revealed: A & ~AlwaysFalsy | B & ~AlwaysFalsy | A & ~AlwaysTruthy | B & ~AlwaysTruthy
-    else:
-        reveal_type(x)  # revealed: A & ~AlwaysTruthy & ~AlwaysFalsy | B & ~AlwaysTruthy & ~AlwaysFalsy
-```
-
-### Truthiness of Types
-
-Also, types may not be Truthy. This is because `__bool__` can be customized via a metaclass.
-Although this is a very rare case, we may consider metaclass checks in the future to handle this
-more accurately.
-
-```py
-def flag() -> bool:
-    return True
-
-x = int if flag() else str
-reveal_type(x)  # revealed: Literal[int, str]
-
-if x:
-    reveal_type(x)  # revealed: Literal[int] & ~AlwaysFalsy | Literal[str] & ~AlwaysFalsy
-else:
-    reveal_type(x)  # revealed: Literal[int] & ~AlwaysTruthy | Literal[str] & ~AlwaysTruthy
-```
-
-## Determined Truthiness
-
-Some custom classes can have a boolean value that is consistently determined as either `True` or
-`False`, regardless of the instance's state. This is achieved by defining a `__bool__` method that
-always returns a fixed value.
-
-These types can always be fully narrowed in boolean contexts, as shown below:
-
-```py
-class T:
-    def __bool__(self) -> Literal[True]:
-        return True
-
-class F:
-    def __bool__(self) -> Literal[False]:
-        return False
-
-t = T()
-
-if t:
-    reveal_type(t)  # revealed: T
-else:
-    reveal_type(t)  # revealed: Never
-
-f = F()
-
-if f:
-    reveal_type(f)  # revealed: Never
-else:
-    reveal_type(f)  # revealed: F
-```
-
-## Narrowing Complex Intersection and Union
-
-```py
-class A: ...
-class B: ...
-
-def flag() -> bool:
-    return True
-
-def instance() -> A | B:
-    return A()
-
-def literals() -> Literal[0, 42, "", "hello"]:
-    return 42
-
-x = instance()
-y = literals()
-
-if isinstance(x, str) and not isinstance(x, B):
-    reveal_type(x)  # revealed: A & str & ~B
-    reveal_type(y)  # revealed: Literal[0, 42, "", "hello"]
-
-    z = x if flag() else y
-
-    reveal_type(z)  # revealed: A & str & ~B | Literal[0, 42, "", "hello"]
-
-    if z:
-        reveal_type(z)  # revealed: A & str & ~B & ~AlwaysFalsy | Literal[42, "hello"]
-    else:
-        reveal_type(z)  # revealed: A & str & ~B & ~AlwaysTruthy | Literal[0, ""]
-```
-
-## Narrowing Multiple Variables
-
-```py
-def f(x: Literal[0, 1], y: Literal["", "hello"]):
-    if x and y and not x and not y:
-        reveal_type(x)  # revealed: Never
-        reveal_type(y)  # revealed: Never
-    else:
-        # ~(x or not x) and ~(y or not y)
-        reveal_type(x)  # revealed: Literal[0, 1]
-        reveal_type(y)  # revealed: Literal["", "hello"]
-
-    if (x or not x) and (y and not y):
-        reveal_type(x)  # revealed: Literal[0, 1]
-        reveal_type(y)  # revealed: Never
-    else:
-        # ~(x or not x) or ~(y and not y)
-        reveal_type(x)  # revealed: Literal[0, 1]
-        reveal_type(y)  # revealed: Literal["", "hello"]
-```
-
-## ControlFlow Merging
-
-After merging control flows, when we take the union of all constraints applied in each branch, we
-should return to the original state.
-
-```py
-class A: ...
-
-x = A()
-
-if x and not x:
-    y = x
-    reveal_type(y)  # revealed: A & ~AlwaysFalsy & ~AlwaysTruthy
-else:
-    y = x
-    reveal_type(y)  # revealed: A & ~AlwaysTruthy | A & ~AlwaysFalsy
-
-# TODO: It should be A. We should improve UnionBuilder or IntersectionBuilder. (issue #15023)
-reveal_type(y)  # revealed: A & ~AlwaysTruthy | A & ~AlwaysFalsy
-```
-
-## Truthiness of classes
-
-```py
-class MetaAmbiguous(type):
-    def __bool__(self) -> bool: ...
-
-class MetaFalsy(type):
-    def __bool__(self) -> Literal[False]: ...
-
-class MetaTruthy(type):
-    def __bool__(self) -> Literal[True]: ...
-
-class MetaDeferred(type):
-    def __bool__(self) -> MetaAmbiguous: ...
-
-class AmbiguousClass(metaclass=MetaAmbiguous): ...
-class FalsyClass(metaclass=MetaFalsy): ...
-class TruthyClass(metaclass=MetaTruthy): ...
-class DeferredClass(metaclass=MetaDeferred): ...
-
-def _(
-    a: type[AmbiguousClass],
-    t: type[TruthyClass],
-    f: type[FalsyClass],
-    d: type[DeferredClass],
-    ta: type[TruthyClass | AmbiguousClass],
-    af: type[AmbiguousClass] | type[FalsyClass],
-    flag: bool,
-):
-    reveal_type(ta)  # revealed: type[TruthyClass] | type[AmbiguousClass]
-    if ta:
-        reveal_type(ta)  # revealed: type[TruthyClass] | type[AmbiguousClass] & ~AlwaysFalsy
-
-    reveal_type(af)  # revealed: type[AmbiguousClass] | type[FalsyClass]
-    if af:
-        reveal_type(af)  # revealed: type[AmbiguousClass] & ~AlwaysFalsy
-
-    # TODO: Emit a diagnostic (`d` is not valid in boolean context)
-    if d:
-        # TODO: Should be `Unknown`
-        reveal_type(d)  # revealed: type[DeferredClass] & ~AlwaysFalsy
-
-    tf = TruthyClass if flag else FalsyClass
-    reveal_type(tf)  # revealed: Literal[TruthyClass, FalsyClass]
-
-    if tf:
-        reveal_type(tf)  # revealed: Literal[TruthyClass]
-    else:
-        reveal_type(tf)  # revealed: Literal[FalsyClass]
-```
-
-## Narrowing in chained boolean expressions
-
-```py
-from typing import Literal
-
-class A: ...
-
-def _(x: Literal[0, 1]):
-    reveal_type(x or A())  # revealed: Literal[1] | A
-    reveal_type(x and A())  # revealed: Literal[0] | A
-
-def _(x: str):
-    reveal_type(x or A())  # revealed: str & ~AlwaysFalsy | A
-    reveal_type(x and A())  # revealed: str & ~AlwaysTruthy | A
-
-def _(x: bool | str):
-    reveal_type(x or A())  # revealed: Literal[True] | str & ~AlwaysFalsy | A
-    reveal_type(x and A())  # revealed: Literal[False] | str & ~AlwaysTruthy | A
-
-class Falsy:
-    def __bool__(self) -> Literal[False]: ...
-
-class Truthy:
-    def __bool__(self) -> Literal[True]: ...
-
-def _(x: Falsy | Truthy):
-    reveal_type(x or A())  # revealed: Truthy | A
-    reveal_type(x and A())  # revealed: Falsy | A
-
-class MetaFalsy(type):
-    def __bool__(self) -> Literal[False]: ...
-
-class MetaTruthy(type):
-    def __bool__(self) -> Literal[True]: ...
-
-class FalsyClass(metaclass=MetaFalsy): ...
-class TruthyClass(metaclass=MetaTruthy): ...
-
-def _(x: type[FalsyClass] | type[TruthyClass]):
-    reveal_type(x or A())  # revealed: type[TruthyClass] | A
-    reveal_type(x and A())  # revealed: type[FalsyClass] | A
-```

crates/red_knot_python_semantic/resources/mdtest/scopes/unbound.md

@@ -37,7 +37,7 @@ class C:
     # error: [possibly-unresolved-reference]
     y = x
 
-reveal_type(C.y)  # revealed: Literal[1, "abc"]
+reveal_type(C.y)  # revealed: Literal[1] | Literal["abc"]
 ```
 
 ## Unbound function local

crates/red_knot_python_semantic/resources/mdtest/shadowing/function.md

@@ -25,29 +25,3 @@ def f(): ...
 
 f: int = 1
 ```
-
-## Explicit shadowing involving `def` statements
-
-Since a `def` statement is a declaration, one `def` can shadow another `def`, or shadow a previous
-non-`def` declaration, without error.
-
-```py
-f = 1
-reveal_type(f)  # revealed: Literal[1]
-
-def f(): ...
-
-reveal_type(f)  # revealed: Literal[f]
-
-def f(x: int) -> int:
-    raise NotImplementedError
-
-reveal_type(f)  # revealed: Literal[f]
-
-f: int = 1
-reveal_type(f)  # revealed: Literal[1]
-
-def f(): ...
-
-reveal_type(f)  # revealed: Literal[f]
-```

crates/red_knot_python_semantic/resources/mdtest/slots.md

@@ -1,184 +0,0 @@
-# `__slots__`
-
-## Not specified and empty
-
-```py
-class A: ...
-
-class B:
-    __slots__ = ()
-
-class C:
-    __slots__ = ("lorem", "ipsum")
-
-class AB(A, B): ...  # fine
-class AC(A, C): ...  # fine
-class BC(B, C): ...  # fine
-class ABC(A, B, C): ...  # fine
-```
-
-## Incompatible tuples
-
-```py
-class A:
-    __slots__ = ("a", "b")
-
-class B:
-    __slots__ = ("c", "d")
-
-class C(
-    A,  # error: [incompatible-slots]
-    B,  # error: [incompatible-slots]
-): ...
-```
-
-## Same value
-
-```py
-class A:
-    __slots__ = ("a", "b")
-
-class B:
-    __slots__ = ("a", "b")
-
-class C(
-    A,  # error: [incompatible-slots]
-    B,  # error: [incompatible-slots]
-): ...
-```
-
-## Strings
-
-```py
-class A:
-    __slots__ = "abc"
-
-class B:
-    __slots__ = ("abc",)
-
-class AB(
-    A,  # error: [incompatible-slots]
-    B,  # error: [incompatible-slots]
-): ...
-```
-
-## Invalid
-
-TODO: Emit diagnostics
-
-```py
-class NonString1:
-    __slots__ = 42
-
-class NonString2:
-    __slots__ = b"ar"
-
-class NonIdentifier1:
-    __slots__ = "42"
-
-class NonIdentifier2:
-    __slots__ = ("lorem", "42")
-
-class NonIdentifier3:
-    __slots__ = (e for e in ("lorem", "42"))
-```
-
-## Inheritance
-
-```py
-class A:
-    __slots__ = ("a", "b")
-
-class B(A): ...
-
-class C:
-    __slots__ = ("c", "d")
-
-class D(C): ...
-class E(
-    B,  # error: [incompatible-slots]
-    D,  # error: [incompatible-slots]
-): ...
-```
-
-## Single solid base
-
-```py
-class A:
-    __slots__ = ("a", "b")
-
-class B(A): ...
-class C(A): ...
-class D(B, A): ...  # fine
-class E(B, C, A): ...  # fine
-```
-
-## False negatives
-
-### Possibly unbound
-
-```py
-def _(flag: bool):
-    class A:
-        if flag:
-            __slots__ = ("a", "b")
-
-    class B:
-        __slots__ = ("c", "d")
-
-    # Might or might not be fine at runtime
-    class C(A, B): ...
-```
-
-### Bound but with different types
-
-```py
-def _(flag: bool):
-    class A:
-        if flag:
-            __slots__ = ("a", "b")
-        else:
-            __slots__ = ()
-
-    class B:
-        __slots__ = ("c", "d")
-
-    # Might or might not be fine at runtime
-    class C(A, B): ...
-```
-
-### Non-tuples
-
-```py
-class A:
-    __slots__ = ["a", "b"]  # This is treated as "dynamic"
-
-class B:
-    __slots__ = ("c", "d")
-
-# False negative: [incompatible-slots]
-class C(A, B): ...
-```
-
-### Post-hoc modifications
-
-```py
-class A:
-    __slots__ = ()
-    __slots__ += ("a", "b")
-
-reveal_type(A.__slots__)  # revealed: @Todo(return type)
-
-class B:
-    __slots__ = ("c", "d")
-
-# False negative: [incompatible-slots]
-class C(A, B): ...
-```
-
-### Built-ins with implicit layouts
-
-```py
-# False negative: [incompatible-slots]
-class A(int, str): ...
-```

crates/red_knot_python_semantic/resources/mdtest/stubs/ellipsis.md

@@ -1,78 +0,0 @@
-# Ellipsis
-
-## Function and methods
-
-The ellipsis literal `...` can be used as a placeholder default value for a function parameter, in a
-stub file only, regardless of the type of the parameter.
-
-```py path=test.pyi
-def f(x: int = ...) -> None:
-    reveal_type(x)  # revealed: int
-
-def f2(x: str = ...) -> None:
-    reveal_type(x)  # revealed: str
-```
-
-## Class and module symbols
-
-The ellipsis literal can be assigned to a class or module symbol, regardless of its declared type,
-in a stub file only.
-
-```py path=test.pyi
-y: bytes = ...
-reveal_type(y)  # revealed: bytes
-x = ...
-reveal_type(x)  # revealed: Unknown
-
-class Foo:
-    y: int = ...
-
-reveal_type(Foo.y)  # revealed: int
-```
-
-## Unpacking ellipsis literal in assignment
-
-No diagnostic is emitted if an ellipsis literal is "unpacked" in a stub file as part of an
-assignment statement:
-
-```py path=test.pyi
-x, y = ...
-reveal_type(x)  # revealed: Unknown
-reveal_type(y)  # revealed: Unknown
-```
-
-## Unpacking ellipsis literal in for loops
-
-Iterating over an ellipsis literal as part of a `for` loop in a stub is invalid, however, and
-results in a diagnostic:
-
-```py path=test.pyi
-# error: [not-iterable] "Object of type `ellipsis` is not iterable"
-for a, b in ...:
-    reveal_type(a)  # revealed: Unknown
-    reveal_type(b)  # revealed: Unknown
-```
-
-## Ellipsis usage in non stub file
-
-In a non-stub file, there's no special treatment of ellipsis literals. An ellipsis literal can only
-be assigned if `EllipsisType` is actually assignable to the annotated type.
-
-```py
-# error: 7 [invalid-parameter-default] "Default value of type `ellipsis` is not assignable to annotated parameter type `int`"
-def f(x: int = ...) -> None: ...
-
-# error: 1 [invalid-assignment] "Object of type `ellipsis` is not assignable to `int`"
-a: int = ...
-b = ...
-reveal_type(b)  # revealed: ellipsis
-```
-
-## Use of `Ellipsis` symbol
-
-There is no special treatment of the builtin name `Ellipsis` in stubs, only of `...` literals.
-
-```py path=test.pyi
-# error: 7 [invalid-parameter-default] "Default value of type `ellipsis` is not assignable to annotated parameter type `int`"
-def f(x: int = Ellipsis) -> None: ...
-```

crates/red_knot_python_semantic/resources/mdtest/subscript/tuple.md

@@ -81,7 +81,10 @@ python-version = "3.9"
 ```
 
 ```py
-# TODO: `tuple[int, str]` is a valid base (generics)
+# TODO:
+#  * `tuple.__class_getitem__` is always bound on 3.9 (`sys.version_info`)
+#  * `tuple[int, str]` is a valid base (generics)
+# error: [call-possibly-unbound-method] "Method `__class_getitem__` of type `Literal[tuple]` is possibly unbound"
 # error: [invalid-base] "Invalid class base with type `GenericAlias` (all bases must be a class, `Any`, `Unknown` or `Todo`)"
 class A(tuple[int, str]): ...
 

crates/red_knot_python_semantic/resources/mdtest/suppressions/knot_ignore.md

@@ -1,182 +0,0 @@
-# Suppressing errors with `knot: ignore`
-
-Type check errors can be suppressed by a `knot: ignore` comment on the same line as the violation.
-
-## Simple `knot: ignore`
-
-```py
-a = 4 + test  # knot: ignore
-```
-
-## Suppressing a specific code
-
-```py
-a = 4 + test  # knot: ignore[unresolved-reference]
-```
-
-## Unused suppression
-
-```py
-test = 10
-# error: [unused-ignore-comment] "Unused `knot: ignore` directive: 'possibly-unresolved-reference'"
-a = test + 3  # knot: ignore[possibly-unresolved-reference]
-```
-
-## Unused suppression if the error codes don't match
-
-```py
-# error: [unresolved-reference]
-# error: [unused-ignore-comment] "Unused `knot: ignore` directive: 'possibly-unresolved-reference'"
-a = test + 3  # knot: ignore[possibly-unresolved-reference]
-```
-
-## Suppressed unused comment
-
-```py
-# error: [unused-ignore-comment]
-a = 10 / 2  # knot: ignore[division-by-zero]
-a = 10 / 2  # knot: ignore[division-by-zero, unused-ignore-comment]
-a = 10 / 2  # knot: ignore[unused-ignore-comment, division-by-zero]
-a = 10 / 2  # knot: ignore[unused-ignore-comment] # type: ignore
-a = 10 / 2  # type: ignore # knot: ignore[unused-ignore-comment]
-```
-
-## Unused ignore comment
-
-```py
-# error: [unused-ignore-comment] "Unused `knot: ignore` directive: 'unused-ignore-comment'"
-a = 10 / 0  # knot: ignore[division-by-zero, unused-ignore-comment]
-```
-
-## Multiple unused comments
-
-Today, Red Knot emits a diagnostic for every unused code. We might want to group the codes by
-comment at some point in the future.
-
-```py
-# error: [unused-ignore-comment] "Unused `knot: ignore` directive: 'division-by-zero'"
-# error: [unused-ignore-comment] "Unused `knot: ignore` directive: 'unresolved-reference'"
-a = 10 / 2  # knot: ignore[division-by-zero, unresolved-reference]
-
-# error: [unused-ignore-comment] "Unused `knot: ignore` directive: 'invalid-assignment'"
-# error: [unused-ignore-comment] "Unused `knot: ignore` directive: 'unresolved-reference'"
-a = 10 / 0  # knot: ignore[invalid-assignment, division-by-zero, unresolved-reference]
-```
-
-## Multiple suppressions
-
-```py
-# fmt: off
-def test(a: f"f-string type annotation", b: b"byte-string-type-annotation"): ...  # knot: ignore[fstring-type-annotation, byte-string-type-annotation]
-```
-
-## Can't suppress syntax errors
-
-<!-- blacken-docs:off -->
-
-```py
-# error: [invalid-syntax]
-# error: [unused-ignore-comment]
-def test(  # knot: ignore
-```
-
-<!-- blacken-docs:on -->
-
-## Can't suppress `revealed-type` diagnostics
-
-```py
-a = 10
-# revealed: Literal[10]
-# error: [unknown-rule] "Unknown rule `revealed-type`"
-reveal_type(a)  # knot: ignore[revealed-type]
-```
-
-## Extra whitespace in type ignore comments is allowed
-
-```py
-a = 10 / 0  # knot   :   ignore
-a = 10 / 0  # knot: ignore  [    division-by-zero   ]
-```
-
-## Whitespace is optional
-
-```py
-# fmt: off
-a = 10 / 0  #knot:ignore[division-by-zero]
-```
-
-## Trailing codes comma
-
-Trailing commas in the codes section are allowed:
-
-```py
-a = 10 / 0  # knot: ignore[division-by-zero,]
-```
-
-## Invalid characters in codes
-
-```py
-# error: [division-by-zero]
-# error: [invalid-ignore-comment] "Invalid `knot: ignore` comment: expected a alphanumeric character or `-` or `_` as code"
-a = 10 / 0  # knot: ignore[*-*]
-```
-
-## Trailing whitespace
-
-<!-- blacken-docs:off -->
-
-```py
-a = 10 / 0  # knot: ignore[division-by-zero]      
-            #                               ^^^^^^ trailing whitespace
-```
-
-<!-- blacken-docs:on -->
-
-## Missing comma
-
-A missing comma results in an invalid suppression comment. We may want to recover from this in the
-future.
-
-```py
-# error: [unresolved-reference]
-# error: [invalid-ignore-comment] "Invalid `knot: ignore` comment: expected a comma separating the rule codes"
-a = x / 0  # knot: ignore[division-by-zero unresolved-reference]
-```
-
-## Missing closing bracket
-
-```py
-# error: [unresolved-reference] "Name `x` used when not defined"
-# error: [invalid-ignore-comment] "Invalid `knot: ignore` comment: expected a comma separating the rule codes"
-a = x / 2  # knot: ignore[unresolved-reference
-```
-
-## Empty codes
-
-An empty codes array suppresses no-diagnostics and is always useless
-
-```py
-# error: [division-by-zero]
-# error: [unused-ignore-comment] "Unused `knot: ignore` without a code"
-a = 4 / 0  # knot: ignore[]
-```
-
-## File-level suppression comments
-
-File level suppression comments are currently intentionally unsupported because we've yet to decide
-if they should use a different syntax that also supports enabling rules or changing the rule's
-severity: `knot: possibly-undefined-reference=error`
-
-```py
-# error: [unused-ignore-comment]
-# knot: ignore[division-by-zero]
-
-a = 4 / 0  # error: [division-by-zero]
-```
-
-## Unknown rule
-
-```py
-# error: [unknown-rule] "Unknown rule `is-equal-14`"
-a = 10 + 4  # knot: ignore[is-equal-14]
-```

crates/red_knot_python_semantic/resources/mdtest/suppressions/no_type_check.md

@@ -1,118 +0,0 @@
-# `@no_type_check`
-
-> If a type checker supports the `no_type_check` decorator for functions, it should suppress all
-> type errors for the def statement and its body including any nested functions or classes. It
-> should also ignore all parameter and return type annotations and treat the function as if it were
-> unannotated. [source](https://typing.readthedocs.io/en/latest/spec/directives.html#no-type-check)
-
-## Error in the function body
-
-```py
-from typing import no_type_check
-
-@no_type_check
-def test() -> int:
-    return a + 5
-```
-
-## Error in nested function
-
-```py
-from typing import no_type_check
-
-@no_type_check
-def test() -> int:
-    def nested():
-        return a + 5
-```
-
-## Error in nested class
-
-```py
-from typing import no_type_check
-
-@no_type_check
-def test() -> int:
-    class Nested:
-        def inner(self):
-            return a + 5
-```
-
-## Error in preceding decorator
-
-Don't suppress diagnostics for decorators appearing before the `no_type_check` decorator.
-
-```py
-from typing import no_type_check
-
-@unknown_decorator  # error: [unresolved-reference]
-@no_type_check
-def test() -> int:
-    return a + 5
-```
-
-## Error in following decorator
-
-Unlike Pyright and mypy, suppress diagnostics appearing after the `no_type_check` decorator. We do
-this because it more closely matches Python's runtime semantics of decorators. For more details, see
-the discussion on the
-[PR adding `@no_type_check` support](https://github.com/astral-sh/ruff/pull/15122#discussion_r1896869411).
-
-```py
-from typing import no_type_check
-
-@no_type_check
-@unknown_decorator
-def test() -> int:
-    return a + 5
-```
-
-## Error in default value
-
-```py
-from typing import no_type_check
-
-@no_type_check
-def test(a: int = "test"):
-    return x + 5
-```
-
-## Error in return value position
-
-```py
-from typing import no_type_check
-
-@no_type_check
-def test() -> Undefined:
-    return x + 5
-```
-
-## `no_type_check` on classes isn't supported
-
-Red Knot does not support decorating classes with `no_type_check`. The behaviour of `no_type_check`
-when applied to classes is
-[not specified currently](https://typing.readthedocs.io/en/latest/spec/directives.html#no-type-check),
-and is not supported by Pyright or mypy.
-
-A future improvement might be to emit a diagnostic if a `no_type_check` annotation is applied to a
-class.
-
-```py
-from typing import no_type_check
-
-@no_type_check
-class Test:
-    def test(self):
-        return a + 5  # error: [unresolved-reference]
-```
-
-## `type: ignore` comments in `@no_type_check` blocks
-
-```py
-from typing import no_type_check
-
-@no_type_check
-def test():
-    # error: [unused-ignore-comment] "Unused `knot: ignore` directive: 'unresolved-reference'"
-    return x + 5  # knot: ignore[unresolved-reference]
-```

crates/red_knot_python_semantic/resources/mdtest/suppressions/type_ignore.md

@@ -1,162 +0,0 @@
-# Suppressing errors with `type: ignore`
-
-Type check errors can be suppressed by a `type: ignore` comment on the same line as the violation.
-
-## Simple `type: ignore`
-
-```py
-a = 4 + test  # type: ignore
-```
-
-## Multiline ranges
-
-A diagnostic with a multiline range can be suppressed by a comment on the same line as the
-diagnostic's start or end. This is the same behavior as Mypy's.
-
-```py
-# fmt: off
-y = (
-    4 / 0  # type: ignore
-)
-
-y = (
-    4 /  # type: ignore
-    0
-)
-
-y = (
-    4 /
-    0  # type: ignore
-)
-```
-
-Pyright diverges from this behavior and instead applies a suppression if its range intersects with
-the diagnostic range. This can be problematic for nested expressions because a suppression in a
-child expression now suppresses errors in the outer expression.
-
-For example, the `type: ignore` comment in this example suppresses the error of adding `2` to
-`"test"` and adding `"other"` to the result of the cast.
-
-```py path=nested.py
-# fmt: off
-from typing import cast
-
-y = (
-    cast(int, "test" +
-            # TODO: Remove the expected error after implementing `invalid-operator` for binary expressions
-            # error: [unused-ignore-comment]
-            2 # type: ignore
-    )
-    + "other"  # TODO: expected-error[invalid-operator]
-)
-```
-
-Mypy flags the second usage.
-
-## Before opening parenthesis
-
-A suppression that applies to all errors before the opening parenthesis.
-
-```py
-a: Test = (  # type: ignore
-  Test()  # error: [unresolved-reference]
-)  # fmt: skip
-```
-
-## Multiline string
-
-```py
-a: int = 4
-a = """
-  This is a multiline string and the suppression is at its end
-"""  # type: ignore
-```
-
-## Line continuations
-
-Suppressions after a line continuation apply to all previous lines.
-
-```py
-# fmt: off
-a = test \
-  + 2  # type: ignore
-
-a = test \
-  + a \
-  + 2  # type: ignore
-```
-
-## Codes
-
-Mypy supports `type: ignore[code]`. Red Knot doesn't understand mypy's rule names. Therefore, ignore
-the codes and suppress all errors.
-
-```py
-a = test  # type: ignore[name-defined]
-```
-
-## Nested comments
-
-```py
-# fmt: off
-a = test \
-  + 2  # fmt: skip # type: ignore
-
-a = test \
-  + 2  # type: ignore # fmt: skip
-```
-
-## Misspelled `type: ignore`
-
-```py
-# error: [unresolved-reference]
-# error: [invalid-ignore-comment]
-a = test + 2  # type: ignoree
-```
-
-## Invalid - ignore on opening parentheses
-
-`type: ignore` comments after an opening parentheses suppress any type errors inside the parentheses
-in Pyright. Neither Ruff, nor mypy support this and neither does Red Knot.
-
-```py
-# fmt: off
-# error: [unused-ignore-comment]
-a = (  # type: ignore
-    test + 4  # error: [unresolved-reference]
-)
-```
-
-## File level suppression
-
-```py
-# type: ignore
-
-a = 10 / 0
-b = a / 0
-```
-
-## File level suppression with leading shebang
-
-```py
-#!/usr/bin/env/python
-# type: ignore
-
-a = 10 / 0
-b = a / 0
-```
-
-## Invalid own-line suppression
-
-```py
-"""
-File level suppressions must come before any non-trivia token,
-including module docstrings. 
-"""
-
-# error: [unused-ignore-comment] "Unused blanket `type: ignore` directive"
-# type: ignore
-
-a = 10 / 0  # error: [division-by-zero]
-b = a / 0  # error: [division-by-zero]
-```

crates/red_knot_python_semantic/resources/mdtest/sys_platform.md

@@ -1,71 +0,0 @@
-# `sys.platform`
-
-## Default value
-
-When no target platform is specified, we fall back to the type of `sys.platform` declared in
-typeshed:
-
-```toml
-[environment]
-# No python-platform entry
-```
-
-```py
-import sys
-
-reveal_type(sys.platform)  # revealed: str
-```
-
-## Explicit selection of `all` platforms
-
-```toml
-[environment]
-python-platform = "all"
-```
-
-```py
-import sys
-
-reveal_type(sys.platform)  # revealed: str
-```
-
-## Explicit selection of a specific platform
-
-```toml
-[environment]
-python-platform = "linux"
-```
-
-```py
-import sys
-
-reveal_type(sys.platform)  # revealed: Literal["linux"]
-```
-
-## Testing for a specific platform
-
-### Exact comparison
-
-```toml
-[environment]
-python-platform = "freebsd8"
-```
-
-```py
-import sys
-
-reveal_type(sys.platform == "freebsd8")  # revealed: Literal[True]
-reveal_type(sys.platform == "linux")  # revealed: Literal[False]
-```
-
-### Substring comparison
-
-It is [recommended](https://docs.python.org/3/library/sys.html#sys.platform) to use
-`sys.platform.startswith(...)` for platform checks. This is not yet supported in type inference:
-
-```py
-import sys
-
-reveal_type(sys.platform.startswith("freebsd"))  # revealed: @Todo(instance attributes)
-reveal_type(sys.platform.startswith("linux"))  # revealed: @Todo(instance attributes)
-```

crates/red_knot_python_semantic/resources/mdtest/type_api.md

@@ -1,352 +0,0 @@
-# Type API (`knot_extensions`)
-
-This document describes the internal `knot_extensions` API for creating and manipulating types as
-well as testing various type system properties.
-
-## Type extensions
-
-The Python language itself allows us to perform a variety of operations on types. For example, we
-can build a union of types like `int | None`, or we can use type constructors such as `list[int]`
-and `type[int]` to create new types. But some type-level operations that we rely on in Red Knot,
-like intersections, cannot yet be expressed in Python. The `knot_extensions` module provides the
-`Intersection` and `Not` type constructors (special forms) which allow us to construct these types
-directly.
-
-### Negation
-
-```py
-from knot_extensions import Not, static_assert
-
-def negate(n1: Not[int], n2: Not[Not[int]], n3: Not[Not[Not[int]]]) -> None:
-    reveal_type(n1)  # revealed: ~int
-    reveal_type(n2)  # revealed: int
-    reveal_type(n3)  # revealed: ~int
-
-def static_truthiness(not_one: Not[Literal[1]]) -> None:
-    static_assert(not_one != 1)
-    static_assert(not (not_one == 1))
-
-# error: "Special form `knot_extensions.Not` expected exactly one type parameter"
-n: Not[int, str]
-```
-
-### Intersection
-
-```py
-from knot_extensions import Intersection, Not, is_subtype_of, static_assert
-from typing_extensions import Never
-
-class S: ...
-class T: ...
-
-def x(x1: Intersection[S, T], x2: Intersection[S, Not[T]]) -> None:
-    reveal_type(x1)  # revealed: S & T
-    reveal_type(x2)  # revealed: S & ~T
-
-def y(y1: Intersection[int, object], y2: Intersection[int, bool], y3: Intersection[int, Never]) -> None:
-    reveal_type(y1)  # revealed: int
-    reveal_type(y2)  # revealed: bool
-    reveal_type(y3)  # revealed: Never
-
-def z(z1: Intersection[int, Not[Literal[1]], Not[Literal[2]]]) -> None:
-    reveal_type(z1)  # revealed: int & ~Literal[1] & ~Literal[2]
-
-class A: ...
-class B: ...
-class C: ...
-
-type ABC = Intersection[A, B, C]
-
-static_assert(is_subtype_of(ABC, A))
-static_assert(is_subtype_of(ABC, B))
-static_assert(is_subtype_of(ABC, C))
-
-class D: ...
-
-static_assert(not is_subtype_of(ABC, D))
-```
-
-### Unknown type
-
-The `Unknown` type is a special type that we use to represent actually unknown types (no
-annotation), as opposed to `Any` which represents an explicitly unknown type.
-
-```py
-from knot_extensions import Unknown, static_assert, is_assignable_to, is_fully_static
-
-static_assert(is_assignable_to(Unknown, int))
-static_assert(is_assignable_to(int, Unknown))
-
-static_assert(not is_fully_static(Unknown))
-
-def explicit_unknown(x: Unknown, y: tuple[str, Unknown], z: Unknown = 1) -> None:
-    reveal_type(x)  # revealed: Unknown
-    reveal_type(y)  # revealed: tuple[str, Unknown]
-    reveal_type(z)  # revealed: Unknown | Literal[1]
-
-# Unknown can be subclassed, just like Any
-class C(Unknown): ...
-
-# revealed: tuple[Literal[C], Unknown, Literal[object]]
-reveal_type(C.__mro__)
-
-# error: "Special form `knot_extensions.Unknown` expected no type parameter"
-u: Unknown[str]
-```
-
-## Static assertions
-
-### Basics
-
-The `knot_extensions` module provides a `static_assert` function that can be used to enforce
-properties at type-check time. The function takes an arbitrary expression and raises a type error if
-the expression is not of statically known truthiness.
-
-```py
-from knot_extensions import static_assert
-from typing import TYPE_CHECKING
-import sys
-
-static_assert(True)
-static_assert(False)  # error: "Static assertion error: argument evaluates to `False`"
-
-static_assert(False or True)
-static_assert(True and True)
-static_assert(False or False)  # error: "Static assertion error: argument evaluates to `False`"
-static_assert(False and True)  # error: "Static assertion error: argument evaluates to `False`"
-
-static_assert(1 + 1 == 2)
-static_assert(1 + 1 == 3)  # error: "Static assertion error: argument evaluates to `False`"
-
-static_assert("a" in "abc")
-static_assert("d" in "abc")  # error: "Static assertion error: argument evaluates to `False`"
-
-n = None
-static_assert(n is None)
-
-static_assert(TYPE_CHECKING)
-
-static_assert(sys.version_info >= (3, 6))
-```
-
-### Narrowing constraints
-
-Static assertions can be used to enforce narrowing constraints:
-
-```py
-from knot_extensions import static_assert
-
-def f(x: int) -> None:
-    if x != 0:
-        static_assert(x != 0)
-    else:
-        # `int` can be subclassed, so we cannot assert that `x == 0` here:
-        # error: "Static assertion error: argument of type `bool` has an ambiguous static truthiness"
-        static_assert(x == 0)
-```
-
-### Truthy expressions
-
-See also: <https://docs.python.org/3/library/stdtypes.html#truth-value-testing>
-
-```py
-from knot_extensions import static_assert
-
-static_assert(True)
-static_assert(False)  # error: "Static assertion error: argument evaluates to `False`"
-
-static_assert(None)  # error: "Static assertion error: argument of type `None` is statically known to be falsy"
-
-static_assert(1)
-static_assert(0)  # error: "Static assertion error: argument of type `Literal[0]` is statically known to be falsy"
-
-static_assert((0,))
-static_assert(())  # error: "Static assertion error: argument of type `tuple[()]` is statically known to be falsy"
-
-static_assert("a")
-static_assert("")  # error: "Static assertion error: argument of type `Literal[""]` is statically known to be falsy"
-
-static_assert(b"a")
-static_assert(b"")  # error: "Static assertion error: argument of type `Literal[b""]` is statically known to be falsy"
-```
-
-### Error messages
-
-We provide various tailored error messages for wrong argument types to `static_assert`:
-
-```py
-from knot_extensions import static_assert
-
-static_assert(2 * 3 == 6)
-
-# error: "Static assertion error: argument evaluates to `False`"
-static_assert(2 * 3 == 7)
-
-# error: "Static assertion error: argument of type `bool` has an ambiguous static truthiness"
-static_assert(int(2.0 * 3.0) == 6)
-
-class InvalidBoolDunder:
-    def __bool__(self) -> int:
-        return 1
-
-# error: "Static assertion error: argument of type `InvalidBoolDunder` has an ambiguous static truthiness"
-static_assert(InvalidBoolDunder())
-```
-
-### Custom error messages
-
-Alternatively, users can provide custom error messages:
-
-```py
-from knot_extensions import static_assert
-
-# error: "Static assertion error: I really want this to be true"
-static_assert(1 + 1 == 3, "I really want this to be true")
-
-error_message = "A custom message "
-error_message += "constructed from multiple string literals"
-# error: "Static assertion error: A custom message constructed from multiple string literals"
-static_assert(False, error_message)
-
-# There are limitations to what we can still infer as a string literal. In those cases,
-# we simply fall back to the default message.
-shouted_message = "A custom message".upper()
-# error: "Static assertion error: argument evaluates to `False`"
-static_assert(False, shouted_message)
-```
-
-## Type predicates
-
-The `knot_extensions` module also provides predicates to test various properties of types. These are
-implemented as functions that return `Literal[True]` or `Literal[False]` depending on the result of
-the test.
-
-### Equivalence
-
-```py
-from knot_extensions import is_equivalent_to, static_assert
-from typing_extensions import Never, Union
-
-static_assert(is_equivalent_to(type, type[object]))
-static_assert(is_equivalent_to(tuple[int, Never], Never))
-static_assert(is_equivalent_to(int | str, Union[int, str]))
-
-static_assert(not is_equivalent_to(int, str))
-static_assert(not is_equivalent_to(int | str, int | str | bytes))
-```
-
-### Subtyping
-
-```py
-from knot_extensions import is_subtype_of, static_assert
-
-static_assert(is_subtype_of(bool, int))
-static_assert(not is_subtype_of(str, int))
-
-static_assert(is_subtype_of(bool, int | str))
-static_assert(is_subtype_of(str, int | str))
-static_assert(not is_subtype_of(bytes, int | str))
-
-class Base: ...
-class Derived(Base): ...
-class Unrelated: ...
-
-static_assert(is_subtype_of(Derived, Base))
-static_assert(not is_subtype_of(Base, Derived))
-static_assert(is_subtype_of(Base, Base))
-
-static_assert(not is_subtype_of(Unrelated, Base))
-static_assert(not is_subtype_of(Base, Unrelated))
-```
-
-### Assignability
-
-```py
-from knot_extensions import is_assignable_to, static_assert
-from typing import Any
-
-static_assert(is_assignable_to(int, Any))
-static_assert(is_assignable_to(Any, str))
-static_assert(not is_assignable_to(int, str))
-```
-
-### Disjointness
-
-```py
-from knot_extensions import is_disjoint_from, static_assert
-
-static_assert(is_disjoint_from(None, int))
-static_assert(not is_disjoint_from(Literal[2] | str, int))
-```
-
-### Fully static types
-
-```py
-from knot_extensions import is_fully_static, static_assert
-from typing import Any
-
-static_assert(is_fully_static(int | str))
-static_assert(is_fully_static(type[int]))
-
-static_assert(not is_fully_static(int | Any))
-static_assert(not is_fully_static(type[Any]))
-```
-
-### Singleton types
-
-```py
-from knot_extensions import is_singleton, static_assert
-
-static_assert(is_singleton(None))
-static_assert(is_singleton(Literal[True]))
-
-static_assert(not is_singleton(int))
-static_assert(not is_singleton(Literal["a"]))
-```
-
-### Single-valued types
-
-```py
-from knot_extensions import is_single_valued, static_assert
-
-static_assert(is_single_valued(None))
-static_assert(is_single_valued(Literal[True]))
-static_assert(is_single_valued(Literal["a"]))
-
-static_assert(not is_single_valued(int))
-static_assert(not is_single_valued(Literal["a"] | Literal["b"]))
-```
-
-## `TypeOf`
-
-We use `TypeOf` to get the inferred type of an expression. This is useful when we want to refer to
-it in a type expression. For example, if we want to make sure that the class literal type `str` is a
-subtype of `type[str]`, we can not use `is_subtype_of(str, type[str])`, as that would test if the
-type `str` itself is a subtype of `type[str]`. Instead, we can use `TypeOf[str]` to get the type of
-the expression `str`:
-
-```py
-from knot_extensions import TypeOf, is_subtype_of, static_assert
-
-# This is incorrect and therefore fails with ...
-# error: "Static assertion error: argument evaluates to `False`"
-static_assert(is_subtype_of(str, type[str]))
-
-# Correct, returns True:
-static_assert(is_subtype_of(TypeOf[str], type[str]))
-
-class Base: ...
-class Derived(Base): ...
-
-# `TypeOf` can be used in annotations:
-def type_of_annotation() -> None:
-    t1: TypeOf[Base] = Base
-    t2: TypeOf[Base] = Derived  # error: [invalid-assignment]
-
-    # Note how this is different from `type[…]` which includes subclasses:
-    s1: type[Base] = Base
-    s2: type[Base] = Derived  # no error here
-
-# error: "Special form `knot_extensions.TypeOf` expected exactly one type parameter"
-t: TypeOf[int, str, bytes]
-```

crates/red_knot_python_semantic/resources/mdtest/type_of/basic.md

@@ -61,8 +61,10 @@ class B: ...
 ```py path=a/test.py
 import a.b
 
+# TODO: no diagnostic
+# error: [unresolved-attribute]
 def f(c: type[a.b.C]):
-    reveal_type(c)  # revealed: type[C]
+    reveal_type(c)  # revealed: @Todo(unsupported type[X] special form)
 ```
 
 ```py path=a/__init__.py
@@ -142,25 +144,3 @@ class Foo(type[int]): ...
 # TODO: should be `tuple[Literal[Foo], Literal[type], Literal[object]]
 reveal_type(Foo.__mro__)  # revealed: tuple[Literal[Foo], Unknown, Literal[object]]
 ```
-
-## `@final` classes
-
-`type[]` types are eagerly converted to class-literal types if a class decorated with `@final` is
-used as the type argument. This applies to standard-library classes and user-defined classes:
-
-```toml
-[environment]
-python-version = "3.10"
-```
-
-```py
-from types import EllipsisType
-from typing import final
-
-@final
-class Foo: ...
-
-def _(x: type[Foo], y: type[EllipsisType]):
-    reveal_type(x)  # revealed: Literal[Foo]
-    reveal_type(y)  # revealed: Literal[EllipsisType]
-```

crates/red_knot_python_semantic/resources/mdtest/type_of/dynamic.md

@@ -47,8 +47,9 @@ x: type = A()  # error: [invalid-assignment]
 
 ```py
 def f(x: type[object]):
-    reveal_type(x)  # revealed: type
-    reveal_type(x.__repr__)  # revealed: @Todo(instance attributes)
+    reveal_type(x)  # revealed: type[object]
+    # TODO: bound method types
+    reveal_type(x.__repr__)  # revealed: Literal[__repr__]
 
 class A: ...
 

crates/red_knot_python_semantic/resources/mdtest/type_properties/is_assignable_to.md

@@ -1,352 +0,0 @@
-# Assignable-to relation
-
-The `is_assignable_to(S, T)` relation below checks if type `S` is assignable to type `T` (target).
-This allows us to check if a type `S` can be used in a context where a type `T` is expected
-(function arguments, variable assignments). See the [typing documentation] for a precise definition
-of this concept.
-
-## Basic types
-
-### Fully static
-
-Fully static types participate in subtyping. If a type `S` is a subtype of `T`, `S` will also be
-assignable to `T`. Two equivalent types are subtypes of each other:
-
-```py
-from knot_extensions import static_assert, is_assignable_to
-
-class Parent: ...
-class Child1(Parent): ...
-class Child2(Parent): ...
-class Grandchild(Child1, Child2): ...
-class Unrelated: ...
-
-static_assert(is_assignable_to(int, int))
-static_assert(is_assignable_to(Parent, Parent))
-static_assert(is_assignable_to(Child1, Parent))
-static_assert(is_assignable_to(Grandchild, Parent))
-static_assert(is_assignable_to(Unrelated, Unrelated))
-
-static_assert(not is_assignable_to(str, int))
-static_assert(not is_assignable_to(object, int))
-static_assert(not is_assignable_to(Parent, Child1))
-static_assert(not is_assignable_to(Unrelated, Parent))
-static_assert(not is_assignable_to(Child1, Child2))
-```
-
-### Gradual types
-
-Gradual types do not participate in subtyping, but can still be assignable to other types (and
-static types can be assignable to gradual types):
-
-```py
-from knot_extensions import static_assert, is_assignable_to, Unknown
-from typing import Any
-
-static_assert(is_assignable_to(Unknown, Literal[1]))
-static_assert(is_assignable_to(Any, Literal[1]))
-static_assert(is_assignable_to(Literal[1], Unknown))
-static_assert(is_assignable_to(Literal[1], Any))
-```
-
-## Literal types
-
-### Boolean literals
-
-`Literal[True]` and `Literal[False]` are both subtypes of (and therefore assignable to) `bool`,
-which is in turn a subtype of `int`:
-
-```py
-from knot_extensions import static_assert, is_assignable_to
-from typing import Literal
-
-static_assert(is_assignable_to(Literal[True], Literal[True]))
-static_assert(is_assignable_to(Literal[True], bool))
-static_assert(is_assignable_to(Literal[True], int))
-
-static_assert(not is_assignable_to(Literal[True], Literal[False]))
-static_assert(not is_assignable_to(bool, Literal[True]))
-```
-
-### Integer literals
-
-```py
-from knot_extensions import static_assert, is_assignable_to
-from typing import Literal
-
-static_assert(is_assignable_to(Literal[1], Literal[1]))
-static_assert(is_assignable_to(Literal[1], int))
-
-static_assert(not is_assignable_to(Literal[1], Literal[2]))
-static_assert(not is_assignable_to(int, Literal[1]))
-static_assert(not is_assignable_to(Literal[1], str))
-```
-
-### String literals and `LiteralString`
-
-All string-literal types are subtypes of (and therefore assignable to) `LiteralString`, which is in
-turn a subtype of `str`:
-
-```py
-from knot_extensions import static_assert, is_assignable_to
-from typing_extensions import Literal, LiteralString
-
-static_assert(is_assignable_to(Literal["foo"], Literal["foo"]))
-static_assert(is_assignable_to(Literal["foo"], LiteralString))
-static_assert(is_assignable_to(Literal["foo"], str))
-
-static_assert(is_assignable_to(LiteralString, str))
-
-static_assert(not is_assignable_to(Literal["foo"], Literal["bar"]))
-static_assert(not is_assignable_to(str, Literal["foo"]))
-static_assert(not is_assignable_to(str, LiteralString))
-```
-
-### Byte literals
-
-```py
-from knot_extensions import static_assert, is_assignable_to
-from typing_extensions import Literal, LiteralString
-
-static_assert(is_assignable_to(Literal[b"foo"], bytes))
-static_assert(is_assignable_to(Literal[b"foo"], Literal[b"foo"]))
-
-static_assert(not is_assignable_to(Literal[b"foo"], str))
-static_assert(not is_assignable_to(Literal[b"foo"], LiteralString))
-static_assert(not is_assignable_to(Literal[b"foo"], Literal[b"bar"]))
-static_assert(not is_assignable_to(Literal[b"foo"], Literal["foo"]))
-static_assert(not is_assignable_to(Literal["foo"], Literal[b"foo"]))
-```
-
-## `type[…]` and class literals
-
-In the following tests, `TypeOf[str]` is a singleton type with a single inhabitant, the class `str`.
-This contrasts with `type[str]`, which represents "all possible subclasses of `str`".
-
-Both `TypeOf[str]` and `type[str]` are subtypes of `type` and `type[object]`, which both represent
-"all possible instances of `type`"; therefore both `type[str]` and `TypeOf[str]` are assignable to
-`type`. `type[Any]`, on the other hand, represents a type of unknown size or inhabitants, but which
-is known to be no larger than the set of possible objects represented by `type`.
-
-```py
-from knot_extensions import static_assert, is_assignable_to, Unknown, TypeOf
-from typing import Any
-
-static_assert(is_assignable_to(type, type))
-static_assert(is_assignable_to(type[object], type[object]))
-
-static_assert(is_assignable_to(type, type[object]))
-static_assert(is_assignable_to(type[object], type))
-
-static_assert(is_assignable_to(type[str], type[object]))
-static_assert(is_assignable_to(TypeOf[str], type[object]))
-static_assert(is_assignable_to(type[str], type))
-static_assert(is_assignable_to(TypeOf[str], type))
-
-static_assert(is_assignable_to(type[str], type[str]))
-static_assert(is_assignable_to(TypeOf[str], type[str]))
-
-static_assert(not is_assignable_to(TypeOf[int], type[str]))
-static_assert(not is_assignable_to(type, type[str]))
-static_assert(not is_assignable_to(type[object], type[str]))
-
-static_assert(is_assignable_to(type[Any], type[Any]))
-static_assert(is_assignable_to(type[Any], type[object]))
-static_assert(is_assignable_to(type[object], type[Any]))
-static_assert(is_assignable_to(type, type[Any]))
-static_assert(is_assignable_to(type[Any], type[str]))
-static_assert(is_assignable_to(type[str], type[Any]))
-static_assert(is_assignable_to(TypeOf[str], type[Any]))
-
-static_assert(is_assignable_to(type[Unknown], type[Unknown]))
-static_assert(is_assignable_to(type[Unknown], type[object]))
-static_assert(is_assignable_to(type[object], type[Unknown]))
-static_assert(is_assignable_to(type, type[Unknown]))
-static_assert(is_assignable_to(type[Unknown], type[str]))
-static_assert(is_assignable_to(type[str], type[Unknown]))
-static_assert(is_assignable_to(TypeOf[str], type[Unknown]))
-
-static_assert(is_assignable_to(type[Unknown], type[Any]))
-static_assert(is_assignable_to(type[Any], type[Unknown]))
-
-static_assert(not is_assignable_to(object, type[Any]))
-static_assert(not is_assignable_to(str, type[Any]))
-
-class Meta(type): ...
-
-static_assert(is_assignable_to(type[Any], Meta))
-static_assert(is_assignable_to(type[Unknown], Meta))
-static_assert(is_assignable_to(Meta, type[Any]))
-static_assert(is_assignable_to(Meta, type[Unknown]))
-```
-
-## Tuple types
-
-```py
-from knot_extensions import static_assert, is_assignable_to
-from typing import Literal, Any
-
-static_assert(is_assignable_to(tuple[()], tuple[()]))
-static_assert(is_assignable_to(tuple[int], tuple[int]))
-static_assert(is_assignable_to(tuple[int], tuple[Any]))
-static_assert(is_assignable_to(tuple[Any], tuple[int]))
-static_assert(is_assignable_to(tuple[int, str], tuple[int, str]))
-static_assert(is_assignable_to(tuple[Literal[1], Literal[2]], tuple[int, int]))
-static_assert(is_assignable_to(tuple[Any, Literal[2]], tuple[int, int]))
-static_assert(is_assignable_to(tuple[Literal[1], Any], tuple[int, int]))
-
-static_assert(not is_assignable_to(tuple[()], tuple[int]))
-static_assert(not is_assignable_to(tuple[int], tuple[str]))
-static_assert(not is_assignable_to(tuple[int], tuple[int, str]))
-static_assert(not is_assignable_to(tuple[int, str], tuple[int]))
-static_assert(not is_assignable_to(tuple[int, int], tuple[Literal[1], int]))
-static_assert(not is_assignable_to(tuple[Any, Literal[2]], tuple[int, str]))
-```
-
-## Union types
-
-```py
-from knot_extensions import static_assert, is_assignable_to, Unknown
-from typing import Literal, Any
-
-static_assert(is_assignable_to(int, int | str))
-static_assert(is_assignable_to(str, int | str))
-static_assert(is_assignable_to(int | str, int | str))
-static_assert(is_assignable_to(str | int, int | str))
-static_assert(is_assignable_to(Literal[1], int | str))
-static_assert(is_assignable_to(Literal[1], Unknown | str))
-static_assert(is_assignable_to(Literal[1] | Literal[2], Literal[1] | Literal[2]))
-static_assert(is_assignable_to(Literal[1] | Literal[2], int))
-static_assert(is_assignable_to(Literal[1] | None, int | None))
-static_assert(is_assignable_to(Any, int | str))
-static_assert(is_assignable_to(Any | int, int))
-static_assert(is_assignable_to(str, int | Any))
-
-static_assert(not is_assignable_to(int | None, int))
-static_assert(not is_assignable_to(int | None, str | None))
-static_assert(not is_assignable_to(Literal[1] | None, int))
-static_assert(not is_assignable_to(Literal[1] | None, str | None))
-static_assert(not is_assignable_to(Any | int | str, int))
-```
-
-## Intersection types
-
-```py
-from knot_extensions import static_assert, is_assignable_to, Intersection, Not
-from typing_extensions import Any, Literal
-
-class Parent: ...
-class Child1(Parent): ...
-class Child2(Parent): ...
-class Grandchild(Child1, Child2): ...
-class Unrelated: ...
-
-static_assert(is_assignable_to(Intersection[Child1, Child2], Child1))
-static_assert(is_assignable_to(Intersection[Child1, Child2], Child2))
-static_assert(is_assignable_to(Intersection[Child1, Child2], Parent))
-static_assert(is_assignable_to(Intersection[Child1, Parent], Parent))
-
-static_assert(is_assignable_to(Intersection[Parent, Unrelated], Parent))
-static_assert(is_assignable_to(Intersection[Child1, Unrelated], Child1))
-
-static_assert(is_assignable_to(Intersection[Child1, Not[Child2]], Child1))
-static_assert(is_assignable_to(Intersection[Child1, Not[Child2]], Parent))
-static_assert(is_assignable_to(Intersection[Child1, Not[Grandchild]], Parent))
-
-static_assert(is_assignable_to(Intersection[Child1, Child2], Intersection[Child1, Child2]))
-static_assert(is_assignable_to(Intersection[Child1, Child2], Intersection[Child2, Child1]))
-static_assert(is_assignable_to(Grandchild, Intersection[Child1, Child2]))
-
-static_assert(not is_assignable_to(Parent, Intersection[Parent, Unrelated]))
-static_assert(not is_assignable_to(int, Intersection[int, Not[Literal[1]]]))
-static_assert(not is_assignable_to(int, Not[int]))
-static_assert(not is_assignable_to(int, Not[Literal[1]]))
-
-static_assert(not is_assignable_to(Intersection[Any, Parent], Unrelated))
-
-# TODO: The following assertions should not fail (see https://github.com/astral-sh/ruff/issues/14899)
-# error: [static-assert-error]
-static_assert(is_assignable_to(Intersection[Any, int], int))
-
-# error: [static-assert-error]
-static_assert(is_assignable_to(Intersection[Unrelated, Any], Intersection[Unrelated, Any]))
-# error: [static-assert-error]
-static_assert(is_assignable_to(Intersection[Unrelated, Any], Intersection[Unrelated, Not[Any]]))
-# error: [static-assert-error]
-static_assert(is_assignable_to(Intersection[Unrelated, Any], Not[tuple[Unrelated, Any]]))
-```
-
-## General properties
-
-See also: our property tests in `property_tests.rs`.
-
-### Everything is assignable to `object`
-
-`object` is Python's top type; the set of all possible objects at runtime:
-
-```py
-from knot_extensions import static_assert, is_assignable_to, Unknown
-from typing import Literal, Any
-
-static_assert(is_assignable_to(str, object))
-static_assert(is_assignable_to(Literal[1], object))
-static_assert(is_assignable_to(object, object))
-static_assert(is_assignable_to(type, object))
-static_assert(is_assignable_to(Any, object))
-static_assert(is_assignable_to(Unknown, object))
-static_assert(is_assignable_to(type[object], object))
-static_assert(is_assignable_to(type[str], object))
-static_assert(is_assignable_to(type[Any], object))
-```
-
-### Every type is assignable to `Any` / `Unknown`
-
-`Any` and `Unknown` are gradual types. They could materialize to any given type at runtime, and so
-any type is assignable to them:
-
-```py
-from knot_extensions import static_assert, is_assignable_to, Unknown
-from typing import Literal, Any
-
-static_assert(is_assignable_to(str, Any))
-static_assert(is_assignable_to(Literal[1], Any))
-static_assert(is_assignable_to(object, Any))
-static_assert(is_assignable_to(type, Any))
-static_assert(is_assignable_to(Any, Any))
-static_assert(is_assignable_to(Unknown, Any))
-static_assert(is_assignable_to(type[object], Any))
-static_assert(is_assignable_to(type[str], Any))
-static_assert(is_assignable_to(type[Any], Any))
-
-static_assert(is_assignable_to(str, Unknown))
-static_assert(is_assignable_to(Literal[1], Unknown))
-static_assert(is_assignable_to(object, Unknown))
-static_assert(is_assignable_to(type, Unknown))
-static_assert(is_assignable_to(Any, Unknown))
-static_assert(is_assignable_to(Unknown, Unknown))
-static_assert(is_assignable_to(type[object], Unknown))
-static_assert(is_assignable_to(type[str], Unknown))
-static_assert(is_assignable_to(type[Any], Unknown))
-```
-
-### `Never` is assignable to every type
-
-`Never` is Python's bottom type: the empty set, a type with no inhabitants. It is therefore
-assignable to any arbitrary type.
-
-```py
-from knot_extensions import static_assert, is_assignable_to, Unknown
-from typing_extensions import Never, Any
-
-static_assert(is_assignable_to(Never, str))
-static_assert(is_assignable_to(Never, Literal[1]))
-static_assert(is_assignable_to(Never, object))
-static_assert(is_assignable_to(Never, type))
-static_assert(is_assignable_to(Never, Any))
-static_assert(is_assignable_to(Never, Unknown))
-static_assert(is_assignable_to(Never, type[object]))
-static_assert(is_assignable_to(Never, type[str]))
-static_assert(is_assignable_to(Never, type[Any]))
-```
-
-[typing documentation]: https://typing.readthedocs.io/en/latest/spec/concepts.html#the-assignable-to-or-consistent-subtyping-relation

crates/red_knot_python_semantic/resources/mdtest/type_properties/tuples_containing_never.md

@@ -1,33 +0,0 @@
-# Tuples containing `Never`
-
-A heterogeneous `tuple[…]` type that contains `Never` as a type argument simplifies to `Never`. One
-way to think about this is the following: in order to construct a tuple, you need to have an object
-of every element type. But since there is no object of type `Never`, you cannot construct the tuple.
-Such a tuple type is therefore uninhabited and equivalent to `Never`.
-
-In the language of algebraic data types, a tuple type is a product type and `Never` acts like the
-zero element in multiplication, similar to how a Cartesian product with the empty set is the empty
-set.
-
-```py
-from knot_extensions import static_assert, is_equivalent_to
-from typing_extensions import Never, NoReturn
-
-static_assert(is_equivalent_to(Never, tuple[Never]))
-static_assert(is_equivalent_to(Never, tuple[Never, int]))
-static_assert(is_equivalent_to(Never, tuple[int, Never]))
-static_assert(is_equivalent_to(Never, tuple[int, Never, str]))
-static_assert(is_equivalent_to(Never, tuple[int, tuple[str, Never]]))
-static_assert(is_equivalent_to(Never, tuple[tuple[str, Never], int]))
-
-# The empty tuple is *not* equivalent to Never!
-static_assert(not is_equivalent_to(Never, tuple[()]))
-
-# NoReturn is just a different spelling of Never, so the same is true for NoReturn
-static_assert(is_equivalent_to(NoReturn, tuple[NoReturn]))
-static_assert(is_equivalent_to(NoReturn, tuple[NoReturn, int]))
-static_assert(is_equivalent_to(NoReturn, tuple[int, NoReturn]))
-static_assert(is_equivalent_to(NoReturn, tuple[int, NoReturn, str]))
-static_assert(is_equivalent_to(NoReturn, tuple[int, tuple[str, NoReturn]]))
-static_assert(is_equivalent_to(NoReturn, tuple[tuple[str, NoReturn], int]))
-```

crates/red_knot_python_semantic/resources/mdtest/unary/custom.md

@@ -1,169 +0,0 @@
-# Custom unary operations
-
-## Class instances
-
-```py
-class Yes:
-    def __pos__(self) -> bool:
-        return False
-
-    def __neg__(self) -> str:
-        return "negative"
-
-    def __invert__(self) -> int:
-        return 17
-
-class Sub(Yes): ...
-class No: ...
-
-reveal_type(+Yes())  # revealed: bool
-reveal_type(-Yes())  # revealed: str
-reveal_type(~Yes())  # revealed: int
-
-reveal_type(+Sub())  # revealed: bool
-reveal_type(-Sub())  # revealed: str
-reveal_type(~Sub())  # revealed: int
-
-# error: [unsupported-operator] "Unary operator `+` is unsupported for type `No`"
-reveal_type(+No())  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `-` is unsupported for type `No`"
-reveal_type(-No())  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `~` is unsupported for type `No`"
-reveal_type(~No())  # revealed: Unknown
-```
-
-## Classes
-
-Dunder methods defined in a class are available to instances of that class, but not to the class
-itself. (For these operators to work on the class itself, they would have to be defined on the
-class's type, i.e. `type`.)
-
-```py
-class Yes:
-    def __pos__(self) -> bool:
-        return False
-
-    def __neg__(self) -> str:
-        return "negative"
-
-    def __invert__(self) -> int:
-        return 17
-
-class Sub(Yes): ...
-class No: ...
-
-# error: [unsupported-operator] "Unary operator `+` is unsupported for type `Literal[Yes]`"
-reveal_type(+Yes)  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `-` is unsupported for type `Literal[Yes]`"
-reveal_type(-Yes)  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `~` is unsupported for type `Literal[Yes]`"
-reveal_type(~Yes)  # revealed: Unknown
-
-# error: [unsupported-operator] "Unary operator `+` is unsupported for type `Literal[Sub]`"
-reveal_type(+Sub)  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `-` is unsupported for type `Literal[Sub]`"
-reveal_type(-Sub)  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `~` is unsupported for type `Literal[Sub]`"
-reveal_type(~Sub)  # revealed: Unknown
-
-# error: [unsupported-operator] "Unary operator `+` is unsupported for type `Literal[No]`"
-reveal_type(+No)  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `-` is unsupported for type `Literal[No]`"
-reveal_type(-No)  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `~` is unsupported for type `Literal[No]`"
-reveal_type(~No)  # revealed: Unknown
-```
-
-## Function literals
-
-```py
-def f():
-    pass
-
-# error: [unsupported-operator] "Unary operator `+` is unsupported for type `Literal[f]`"
-reveal_type(+f)  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `-` is unsupported for type `Literal[f]`"
-reveal_type(-f)  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `~` is unsupported for type `Literal[f]`"
-reveal_type(~f)  # revealed: Unknown
-```
-
-## Subclass
-
-```py
-class Yes:
-    def __pos__(self) -> bool:
-        return False
-
-    def __neg__(self) -> str:
-        return "negative"
-
-    def __invert__(self) -> int:
-        return 17
-
-class Sub(Yes): ...
-class No: ...
-
-def yes() -> type[Yes]:
-    return Yes
-
-def sub() -> type[Sub]:
-    return Sub
-
-def no() -> type[No]:
-    return No
-
-# error: [unsupported-operator] "Unary operator `+` is unsupported for type `type[Yes]`"
-reveal_type(+yes())  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `-` is unsupported for type `type[Yes]`"
-reveal_type(-yes())  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `~` is unsupported for type `type[Yes]`"
-reveal_type(~yes())  # revealed: Unknown
-
-# error: [unsupported-operator] "Unary operator `+` is unsupported for type `type[Sub]`"
-reveal_type(+sub())  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `-` is unsupported for type `type[Sub]`"
-reveal_type(-sub())  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `~` is unsupported for type `type[Sub]`"
-reveal_type(~sub())  # revealed: Unknown
-
-# error: [unsupported-operator] "Unary operator `+` is unsupported for type `type[No]`"
-reveal_type(+no())  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `-` is unsupported for type `type[No]`"
-reveal_type(-no())  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `~` is unsupported for type `type[No]`"
-reveal_type(~no())  # revealed: Unknown
-```
-
-## Metaclass
-
-```py
-class Meta(type):
-    def __pos__(self) -> bool:
-        return False
-
-    def __neg__(self) -> str:
-        return "negative"
-
-    def __invert__(self) -> int:
-        return 17
-
-class Yes(metaclass=Meta): ...
-class Sub(Yes): ...
-class No: ...
-
-reveal_type(+Yes)  # revealed: bool
-reveal_type(-Yes)  # revealed: str
-reveal_type(~Yes)  # revealed: int
-
-reveal_type(+Sub)  # revealed: bool
-reveal_type(-Sub)  # revealed: str
-reveal_type(~Sub)  # revealed: int
-
-# error: [unsupported-operator] "Unary operator `+` is unsupported for type `Literal[No]`"
-reveal_type(+No)  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `-` is unsupported for type `Literal[No]`"
-reveal_type(-No)  # revealed: Unknown
-# error: [unsupported-operator] "Unary operator `~` is unsupported for type `Literal[No]`"
-reveal_type(~No)  # revealed: Unknown
-```

crates/red_knot_python_semantic/resources/mdtest/union_types.md

@@ -1,143 +0,0 @@
-# Union types
-
-This test suite covers certain basic properties and simplification strategies for union types.
-
-## Basic unions
-
-```py
-from typing import Literal
-
-def _(u1: int | str, u2: Literal[0] | Literal[1]) -> None:
-    reveal_type(u1)  # revealed: int | str
-    reveal_type(u2)  # revealed: Literal[0, 1]
-```
-
-## Duplicate elements are collapsed
-
-```py
-def _(u1: int | int | str, u2: int | str | int) -> None:
-    reveal_type(u1)  # revealed: int | str
-    reveal_type(u2)  # revealed: int | str
-```
-
-## `Never` is removed
-
-`Never` is an empty set, a type with no inhabitants. Its presence in a union is always redundant,
-and so we eagerly simplify it away. `NoReturn` is equivalent to `Never`.
-
-```py
-from typing_extensions import Never, NoReturn
-
-def never(u1: int | Never, u2: int | Never | str) -> None:
-    reveal_type(u1)  # revealed: int
-    reveal_type(u2)  # revealed:  int | str
-
-def noreturn(u1: int | NoReturn, u2: int | NoReturn | str) -> None:
-    reveal_type(u1)  # revealed: int
-    reveal_type(u2)  # revealed:  int | str
-```
-
-## Flattening of nested unions
-
-```py
-from typing import Literal
-
-def _(
-    u1: (int | str) | bytes,
-    u2: int | (str | bytes),
-    u3: int | (str | (bytes | complex)),
-) -> None:
-    reveal_type(u1)  # revealed: int | str | bytes
-    reveal_type(u2)  # revealed: int | str | bytes
-    reveal_type(u3)  # revealed: int | str | bytes | complex
-```
-
-## Simplification using subtyping
-
-The type `S | T` can be simplified to `T` if `S` is a subtype of `T`:
-
-```py
-from typing_extensions import Literal, LiteralString
-
-def _(
-    u1: str | LiteralString, u2: LiteralString | str, u3: Literal["a"] | str | LiteralString, u4: str | bytes | LiteralString
-) -> None:
-    reveal_type(u1)  # revealed: str
-    reveal_type(u2)  # revealed: str
-    reveal_type(u3)  # revealed: str
-    reveal_type(u4)  # revealed: str | bytes
-```
-
-## Boolean literals
-
-The union `Literal[True] | Literal[False]` is exactly equivalent to `bool`:
-
-```py
-from typing import Literal
-
-def _(
-    u1: Literal[True, False],
-    u2: bool | Literal[True],
-    u3: Literal[True] | bool,
-    u4: Literal[True] | Literal[True, 17],
-    u5: Literal[True, False, True, 17],
-) -> None:
-    reveal_type(u1)  # revealed: bool
-    reveal_type(u2)  # revealed: bool
-    reveal_type(u3)  # revealed: bool
-    reveal_type(u4)  # revealed: Literal[True, 17]
-    reveal_type(u5)  # revealed: bool | Literal[17]
-```
-
-## Do not erase `Unknown`
-
-```py
-from knot_extensions import Unknown
-
-def _(u1: Unknown | str, u2: str | Unknown) -> None:
-    reveal_type(u1)  # revealed: Unknown | str
-    reveal_type(u2)  # revealed: str | Unknown
-```
-
-## Collapse multiple `Unknown`s
-
-Since `Unknown` is a gradual type, it is not a subtype of anything, but multiple `Unknown`s in a
-union are still redundant:
-
-```py
-from knot_extensions import Unknown
-
-def _(u1: Unknown | Unknown | str, u2: Unknown | str | Unknown, u3: str | Unknown | Unknown) -> None:
-    reveal_type(u1)  # revealed: Unknown | str
-    reveal_type(u2)  # revealed: Unknown | str
-    reveal_type(u3)  # revealed: str | Unknown
-```
-
-## Subsume multiple elements
-
-Simplifications still apply when `Unknown` is present.
-
-```py
-from knot_extensions import Unknown
-
-def _(u1: str | Unknown | int | object):
-    reveal_type(u1)  # revealed: Unknown | object
-```
-
-## Union of intersections
-
-We can simplify unions of intersections:
-
-```py
-from knot_extensions import Intersection, Not
-
-class P: ...
-class Q: ...
-
-def _(
-    i1: Intersection[P, Q] | Intersection[P, Q],
-    i2: Intersection[P, Q] | Intersection[Q, P],
-) -> None:
-    reveal_type(i1)  # revealed: P & Q
-    reveal_type(i2)  # revealed: P & Q
-```

crates/red_knot_python_semantic/resources/mdtest/unpacking.md

@@ -61,7 +61,7 @@ reveal_type(c)  # revealed: Literal[4]
 ### Uneven unpacking (1)
 
 ```py
-# error: [invalid-assignment] "Not enough values to unpack (expected 3, got 2)"
+# TODO: Add diagnostic (there aren't enough values to unpack)
 (a, b, c) = (1, 2)
 reveal_type(a)  # revealed: Literal[1]
 reveal_type(b)  # revealed: Literal[2]
@@ -71,7 +71,7 @@ reveal_type(c)  # revealed: Unknown
 ### Uneven unpacking (2)
 
 ```py
-# error: [invalid-assignment] "Too many values to unpack (expected 2, got 3)"
+# TODO: Add diagnostic (too many values to unpack)
 (a, b) = (1, 2, 3)
 reveal_type(a)  # revealed: Literal[1]
 reveal_type(b)  # revealed: Literal[2]
@@ -80,7 +80,7 @@ reveal_type(b)  # revealed: Literal[2]
 ### Starred expression (1)
 
 ```py
-# error: [invalid-assignment] "Not enough values to unpack (expected 3 or more, got 2)"
+# TODO: Add diagnostic (need more values to unpack)
 [a, *b, c, d] = (1, 2)
 reveal_type(a)  # revealed: Literal[1]
 # TODO: Should be list[Any] once support for assigning to starred expression is added
@@ -133,7 +133,7 @@ reveal_type(c)  # revealed: @Todo(starred unpacking)
 ### Starred expression (6)
 
 ```py
-# error: [invalid-assignment] "Not enough values to unpack (expected 5 or more, got 1)"
+# TODO: Add diagnostic (need more values to unpack)
 (a, b, c, *d, e, f) = (1,)
 reveal_type(a)  # revealed: Literal[1]
 reveal_type(b)  # revealed: Unknown
@@ -199,7 +199,7 @@ reveal_type(b)  # revealed: LiteralString
 ### Uneven unpacking (1)
 
 ```py
-# error: [invalid-assignment] "Not enough values to unpack (expected 3, got 2)"
+# TODO: Add diagnostic (there aren't enough values to unpack)
 a, b, c = "ab"
 reveal_type(a)  # revealed: LiteralString
 reveal_type(b)  # revealed: LiteralString
@@ -209,7 +209,7 @@ reveal_type(c)  # revealed: Unknown
 ### Uneven unpacking (2)
 
 ```py
-# error: [invalid-assignment] "Too many values to unpack (expected 2, got 3)"
+# TODO: Add diagnostic (too many values to unpack)
 a, b = "abc"
 reveal_type(a)  # revealed: LiteralString
 reveal_type(b)  # revealed: LiteralString
@@ -218,7 +218,7 @@ reveal_type(b)  # revealed: LiteralString
 ### Starred expression (1)
 
 ```py
-# error: [invalid-assignment] "Not enough values to unpack (expected 3 or more, got 2)"
+# TODO: Add diagnostic (need more values to unpack)
 (a, *b, c, d) = "ab"
 reveal_type(a)  # revealed: LiteralString
 # TODO: Should be list[LiteralString] once support for assigning to starred expression is added
@@ -271,7 +271,7 @@ reveal_type(c)  # revealed: @Todo(starred unpacking)
 ### Unicode
 
 ```py
-# error: [invalid-assignment] "Not enough values to unpack (expected 2, got 1)"
+# TODO: Add diagnostic (need more values to unpack)
 (a, b) = "é"
 
 reveal_type(a)  # revealed: LiteralString
@@ -281,7 +281,7 @@ reveal_type(b)  # revealed: Unknown
 ### Unicode escape (1)
 
 ```py
-# error: [invalid-assignment] "Not enough values to unpack (expected 2, got 1)"
+# TODO: Add diagnostic (need more values to unpack)
 (a, b) = "\u9E6C"
 
 reveal_type(a)  # revealed: LiteralString
@@ -291,7 +291,7 @@ reveal_type(b)  # revealed: Unknown
 ### Unicode escape (2)
 
 ```py
-# error: [invalid-assignment] "Not enough values to unpack (expected 2, got 1)"
+# TODO: Add diagnostic (need more values to unpack)
 (a, b) = "\U0010FFFF"
 
 reveal_type(a)  # revealed: LiteralString
@@ -306,273 +306,3 @@ reveal_type(b)  # revealed: Unknown
 reveal_type(a)  # revealed: LiteralString
 reveal_type(b)  # revealed: LiteralString
 ```
-
-## Union
-
-### Same types
-
-Union of two tuples of equal length and each element is of the same type.
-
-```py
-def _(arg: tuple[int, int] | tuple[int, int]):
-    (a, b) = arg
-    reveal_type(a)  # revealed: int
-    reveal_type(b)  # revealed: int
-```
-
-### Mixed types (1)
-
-Union of two tuples of equal length and one element differs in its type.
-
-```py
-def _(arg: tuple[int, int] | tuple[int, str]):
-    a, b = arg
-    reveal_type(a)  # revealed: int
-    reveal_type(b)  # revealed: int | str
-```
-
-### Mixed types (2)
-
-Union of two tuples of equal length and both the element types are different.
-
-```py
-def _(arg: tuple[int, str] | tuple[str, int]):
-    a, b = arg
-    reveal_type(a)  # revealed: int | str
-    reveal_type(b)  # revealed: str | int
-```
-
-### Mixed types (3)
-
-Union of three tuples of equal length and various combination of element types:
-
-1. All same types
-1. One different type
-1. All different types
-
-```py
-def _(arg: tuple[int, int, int] | tuple[int, str, bytes] | tuple[int, int, str]):
-    a, b, c = arg
-    reveal_type(a)  # revealed: int
-    reveal_type(b)  # revealed: int | str
-    reveal_type(c)  # revealed: int | bytes | str
-```
-
-### Nested
-
-```py
-def _(arg: tuple[int, tuple[str, bytes]] | tuple[tuple[int, bytes], Literal["ab"]]):
-    a, (b, c) = arg
-    reveal_type(a)  # revealed: int | tuple[int, bytes]
-    reveal_type(b)  # revealed: str
-    reveal_type(c)  # revealed: bytes | LiteralString
-```
-
-### Starred expression
-
-```py
-def _(arg: tuple[int, bytes, int] | tuple[int, int, str, int, bytes]):
-    a, *b, c = arg
-    reveal_type(a)  # revealed: int
-    # TODO: Should be `list[bytes | int | str]`
-    reveal_type(b)  # revealed: @Todo(starred unpacking)
-    reveal_type(c)  # revealed: int | bytes
-```
-
-### Size mismatch (1)
-
-```py
-def _(arg: tuple[int, bytes, int] | tuple[int, int, str, int, bytes]):
-    # error: [invalid-assignment] "Too many values to unpack (expected 2, got 3)"
-    # error: [invalid-assignment] "Too many values to unpack (expected 2, got 5)"
-    a, b = arg
-    reveal_type(a)  # revealed: int
-    reveal_type(b)  # revealed: bytes | int
-```
-
-### Size mismatch (2)
-
-```py
-def _(arg: tuple[int, bytes] | tuple[int, str]):
-    # error: [invalid-assignment] "Not enough values to unpack (expected 3, got 2)"
-    # error: [invalid-assignment] "Not enough values to unpack (expected 3, got 2)"
-    a, b, c = arg
-    reveal_type(a)  # revealed: int
-    reveal_type(b)  # revealed: bytes | str
-    reveal_type(c)  # revealed: Unknown
-```
-
-### Same literal types
-
-```py
-def _(flag: bool):
-    if flag:
-        value = (1, 2)
-    else:
-        value = (3, 4)
-
-    a, b = value
-    reveal_type(a)  # revealed: Literal[1, 3]
-    reveal_type(b)  # revealed: Literal[2, 4]
-```
-
-### Mixed literal types
-
-```py
-def _(flag: bool):
-    if flag:
-        value = (1, 2)
-    else:
-        value = ("a", "b")
-
-    a, b = value
-    reveal_type(a)  # revealed: Literal[1, "a"]
-    reveal_type(b)  # revealed: Literal[2, "b"]
-```
-
-### Typing literal
-
-```py
-from typing import Literal
-
-def _(arg: tuple[int, int] | Literal["ab"]):
-    a, b = arg
-    reveal_type(a)  # revealed: int | LiteralString
-    reveal_type(b)  # revealed: int | LiteralString
-```
-
-### Custom iterator (1)
-
-```py
-class Iterator:
-    def __next__(self) -> tuple[int, int] | tuple[int, str]:
-        return (1, 2)
-
-class Iterable:
-    def __iter__(self) -> Iterator:
-        return Iterator()
-
-((a, b), c) = Iterable()
-reveal_type(a)  # revealed: int
-reveal_type(b)  # revealed: int | str
-reveal_type(c)  # revealed: tuple[int, int] | tuple[int, str]
-```
-
-### Custom iterator (2)
-
-```py
-class Iterator:
-    def __next__(self) -> bytes:
-        return b""
-
-class Iterable:
-    def __iter__(self) -> Iterator:
-        return Iterator()
-
-def _(arg: tuple[int, str] | Iterable):
-    a, b = arg
-    reveal_type(a)  # revealed: int | bytes
-    reveal_type(b)  # revealed: str | bytes
-```
-
-## For statement
-
-Unpacking in a `for` statement.
-
-### Same types
-
-```py
-def _(arg: tuple[tuple[int, int], tuple[int, int]]):
-    for a, b in arg:
-        reveal_type(a)  # revealed: int
-        reveal_type(b)  # revealed: int
-```
-
-### Mixed types (1)
-
-```py
-def _(arg: tuple[tuple[int, int], tuple[int, str]]):
-    for a, b in arg:
-        reveal_type(a)  # revealed: int
-        reveal_type(b)  # revealed: int | str
-```
-
-### Mixed types (2)
-
-```py
-def _(arg: tuple[tuple[int, str], tuple[str, int]]):
-    for a, b in arg:
-        reveal_type(a)  # revealed: int | str
-        reveal_type(b)  # revealed: str | int
-```
-
-### Mixed types (3)
-
-```py
-def _(arg: tuple[tuple[int, int, int], tuple[int, str, bytes], tuple[int, int, str]]):
-    for a, b, c in arg:
-        reveal_type(a)  # revealed: int
-        reveal_type(b)  # revealed: int | str
-        reveal_type(c)  # revealed: int | bytes | str
-```
-
-### Same literal values
-
-```py
-for a, b in ((1, 2), (3, 4)):
-    reveal_type(a)  # revealed: Literal[1, 3]
-    reveal_type(b)  # revealed: Literal[2, 4]
-```
-
-### Mixed literal values (1)
-
-```py
-for a, b in ((1, 2), ("a", "b")):
-    reveal_type(a)  # revealed: Literal[1, "a"]
-    reveal_type(b)  # revealed: Literal[2, "b"]
-```
-
-### Mixed literals values (2)
-
-```py
-# error: "Object of type `Literal[1]` is not iterable"
-# error: "Object of type `Literal[2]` is not iterable"
-# error: "Object of type `Literal[4]` is not iterable"
-# error: [invalid-assignment] "Not enough values to unpack (expected 2, got 1)"
-for a, b in (1, 2, (3, "a"), 4, (5, "b"), "c"):
-    reveal_type(a)  # revealed: Unknown | Literal[3, 5] | LiteralString
-    reveal_type(b)  # revealed: Unknown | Literal["a", "b"]
-```
-
-### Custom iterator (1)
-
-```py
-class Iterator:
-    def __next__(self) -> tuple[int, int]:
-        return (1, 2)
-
-class Iterable:
-    def __iter__(self) -> Iterator:
-        return Iterator()
-
-for a, b in Iterable():
-    reveal_type(a)  # revealed: int
-    reveal_type(b)  # revealed: int
-```
-
-### Custom iterator (2)
-
-```py
-class Iterator:
-    def __next__(self) -> bytes:
-        return b""
-
-class Iterable:
-    def __iter__(self) -> Iterator:
-        return Iterator()
-
-def _(arg: tuple[tuple[int, str], Iterable]):
-    for a, b in arg:
-        reveal_type(a)  # revealed: int | bytes
-        reveal_type(b)  # revealed: str | bytes
-```

crates/red_knot_python_semantic/resources/mdtest/with/async.md

@@ -17,5 +17,5 @@ class Manager:
 
 async def test():
     async with Manager() as f:
-        reveal_type(f)  # revealed: @Todo(async `with` statement)
+        reveal_type(f)  # revealed: @Todo(async with statement)
 ```

crates/red_knot_python_semantic/src/ast_node_ref.rs

@@ -43,7 +43,7 @@ impl<T> AstNodeRef<T> {
     }
 
     /// Returns a reference to the wrapped node.
-    pub const fn node(&self) -> &T {
+    pub fn node(&self) -> &T {
         // SAFETY: Holding on to `parsed` ensures that the AST to which `node` belongs is still
         // alive and not moved.
         unsafe { self.node.as_ref() }

crates/red_knot_python_semantic/src/db.rs

@@ -1,4 +1,4 @@
-use crate::lint::{LintRegistry, RuleSelection};
+use crate::lint::RuleSelection;
 use ruff_db::files::File;
 use ruff_db::{Db as SourceDb, Upcast};
 
@@ -8,8 +8,6 @@ pub trait Db: SourceDb + Upcast<dyn SourceDb> {
     fn is_file_open(&self, file: File) -> bool;
 
     fn rule_selection(&self) -> &RuleSelection;
-
-    fn lint_registry(&self) -> &LintRegistry;
 }
 
 #[cfg(test)]
@@ -18,10 +16,10 @@ pub(crate) mod tests {
 
     use crate::program::{Program, SearchPathSettings};
     use crate::python_version::PythonVersion;
-    use crate::{default_lint_registry, ProgramSettings, PythonPlatform};
+    use crate::{default_lint_registry, ProgramSettings};
 
     use super::Db;
-    use crate::lint::{LintRegistry, RuleSelection};
+    use crate::lint::RuleSelection;
     use anyhow::Context;
     use ruff_db::files::{File, Files};
     use ruff_db::system::{DbWithTestSystem, System, SystemPathBuf, TestSystem};
@@ -29,7 +27,6 @@ pub(crate) mod tests {
     use ruff_db::{Db as SourceDb, Upcast};
 
     #[salsa::db]
-    #[derive(Clone)]
     pub(crate) struct TestDb {
         storage: salsa::Storage<Self>,
         files: Files,
@@ -47,7 +44,7 @@ pub(crate) mod tests {
                 vendored: red_knot_vendored::file_system().clone(),
                 events: Arc::default(),
                 files: Files::default(),
-                rule_selection: Arc::new(RuleSelection::from_registry(default_lint_registry())),
+                rule_selection: Arc::new(RuleSelection::from_registry(&default_lint_registry())),
             }
         }
 
@@ -114,10 +111,6 @@ pub(crate) mod tests {
         fn rule_selection(&self) -> &RuleSelection {
             &self.rule_selection
         }
-
-        fn lint_registry(&self) -> &LintRegistry {
-            default_lint_registry()
-        }
     }
 
     #[salsa::db]
@@ -133,8 +126,6 @@ pub(crate) mod tests {
     pub(crate) struct TestDbBuilder<'a> {
         /// Target Python version
         python_version: PythonVersion,
-        /// Target Python platform
-        python_platform: PythonPlatform,
         /// Path to a custom typeshed directory
         custom_typeshed: Option<SystemPathBuf>,
         /// Path and content pairs for files that should be present
@@ -145,7 +136,6 @@ pub(crate) mod tests {
         pub(crate) fn new() -> Self {
             Self {
                 python_version: PythonVersion::default(),
-                python_platform: PythonPlatform::default(),
                 custom_typeshed: None,
                 files: vec![],
             }
@@ -182,7 +172,6 @@ pub(crate) mod tests {
                 &db,
                 &ProgramSettings {
                     python_version: self.python_version,
-                    python_platform: self.python_platform,
                     search_paths,
                 },
             )

crates/red_knot_python_semantic/src/lib.rs

@@ -3,12 +3,10 @@ use std::hash::BuildHasherDefault;
 use rustc_hash::FxHasher;
 
 use crate::lint::{LintRegistry, LintRegistryBuilder};
-use crate::suppression::{INVALID_IGNORE_COMMENT, UNKNOWN_RULE, UNUSED_IGNORE_COMMENT};
 pub use db::Db;
 pub use module_name::ModuleName;
-pub use module_resolver::{resolve_module, system_module_search_paths, KnownModule, Module};
+pub use module_resolver::{resolve_module, system_module_search_paths, Module};
 pub use program::{Program, ProgramSettings, SearchPathSettings, SitePackages};
-pub use python_platform::PythonPlatform;
 pub use python_version::PythonVersion;
 pub use semantic_model::{HasTy, SemanticModel};
 
@@ -19,36 +17,26 @@ mod module_name;
 mod module_resolver;
 mod node_key;
 mod program;
-mod python_platform;
 mod python_version;
 pub mod semantic_index;
 mod semantic_model;
 pub(crate) mod site_packages;
 mod stdlib;
-mod suppression;
 pub(crate) mod symbol;
 pub mod types;
 mod unpack;
 mod util;
-mod visibility_constraints;
 
 type FxOrderSet<V> = ordermap::set::OrderSet<V, BuildHasherDefault<FxHasher>>;
 
-/// Returns the default registry with all known semantic lints.
-pub fn default_lint_registry() -> &'static LintRegistry {
-    static REGISTRY: std::sync::LazyLock<LintRegistry> = std::sync::LazyLock::new(|| {
-        let mut registry = LintRegistryBuilder::default();
-        register_lints(&mut registry);
-        registry.build()
-    });
-
-    &REGISTRY
+/// Creates a new registry with all known semantic lints.
+pub fn default_lint_registry() -> LintRegistry {
+    let mut registry = LintRegistryBuilder::default();
+    register_lints(&mut registry);
+    registry.build()
 }
 
 /// Register all known semantic lints.
 pub fn register_lints(registry: &mut LintRegistryBuilder) {
     types::register_lints(registry);
-    registry.register_lint(&UNUSED_IGNORE_COMMENT);
-    registry.register_lint(&UNKNOWN_RULE);
-    registry.register_lint(&INVALID_IGNORE_COMMENT);
 }

crates/red_knot_python_semantic/src/lint.rs

@@ -321,7 +321,7 @@ impl LintRegistryBuilder {
     }
 }
 
-#[derive(Default, Debug, Clone)]
+#[derive(Default, Debug)]
 pub struct LintRegistry {
     lints: Vec<LintId>,
     by_name: FxHashMap<&'static str, LintEntry>,
@@ -374,7 +374,7 @@ impl LintRegistry {
     }
 }
 
-#[derive(Error, Debug, Clone, PartialEq, Eq)]
+#[derive(Error, Debug, Clone)]
 pub enum GetLintError {
     /// The name maps to this removed lint.
     #[error("lint {0} has been removed")]
@@ -385,7 +385,7 @@ pub enum GetLintError {
     Unknown(String),
 }
 
-#[derive(Debug, PartialEq, Eq, Clone, Copy)]
+#[derive(Debug, PartialEq, Eq)]
 pub enum LintEntry {
     /// An existing lint rule. Can be in preview, stable or deprecated.
     Lint(LintId),
@@ -444,11 +444,6 @@ impl RuleSelection {
         self.lints.get(&lint).copied()
     }
 
-    /// Returns `true` if the `lint` is enabled.
-    pub fn is_enabled(&self, lint: LintId) -> bool {
-        self.severity(lint).is_some()
-    }
-
     /// Enables `lint` and configures with the given `severity`.
     ///
     /// Overrides any previous configuration for the lint.

crates/red_knot_python_semantic/src/module_name.rs

@@ -186,26 +186,6 @@ impl ModuleName {
         self.0.push('.');
         self.0.push_str(other);
     }
-
-    /// Returns an iterator of this module name and all of its parent modules.
-    ///
-    /// # Examples
-    ///
-    /// ```
-    /// use red_knot_python_semantic::ModuleName;
-    ///
-    /// assert_eq!(
-    ///     ModuleName::new_static("foo.bar.baz").unwrap().ancestors().collect::<Vec<_>>(),
-    ///     vec![
-    ///         ModuleName::new_static("foo.bar.baz").unwrap(),
-    ///         ModuleName::new_static("foo.bar").unwrap(),
-    ///         ModuleName::new_static("foo").unwrap(),
-    ///     ],
-    /// );
-    /// ```
-    pub fn ancestors(&self) -> impl Iterator<Item = Self> {
-        std::iter::successors(Some(self.clone()), Self::parent)
-    }
 }
 
 impl Deref for ModuleName {

crates/red_knot_python_semantic/src/module_resolver/mod.rs

@@ -1,6 +1,6 @@
 use std::iter::FusedIterator;
 
-pub use module::{KnownModule, Module};
+pub use module::Module;
 pub use resolver::resolve_module;
 pub(crate) use resolver::{file_to_module, SearchPaths};
 use ruff_db::system::SystemPath;

crates/red_knot_python_semantic/src/module_resolver/module.rs

@@ -7,7 +7,7 @@ use super::path::SearchPath;
 use crate::module_name::ModuleName;
 
 /// Representation of a Python module.
-#[derive(Clone, PartialEq, Eq, Hash)]
+#[derive(Clone, PartialEq, Eq)]
 pub struct Module {
     inner: Arc<ModuleInner>,
 }
@@ -19,14 +19,12 @@ impl Module {
         search_path: SearchPath,
         file: File,
     ) -> Self {
-        let known = KnownModule::try_from_search_path_and_name(&search_path, &name);
         Self {
             inner: Arc::new(ModuleInner {
                 name,
                 kind,
                 search_path,
                 file,
-                known,
             }),
         }
     }
@@ -41,16 +39,6 @@ impl Module {
         self.inner.file
     }
 
-    /// Is this a module that we special-case somehow? If so, which one?
-    pub fn known(&self) -> Option<KnownModule> {
-        self.inner.known
-    }
-
-    /// Does this module represent the given known module?
-    pub fn is_known(&self, known_module: KnownModule) -> bool {
-        self.known() == Some(known_module)
-    }
-
     /// The search path from which the module was resolved.
     pub(crate) fn search_path(&self) -> &SearchPath {
         &self.inner.search_path
@@ -73,13 +61,12 @@ impl std::fmt::Debug for Module {
     }
 }
 
-#[derive(PartialEq, Eq, Hash)]
+#[derive(PartialEq, Eq)]
 struct ModuleInner {
     name: ModuleName,
     kind: ModuleKind,
     search_path: SearchPath,
     file: File,
-    known: Option<KnownModule>,
 }
 
 #[derive(Copy, Clone, Debug, Eq, PartialEq, Hash)]
@@ -96,69 +83,3 @@ impl ModuleKind {
         matches!(self, ModuleKind::Package)
     }
 }
-
-/// Enumeration of various core stdlib modules in which important types are located
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
-pub enum KnownModule {
-    Builtins,
-    Types,
-    Typeshed,
-    TypingExtensions,
-    Typing,
-    Sys,
-    #[allow(dead_code)]
-    Abc, // currently only used in tests
-    Collections,
-    KnotExtensions,
-}
-
-impl KnownModule {
-    pub const fn as_str(self) -> &'static str {
-        match self {
-            Self::Builtins => "builtins",
-            Self::Types => "types",
-            Self::Typing => "typing",
-            Self::Typeshed => "_typeshed",
-            Self::TypingExtensions => "typing_extensions",
-            Self::Sys => "sys",
-            Self::Abc => "abc",
-            Self::Collections => "collections",
-            Self::KnotExtensions => "knot_extensions",
-        }
-    }
-
-    pub fn name(self) -> ModuleName {
-        let self_as_str = self.as_str();
-        ModuleName::new_static(self_as_str)
-            .unwrap_or_else(|| panic!("{self_as_str} should be a valid module name!"))
-    }
-
-    pub(crate) fn try_from_search_path_and_name(
-        search_path: &SearchPath,
-        name: &ModuleName,
-    ) -> Option<Self> {
-        if !search_path.is_standard_library() {
-            return None;
-        }
-        match name.as_str() {
-            "builtins" => Some(Self::Builtins),
-            "types" => Some(Self::Types),
-            "typing" => Some(Self::Typing),
-            "_typeshed" => Some(Self::Typeshed),
-            "typing_extensions" => Some(Self::TypingExtensions),
-            "sys" => Some(Self::Sys),
-            "abc" => Some(Self::Abc),
-            "collections" => Some(Self::Collections),
-            "knot_extensions" => Some(Self::KnotExtensions),
-            _ => None,
-        }
-    }
-
-    pub const fn is_typing(self) -> bool {
-        matches!(self, Self::Typing)
-    }
-
-    pub const fn is_knot_extensions(self) -> bool {
-        matches!(self, Self::KnotExtensions)
-    }
-}

crates/red_knot_python_semantic/src/module_resolver/resolver.rs

@@ -73,15 +73,6 @@ enum SystemOrVendoredPathRef<'a> {
     Vendored(&'a VendoredPath),
 }
 
-impl std::fmt::Display for SystemOrVendoredPathRef<'_> {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        match self {
-            SystemOrVendoredPathRef::System(system) => system.fmt(f),
-            SystemOrVendoredPathRef::Vendored(vendored) => vendored.fmt(f),
-        }
-    }
-}
-
 /// Resolves the module for the file with the given id.
 ///
 /// Returns `None` if the file is not a module locatable via any of the known search paths.
@@ -721,8 +712,8 @@ mod tests {
     use crate::module_name::ModuleName;
     use crate::module_resolver::module::ModuleKind;
     use crate::module_resolver::testing::{FileSpec, MockedTypeshed, TestCase, TestCaseBuilder};
+    use crate::ProgramSettings;
     use crate::PythonVersion;
-    use crate::{ProgramSettings, PythonPlatform};
 
     use super::*;
 
@@ -1262,7 +1253,7 @@ mod tests {
     fn symlink() -> anyhow::Result<()> {
         use anyhow::Context;
 
-        use crate::{program::Program, PythonPlatform};
+        use crate::program::Program;
         use ruff_db::system::{OsSystem, SystemPath};
 
         use crate::db::tests::TestDb;
@@ -1296,7 +1287,6 @@ mod tests {
             &db,
             &ProgramSettings {
                 python_version: PythonVersion::PY38,
-                python_platform: PythonPlatform::default(),
                 search_paths: SearchPathSettings {
                     extra_paths: vec![],
                     src_root: src.clone(),
@@ -1802,7 +1792,6 @@ not_a_directory
             &db,
             &ProgramSettings {
                 python_version: PythonVersion::default(),
-                python_platform: PythonPlatform::default(),
                 search_paths: SearchPathSettings {
                     extra_paths: vec![],
                     src_root: SystemPathBuf::from("/src"),

crates/red_knot_python_semantic/src/module_resolver/testing.rs

@@ -4,7 +4,7 @@ use ruff_db::vendored::VendoredPathBuf;
 use crate::db::tests::TestDb;
 use crate::program::{Program, SearchPathSettings};
 use crate::python_version::PythonVersion;
-use crate::{ProgramSettings, PythonPlatform, SitePackages};
+use crate::{ProgramSettings, SitePackages};
 
 /// A test case for the module resolver.
 ///
@@ -101,7 +101,6 @@ pub(crate) struct UnspecifiedTypeshed;
 pub(crate) struct TestCaseBuilder<T> {
     typeshed_option: T,
     python_version: PythonVersion,
-    python_platform: PythonPlatform,
     first_party_files: Vec<FileSpec>,
     site_packages_files: Vec<FileSpec>,
 }
@@ -148,7 +147,6 @@ impl TestCaseBuilder<UnspecifiedTypeshed> {
         Self {
             typeshed_option: UnspecifiedTypeshed,
             python_version: PythonVersion::default(),
-            python_platform: PythonPlatform::default(),
             first_party_files: vec![],
             site_packages_files: vec![],
         }
@@ -159,14 +157,12 @@ impl TestCaseBuilder<UnspecifiedTypeshed> {
         let TestCaseBuilder {
             typeshed_option: _,
             python_version,
-            python_platform,
             first_party_files,
             site_packages_files,
         } = self;
         TestCaseBuilder {
             typeshed_option: VendoredTypeshed,
             python_version,
-            python_platform,
             first_party_files,
             site_packages_files,
         }
@@ -180,7 +176,6 @@ impl TestCaseBuilder<UnspecifiedTypeshed> {
         let TestCaseBuilder {
             typeshed_option: _,
             python_version,
-            python_platform,
             first_party_files,
             site_packages_files,
         } = self;
@@ -188,7 +183,6 @@ impl TestCaseBuilder<UnspecifiedTypeshed> {
         TestCaseBuilder {
             typeshed_option: typeshed,
             python_version,
-            python_platform,
             first_party_files,
             site_packages_files,
         }
@@ -218,7 +212,6 @@ impl TestCaseBuilder<MockedTypeshed> {
         let TestCaseBuilder {
             typeshed_option,
             python_version,
-            python_platform,
             first_party_files,
             site_packages_files,
         } = self;
@@ -234,7 +227,6 @@ impl TestCaseBuilder<MockedTypeshed> {
             &db,
             &ProgramSettings {
                 python_version,
-                python_platform,
                 search_paths: SearchPathSettings {
                     extra_paths: vec![],
                     src_root: src.clone(),
@@ -277,7 +269,6 @@ impl TestCaseBuilder<VendoredTypeshed> {
         let TestCaseBuilder {
             typeshed_option: VendoredTypeshed,
             python_version,
-            python_platform,
             first_party_files,
             site_packages_files,
         } = self;
@@ -292,7 +283,6 @@ impl TestCaseBuilder<VendoredTypeshed> {
             &db,
             &ProgramSettings {
                 python_version,
-                python_platform,
                 search_paths: SearchPathSettings {
                     site_packages: SitePackages::Known(vec![site_packages.clone()]),
                     ..SearchPathSettings::new(src.clone())

crates/red_knot_python_semantic/src/program.rs

@@ -1,4 +1,3 @@
-use crate::python_platform::PythonPlatform;
 use crate::python_version::PythonVersion;
 use anyhow::Context;
 use salsa::Durability;
@@ -13,8 +12,6 @@ use crate::Db;
 pub struct Program {
     pub python_version: PythonVersion,
 
-    pub python_platform: PythonPlatform,
-
     #[return_ref]
     pub(crate) search_paths: SearchPaths,
 }
@@ -23,7 +20,6 @@ impl Program {
     pub fn from_settings(db: &dyn Db, settings: &ProgramSettings) -> anyhow::Result<Self> {
         let ProgramSettings {
             python_version,
-            python_platform,
             search_paths,
         } = settings;
 
@@ -32,11 +28,9 @@ impl Program {
         let search_paths = SearchPaths::from_settings(db, search_paths)
             .with_context(|| "Invalid search path settings")?;
 
-        Ok(
-            Program::builder(*python_version, python_platform.clone(), search_paths)
-                .durability(Durability::HIGH)
-                .new(db),
-        )
+        Ok(Program::builder(settings.python_version, search_paths)
+            .durability(Durability::HIGH)
+            .new(db))
     }
 
     pub fn update_search_paths(
@@ -63,7 +57,6 @@ impl Program {
 #[cfg_attr(feature = "serde", derive(serde::Serialize))]
 pub struct ProgramSettings {
     pub python_version: PythonVersion,
-    pub python_platform: PythonPlatform,
     pub search_paths: SearchPathSettings,
 }
 

crates/red_knot_python_semantic/src/python_platform.rs

@@ -1,19 +0,0 @@
-/// The target platform to assume when resolving types.
-#[derive(Debug, Clone, Default, PartialEq, Eq)]
-#[cfg_attr(
-    feature = "serde",
-    derive(serde::Serialize, serde::Deserialize),
-    serde(rename_all = "kebab-case")
-)]
-pub enum PythonPlatform {
-    /// Do not make any assumptions about the target platform.
-    #[default]
-    All,
-    /// Assume a specific target platform like `linux`, `darwin` or `win32`.
-    ///
-    /// We use a string (instead of individual enum variants), as the set of possible platforms
-    /// may change over time. See <https://docs.python.org/3/library/sys.html#sys.platform> for
-    /// some known platform identifiers.
-    #[cfg_attr(feature = "serde", serde(untagged))]
-    Identifier(String),
-}

crates/red_knot_python_semantic/src/semantic_index.rs

@@ -1,14 +1,13 @@
 use std::iter::FusedIterator;
 use std::sync::Arc;
 
-use rustc_hash::{FxBuildHasher, FxHashMap, FxHashSet};
+use rustc_hash::{FxBuildHasher, FxHashMap};
 use salsa::plumbing::AsId;
 
 use ruff_db::files::File;
 use ruff_db::parsed::parsed_module;
 use ruff_index::{IndexSlice, IndexVec};
 
-use crate::module_name::ModuleName;
 use crate::semantic_index::ast_ids::node_key::ExpressionNodeKey;
 use crate::semantic_index::ast_ids::AstIds;
 use crate::semantic_index::builder::SemanticIndexBuilder;
@@ -29,8 +28,7 @@ pub mod symbol;
 mod use_def;
 
 pub(crate) use self::use_def::{
-    BindingWithConstraints, BindingWithConstraintsIterator, DeclarationWithConstraint,
-    DeclarationsIterator, ScopedVisibilityConstraintId,
+    BindingWithConstraints, BindingWithConstraintsIterator, DeclarationsIterator,
 };
 
 type SymbolMap = hashbrown::HashMap<ScopedSymbolId, (), FxBuildHasher>;
@@ -62,22 +60,6 @@ pub(crate) fn symbol_table<'db>(db: &'db dyn Db, scope: ScopeId<'db>) -> Arc<Sym
     index.symbol_table(scope.file_scope_id(db))
 }
 
-/// Returns the set of modules that are imported anywhere in `file`.
-///
-/// This set only considers `import` statements, not `from...import` statements, because:
-///
-///   - In `from foo import bar`, we cannot determine whether `foo.bar` is a submodule (and is
-///     therefore imported) without looking outside the content of this file.  (We could turn this
-///     into a _potentially_ imported modules set, but that would change how it's used in our type
-///     inference logic.)
-///
-///   - We cannot resolve relative imports (which aren't allowed in `import` statements) without
-///     knowing the name of the current module, and whether it's a package.
-#[salsa::tracked]
-pub(crate) fn imported_modules<'db>(db: &'db dyn Db, file: File) -> Arc<FxHashSet<ModuleName>> {
-    semantic_index(db, file).imported_modules.clone()
-}
-
 /// Returns the use-def map for a specific `scope`.
 ///
 /// Using [`use_def_map`] over [`semantic_index`] has the advantage that
@@ -134,9 +116,6 @@ pub(crate) struct SemanticIndex<'db> {
     /// changing a file invalidates all dependents.
     ast_ids: IndexVec<FileScopeId, AstIds>,
 
-    /// The set of modules that are imported anywhere within this file.
-    imported_modules: Arc<FxHashSet<ModuleName>>,
-
     /// Flags about the global scope (code usage impacting inference)
     has_future_annotations: bool,
 }
@@ -379,12 +358,14 @@ mod tests {
     impl UseDefMap<'_> {
         fn first_public_binding(&self, symbol: ScopedSymbolId) -> Option<Definition<'_>> {
             self.public_bindings(symbol)
-                .find_map(|constrained_binding| constrained_binding.binding)
+                .next()
+                .map(|constrained_binding| constrained_binding.binding)
         }
 
         fn first_binding_at_use(&self, use_id: ScopedUseId) -> Option<Definition<'_>> {
             self.bindings_at_use(use_id)
-                .find_map(|constrained_binding| constrained_binding.binding)
+                .next()
+                .map(|constrained_binding| constrained_binding.binding)
         }
     }
 

crates/red_knot_python_semantic/src/semantic_index/builder.rs

@@ -1,20 +1,22 @@
+use std::num::NonZeroUsize;
+use std::ops::Div;
 use std::sync::Arc;
 
 use except_handlers::TryNodeContextStackManager;
-use rustc_hash::{FxHashMap, FxHashSet};
+use rustc_hash::{FxBuildHasher, FxHashMap};
 
 use ruff_db::files::File;
 use ruff_db::parsed::ParsedModule;
+use ruff_db::source::source_text;
 use ruff_index::IndexVec;
 use ruff_python_ast as ast;
 use ruff_python_ast::name::Name;
 use ruff_python_ast::visitor::{walk_expr, walk_pattern, walk_stmt, Visitor};
+use ruff_python_ast::{BoolOp, Expr};
 
 use crate::ast_node_ref::AstNodeRef;
-use crate::module_name::ModuleName;
 use crate::semantic_index::ast_ids::node_key::ExpressionNodeKey;
 use crate::semantic_index::ast_ids::AstIdsBuilder;
-use crate::semantic_index::constraint::PatternConstraintKind;
 use crate::semantic_index::definition::{
     AssignmentDefinitionNodeRef, ComprehensionDefinitionNodeRef, Definition, DefinitionNodeKey,
     DefinitionNodeRef, ForStmtDefinitionNodeRef, ImportFromDefinitionNodeRef,
@@ -24,12 +26,9 @@ use crate::semantic_index::symbol::{
     FileScopeId, NodeWithScopeKey, NodeWithScopeRef, Scope, ScopeId, ScopedSymbolId,
     SymbolTableBuilder,
 };
-use crate::semantic_index::use_def::{
-    FlowSnapshot, ScopedConstraintId, ScopedVisibilityConstraintId, UseDefMapBuilder,
-};
+use crate::semantic_index::use_def::{FlowSnapshot, UseDefMapBuilder};
 use crate::semantic_index::SemanticIndex;
-use crate::unpack::{Unpack, UnpackValue};
-use crate::visibility_constraints::VisibilityConstraint;
+use crate::unpack::Unpack;
 use crate::Db;
 
 use super::constraint::{Constraint, ConstraintNode, PatternConstraint};
@@ -83,11 +82,14 @@ pub(super) struct SemanticIndexBuilder<'db> {
     scopes_by_expression: FxHashMap<ExpressionNodeKey, FileScopeId>,
     definitions_by_node: FxHashMap<DefinitionNodeKey, Definition<'db>>,
     expressions_by_node: FxHashMap<ExpressionNodeKey, Expression<'db>>,
-    imported_modules: FxHashSet<ModuleName>,
 }
 
 impl<'db> SemanticIndexBuilder<'db> {
     pub(super) fn new(db: &'db dyn Db, file: File, parsed: &'db ParsedModule) -> Self {
+        let source = source_text(db.upcast(), file);
+        let approximated_expressions = (source.len() as f64 * 0.05) as usize;
+        let approximated_definitions = (source.len() as f64 * 0.015) as usize;
+
         let mut builder = Self {
             db,
             file,
@@ -106,12 +108,19 @@ impl<'db> SemanticIndexBuilder<'db> {
             scope_ids_by_scope: IndexVec::new(),
             use_def_maps: IndexVec::new(),
 
-            scopes_by_expression: FxHashMap::default(),
+            scopes_by_expression: FxHashMap::with_capacity_and_hasher(
+                approximated_expressions,
+                FxBuildHasher::default(),
+            ),
             scopes_by_node: FxHashMap::default(),
-            definitions_by_node: FxHashMap::default(),
-            expressions_by_node: FxHashMap::default(),
-
-            imported_modules: FxHashSet::default(),
+            definitions_by_node: FxHashMap::with_capacity_and_hasher(
+                approximated_definitions,
+                FxBuildHasher::default(),
+            ),
+            expressions_by_node: FxHashMap::with_capacity_and_hasher(
+                approximated_expressions,
+                FxBuildHasher::default(),
+            ),
         };
 
         builder.push_scope_with_parent(NodeWithScopeRef::Module, None);
@@ -288,7 +297,11 @@ impl<'db> SemanticIndexBuilder<'db> {
         constraint
     }
 
-    fn build_constraint(&mut self, constraint_node: &ast::Expr) -> Constraint<'db> {
+    fn record_constraint(&mut self, constraint: Constraint<'db>) {
+        self.current_use_def_map_mut().record_constraint(constraint);
+    }
+
+    fn build_constraint(&mut self, constraint_node: &Expr) -> Constraint<'db> {
         let expression = self.add_standalone_expression(constraint_node);
         Constraint {
             node: ConstraintNode::Expression(expression),
@@ -296,89 +309,12 @@ impl<'db> SemanticIndexBuilder<'db> {
         }
     }
 
-    /// Adds a new constraint to the list of all constraints, but does not record it. Returns the
-    /// constraint ID for later recording using [`SemanticIndexBuilder::record_constraint_id`].
-    fn add_constraint(&mut self, constraint: Constraint<'db>) -> ScopedConstraintId {
-        self.current_use_def_map_mut().add_constraint(constraint)
-    }
-
-    /// Negates a constraint and adds it to the list of all constraints, does not record it.
-    fn add_negated_constraint(
-        &mut self,
-        constraint: Constraint<'db>,
-    ) -> (Constraint<'db>, ScopedConstraintId) {
-        let negated = Constraint {
-            node: constraint.node,
-            is_positive: false,
-        };
-        let id = self.current_use_def_map_mut().add_constraint(negated);
-        (negated, id)
-    }
-
-    /// Records a previously added constraint by adding it to all live bindings.
-    fn record_constraint_id(&mut self, constraint: ScopedConstraintId) {
+    fn record_negated_constraint(&mut self, constraint: Constraint<'db>) {
         self.current_use_def_map_mut()
-            .record_constraint_id(constraint);
-    }
-
-    /// Adds and records a constraint, i.e. adds it to all live bindings.
-    fn record_constraint(&mut self, constraint: Constraint<'db>) {
-        self.current_use_def_map_mut().record_constraint(constraint);
-    }
-
-    /// Negates the given constraint and then adds it to all live bindings.
-    fn record_negated_constraint(&mut self, constraint: Constraint<'db>) -> ScopedConstraintId {
-        let (_, id) = self.add_negated_constraint(constraint);
-        self.record_constraint_id(id);
-        id
-    }
-
-    /// Adds a new visibility constraint, but does not record it. Returns the constraint ID
-    /// for later recording using [`SemanticIndexBuilder::record_visibility_constraint_id`].
-    fn add_visibility_constraint(
-        &mut self,
-        constraint: VisibilityConstraint<'db>,
-    ) -> ScopedVisibilityConstraintId {
-        self.current_use_def_map_mut()
-            .add_visibility_constraint(constraint)
-    }
-
-    /// Records a previously added visibility constraint by applying it to all live bindings
-    /// and declarations.
-    fn record_visibility_constraint_id(&mut self, constraint: ScopedVisibilityConstraintId) {
-        self.current_use_def_map_mut()
-            .record_visibility_constraint_id(constraint);
-    }
-
-    /// Negates the given visibility constraint and then adds it to all live bindings and declarations.
-    fn record_negated_visibility_constraint(
-        &mut self,
-        constraint: ScopedVisibilityConstraintId,
-    ) -> ScopedVisibilityConstraintId {
-        self.current_use_def_map_mut()
-            .record_visibility_constraint(VisibilityConstraint::VisibleIfNot(constraint))
-    }
-
-    /// Records a visibility constraint by applying it to all live bindings and declarations.
-    fn record_visibility_constraint(
-        &mut self,
-        constraint: Constraint<'db>,
-    ) -> ScopedVisibilityConstraintId {
-        self.current_use_def_map_mut()
-            .record_visibility_constraint(VisibilityConstraint::VisibleIf(constraint))
-    }
-
-    /// Records a [`VisibilityConstraint::Ambiguous`] constraint.
-    fn record_ambiguous_visibility(&mut self) -> ScopedVisibilityConstraintId {
-        self.current_use_def_map_mut()
-            .record_visibility_constraint(VisibilityConstraint::Ambiguous)
-    }
-
-    /// Simplifies (resets) visibility constraints on all live bindings and declarations that did
-    /// not see any new definitions since the given snapshot.
-    fn simplify_visibility_constraints(&mut self, snapshot: FlowSnapshot) {
-        self.current_use_def_map_mut()
-            .simplify_visibility_constraints(snapshot);
+            .record_constraint(Constraint {
+                node: constraint.node,
+                is_positive: false,
+            });
     }
 
     fn push_assignment(&mut self, assignment: CurrentAssignment<'db>) {
@@ -400,52 +336,30 @@ impl<'db> SemanticIndexBuilder<'db> {
 
     fn add_pattern_constraint(
         &mut self,
-        subject: Expression<'db>,
+        subject: &ast::Expr,
         pattern: &ast::Pattern,
-        guard: Option<&ast::Expr>,
-    ) -> Constraint<'db> {
-        // This is called for the top-level pattern of each match arm. We need to create a
-        // standalone expression for each arm of a match statement, since they can introduce
-        // constraints on the match subject. (Or more accurately, for the match arm's pattern,
-        // since its the pattern that introduces any constraints, not the body.) Ideally, that
-        // standalone expression would wrap the match arm's pattern as a whole. But a standalone
-        // expression can currently only wrap an ast::Expr, which patterns are not. So, we need to
-        // choose an Expr that can “stand in” for the pattern, which we can wrap in a standalone
-        // expression.
-        //
-        // See the comment in TypeInferenceBuilder::infer_match_pattern for more details.
-
-        let guard = guard.map(|guard| self.add_standalone_expression(guard));
-
-        let kind = match pattern {
-            ast::Pattern::MatchValue(pattern) => {
-                let value = self.add_standalone_expression(&pattern.value);
-                PatternConstraintKind::Value(value, guard)
-            }
-            ast::Pattern::MatchSingleton(singleton) => {
-                PatternConstraintKind::Singleton(singleton.value, guard)
-            }
-            ast::Pattern::MatchClass(pattern) => {
-                let cls = self.add_standalone_expression(&pattern.cls);
-                PatternConstraintKind::Class(cls, guard)
-            }
-            _ => PatternConstraintKind::Unsupported,
+    ) -> PatternConstraint<'db> {
+        #[allow(unsafe_code)]
+        let (subject, pattern) = unsafe {
+            (
+                AstNodeRef::new(self.module.clone(), subject),
+                AstNodeRef::new(self.module.clone(), pattern),
+            )
         };
-
         let pattern_constraint = PatternConstraint::new(
             self.db,
             self.file,
             self.current_scope(),
             subject,
-            kind,
+            pattern,
             countme::Count::default(),
         );
-        let constraint = Constraint {
-            node: ConstraintNode::Pattern(pattern_constraint),
-            is_positive: true,
-        };
-        self.current_use_def_map_mut().record_constraint(constraint);
-        constraint
+        self.current_use_def_map_mut()
+            .record_constraint(Constraint {
+                node: ConstraintNode::Pattern(pattern_constraint),
+                is_positive: true,
+            });
+        pattern_constraint
     }
 
     /// Record an expression that needs to be a Salsa ingredient, because we need to infer its type
@@ -650,6 +564,19 @@ impl<'db> SemanticIndexBuilder<'db> {
         self.scope_ids_by_scope.shrink_to_fit();
         self.scopes_by_node.shrink_to_fit();
 
+        // let source_len = source_text(self.db.upcast(), self.file).len();
+        // let expressions = self.scopes_by_expression.len();
+        // let definitions = self.definitions_by_node.len();
+        //
+        // let expression_rel = NonZeroUsize::new(source_len)
+        //     .map(|size| (expressions as f64).div(size.get() as f64))
+        //     .unwrap_or_default();
+        // let definitions_rel = NonZeroUsize::new(source_len)
+        //     .map(|size| (definitions as f64).div(size.get() as f64))
+        //     .unwrap_or_default();
+        //
+        // println!("{source_len},{expressions},{expression_rel},{definitions},{definitions_rel}");
+
         SemanticIndex {
             symbol_tables,
             scopes: self.scopes,
@@ -660,7 +587,6 @@ impl<'db> SemanticIndexBuilder<'db> {
             scopes_by_expression: self.scopes_by_expression,
             scopes_by_node: self.scopes_by_node,
             use_def_maps,
-            imported_modules: Arc::new(self.imported_modules),
             has_future_annotations: self.has_future_annotations,
         }
     }
@@ -764,12 +690,6 @@ where
             }
             ast::Stmt::Import(node) => {
                 for alias in &node.names {
-                    // Mark the imported module, and all of its parents, as being imported in this
-                    // file.
-                    if let Some(module_name) = ModuleName::new(&alias.name) {
-                        self.imported_modules.extend(module_name.ancestors());
-                    }
-
                     let symbol_name = if let Some(asname) = &alias.asname {
                         asname.id.clone()
                     } else {
@@ -824,7 +744,7 @@ where
                                     unsafe {
                                         AstNodeRef::new(self.module.clone(), target)
                                     },
-                                    UnpackValue::Assign(value),
+                                    value,
                                     countme::Count::default(),
                                 )),
                             })
@@ -893,13 +813,10 @@ where
             }
             ast::Stmt::If(node) => {
                 self.visit_expr(&node.test);
-                let mut no_branch_taken = self.flow_snapshot();
-                let mut last_constraint = self.record_expression_constraint(&node.test);
+                let pre_if = self.flow_snapshot();
+                let constraint = self.record_expression_constraint(&node.test);
+                let mut constraints = vec![constraint];
                 self.visit_body(&node.body);
-
-                let visibility_constraint_id = self.record_visibility_constraint(last_constraint);
-                let mut vis_constraints = vec![visibility_constraint_id];
-
                 let mut post_clauses: Vec<FlowSnapshot> = vec![];
                 let elif_else_clauses = node
                     .elif_else_clauses
@@ -921,37 +838,20 @@ where
                     // the state that we merge the other snapshots into
                     post_clauses.push(self.flow_snapshot());
                     // we can only take an elif/else branch if none of the previous ones were
-                    // taken
-                    self.flow_restore(no_branch_taken.clone());
-                    self.record_negated_constraint(last_constraint);
-
-                    let elif_constraint = if let Some(elif_test) = clause_test {
+                    // taken, so the block entry state is always `pre_if`
+                    self.flow_restore(pre_if.clone());
+                    for constraint in &constraints {
+                        self.record_negated_constraint(*constraint);
+                    }
+                    if let Some(elif_test) = clause_test {
                         self.visit_expr(elif_test);
-                        // A test expression is evaluated whether the branch is taken or not
-                        no_branch_taken = self.flow_snapshot();
-                        let constraint = self.record_expression_constraint(elif_test);
-                        Some(constraint)
-                    } else {
-                        None
-                    };
-
+                        constraints.push(self.record_expression_constraint(elif_test));
+                    }
                     self.visit_body(clause_body);
-
-                    for id in &vis_constraints {
-                        self.record_negated_visibility_constraint(*id);
-                    }
-                    if let Some(elif_constraint) = elif_constraint {
-                        last_constraint = elif_constraint;
-                        let id = self.record_visibility_constraint(elif_constraint);
-                        vis_constraints.push(id);
-                    }
                 }
-
                 for post_clause_state in post_clauses {
                     self.flow_merge(post_clause_state);
                 }
-
-                self.simplify_visibility_constraints(no_branch_taken);
             }
             ast::Stmt::While(ast::StmtWhile {
                 test,
@@ -974,8 +874,6 @@ where
                 self.visit_body(body);
                 self.set_inside_loop(outer_loop_state);
 
-                let vis_constraint_id = self.record_visibility_constraint(constraint);
-
                 // Get the break states from the body of this loop, and restore the saved outer
                 // ones.
                 let break_states =
@@ -983,21 +881,15 @@ where
 
                 // We may execute the `else` clause without ever executing the body, so merge in
                 // the pre-loop state before visiting `else`.
-                self.flow_merge(pre_loop.clone());
+                self.flow_merge(pre_loop);
                 self.record_negated_constraint(constraint);
                 self.visit_body(orelse);
-                self.record_negated_visibility_constraint(vis_constraint_id);
 
                 // Breaking out of a while loop bypasses the `else` clause, so merge in the break
                 // states after visiting `else`.
                 for break_state in break_states {
-                    let snapshot = self.flow_snapshot();
-                    self.flow_restore(break_state);
-                    self.record_visibility_constraint(constraint);
-                    self.flow_merge(snapshot);
+                    self.flow_merge(break_state);
                 }
-
-                self.simplify_visibility_constraints(pre_loop);
             }
             ast::Stmt::With(ast::StmtWith {
                 items,
@@ -1035,47 +927,16 @@ where
                     orelse,
                 },
             ) => {
-                debug_assert_eq!(&self.current_assignments, &[]);
-
-                let iter_expr = self.add_standalone_expression(iter);
+                self.add_standalone_expression(iter);
                 self.visit_expr(iter);
 
-                self.record_ambiguous_visibility();
-
                 let pre_loop = self.flow_snapshot();
                 let saved_break_states = std::mem::take(&mut self.loop_break_states);
 
-                let current_assignment = match &**target {
-                    ast::Expr::List(_) | ast::Expr::Tuple(_) => Some(CurrentAssignment::For {
-                        node: for_stmt,
-                        first: true,
-                        unpack: Some(Unpack::new(
-                            self.db,
-                            self.file,
-                            self.current_scope(),
-                            #[allow(unsafe_code)]
-                            unsafe {
-                                AstNodeRef::new(self.module.clone(), target)
-                            },
-                            UnpackValue::Iterable(iter_expr),
-                            countme::Count::default(),
-                        )),
-                    }),
-                    ast::Expr::Name(_) => Some(CurrentAssignment::For {
-                        node: for_stmt,
-                        unpack: None,
-                        first: false,
-                    }),
-                    _ => None,
-                };
-
-                if let Some(current_assignment) = current_assignment {
-                    self.push_assignment(current_assignment);
-                }
+                debug_assert_eq!(&self.current_assignments, &[]);
+                self.push_assignment(for_stmt.into());
                 self.visit_expr(target);
-                if current_assignment.is_some() {
-                    self.pop_assignment();
-                }
+                self.pop_assignment();
 
                 // TODO: Definitions created by loop variables
                 // (and definitions created inside the body)
@@ -1104,61 +965,32 @@ where
                 cases,
                 range: _,
             }) => {
-                debug_assert_eq!(self.current_match_case, None);
-
-                let subject_expr = self.add_standalone_expression(subject);
+                self.add_standalone_expression(subject);
                 self.visit_expr(subject);
-                if cases.is_empty() {
-                    return;
-                };
 
                 let after_subject = self.flow_snapshot();
-                let mut vis_constraints = vec![];
+                let Some((first, remaining)) = cases.split_first() else {
+                    return;
+                };
+                self.add_pattern_constraint(subject, &first.pattern);
+                self.visit_match_case(first);
+
                 let mut post_case_snapshots = vec![];
-                for (i, case) in cases.iter().enumerate() {
-                    if i != 0 {
-                        post_case_snapshots.push(self.flow_snapshot());
-                        self.flow_restore(after_subject.clone());
-                    }
-
-                    self.current_match_case = Some(CurrentMatchCase::new(&case.pattern));
-                    self.visit_pattern(&case.pattern);
-                    self.current_match_case = None;
-                    let constraint_id = self.add_pattern_constraint(
-                        subject_expr,
-                        &case.pattern,
-                        case.guard.as_deref(),
-                    );
-                    if let Some(expr) = &case.guard {
-                        self.visit_expr(expr);
-                    }
-                    self.visit_body(&case.body);
-                    for id in &vis_constraints {
-                        self.record_negated_visibility_constraint(*id);
-                    }
-                    let vis_constraint_id = self.record_visibility_constraint(constraint_id);
-                    vis_constraints.push(vis_constraint_id);
+                for case in remaining {
+                    post_case_snapshots.push(self.flow_snapshot());
+                    self.flow_restore(after_subject.clone());
+                    self.add_pattern_constraint(subject, &case.pattern);
+                    self.visit_match_case(case);
+                }
+                for post_clause_state in post_case_snapshots {
+                    self.flow_merge(post_clause_state);
                 }
-
-                // If there is no final wildcard match case, pretend there is one. This is similar to how
-                // we add an implicit `else` block in if-elif chains, in case it's not present.
                 if !cases
                     .last()
                     .is_some_and(|case| case.guard.is_none() && case.pattern.is_wildcard())
                 {
-                    post_case_snapshots.push(self.flow_snapshot());
-                    self.flow_restore(after_subject.clone());
-
-                    for id in &vis_constraints {
-                        self.record_negated_visibility_constraint(*id);
-                    }
+                    self.flow_merge(after_subject);
                 }
-
-                for post_clause_state in post_case_snapshots {
-                    self.flow_merge(post_clause_state);
-                }
-
-                self.simplify_visibility_constraints(after_subject);
             }
             ast::Stmt::Try(ast::StmtTry {
                 body,
@@ -1168,8 +1000,6 @@ where
                 is_star,
                 range: _,
             }) => {
-                self.record_ambiguous_visibility();
-
                 // Save the state prior to visiting any of the `try` block.
                 //
                 // Potentially none of the `try` block could have been executed prior to executing
@@ -1324,18 +1154,12 @@ where
                         Some(CurrentAssignment::AugAssign(aug_assign)) => {
                             self.add_definition(symbol, aug_assign);
                         }
-                        Some(CurrentAssignment::For {
-                            node,
-                            first,
-                            unpack,
-                        }) => {
+                        Some(CurrentAssignment::For(node)) => {
                             self.add_definition(
                                 symbol,
                                 ForStmtDefinitionNodeRef {
-                                    unpack,
-                                    first,
                                     iterable: &node.iter,
-                                    name: name_node,
+                                    target: name_node,
                                     is_async: node.is_async,
                                 },
                             );
@@ -1371,9 +1195,7 @@ where
                     }
                 }
 
-                if let Some(
-                    CurrentAssignment::Assign { first, .. } | CurrentAssignment::For { first, .. },
-                ) = self.current_assignment_mut()
+                if let Some(CurrentAssignment::Assign { first, .. }) = self.current_assignment_mut()
                 {
                     *first = false;
                 }
@@ -1418,19 +1240,19 @@ where
             ast::Expr::If(ast::ExprIf {
                 body, test, orelse, ..
             }) => {
+                // TODO detect statically known truthy or falsy test (via type inference, not naive
+                // AST inspection, so we can't simplify here, need to record test expression for
+                // later checking)
                 self.visit_expr(test);
                 let pre_if = self.flow_snapshot();
                 let constraint = self.record_expression_constraint(test);
                 self.visit_expr(body);
-                let visibility_constraint = self.record_visibility_constraint(constraint);
                 let post_body = self.flow_snapshot();
-                self.flow_restore(pre_if.clone());
+                self.flow_restore(pre_if);
 
                 self.record_negated_constraint(constraint);
                 self.visit_expr(orelse);
-                self.record_negated_visibility_constraint(visibility_constraint);
                 self.flow_merge(post_body);
-                self.simplify_visibility_constraints(pre_if);
             }
             ast::Expr::ListComp(
                 list_comprehension @ ast::ExprListComp {
@@ -1487,55 +1309,27 @@ where
                 range: _,
                 op,
             }) => {
-                let pre_op = self.flow_snapshot();
-
+                // TODO detect statically known truthy or falsy values (via type inference, not naive
+                // AST inspection, so we can't simplify here, need to record test expression for
+                // later checking)
                 let mut snapshots = vec![];
-                let mut visibility_constraints = vec![];
 
                 for (index, value) in values.iter().enumerate() {
                     self.visit_expr(value);
-
-                    for vid in &visibility_constraints {
-                        self.record_visibility_constraint_id(*vid);
-                    }
-
-                    // For the last value, we don't need to model control flow. There is short-circuiting
-                    // anymore.
+                    // In the last value we don't need to take a snapshot nor add a constraint
                     if index < values.len() - 1 {
-                        let constraint = self.build_constraint(value);
-                        let (constraint, constraint_id) = match op {
-                            ast::BoolOp::And => (constraint, self.add_constraint(constraint)),
-                            ast::BoolOp::Or => self.add_negated_constraint(constraint),
-                        };
-                        let visibility_constraint = self
-                            .add_visibility_constraint(VisibilityConstraint::VisibleIf(constraint));
-
-                        let after_expr = self.flow_snapshot();
-
-                        // We first model the short-circuiting behavior. We take the short-circuit
-                        // path here if all of the previous short-circuit paths were not taken, so
-                        // we record all previously existing visibility constraints, and negate the
-                        // one for the current expression.
-                        for vid in &visibility_constraints {
-                            self.record_visibility_constraint_id(*vid);
-                        }
-                        self.record_negated_visibility_constraint(visibility_constraint);
+                        // Snapshot is taken after visiting the expression but before adding the constraint.
                         snapshots.push(self.flow_snapshot());
-
-                        // Then we model the non-short-circuiting behavior. Here, we need to delay
-                        // the application of the visibility constraint until after the expression
-                        // has been evaluated, so we only push it onto the stack here.
-                        self.flow_restore(after_expr);
-                        self.record_constraint_id(constraint_id);
-                        visibility_constraints.push(visibility_constraint);
+                        let constraint = self.build_constraint(value);
+                        match op {
+                            BoolOp::And => self.record_constraint(constraint),
+                            BoolOp::Or => self.record_negated_constraint(constraint),
+                        }
                     }
                 }
-
                 for snapshot in snapshots {
                     self.flow_merge(snapshot);
                 }
-
-                self.simplify_visibility_constraints(pre_op);
             }
             _ => {
                 walk_expr(self, expr);
@@ -1551,6 +1345,18 @@ where
         }
     }
 
+    fn visit_match_case(&mut self, match_case: &'ast ast::MatchCase) {
+        debug_assert!(self.current_match_case.is_none());
+        self.current_match_case = Some(CurrentMatchCase::new(&match_case.pattern));
+        self.visit_pattern(&match_case.pattern);
+        self.current_match_case = None;
+
+        if let Some(expr) = &match_case.guard {
+            self.visit_expr(expr);
+        }
+        self.visit_body(&match_case.body);
+    }
+
     fn visit_pattern(&mut self, pattern: &'ast ast::Pattern) {
         if let ast::Pattern::MatchStar(ast::PatternMatchStar {
             name: Some(name),
@@ -1603,11 +1409,7 @@ enum CurrentAssignment<'a> {
     },
     AnnAssign(&'a ast::StmtAnnAssign),
     AugAssign(&'a ast::StmtAugAssign),
-    For {
-        node: &'a ast::StmtFor,
-        first: bool,
-        unpack: Option<Unpack<'a>>,
-    },
+    For(&'a ast::StmtFor),
     Named(&'a ast::ExprNamed),
     Comprehension {
         node: &'a ast::Comprehension,
@@ -1631,13 +1433,18 @@ impl<'a> From<&'a ast::StmtAugAssign> for CurrentAssignment<'a> {
     }
 }
 
+impl<'a> From<&'a ast::StmtFor> for CurrentAssignment<'a> {
+    fn from(value: &'a ast::StmtFor) -> Self {
+        Self::For(value)
+    }
+}
+
 impl<'a> From<&'a ast::ExprNamed> for CurrentAssignment<'a> {
     fn from(value: &'a ast::ExprNamed) -> Self {
         Self::Named(value)
     }
 }
 
-#[derive(Debug, PartialEq)]
 struct CurrentMatchCase<'a> {
     /// The pattern that's part of the current match case.
     pattern: &'a ast::Pattern,

crates/red_knot_python_semantic/src/semantic_index/constraint.rs

@@ -1,6 +1,7 @@
 use ruff_db::files::File;
-use ruff_python_ast::Singleton;
+use ruff_python_ast as ast;
 
+use crate::ast_node_ref::AstNodeRef;
 use crate::db::Db;
 use crate::semantic_index::expression::Expression;
 use crate::semantic_index::symbol::{FileScopeId, ScopeId};
@@ -17,15 +18,6 @@ pub(crate) enum ConstraintNode<'db> {
     Pattern(PatternConstraint<'db>),
 }
 
-/// Pattern kinds for which we support type narrowing and/or static visibility analysis.
-#[derive(Debug, Clone, PartialEq)]
-pub(crate) enum PatternConstraintKind<'db> {
-    Singleton(Singleton, Option<Expression<'db>>),
-    Value(Expression<'db>, Option<Expression<'db>>),
-    Class(Expression<'db>, Option<Expression<'db>>),
-    Unsupported,
-}
-
 #[salsa::tracked]
 pub(crate) struct PatternConstraint<'db> {
     #[id]
@@ -36,11 +28,11 @@ pub(crate) struct PatternConstraint<'db> {
 
     #[no_eq]
     #[return_ref]
-    pub(crate) subject: Expression<'db>,
+    pub(crate) subject: AstNodeRef<ast::Expr>,
 
     #[no_eq]
     #[return_ref]
-    pub(crate) kind: PatternConstraintKind<'db>,
+    pub(crate) pattern: AstNodeRef<ast::Pattern>,
 
     #[no_eq]
     count: countme::Count<PatternConstraint<'static>>,

crates/red_knot_python_semantic/src/semantic_index/definition.rs

@@ -8,7 +8,7 @@ use crate::module_resolver::file_to_module;
 use crate::node_key::NodeKey;
 use crate::semantic_index::symbol::{FileScopeId, ScopeId, ScopedSymbolId};
 use crate::unpack::Unpack;
-use crate::{Db, KnownModule};
+use crate::Db;
 
 /// A definition of a symbol.
 ///
@@ -63,21 +63,17 @@ impl<'db> Definition<'db> {
     }
 
     pub(crate) fn is_builtin_definition(self, db: &'db dyn Db) -> bool {
-        file_to_module(db, self.file(db))
-            .is_some_and(|module| module.is_known(KnownModule::Builtins))
+        file_to_module(db, self.file(db)).is_some_and(|module| {
+            module.search_path().is_standard_library() && matches!(&**module.name(), "builtins")
+        })
     }
 
     /// Return true if this symbol was defined in the `typing` or `typing_extensions` modules
     pub(crate) fn is_typing_definition(self, db: &'db dyn Db) -> bool {
-        matches!(
-            file_to_module(db, self.file(db)).and_then(|module| module.known()),
-            Some(KnownModule::Typing | KnownModule::TypingExtensions)
-        )
-    }
-
-    pub(crate) fn is_knot_extensions_definition(self, db: &'db dyn Db) -> bool {
-        file_to_module(db, self.file(db))
-            .is_some_and(|module| module.is_known(KnownModule::KnotExtensions))
+        file_to_module(db, self.file(db)).is_some_and(|module| {
+            module.search_path().is_standard_library()
+                && matches!(&**module.name(), "typing" | "typing_extensions")
+        })
     }
 }
 
@@ -230,10 +226,8 @@ pub(crate) struct WithItemDefinitionNodeRef<'a> {
 
 #[derive(Copy, Clone, Debug)]
 pub(crate) struct ForStmtDefinitionNodeRef<'a> {
-    pub(crate) unpack: Option<Unpack<'a>>,
     pub(crate) iterable: &'a ast::Expr,
-    pub(crate) name: &'a ast::ExprName,
-    pub(crate) first: bool,
+    pub(crate) target: &'a ast::ExprName,
     pub(crate) is_async: bool,
 }
 
@@ -305,16 +299,12 @@ impl<'db> DefinitionNodeRef<'db> {
                 DefinitionKind::AugmentedAssignment(AstNodeRef::new(parsed, augmented_assignment))
             }
             DefinitionNodeRef::For(ForStmtDefinitionNodeRef {
-                unpack,
                 iterable,
-                name,
-                first,
+                target,
                 is_async,
             }) => DefinitionKind::For(ForStmtDefinitionKind {
-                target: TargetKind::from(unpack),
                 iterable: AstNodeRef::new(parsed.clone(), iterable),
-                name: AstNodeRef::new(parsed, name),
-                first,
+                target: AstNodeRef::new(parsed, target),
                 is_async,
             }),
             DefinitionNodeRef::Comprehension(ComprehensionDefinitionNodeRef {
@@ -393,12 +383,10 @@ impl<'db> DefinitionNodeRef<'db> {
             Self::AnnotatedAssignment(node) => node.into(),
             Self::AugmentedAssignment(node) => node.into(),
             Self::For(ForStmtDefinitionNodeRef {
-                unpack: _,
                 iterable: _,
-                name,
-                first: _,
+                target,
                 is_async: _,
-            }) => name.into(),
+            }) => target.into(),
             Self::Comprehension(ComprehensionDefinitionNodeRef { target, .. }) => target.into(),
             Self::VariadicPositionalParameter(node) => node.into(),
             Self::VariadicKeywordParameter(node) => node.into(),
@@ -465,7 +453,7 @@ pub enum DefinitionKind<'db> {
     Assignment(AssignmentDefinitionKind<'db>),
     AnnotatedAssignment(AstNodeRef<ast::StmtAnnAssign>),
     AugmentedAssignment(AstNodeRef<ast::StmtAugAssign>),
-    For(ForStmtDefinitionKind<'db>),
+    For(ForStmtDefinitionKind),
     Comprehension(ComprehensionDefinitionKind),
     VariadicPositionalParameter(AstNodeRef<ast::Parameter>),
     VariadicKeywordParameter(AstNodeRef<ast::Parameter>),
@@ -478,14 +466,8 @@ pub enum DefinitionKind<'db> {
     TypeVarTuple(AstNodeRef<ast::TypeParamTypeVarTuple>),
 }
 
-impl DefinitionKind<'_> {
-    /// Returns the [`TextRange`] of the definition target.
-    ///
-    /// A definition target would mainly be the node representing the symbol being defined i.e.,
-    /// [`ast::ExprName`] or [`ast::Identifier`] but could also be other nodes.
-    ///
-    /// This is mainly used for logging and debugging purposes.
-    pub(crate) fn target_range(&self) -> TextRange {
+impl Ranged for DefinitionKind<'_> {
+    fn range(&self) -> TextRange {
         match self {
             DefinitionKind::Import(alias) => alias.range(),
             DefinitionKind::ImportFrom(import) => import.alias().range(),
@@ -496,7 +478,7 @@ impl DefinitionKind<'_> {
             DefinitionKind::Assignment(assignment) => assignment.name().range(),
             DefinitionKind::AnnotatedAssignment(assign) => assign.target.range(),
             DefinitionKind::AugmentedAssignment(aug_assign) => aug_assign.target.range(),
-            DefinitionKind::For(for_stmt) => for_stmt.name().range(),
+            DefinitionKind::For(for_stmt) => for_stmt.target().range(),
             DefinitionKind::Comprehension(comp) => comp.target().range(),
             DefinitionKind::VariadicPositionalParameter(parameter) => parameter.name.range(),
             DefinitionKind::VariadicKeywordParameter(parameter) => parameter.name.range(),
@@ -509,7 +491,9 @@ impl DefinitionKind<'_> {
             DefinitionKind::TypeVarTuple(type_var_tuple) => type_var_tuple.name.range(),
         }
     }
+}
 
+impl DefinitionKind<'_> {
     pub(crate) fn category(&self) -> DefinitionCategory {
         match self {
             // functions, classes, and imports always bind, and we consider them declarations
@@ -682,32 +666,22 @@ impl WithItemDefinitionKind {
 }
 
 #[derive(Clone, Debug)]
-pub struct ForStmtDefinitionKind<'db> {
-    target: TargetKind<'db>,
+pub struct ForStmtDefinitionKind {
     iterable: AstNodeRef<ast::Expr>,
-    name: AstNodeRef<ast::ExprName>,
-    first: bool,
+    target: AstNodeRef<ast::ExprName>,
     is_async: bool,
 }
 
-impl<'db> ForStmtDefinitionKind<'db> {
+impl ForStmtDefinitionKind {
     pub(crate) fn iterable(&self) -> &ast::Expr {
         self.iterable.node()
     }
 
-    pub(crate) fn target(&self) -> TargetKind<'db> {
-        self.target
+    pub(crate) fn target(&self) -> &ast::ExprName {
+        self.target.node()
     }
 
-    pub(crate) fn name(&self) -> &ast::ExprName {
-        self.name.node()
-    }
-
-    pub(crate) const fn is_first(&self) -> bool {
-        self.first
-    }
-
-    pub(crate) const fn is_async(&self) -> bool {
+    pub(crate) fn is_async(&self) -> bool {
         self.is_async
     }
 }
@@ -783,6 +757,12 @@ impl From<&ast::StmtAugAssign> for DefinitionNodeKey {
     }
 }
 
+impl From<&ast::StmtFor> for DefinitionNodeKey {
+    fn from(value: &ast::StmtFor) -> Self {
+        Self(NodeKey::from_node(value))
+    }
+}
+
 impl From<&ast::Parameter> for DefinitionNodeKey {
     fn from(node: &ast::Parameter) -> Self {
         Self(NodeKey::from_node(node))