suggestions from code review

.github/workflows/ci.yaml

@@ -250,7 +250,7 @@ jobs:
       - name: "Install Rust toolchain"
         run: rustup show
       - name: "Install mold"
-        uses: rui314/setup-mold@725a8794d15fc7563f59595bd9556495c0564878 # v1
+        uses: rui314/setup-mold@7344740a9418dcdcb481c7df83d9fbd1d5072d7d # v1
       - name: "Install cargo nextest"
         uses: taiki-e/install-action@6064345e6658255e90e9500fdf9a06ab77e6909c # v2.57.6
         with:
@@ -259,10 +259,6 @@ jobs:
         uses: taiki-e/install-action@6064345e6658255e90e9500fdf9a06ab77e6909c # v2.57.6
         with:
           tool: cargo-insta
-      - name: "Install uv"
-        uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
-        with:
-          enable-cache: "true"
       - name: ty mdtests (GitHub annotations)
         if: ${{ needs.determine_changes.outputs.ty == 'true' }}
         env:
@@ -312,7 +308,7 @@ jobs:
       - name: "Install Rust toolchain"
         run: rustup show
       - name: "Install mold"
-        uses: rui314/setup-mold@725a8794d15fc7563f59595bd9556495c0564878 # v1
+        uses: rui314/setup-mold@7344740a9418dcdcb481c7df83d9fbd1d5072d7d # v1
       - name: "Install cargo nextest"
         uses: taiki-e/install-action@6064345e6658255e90e9500fdf9a06ab77e6909c # v2.57.6
         with:
@@ -321,10 +317,6 @@ jobs:
         uses: taiki-e/install-action@6064345e6658255e90e9500fdf9a06ab77e6909c # v2.57.6
         with:
           tool: cargo-insta
-      - name: "Install uv"
-        uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
-        with:
-          enable-cache: "true"
       - name: "Run tests"
         shell: bash
         env:
@@ -348,10 +340,6 @@ jobs:
         uses: taiki-e/install-action@6064345e6658255e90e9500fdf9a06ab77e6909c # v2.57.6
         with:
           tool: cargo-nextest
-      - name: "Install uv"
-        uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
-        with:
-          enable-cache: "true"
       - name: "Run tests"
         shell: bash
         env:
@@ -405,7 +393,7 @@ jobs:
       - name: "Install Rust toolchain"
         run: rustup show
       - name: "Install mold"
-        uses: rui314/setup-mold@725a8794d15fc7563f59595bd9556495c0564878 # v1
+        uses: rui314/setup-mold@7344740a9418dcdcb481c7df83d9fbd1d5072d7d # v1
       - name: "Build"
         run: cargo build --release --locked
 
@@ -430,7 +418,7 @@ jobs:
           MSRV: ${{ steps.msrv.outputs.value }}
         run: rustup default "${MSRV}"
       - name: "Install mold"
-        uses: rui314/setup-mold@725a8794d15fc7563f59595bd9556495c0564878 # v1
+        uses: rui314/setup-mold@7344740a9418dcdcb481c7df83d9fbd1d5072d7d # v1
       - name: "Build tests"
         shell: bash
         env:
@@ -453,7 +441,9 @@ jobs:
       - name: "Install Rust toolchain"
         run: rustup show
       - name: "Install cargo-binstall"
-        uses: cargo-bins/cargo-binstall@837578dfb436769f1e6669b2e23ffea9d9d2da8f # v1.15.4
+        uses: cargo-bins/cargo-binstall@79e4beb1e02f733a26129a6bf26c37dab4ab3307 # v1.14.4
+        with:
+          tool: cargo-fuzz@0.11.2
       - name: "Install cargo-fuzz"
         # Download the latest version from quick install and not the github releases because github releases only has MUSL targets.
         run: cargo binstall cargo-fuzz --force  --disable-strategies crate-meta-data --no-confirm
@@ -473,7 +463,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           persist-credentials: false
-      - uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+      - uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
       - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
         name: Download Ruff binary to test
         id: download-cached-binary
@@ -674,7 +664,7 @@ jobs:
           branch: ${{ github.event.pull_request.base.ref }}
           workflow: "ci.yaml"
           check_artifacts: true
-      - uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+      - uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
       - name: Fuzz
         env:
           FORCE_COLOR: 1
@@ -704,7 +694,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           persist-credentials: false
-      - uses: cargo-bins/cargo-binstall@837578dfb436769f1e6669b2e23ffea9d9d2da8f # v1.15.4
+      - uses: cargo-bins/cargo-binstall@79e4beb1e02f733a26129a6bf26c37dab4ab3307 # v1.14.4
       - run: cargo binstall --no-confirm cargo-shear
       - run: cargo shear
 
@@ -744,7 +734,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           persist-credentials: false
-      - uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+      - uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
       - uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0 # v2.8.0
       - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
         with:
@@ -787,7 +777,7 @@ jobs:
       - name: "Install Rust toolchain"
         run: rustup show
       - name: Install uv
-        uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+        uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
       - name: "Install Insiders dependencies"
         if: ${{ env.MKDOCS_INSIDERS_SSH_KEY_EXISTS == 'true' }}
         run: uv pip install -r docs/requirements-insiders.txt --system
@@ -919,7 +909,7 @@ jobs:
           persist-credentials: false
 
       - uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0 # v2.8.0
-      - uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+      - uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
 
       - name: "Install Rust toolchain"
         run: rustup show
@@ -933,7 +923,7 @@ jobs:
         run: cargo codspeed build --features "codspeed,instrumented" --no-default-features -p ruff_benchmark
 
       - name: "Run benchmarks"
-        uses: CodSpeedHQ/action@76578c2a7ddd928664caa737f0e962e3085d4e7c # v3.8.1
+        uses: CodSpeedHQ/action@0b6e7a3d96c9d2a6057e7bcea6b45aaf2f7ce60b # v3.8.0
         with:
           run: cargo codspeed run
           token: ${{ secrets.CODSPEED_TOKEN }}
@@ -952,7 +942,7 @@ jobs:
           persist-credentials: false
 
       - uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0 # v2.8.0
-      - uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+      - uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
 
       - name: "Install Rust toolchain"
         run: rustup show
@@ -966,7 +956,7 @@ jobs:
         run: cargo codspeed build --features "codspeed,walltime" --no-default-features -p ruff_benchmark
 
       - name: "Run benchmarks"
-        uses: CodSpeedHQ/action@76578c2a7ddd928664caa737f0e962e3085d4e7c # v3.8.1
+        uses: CodSpeedHQ/action@0b6e7a3d96c9d2a6057e7bcea6b45aaf2f7ce60b # v3.8.0
         with:
           run: cargo codspeed run
           token: ${{ secrets.CODSPEED_TOKEN }}

.github/workflows/daily_fuzz.yaml

@@ -34,11 +34,11 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           persist-credentials: false
-      - uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+      - uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
       - name: "Install Rust toolchain"
         run: rustup show
       - name: "Install mold"
-        uses: rui314/setup-mold@725a8794d15fc7563f59595bd9556495c0564878 # v1
+        uses: rui314/setup-mold@7344740a9418dcdcb481c7df83d9fbd1d5072d7d # v1
       - uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0 # v2.8.0
       - name: Build ruff
         # A debug build means the script runs slower once it gets started,

.github/workflows/mypy_primer.yaml

@@ -39,7 +39,7 @@ jobs:
           persist-credentials: false
 
       - name: Install the latest version of uv
-        uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+        uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
 
       - uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0 # v2.8.0
         with:
@@ -82,7 +82,7 @@ jobs:
           persist-credentials: false
 
       - name: Install the latest version of uv
-        uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+        uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
 
       - uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0 # v2.8.0
         with:

.github/workflows/publish-pypi.yml

@@ -22,7 +22,7 @@ jobs:
       id-token: write
     steps:
       - name: "Install uv"
-        uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+        uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
       - uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
         with:
           pattern: wheels-*

.github/workflows/release.yml

@@ -61,7 +61,7 @@ jobs:
     env:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     steps:
-      - uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
         with:
           persist-credentials: false
           submodules: recursive
@@ -124,7 +124,7 @@ jobs:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       BUILD_MANIFEST_NAME: target/distrib/global-dist-manifest.json
     steps:
-      - uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
         with:
           persist-credentials: false
           submodules: recursive
@@ -175,7 +175,7 @@ jobs:
     outputs:
       val: ${{ steps.host.outputs.manifest }}
     steps:
-      - uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
         with:
           persist-credentials: false
           submodules: recursive
@@ -251,7 +251,7 @@ jobs:
     env:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     steps:
-      - uses: actions/checkout@ff7abcd0c3c05ccf6adc123a8cd1fd4fb30fb493
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
         with:
           persist-credentials: false
           submodules: recursive

.github/workflows/sync_typeshed.yaml

@@ -65,7 +65,7 @@ jobs:
         run: |
           git config --global user.name typeshedbot
           git config --global user.email '<>'
-      - uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+      - uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
       - name: Sync typeshed stubs
         run: |
           rm -rf "ruff/${VENDORED_TYPESHED}"
@@ -117,7 +117,7 @@ jobs:
         with:
           persist-credentials: true
           ref: ${{ env.UPSTREAM_BRANCH}}
-      - uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+      - uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
       - name: Setup git
         run: |
           git config --global user.name typeshedbot
@@ -155,7 +155,7 @@ jobs:
         with:
           persist-credentials: true
           ref: ${{ env.UPSTREAM_BRANCH}}
-      - uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+      - uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
       - name: Setup git
         run: |
           git config --global user.name typeshedbot

.github/workflows/ty-ecosystem-analyzer.yaml

@@ -33,7 +33,7 @@ jobs:
           persist-credentials: false
 
       - name: Install the latest version of uv
-        uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+        uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
 
       - uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0 # v2.8.0
         with:
@@ -64,12 +64,11 @@ jobs:
 
           cd ..
 
-          uv tool install "git+https://github.com/astral-sh/ecosystem-analyzer@1f560d07d672effae250e3d271da53d96c5260ff"
+          uv tool install "git+https://github.com/astral-sh/ecosystem-analyzer@27dd66d9e397d986ef9c631119ee09556eab8af9"
 
           ecosystem-analyzer \
             --repository ruff \
             diff \
-            --profile=release \
             --projects-old ruff/projects_old.txt \
             --projects-new ruff/projects_new.txt \
             --old old_commit \

.github/workflows/ty-ecosystem-report.yaml

@@ -29,7 +29,7 @@ jobs:
           persist-credentials: false
 
       - name: Install the latest version of uv
-        uses: astral-sh/setup-uv@557e51de59eb14aaaba2ed9621916900a91d50c6 # v6.6.1
+        uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
 
       - uses: Swatinem/rust-cache@98c8021b550208e191a6a3145459bfc9fb29c4c0 # v2.8.0
         with:

CHANGELOG.md

@@ -1,60 +1,5 @@
 # Changelog
 
-## 0.12.12
-
-### Preview features
-
-- Show fixes by default ([#19919](https://github.com/astral-sh/ruff/pull/19919))
-- \[`airflow`\] Convert `DatasetOrTimeSchedule(datasets=...)` to `AssetOrTimeSchedule(assets=...)` (`AIR311`) ([#20202](https://github.com/astral-sh/ruff/pull/20202))
-- \[`airflow`\] Improve the `AIR002` error message ([#20173](https://github.com/astral-sh/ruff/pull/20173))
-- \[`airflow`\] Move `airflow.operators.postgres_operator.Mapping` from `AIR302` to `AIR301` ([#20172](https://github.com/astral-sh/ruff/pull/20172))
-- \[`flake8-async`\] Implement `blocking-input` rule (`ASYNC250`) ([#20122](https://github.com/astral-sh/ruff/pull/20122))
-- \[`flake8-use-pathlib`\] Make `PTH119` and `PTH120` fixes unsafe because they can change behavior ([#20118](https://github.com/astral-sh/ruff/pull/20118))
-- \[`pylint`\] Add U+061C to `PLE2502` ([#20106](https://github.com/astral-sh/ruff/pull/20106))
-- \[`ruff`\] Fix false negative for empty f-strings in `deque` calls (`RUF037`) ([#20109](https://github.com/astral-sh/ruff/pull/20109))
-
-### Bug fixes
-
-- Less confidently mark f-strings as empty when inferring truthiness ([#20152](https://github.com/astral-sh/ruff/pull/20152))
-- \[`fastapi`\] Fix false positive for paths with spaces around parameters (`FAST003`) ([#20077](https://github.com/astral-sh/ruff/pull/20077))
-- \[`flake8-comprehensions`\] Skip `C417` when lambda contains `yield`/`yield from` ([#20201](https://github.com/astral-sh/ruff/pull/20201))
-- \[`perflint`\] Handle tuples in dictionary comprehensions (`PERF403`) ([#19934](https://github.com/astral-sh/ruff/pull/19934))
-
-### Rule changes
-
-- \[`pycodestyle`\] Preserve return type annotation for `ParamSpec` (`E731`) ([#20108](https://github.com/astral-sh/ruff/pull/20108))
-
-### Documentation
-
-- Add fix safety sections to docs ([#17490](https://github.com/astral-sh/ruff/pull/17490),[#17499](https://github.com/astral-sh/ruff/pull/17499))
-
-## 0.12.11
-
-### Preview features
-
-- \[`airflow`\] Extend `AIR311` and `AIR312` rules ([#20082](https://github.com/astral-sh/ruff/pull/20082))
-- \[`airflow`\] Replace wrong path `airflow.io.storage` with `airflow.io.store` (`AIR311`) ([#20081](https://github.com/astral-sh/ruff/pull/20081))
-- \[`flake8-async`\] Implement `blocking-http-call-httpx-in-async-function` (`ASYNC212`) ([#20091](https://github.com/astral-sh/ruff/pull/20091))
-- \[`flake8-logging-format`\] Add auto-fix for f-string logging calls (`G004`) ([#19303](https://github.com/astral-sh/ruff/pull/19303))
-- \[`flake8-use-pathlib`\] Add autofix for `PTH211` ([#20009](https://github.com/astral-sh/ruff/pull/20009))
-- \[`flake8-use-pathlib`\] Make `PTH100` fix unsafe because it can change behavior ([#20100](https://github.com/astral-sh/ruff/pull/20100))
-
-### Bug fixes
-
-- \[`pyflakes`, `pylint`\] Fix false positives caused by `__class__` cell handling (`F841`, `PLE0117`) ([#20048](https://github.com/astral-sh/ruff/pull/20048))
-- \[`pyflakes`\] Fix `allowed-unused-imports` matching for top-level modules (`F401`) ([#20115](https://github.com/astral-sh/ruff/pull/20115))
-- \[`ruff`\] Fix false positive for t-strings in `default-factory-kwarg` (`RUF026`) ([#20032](https://github.com/astral-sh/ruff/pull/20032))
-- \[`ruff`\] Preserve relative whitespace in multi-line expressions (`RUF033`) ([#19647](https://github.com/astral-sh/ruff/pull/19647))
-
-### Rule changes
-
-- \[`ruff`\] Handle empty t-strings in `unnecessary-empty-iterable-within-deque-call` (`RUF037`) ([#20045](https://github.com/astral-sh/ruff/pull/20045))
-
-### Documentation
-
-- Fix incorrect `D413` links in docstrings convention FAQ ([#20089](https://github.com/astral-sh/ruff/pull/20089))
-- \[`flake8-use-pathlib`\] Update links to the table showing the correspondence between `os` and `pathlib` ([#20103](https://github.com/astral-sh/ruff/pull/20103))
-
 ## 0.12.10
 
 ### Preview features

Cargo.toml

@@ -57,8 +57,8 @@ anyhow = { version = "1.0.80" }
 arc-swap = { version = "1.7.1" }
 assert_fs = { version = "1.1.0" }
 argfile = { version = "0.2.0" }
-bincode = { version = "2.0.0" }
-bitflags = { version = "2.5.0" }
+bincode = { version = "2.0.0", features = ["serde"] }
+bitflags = { version = "2.5.0", features = ["serde"] }
 bitvec = { version = "1.0.1", default-features = false, features = [
     "alloc",
 ] }
@@ -115,7 +115,7 @@ jiff = { version = "0.2.0" }
 js-sys = { version = "0.3.69" }
 jod-thread = { version = "1.0.0" }
 libc = { version = "0.2.153" }
-libcst = { version = "1.8.4", default-features = false }
+libcst = { version = "1.1.0", default-features = false }
 log = { version = "0.4.17" }
 lsp-server = { version = "0.7.6" }
 lsp-types = { git = "https://github.com/astral-sh/lsp-types.git", rev = "3512a9f", features = [
@@ -126,7 +126,7 @@ memchr = { version = "2.7.1" }
 mimalloc = { version = "0.1.39" }
 natord = { version = "1.0.9" }
 notify = { version = "8.0.0" }
-ordermap = { version = "0.5.0" }
+ordermap = { version = "0.5.0", features = ["serde"] }
 path-absolutize = { version = "3.1.1" }
 path-slash = { version = "0.2.1" }
 pathdiff = { version = "0.2.1" }
@@ -143,24 +143,25 @@ regex-automata = { version = "0.4.9" }
 rustc-hash = { version = "2.0.0" }
 rustc-stable-hash = { version = "0.1.2" }
 # When updating salsa, make sure to also update the revision in `fuzz/Cargo.toml`
-salsa = { git = "https://github.com/salsa-rs/salsa.git", rev = "a3ffa22cb26756473d56f867aedec3fd907c4dd9", default-features = false, features = [
+salsa = { git = "https://github.com/salsa-rs/salsa.git", rev = "a0e7a06", default-features = false, features = [
     "compact_str",
     "macros",
     "salsa_unstable",
     "inventory",
+    "persistence",
 ] }
 schemars = { version = "0.8.16" }
 seahash = { version = "4.1.0" }
-serde = { version = "1.0.197", features = ["derive"] }
+serde = { version = "1.0.197", features = ["derive", "rc"] }
 serde-wasm-bindgen = { version = "0.6.4" }
-serde_json = { version = "1.0.113" }
+serde_json = { version = "1.0.142" }
 serde_test = { version = "1.0.152" }
 serde_with = { version = "3.6.0", default-features = false, features = [
     "macros",
 ] }
 shellexpand = { version = "3.0.0" }
 similar = { version = "2.4.0", features = ["inline"] }
-smallvec = { version = "1.13.2", features = ["union", "const_generics", "const_new"] }
+smallvec = { version = "1.13.2", features = ["union", "const_generics", "const_new", "serde"] }
 snapbox = { version = "0.6.0", features = [
     "diff",
     "term-svg",
@@ -251,14 +252,6 @@ rest_pat_in_fully_bound_structs = "warn"
 redundant_clone = "warn"
 debug_assert_with_mut_call = "warn"
 unused_peekable = "warn"
-# This lint sometimes flags code whose `if` and `else`
-# bodies could be flipped when a `!` operator is removed.
-# While perhaps sometimes a good idea, it is also often
-# not a good idea due to other factors impacting
-# readability. For example, if flipping the bodies results
-# in the `if` being an order of magnitude bigger than the
-# `else`, then some might consider that harder to read.
-if_not_else = "allow"
 
 # Diagnostics are not actionable: Enable once https://github.com/rust-lang/rust-clippy/issues/13774 is resolved.
 large_stack_arrays = "allow"

README.md

@@ -148,8 +148,8 @@ curl -LsSf https://astral.sh/ruff/install.sh | sh
 powershell -c "irm https://astral.sh/ruff/install.ps1 | iex"
 
 # For a specific version.
-curl -LsSf https://astral.sh/ruff/0.12.12/install.sh | sh
-powershell -c "irm https://astral.sh/ruff/0.12.12/install.ps1 | iex"
+curl -LsSf https://astral.sh/ruff/0.12.10/install.sh | sh
+powershell -c "irm https://astral.sh/ruff/0.12.10/install.ps1 | iex"
 ```
 
 You can also install Ruff via [Homebrew](https://formulae.brew.sh/formula/ruff), [Conda](https://anaconda.org/conda-forge/ruff),
@@ -182,7 +182,7 @@ Ruff can also be used as a [pre-commit](https://pre-commit.com/) hook via [`ruff
 ```yaml
 - repo: https://github.com/astral-sh/ruff-pre-commit
   # Ruff version.
-  rev: v0.12.12
+  rev: v0.12.10
   hooks:
     # Run the linter.
     - id: ruff-check

crates/ruff/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ruff"
-version = "0.12.12"
+version = "0.12.10"
 publish = true
 authors = { workspace = true }
 edition = { workspace = true }
@@ -31,7 +31,7 @@ ruff_workspace = { workspace = true }
 
 anyhow = { workspace = true }
 argfile = { workspace = true }
-bincode = { workspace = true, features = ["serde"] }
+bincode = { workspace = true }
 bitflags = { workspace = true }
 cachedir = { workspace = true }
 clap = { workspace = true, features = ["derive", "env", "wrap_help"] }

crates/ruff/src/printer.rs

@@ -15,7 +15,8 @@ use ruff_db::diagnostic::{
 use ruff_linter::fs::relativize_path;
 use ruff_linter::logging::LogLevel;
 use ruff_linter::message::{
-    Emitter, EmitterContext, GithubEmitter, GroupedEmitter, SarifEmitter, TextEmitter,
+    Emitter, EmitterContext, GithubEmitter, GitlabEmitter, GroupedEmitter, SarifEmitter,
+    TextEmitter,
 };
 use ruff_linter::notify_user;
 use ruff_linter::settings::flags::{self};
@@ -30,6 +31,8 @@ bitflags! {
         const SHOW_VIOLATIONS = 1 << 0;
         /// Whether to show a summary of the fixed violations when emitting diagnostics.
         const SHOW_FIX_SUMMARY = 1 << 1;
+        /// Whether to show a diff of each fixed violation when emitting diagnostics.
+        const SHOW_FIX_DIFF = 1 << 2;
     }
 }
 
@@ -258,9 +261,9 @@ impl Printer {
             OutputFormat::Concise | OutputFormat::Full => {
                 TextEmitter::default()
                     .with_show_fix_status(show_fix_status(self.fix_mode, fixables.as_ref()))
-                    .with_show_fix_diff(self.format == OutputFormat::Full && preview)
+                    .with_show_fix_diff(self.flags.intersects(Flags::SHOW_FIX_DIFF))
                     .with_show_source(self.format == OutputFormat::Full)
-                    .with_fix_applicability(self.unsafe_fixes.required_applicability())
+                    .with_unsafe_fixes(self.unsafe_fixes)
                     .with_preview(preview)
                     .emit(writer, &diagnostics.inner, &context)?;
 
@@ -293,11 +296,7 @@ impl Printer {
                 GithubEmitter.emit(writer, &diagnostics.inner, &context)?;
             }
             OutputFormat::Gitlab => {
-                let config = DisplayDiagnosticConfig::default()
-                    .format(DiagnosticFormat::Gitlab)
-                    .preview(preview);
-                let value = DisplayDiagnostics::new(&context, &config, &diagnostics.inner);
-                write!(writer, "{value}")?;
+                GitlabEmitter::default().emit(writer, &diagnostics.inner, &context)?;
             }
             OutputFormat::Pylint => {
                 let config = DisplayDiagnosticConfig::default()
@@ -462,7 +461,7 @@ impl Printer {
             TextEmitter::default()
                 .with_show_fix_status(show_fix_status(self.fix_mode, fixables.as_ref()))
                 .with_show_source(preview)
-                .with_fix_applicability(self.unsafe_fixes.required_applicability())
+                .with_unsafe_fixes(self.unsafe_fixes)
                 .emit(writer, &diagnostics.inner, &context)?;
         }
         writer.flush()?;

crates/ruff/tests/integration_test.rs

@@ -1489,8 +1489,6 @@ fn deprecated_direct() {
 
 #[test]
 fn deprecated_multiple_direct() {
-    // Multiple deprecated rules selected by exact code should be included
-    // but a warning should be displayed
     let mut cmd = RuffCheck::default()
         .args(["--select", "RUF920", "--select", "RUF921"])
         .build();
@@ -1518,10 +1516,16 @@ fn deprecated_indirect() {
     // since it is not a "direct" selection
     let mut cmd = RuffCheck::default().args(["--select", "RUF92"]).build();
     assert_cmd_snapshot!(cmd, @r"
-    success: true
-    exit_code: 0
+    success: false
+    exit_code: 1
     ----- stdout -----
-    All checks passed!
+    RUF920 Hey this is a deprecated test rule.
+    --> -:1:1
+
+    RUF921 Hey this is another deprecated test rule.
+    --> -:1:1
+
+    Found 2 errors.
 
     ----- stderr -----
     ");
@@ -2151,10 +2155,16 @@ extend-safe-fixes = ["RUF9"]
     RUF903 Hey this is a stable test rule with a display only fix.
     --> -:1:1
 
+    RUF920 Hey this is a deprecated test rule.
+    --> -:1:1
+
+    RUF921 Hey this is another deprecated test rule.
+    --> -:1:1
+
     RUF950 Hey this is a test rule that was redirected from another.
     --> -:1:1
 
-    Found 5 errors.
+    Found 7 errors.
     [*] 1 fixable with the `--fix` option (1 hidden fix can be enabled with the `--unsafe-fixes` option).
 
     ----- stderr -----

crates/ruff/tests/lint.rs

@@ -5780,6 +5780,28 @@ match 42:  # invalid-syntax
     Ok(())
 }
 
+#[test]
+fn future_annotations_preview_warning() {
+    assert_cmd_snapshot!(
+        Command::new(get_cargo_bin(BIN_NAME))
+            .args(STDIN_BASE_OPTIONS)
+            .args(["--config", "lint.future-annotations = true"])
+            .args(["--select", "F"])
+            .arg("--no-preview")
+            .arg("-")
+            .pass_stdin("1"),
+        @r"
+    success: true
+    exit_code: 0
+    ----- stdout -----
+    All checks passed!
+
+    ----- stderr -----
+    warning: The `lint.future-annotations` setting will have no effect because `preview` is disabled
+    ",
+    );
+}
+
 #[test]
 fn up045_nested_optional_flatten_all() {
     let contents = "\
@@ -5808,33 +5830,3 @@ nested_optional: Optional[Optional[Optional[str]]] = None
     ",
     );
 }
-
-#[test]
-fn show_fixes_in_full_output_with_preview_enabled() {
-    assert_cmd_snapshot!(
-        Command::new(get_cargo_bin(BIN_NAME))
-            .args(["check", "--no-cache", "--output-format", "full"])
-            .args(["--select", "F401"])
-            .arg("--preview")
-            .arg("-")
-            .pass_stdin("import math"),
-        @r"
-    success: false
-    exit_code: 1
-    ----- stdout -----
-    F401 [*] `math` imported but unused
-     --> -:1:8
-      |
-    1 | import math
-      |        ^^^^
-      |
-    help: Remove unused import: `math`
-      - import math
-
-    Found 1 error.
-    [*] 1 fixable with the `--fix` option.
-
-    ----- stderr -----
-    ",
-    );
-}

crates/ruff/tests/snapshots/integration_test__rule_f401.snap

@@ -55,10 +55,6 @@ either a redundant alias or, if already present in the file, an `__all__` entry.
 to remove third-party and standard library imports -- the fix is unsafe because the module's
 interface changes.
 
-See [this FAQ section](https://docs.astral.sh/ruff/faq/#how-does-ruff-determine-which-of-my-imports-are-first-party-third-party-etc)
-for more details on how Ruff
-determines whether an import is first or third-party.
-
 ## Example
 
 ```python
@@ -87,6 +83,11 @@ else:
     print("numpy is not installed")
 ```
 
+## Preview
+When [preview](https://docs.astral.sh/ruff/preview/) is enabled,
+the criterion for determining whether an import is first-party
+is stricter, which could affect the suggested fix. See [this FAQ section](https://docs.astral.sh/ruff/faq/#how-does-ruff-determine-which-of-my-imports-are-first-party-third-party-etc) for more details.
+
 ## Options
 - `lint.ignore-init-module-imports`
 - `lint.pyflakes.allowed-unused-imports`

crates/ruff/tests/snapshots/lint__output_format_gitlab.snap

@@ -20,59 +20,59 @@ exit_code: 1
   {
     "check_name": "F401",
     "description": "F401: `os` imported but unused",
-    "severity": "major",
     "fingerprint": "4dbad37161e65c72",
     "location": {
       "path": "input.py",
       "positions": {
         "begin": {
-          "line": 1,
-          "column": 8
+          "column": 8,
+          "line": 1
         },
         "end": {
-          "line": 1,
-          "column": 10
+          "column": 10,
+          "line": 1
         }
       }
-    }
+    },
+    "severity": "major"
   },
   {
     "check_name": "F821",
     "description": "F821: Undefined name `y`",
-    "severity": "major",
     "fingerprint": "7af59862a085230",
     "location": {
       "path": "input.py",
       "positions": {
         "begin": {
-          "line": 2,
-          "column": 5
+          "column": 5,
+          "line": 2
         },
         "end": {
-          "line": 2,
-          "column": 6
+          "column": 6,
+          "line": 2
         }
       }
-    }
+    },
+    "severity": "major"
   },
   {
     "check_name": "invalid-syntax",
     "description": "invalid-syntax: Cannot use `match` statement on Python 3.9 (syntax was added in Python 3.10)",
-    "severity": "major",
     "fingerprint": "e558cec859bb66e8",
     "location": {
       "path": "input.py",
       "positions": {
         "begin": {
-          "line": 3,
-          "column": 1
+          "column": 1,
+          "line": 3
         },
         "end": {
-          "line": 3,
-          "column": 6
+          "column": 6,
+          "line": 3
         }
       }
-    }
+    },
+    "severity": "major"
   }
 ]
 ----- stderr -----

crates/ruff/tests/snapshots/lint__output_format_sarif.snap

@@ -95,7 +95,7 @@ exit_code: 1
           "rules": [
             {
               "fullDescription": {
-                "text": "## What it does\nChecks for unused imports.\n\n## Why is this bad?\nUnused imports add a performance overhead at runtime, and risk creating\nimport cycles. They also increase the cognitive load of reading the code.\n\nIf an import statement is used to check for the availability or existence\nof a module, consider using `importlib.util.find_spec` instead.\n\nIf an import statement is used to re-export a symbol as part of a module's\npublic interface, consider using a \"redundant\" import alias, which\ninstructs Ruff (and other tools) to respect the re-export, and avoid\nmarking it as unused, as in:\n\n```python\nfrom module import member as member\n```\n\nAlternatively, you can use `__all__` to declare a symbol as part of the module's\ninterface, as in:\n\n```python\n# __init__.py\nimport some_module\n\n__all__ = [\"some_module\"]\n```\n\n## Fix safety\n\nFixes to remove unused imports are safe, except in `__init__.py` files.\n\nApplying fixes to `__init__.py` files is currently in preview. The fix offered depends on the\ntype of the unused import. Ruff will suggest a safe fix to export first-party imports with\neither a redundant alias or, if already present in the file, an `__all__` entry. If multiple\n`__all__` declarations are present, Ruff will not offer a fix. Ruff will suggest an unsafe fix\nto remove third-party and standard library imports -- the fix is unsafe because the module's\ninterface changes.\n\nSee [this FAQ section](https://docs.astral.sh/ruff/faq/#how-does-ruff-determine-which-of-my-imports-are-first-party-third-party-etc)\nfor more details on how Ruff\ndetermines whether an import is first or third-party.\n\n## Example\n\n```python\nimport numpy as np  # unused import\n\n\ndef area(radius):\n    return 3.14 * radius**2\n```\n\nUse instead:\n\n```python\ndef area(radius):\n    return 3.14 * radius**2\n```\n\nTo check the availability of a module, use `importlib.util.find_spec`:\n\n```python\nfrom importlib.util import find_spec\n\nif find_spec(\"numpy\") is not None:\n    print(\"numpy is installed\")\nelse:\n    print(\"numpy is not installed\")\n```\n\n## Options\n- `lint.ignore-init-module-imports`\n- `lint.pyflakes.allowed-unused-imports`\n\n## References\n- [Python documentation: `import`](https://docs.python.org/3/reference/simple_stmts.html#the-import-statement)\n- [Python documentation: `importlib.util.find_spec`](https://docs.python.org/3/library/importlib.html#importlib.util.find_spec)\n- [Typing documentation: interface conventions](https://typing.python.org/en/latest/spec/distributing.html#library-interface-public-and-private-symbols)\n"
+                "text": "## What it does\nChecks for unused imports.\n\n## Why is this bad?\nUnused imports add a performance overhead at runtime, and risk creating\nimport cycles. They also increase the cognitive load of reading the code.\n\nIf an import statement is used to check for the availability or existence\nof a module, consider using `importlib.util.find_spec` instead.\n\nIf an import statement is used to re-export a symbol as part of a module's\npublic interface, consider using a \"redundant\" import alias, which\ninstructs Ruff (and other tools) to respect the re-export, and avoid\nmarking it as unused, as in:\n\n```python\nfrom module import member as member\n```\n\nAlternatively, you can use `__all__` to declare a symbol as part of the module's\ninterface, as in:\n\n```python\n# __init__.py\nimport some_module\n\n__all__ = [\"some_module\"]\n```\n\n## Fix safety\n\nFixes to remove unused imports are safe, except in `__init__.py` files.\n\nApplying fixes to `__init__.py` files is currently in preview. The fix offered depends on the\ntype of the unused import. Ruff will suggest a safe fix to export first-party imports with\neither a redundant alias or, if already present in the file, an `__all__` entry. If multiple\n`__all__` declarations are present, Ruff will not offer a fix. Ruff will suggest an unsafe fix\nto remove third-party and standard library imports -- the fix is unsafe because the module's\ninterface changes.\n\n## Example\n\n```python\nimport numpy as np  # unused import\n\n\ndef area(radius):\n    return 3.14 * radius**2\n```\n\nUse instead:\n\n```python\ndef area(radius):\n    return 3.14 * radius**2\n```\n\nTo check the availability of a module, use `importlib.util.find_spec`:\n\n```python\nfrom importlib.util import find_spec\n\nif find_spec(\"numpy\") is not None:\n    print(\"numpy is installed\")\nelse:\n    print(\"numpy is not installed\")\n```\n\n## Preview\nWhen [preview](https://docs.astral.sh/ruff/preview/) is enabled,\nthe criterion for determining whether an import is first-party\nis stricter, which could affect the suggested fix. See [this FAQ section](https://docs.astral.sh/ruff/faq/#how-does-ruff-determine-which-of-my-imports-are-first-party-third-party-etc) for more details.\n\n## Options\n- `lint.ignore-init-module-imports`\n- `lint.pyflakes.allowed-unused-imports`\n\n## References\n- [Python documentation: `import`](https://docs.python.org/3/reference/simple_stmts.html#the-import-statement)\n- [Python documentation: `importlib.util.find_spec`](https://docs.python.org/3/library/importlib.html#importlib.util.find_spec)\n- [Typing documentation: interface conventions](https://typing.python.org/en/latest/spec/distributing.html#library-interface-public-and-private-symbols)\n"
               },
               "help": {
                 "text": "`{name}` imported but unused; consider using `importlib.util.find_spec` to test for availability"

crates/ruff_benchmark/benches/ty.rs

@@ -450,6 +450,9 @@ fn benchmark_complex_constrained_attributes_2(criterion: &mut Criterion) {
                     r#"
                     class C:
                         def f(self: "C"):
+                            self.a = ""
+                            self.b = ""
+
                             if isinstance(self.a, str):
                                 return
 
@@ -463,56 +466,6 @@ fn benchmark_complex_constrained_attributes_2(criterion: &mut Criterion) {
                                 return
                             if isinstance(self.b, str):
                                 return
-                            if isinstance(self.b, str):
-                                return
-                            if isinstance(self.b, str):
-                                return
-
-                            self.a = ""
-                            self.b = ""
-                    "#,
-                )
-            },
-            |case| {
-                let Case { db, .. } = case;
-                let result = db.check();
-                assert_eq!(result.len(), 0);
-            },
-            BatchSize::SmallInput,
-        );
-    });
-}
-
-fn benchmark_complex_constrained_attributes_3(criterion: &mut Criterion) {
-    setup_rayon();
-
-    criterion.bench_function("ty_micro[complex_constrained_attributes_3]", |b| {
-        b.iter_batched_ref(
-            || {
-                // This is a regression test for https://github.com/astral-sh/ty/issues/758
-                setup_micro_case(
-                    r#"
-                    class GridOut:
-                        def __init__(self: "GridOut") -> None:
-                            self._buffer = b""
-
-                        def _read_size_or_line(self: "GridOut", size: int = -1):
-                            if size > self._position:
-                                size = self._position
-                                pass
-                            if size == 0:
-                                return bytes()
-
-                            while size > 0:
-                                if self._buffer:
-                                    buf = self._buffer
-                                    self._buffer = b""
-                                else:
-                                    buf = b""
-
-                                if len(buf) > size:
-                                    self._buffer = buf
-                                    self._position -= len(self._buffer)
                     "#,
                 )
             },
@@ -715,7 +668,6 @@ criterion_group!(
     benchmark_tuple_implicit_instance_attributes,
     benchmark_complex_constrained_attributes_1,
     benchmark_complex_constrained_attributes_2,
-    benchmark_complex_constrained_attributes_3,
     benchmark_many_enum_members,
 );
 criterion_group!(project, anyio, attrs, hydra, datetype);

crates/ruff_db/Cargo.toml

@@ -34,7 +34,6 @@ glob = { workspace = true }
 ignore = { workspace = true, optional = true }
 matchit = { workspace = true }
 path-slash = { workspace = true }
-pathdiff = { workspace = true }
 quick-junit = { workspace = true, optional = true }
 rustc-hash = { workspace = true }
 salsa = { workspace = true }
@@ -54,7 +53,7 @@ web-time = { version = "1.1.0" }
 etcetera = { workspace = true, optional = true }
 
 [dev-dependencies]
-insta = { workspace = true, features = ["filters"] }
+insta = { workspace = true }
 tempfile = { workspace = true }
 
 [features]

crates/ruff_db/src/diagnostic/mod.rs

@@ -22,6 +22,7 @@ mod stylesheet;
 /// a characteristic is a deficiency. An example of a characteristic that is
 /// _not_ a deficiency is the `reveal_type` diagnostic for our type checker.
 #[derive(Debug, Clone, Eq, PartialEq, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 pub struct Diagnostic {
     /// The actual diagnostic.
     ///
@@ -325,11 +326,6 @@ impl Diagnostic {
         self.inner.fix.as_ref()
     }
 
-    #[cfg(test)]
-    pub(crate) fn fix_mut(&mut self) -> Option<&mut Fix> {
-        Arc::make_mut(&mut self.inner).fix.as_mut()
-    }
-
     /// Set the fix for this diagnostic.
     pub fn set_fix(&mut self, fix: Fix) {
         debug_assert!(
@@ -349,13 +345,6 @@ impl Diagnostic {
         self.fix().is_some()
     }
 
-    /// Returns `true` if the diagnostic is [`fixable`](Diagnostic::fixable) and applies at the
-    /// configured applicability level.
-    pub fn has_applicable_fix(&self, config: &DisplayDiagnosticConfig) -> bool {
-        self.fix()
-            .is_some_and(|fix| fix.applies(config.fix_applicability))
-    }
-
     /// Returns the offset of the parent statement for this diagnostic if it exists.
     ///
     /// This is primarily used for checking noqa/secondary code suppressions.
@@ -454,26 +443,24 @@ impl Diagnostic {
 
     /// Computes the start source location for the message.
     ///
-    /// Returns None if the diagnostic has no primary span, if its file is not a `SourceFile`,
-    /// or if the span has no range.
-    pub fn ruff_start_location(&self) -> Option<LineColumn> {
-        Some(
-            self.ruff_source_file()?
-                .to_source_code()
-                .line_column(self.range()?.start()),
-        )
+    /// Panics if the diagnostic has no primary span, if its file is not a `SourceFile`, or if the
+    /// span has no range.
+    pub fn expect_ruff_start_location(&self) -> LineColumn {
+        self.expect_primary_span()
+            .expect_ruff_file()
+            .to_source_code()
+            .line_column(self.expect_range().start())
     }
 
     /// Computes the end source location for the message.
     ///
-    /// Returns None if the diagnostic has no primary span, if its file is not a `SourceFile`,
-    /// or if the span has no range.
-    pub fn ruff_end_location(&self) -> Option<LineColumn> {
-        Some(
-            self.ruff_source_file()?
-                .to_source_code()
-                .line_column(self.range()?.end()),
-        )
+    /// Panics if the diagnostic has no primary span, if its file is not a `SourceFile`, or if the
+    /// span has no range.
+    pub fn expect_ruff_end_location(&self) -> LineColumn {
+        self.expect_primary_span()
+            .expect_ruff_file()
+            .to_source_code()
+            .line_column(self.expect_range().end())
     }
 
     /// Returns the [`SourceFile`] which the message belongs to.
@@ -503,22 +490,18 @@ impl Diagnostic {
 
     /// Returns the ordering of diagnostics based on the start of their ranges, if they have any.
     ///
-    /// Panics if either diagnostic has no primary span, or if its file is not a `SourceFile`.
+    /// Panics if either diagnostic has no primary span, if the span has no range, or if its file is
+    /// not a `SourceFile`.
     pub fn ruff_start_ordering(&self, other: &Self) -> std::cmp::Ordering {
-        let a = (
-            self.expect_ruff_source_file(),
-            self.range().map(|r| r.start()),
-        );
-        let b = (
+        (self.expect_ruff_source_file(), self.expect_range().start()).cmp(&(
             other.expect_ruff_source_file(),
-            other.range().map(|r| r.start()),
-        );
-
-        a.cmp(&b)
+            other.expect_range().start(),
+        ))
     }
 }
 
 #[derive(Debug, Clone, Eq, PartialEq, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 struct DiagnosticInner {
     id: DiagnosticId,
     severity: Severity,
@@ -595,6 +578,7 @@ impl Eq for RenderingSortKey<'_> {}
 /// another (for a single parent diagnostic) is the order in which they were
 /// attached to the diagnostic.
 #[derive(Debug, Clone, Eq, PartialEq, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 pub struct SubDiagnostic {
     /// Like with `Diagnostic`, we box the `SubDiagnostic` to make it
     /// pointer-sized.
@@ -704,6 +688,7 @@ impl SubDiagnostic {
 }
 
 #[derive(Debug, Clone, Eq, PartialEq, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 struct SubDiagnosticInner {
     severity: SubDiagnosticSeverity,
     message: DiagnosticMessage,
@@ -732,6 +717,7 @@ struct SubDiagnosticInner {
 /// Messages attached to annotations should also be as brief and specific as
 /// possible. Long messages could negative impact the quality of rendering.
 #[derive(Debug, Clone, Eq, PartialEq, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 pub struct Annotation {
     /// The span of this annotation, corresponding to some subsequence of the
     /// user's input that we want to highlight.
@@ -874,6 +860,7 @@ impl Annotation {
 /// These tags are used to provide additional information about the annotation.
 /// and are passed through to the language server protocol.
 #[derive(Debug, Clone, Eq, PartialEq, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 pub enum DiagnosticTag {
     /// Unused or unnecessary code. Used for unused parameters, unreachable code, etc.
     Unnecessary,
@@ -888,6 +875,7 @@ pub enum DiagnosticTag {
 ///
 /// Rules use kebab case, e.g. `no-foo`.
 #[derive(Debug, Copy, Clone, PartialOrd, Ord, PartialEq, Eq, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Serialize), serde(transparent))]
 pub struct LintName(&'static str);
 
 impl LintName {
@@ -900,6 +888,66 @@ impl LintName {
     }
 }
 
+#[cfg(feature = "serde")]
+pub use lint_name_serde::LintRegistryGuard;
+
+#[cfg(feature = "serde")]
+mod lint_name_serde {
+    use super::LintName;
+
+    use std::cell::RefCell;
+
+    thread_local! {
+        /// Serde doesn't provide any easy means to pass a value to a [`Deserialize`] implementation,
+        /// but we need a way to retrieve static [`LintName`]s from the lint registry when deserializing.
+        ///
+        /// Use the [`LintRegistryGuard`] to initialize the thread local before calling into any
+        /// deserialization code. It ensures that the thread local variable gets cleaned up
+        /// once deserialization is done (once the guard gets dropped).
+        static LINT_REGISTRY: RefCell<Option<LintRegistry>> = const { RefCell::new(None) };
+    }
+
+    type LintRegistry = fn(&str) -> Option<LintName>;
+
+    /// Guard to safely change the lint registry for the current thread.
+    #[must_use]
+    pub struct LintRegistryGuard {
+        prev_value: Option<LintRegistry>,
+    }
+
+    impl LintRegistryGuard {
+        pub fn new(registry: LintRegistry) -> Self {
+            let prev = LINT_REGISTRY.replace(Some(registry));
+            Self { prev_value: prev }
+        }
+    }
+
+    impl Drop for LintRegistryGuard {
+        fn drop(&mut self) {
+            LINT_REGISTRY.set(self.prev_value.take());
+        }
+    }
+
+    #[cfg(feature = "serde")]
+    impl<'de> serde::Deserialize<'de> for LintName {
+        fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
+        where
+            D: serde::Deserializer<'de>,
+        {
+            let name: &str = serde::Deserialize::deserialize(deserializer)?;
+
+            LINT_REGISTRY.with_borrow(|registry| {
+                let registry = registry
+                    .expect("must set the `LintRegistryGuard` when deserializing a `LintName`");
+
+                registry(name).ok_or(serde::de::Error::custom(format!(
+                    "invalid `LintName` {name}"
+                )))
+            })
+        }
+    }
+}
+
 impl std::ops::Deref for LintName {
     type Target = str;
 
@@ -928,6 +976,7 @@ impl PartialEq<&str> for LintName {
 
 /// Uniquely identifies the kind of a diagnostic.
 #[derive(Debug, Copy, Clone, Eq, PartialEq, PartialOrd, Ord, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 pub enum DiagnosticId {
     Panic,
 
@@ -1116,6 +1165,30 @@ impl UnifiedFile {
     }
 }
 
+#[cfg(feature = "serde")]
+impl serde::Serialize for UnifiedFile {
+    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
+    where
+        S: serde::Serializer,
+    {
+        match self {
+            UnifiedFile::Ty(file) => serde::Serialize::serialize(file, serializer),
+            // Persistent caching is only used in ty.
+            UnifiedFile::Ruff(..) => panic!("Ruff files are not persistable"),
+        }
+    }
+}
+
+#[cfg(feature = "serde")]
+impl<'de> serde::Deserialize<'de> for UnifiedFile {
+    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
+    where
+        D: serde::Deserializer<'de>,
+    {
+        serde::Deserialize::deserialize(deserializer).map(UnifiedFile::Ty)
+    }
+}
+
 /// A unified wrapper for types that can be converted to a [`SourceCode`].
 ///
 /// As with [`UnifiedFile`], ruff and ty use slightly different representations for source code.
@@ -1147,6 +1220,7 @@ impl DiagnosticSource {
 /// range isn't present, it semantically implies that the diagnostic refers to
 /// the entire file. For example, when the file should be executable but isn't.
 #[derive(Debug, Clone, PartialEq, Eq, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 pub struct Span {
     file: UnifiedFile,
     range: Option<TextRange>,
@@ -1225,6 +1299,7 @@ impl From<crate::files::FileRange> for Span {
 }
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Ord, PartialOrd, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 pub enum Severity {
     Info,
     Warning,
@@ -1260,6 +1335,7 @@ impl Severity {
 /// used for main diagnostics. If we want to add `Severity::Help` in the future, this type could be
 /// deleted and the two combined again.
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Ord, PartialOrd, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 pub enum SubDiagnosticSeverity {
     Help,
     Info,
@@ -1449,11 +1525,6 @@ pub enum DiagnosticFormat {
     /// Print diagnostics in the format expected by JUnit.
     #[cfg(feature = "junit")]
     Junit,
-    /// Print diagnostics in the JSON format used by GitLab [Code Quality] reports.
-    ///
-    /// [Code Quality]: https://docs.gitlab.com/ci/testing/code_quality/#code-quality-report-format
-    #[cfg(feature = "serde")]
-    Gitlab,
 }
 
 /// A representation of the kinds of messages inside a diagnostic.
@@ -1513,6 +1584,7 @@ impl std::fmt::Display for ConciseMessage<'_> {
 /// a blanket trait implementation for `IntoDiagnosticMessage` for
 /// anything that implements `std::fmt::Display`.
 #[derive(Clone, Debug, Eq, PartialEq, Hash, get_size2::GetSize)]
+#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))]
 pub struct DiagnosticMessage(Box<str>);
 
 impl DiagnosticMessage {
@@ -1576,7 +1648,11 @@ impl<T: std::fmt::Display> IntoDiagnosticMessage for T {
 ///
 /// For Ruff rules this means the noqa code.
 #[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Default, Hash, get_size2::GetSize)]
-#[cfg_attr(feature = "serde", derive(serde::Serialize), serde(transparent))]
+#[cfg_attr(
+    feature = "serde",
+    derive(serde::Serialize, serde::Deserialize),
+    serde(transparent)
+)]
 pub struct SecondaryCode(String);
 
 impl SecondaryCode {

crates/ruff_db/src/diagnostic/render.rs

@@ -31,8 +31,6 @@ mod azure;
 mod concise;
 mod full;
 #[cfg(feature = "serde")]
-mod gitlab;
-#[cfg(feature = "serde")]
 mod json;
 #[cfg(feature = "serde")]
 mod json_lines;
@@ -138,10 +136,6 @@ impl std::fmt::Display for DisplayDiagnostics<'_> {
             DiagnosticFormat::Junit => {
                 junit::JunitRenderer::new(self.resolver).render(f, self.diagnostics)?;
             }
-            #[cfg(feature = "serde")]
-            DiagnosticFormat::Gitlab => {
-                gitlab::GitlabRenderer::new(self.resolver).render(f, self.diagnostics)?;
-            }
         }
 
         Ok(())
@@ -254,7 +248,9 @@ impl<'a> ResolvedDiagnostic<'a> {
             id,
             message: diag.inner.message.as_str().to_string(),
             annotations,
-            is_fixable: diag.has_applicable_fix(config),
+            is_fixable: diag
+                .fix()
+                .is_some_and(|fix| fix.applies(config.fix_applicability)),
         }
     }
 
@@ -2626,13 +2622,6 @@ watermelon
             self.config = config;
         }
 
-        /// Show a diff for the fix when rendering.
-        pub(super) fn show_fix_diff(&mut self, yes: bool) {
-            let mut config = std::mem::take(&mut self.config);
-            config = config.show_fix_diff(yes);
-            self.config = config;
-        }
-
         /// The lowest fix applicability to show when rendering.
         pub(super) fn fix_applicability(&mut self, applicability: Applicability) {
             let mut config = std::mem::take(&mut self.config);

crates/ruff_db/src/diagnostic/render/concise.rs

@@ -77,9 +77,11 @@ impl<'a> ConciseRenderer<'a> {
                     )?;
                 }
                 if self.config.show_fix_status {
-                    // Do not display an indicator for inapplicable fixes
-                    if diag.has_applicable_fix(self.config) {
-                        write!(f, "[{fix}] ", fix = fmt_styled("*", stylesheet.separator))?;
+                    if let Some(fix) = diag.fix() {
+                        // Do not display an indicator for inapplicable fixes
+                        if fix.applies(self.config.fix_applicability) {
+                            write!(f, "[{fix}] ", fix = fmt_styled("*", stylesheet.separator))?;
+                        }
                     }
                 }
             } else {

crates/ruff_db/src/diagnostic/render/full.rs

@@ -1,13 +1,13 @@
 use std::borrow::Cow;
 use std::num::NonZeroUsize;
 
+use anstyle::Style;
 use similar::{ChangeTag, TextDiff};
 
 use ruff_annotate_snippets::Renderer as AnnotateRenderer;
 use ruff_diagnostics::{Applicability, Fix};
-use ruff_notebook::NotebookIndex;
 use ruff_source_file::OneIndexed;
-use ruff_text_size::{Ranged, TextLen, TextRange, TextSize};
+use ruff_text_size::{Ranged, TextRange, TextSize};
 
 use crate::diagnostic::render::{FileResolver, Resolved};
 use crate::diagnostic::stylesheet::{DiagnosticStylesheet, fmt_styled};
@@ -57,14 +57,13 @@ impl<'a> FullRenderer<'a> {
             for diag in renderable.diagnostics.iter() {
                 writeln!(f, "{}", renderer.render(diag.to_annotate()))?;
             }
+            writeln!(f)?;
 
-            if self.config.show_fix_diff && diag.has_applicable_fix(self.config) {
+            if self.config.show_fix_diff {
                 if let Some(diff) = Diff::from_diagnostic(diag, &stylesheet, self.resolver) {
-                    write!(f, "{diff}")?;
+                    writeln!(f, "{diff}")?;
                 }
             }
-
-            writeln!(f)?;
         }
 
         Ok(())
@@ -82,7 +81,6 @@ impl<'a> FullRenderer<'a> {
 struct Diff<'a> {
     fix: &'a Fix,
     diagnostic_source: DiagnosticSource,
-    notebook_index: Option<NotebookIndex>,
     stylesheet: &'a DiagnosticStylesheet,
 }
 
@@ -92,11 +90,12 @@ impl<'a> Diff<'a> {
         stylesheet: &'a DiagnosticStylesheet,
         resolver: &'a dyn FileResolver,
     ) -> Option<Diff<'a>> {
-        let file = &diagnostic.primary_span_ref()?.file;
         Some(Diff {
             fix: diagnostic.fix()?,
-            diagnostic_source: file.diagnostic_source(resolver),
-            notebook_index: resolver.notebook_index(file),
+            diagnostic_source: diagnostic
+                .primary_span_ref()?
+                .file
+                .diagnostic_source(resolver),
             stylesheet,
         })
     }
@@ -107,156 +106,119 @@ impl std::fmt::Display for Diff<'_> {
         let source_code = self.diagnostic_source.as_source_code();
         let source_text = source_code.text();
 
-        // Partition the source code into end offsets for each cell. If `self.notebook_index` is
-        // `None`, indicating a regular script file, all the lines will be in one "cell" under the
-        // `None` key.
-        let cells = if let Some(notebook_index) = &self.notebook_index {
-            let mut last_cell = OneIndexed::MIN;
-            let mut cells: Vec<(Option<OneIndexed>, TextSize)> = Vec::new();
-            for (row, cell) in notebook_index.iter() {
-                if cell != last_cell {
-                    let offset = source_code.line_start(row);
-                    cells.push((Some(last_cell), offset));
-                    last_cell = cell;
-                }
-            }
-            cells.push((Some(last_cell), source_text.text_len()));
-            cells
-        } else {
-            vec![(None, source_text.text_len())]
+        // TODO(dhruvmanila): Add support for Notebook cells once it's user-facing
+        let mut output = String::with_capacity(source_text.len());
+        let mut last_end = TextSize::default();
+
+        for edit in self.fix.edits() {
+            output.push_str(source_code.slice(TextRange::new(last_end, edit.start())));
+            output.push_str(edit.content().unwrap_or_default());
+            last_end = edit.end();
+        }
+
+        output.push_str(&source_text[usize::from(last_end)..]);
+
+        let diff = TextDiff::from_lines(source_text, &output);
+
+        let message = match self.fix.applicability() {
+            // TODO(zanieb): Adjust this messaging once it's user-facing
+            Applicability::Safe => "Safe fix",
+            Applicability::Unsafe => "Unsafe fix",
+            Applicability::DisplayOnly => "Display-only fix",
         };
 
-        let mut last_end = TextSize::ZERO;
-        for (cell, offset) in cells {
-            let range = TextRange::new(last_end, offset);
-            last_end = offset;
-            let input = source_code.slice(range);
+        // TODO(brent) `stylesheet.separator` is cyan rather than blue, as we had before. I think
+        // we're getting rid of this soon anyway, so I didn't think it was worth adding another
+        // style to the stylesheet temporarily. The color doesn't appear at all in the snapshot
+        // tests, which is the only place these are currently used.
+        writeln!(f, "ℹ {}", fmt_styled(message, self.stylesheet.separator))?;
 
-            let mut output = String::with_capacity(input.len());
-            let mut last_end = range.start();
+        let (largest_old, largest_new) = diff
+            .ops()
+            .last()
+            .map(|op| (op.old_range().start, op.new_range().start))
+            .unwrap_or_default();
 
-            let mut applied = 0;
-            for edit in self.fix.edits() {
-                if range.contains_range(edit.range()) {
-                    output.push_str(source_code.slice(TextRange::new(last_end, edit.start())));
-                    output.push_str(edit.content().unwrap_or_default());
-                    last_end = edit.end();
-                    applied += 1;
-                }
+        let digit_with = OneIndexed::from_zero_indexed(largest_new.max(largest_old)).digits();
+
+        for (idx, group) in diff.grouped_ops(3).iter().enumerate() {
+            if idx > 0 {
+                writeln!(f, "{:-^1$}", "-", 80)?;
             }
+            for op in group {
+                for change in diff.iter_inline_changes(op) {
+                    let sign = match change.tag() {
+                        ChangeTag::Delete => "-",
+                        ChangeTag::Insert => "+",
+                        ChangeTag::Equal => " ",
+                    };
 
-            // No edits were applied, so there's no need to diff.
-            if applied == 0 {
-                continue;
-            }
+                    let line_style = LineStyle::from(change.tag(), self.stylesheet);
 
-            output.push_str(&source_text[usize::from(last_end)..usize::from(range.end())]);
+                    let old_index = change.old_index().map(OneIndexed::from_zero_indexed);
+                    let new_index = change.new_index().map(OneIndexed::from_zero_indexed);
 
-            let diff = TextDiff::from_lines(input, &output);
+                    write!(
+                        f,
+                        "{} {} |{}",
+                        Line {
+                            index: old_index,
+                            width: digit_with
+                        },
+                        Line {
+                            index: new_index,
+                            width: digit_with
+                        },
+                        fmt_styled(line_style.apply_to(sign), self.stylesheet.emphasis),
+                    )?;
 
-            let grouped_ops = diff.grouped_ops(3);
-
-            // Find the new line number with the largest number of digits to align all of the line
-            // number separators.
-            let last_op = grouped_ops.last().and_then(|group| group.last());
-            let largest_new = last_op.map(|op| op.new_range().end).unwrap_or_default();
-
-            let digit_with = OneIndexed::new(largest_new).unwrap_or_default().digits();
-
-            if let Some(cell) = cell {
-                // Room for 1 digit, 1 space, 1 `|`, and 1 more following space. This centers the
-                // three colons on the pipe.
-                writeln!(f, "{:>1$} cell {cell}", ":::", digit_with.get() + 3)?;
-            }
-
-            for (idx, group) in grouped_ops.iter().enumerate() {
-                if idx > 0 {
-                    writeln!(f, "{:-^1$}", "-", 80)?;
-                }
-                for op in group {
-                    for change in diff.iter_inline_changes(op) {
-                        let (sign, style, line_no_style, index) = match change.tag() {
-                            ChangeTag::Delete => (
-                                "-",
-                                self.stylesheet.deletion,
-                                self.stylesheet.deletion_line_no,
-                                None,
-                            ),
-                            ChangeTag::Insert => (
-                                "+",
-                                self.stylesheet.insertion,
-                                self.stylesheet.insertion_line_no,
-                                change.new_index(),
-                            ),
-                            ChangeTag::Equal => (
-                                "|",
-                                self.stylesheet.none,
-                                self.stylesheet.line_no,
-                                change.new_index(),
-                            ),
-                        };
-
-                        let line = Line {
-                            index: index.map(OneIndexed::from_zero_indexed),
-                            width: digit_with,
-                        };
-
-                        write!(
-                            f,
-                            "{line} {sign} ",
-                            line = fmt_styled(line, self.stylesheet.line_no),
-                            sign = fmt_styled(sign, line_no_style),
-                        )?;
-
-                        for (emphasized, value) in change.iter_strings_lossy() {
-                            let value = show_nonprinting(&value);
-                            let styled = fmt_styled(value, style);
-                            if emphasized {
-                                write!(f, "{}", fmt_styled(styled, self.stylesheet.emphasis))?;
-                            } else {
-                                write!(f, "{styled}")?;
-                            }
-                        }
-                        if change.missing_newline() {
-                            writeln!(f)?;
+                    for (emphasized, value) in change.iter_strings_lossy() {
+                        let value = show_nonprinting(&value);
+                        if emphasized {
+                            write!(
+                                f,
+                                "{}",
+                                fmt_styled(line_style.apply_to(&value), self.stylesheet.underline)
+                            )?;
+                        } else {
+                            write!(f, "{}", line_style.apply_to(&value))?;
                         }
                     }
+                    if change.missing_newline() {
+                        writeln!(f)?;
+                    }
                 }
             }
         }
 
-        match self.fix.applicability() {
-            Applicability::Safe => {}
-            Applicability::Unsafe => {
-                writeln!(
-                    f,
-                    "{note}: {msg}",
-                    note = fmt_styled("note", self.stylesheet.warning),
-                    msg = fmt_styled(
-                        "This is an unsafe fix and may change runtime behavior",
-                        self.stylesheet.emphasis
-                    )
-                )?;
-            }
-            Applicability::DisplayOnly => {
-                // Note that this is still only used in tests. There's no `--display-only-fixes`
-                // analog to `--unsafe-fixes` for users to activate this or see the styling.
-                writeln!(
-                    f,
-                    "{note}: {msg}",
-                    note = fmt_styled("note", self.stylesheet.error),
-                    msg = fmt_styled(
-                        "This is a display-only fix and is likely to be incorrect",
-                        self.stylesheet.emphasis
-                    )
-                )?;
-            }
-        }
-
         Ok(())
     }
 }
 
+struct LineStyle {
+    style: Style,
+}
+
+impl LineStyle {
+    fn apply_to(&self, input: &str) -> impl std::fmt::Display {
+        fmt_styled(input, self.style)
+    }
+
+    fn from(value: ChangeTag, stylesheet: &DiagnosticStylesheet) -> LineStyle {
+        match value {
+            ChangeTag::Equal => LineStyle {
+                style: stylesheet.none,
+            },
+            ChangeTag::Delete => LineStyle {
+                style: stylesheet.deletion,
+            },
+            ChangeTag::Insert => LineStyle {
+                style: stylesheet.insertion,
+            },
+        }
+    }
+}
+
 struct Line {
     index: Option<OneIndexed>,
     width: NonZeroUsize,
@@ -291,7 +253,7 @@ fn show_nonprinting(s: &str) -> Cow<'_, str> {
 
 #[cfg(test)]
 mod tests {
-    use ruff_diagnostics::{Applicability, Edit, Fix};
+    use ruff_diagnostics::Applicability;
     use ruff_text_size::{TextLen, TextRange, TextSize};
 
     use crate::diagnostic::{
@@ -692,104 +654,6 @@ print()
         ");
     }
 
-    /// Test that we remap notebook cell line numbers in the diff as well as the main diagnostic.
-    #[test]
-    fn notebook_output_with_diff() {
-        let (mut env, diagnostics) = create_notebook_diagnostics(DiagnosticFormat::Full);
-        env.show_fix_diff(true);
-        env.fix_applicability(Applicability::DisplayOnly);
-
-        insta::assert_snapshot!(env.render_diagnostics(&diagnostics), @r"
-        error[unused-import][*]: `os` imported but unused
-         --> notebook.ipynb:cell 1:2:8
-          |
-        1 | # cell 1
-        2 | import os
-          |        ^^
-          |
-        help: Remove unused import: `os`
-         ::: cell 1
-        1 | # cell 1
-          - import os
-
-        error[unused-import][*]: `math` imported but unused
-         --> notebook.ipynb:cell 2:2:8
-          |
-        1 | # cell 2
-        2 | import math
-          |        ^^^^
-        3 |
-        4 | print('hello world')
-          |
-        help: Remove unused import: `math`
-         ::: cell 2
-        1 | # cell 2
-          - import math
-        2 | 
-        3 | print('hello world')
-
-        error[unused-variable][*]: Local variable `x` is assigned to but never used
-         --> notebook.ipynb:cell 3:4:5
-          |
-        2 | def foo():
-        3 |     print()
-        4 |     x = 1
-          |     ^
-          |
-        help: Remove assignment to unused variable `x`
-         ::: cell 3
-        1 | # cell 3
-        2 | def foo():
-        3 |     print()
-          -     x = 1
-        4 | 
-        note: This is an unsafe fix and may change runtime behavior
-        ");
-    }
-
-    #[test]
-    fn notebook_output_with_diff_spanning_cells() {
-        let (mut env, mut diagnostics) = create_notebook_diagnostics(DiagnosticFormat::Full);
-        env.show_fix_diff(true);
-        env.fix_applicability(Applicability::DisplayOnly);
-
-        // Move all of the edits from the later diagnostics to the first diagnostic to simulate a
-        // single diagnostic with edits in different cells.
-        let mut diagnostic = diagnostics.swap_remove(0);
-        let fix = diagnostic.fix_mut().unwrap();
-        let mut edits = fix.edits().to_vec();
-        for diag in diagnostics {
-            edits.extend_from_slice(diag.fix().unwrap().edits());
-        }
-        *fix = Fix::unsafe_edits(edits.remove(0), edits);
-
-        insta::assert_snapshot!(env.render(&diagnostic), @r"
-        error[unused-import][*]: `os` imported but unused
-         --> notebook.ipynb:cell 1:2:8
-          |
-        1 | # cell 1
-        2 | import os
-          |        ^^
-          |
-        help: Remove unused import: `os`
-         ::: cell 1
-        1 | # cell 1
-          - import os
-         ::: cell 2
-        1 | # cell 2
-          - import math
-        2 | 
-        3 | print('hello world')
-         ::: cell 3
-        1 | # cell 3
-        2 | def foo():
-        3 |     print()
-          -     x = 1
-        4 | 
-        note: This is an unsafe fix and may change runtime behavior
-        ");
-    }
-
     /// Carriage return (`\r`) is a valid line-ending in Python, so we should normalize this to a
     /// line feed (`\n`) for rendering. Otherwise we report a single long line for this case.
     #[test]
@@ -892,74 +756,4 @@ print()
           |
         ");
     }
-
-    /// Test that we handle the width calculation for the line number correctly even for context
-    /// lines at the end of a diff. For example, we want it to render like this:
-    ///
-    /// ```
-    /// 8  |
-    /// 9  |
-    /// 10 |
-    /// ```
-    ///
-    /// and not like this:
-    ///
-    /// ```
-    /// 8 |
-    /// 9 |
-    /// 10 |
-    /// ```
-    #[test]
-    fn longer_line_number_end_of_context() {
-        let mut env = TestEnvironment::new();
-        let contents = "\
-line 1
-line 2
-line 3
-line 4
-line 5
-line 6
-line 7
-line 8
-line 9
-line 10
-        ";
-        env.add("example.py", contents);
-        env.format(DiagnosticFormat::Full);
-        env.show_fix_diff(true);
-        env.fix_applicability(Applicability::DisplayOnly);
-
-        let mut diagnostic = env.err().primary("example.py", "3", "3", "label").build();
-        diagnostic.help("Start of diff:");
-        let target = "line 7";
-        let line9 = contents.find(target).unwrap();
-        let range = TextRange::at(TextSize::try_from(line9).unwrap(), target.text_len());
-        diagnostic.set_fix(Fix::unsafe_edit(Edit::range_replacement(
-            format!("fixed {target}"),
-            range,
-        )));
-
-        insta::assert_snapshot!(env.render(&diagnostic), @r"
-        error[test-diagnostic][*]: main diagnostic message
-         --> example.py:3:1
-          |
-        1 | line 1
-        2 | line 2
-        3 | line 3
-          | ^^^^^^ label
-        4 | line 4
-        5 | line 5
-          |
-        help: Start of diff:
-        4  | line 4
-        5  | line 5
-        6  | line 6
-           - line 7
-        7  + fixed line 7
-        8  | line 8
-        9  | line 9
-        10 | line 10
-        note: This is an unsafe fix and may change runtime behavior
-        ");
-    }
 }

crates/ruff_db/src/diagnostic/render/gitlab.rs

@@ -1,205 +0,0 @@
-use std::{
-    collections::HashSet,
-    hash::{DefaultHasher, Hash, Hasher},
-    path::Path,
-};
-
-use ruff_source_file::LineColumn;
-use serde::{Serialize, Serializer, ser::SerializeSeq};
-
-use crate::diagnostic::{Diagnostic, Severity};
-
-use super::FileResolver;
-
-pub(super) struct GitlabRenderer<'a> {
-    resolver: &'a dyn FileResolver,
-}
-
-impl<'a> GitlabRenderer<'a> {
-    pub(super) fn new(resolver: &'a dyn FileResolver) -> Self {
-        Self { resolver }
-    }
-}
-
-impl GitlabRenderer<'_> {
-    pub(super) fn render(
-        &self,
-        f: &mut std::fmt::Formatter,
-        diagnostics: &[Diagnostic],
-    ) -> std::fmt::Result {
-        write!(
-            f,
-            "{}",
-            serde_json::to_string_pretty(&SerializedMessages {
-                diagnostics,
-                resolver: self.resolver,
-                #[expect(
-                    clippy::disallowed_methods,
-                    reason = "We don't have access to a `System` here, \
-                              and this is only intended for use by GitLab CI, \
-                              which runs on a real `System`."
-                )]
-                project_dir: std::env::var("CI_PROJECT_DIR").ok().as_deref(),
-            })
-            .unwrap()
-        )
-    }
-}
-
-struct SerializedMessages<'a> {
-    diagnostics: &'a [Diagnostic],
-    resolver: &'a dyn FileResolver,
-    project_dir: Option<&'a str>,
-}
-
-impl Serialize for SerializedMessages<'_> {
-    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
-    where
-        S: Serializer,
-    {
-        let mut s = serializer.serialize_seq(Some(self.diagnostics.len()))?;
-        let mut fingerprints = HashSet::<u64>::with_capacity(self.diagnostics.len());
-
-        for diagnostic in self.diagnostics {
-            let location = diagnostic
-                .primary_span()
-                .map(|span| {
-                    let file = span.file();
-                    let positions = if self.resolver.is_notebook(file) {
-                        // We can't give a reasonable location for the structured formats,
-                        // so we show one that's clearly a fallback
-                        Default::default()
-                    } else {
-                        let diagnostic_source = file.diagnostic_source(self.resolver);
-                        let source_code = diagnostic_source.as_source_code();
-                        span.range()
-                            .map(|range| Positions {
-                                begin: source_code.line_column(range.start()),
-                                end: source_code.line_column(range.end()),
-                            })
-                            .unwrap_or_default()
-                    };
-
-                    let path = self.project_dir.as_ref().map_or_else(
-                        || file.relative_path(self.resolver).display().to_string(),
-                        |project_dir| relativize_path_to(file.path(self.resolver), project_dir),
-                    );
-
-                    Location { path, positions }
-                })
-                .unwrap_or_default();
-
-            let mut message_fingerprint = fingerprint(diagnostic, &location.path, 0);
-
-            // Make sure that we do not get a fingerprint that is already in use
-            // by adding in the previously generated one.
-            while fingerprints.contains(&message_fingerprint) {
-                message_fingerprint = fingerprint(diagnostic, &location.path, message_fingerprint);
-            }
-            fingerprints.insert(message_fingerprint);
-
-            let description = diagnostic.body();
-            let check_name = diagnostic.secondary_code_or_id();
-            let severity = match diagnostic.severity() {
-                Severity::Info => "info",
-                Severity::Warning => "minor",
-                Severity::Error => "major",
-                // Another option here is `blocker`
-                Severity::Fatal => "critical",
-            };
-
-            let value = Message {
-                check_name,
-                // GitLab doesn't display the separate `check_name` field in a Code Quality report,
-                // so prepend it to the description too.
-                description: format!("{check_name}: {description}"),
-                severity,
-                fingerprint: format!("{:x}", message_fingerprint),
-                location,
-            };
-
-            s.serialize_element(&value)?;
-        }
-
-        s.end()
-    }
-}
-
-#[derive(Serialize)]
-struct Message<'a> {
-    check_name: &'a str,
-    description: String,
-    severity: &'static str,
-    fingerprint: String,
-    location: Location,
-}
-
-/// The place in the source code where the issue was discovered.
-///
-/// According to the CodeClimate report format [specification] linked from the GitLab [docs], this
-/// field is required, so we fall back on a default `path` and position if the diagnostic doesn't
-/// have a primary span.
-///
-/// [specification]: https://github.com/codeclimate/platform/blob/master/spec/analyzers/SPEC.md#data-types
-/// [docs]: https://docs.gitlab.com/ci/testing/code_quality/#code-quality-report-format
-#[derive(Default, Serialize)]
-struct Location {
-    path: String,
-    positions: Positions,
-}
-
-#[derive(Default, Serialize)]
-struct Positions {
-    begin: LineColumn,
-    end: LineColumn,
-}
-
-/// Generate a unique fingerprint to identify a violation.
-fn fingerprint(diagnostic: &Diagnostic, project_path: &str, salt: u64) -> u64 {
-    let mut hasher = DefaultHasher::new();
-
-    salt.hash(&mut hasher);
-    diagnostic.name().hash(&mut hasher);
-    project_path.hash(&mut hasher);
-
-    hasher.finish()
-}
-
-/// Convert an absolute path to be relative to the specified project root.
-fn relativize_path_to<P: AsRef<Path>, R: AsRef<Path>>(path: P, project_root: R) -> String {
-    format!(
-        "{}",
-        pathdiff::diff_paths(&path, project_root)
-            .expect("Could not diff paths")
-            .display()
-    )
-}
-
-#[cfg(test)]
-mod tests {
-    use crate::diagnostic::{
-        DiagnosticFormat,
-        render::tests::{create_diagnostics, create_syntax_error_diagnostics},
-    };
-
-    const FINGERPRINT_FILTERS: [(&str, &str); 1] = [(
-        r#""fingerprint": "[a-z0-9]+","#,
-        r#""fingerprint": "<redacted>","#,
-    )];
-
-    #[test]
-    fn output() {
-        let (env, diagnostics) = create_diagnostics(DiagnosticFormat::Gitlab);
-        insta::with_settings!({filters => FINGERPRINT_FILTERS}, {
-            insta::assert_snapshot!(env.render_diagnostics(&diagnostics));
-        });
-    }
-
-    #[test]
-    fn syntax_errors() {
-        let (env, diagnostics) = create_syntax_error_diagnostics(DiagnosticFormat::Gitlab);
-        insta::with_settings!({filters => FINGERPRINT_FILTERS}, {
-            insta::assert_snapshot!(env.render_diagnostics(&diagnostics));
-        });
-    }
-}

crates/ruff_db/src/diagnostic/stylesheet.rs

@@ -40,13 +40,12 @@ pub struct DiagnosticStylesheet {
     pub(crate) help: Style,
     pub(crate) line_no: Style,
     pub(crate) emphasis: Style,
+    pub(crate) underline: Style,
     pub(crate) none: Style,
     pub(crate) separator: Style,
     pub(crate) secondary_code: Style,
     pub(crate) insertion: Style,
     pub(crate) deletion: Style,
-    pub(crate) insertion_line_no: Style,
-    pub(crate) deletion_line_no: Style,
 }
 
 impl Default for DiagnosticStylesheet {
@@ -67,13 +66,12 @@ impl DiagnosticStylesheet {
             help: AnsiColor::BrightCyan.on_default().effects(Effects::BOLD),
             line_no: bright_blue.effects(Effects::BOLD),
             emphasis: Style::new().effects(Effects::BOLD),
+            underline: Style::new().effects(Effects::UNDERLINE),
             none: Style::new(),
             separator: AnsiColor::Cyan.on_default(),
             secondary_code: AnsiColor::Red.on_default().effects(Effects::BOLD),
             insertion: AnsiColor::Green.on_default(),
             deletion: AnsiColor::Red.on_default(),
-            insertion_line_no: AnsiColor::Green.on_default().effects(Effects::BOLD),
-            deletion_line_no: AnsiColor::Red.on_default().effects(Effects::BOLD),
         }
     }
 
@@ -86,13 +84,12 @@ impl DiagnosticStylesheet {
             help: Style::new(),
             line_no: Style::new(),
             emphasis: Style::new(),
+            underline: Style::new(),
             none: Style::new(),
             separator: Style::new(),
             secondary_code: Style::new(),
             insertion: Style::new(),
             deletion: Style::new(),
-            insertion_line_no: Style::new(),
-            deletion_line_no: Style::new(),
         }
     }
 }

crates/ruff_db/src/file_revision.rs

@@ -9,7 +9,17 @@ use crate::system::file_time_now;
 /// * The last modification time of the file.
 /// * The hash of the file's content.
 /// * The revision as it comes from an external system, for example the LSP.
-#[derive(Copy, Clone, Debug, Eq, PartialEq, Default, get_size2::GetSize)]
+#[derive(
+    Copy,
+    Clone,
+    Debug,
+    Eq,
+    PartialEq,
+    Default,
+    get_size2::GetSize,
+    serde::Serialize,
+    serde::Deserialize,
+)]
 pub struct FileRevision(u128);
 
 impl FileRevision {

crates/ruff_db/src/files.rs

@@ -14,7 +14,7 @@ use crate::diagnostic::{Span, UnifiedFile};
 use crate::file_revision::FileRevision;
 use crate::files::file_root::FileRoots;
 use crate::files::private::FileStatus;
-use crate::system::{SystemPath, SystemPathBuf, SystemVirtualPath, SystemVirtualPathBuf};
+use crate::system::{FileType, SystemPath, SystemPathBuf, SystemVirtualPath, SystemVirtualPathBuf};
 use crate::vendored::{VendoredPath, VendoredPathBuf};
 use crate::{Db, FxDashMap, vendored};
 
@@ -139,6 +139,7 @@ impl Files {
                 };
 
                 tracing::trace!("Adding vendored file `{}`", path);
+
                 let file = File::builder(FilePath::Vendored(path.to_path_buf()))
                     .permissions(Some(0o444))
                     .revision(metadata.revision())
@@ -200,7 +201,15 @@ impl Files {
         let mut roots = self.inner.roots.write().unwrap();
 
         let absolute = SystemPath::absolute(path, db.system().current_directory());
-        roots.try_add(db, absolute, kind)
+
+        let (Ok(root) | Err(root)) = roots.try_add(db, absolute, |absolute| {
+            FileRoot::builder(absolute, kind, FileRevision::now())
+                .durability(Durability::HIGH)
+                .revision_durability(kind.durability())
+                .new(db)
+        });
+
+        root
     }
 
     /// Updates the revision of the root for `path`.
@@ -259,6 +268,51 @@ impl Files {
             root.set_revision(db).to(FileRevision::now());
         }
     }
+
+    /// Seed the files with an existing [`File`] instance.
+    pub fn seed(&self, file: File, db: &dyn Db) {
+        let seeded = match file.path(db) {
+            FilePath::System(path) => self
+                .inner
+                .system_by_path
+                .insert(path.clone(), file)
+                .is_none(),
+            FilePath::SystemVirtual(path) => self
+                .inner
+                .system_virtual_by_path
+                .insert(path.clone(), VirtualFile(file))
+                .is_none(),
+            FilePath::Vendored(path) => self
+                .inner
+                .vendored_by_path
+                .insert(path.clone(), file)
+                .is_none(),
+        };
+
+        // Recreating a `File` input means the persisted queries depending on that file
+        // will be invalidated.
+        assert!(
+            seeded,
+            "unexpected `File` input recreated for path `{}`",
+            file.path(db)
+        );
+    }
+
+    /// Seed the files with an existing [`FileRoot`] instance.
+    pub fn seed_root(&self, root: FileRoot, db: &dyn Db) {
+        let mut roots = self.inner.roots.write().unwrap();
+        let seeded = roots
+            .try_add(db, root.path(db).to_path_buf(), |_| root)
+            .is_ok();
+
+        // Recreating a `FileRoot` input means the persisted queries depending on that file
+        // root will be invalidated.
+        assert!(
+            seeded,
+            "unexpected `FileRoot` input recreated for path `{}`",
+            root.path(db)
+        );
+    }
 }
 
 impl fmt::Debug for Files {
@@ -290,7 +344,7 @@ impl std::panic::RefUnwindSafe for Files {}
 /// # Ordering
 /// Ordering is based on the file's salsa-assigned id and not on its values.
 /// The id may change between runs.
-#[salsa::input(heap_size=ruff_memory_usage::heap_size)]
+#[salsa::input(persist, heap_size=ruff_memory_usage::heap_size)]
 #[derive(PartialOrd, Ord)]
 pub struct File {
     /// The path of the file (immutable).
@@ -414,6 +468,15 @@ impl File {
         }
     }
 
+    /// Loads all existing [`File`]s in the database.
+    pub fn load_all(db: &dyn Db) -> Vec<File> {
+        // TODO: Prune deleted paths.
+        File::ingredient(db)
+            .entries(db.zalsa())
+            .map(|entry| entry.as_struct())
+            .collect()
+    }
+
     /// Private method providing the implementation for [`Self::sync_path`] and [`Self::sync`] for
     /// system paths.
     fn sync_system_path(db: &mut dyn Db, path: &SystemPath, file: Option<File>) {
@@ -522,7 +585,17 @@ impl VirtualFile {
 // The types in here need to be public because they're salsa ingredients but we
 // don't want them to be publicly accessible. That's why we put them into a private module.
 mod private {
-    #[derive(Copy, Clone, Debug, Eq, PartialEq, Default, get_size2::GetSize)]
+    #[derive(
+        Copy,
+        Clone,
+        Debug,
+        Eq,
+        PartialEq,
+        Default,
+        get_size2::GetSize,
+        serde::Serialize,
+        serde::Deserialize,
+    )]
     pub enum FileStatus {
         /// The file exists.
         #[default]
@@ -536,6 +609,16 @@ mod private {
     }
 }
 
+impl From<FileType> for FileStatus {
+    fn from(value: FileType) -> Self {
+        match value {
+            FileType::File => FileStatus::Exists,
+            FileType::Symlink => FileStatus::Exists,
+            FileType::Directory => FileStatus::IsADirectory,
+        }
+    }
+}
+
 #[derive(Copy, Clone, Debug, Eq, PartialEq)]
 pub enum FileError {
     IsADirectory,

crates/ruff_db/src/files/file_root.rs

@@ -16,7 +16,7 @@ use crate::system::{SystemPath, SystemPathBuf};
 /// The main usage of file roots is to determine a file's durability. But it can also be used
 /// to make a salsa query dependent on whether a file in a root has changed without writing any
 /// manual invalidation logic.
-#[salsa::input(debug, heap_size=ruff_memory_usage::heap_size)]
+#[salsa::input(persist, debug, heap_size=ruff_memory_usage::heap_size)]
 pub struct FileRoot {
     /// The path of a root is guaranteed to never change.
     #[returns(deref)]
@@ -35,9 +35,20 @@ impl FileRoot {
     pub fn durability(self, db: &dyn Db) -> salsa::Durability {
         self.kind_at_time_of_creation(db).durability()
     }
+
+    /// Loads all existing [`FileRoot`]s in the database.
+    pub fn load_all(db: &dyn Db) -> Vec<FileRoot> {
+        // TODO: Prune deleted paths.
+        FileRoot::ingredient(db)
+            .entries(db.zalsa())
+            .map(|entry| entry.as_struct())
+            .collect()
+    }
 }
 
-#[derive(Copy, Clone, Debug, Eq, PartialEq, get_size2::GetSize)]
+#[derive(
+    Copy, Clone, Debug, Eq, PartialEq, get_size2::GetSize, serde::Serialize, serde::Deserialize,
+)]
 pub enum FileRootKind {
     /// The root of a project.
     Project,
@@ -47,7 +58,7 @@ pub enum FileRootKind {
 }
 
 impl FileRootKind {
-    const fn durability(self) -> Durability {
+    pub const fn durability(self) -> Durability {
         match self {
             FileRootKind::Project => Durability::LOW,
             FileRootKind::LibrarySearchPath => Durability::HIGH,
@@ -62,34 +73,34 @@ pub(super) struct FileRoots {
 }
 
 impl FileRoots {
-    /// Tries to add a new root for `path` and returns the root.
+    /// Tries to add a new root for `path`.
     ///
     /// The root isn't added nor is the file root's kind updated if a root for `path` already exists.
+    ///
+    /// Returns `Ok(root)` if the `FileRoot` was successfully added, and returns `Err(root)` with
+    /// the previous root if one already existed at that path.
     pub(super) fn try_add(
         &mut self,
         db: &dyn Db,
         path: SystemPathBuf,
-        kind: FileRootKind,
-    ) -> FileRoot {
+        create_root: impl FnOnce(SystemPathBuf) -> FileRoot,
+    ) -> Result<FileRoot, FileRoot> {
         // SAFETY: Guaranteed to succeed because `path` is a UTF-8 that only contains Unicode characters.
         let normalized_path = path.as_std_path().to_slash().unwrap();
 
         if let Ok(existing) = self.by_path.at(&normalized_path) {
             // Only if it is an exact match
             if existing.value.path(db) == &*path {
-                return *existing.value;
+                return Err(*existing.value);
             }
         }
 
-        // normalize the path to use `/` separators and escape the '{' and '}' characters,
-        // which matchit uses for routing parameters
+        // Normalize the path to use `/` separators and escape the '{' and '}' characters,
+        // which `matchit` uses for routing parameters.
         let mut route = normalized_path.replace('{', "{{").replace('}', "}}");
 
         // Insert a new source root
-        let root = FileRoot::builder(path, kind, FileRevision::now())
-            .durability(Durability::HIGH)
-            .revision_durability(kind.durability())
-            .new(db);
+        let root = create_root(path);
 
         // Insert a path that matches the root itself
         self.by_path.insert(route.clone(), root).unwrap();
@@ -100,7 +111,7 @@ impl FileRoots {
         self.by_path.insert(route, root).unwrap();
         self.roots.push(root);
 
-        root
+        Ok(root)
     }
 
     /// Returns the closest root for `path` or `None` if no root contains `path`.

crates/ruff_db/src/files/path.rs

@@ -11,7 +11,9 @@ use std::fmt::{Display, Formatter};
 /// * a file stored on the [host system](crate::system::System).
 /// * a virtual file stored on the [host system](crate::system::System).
 /// * a vendored file stored in the [vendored file system](crate::vendored::VendoredFileSystem).
-#[derive(Clone, Debug, Eq, PartialEq, Hash, get_size2::GetSize)]
+#[derive(
+    Clone, Debug, Eq, PartialEq, Hash, get_size2::GetSize, serde::Serialize, serde::Deserialize,
+)]
 pub enum FilePath {
     /// Path to a file on the [host system](crate::system::System).
     System(SystemPathBuf),

crates/ruff_db/src/source.rs

@@ -148,7 +148,16 @@ impl From<Notebook> for SourceTextKind {
     }
 }
 
-#[derive(Debug, thiserror::Error, PartialEq, Eq, Clone, get_size2::GetSize)]
+#[derive(
+    Debug,
+    thiserror::Error,
+    PartialEq,
+    Eq,
+    Clone,
+    get_size2::GetSize,
+    serde::Serialize,
+    serde::Deserialize,
+)]
 pub enum SourceTextError {
     #[error("Failed to read notebook: {0}`")]
     FailedToReadNotebook(String),

crates/ruff_db/src/system.rs

@@ -66,6 +66,9 @@ pub trait System: Debug + Sync + Send {
     /// See [dunce::canonicalize] for more information.
     fn canonicalize_path(&self, path: &SystemPath) -> Result<SystemPathBuf>;
 
+    /// Reads the content of the file at `path` into a bytes buffer.
+    fn read_to_end(&self, path: &SystemPath) -> Result<Vec<u8>>;
+
     /// Reads the content of the file at `path` into a [`String`].
     fn read_to_string(&self, path: &SystemPath) -> Result<String>;
 
@@ -242,7 +245,7 @@ pub trait WritableSystem: System {
     fn create_new_file(&self, path: &SystemPath) -> Result<()>;
 
     /// Writes the given content to the file at the given path.
-    fn write_file(&self, path: &SystemPath, content: &str) -> Result<()>;
+    fn write_file(&self, path: &SystemPath, content: &[u8]) -> Result<()>;
 
     /// Creates a directory at `path` as well as any intermediate directories.
     fn create_directory_all(&self, path: &SystemPath) -> Result<()>;
@@ -278,7 +281,7 @@ pub trait WritableSystem: System {
         // ensures that only one thread/process ever attempts to write to it to avoid corrupting
         // the cache.
         self.create_new_file(&cache_path)?;
-        self.write_file(&cache_path, &contents)?;
+        self.write_file(&cache_path, contents.as_bytes())?;
 
         Ok(Some(cache_path))
     }

crates/ruff_db/src/system/memory_fs.rs

@@ -114,8 +114,8 @@ impl MemoryFileSystem {
         matches!(by_path.get(&normalized), Some(Entry::Directory(_)))
     }
 
-    pub fn read_to_string(&self, path: impl AsRef<SystemPath>) -> Result<String> {
-        fn read_to_string(fs: &MemoryFileSystem, path: &SystemPath) -> Result<String> {
+    pub fn read_to_end(&self, path: impl AsRef<SystemPath>) -> Result<Vec<u8>> {
+        fn read_to_end(fs: &MemoryFileSystem, path: &SystemPath) -> Result<Vec<u8>> {
             let by_path = fs.inner.by_path.read().unwrap();
             let normalized = fs.normalize_path(path);
 
@@ -127,13 +127,18 @@ impl MemoryFileSystem {
             }
         }
 
-        read_to_string(self, path.as_ref())
+        read_to_end(self, path.as_ref())
     }
 
-    pub(crate) fn read_virtual_path_to_string(
+    pub fn read_to_string(&self, path: impl AsRef<SystemPath>) -> Result<String> {
+        self.read_to_end(path)
+            .and_then(|bytes| String::from_utf8(bytes).map_err(io::Error::other))
+    }
+
+    pub(crate) fn read_virtual_path_to_end(
         &self,
         path: impl AsRef<SystemVirtualPath>,
-    ) -> Result<String> {
+    ) -> Result<Vec<u8>> {
         let virtual_files = self.inner.virtual_files.read().unwrap();
         let file = virtual_files
             .get(&path.as_ref().to_path_buf())
@@ -142,6 +147,14 @@ impl MemoryFileSystem {
         Ok(file.content.clone())
     }
 
+    pub(crate) fn read_virtual_path_to_string(
+        &self,
+        path: impl AsRef<SystemVirtualPath>,
+    ) -> Result<String> {
+        self.read_virtual_path_to_end(path)
+            .and_then(|bytes| String::from_utf8(bytes).map_err(io::Error::other))
+    }
+
     pub fn exists(&self, path: &SystemPath) -> bool {
         let by_path = self.inner.by_path.read().unwrap();
         let normalized = self.normalize_path(path);
@@ -161,7 +174,7 @@ impl MemoryFileSystem {
         match by_path.entry(normalized) {
             btree_map::Entry::Vacant(entry) => {
                 entry.insert(Entry::File(File {
-                    content: String::new(),
+                    content: Vec::new(),
                     last_modified: file_time_now(),
                 }));
 
@@ -177,13 +190,17 @@ impl MemoryFileSystem {
     /// Stores a new file in the file system.
     ///
     /// The operation overrides the content for an existing file with the same normalized `path`.
-    pub fn write_file(&self, path: impl AsRef<SystemPath>, content: impl ToString) -> Result<()> {
+    pub fn write_file(
+        &self,
+        path: impl AsRef<SystemPath>,
+        content: impl Into<Vec<u8>>,
+    ) -> Result<()> {
         let mut by_path = self.inner.by_path.write().unwrap();
 
         let normalized = self.normalize_path(path.as_ref());
 
         let file = get_or_create_file(&mut by_path, &normalized)?;
-        file.content = content.to_string();
+        file.content = content.into();
         file.last_modified = file_time_now();
 
         Ok(())
@@ -214,7 +231,7 @@ impl MemoryFileSystem {
     pub fn write_file_all(
         &self,
         path: impl AsRef<SystemPath>,
-        content: impl ToString,
+        content: impl Into<Vec<u8>>,
     ) -> Result<()> {
         let path = path.as_ref();
 
@@ -228,19 +245,23 @@ impl MemoryFileSystem {
     /// Stores a new virtual file in the file system.
     ///
     /// The operation overrides the content for an existing virtual file with the same `path`.
-    pub fn write_virtual_file(&self, path: impl AsRef<SystemVirtualPath>, content: impl ToString) {
+    pub fn write_virtual_file(
+        &self,
+        path: impl AsRef<SystemVirtualPath>,
+        content: impl Into<Vec<u8>>,
+    ) {
         let path = path.as_ref();
         let mut virtual_files = self.inner.virtual_files.write().unwrap();
 
         match virtual_files.entry(path.to_path_buf()) {
             std::collections::hash_map::Entry::Vacant(entry) => {
                 entry.insert(File {
-                    content: content.to_string(),
+                    content: content.into(),
                     last_modified: file_time_now(),
                 });
             }
             std::collections::hash_map::Entry::Occupied(mut entry) => {
-                entry.get_mut().content = content.to_string();
+                entry.get_mut().content = content.into();
             }
         }
     }
@@ -468,7 +489,7 @@ impl Entry {
 
 #[derive(Debug)]
 struct File {
-    content: String,
+    content: Vec<u8>,
     last_modified: FileTime,
 }
 
@@ -533,7 +554,7 @@ fn get_or_create_file<'a>(
 
     let entry = paths.entry(normalized.to_path_buf()).or_insert_with(|| {
         Entry::File(File {
-            content: String::new(),
+            content: Vec::new(),
             last_modified: file_time_now(),
         })
     });

crates/ruff_db/src/system/os.rs

@@ -93,6 +93,10 @@ impl System for OsSystem {
         })
     }
 
+    fn read_to_end(&self, path: &SystemPath) -> Result<Vec<u8>> {
+        std::fs::read(path.as_std_path())
+    }
+
     fn read_to_string(&self, path: &SystemPath) -> Result<String> {
         std::fs::read_to_string(path.as_std_path())
     }
@@ -357,7 +361,7 @@ impl WritableSystem for OsSystem {
         std::fs::File::create_new(path).map(drop)
     }
 
-    fn write_file(&self, path: &SystemPath, content: &str) -> Result<()> {
+    fn write_file(&self, path: &SystemPath, content: &[u8]) -> Result<()> {
         std::fs::write(path.as_std_path(), content)
     }
 

crates/ruff_db/src/system/path.rs

@@ -762,7 +762,17 @@ impl SystemVirtualPath {
 }
 
 /// An owned, virtual path on [`System`](`super::System`) (akin to [`String`]).
-#[derive(Eq, PartialEq, Clone, Hash, PartialOrd, Ord, get_size2::GetSize)]
+#[derive(
+    Eq,
+    PartialEq,
+    Clone,
+    Hash,
+    PartialOrd,
+    Ord,
+    get_size2::GetSize,
+    serde::Serialize,
+    serde::Deserialize,
+)]
 pub struct SystemVirtualPathBuf(String);
 
 impl SystemVirtualPathBuf {

crates/ruff_db/src/system/test.rs

@@ -75,6 +75,10 @@ impl System for TestSystem {
         self.system().canonicalize_path(path)
     }
 
+    fn read_to_end(&self, path: &SystemPath) -> Result<Vec<u8>> {
+        self.system().read_to_end(path)
+    }
+
     fn read_to_string(&self, path: &SystemPath) -> Result<String> {
         self.system().read_to_string(path)
     }
@@ -165,7 +169,7 @@ impl WritableSystem for TestSystem {
         self.system().create_new_file(path)
     }
 
-    fn write_file(&self, path: &SystemPath, content: &str) -> Result<()> {
+    fn write_file(&self, path: &SystemPath, content: &[u8]) -> Result<()> {
         self.system().write_file(path, content)
     }
 
@@ -185,7 +189,9 @@ pub trait DbWithWritableSystem: Db + Sized {
     /// Writes the content of the given file and notifies the Db about the change.
     fn write_file(&mut self, path: impl AsRef<SystemPath>, content: impl AsRef<str>) -> Result<()> {
         let path = path.as_ref();
-        match self.writable_system().write_file(path, content.as_ref()) {
+        let content = content.as_ref();
+
+        match self.writable_system().write_file(path, content.as_bytes()) {
             Ok(()) => {
                 File::sync_path(self, path);
                 Ok(())
@@ -198,7 +204,8 @@ pub trait DbWithWritableSystem: Db + Sized {
                         File::sync_path(self, ancestor);
                     }
 
-                    self.writable_system().write_file(path, content.as_ref())?;
+                    self.writable_system()
+                        .write_file(path, content.as_bytes())?;
                     File::sync_path(self, path);
 
                     Ok(())
@@ -243,8 +250,14 @@ pub trait DbWithTestSystem: Db + Sized {
     ///
     /// ## Panics
     /// If the db isn't using the [`InMemorySystem`].
-    fn write_virtual_file(&mut self, path: impl AsRef<SystemVirtualPath>, content: impl ToString) {
+    fn write_virtual_file(
+        &mut self,
+        path: impl AsRef<SystemVirtualPath>,
+        content: impl Into<Vec<u8>>,
+    ) {
         let path = path.as_ref();
+        let content = content.into();
+
         self.test_system()
             .memory_file_system()
             .write_virtual_file(path, content);
@@ -322,6 +335,10 @@ impl System for InMemorySystem {
         self.memory_fs.canonicalize(path)
     }
 
+    fn read_to_end(&self, path: &SystemPath) -> Result<Vec<u8>> {
+        self.memory_fs.read_to_end(path)
+    }
+
     fn read_to_string(&self, path: &SystemPath) -> Result<String> {
         self.memory_fs.read_to_string(path)
     }
@@ -412,7 +429,7 @@ impl WritableSystem for InMemorySystem {
         self.memory_fs.create_new_file(path)
     }
 
-    fn write_file(&self, path: &SystemPath, content: &str) -> Result<()> {
+    fn write_file(&self, path: &SystemPath, content: &[u8]) -> Result<()> {
         self.memory_fs.write_file(path, content)
     }
 

crates/ruff_db/src/vendored/path.rs

@@ -88,7 +88,7 @@ impl ToOwned for VendoredPath {
 }
 
 #[repr(transparent)]
-#[derive(Debug, Eq, PartialEq, Clone, Hash)]
+#[derive(Debug, Eq, PartialEq, Clone, Hash, serde::Serialize, serde::Deserialize)]
 pub struct VendoredPathBuf(Utf8PathBuf);
 
 impl get_size2::GetSize for VendoredPathBuf {

crates/ruff_dev/Cargo.toml

@@ -13,7 +13,6 @@ license = { workspace = true }
 [dependencies]
 ty = { workspace = true }
 ty_project = { workspace = true, features = ["schemars"] }
-ty_python_semantic = { workspace = true }
 ty_static = { workspace = true }
 ruff = { workspace = true }
 ruff_formatter = { workspace = true }

crates/ruff_dev/src/generate_ty_rules.rs

@@ -52,7 +52,7 @@ pub(crate) fn main(args: &Args) -> Result<()> {
 }
 
 fn generate_markdown() -> String {
-    let registry = ty_python_semantic::default_lint_registry();
+    let registry = &*ty_project::DEFAULT_LINT_REGISTRY;
 
     let mut output = String::new();
 

crates/ruff_formatter/src/lib.rs

@@ -81,19 +81,14 @@ impl IndentStyle {
     pub const fn is_space(&self) -> bool {
         matches!(self, IndentStyle::Space)
     }
-
-    /// Returns the string representation of the indent style.
-    pub const fn as_str(&self) -> &'static str {
-        match self {
-            IndentStyle::Tab => "tab",
-            IndentStyle::Space => "space",
-        }
-    }
 }
 
 impl std::fmt::Display for IndentStyle {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        f.write_str(self.as_str())
+        match self {
+            IndentStyle::Tab => std::write!(f, "tab"),
+            IndentStyle::Space => std::write!(f, "space"),
+        }
     }
 }
 

crates/ruff_formatter/src/printer/printer_options/mod.rs

@@ -139,16 +139,4 @@ impl LineEnding {
             LineEnding::CarriageReturn => "\r",
         }
     }
-
-    /// Returns the string used to configure this line ending.
-    ///
-    /// See [`LineEnding::as_str`] for the actual string representation of the line ending.
-    #[inline]
-    pub const fn as_setting_str(&self) -> &'static str {
-        match self {
-            LineEnding::LineFeed => "lf",
-            LineEnding::CarriageReturnLineFeed => "crlf",
-            LineEnding::CarriageReturn => "cr",
-        }
-    }
 }

crates/ruff_linter/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ruff_linter"
-version = "0.12.12"
+version = "0.12.10"
 publish = false
 authors = { workspace = true }
 edition = { workspace = true }
@@ -51,6 +51,7 @@ path-absolutize = { workspace = true, features = [
     "once_cell_cache",
     "use_unix_paths_on_wasm",
 ] }
+pathdiff = { workspace = true }
 pep440_rs = { workspace = true }
 pyproject-toml = { workspace = true }
 regex = { workspace = true }

crates/ruff_linter/resources/test/fixtures/airflow/AIR301_names.py

@@ -12,7 +12,6 @@ from airflow import (
 from airflow.api_connexion.security import requires_access
 from airflow.contrib.aws_athena_hook import AWSAthenaHook
 from airflow.datasets import DatasetAliasEvent
-from airflow.operators.postgres_operator import Mapping
 from airflow.operators.subdag import SubDagOperator
 from airflow.secrets.cache import SecretCache
 from airflow.secrets.local_filesystem import LocalFilesystemBackend
@@ -53,8 +52,6 @@ DatasetAliasEvent()
 # airflow.operators.subdag.*
 SubDagOperator()
 
-# airflow.operators.postgres_operator
-Mapping()
 
 # airflow.secrets
 # get_connection

crates/ruff_linter/resources/test/fixtures/airflow/AIR311_names.py

@@ -34,7 +34,7 @@ task_group()
 setup()
 from airflow.decorators import teardown
 from airflow.io.path import ObjectStoragePath
-from airflow.io.store import attach
+from airflow.io.storage import attach
 from airflow.models import DAG as DAGFromModel
 from airflow.models import (
     Connection,
@@ -70,40 +70,7 @@ from airflow.timetables.datasets import DatasetOrTimeSchedule
 from airflow.utils.dag_parsing_context import get_parsing_context
 
 # airflow.timetables.datasets
-DatasetOrTimeSchedule(datasets=[])
+DatasetOrTimeSchedule()
 
 # airflow.utils.dag_parsing_context
 get_parsing_context()
-
-from airflow.decorators.base import (
-    DecoratedMappedOperator,
-    DecoratedOperator,
-    TaskDecorator,
-    get_unique_task_id,
-    task_decorator_factory,
-)
-
-# airflow.decorators.base
-DecoratedMappedOperator()
-DecoratedOperator()
-TaskDecorator()
-get_unique_task_id()
-task_decorator_factory()
-
-
-from airflow.models import Param
-
-# airflow.models
-Param()
-
-
-from airflow.sensors.base import (
-    BaseSensorOperator,
-    PokeReturnValue,
-    poke_mode_only,
-)
-
-# airflow.sensors.base
-BaseSensorOperator()
-PokeReturnValue()
-poke_mode_only()

crates/ruff_linter/resources/test/fixtures/airflow/AIR312.py

@@ -9,6 +9,7 @@ from airflow.operators.empty import EmptyOperator
 from airflow.operators.latest_only import LatestOnlyOperator
 from airflow.operators.trigger_dagrun import TriggerDagRunOperator
 from airflow.operators.weekday import BranchDayOfWeekOperator
+from airflow.sensors.date_time import DateTimeSensor
 
 FSHook()
 PackageIndexHook()
@@ -21,6 +22,7 @@ EmptyOperator()
 
 LatestOnlyOperator()
 BranchDayOfWeekOperator()
+DateTimeSensor()
 
 from airflow.operators.python import (
     BranchPythonOperator,
@@ -28,23 +30,16 @@ from airflow.operators.python import (
     PythonVirtualenvOperator,
     ShortCircuitOperator,
 )
-from airflow.sensors.bash import BashSensor
-from airflow.sensors.date_time import DateTimeSensor
-
-BranchPythonOperator()
-PythonOperator()
-PythonVirtualenvOperator()
-ShortCircuitOperator()
-
-BashSensor()
-DateTimeSensor()
 from airflow.sensors.date_time import DateTimeSensorAsync
 from airflow.sensors.external_task import (
     ExternalTaskMarker,
     ExternalTaskSensor,
 )
+from airflow.sensors.time_sensor import (
+    TimeSensor,
+    TimeSensorAsync,
+)
 from airflow.sensors.filesystem import FileSensor
-from airflow.sensors.python import PythonSensor
 
 BranchPythonOperator()
 PythonOperator()
@@ -54,13 +49,6 @@ DateTimeSensorAsync()
 ExternalTaskMarker()
 ExternalTaskSensor()
 FileSensor()
-PythonSensor()
-
-from airflow.sensors.time_sensor import (
-    TimeSensor,
-    TimeSensorAsync,
-)
-
 TimeSensor()
 TimeSensorAsync()
 

crates/ruff_linter/resources/test/fixtures/fastapi/FAST003.py

@@ -213,17 +213,3 @@ async def get_id_pydantic_full(
 async def get_id_pydantic_short(params: Annotated[PydanticParams, Depends()]): ...
 @app.get("/{my_id}")
 async def get_id_init_not_annotated(params = Depends(InitParams)): ...
-
-@app.get("/things/{ thing_id }")
-async def read_thing(query: str):
-    return {"query": query}
-
-
-@app.get("/things/{ thing_id : path }")
-async def read_thing(query: str):
-    return {"query": query}
-
-
-@app.get("/things/{ thing_id : str }")
-async def read_thing(query: str):
-    return {"query": query}

crates/ruff_linter/resources/test/fixtures/flake8_async/ASYNC212.py

@@ -1,75 +0,0 @@
-from typing import Optional
-
-import httpx
-
-
-def foo():
-    client = httpx.Client()
-    client.close()  # Ok
-    client.delete()  # Ok
-    client.get()  # Ok
-    client.head()  # Ok
-    client.options()  # Ok
-    client.patch()  # Ok
-    client.post()  # Ok
-    client.put()  # Ok
-    client.request()  # Ok
-    client.send()  # Ok
-    client.stream()  # Ok
-
-    client.anything()  # Ok
-    client.build_request()  # Ok
-    client.is_closed  # Ok
-
-
-async def foo():
-    client = httpx.Client()
-    client.close()  # ASYNC212
-    client.delete()  # ASYNC212
-    client.get()  # ASYNC212
-    client.head()  # ASYNC212
-    client.options()  # ASYNC212
-    client.patch()  # ASYNC212
-    client.post()  # ASYNC212
-    client.put()  # ASYNC212
-    client.request()  # ASYNC212
-    client.send()  # ASYNC212
-    client.stream()  # ASYNC212
-
-    client.anything()  # Ok
-    client.build_request()  # Ok
-    client.is_closed  # Ok
-
-
-async def foo(client: httpx.Client):
-    client.request()  # ASYNC212
-    client.anything()  # Ok
-
-
-async def foo(client: httpx.Client | None):
-    client.request()  # ASYNC212
-    client.anything()  # Ok
-
-
-async def foo(client: Optional[httpx.Client]):
-    client.request()  # ASYNC212
-    client.anything()  # Ok
-
-
-async def foo():
-    client: httpx.Client = ...
-    client.request()  # ASYNC212
-    client.anything()  # Ok
-
-
-global_client = httpx.Client()
-
-
-async def foo():
-    global_client.request()  # ASYNC212
-    global_client.anything()  # Ok
-
-
-async def foo():
-    async with httpx.AsyncClient() as client:
-        await client.get()  # Ok

crates/ruff_linter/resources/test/fixtures/flake8_async/ASYNC250.py

@@ -1,22 +0,0 @@
-def foo():
-    k = input()  # Ok
-    input("hello world")  # Ok
-
-
-async def foo():
-    k = input()  # ASYNC250
-    input("hello world")  # ASYNC250
-
-
-import builtins
-
-import fake
-
-
-def foo():
-    builtins.input("testing")  # Ok
-
-
-async def foo():
-    builtins.input("testing")  # ASYNC250
-    fake.input("whatever")  # Ok

crates/ruff_linter/resources/test/fixtures/flake8_comprehensions/C417.py

@@ -75,7 +75,3 @@ list(map(lambda x, y: x, [(1, 2), (3, 4)]))
 _ = t"{set(map(lambda x: x % 2 == 0, nums))}"
 _ = t"{dict(map(lambda v: (v, v**2), nums))}"
 
-
-# See https://github.com/astral-sh/ruff/issues/20198
-# No error: lambda contains `yield`, so map() should not be rewritten
-map(lambda x: (yield x), [1, 2, 3])

crates/ruff_linter/resources/test/fixtures/flake8_logging_format/G004.py

@@ -17,50 +17,3 @@ info(f"{__name__}")
 # Don't trigger for t-strings
 info(t"{name}")
 info(t"{__name__}")
-
-count = 5
-total = 9
-directory_path = "/home/hamir/ruff/crates/ruff_linter/resources/test/"
-logging.info(f"{count} out of {total} files in {directory_path} checked")
-
-
-
-x = 99
-fmt = "08d"
-logger.info(f"{x:{'08d'}}")
-logger.info(f"{x:>10} {x:{fmt}}")
-
-logging.info(f"")
-logging.info(f"This message doesn't have any variables.")
-
-obj = {"key": "value"}
-logging.info(f"Object: {obj!r}")
-
-items_count = 3
-logging.warning(f"Items: {items_count:d}")
-
-data = {"status": "active"}
-logging.info(f"Processing {len(data)} items")
-logging.info(f"Status: {data.get('status', 'unknown').upper()}")
-
-
-result = 123
-logging.info(f"Calculated result: {result + 100}")
-
-temperature = 123
-logging.info(f"Temperature: {temperature:.1f}°C")
-
-class FilePath:
-    def __init__(self, name: str):
-        self.name = name
-
-logging.info(f"No changes made to {file_path.name}.")
-
-user = "tron"
-balance = 123.45
-logging.error(f"Error {404}: User {user} has insufficient balance ${balance:.2f}")
-
-import logging
-
-x = 1
-logging.error(f"{x} -> %s", x)

crates/ruff_linter/resources/test/fixtures/flake8_logging_format/G004_arg_order.py

@@ -1,10 +0,0 @@
-"""Test f-string argument order."""
-
-import logging
-
-logger = logging.getLogger(__name__)
-
-X = 1
-Y = 2
-logger.error(f"{X} -> %s", Y)
-logger.error(f"{Y} -> %s", X)

crates/ruff_linter/resources/test/fixtures/flake8_pytest_style/PT015.py

@@ -23,11 +23,3 @@ def test_error():
     assert list([])
     assert set(set())
     assert tuple("")
-
-# https://github.com/astral-sh/ruff/issues/19935
-def test_all_ok():
-    assert f"{b""}"
-    assert f"{""=}"
-    assert f"{""!a}"
-    assert f"{""!r}"
-    assert f"{"":1}"

crates/ruff_linter/resources/test/fixtures/perflint/PERF403.py

@@ -192,24 +192,3 @@ def issue_19005_3():
     c = {}
     for a[0], a[1] in ():
         c[a[0]] = a[1]
-
-
-def issue_19153_1():
-    v = {}
-    for o, (x,) in ["ox"]:
-        v[x,] = o
-    return v
-
-
-def issue_19153_2():
-    v = {}
-    for (o, p), x in [("op", "x")]:
-        v[x] = o, p
-    return v
-
-
-def issue_19153_3():
-    v = {}
-    for o, (x,) in ["ox"]: 
-        v[(x,)] = o 
-    return v

crates/ruff_linter/resources/test/fixtures/pycodestyle/E731.py

@@ -190,12 +190,3 @@ foo_tooltip = (
     more
 
 )
-
-# https://github.com/astral-sh/ruff/issues/20097
-def scope():
-    from collections.abc import Callable
-    from typing import ParamSpec
-
-    P = ParamSpec("P")
-    f1: Callable[P, str] = lambda x: str(x)
-    f2: Callable[..., str] = lambda x: str(x)

crates/ruff_linter/resources/test/fixtures/pyflakes/F401_35.py

@@ -1,16 +0,0 @@
-"""
-Test: allowed-unused-imports-top-level-module
-"""
-
-# No errors
-
-def f():
-    import hvplot
-def f():
-    import hvplot.pandas
-def f():
-    import hvplot.pandas.plots
-def f():
-    from hvplot.pandas import scatter_matrix
-def f():
-    from hvplot.pandas.plots import scatter_matrix

crates/ruff_linter/resources/test/fixtures/pyflakes/F841_0.py

@@ -151,39 +151,3 @@ def f():
         pass
     except Exception as _:
         pass
-
-
-# OK, `__class__` in this case is not the special `__class__` cell, so we don't
-# emit a diagnostic. (It has its own special semantics -- see
-# https://github.com/astral-sh/ruff/pull/20048#discussion_r2298338048 -- but
-# those aren't relevant here.)
-class A:
-    __class__ = 1
-
-
-# The following three cases are flagged because they declare local `__class__`
-# variables that don't refer to the special `__class__` cell.
-class A:
-    def set_class(self, cls):
-        __class__ = cls  # F841
-
-
-class A:
-    class B:
-        def set_class(self, cls):
-            __class__ = cls  # F841
-
-
-class A:
-    def foo():
-        class B:
-            print(__class__)
-            def set_class(self, cls):
-                __class__ = cls  # F841
-
-
-# OK, the `__class__` cell is nonlocal and declared as such.
-class NonlocalDunderClass:
-    def foo():
-        nonlocal __class__
-        __class__ = 1

crates/ruff_linter/resources/test/fixtures/pylint/bidirectional_unicode.py

@@ -4,9 +4,6 @@ print("שלום‬")
 # E2502
 example = "x‏" * 100  #    "‏x" is assigned
 
-# E2502
-another = "x؜" * 50  #    "؜x" is assigned
-
 # E2502
 if access_level != "none‮⁦":  # Check if admin ⁩⁦' and access_level != 'user
     print("You are an admin.")

crates/ruff_linter/resources/test/fixtures/pylint/nonlocal_without_binding.py

@@ -44,8 +44,3 @@ def f():
     def g():
         nonlocal x
         x = 2
-
-# OK
-class A:
-    def method(self):
-        nonlocal __class__

crates/ruff_linter/resources/test/fixtures/pyupgrade/UP008.py

@@ -141,133 +141,3 @@ class ExampleWithKeywords:
     
     def method3(self):
         super(ExampleWithKeywords, self).some_method()  # Should be fixed - no keywords
-
-# See: https://github.com/astral-sh/ruff/issues/19357
-# Must be detected
-class ParentD:
-    def f(self):
-        print("D")
-
-class ChildD1(ParentD):
-    def f(self):
-        if False: __class__ # Python injects __class__ into scope
-        builtins.super(ChildD1, self).f()
-
-class ChildD2(ParentD):
-    def f(self):
-        if False: super # Python injects __class__ into scope
-        builtins.super(ChildD2, self).f()
-
-class ChildD3(ParentD):
-    def f(self):
-        builtins.super(ChildD3, self).f()
-        super # Python injects __class__ into scope
-
-import builtins as builtins_alias
-class ChildD4(ParentD):
-    def f(self):
-        builtins_alias.super(ChildD4, self).f()
-        super # Python injects __class__ into scope
-
-class ChildD5(ParentD):
-    def f(self):
-        super = 1
-        super # Python injects __class__ into scope
-        builtins.super(ChildD5, self).f()
-
-class ChildD6(ParentD):
-    def f(self):
-        super: "Any"
-        __class__ # Python injects __class__ into scope
-        builtins.super(ChildD6, self).f()
-
-class ChildD7(ParentD):
-    def f(self):
-        def x():
-            __class__ # Python injects __class__ into scope
-        builtins.super(ChildD7, self).f()
-
-class ChildD8(ParentD):
-    def f(self):
-        def x():
-            super = 1
-        super # Python injects __class__ into scope
-        builtins.super(ChildD8, self).f()
-
-class ChildD9(ParentD):
-    def f(self):
-        def x():
-            __class__ = 1
-        __class__ # Python injects __class__ into scope
-        builtins.super(ChildD9, self).f()
-
-class ChildD10(ParentD):
-    def f(self):
-        def x():
-            __class__ = 1
-        super # Python injects __class__ into scope
-        builtins.super(ChildD10, self).f()
-
-
-# Must be ignored
-class ParentI:
-    def f(self):
-        print("I")
-
-class ChildI1(ParentI):
-    def f(self):
-        builtins.super(ChildI1, self).f() # no __class__ in the local scope
-
-
-class ChildI2(ParentI):
-    def b(self):
-        x = __class__
-        if False: super
-
-    def f(self):
-        self.b()
-        builtins.super(ChildI2, self).f() # no __class__ in the local scope
-
-class ChildI3(ParentI):
-    def f(self):
-        if False: super
-        def x(_):
-            builtins.super(ChildI3, self).f() # no __class__ in the local scope
-        x(None)
-
-class ChildI4(ParentI):
-    def f(self):
-        super: "str"
-        builtins.super(ChildI4, self).f() # no __class__ in the local scope
-
-class ChildI5(ParentI):
-    def f(self):
-        super = 1
-        __class__ = 3
-        builtins.super(ChildI5, self).f() # no __class__ in the local scope
-
-class ChildI6(ParentI):
-    def f(self):
-        __class__ = None
-        __class__
-        builtins.super(ChildI6, self).f() # no __class__ in the local scope
-
-class ChildI7(ParentI):
-    def f(self):
-        __class__ = None
-        super
-        builtins.super(ChildI7, self).f()
-
-class ChildI8(ParentI):
-    def f(self):
-        __class__: "Any"
-        super
-        builtins.super(ChildI8, self).f()
-
-class ChildI9(ParentI):
-    def f(self):
-        class A:
-            def foo(self):
-                if False: super
-                if False: __class__
-        builtins.super(ChildI9, self).f()

crates/ruff_linter/resources/test/fixtures/pyupgrade/UP043.pyi

@@ -1,59 +0,0 @@
-from collections.abc import Generator, AsyncGenerator
-
-
-def func() -> Generator[int, None, None]:
-    yield 42
-
-
-def func() -> Generator[int, None]:
-    yield 42
-
-
-def func() -> Generator[int]:
-    yield 42
-
-
-def func() -> Generator[int, int, int]:
-    foo = yield 42
-    return foo
-
-
-def func() -> Generator[int, int, None]:
-    _ = yield 42
-    return None
-
-
-def func() -> Generator[int, None, int]:
-    yield 42
-    return 42
-
-
-async def func() -> AsyncGenerator[int, None]:
-    yield 42
-
-
-async def func() -> AsyncGenerator[int]:
-    yield 42
-
-
-async def func() -> AsyncGenerator[int, int]:
-    foo = yield 42
-    return foo
-
-
-from typing import Generator, AsyncGenerator
-
-
-def func() -> Generator[str, None, None]:
-    yield "hello"
-
-
-async def func() -> AsyncGenerator[str, None]:
-    yield "hello"
-
-
-async def func() -> AsyncGenerator[  # type: ignore
-    str,
-    None
-]:
-    yield "hello"

crates/ruff_linter/resources/test/fixtures/ruff/RUF033.py

@@ -124,19 +124,3 @@ def fun_with_python_syntax():
             ...
 
     return Foo
-
-
-@dataclass
-class C:
-    def __post_init__(self, x: tuple[int, ...] = (
-        1,
-        2,
-    )) -> None:
-        self.x = x
-
-
-@dataclass
-class D:
-    def __post_init__(self, x: int = """
-    """) -> None:
-        self.x = x

crates/ruff_linter/resources/test/fixtures/ruff/RUF037.py

@@ -107,12 +107,3 @@ deque(f"{x}" "")  # OK
 deque(t"")
 deque(t""  t"")
 deque(t"{""}") # OK
-
-# https://github.com/astral-sh/ruff/issues/20050
-deque(f"{""}")  # RUF037
-
-deque(f"{b""}")
-deque(f"{""=}")
-deque(f"{""!a}")
-deque(f"{""!r}")
-deque(f"{"":1}")

crates/ruff_linter/resources/test/fixtures/ruff/RUF060.py

@@ -42,7 +42,3 @@ b"a" in bytes("a", "utf-8")
 1 in set(set([1]))
 '' in {""}
 frozenset() in {frozenset()}
-
-# https://github.com/astral-sh/ruff/issues/20238
-"b" in f"" "" # Error
-"b" in f"" "x" # OK

crates/ruff_linter/resources/test/fixtures/syntax_errors/yield_from_in_async_function.py

@@ -1 +0,0 @@
-async def f(): yield from x # error

crates/ruff_linter/src/checkers/ast/analyze/expression.rs

@@ -8,7 +8,7 @@ use ruff_text_size::Ranged;
 
 use crate::checkers::ast::Checker;
 use crate::preview::{
-    is_optional_as_none_in_union_enabled, is_unnecessary_default_type_args_stubs_enabled,
+    is_assert_raises_exception_call_enabled, is_optional_as_none_in_union_enabled,
 };
 use crate::registry::Rule;
 use crate::rules::{
@@ -142,10 +142,7 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
             }
 
             if checker.is_rule_enabled(Rule::UnnecessaryDefaultTypeArgs) {
-                if checker.target_version() >= PythonVersion::PY313
-                    || is_unnecessary_default_type_args_stubs_enabled(checker.settings())
-                        && checker.semantic().in_stub_file()
-                {
+                if checker.target_version() >= PythonVersion::PY313 {
                     pyupgrade::rules::unnecessary_default_type_args(checker, expr);
                 }
             }
@@ -663,9 +660,6 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
             if checker.is_rule_enabled(Rule::BlockingHttpCallInAsyncFunction) {
                 flake8_async::rules::blocking_http_call(checker, call);
             }
-            if checker.is_rule_enabled(Rule::BlockingHttpCallHttpxInAsyncFunction) {
-                flake8_async::rules::blocking_http_call_httpx(checker, call);
-            }
             if checker.is_rule_enabled(Rule::BlockingOpenCallInAsyncFunction) {
                 flake8_async::rules::blocking_open_call(checker, call);
             }
@@ -676,9 +670,6 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
             ]) {
                 flake8_async::rules::blocking_process_invocation(checker, call);
             }
-            if checker.is_rule_enabled(Rule::BlockingInputInAsyncFunction) {
-                flake8_async::rules::blocking_input(checker, call);
-            }
             if checker.is_rule_enabled(Rule::BlockingSleepInAsyncFunction) {
                 flake8_async::rules::blocking_sleep(checker, call);
             }
@@ -1055,6 +1046,7 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
                 Rule::PyPath,
                 Rule::Glob,
                 Rule::OsListdir,
+                Rule::OsSymlink,
             ]) {
                 flake8_use_pathlib::rules::replaceable_by_pathlib(checker, call);
             }
@@ -1295,7 +1287,9 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
             if checker.is_rule_enabled(Rule::NonOctalPermissions) {
                 ruff::rules::non_octal_permissions(checker, call);
             }
-            if checker.is_rule_enabled(Rule::AssertRaisesException) {
+            if checker.is_rule_enabled(Rule::AssertRaisesException)
+                && is_assert_raises_exception_call_enabled(checker.settings())
+            {
                 flake8_bugbear::rules::assert_raises_exception_call(checker, call);
             }
         }
@@ -1320,10 +1314,13 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
                 pylint::rules::yield_in_init(checker, expr);
             }
         }
-        Expr::YieldFrom(_) => {
+        Expr::YieldFrom(yield_from) => {
             if checker.is_rule_enabled(Rule::YieldInInit) {
                 pylint::rules::yield_in_init(checker, expr);
             }
+            if checker.is_rule_enabled(Rule::YieldFromInAsyncFunction) {
+                pylint::rules::yield_from_in_async_function(checker, yield_from);
+            }
         }
         Expr::FString(f_string_expr @ ast::ExprFString { value, .. }) => {
             if checker.is_rule_enabled(Rule::FStringMissingPlaceholders) {

crates/ruff_linter/src/checkers/ast/mod.rs

@@ -71,9 +71,7 @@ use crate::registry::Rule;
 use crate::rules::pyflakes::rules::{
     LateFutureImport, ReturnOutsideFunction, YieldOutsideFunction,
 };
-use crate::rules::pylint::rules::{
-    AwaitOutsideAsync, LoadBeforeGlobalDeclaration, YieldFromInAsyncFunction,
-};
+use crate::rules::pylint::rules::{AwaitOutsideAsync, LoadBeforeGlobalDeclaration};
 use crate::rules::{flake8_pyi, flake8_type_checking, pyflakes, pyupgrade};
 use crate::settings::rule_table::RuleTable;
 use crate::settings::{LinterSettings, TargetVersion, flags};
@@ -670,12 +668,6 @@ impl SemanticSyntaxContext for Checker<'_> {
                     self.report_diagnostic(AwaitOutsideAsync, error.range);
                 }
             }
-            SemanticSyntaxErrorKind::YieldFromInAsyncFunction => {
-                // PLE1700
-                if self.is_rule_enabled(Rule::YieldFromInAsyncFunction) {
-                    self.report_diagnostic(YieldFromInAsyncFunction, error.range);
-                }
-            }
             SemanticSyntaxErrorKind::ReboundComprehensionVariable
             | SemanticSyntaxErrorKind::DuplicateTypeParameter
             | SemanticSyntaxErrorKind::MultipleCaseAssignment(_)
@@ -711,10 +703,7 @@ impl SemanticSyntaxContext for Checker<'_> {
             match scope.kind {
                 ScopeKind::Class(_) | ScopeKind::Lambda(_) => return false,
                 ScopeKind::Function(ast::StmtFunctionDef { is_async, .. }) => return *is_async,
-                ScopeKind::Generator { .. }
-                | ScopeKind::Module
-                | ScopeKind::Type
-                | ScopeKind::DunderClassCell => {}
+                ScopeKind::Generator { .. } | ScopeKind::Module | ScopeKind::Type => {}
             }
         }
         false
@@ -725,10 +714,7 @@ impl SemanticSyntaxContext for Checker<'_> {
             match scope.kind {
                 ScopeKind::Class(_) => return false,
                 ScopeKind::Function(_) | ScopeKind::Lambda(_) => return true,
-                ScopeKind::Generator { .. }
-                | ScopeKind::Module
-                | ScopeKind::Type
-                | ScopeKind::DunderClassCell => {}
+                ScopeKind::Generator { .. } | ScopeKind::Module | ScopeKind::Type => {}
             }
         }
         false
@@ -739,7 +725,7 @@ impl SemanticSyntaxContext for Checker<'_> {
             match scope.kind {
                 ScopeKind::Class(_) | ScopeKind::Generator { .. } => return false,
                 ScopeKind::Function(_) | ScopeKind::Lambda(_) => return true,
-                ScopeKind::Module | ScopeKind::Type | ScopeKind::DunderClassCell => {}
+                ScopeKind::Module | ScopeKind::Type => {}
             }
         }
         false
@@ -1106,24 +1092,6 @@ impl<'a> Visitor<'a> for Checker<'a> {
                     }
                 }
 
-                // Here we add the implicit scope surrounding a method which allows code in the
-                // method to access `__class__` at runtime. See the `ScopeKind::DunderClassCell`
-                // docs for more information.
-                let added_dunder_class_scope = if self.semantic.current_scope().kind.is_class() {
-                    self.semantic.push_scope(ScopeKind::DunderClassCell);
-                    let binding_id = self.semantic.push_binding(
-                        TextRange::default(),
-                        BindingKind::DunderClassCell,
-                        BindingFlags::empty(),
-                    );
-                    self.semantic
-                        .current_scope_mut()
-                        .add("__class__", binding_id);
-                    true
-                } else {
-                    false
-                };
-
                 self.semantic.push_scope(ScopeKind::Type);
 
                 if let Some(type_params) = type_params {
@@ -1187,9 +1155,6 @@ impl<'a> Visitor<'a> for Checker<'a> {
                 self.semantic.pop_scope(); // Function scope
                 self.semantic.pop_definition();
                 self.semantic.pop_scope(); // Type parameter scope
-                if added_dunder_class_scope {
-                    self.semantic.pop_scope(); // `__class__` cell closure scope
-                }
                 self.add_binding(
                     name,
                     stmt.identifier(),

crates/ruff_linter/src/codes.rs

@@ -334,14 +334,12 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Flake8Async, "109") => (RuleGroup::Stable, rules::flake8_async::rules::AsyncFunctionWithTimeout),
         (Flake8Async, "110") => (RuleGroup::Stable, rules::flake8_async::rules::AsyncBusyWait),
         (Flake8Async, "115") => (RuleGroup::Stable, rules::flake8_async::rules::AsyncZeroSleep),
-        (Flake8Async, "116") => (RuleGroup::Stable, rules::flake8_async::rules::LongSleepNotForever),
+        (Flake8Async, "116") => (RuleGroup::Preview, rules::flake8_async::rules::LongSleepNotForever),
         (Flake8Async, "210") => (RuleGroup::Stable, rules::flake8_async::rules::BlockingHttpCallInAsyncFunction),
-        (Flake8Async, "212") => (RuleGroup::Preview, rules::flake8_async::rules::BlockingHttpCallHttpxInAsyncFunction),
         (Flake8Async, "220") => (RuleGroup::Stable, rules::flake8_async::rules::CreateSubprocessInAsyncFunction),
         (Flake8Async, "221") => (RuleGroup::Stable, rules::flake8_async::rules::RunProcessInAsyncFunction),
         (Flake8Async, "222") => (RuleGroup::Stable, rules::flake8_async::rules::WaitForProcessInAsyncFunction),
         (Flake8Async, "230") => (RuleGroup::Stable, rules::flake8_async::rules::BlockingOpenCallInAsyncFunction),
-        (Flake8Async, "250") => (RuleGroup::Preview, rules::flake8_async::rules::BlockingInputInAsyncFunction),
         (Flake8Async, "251") => (RuleGroup::Stable, rules::flake8_async::rules::BlockingSleepInAsyncFunction),
 
         // flake8-builtins
@@ -563,7 +561,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Pyupgrade, "035") => (RuleGroup::Stable, rules::pyupgrade::rules::DeprecatedImport),
         (Pyupgrade, "036") => (RuleGroup::Stable, rules::pyupgrade::rules::OutdatedVersionBlock),
         (Pyupgrade, "037") => (RuleGroup::Stable, rules::pyupgrade::rules::QuotedAnnotation),
-        (Pyupgrade, "038") => (RuleGroup::Removed, rules::pyupgrade::rules::NonPEP604Isinstance),
+        (Pyupgrade, "038") => (RuleGroup::Deprecated, rules::pyupgrade::rules::NonPEP604Isinstance),
         (Pyupgrade, "039") => (RuleGroup::Stable, rules::pyupgrade::rules::UnnecessaryClassParentheses),
         (Pyupgrade, "040") => (RuleGroup::Stable, rules::pyupgrade::rules::NonPEP695TypeAlias),
         (Pyupgrade, "041") => (RuleGroup::Stable, rules::pyupgrade::rules::TimeoutErrorAlias),
@@ -574,7 +572,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Pyupgrade, "046") => (RuleGroup::Stable, rules::pyupgrade::rules::NonPEP695GenericClass),
         (Pyupgrade, "047") => (RuleGroup::Stable, rules::pyupgrade::rules::NonPEP695GenericFunction),
         (Pyupgrade, "049") => (RuleGroup::Stable, rules::pyupgrade::rules::PrivateTypeParameter),
-        (Pyupgrade, "050") => (RuleGroup::Stable, rules::pyupgrade::rules::UselessClassMetaclassType),
+        (Pyupgrade, "050") => (RuleGroup::Preview, rules::pyupgrade::rules::UselessClassMetaclassType),
 
         // pydocstyle
         (Pydocstyle, "100") => (RuleGroup::Stable, rules::pydocstyle::rules::UndocumentedPublicModule),
@@ -773,7 +771,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (PandasVet, "013") => (RuleGroup::Stable, rules::pandas_vet::rules::PandasUseOfDotStack),
         (PandasVet, "015") => (RuleGroup::Stable, rules::pandas_vet::rules::PandasUseOfPdMerge),
         (PandasVet, "101") => (RuleGroup::Stable, rules::pandas_vet::rules::PandasNuniqueConstantSeriesCheck),
-        (PandasVet, "901") => (RuleGroup::Removed, rules::pandas_vet::rules::PandasDfVariableName),
+        (PandasVet, "901") => (RuleGroup::Deprecated, rules::pandas_vet::rules::PandasDfVariableName),
 
         // flake8-errmsg
         (Flake8ErrMsg, "101") => (RuleGroup::Stable, rules::flake8_errmsg::rules::RawStringInException),
@@ -830,8 +828,8 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Flake8Pyi, "056") => (RuleGroup::Stable, rules::flake8_pyi::rules::UnsupportedMethodCallOnAll),
         (Flake8Pyi, "058") => (RuleGroup::Stable, rules::flake8_pyi::rules::GeneratorReturnFromIterMethod),
         (Flake8Pyi, "057") => (RuleGroup::Stable, rules::flake8_pyi::rules::ByteStringUsage),
-        (Flake8Pyi, "059") => (RuleGroup::Stable, rules::flake8_pyi::rules::GenericNotLastBaseClass),
-        (Flake8Pyi, "061") => (RuleGroup::Stable, rules::flake8_pyi::rules::RedundantNoneLiteral),
+        (Flake8Pyi, "059") => (RuleGroup::Preview, rules::flake8_pyi::rules::GenericNotLastBaseClass),
+        (Flake8Pyi, "061") => (RuleGroup::Preview, rules::flake8_pyi::rules::RedundantNoneLiteral),
         (Flake8Pyi, "062") => (RuleGroup::Stable, rules::flake8_pyi::rules::DuplicateLiteralMember),
         (Flake8Pyi, "063") => (RuleGroup::Stable, rules::flake8_pyi::rules::Pep484StylePositionalOnlyParameter),
         (Flake8Pyi, "064") => (RuleGroup::Stable, rules::flake8_pyi::rules::RedundantFinalLiteral),
@@ -956,7 +954,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Flake8UsePathlib, "207") => (RuleGroup::Stable, rules::flake8_use_pathlib::rules::Glob),
         (Flake8UsePathlib, "208") => (RuleGroup::Stable, rules::flake8_use_pathlib::violations::OsListdir),
         (Flake8UsePathlib, "210") => (RuleGroup::Stable, rules::flake8_use_pathlib::rules::InvalidPathlibWithSuffix),
-        (Flake8UsePathlib, "211") => (RuleGroup::Stable, rules::flake8_use_pathlib::rules::OsSymlink),
+        (Flake8UsePathlib, "211") => (RuleGroup::Preview, rules::flake8_use_pathlib::rules::OsSymlink),
 
         // flake8-logging-format
         (Flake8LoggingFormat, "001") => (RuleGroup::Stable, rules::flake8_logging_format::violations::LoggingStringFormat),
@@ -1032,7 +1030,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Ruff, "039") => (RuleGroup::Preview, rules::ruff::rules::UnrawRePattern),
         (Ruff, "040") => (RuleGroup::Stable, rules::ruff::rules::InvalidAssertMessageLiteralArgument),
         (Ruff, "041") => (RuleGroup::Stable, rules::ruff::rules::UnnecessaryNestedLiteral),
-        (Ruff, "043") => (RuleGroup::Stable, rules::ruff::rules::PytestRaisesAmbiguousPattern),
+        (Ruff, "043") => (RuleGroup::Preview, rules::ruff::rules::PytestRaisesAmbiguousPattern),
         (Ruff, "045") => (RuleGroup::Preview, rules::ruff::rules::ImplicitClassVarInDataclass),
         (Ruff, "046") => (RuleGroup::Stable, rules::ruff::rules::UnnecessaryCastToInt),
         (Ruff, "047") => (RuleGroup::Preview, rules::ruff::rules::NeedlessElse),
@@ -1046,7 +1044,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Ruff, "056") => (RuleGroup::Preview, rules::ruff::rules::FalsyDictGetFallback),
         (Ruff, "057") => (RuleGroup::Stable, rules::ruff::rules::UnnecessaryRound),
         (Ruff, "058") => (RuleGroup::Stable, rules::ruff::rules::StarmapZip),
-        (Ruff, "059") => (RuleGroup::Stable, rules::ruff::rules::UnusedUnpackedVariable),
+        (Ruff, "059") => (RuleGroup::Preview, rules::ruff::rules::UnusedUnpackedVariable),
         (Ruff, "060") => (RuleGroup::Preview, rules::ruff::rules::InEmptyCollection),
         (Ruff, "061") => (RuleGroup::Preview, rules::ruff::rules::LegacyFormPytestRaises),
         (Ruff, "063") => (RuleGroup::Preview, rules::ruff::rules::AccessAnnotationsFromClassDict),
@@ -1106,11 +1104,11 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
 
         // airflow
         (Airflow, "001") => (RuleGroup::Stable, rules::airflow::rules::AirflowVariableNameTaskIdMismatch),
-        (Airflow, "002") => (RuleGroup::Stable, rules::airflow::rules::AirflowDagNoScheduleArgument),
-        (Airflow, "301") => (RuleGroup::Stable, rules::airflow::rules::Airflow3Removal),
-        (Airflow, "302") => (RuleGroup::Stable, rules::airflow::rules::Airflow3MovedToProvider),
-        (Airflow, "311") => (RuleGroup::Stable, rules::airflow::rules::Airflow3SuggestedUpdate),
-        (Airflow, "312") => (RuleGroup::Stable, rules::airflow::rules::Airflow3SuggestedToMoveToProvider),
+        (Airflow, "002") => (RuleGroup::Preview, rules::airflow::rules::AirflowDagNoScheduleArgument),
+        (Airflow, "301") => (RuleGroup::Preview, rules::airflow::rules::Airflow3Removal),
+        (Airflow, "302") => (RuleGroup::Preview, rules::airflow::rules::Airflow3MovedToProvider),
+        (Airflow, "311") => (RuleGroup::Preview, rules::airflow::rules::Airflow3SuggestedUpdate),
+        (Airflow, "312") => (RuleGroup::Preview, rules::airflow::rules::Airflow3SuggestedToMoveToProvider),
 
         // perflint
         (Perflint, "101") => (RuleGroup::Stable, rules::perflint::rules::UnnecessaryListCast),
@@ -1137,7 +1135,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Refurb, "105") => (RuleGroup::Stable, rules::refurb::rules::PrintEmptyString),
         (Refurb, "110") => (RuleGroup::Preview, rules::refurb::rules::IfExpInsteadOfOrOperator),
         (Refurb, "113") => (RuleGroup::Preview, rules::refurb::rules::RepeatedAppend),
-        (Refurb, "116") => (RuleGroup::Stable, rules::refurb::rules::FStringNumberFormat),
+        (Refurb, "116") => (RuleGroup::Preview, rules::refurb::rules::FStringNumberFormat),
         (Refurb, "118") => (RuleGroup::Preview, rules::refurb::rules::ReimplementedOperator),
         (Refurb, "122") => (RuleGroup::Stable, rules::refurb::rules::ForLoopWrites),
         (Refurb, "129") => (RuleGroup::Stable, rules::refurb::rules::ReadlinesInFor),

crates/ruff_linter/src/fs.rs

@@ -58,3 +58,13 @@ pub fn relativize_path<P: AsRef<Path>>(path: P) -> String {
     }
     format!("{}", path.display())
 }
+
+/// Convert an absolute path to be relative to the specified project root.
+pub fn relativize_path_to<P: AsRef<Path>, R: AsRef<Path>>(path: P, project_root: R) -> String {
+    format!(
+        "{}",
+        pathdiff::diff_paths(&path, project_root)
+            .expect("Could not diff paths")
+            .display()
+    )
+}

crates/ruff_linter/src/linter.rs

@@ -1231,10 +1231,6 @@ mod tests {
     )]
     #[test_case(Rule::AwaitOutsideAsync, Path::new("await_outside_async_function.py"))]
     #[test_case(Rule::AwaitOutsideAsync, Path::new("async_comprehension.py"))]
-    #[test_case(
-        Rule::YieldFromInAsyncFunction,
-        Path::new("yield_from_in_async_function.py")
-    )]
     fn test_syntax_errors(rule: Rule, path: &Path) -> Result<()> {
         let snapshot = path.to_string_lossy().to_string();
         let path = Path::new("resources/test/fixtures/syntax_errors").join(path);

crates/ruff_linter/src/message/github.rs

@@ -19,7 +19,7 @@ impl Emitter for GithubEmitter {
         context: &EmitterContext,
     ) -> anyhow::Result<()> {
         for diagnostic in diagnostics {
-            let source_location = diagnostic.ruff_start_location().unwrap_or_default();
+            let source_location = diagnostic.expect_ruff_start_location();
             let filename = diagnostic.expect_ruff_filename();
             let location = if context.is_notebook(&filename) {
                 // We can't give a reasonable location for the structured formats,
@@ -29,7 +29,7 @@ impl Emitter for GithubEmitter {
                 source_location
             };
 
-            let end_location = diagnostic.ruff_end_location().unwrap_or_default();
+            let end_location = diagnostic.expect_ruff_end_location();
 
             write!(
                 writer,

crates/ruff_linter/src/message/gitlab.rs

@@ -0,0 +1,174 @@
+use std::collections::HashSet;
+use std::collections::hash_map::DefaultHasher;
+use std::hash::{Hash, Hasher};
+use std::io::Write;
+
+use serde::ser::SerializeSeq;
+use serde::{Serialize, Serializer};
+use serde_json::json;
+
+use ruff_db::diagnostic::Diagnostic;
+
+use crate::fs::{relativize_path, relativize_path_to};
+use crate::message::{Emitter, EmitterContext};
+
+/// Generate JSON with violations in GitLab CI format
+//  https://docs.gitlab.com/ee/ci/testing/code_quality.html#implement-a-custom-tool
+pub struct GitlabEmitter {
+    project_dir: Option<String>,
+}
+
+impl Default for GitlabEmitter {
+    fn default() -> Self {
+        Self {
+            project_dir: std::env::var("CI_PROJECT_DIR").ok(),
+        }
+    }
+}
+
+impl Emitter for GitlabEmitter {
+    fn emit(
+        &mut self,
+        writer: &mut dyn Write,
+        diagnostics: &[Diagnostic],
+        context: &EmitterContext,
+    ) -> anyhow::Result<()> {
+        serde_json::to_writer_pretty(
+            writer,
+            &SerializedMessages {
+                diagnostics,
+                context,
+                project_dir: self.project_dir.as_deref(),
+            },
+        )?;
+
+        Ok(())
+    }
+}
+
+struct SerializedMessages<'a> {
+    diagnostics: &'a [Diagnostic],
+    context: &'a EmitterContext<'a>,
+    project_dir: Option<&'a str>,
+}
+
+impl Serialize for SerializedMessages<'_> {
+    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
+    where
+        S: Serializer,
+    {
+        let mut s = serializer.serialize_seq(Some(self.diagnostics.len()))?;
+        let mut fingerprints = HashSet::<u64>::with_capacity(self.diagnostics.len());
+
+        for diagnostic in self.diagnostics {
+            let filename = diagnostic.expect_ruff_filename();
+
+            let (start_location, end_location) = if self.context.is_notebook(&filename) {
+                // We can't give a reasonable location for the structured formats,
+                // so we show one that's clearly a fallback
+                Default::default()
+            } else {
+                (
+                    diagnostic.expect_ruff_start_location(),
+                    diagnostic.expect_ruff_end_location(),
+                )
+            };
+
+            let path = self.project_dir.as_ref().map_or_else(
+                || relativize_path(&filename),
+                |project_dir| relativize_path_to(&filename, project_dir),
+            );
+
+            let mut message_fingerprint = fingerprint(diagnostic, &path, 0);
+
+            // Make sure that we do not get a fingerprint that is already in use
+            // by adding in the previously generated one.
+            while fingerprints.contains(&message_fingerprint) {
+                message_fingerprint = fingerprint(diagnostic, &path, message_fingerprint);
+            }
+            fingerprints.insert(message_fingerprint);
+
+            let description = diagnostic.body();
+            let check_name = diagnostic.secondary_code_or_id();
+
+            let value = json!({
+                "check_name": check_name,
+                // GitLab doesn't display the separate `check_name` field in a Code Quality report,
+                // so prepend it to the description too.
+                "description": format!("{check_name}: {description}"),
+                "severity": "major",
+                "fingerprint": format!("{:x}", message_fingerprint),
+                "location": {
+                    "path": path,
+                    "positions": {
+                        "begin": start_location,
+                        "end": end_location,
+                    },
+                },
+            });
+
+            s.serialize_element(&value)?;
+        }
+
+        s.end()
+    }
+}
+
+/// Generate a unique fingerprint to identify a violation.
+fn fingerprint(message: &Diagnostic, project_path: &str, salt: u64) -> u64 {
+    let mut hasher = DefaultHasher::new();
+
+    salt.hash(&mut hasher);
+    message.name().hash(&mut hasher);
+    project_path.hash(&mut hasher);
+
+    hasher.finish()
+}
+
+#[cfg(test)]
+mod tests {
+    use insta::assert_snapshot;
+
+    use crate::message::GitlabEmitter;
+    use crate::message::tests::{
+        capture_emitter_output, create_diagnostics, create_syntax_error_diagnostics,
+    };
+
+    #[test]
+    fn output() {
+        let mut emitter = GitlabEmitter::default();
+        let content = capture_emitter_output(&mut emitter, &create_diagnostics());
+
+        assert_snapshot!(redact_fingerprint(&content));
+    }
+
+    #[test]
+    fn syntax_errors() {
+        let mut emitter = GitlabEmitter::default();
+        let content = capture_emitter_output(&mut emitter, &create_syntax_error_diagnostics());
+
+        assert_snapshot!(redact_fingerprint(&content));
+    }
+
+    // Redact the fingerprint because the default hasher isn't stable across platforms.
+    fn redact_fingerprint(content: &str) -> String {
+        static FINGERPRINT_HAY_KEY: &str = r#""fingerprint": ""#;
+
+        let mut output = String::with_capacity(content.len());
+        let mut last = 0;
+
+        for (start, _) in content.match_indices(FINGERPRINT_HAY_KEY) {
+            let fingerprint_hash_start = start + FINGERPRINT_HAY_KEY.len();
+            output.push_str(&content[last..fingerprint_hash_start]);
+            output.push_str("<redacted>");
+            last = fingerprint_hash_start
+                + content[fingerprint_hash_start..]
+                    .find('"')
+                    .expect("Expected terminating quote");
+        }
+
+        output.push_str(&content[last..]);
+
+        output
+    }
+}

crates/ruff_linter/src/message/grouped.rs

@@ -105,7 +105,7 @@ fn group_diagnostics_by_filename(
             .or_insert_with(Vec::new)
             .push(MessageWithLocation {
                 message: diagnostic,
-                start_location: diagnostic.ruff_start_location().unwrap_or_default(),
+                start_location: diagnostic.expect_ruff_start_location(),
             });
     }
     grouped_messages

crates/ruff_linter/src/message/mod.rs

@@ -10,6 +10,7 @@ use ruff_db::diagnostic::{
 use ruff_db::files::File;
 
 pub use github::GithubEmitter;
+pub use gitlab::GitlabEmitter;
 pub use grouped::GroupedEmitter;
 use ruff_notebook::NotebookIndex;
 use ruff_source_file::SourceFile;
@@ -21,6 +22,7 @@ use crate::Fix;
 use crate::registry::Rule;
 
 mod github;
+mod gitlab;
 mod grouped;
 mod sarif;
 mod text;

crates/ruff_linter/src/message/sarif.rs

@@ -158,8 +158,8 @@ struct SarifResult<'a> {
 impl<'a> SarifResult<'a> {
     #[cfg(not(target_arch = "wasm32"))]
     fn from_message(message: &'a Diagnostic) -> Result<Self> {
-        let start_location = message.ruff_start_location().unwrap_or_default();
-        let end_location = message.ruff_end_location().unwrap_or_default();
+        let start_location = message.expect_ruff_start_location();
+        let end_location = message.expect_ruff_end_location();
         let path = normalize_path(&*message.expect_ruff_filename());
         Ok(Self {
             code: RuleCode::from(message),
@@ -178,8 +178,8 @@ impl<'a> SarifResult<'a> {
     #[cfg(target_arch = "wasm32")]
     #[expect(clippy::unnecessary_wraps)]
     fn from_message(message: &'a Diagnostic) -> Result<Self> {
-        let start_location = message.ruff_start_location().unwrap_or_default();
-        let end_location = message.ruff_end_location().unwrap_or_default();
+        let start_location = message.expect_ruff_start_location();
+        let end_location = message.expect_ruff_end_location();
         let path = normalize_path(&*message.expect_ruff_filename());
         Ok(Self {
             code: RuleCode::from(message),

crates/ruff_linter/src/message/snapshots/ruff_linter__message__gitlab__tests__output.snap

@@ -1,63 +1,63 @@
 ---
-source: crates/ruff_db/src/diagnostic/render/gitlab.rs
-expression: env.render_diagnostics(&diagnostics)
+source: crates/ruff_linter/src/message/gitlab.rs
+expression: redact_fingerprint(&content)
 ---
 [
   {
     "check_name": "F401",
     "description": "F401: `os` imported but unused",
-    "severity": "major",
     "fingerprint": "<redacted>",
     "location": {
       "path": "fib.py",
       "positions": {
         "begin": {
-          "line": 1,
-          "column": 8
+          "column": 8,
+          "line": 1
         },
         "end": {
-          "line": 1,
-          "column": 10
+          "column": 10,
+          "line": 1
         }
       }
-    }
+    },
+    "severity": "major"
   },
   {
     "check_name": "F841",
     "description": "F841: Local variable `x` is assigned to but never used",
-    "severity": "major",
     "fingerprint": "<redacted>",
     "location": {
       "path": "fib.py",
       "positions": {
         "begin": {
-          "line": 6,
-          "column": 5
+          "column": 5,
+          "line": 6
         },
         "end": {
-          "line": 6,
-          "column": 6
+          "column": 6,
+          "line": 6
         }
       }
-    }
+    },
+    "severity": "major"
   },
   {
     "check_name": "F821",
     "description": "F821: Undefined name `a`",
-    "severity": "major",
     "fingerprint": "<redacted>",
     "location": {
       "path": "undef.py",
       "positions": {
         "begin": {
-          "line": 1,
-          "column": 4
+          "column": 4,
+          "line": 1
         },
         "end": {
-          "line": 1,
-          "column": 5
+          "column": 5,
+          "line": 1
         }
       }
-    }
+    },
+    "severity": "major"
   }
 ]

crates/ruff_linter/src/message/snapshots/ruff_linter__message__gitlab__tests__syntax_errors.snap

@@ -1,44 +1,44 @@
 ---
-source: crates/ruff_db/src/diagnostic/render/gitlab.rs
-expression: env.render_diagnostics(&diagnostics)
+source: crates/ruff_linter/src/message/gitlab.rs
+expression: redact_fingerprint(&content)
 ---
 [
   {
     "check_name": "invalid-syntax",
     "description": "invalid-syntax: Expected one or more symbol names after import",
-    "severity": "major",
     "fingerprint": "<redacted>",
     "location": {
       "path": "syntax_errors.py",
       "positions": {
         "begin": {
-          "line": 1,
-          "column": 15
+          "column": 15,
+          "line": 1
         },
         "end": {
-          "line": 2,
-          "column": 1
+          "column": 1,
+          "line": 2
         }
       }
-    }
+    },
+    "severity": "major"
   },
   {
     "check_name": "invalid-syntax",
     "description": "invalid-syntax: Expected ')', found newline",
-    "severity": "major",
     "fingerprint": "<redacted>",
     "location": {
       "path": "syntax_errors.py",
       "positions": {
         "begin": {
-          "line": 3,
-          "column": 12
+          "column": 12,
+          "line": 3
         },
         "end": {
-          "line": 4,
-          "column": 1
+          "column": 1,
+          "line": 4
         }
       }
-    }
+    },
+    "severity": "major"
   }
 ]

crates/ruff_linter/src/message/snapshots/ruff_linter__message__sarif__tests__results.snap

@@ -81,7 +81,7 @@ expression: value
           "rules": [
             {
               "fullDescription": {
-                "text": "## What it does\nChecks for unused imports.\n\n## Why is this bad?\nUnused imports add a performance overhead at runtime, and risk creating\nimport cycles. They also increase the cognitive load of reading the code.\n\nIf an import statement is used to check for the availability or existence\nof a module, consider using `importlib.util.find_spec` instead.\n\nIf an import statement is used to re-export a symbol as part of a module's\npublic interface, consider using a \"redundant\" import alias, which\ninstructs Ruff (and other tools) to respect the re-export, and avoid\nmarking it as unused, as in:\n\n```python\nfrom module import member as member\n```\n\nAlternatively, you can use `__all__` to declare a symbol as part of the module's\ninterface, as in:\n\n```python\n# __init__.py\nimport some_module\n\n__all__ = [\"some_module\"]\n```\n\n## Fix safety\n\nFixes to remove unused imports are safe, except in `__init__.py` files.\n\nApplying fixes to `__init__.py` files is currently in preview. The fix offered depends on the\ntype of the unused import. Ruff will suggest a safe fix to export first-party imports with\neither a redundant alias or, if already present in the file, an `__all__` entry. If multiple\n`__all__` declarations are present, Ruff will not offer a fix. Ruff will suggest an unsafe fix\nto remove third-party and standard library imports -- the fix is unsafe because the module's\ninterface changes.\n\nSee [this FAQ section](https://docs.astral.sh/ruff/faq/#how-does-ruff-determine-which-of-my-imports-are-first-party-third-party-etc)\nfor more details on how Ruff\ndetermines whether an import is first or third-party.\n\n## Example\n\n```python\nimport numpy as np  # unused import\n\n\ndef area(radius):\n    return 3.14 * radius**2\n```\n\nUse instead:\n\n```python\ndef area(radius):\n    return 3.14 * radius**2\n```\n\nTo check the availability of a module, use `importlib.util.find_spec`:\n\n```python\nfrom importlib.util import find_spec\n\nif find_spec(\"numpy\") is not None:\n    print(\"numpy is installed\")\nelse:\n    print(\"numpy is not installed\")\n```\n\n## Options\n- `lint.ignore-init-module-imports`\n- `lint.pyflakes.allowed-unused-imports`\n\n## References\n- [Python documentation: `import`](https://docs.python.org/3/reference/simple_stmts.html#the-import-statement)\n- [Python documentation: `importlib.util.find_spec`](https://docs.python.org/3/library/importlib.html#importlib.util.find_spec)\n- [Typing documentation: interface conventions](https://typing.python.org/en/latest/spec/distributing.html#library-interface-public-and-private-symbols)\n"
+                "text": "## What it does\nChecks for unused imports.\n\n## Why is this bad?\nUnused imports add a performance overhead at runtime, and risk creating\nimport cycles. They also increase the cognitive load of reading the code.\n\nIf an import statement is used to check for the availability or existence\nof a module, consider using `importlib.util.find_spec` instead.\n\nIf an import statement is used to re-export a symbol as part of a module's\npublic interface, consider using a \"redundant\" import alias, which\ninstructs Ruff (and other tools) to respect the re-export, and avoid\nmarking it as unused, as in:\n\n```python\nfrom module import member as member\n```\n\nAlternatively, you can use `__all__` to declare a symbol as part of the module's\ninterface, as in:\n\n```python\n# __init__.py\nimport some_module\n\n__all__ = [\"some_module\"]\n```\n\n## Fix safety\n\nFixes to remove unused imports are safe, except in `__init__.py` files.\n\nApplying fixes to `__init__.py` files is currently in preview. The fix offered depends on the\ntype of the unused import. Ruff will suggest a safe fix to export first-party imports with\neither a redundant alias or, if already present in the file, an `__all__` entry. If multiple\n`__all__` declarations are present, Ruff will not offer a fix. Ruff will suggest an unsafe fix\nto remove third-party and standard library imports -- the fix is unsafe because the module's\ninterface changes.\n\n## Example\n\n```python\nimport numpy as np  # unused import\n\n\ndef area(radius):\n    return 3.14 * radius**2\n```\n\nUse instead:\n\n```python\ndef area(radius):\n    return 3.14 * radius**2\n```\n\nTo check the availability of a module, use `importlib.util.find_spec`:\n\n```python\nfrom importlib.util import find_spec\n\nif find_spec(\"numpy\") is not None:\n    print(\"numpy is installed\")\nelse:\n    print(\"numpy is not installed\")\n```\n\n## Preview\nWhen [preview](https://docs.astral.sh/ruff/preview/) is enabled,\nthe criterion for determining whether an import is first-party\nis stricter, which could affect the suggested fix. See [this FAQ section](https://docs.astral.sh/ruff/faq/#how-does-ruff-determine-which-of-my-imports-are-first-party-third-party-etc) for more details.\n\n## Options\n- `lint.ignore-init-module-imports`\n- `lint.pyflakes.allowed-unused-imports`\n\n## References\n- [Python documentation: `import`](https://docs.python.org/3/reference/simple_stmts.html#the-import-statement)\n- [Python documentation: `importlib.util.find_spec`](https://docs.python.org/3/library/importlib.html#importlib.util.find_spec)\n- [Typing documentation: interface conventions](https://typing.python.org/en/latest/spec/distributing.html#library-interface-public-and-private-symbols)\n"
               },
               "help": {
                 "text": "`{name}` imported but unused; consider using `importlib.util.find_spec` to test for availability"
@@ -119,7 +119,7 @@ expression: value
             },
             {
               "fullDescription": {
-                "text": "## What it does\nChecks for the presence of unused variables in function scopes.\n\n## Why is this bad?\nA variable that is defined but not used is likely a mistake, and should\nbe removed to avoid confusion.\n\nIf a variable is intentionally defined-but-not-used, it should be\nprefixed with an underscore, or some other value that adheres to the\n[`lint.dummy-variable-rgx`] pattern.\n\n## Example\n```python\ndef foo():\n    x = 1\n    y = 2\n    return x\n```\n\nUse instead:\n```python\ndef foo():\n    x = 1\n    return x\n```\n\n## Fix safety\n\nThis rule's fix is marked as unsafe because removing an unused variable assignment may\ndelete comments that are attached to the assignment.\n\n## See also\n\nThis rule does not apply to bindings in unpacked assignments (e.g. `x, y = 1, 2`). See\n[`unused-unpacked-variable`][RUF059] for this case.\n\n## Options\n- `lint.dummy-variable-rgx`\n\n[RUF059]: https://docs.astral.sh/ruff/rules/unused-unpacked-variable/\n"
+                "text": "## What it does\nChecks for the presence of unused variables in function scopes.\n\n## Why is this bad?\nA variable that is defined but not used is likely a mistake, and should\nbe removed to avoid confusion.\n\nIf a variable is intentionally defined-but-not-used, it should be\nprefixed with an underscore, or some other value that adheres to the\n[`lint.dummy-variable-rgx`] pattern.\n\n## Example\n```python\ndef foo():\n    x = 1\n    y = 2\n    return x\n```\n\nUse instead:\n```python\ndef foo():\n    x = 1\n    return x\n```\n\n## Fix safety\n\nThis rule's fix is marked as unsafe because removing an unused variable assignment may\ndelete comments that are attached to the assignment.\n\n## Options\n- `lint.dummy-variable-rgx`\n"
               },
               "help": {
                 "text": "Local variable `{name}` is assigned to but never used"

crates/ruff_linter/src/message/text.rs

@@ -3,9 +3,9 @@ use std::io::Write;
 use ruff_db::diagnostic::{
     Diagnostic, DiagnosticFormat, DisplayDiagnosticConfig, DisplayDiagnostics,
 };
-use ruff_diagnostics::Applicability;
 
 use crate::message::{Emitter, EmitterContext};
+use crate::settings::types::UnsafeFixes;
 
 pub struct TextEmitter {
     config: DisplayDiagnosticConfig,
@@ -46,8 +46,10 @@ impl TextEmitter {
     }
 
     #[must_use]
-    pub fn with_fix_applicability(mut self, applicability: Applicability) -> Self {
-        self.config = self.config.fix_applicability(applicability);
+    pub fn with_unsafe_fixes(mut self, unsafe_fixes: UnsafeFixes) -> Self {
+        self.config = self
+            .config
+            .fix_applicability(unsafe_fixes.required_applicability());
         self
     }
 
@@ -84,13 +86,13 @@ impl Emitter for TextEmitter {
 #[cfg(test)]
 mod tests {
     use insta::assert_snapshot;
-    use ruff_diagnostics::Applicability;
 
     use crate::message::TextEmitter;
     use crate::message::tests::{
         capture_emitter_notebook_output, capture_emitter_output, create_diagnostics,
         create_notebook_diagnostics, create_syntax_error_diagnostics,
     };
+    use crate::settings::types::UnsafeFixes;
 
     #[test]
     fn default() {
@@ -115,7 +117,7 @@ mod tests {
         let mut emitter = TextEmitter::default()
             .with_show_fix_status(true)
             .with_show_source(true)
-            .with_fix_applicability(Applicability::Unsafe);
+            .with_unsafe_fixes(UnsafeFixes::Enabled);
         let content = capture_emitter_output(&mut emitter, &create_diagnostics());
 
         assert_snapshot!(content);
@@ -126,7 +128,7 @@ mod tests {
         let mut emitter = TextEmitter::default()
             .with_show_fix_status(true)
             .with_show_source(true)
-            .with_fix_applicability(Applicability::Unsafe);
+            .with_unsafe_fixes(UnsafeFixes::Enabled);
         let (messages, notebook_indexes) = create_notebook_diagnostics();
         let content = capture_emitter_notebook_output(&mut emitter, &messages, &notebook_indexes);
 

crates/ruff_linter/src/preview.rs

@@ -11,6 +11,11 @@ pub(crate) const fn is_py314_support_enabled(settings: &LinterSettings) -> bool
     settings.preview.is_enabled()
 }
 
+// https://github.com/astral-sh/ruff/pull/16565
+pub(crate) const fn is_full_path_match_source_strategy_enabled(settings: &LinterSettings) -> bool {
+    settings.preview.is_enabled()
+}
+
 // Rule-specific behavior
 
 // https://github.com/astral-sh/ruff/pull/15541
@@ -35,11 +40,6 @@ pub(crate) const fn is_bad_version_info_in_non_stub_enabled(settings: &LinterSet
     settings.preview.is_enabled()
 }
 
-/// <https://github.com/astral-sh/ruff/pull/19303>
-pub(crate) const fn is_fix_f_string_logging_enabled(settings: &LinterSettings) -> bool {
-    settings.preview.is_enabled()
-}
-
 // https://github.com/astral-sh/ruff/pull/16719
 pub(crate) const fn is_fix_manual_dict_comprehension_enabled(settings: &LinterSettings) -> bool {
     settings.preview.is_enabled()
@@ -195,11 +195,35 @@ pub(crate) const fn is_allow_nested_roots_enabled(settings: &LinterSettings) ->
     settings.preview.is_enabled()
 }
 
+// https://github.com/astral-sh/ruff/pull/18208
+pub(crate) const fn is_multiple_with_statements_fix_safe_enabled(
+    settings: &LinterSettings,
+) -> bool {
+    settings.preview.is_enabled()
+}
+
+// https://github.com/astral-sh/ruff/pull/18400
+pub(crate) const fn is_ignore_init_files_in_useless_alias_enabled(
+    settings: &LinterSettings,
+) -> bool {
+    settings.preview.is_enabled()
+}
+
 // https://github.com/astral-sh/ruff/pull/18572
 pub(crate) const fn is_optional_as_none_in_union_enabled(settings: &LinterSettings) -> bool {
     settings.preview.is_enabled()
 }
 
+// https://github.com/astral-sh/ruff/pull/18547
+pub(crate) const fn is_invalid_async_mock_access_check_enabled(settings: &LinterSettings) -> bool {
+    settings.preview.is_enabled()
+}
+
+// https://github.com/astral-sh/ruff/pull/18867
+pub(crate) const fn is_raise_exception_byte_string_enabled(settings: &LinterSettings) -> bool {
+    settings.preview.is_enabled()
+}
+
 // https://github.com/astral-sh/ruff/pull/18683
 pub(crate) const fn is_safe_super_call_with_parameters_fix_enabled(
     settings: &LinterSettings,
@@ -207,14 +231,22 @@ pub(crate) const fn is_safe_super_call_with_parameters_fix_enabled(
     settings.preview.is_enabled()
 }
 
+// https://github.com/astral-sh/ruff/pull/19063
+pub(crate) const fn is_assert_raises_exception_call_enabled(settings: &LinterSettings) -> bool {
+    settings.preview.is_enabled()
+}
+
+// https://github.com/astral-sh/ruff/pull/19100
+pub(crate) const fn is_add_future_annotations_imports_enabled(settings: &LinterSettings) -> bool {
+    settings.preview.is_enabled()
+}
+
+// https://github.com/astral-sh/ruff/pull/19390
+pub(crate) const fn is_trailing_comma_type_params_enabled(settings: &LinterSettings) -> bool {
+    settings.preview.is_enabled()
+}
+
 // https://github.com/astral-sh/ruff/pull/19851
 pub(crate) const fn is_maxsplit_without_separator_fix_enabled(settings: &LinterSettings) -> bool {
     settings.preview.is_enabled()
 }
-
-// https://github.com/astral-sh/ruff/pull/20027
-pub(crate) const fn is_unnecessary_default_type_args_stubs_enabled(
-    settings: &LinterSettings,
-) -> bool {
-    settings.preview.is_enabled()
-}

crates/ruff_linter/src/renamer.rs

@@ -354,10 +354,7 @@ impl Renamer {
                 ))
             }
             // Avoid renaming builtins and other "special" bindings.
-            BindingKind::FutureImport
-            | BindingKind::Builtin
-            | BindingKind::Export(_)
-            | BindingKind::DunderClassCell => None,
+            BindingKind::FutureImport | BindingKind::Builtin | BindingKind::Export(_) => None,
             // By default, replace the binding's name with the target name.
             BindingKind::Annotation
             | BindingKind::Argument

crates/ruff_linter/src/rule_selector.rs

@@ -214,8 +214,10 @@ impl RuleSelector {
                 RuleGroup::Preview => {
                     preview_enabled && (self.is_exact() || !preview_require_explicit)
                 }
-                // Deprecated rules are excluded by default unless explicitly selected
-                RuleGroup::Deprecated => !preview_enabled && self.is_exact(),
+                // Deprecated rules are excluded in preview mode and with 'All' option unless explicitly selected
+                RuleGroup::Deprecated => {
+                    (!preview_enabled || self.is_exact()) && !matches!(self, RuleSelector::All)
+                }
                 // Removed rules are included if explicitly selected but will error downstream
                 RuleGroup::Removed => self.is_exact(),
             }

crates/ruff_linter/src/rules/airflow/helpers.rs

@@ -37,6 +37,7 @@ pub(crate) enum Replacement {
 
 #[derive(Clone, Debug, Eq, PartialEq)]
 pub(crate) enum ProviderReplacement {
+    None,
     AutoImport {
         module: &'static str,
         name: &'static str,

crates/ruff_linter/src/rules/airflow/rules/dag_schedule_argument.rs

@@ -46,7 +46,7 @@ pub(crate) struct AirflowDagNoScheduleArgument;
 impl Violation for AirflowDagNoScheduleArgument {
     #[derive_message_formats]
     fn message(&self) -> String {
-        "`DAG` or `@dag` should have an explicit `schedule` argument".to_string()
+        "DAG should have an explicit `schedule` argument".to_string()
     }
 }
 

crates/ruff_linter/src/rules/airflow/rules/moved_to_provider_in_3.rs

@@ -13,13 +13,13 @@ use ruff_text_size::TextRange;
 use crate::{FixAvailability, Violation};
 
 /// ## What it does
-/// Checks for uses of Airflow functions and values that have been moved to its providers
-/// (e.g., `apache-airflow-providers-fab`).
+/// Checks for uses of Airflow functions and values that have been moved to it providers.
+/// (e.g., apache-airflow-providers-fab)
 ///
 /// ## Why is this bad?
 /// Airflow 3.0 moved various deprecated functions, members, and other
 /// values to its providers. The user needs to install the corresponding provider and replace
-/// the original usage with the one in the provider.
+/// the original usage with the one in the provider
 ///
 /// ## Example
 /// ```python
@@ -50,6 +50,9 @@ impl Violation for Airflow3MovedToProvider<'_> {
             replacement,
         } = self;
         match replacement {
+            ProviderReplacement::None => {
+                format!("`{deprecated}` is removed in Airflow 3.0")
+            }
             ProviderReplacement::AutoImport {
                 name: _,
                 module: _,
@@ -82,6 +85,7 @@ impl Violation for Airflow3MovedToProvider<'_> {
                 provider,
                 version,
             } => Some((module, name.as_str(), provider, version)),
+            ProviderReplacement::None => None,
         } {
             Some(format!(
                 "Install `apache-airflow-providers-{provider}>={version}` and use `{name}` from `{module}` instead."
@@ -1016,6 +1020,7 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
             provider: "postgres",
             version: "1.0.0",
         },
+        ["airflow", "operators", "postgres_operator", "Mapping"] => ProviderReplacement::None,
 
         // apache-airflow-providers-presto
         ["airflow", "hooks", "presto_hook", "PrestoHook"] => ProviderReplacement::AutoImport {
@@ -1204,6 +1209,16 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
         ProviderReplacement::SourceModuleMovedToProvider { module, name, .. } => {
             (module, name.as_str())
         }
+        ProviderReplacement::None => {
+            checker.report_diagnostic(
+                Airflow3MovedToProvider {
+                    deprecated: qualified_name,
+                    replacement,
+                },
+                ranged,
+            );
+            return;
+        }
     };
 
     if is_guarded_by_try_except(expr, module, name, checker.semantic()) {

crates/ruff_linter/src/rules/airflow/rules/removal_in_3.rs

@@ -23,7 +23,7 @@ use ruff_text_size::TextRange;
 /// ## Why is this bad?
 /// Airflow 3.0 removed various deprecated functions, members, and other
 /// values. Some have more modern replacements. Others are considered too niche
-/// and not worth continued maintenance in Airflow.
+/// and not worth to be maintained in Airflow.
 ///
 /// ## Example
 /// ```python
@@ -704,7 +704,6 @@ fn check_name(checker: &Checker, expr: &Expr, range: TextRange) {
         ["airflow", "operators", "subdag", ..] => {
             Replacement::Message("The whole `airflow.subdag` module has been removed.")
         }
-        ["airflow", "operators", "postgres_operator", "Mapping"] => Replacement::None,
         ["airflow", "operators", "python", "get_current_context"] => Replacement::AutoImport {
             module: "airflow.sdk",
             name: "get_current_context",

crates/ruff_linter/src/rules/airflow/rules/suggested_to_move_to_provider_in_3.rs

@@ -65,6 +65,9 @@ impl Violation for Airflow3SuggestedToMoveToProvider<'_> {
             replacement,
         } = self;
         match replacement {
+            ProviderReplacement::None => {
+                format!("`{deprecated}` is removed in Airflow 3.0")
+            }
             ProviderReplacement::AutoImport {
                 name: _,
                 module: _,
@@ -88,6 +91,7 @@ impl Violation for Airflow3SuggestedToMoveToProvider<'_> {
     fn fix_title(&self) -> Option<String> {
         let Airflow3SuggestedToMoveToProvider { replacement, .. } = self;
         match replacement {
+            ProviderReplacement::None => None,
             ProviderReplacement::AutoImport {
                 module,
                 name,
@@ -211,12 +215,6 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
                 version: "0.0.1",
             }
         }
-        ["airflow", "sensors", "bash", "BashSensor"] => ProviderReplacement::AutoImport {
-            module: "airflow.providers.standard.sensor.bash",
-            name: "BashSensor",
-            provider: "standard",
-            version: "0.0.1",
-        },
         [
             "airflow",
             "sensors",
@@ -245,12 +243,6 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
             provider: "standard",
             version: "0.0.2",
         },
-        ["airflow", "sensors", "python", "PythonSensor"] => ProviderReplacement::AutoImport {
-            module: "airflow.providers.standard.sensors.python",
-            name: "PythonSensor",
-            provider: "standard",
-            version: "0.0.1",
-        },
         [
             "airflow",
             "sensors",
@@ -315,6 +307,16 @@ fn check_names_moved_to_provider(checker: &Checker, expr: &Expr, ranged: TextRan
         ProviderReplacement::SourceModuleMovedToProvider { module, name, .. } => {
             (module, name.as_str())
         }
+        ProviderReplacement::None => {
+            checker.report_diagnostic(
+                Airflow3SuggestedToMoveToProvider {
+                    deprecated: qualified_name,
+                    replacement: replacement.clone(),
+                },
+                ranged.range(),
+            );
+            return;
+        }
     };
 
     if is_guarded_by_try_except(expr, module, name, checker.semantic()) {

crates/ruff_linter/src/rules/airflow/rules/suggested_to_update_3_0.rs

@@ -17,9 +17,9 @@ use ruff_text_size::TextRange;
 /// ## Why is this bad?
 /// Airflow 3.0 removed various deprecated functions, members, and other
 /// values. Some have more modern replacements. Others are considered too niche
-/// and not worth continued maintenance in Airflow.
+/// and not worth to be maintained in Airflow.
 /// Even though these symbols still work fine on Airflow 3.0, they are expected to be removed in a future version.
-/// Where available, users should replace the removed functionality with the new alternatives.
+/// The user is suggested to replace the original usage with the new ones.
 ///
 /// ## Example
 /// ```python
@@ -157,9 +157,6 @@ fn check_call_arguments(checker: &Checker, qualified_name: &QualifiedName, argum
         ["airflow", .., "DAG" | "dag"] => {
             diagnostic_for_argument(checker, arguments, "sla_miss_callback", None);
         }
-        ["airflow", "timetables", "datasets", "DatasetOrTimeSchedule"] => {
-            diagnostic_for_argument(checker, arguments, "datasets", Some("assets"));
-        }
         segments => {
             if is_airflow_builtin_or_provider(segments, "operators", "Operator") {
                 diagnostic_for_argument(checker, arguments, "sla", None);
@@ -230,26 +227,13 @@ fn check_name(checker: &Checker, expr: &Expr, range: TextRange) {
             module: "airflow.sdk",
             name: (*rest).to_string(),
         },
-        [
-            "airflow",
-            "decorators",
-            "base",
-            rest @ ("DecoratedMappedOperator"
-            | "DecoratedOperator"
-            | "TaskDecorator"
-            | "get_unique_task_id"
-            | "task_decorator_factory"),
-        ] => Replacement::SourceModuleMoved {
-            module: "airflow.sdk.bases.decorator",
-            name: (*rest).to_string(),
-        },
 
         // airflow.io
         ["airflow", "io", "path", "ObjectStoragePath"] => Replacement::SourceModuleMoved {
             module: "airflow.sdk",
             name: "ObjectStoragePath".to_string(),
         },
-        ["airflow", "io", "store", "attach"] => Replacement::SourceModuleMoved {
+        ["airflow", "io", "storage", "attach"] => Replacement::SourceModuleMoved {
             module: "airflow.sdk.io",
             name: "attach".to_string(),
         },
@@ -261,10 +245,6 @@ fn check_name(checker: &Checker, expr: &Expr, range: TextRange) {
                 name: (*rest).to_string(),
             }
         }
-        ["airflow", "models", "Param"] => Replacement::AutoImport {
-            module: "airflow.sdk.definitions.param",
-            name: "Param",
-        },
 
         // airflow.models.baseoperator
         [
@@ -280,30 +260,16 @@ fn check_name(checker: &Checker, expr: &Expr, range: TextRange) {
             module: "airflow.sdk",
             name: "BaseOperatorLink",
         },
-
         // airflow.model..DAG
         ["airflow", "models", .., "DAG"] => Replacement::SourceModuleMoved {
             module: "airflow.sdk",
             name: "DAG".to_string(),
         },
-
-        // airflow.sensors.base
-        [
-            "airflow",
-            "sensors",
-            "base",
-            rest @ ("BaseSensorOperator" | "PokeReturnValue" | "poke_mode_only"),
-        ] => Replacement::SourceModuleMoved {
-            module: "airflow.sdk",
-            name: (*rest).to_string(),
-        },
-
         // airflow.timetables
         ["airflow", "timetables", "datasets", "DatasetOrTimeSchedule"] => Replacement::AutoImport {
             module: "airflow.timetables.assets",
             name: "AssetOrTimeSchedule",
         },
-
         // airflow.utils
         [
             "airflow",

crates/ruff_linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR002_AIR002.py.snap

@@ -1,7 +1,7 @@
 ---
 source: crates/ruff_linter/src/rules/airflow/mod.rs
 ---
-AIR002 `DAG` or `@dag` should have an explicit `schedule` argument
+AIR002 DAG should have an explicit `schedule` argument
  --> AIR002.py:4:1
   |
 2 | from airflow.timetables.simple import NullTimetable
@@ -12,7 +12,7 @@ AIR002 `DAG` or `@dag` should have an explicit `schedule` argument
 6 | DAG(dag_id="class_schedule", schedule="@hourly")
   |
 
-AIR002 `DAG` or `@dag` should have an explicit `schedule` argument
+AIR002 DAG should have an explicit `schedule` argument
   --> AIR002.py:13:2
    |
 13 | @dag()

crates/ruff_linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR301_AIR301_args.py.snap

@@ -12,14 +12,16 @@ AIR301 [*] `schedule_interval` is removed in Airflow 3.0
 23 | DAG(dag_id="class_timetable", timetable=NullTimetable())
    |
 help: Use `schedule` instead
-18 | 
-19 | DAG(dag_id="class_schedule", schedule="@hourly")
-20 | 
-   - DAG(dag_id="class_schedule_interval", schedule_interval="@hourly")
-21 + DAG(dag_id="class_schedule_interval", schedule="@hourly")
-22 | 
-23 | DAG(dag_id="class_timetable", timetable=NullTimetable())
-24 | 
+
+ℹ Safe fix
+18 18 | 
+19 19 | DAG(dag_id="class_schedule", schedule="@hourly")
+20 20 | 
+21    |-DAG(dag_id="class_schedule_interval", schedule_interval="@hourly")
+   21 |+DAG(dag_id="class_schedule_interval", schedule="@hourly")
+22 22 | 
+23 23 | DAG(dag_id="class_timetable", timetable=NullTimetable())
+24 24 | 
 
 AIR301 [*] `timetable` is removed in Airflow 3.0
   --> AIR301_args.py:23:31
@@ -30,14 +32,16 @@ AIR301 [*] `timetable` is removed in Airflow 3.0
    |                               ^^^^^^^^^
    |
 help: Use `schedule` instead
-20 | 
-21 | DAG(dag_id="class_schedule_interval", schedule_interval="@hourly")
-22 | 
-   - DAG(dag_id="class_timetable", timetable=NullTimetable())
-23 + DAG(dag_id="class_timetable", schedule=NullTimetable())
-24 | 
-25 | 
-26 | DAG(dag_id="class_fail_stop", fail_stop=True)
+
+ℹ Safe fix
+20 20 | 
+21 21 | DAG(dag_id="class_schedule_interval", schedule_interval="@hourly")
+22 22 | 
+23    |-DAG(dag_id="class_timetable", timetable=NullTimetable())
+   23 |+DAG(dag_id="class_timetable", schedule=NullTimetable())
+24 24 | 
+25 25 | 
+26 26 | DAG(dag_id="class_fail_stop", fail_stop=True)
 
 AIR301 [*] `fail_stop` is removed in Airflow 3.0
   --> AIR301_args.py:26:31
@@ -48,14 +52,16 @@ AIR301 [*] `fail_stop` is removed in Airflow 3.0
 28 | DAG(dag_id="class_default_view", default_view="dag_default_view")
    |
 help: Use `fail_fast` instead
-23 | DAG(dag_id="class_timetable", timetable=NullTimetable())
-24 | 
-25 | 
-   - DAG(dag_id="class_fail_stop", fail_stop=True)
-26 + DAG(dag_id="class_fail_stop", fail_fast=True)
-27 | 
-28 | DAG(dag_id="class_default_view", default_view="dag_default_view")
-29 | 
+
+ℹ Safe fix
+23 23 | DAG(dag_id="class_timetable", timetable=NullTimetable())
+24 24 | 
+25 25 | 
+26    |-DAG(dag_id="class_fail_stop", fail_stop=True)
+   26 |+DAG(dag_id="class_fail_stop", fail_fast=True)
+27 27 | 
+28 28 | DAG(dag_id="class_default_view", default_view="dag_default_view")
+29 29 | 
 
 AIR301 `default_view` is removed in Airflow 3.0
   --> AIR301_args.py:28:34
@@ -88,14 +94,16 @@ AIR301 [*] `schedule_interval` is removed in Airflow 3.0
 43 |     pass
    |
 help: Use `schedule` instead
-38 |     pass
-39 | 
-40 | 
-   - @dag(schedule_interval="0 * * * *")
-41 + @dag(schedule="0 * * * *")
-42 | def decorator_schedule_interval():
-43 |     pass
-44 | 
+
+ℹ Safe fix
+38 38 |     pass
+39 39 | 
+40 40 | 
+41    |-@dag(schedule_interval="0 * * * *")
+   41 |+@dag(schedule="0 * * * *")
+42 42 | def decorator_schedule_interval():
+43 43 |     pass
+44 44 | 
 
 AIR301 [*] `timetable` is removed in Airflow 3.0
   --> AIR301_args.py:46:6
@@ -106,14 +114,16 @@ AIR301 [*] `timetable` is removed in Airflow 3.0
 48 |     pass
    |
 help: Use `schedule` instead
-43 |     pass
-44 | 
-45 | 
-   - @dag(timetable=NullTimetable())
-46 + @dag(schedule=NullTimetable())
-47 | def decorator_timetable():
-48 |     pass
-49 | 
+
+ℹ Safe fix
+43 43 |     pass
+44 44 | 
+45 45 | 
+46    |-@dag(timetable=NullTimetable())
+   46 |+@dag(schedule=NullTimetable())
+47 47 | def decorator_timetable():
+48 48 |     pass
+49 49 | 
 
 AIR301 [*] `execution_date` is removed in Airflow 3.0
   --> AIR301_args.py:54:62
@@ -126,14 +136,16 @@ AIR301 [*] `execution_date` is removed in Airflow 3.0
 56 |     trigger_dagrun_op2 = TriggerDagRunOperator(
    |
 help: Use `logical_date` instead
-51 | @dag()
-52 | def decorator_deprecated_operator_args():
-53 |     trigger_dagrun_op = trigger_dagrun.TriggerDagRunOperator(
-   -         task_id="trigger_dagrun_op1", trigger_dag_id="test", execution_date="2024-12-04"
-54 +         task_id="trigger_dagrun_op1", trigger_dag_id="test", logical_date="2024-12-04"
-55 |     )
-56 |     trigger_dagrun_op2 = TriggerDagRunOperator(
-57 |         task_id="trigger_dagrun_op2", trigger_dag_id="test", execution_date="2024-12-04"
+
+ℹ Safe fix
+51 51 | @dag()
+52 52 | def decorator_deprecated_operator_args():
+53 53 |     trigger_dagrun_op = trigger_dagrun.TriggerDagRunOperator(
+54    |-        task_id="trigger_dagrun_op1", trigger_dag_id="test", execution_date="2024-12-04"
+   54 |+        task_id="trigger_dagrun_op1", trigger_dag_id="test", logical_date="2024-12-04"
+55 55 |     )
+56 56 |     trigger_dagrun_op2 = TriggerDagRunOperator(
+57 57 |         task_id="trigger_dagrun_op2", trigger_dag_id="test", execution_date="2024-12-04"
 
 AIR301 [*] `execution_date` is removed in Airflow 3.0
   --> AIR301_args.py:57:62
@@ -145,14 +157,16 @@ AIR301 [*] `execution_date` is removed in Airflow 3.0
 58 |     )
    |
 help: Use `logical_date` instead
-54 |         task_id="trigger_dagrun_op1", trigger_dag_id="test", execution_date="2024-12-04"
-55 |     )
-56 |     trigger_dagrun_op2 = TriggerDagRunOperator(
-   -         task_id="trigger_dagrun_op2", trigger_dag_id="test", execution_date="2024-12-04"
-57 +         task_id="trigger_dagrun_op2", trigger_dag_id="test", logical_date="2024-12-04"
-58 |     )
-59 | 
-60 |     branch_dt_op = datetime.BranchDateTimeOperator(
+
+ℹ Safe fix
+54 54 |         task_id="trigger_dagrun_op1", trigger_dag_id="test", execution_date="2024-12-04"
+55 55 |     )
+56 56 |     trigger_dagrun_op2 = TriggerDagRunOperator(
+57    |-        task_id="trigger_dagrun_op2", trigger_dag_id="test", execution_date="2024-12-04"
+   57 |+        task_id="trigger_dagrun_op2", trigger_dag_id="test", logical_date="2024-12-04"
+58 58 |     )
+59 59 | 
+60 60 |     branch_dt_op = datetime.BranchDateTimeOperator(
 
 AIR301 [*] `use_task_execution_day` is removed in Airflow 3.0
   --> AIR301_args.py:61:33
@@ -164,14 +178,16 @@ AIR301 [*] `use_task_execution_day` is removed in Airflow 3.0
 63 |     branch_dt_op2 = BranchDateTimeOperator(
    |
 help: Use `use_task_logical_date` instead
-58 |     )
-59 | 
-60 |     branch_dt_op = datetime.BranchDateTimeOperator(
-   -         task_id="branch_dt_op", use_task_execution_day=True, task_concurrency=5
-61 +         task_id="branch_dt_op", use_task_logical_date=True, task_concurrency=5
-62 |     )
-63 |     branch_dt_op2 = BranchDateTimeOperator(
-64 |         task_id="branch_dt_op2",
+
+ℹ Safe fix
+58 58 |     )
+59 59 | 
+60 60 |     branch_dt_op = datetime.BranchDateTimeOperator(
+61    |-        task_id="branch_dt_op", use_task_execution_day=True, task_concurrency=5
+   61 |+        task_id="branch_dt_op", use_task_logical_date=True, task_concurrency=5
+62 62 |     )
+63 63 |     branch_dt_op2 = BranchDateTimeOperator(
+64 64 |         task_id="branch_dt_op2",
 
 AIR301 [*] `task_concurrency` is removed in Airflow 3.0
   --> AIR301_args.py:61:62
@@ -183,14 +199,16 @@ AIR301 [*] `task_concurrency` is removed in Airflow 3.0
 63 |     branch_dt_op2 = BranchDateTimeOperator(
    |
 help: Use `max_active_tis_per_dag` instead
-58 |     )
-59 | 
-60 |     branch_dt_op = datetime.BranchDateTimeOperator(
-   -         task_id="branch_dt_op", use_task_execution_day=True, task_concurrency=5
-61 +         task_id="branch_dt_op", use_task_execution_day=True, max_active_tis_per_dag=5
-62 |     )
-63 |     branch_dt_op2 = BranchDateTimeOperator(
-64 |         task_id="branch_dt_op2",
+
+ℹ Safe fix
+58 58 |     )
+59 59 | 
+60 60 |     branch_dt_op = datetime.BranchDateTimeOperator(
+61    |-        task_id="branch_dt_op", use_task_execution_day=True, task_concurrency=5
+   61 |+        task_id="branch_dt_op", use_task_execution_day=True, max_active_tis_per_dag=5
+62 62 |     )
+63 63 |     branch_dt_op2 = BranchDateTimeOperator(
+64 64 |         task_id="branch_dt_op2",
 
 AIR301 [*] `use_task_execution_day` is removed in Airflow 3.0
   --> AIR301_args.py:65:9
@@ -203,14 +221,16 @@ AIR301 [*] `use_task_execution_day` is removed in Airflow 3.0
 67 |     )
    |
 help: Use `use_task_logical_date` instead
-62 |     )
-63 |     branch_dt_op2 = BranchDateTimeOperator(
-64 |         task_id="branch_dt_op2",
-   -         use_task_execution_day=True,
-65 +         use_task_logical_date=True,
-66 |         sla=timedelta(seconds=10),
-67 |     )
-68 | 
+
+ℹ Safe fix
+62 62 |     )
+63 63 |     branch_dt_op2 = BranchDateTimeOperator(
+64 64 |         task_id="branch_dt_op2",
+65    |-        use_task_execution_day=True,
+   65 |+        use_task_logical_date=True,
+66 66 |         sla=timedelta(seconds=10),
+67 67 |     )
+68 68 | 
 
 AIR301 [*] `use_task_execution_day` is removed in Airflow 3.0
   --> AIR301_args.py:92:9
@@ -222,14 +242,16 @@ AIR301 [*] `use_task_execution_day` is removed in Airflow 3.0
 93 |     )
    |
 help: Use `use_task_logical_date` instead
-89 |         follow_task_ids_if_false=None,
-90 |         follow_task_ids_if_true=None,
-91 |         week_day=1,
-   -         use_task_execution_day=True,
-92 +         use_task_logical_date=True,
-93 |     )
-94 | 
-95 |     trigger_dagrun_op >> trigger_dagrun_op2
+
+ℹ Safe fix
+89 89 |         follow_task_ids_if_false=None,
+90 90 |         follow_task_ids_if_true=None,
+91 91 |         week_day=1,
+92    |-        use_task_execution_day=True,
+   92 |+        use_task_logical_date=True,
+93 93 |     )
+94 94 | 
+95 95 |     trigger_dagrun_op >> trigger_dagrun_op2
 
 AIR301 `filename_template` is removed in Airflow 3.0
    --> AIR301_args.py:102:15

crates/ruff_linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR301_AIR301_class_attribute.py.snap

@@ -11,14 +11,16 @@ AIR301 [*] `iter_datasets` is removed in Airflow 3.0
 26 | dataset_from_root.iter_dataset_aliases()
    |
 help: Use `iter_assets` instead
-22 | 
-23 | # airflow.Dataset
-24 | dataset_from_root = DatasetFromRoot()
-   - dataset_from_root.iter_datasets()
-25 + dataset_from_root.iter_assets()
-26 | dataset_from_root.iter_dataset_aliases()
-27 | 
-28 | # airflow.datasets
+
+ℹ Safe fix
+22 22 | 
+23 23 | # airflow.Dataset
+24 24 | dataset_from_root = DatasetFromRoot()
+25    |-dataset_from_root.iter_datasets()
+   25 |+dataset_from_root.iter_assets()
+26 26 | dataset_from_root.iter_dataset_aliases()
+27 27 | 
+28 28 | # airflow.datasets
 
 AIR301 [*] `iter_dataset_aliases` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:26:19
@@ -31,14 +33,16 @@ AIR301 [*] `iter_dataset_aliases` is removed in Airflow 3.0
 28 | # airflow.datasets
    |
 help: Use `iter_asset_aliases` instead
-23 | # airflow.Dataset
-24 | dataset_from_root = DatasetFromRoot()
-25 | dataset_from_root.iter_datasets()
-   - dataset_from_root.iter_dataset_aliases()
-26 + dataset_from_root.iter_asset_aliases()
-27 | 
-28 | # airflow.datasets
-29 | dataset_to_test_method_call = Dataset()
+
+ℹ Safe fix
+23 23 | # airflow.Dataset
+24 24 | dataset_from_root = DatasetFromRoot()
+25 25 | dataset_from_root.iter_datasets()
+26    |-dataset_from_root.iter_dataset_aliases()
+   26 |+dataset_from_root.iter_asset_aliases()
+27 27 | 
+28 28 | # airflow.datasets
+29 29 | dataset_to_test_method_call = Dataset()
 
 AIR301 [*] `iter_datasets` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:30:29
@@ -50,14 +54,16 @@ AIR301 [*] `iter_datasets` is removed in Airflow 3.0
 31 | dataset_to_test_method_call.iter_dataset_aliases()
    |
 help: Use `iter_assets` instead
-27 | 
-28 | # airflow.datasets
-29 | dataset_to_test_method_call = Dataset()
-   - dataset_to_test_method_call.iter_datasets()
-30 + dataset_to_test_method_call.iter_assets()
-31 | dataset_to_test_method_call.iter_dataset_aliases()
-32 | 
-33 | alias_to_test_method_call = DatasetAlias()
+
+ℹ Safe fix
+27 27 | 
+28 28 | # airflow.datasets
+29 29 | dataset_to_test_method_call = Dataset()
+30    |-dataset_to_test_method_call.iter_datasets()
+   30 |+dataset_to_test_method_call.iter_assets()
+31 31 | dataset_to_test_method_call.iter_dataset_aliases()
+32 32 | 
+33 33 | alias_to_test_method_call = DatasetAlias()
 
 AIR301 [*] `iter_dataset_aliases` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:31:29
@@ -70,14 +76,16 @@ AIR301 [*] `iter_dataset_aliases` is removed in Airflow 3.0
 33 | alias_to_test_method_call = DatasetAlias()
    |
 help: Use `iter_asset_aliases` instead
-28 | # airflow.datasets
-29 | dataset_to_test_method_call = Dataset()
-30 | dataset_to_test_method_call.iter_datasets()
-   - dataset_to_test_method_call.iter_dataset_aliases()
-31 + dataset_to_test_method_call.iter_asset_aliases()
-32 | 
-33 | alias_to_test_method_call = DatasetAlias()
-34 | alias_to_test_method_call.iter_datasets()
+
+ℹ Safe fix
+28 28 | # airflow.datasets
+29 29 | dataset_to_test_method_call = Dataset()
+30 30 | dataset_to_test_method_call.iter_datasets()
+31    |-dataset_to_test_method_call.iter_dataset_aliases()
+   31 |+dataset_to_test_method_call.iter_asset_aliases()
+32 32 | 
+33 33 | alias_to_test_method_call = DatasetAlias()
+34 34 | alias_to_test_method_call.iter_datasets()
 
 AIR301 [*] `iter_datasets` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:34:27
@@ -88,14 +96,16 @@ AIR301 [*] `iter_datasets` is removed in Airflow 3.0
 35 | alias_to_test_method_call.iter_dataset_aliases()
    |
 help: Use `iter_assets` instead
-31 | dataset_to_test_method_call.iter_dataset_aliases()
-32 | 
-33 | alias_to_test_method_call = DatasetAlias()
-   - alias_to_test_method_call.iter_datasets()
-34 + alias_to_test_method_call.iter_assets()
-35 | alias_to_test_method_call.iter_dataset_aliases()
-36 | 
-37 | any_to_test_method_call = DatasetAny()
+
+ℹ Safe fix
+31 31 | dataset_to_test_method_call.iter_dataset_aliases()
+32 32 | 
+33 33 | alias_to_test_method_call = DatasetAlias()
+34    |-alias_to_test_method_call.iter_datasets()
+   34 |+alias_to_test_method_call.iter_assets()
+35 35 | alias_to_test_method_call.iter_dataset_aliases()
+36 36 | 
+37 37 | any_to_test_method_call = DatasetAny()
 
 AIR301 [*] `iter_dataset_aliases` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:35:27
@@ -108,14 +118,16 @@ AIR301 [*] `iter_dataset_aliases` is removed in Airflow 3.0
 37 | any_to_test_method_call = DatasetAny()
    |
 help: Use `iter_asset_aliases` instead
-32 | 
-33 | alias_to_test_method_call = DatasetAlias()
-34 | alias_to_test_method_call.iter_datasets()
-   - alias_to_test_method_call.iter_dataset_aliases()
-35 + alias_to_test_method_call.iter_asset_aliases()
-36 | 
-37 | any_to_test_method_call = DatasetAny()
-38 | any_to_test_method_call.iter_datasets()
+
+ℹ Safe fix
+32 32 | 
+33 33 | alias_to_test_method_call = DatasetAlias()
+34 34 | alias_to_test_method_call.iter_datasets()
+35    |-alias_to_test_method_call.iter_dataset_aliases()
+   35 |+alias_to_test_method_call.iter_asset_aliases()
+36 36 | 
+37 37 | any_to_test_method_call = DatasetAny()
+38 38 | any_to_test_method_call.iter_datasets()
 
 AIR301 [*] `iter_datasets` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:38:25
@@ -126,14 +138,16 @@ AIR301 [*] `iter_datasets` is removed in Airflow 3.0
 39 | any_to_test_method_call.iter_dataset_aliases()
    |
 help: Use `iter_assets` instead
-35 | alias_to_test_method_call.iter_dataset_aliases()
-36 | 
-37 | any_to_test_method_call = DatasetAny()
-   - any_to_test_method_call.iter_datasets()
-38 + any_to_test_method_call.iter_assets()
-39 | any_to_test_method_call.iter_dataset_aliases()
-40 | 
-41 | # airflow.datasets.manager
+
+ℹ Safe fix
+35 35 | alias_to_test_method_call.iter_dataset_aliases()
+36 36 | 
+37 37 | any_to_test_method_call = DatasetAny()
+38    |-any_to_test_method_call.iter_datasets()
+   38 |+any_to_test_method_call.iter_assets()
+39 39 | any_to_test_method_call.iter_dataset_aliases()
+40 40 | 
+41 41 | # airflow.datasets.manager
 
 AIR301 [*] `iter_dataset_aliases` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:39:25
@@ -146,14 +160,16 @@ AIR301 [*] `iter_dataset_aliases` is removed in Airflow 3.0
 41 | # airflow.datasets.manager
    |
 help: Use `iter_asset_aliases` instead
-36 | 
-37 | any_to_test_method_call = DatasetAny()
-38 | any_to_test_method_call.iter_datasets()
-   - any_to_test_method_call.iter_dataset_aliases()
-39 + any_to_test_method_call.iter_asset_aliases()
-40 | 
-41 | # airflow.datasets.manager
-42 | dm = DatasetManager()
+
+ℹ Safe fix
+36 36 | 
+37 37 | any_to_test_method_call = DatasetAny()
+38 38 | any_to_test_method_call.iter_datasets()
+39    |-any_to_test_method_call.iter_dataset_aliases()
+   39 |+any_to_test_method_call.iter_asset_aliases()
+40 40 | 
+41 41 | # airflow.datasets.manager
+42 42 | dm = DatasetManager()
 
 AIR301 [*] `airflow.datasets.manager.DatasetManager` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:42:6
@@ -165,22 +181,24 @@ AIR301 [*] `airflow.datasets.manager.DatasetManager` is removed in Airflow 3.0
 44 | dm.create_datasets()
    |
 help: Use `AssetManager` from `airflow.assets.manager` instead.
-19 | from airflow.providers_manager import ProvidersManager
-20 | from airflow.secrets.base_secrets import BaseSecretsBackend
-21 | from airflow.secrets.local_filesystem import LocalFilesystemBackend
-22 + from airflow.assets.manager import AssetManager
-23 | 
-24 | # airflow.Dataset
-25 | dataset_from_root = DatasetFromRoot()
+
+ℹ Safe fix
+19 19 | from airflow.providers_manager import ProvidersManager
+20 20 | from airflow.secrets.base_secrets import BaseSecretsBackend
+21 21 | from airflow.secrets.local_filesystem import LocalFilesystemBackend
+   22 |+from airflow.assets.manager import AssetManager
+22 23 | 
+23 24 | # airflow.Dataset
+24 25 | dataset_from_root = DatasetFromRoot()
 --------------------------------------------------------------------------------
-40 | any_to_test_method_call.iter_dataset_aliases()
-41 | 
-42 | # airflow.datasets.manager
-   - dm = DatasetManager()
-43 + dm = AssetManager()
-44 | dm.register_dataset_change()
-45 | dm.create_datasets()
-46 | dm.notify_dataset_created()
+39 40 | any_to_test_method_call.iter_dataset_aliases()
+40 41 | 
+41 42 | # airflow.datasets.manager
+42    |-dm = DatasetManager()
+   43 |+dm = AssetManager()
+43 44 | dm.register_dataset_change()
+44 45 | dm.create_datasets()
+45 46 | dm.notify_dataset_created()
 
 AIR301 [*] `register_dataset_change` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:43:4
@@ -193,14 +211,16 @@ AIR301 [*] `register_dataset_change` is removed in Airflow 3.0
 45 | dm.notify_dataset_created()
    |
 help: Use `register_asset_change` instead
-40 | 
-41 | # airflow.datasets.manager
-42 | dm = DatasetManager()
-   - dm.register_dataset_change()
-43 + dm.register_asset_change()
-44 | dm.create_datasets()
-45 | dm.notify_dataset_created()
-46 | dm.notify_dataset_changed()
+
+ℹ Safe fix
+40 40 | 
+41 41 | # airflow.datasets.manager
+42 42 | dm = DatasetManager()
+43    |-dm.register_dataset_change()
+   43 |+dm.register_asset_change()
+44 44 | dm.create_datasets()
+45 45 | dm.notify_dataset_created()
+46 46 | dm.notify_dataset_changed()
 
 AIR301 [*] `create_datasets` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:44:4
@@ -213,14 +233,16 @@ AIR301 [*] `create_datasets` is removed in Airflow 3.0
 46 | dm.notify_dataset_changed()
    |
 help: Use `create_assets` instead
-41 | # airflow.datasets.manager
-42 | dm = DatasetManager()
-43 | dm.register_dataset_change()
-   - dm.create_datasets()
-44 + dm.create_assets()
-45 | dm.notify_dataset_created()
-46 | dm.notify_dataset_changed()
-47 | dm.notify_dataset_alias_created()
+
+ℹ Safe fix
+41 41 | # airflow.datasets.manager
+42 42 | dm = DatasetManager()
+43 43 | dm.register_dataset_change()
+44    |-dm.create_datasets()
+   44 |+dm.create_assets()
+45 45 | dm.notify_dataset_created()
+46 46 | dm.notify_dataset_changed()
+47 47 | dm.notify_dataset_alias_created()
 
 AIR301 [*] `notify_dataset_created` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:45:4
@@ -233,14 +255,16 @@ AIR301 [*] `notify_dataset_created` is removed in Airflow 3.0
 47 | dm.notify_dataset_alias_created()
    |
 help: Use `notify_asset_created` instead
-42 | dm = DatasetManager()
-43 | dm.register_dataset_change()
-44 | dm.create_datasets()
-   - dm.notify_dataset_created()
-45 + dm.notify_asset_created()
-46 | dm.notify_dataset_changed()
-47 | dm.notify_dataset_alias_created()
-48 | 
+
+ℹ Safe fix
+42 42 | dm = DatasetManager()
+43 43 | dm.register_dataset_change()
+44 44 | dm.create_datasets()
+45    |-dm.notify_dataset_created()
+   45 |+dm.notify_asset_created()
+46 46 | dm.notify_dataset_changed()
+47 47 | dm.notify_dataset_alias_created()
+48 48 | 
 
 AIR301 [*] `notify_dataset_changed` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:46:4
@@ -252,14 +276,16 @@ AIR301 [*] `notify_dataset_changed` is removed in Airflow 3.0
 47 | dm.notify_dataset_alias_created()
    |
 help: Use `notify_asset_changed` instead
-43 | dm.register_dataset_change()
-44 | dm.create_datasets()
-45 | dm.notify_dataset_created()
-   - dm.notify_dataset_changed()
-46 + dm.notify_asset_changed()
-47 | dm.notify_dataset_alias_created()
-48 | 
-49 | # airflow.lineage.hook
+
+ℹ Safe fix
+43 43 | dm.register_dataset_change()
+44 44 | dm.create_datasets()
+45 45 | dm.notify_dataset_created()
+46    |-dm.notify_dataset_changed()
+   46 |+dm.notify_asset_changed()
+47 47 | dm.notify_dataset_alias_created()
+48 48 | 
+49 49 | # airflow.lineage.hook
 
 AIR301 [*] `notify_dataset_alias_created` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:47:4
@@ -272,14 +298,16 @@ AIR301 [*] `notify_dataset_alias_created` is removed in Airflow 3.0
 49 | # airflow.lineage.hook
    |
 help: Use `notify_asset_alias_created` instead
-44 | dm.create_datasets()
-45 | dm.notify_dataset_created()
-46 | dm.notify_dataset_changed()
-   - dm.notify_dataset_alias_created()
-47 + dm.notify_asset_alias_created()
-48 | 
-49 | # airflow.lineage.hook
-50 | dl_info = DatasetLineageInfo()
+
+ℹ Safe fix
+44 44 | dm.create_datasets()
+45 45 | dm.notify_dataset_created()
+46 46 | dm.notify_dataset_changed()
+47    |-dm.notify_dataset_alias_created()
+   47 |+dm.notify_asset_alias_created()
+48 48 | 
+49 49 | # airflow.lineage.hook
+50 50 | dl_info = DatasetLineageInfo()
 
 AIR301 [*] `airflow.lineage.hook.DatasetLineageInfo` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:50:11
@@ -290,23 +318,25 @@ AIR301 [*] `airflow.lineage.hook.DatasetLineageInfo` is removed in Airflow 3.0
 51 | dl_info.dataset
    |
 help: Use `AssetLineageInfo` from `airflow.lineage.hook` instead.
-9  |     DatasetAny,
-10 | )
-11 | from airflow.datasets.manager import DatasetManager
-   - from airflow.lineage.hook import DatasetLineageInfo, HookLineageCollector
-12 + from airflow.lineage.hook import DatasetLineageInfo, HookLineageCollector, AssetLineageInfo
-13 | from airflow.providers.amazon.aws.auth_manager.aws_auth_manager import AwsAuthManager
-14 | from airflow.providers.apache.beam.hooks import BeamHook, NotAir302HookError
-15 | from airflow.providers.google.cloud.secrets.secret_manager import (
+
+ℹ Safe fix
+9  9  |     DatasetAny,
+10 10 | )
+11 11 | from airflow.datasets.manager import DatasetManager
+12    |-from airflow.lineage.hook import DatasetLineageInfo, HookLineageCollector
+   12 |+from airflow.lineage.hook import DatasetLineageInfo, HookLineageCollector, AssetLineageInfo
+13 13 | from airflow.providers.amazon.aws.auth_manager.aws_auth_manager import AwsAuthManager
+14 14 | from airflow.providers.apache.beam.hooks import BeamHook, NotAir302HookError
+15 15 | from airflow.providers.google.cloud.secrets.secret_manager import (
 --------------------------------------------------------------------------------
-47 | dm.notify_dataset_alias_created()
-48 | 
-49 | # airflow.lineage.hook
-   - dl_info = DatasetLineageInfo()
-50 + dl_info = AssetLineageInfo()
-51 | dl_info.dataset
-52 | 
-53 | hlc = HookLineageCollector()
+47 47 | dm.notify_dataset_alias_created()
+48 48 | 
+49 49 | # airflow.lineage.hook
+50    |-dl_info = DatasetLineageInfo()
+   50 |+dl_info = AssetLineageInfo()
+51 51 | dl_info.dataset
+52 52 | 
+53 53 | hlc = HookLineageCollector()
 
 AIR301 [*] `dataset` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:51:9
@@ -319,14 +349,16 @@ AIR301 [*] `dataset` is removed in Airflow 3.0
 53 | hlc = HookLineageCollector()
    |
 help: Use `asset` instead
-48 | 
-49 | # airflow.lineage.hook
-50 | dl_info = DatasetLineageInfo()
-   - dl_info.dataset
-51 + dl_info.asset
-52 | 
-53 | hlc = HookLineageCollector()
-54 | hlc.create_dataset()
+
+ℹ Safe fix
+48 48 | 
+49 49 | # airflow.lineage.hook
+50 50 | dl_info = DatasetLineageInfo()
+51    |-dl_info.dataset
+   51 |+dl_info.asset
+52 52 | 
+53 53 | hlc = HookLineageCollector()
+54 54 | hlc.create_dataset()
 
 AIR301 [*] `create_dataset` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:54:5
@@ -338,14 +370,16 @@ AIR301 [*] `create_dataset` is removed in Airflow 3.0
 56 | hlc.add_output_dataset()
    |
 help: Use `create_asset` instead
-51 | dl_info.dataset
-52 | 
-53 | hlc = HookLineageCollector()
-   - hlc.create_dataset()
-54 + hlc.create_asset()
-55 | hlc.add_input_dataset()
-56 | hlc.add_output_dataset()
-57 | hlc.collected_datasets()
+
+ℹ Safe fix
+51 51 | dl_info.dataset
+52 52 | 
+53 53 | hlc = HookLineageCollector()
+54    |-hlc.create_dataset()
+   54 |+hlc.create_asset()
+55 55 | hlc.add_input_dataset()
+56 56 | hlc.add_output_dataset()
+57 57 | hlc.collected_datasets()
 
 AIR301 [*] `add_input_dataset` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:55:5
@@ -358,14 +392,16 @@ AIR301 [*] `add_input_dataset` is removed in Airflow 3.0
 57 | hlc.collected_datasets()
    |
 help: Use `add_input_asset` instead
-52 | 
-53 | hlc = HookLineageCollector()
-54 | hlc.create_dataset()
-   - hlc.add_input_dataset()
-55 + hlc.add_input_asset()
-56 | hlc.add_output_dataset()
-57 | hlc.collected_datasets()
-58 | 
+
+ℹ Safe fix
+52 52 | 
+53 53 | hlc = HookLineageCollector()
+54 54 | hlc.create_dataset()
+55    |-hlc.add_input_dataset()
+   55 |+hlc.add_input_asset()
+56 56 | hlc.add_output_dataset()
+57 57 | hlc.collected_datasets()
+58 58 | 
 
 AIR301 [*] `add_output_dataset` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:56:5
@@ -377,14 +413,16 @@ AIR301 [*] `add_output_dataset` is removed in Airflow 3.0
 57 | hlc.collected_datasets()
    |
 help: Use `add_output_asset` instead
-53 | hlc = HookLineageCollector()
-54 | hlc.create_dataset()
-55 | hlc.add_input_dataset()
-   - hlc.add_output_dataset()
-56 + hlc.add_output_asset()
-57 | hlc.collected_datasets()
-58 | 
-59 | # airflow.providers.amazon.auth_manager.aws_auth_manager
+
+ℹ Safe fix
+53 53 | hlc = HookLineageCollector()
+54 54 | hlc.create_dataset()
+55 55 | hlc.add_input_dataset()
+56    |-hlc.add_output_dataset()
+   56 |+hlc.add_output_asset()
+57 57 | hlc.collected_datasets()
+58 58 | 
+59 59 | # airflow.providers.amazon.auth_manager.aws_auth_manager
 
 AIR301 [*] `collected_datasets` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:57:5
@@ -397,14 +435,16 @@ AIR301 [*] `collected_datasets` is removed in Airflow 3.0
 59 | # airflow.providers.amazon.auth_manager.aws_auth_manager
    |
 help: Use `collected_assets` instead
-54 | hlc.create_dataset()
-55 | hlc.add_input_dataset()
-56 | hlc.add_output_dataset()
-   - hlc.collected_datasets()
-57 + hlc.collected_assets()
-58 | 
-59 | # airflow.providers.amazon.auth_manager.aws_auth_manager
-60 | aam = AwsAuthManager()
+
+ℹ Safe fix
+54 54 | hlc.create_dataset()
+55 55 | hlc.add_input_dataset()
+56 56 | hlc.add_output_dataset()
+57    |-hlc.collected_datasets()
+   57 |+hlc.collected_assets()
+58 58 | 
+59 59 | # airflow.providers.amazon.auth_manager.aws_auth_manager
+60 60 | aam = AwsAuthManager()
 
 AIR301 [*] `is_authorized_dataset` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:61:5
@@ -417,14 +457,16 @@ AIR301 [*] `is_authorized_dataset` is removed in Airflow 3.0
 63 | # airflow.providers.apache.beam.hooks
    |
 help: Use `is_authorized_asset` instead
-58 | 
-59 | # airflow.providers.amazon.auth_manager.aws_auth_manager
-60 | aam = AwsAuthManager()
-   - aam.is_authorized_dataset()
-61 + aam.is_authorized_asset()
-62 | 
-63 | # airflow.providers.apache.beam.hooks
-64 | # check get_conn_uri is caught if the class inherits from an airflow hook
+
+ℹ Safe fix
+58 58 | 
+59 59 | # airflow.providers.amazon.auth_manager.aws_auth_manager
+60 60 | aam = AwsAuthManager()
+61    |-aam.is_authorized_dataset()
+   61 |+aam.is_authorized_asset()
+62 62 | 
+63 63 | # airflow.providers.apache.beam.hooks
+64 64 | # check get_conn_uri is caught if the class inherits from an airflow hook
 
 AIR301 [*] `get_conn_uri` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:73:13
@@ -436,14 +478,16 @@ AIR301 [*] `get_conn_uri` is removed in Airflow 3.0
 74 | csm_backend.get_connections()
    |
 help: Use `get_conn_value` instead
-70 | 
-71 | # airflow.providers.google.cloud.secrets.secret_manager
-72 | csm_backend = CloudSecretManagerBackend()
-   - csm_backend.get_conn_uri()
-73 + csm_backend.get_conn_value()
-74 | csm_backend.get_connections()
-75 | 
-76 | # airflow.providers.hashicorp.secrets.vault
+
+ℹ Safe fix
+70 70 | 
+71 71 | # airflow.providers.google.cloud.secrets.secret_manager
+72 72 | csm_backend = CloudSecretManagerBackend()
+73    |-csm_backend.get_conn_uri()
+   73 |+csm_backend.get_conn_value()
+74 74 | csm_backend.get_connections()
+75 75 | 
+76 76 | # airflow.providers.hashicorp.secrets.vault
 
 AIR301 [*] `get_connections` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:74:13
@@ -456,14 +500,16 @@ AIR301 [*] `get_connections` is removed in Airflow 3.0
 76 | # airflow.providers.hashicorp.secrets.vault
    |
 help: Use `get_connection` instead
-71 | # airflow.providers.google.cloud.secrets.secret_manager
-72 | csm_backend = CloudSecretManagerBackend()
-73 | csm_backend.get_conn_uri()
-   - csm_backend.get_connections()
-74 + csm_backend.get_connection()
-75 | 
-76 | # airflow.providers.hashicorp.secrets.vault
-77 | vault_backend = VaultBackend()
+
+ℹ Safe fix
+71 71 | # airflow.providers.google.cloud.secrets.secret_manager
+72 72 | csm_backend = CloudSecretManagerBackend()
+73 73 | csm_backend.get_conn_uri()
+74    |-csm_backend.get_connections()
+   74 |+csm_backend.get_connection()
+75 75 | 
+76 76 | # airflow.providers.hashicorp.secrets.vault
+77 77 | vault_backend = VaultBackend()
 
 AIR301 [*] `get_conn_uri` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:78:15
@@ -475,14 +521,16 @@ AIR301 [*] `get_conn_uri` is removed in Airflow 3.0
 79 | vault_backend.get_connections()
    |
 help: Use `get_conn_value` instead
-75 | 
-76 | # airflow.providers.hashicorp.secrets.vault
-77 | vault_backend = VaultBackend()
-   - vault_backend.get_conn_uri()
-78 + vault_backend.get_conn_value()
-79 | vault_backend.get_connections()
-80 | 
-81 | not_an_error = NotAir302SecretError()
+
+ℹ Safe fix
+75 75 | 
+76 76 | # airflow.providers.hashicorp.secrets.vault
+77 77 | vault_backend = VaultBackend()
+78    |-vault_backend.get_conn_uri()
+   78 |+vault_backend.get_conn_value()
+79 79 | vault_backend.get_connections()
+80 80 | 
+81 81 | not_an_error = NotAir302SecretError()
 
 AIR301 [*] `get_connections` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:79:15
@@ -495,14 +543,16 @@ AIR301 [*] `get_connections` is removed in Airflow 3.0
 81 | not_an_error = NotAir302SecretError()
    |
 help: Use `get_connection` instead
-76 | # airflow.providers.hashicorp.secrets.vault
-77 | vault_backend = VaultBackend()
-78 | vault_backend.get_conn_uri()
-   - vault_backend.get_connections()
-79 + vault_backend.get_connection()
-80 | 
-81 | not_an_error = NotAir302SecretError()
-82 | not_an_error.get_conn_uri()
+
+ℹ Safe fix
+76 76 | # airflow.providers.hashicorp.secrets.vault
+77 77 | vault_backend = VaultBackend()
+78 78 | vault_backend.get_conn_uri()
+79    |-vault_backend.get_connections()
+   79 |+vault_backend.get_connection()
+80 80 | 
+81 81 | not_an_error = NotAir302SecretError()
+82 82 | not_an_error.get_conn_uri()
 
 AIR301 [*] `initialize_providers_dataset_uri_resources` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:86:4
@@ -515,14 +565,16 @@ AIR301 [*] `initialize_providers_dataset_uri_resources` is removed in Airflow 3.
 88 | pm.dataset_uri_handlers
    |
 help: Use `initialize_providers_asset_uri_resources` instead
-83 | 
-84 | # airflow.providers_manager
-85 | pm = ProvidersManager()
-   - pm.initialize_providers_dataset_uri_resources()
-86 + pm.initialize_providers_asset_uri_resources()
-87 | pm.dataset_factories
-88 | pm.dataset_uri_handlers
-89 | pm.dataset_to_openlineage_converters
+
+ℹ Safe fix
+83 83 | 
+84 84 | # airflow.providers_manager
+85 85 | pm = ProvidersManager()
+86    |-pm.initialize_providers_dataset_uri_resources()
+   86 |+pm.initialize_providers_asset_uri_resources()
+87 87 | pm.dataset_factories
+88 88 | pm.dataset_uri_handlers
+89 89 | pm.dataset_to_openlineage_converters
 
 AIR301 [*] `dataset_factories` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:87:4
@@ -535,14 +587,16 @@ AIR301 [*] `dataset_factories` is removed in Airflow 3.0
 89 | pm.dataset_to_openlineage_converters
    |
 help: Use `asset_factories` instead
-84 | # airflow.providers_manager
-85 | pm = ProvidersManager()
-86 | pm.initialize_providers_dataset_uri_resources()
-   - pm.dataset_factories
-87 + pm.asset_factories
-88 | pm.dataset_uri_handlers
-89 | pm.dataset_to_openlineage_converters
-90 | 
+
+ℹ Safe fix
+84 84 | # airflow.providers_manager
+85 85 | pm = ProvidersManager()
+86 86 | pm.initialize_providers_dataset_uri_resources()
+87    |-pm.dataset_factories
+   87 |+pm.asset_factories
+88 88 | pm.dataset_uri_handlers
+89 89 | pm.dataset_to_openlineage_converters
+90 90 | 
 
 AIR301 [*] `dataset_uri_handlers` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:88:4
@@ -554,14 +608,16 @@ AIR301 [*] `dataset_uri_handlers` is removed in Airflow 3.0
 89 | pm.dataset_to_openlineage_converters
    |
 help: Use `asset_uri_handlers` instead
-85 | pm = ProvidersManager()
-86 | pm.initialize_providers_dataset_uri_resources()
-87 | pm.dataset_factories
-   - pm.dataset_uri_handlers
-88 + pm.asset_uri_handlers
-89 | pm.dataset_to_openlineage_converters
-90 | 
-91 | # airflow.secrets.base_secrets
+
+ℹ Safe fix
+85 85 | pm = ProvidersManager()
+86 86 | pm.initialize_providers_dataset_uri_resources()
+87 87 | pm.dataset_factories
+88    |-pm.dataset_uri_handlers
+   88 |+pm.asset_uri_handlers
+89 89 | pm.dataset_to_openlineage_converters
+90 90 | 
+91 91 | # airflow.secrets.base_secrets
 
 AIR301 [*] `dataset_to_openlineage_converters` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:89:4
@@ -574,14 +630,16 @@ AIR301 [*] `dataset_to_openlineage_converters` is removed in Airflow 3.0
 91 | # airflow.secrets.base_secrets
    |
 help: Use `asset_to_openlineage_converters` instead
-86 | pm.initialize_providers_dataset_uri_resources()
-87 | pm.dataset_factories
-88 | pm.dataset_uri_handlers
-   - pm.dataset_to_openlineage_converters
-89 + pm.asset_to_openlineage_converters
-90 | 
-91 | # airflow.secrets.base_secrets
-92 | base_secret_backend = BaseSecretsBackend()
+
+ℹ Safe fix
+86 86 | pm.initialize_providers_dataset_uri_resources()
+87 87 | pm.dataset_factories
+88 88 | pm.dataset_uri_handlers
+89    |-pm.dataset_to_openlineage_converters
+   89 |+pm.asset_to_openlineage_converters
+90 90 | 
+91 91 | # airflow.secrets.base_secrets
+92 92 | base_secret_backend = BaseSecretsBackend()
 
 AIR301 [*] `get_conn_uri` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:93:21
@@ -593,14 +651,16 @@ AIR301 [*] `get_conn_uri` is removed in Airflow 3.0
 94 | base_secret_backend.get_connections()
    |
 help: Use `get_conn_value` instead
-90 | 
-91 | # airflow.secrets.base_secrets
-92 | base_secret_backend = BaseSecretsBackend()
-   - base_secret_backend.get_conn_uri()
-93 + base_secret_backend.get_conn_value()
-94 | base_secret_backend.get_connections()
-95 | 
-96 | # airflow.secrets.local_filesystem
+
+ℹ Safe fix
+90 90 | 
+91 91 | # airflow.secrets.base_secrets
+92 92 | base_secret_backend = BaseSecretsBackend()
+93    |-base_secret_backend.get_conn_uri()
+   93 |+base_secret_backend.get_conn_value()
+94 94 | base_secret_backend.get_connections()
+95 95 | 
+96 96 | # airflow.secrets.local_filesystem
 
 AIR301 [*] `get_connections` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:94:21
@@ -613,14 +673,16 @@ AIR301 [*] `get_connections` is removed in Airflow 3.0
 96 | # airflow.secrets.local_filesystem
    |
 help: Use `get_connection` instead
-91 | # airflow.secrets.base_secrets
-92 | base_secret_backend = BaseSecretsBackend()
-93 | base_secret_backend.get_conn_uri()
-   - base_secret_backend.get_connections()
-94 + base_secret_backend.get_connection()
-95 | 
-96 | # airflow.secrets.local_filesystem
-97 | lfb = LocalFilesystemBackend()
+
+ℹ Safe fix
+91 91 | # airflow.secrets.base_secrets
+92 92 | base_secret_backend = BaseSecretsBackend()
+93 93 | base_secret_backend.get_conn_uri()
+94    |-base_secret_backend.get_connections()
+   94 |+base_secret_backend.get_connection()
+95 95 | 
+96 96 | # airflow.secrets.local_filesystem
+97 97 | lfb = LocalFilesystemBackend()
 
 AIR301 [*] `get_connections` is removed in Airflow 3.0
   --> AIR301_class_attribute.py:98:5
@@ -631,8 +693,10 @@ AIR301 [*] `get_connections` is removed in Airflow 3.0
    |     ^^^^^^^^^^^^^^^
    |
 help: Use `get_connection` instead
-95 | 
-96 | # airflow.secrets.local_filesystem
-97 | lfb = LocalFilesystemBackend()
-   - lfb.get_connections()
-98 + lfb.get_connection()
+
+ℹ Safe fix
+95 95 | 
+96 96 | # airflow.secrets.local_filesystem
+97 97 | lfb = LocalFilesystemBackend()
+98    |-lfb.get_connections()
+   98 |+lfb.get_connection()

crates/ruff_linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR301_AIR301_context.py.snap

@@ -337,14 +337,16 @@ AIR301 [*] `schedule_interval` is removed in Airflow 3.0
 113 |     template_searchpath=["/templates"],
     |
 help: Use `schedule` instead
-108 | 
-109 | with DAG(
-110 |     dag_id="example_dag",
-    -     schedule_interval="@daily",
-111 +     schedule="@daily",
-112 |     start_date=datetime(2023, 1, 1),
-113 |     template_searchpath=["/templates"],
-114 | ) as dag:
+
+ℹ Safe fix
+108 108 | 
+109 109 | with DAG(
+110 110 |     dag_id="example_dag",
+111     |-    schedule_interval="@daily",
+    111 |+    schedule="@daily",
+112 112 |     start_date=datetime(2023, 1, 1),
+113 113 |     template_searchpath=["/templates"],
+114 114 | ) as dag:
 
 AIR301 `next_ds` is removed in Airflow 3.0
    --> AIR301_context.py:135:23

crates/ruff_linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR301_AIR301_names.py.snap

@@ -2,362 +2,351 @@
 source: crates/ruff_linter/src/rules/airflow/mod.rs
 ---
 AIR301 `airflow.PY36` is removed in Airflow 3.0
-  --> AIR301_names.py:40:1
+  --> AIR301_names.py:39:1
    |
-39 | # airflow root
-40 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
+38 | # airflow root
+39 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
    | ^^^^
-41 |
-42 | # airflow.api_connexion.security
+40 |
+41 | # airflow.api_connexion.security
    |
 help: Use `sys.version_info` instead
 
 AIR301 `airflow.PY37` is removed in Airflow 3.0
-  --> AIR301_names.py:40:7
+  --> AIR301_names.py:39:7
    |
-39 | # airflow root
-40 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
+38 | # airflow root
+39 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
    |       ^^^^
-41 |
-42 | # airflow.api_connexion.security
+40 |
+41 | # airflow.api_connexion.security
    |
 help: Use `sys.version_info` instead
 
 AIR301 `airflow.PY38` is removed in Airflow 3.0
-  --> AIR301_names.py:40:13
+  --> AIR301_names.py:39:13
    |
-39 | # airflow root
-40 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
+38 | # airflow root
+39 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
    |             ^^^^
-41 |
-42 | # airflow.api_connexion.security
+40 |
+41 | # airflow.api_connexion.security
    |
 help: Use `sys.version_info` instead
 
 AIR301 `airflow.PY39` is removed in Airflow 3.0
-  --> AIR301_names.py:40:19
+  --> AIR301_names.py:39:19
    |
-39 | # airflow root
-40 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
+38 | # airflow root
+39 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
    |                   ^^^^
-41 |
-42 | # airflow.api_connexion.security
+40 |
+41 | # airflow.api_connexion.security
    |
 help: Use `sys.version_info` instead
 
 AIR301 `airflow.PY310` is removed in Airflow 3.0
-  --> AIR301_names.py:40:25
+  --> AIR301_names.py:39:25
    |
-39 | # airflow root
-40 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
+38 | # airflow root
+39 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
    |                         ^^^^^
-41 |
-42 | # airflow.api_connexion.security
+40 |
+41 | # airflow.api_connexion.security
    |
 help: Use `sys.version_info` instead
 
 AIR301 `airflow.PY311` is removed in Airflow 3.0
-  --> AIR301_names.py:40:32
+  --> AIR301_names.py:39:32
    |
-39 | # airflow root
-40 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
+38 | # airflow root
+39 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
    |                                ^^^^^
-41 |
-42 | # airflow.api_connexion.security
+40 |
+41 | # airflow.api_connexion.security
    |
 help: Use `sys.version_info` instead
 
 AIR301 `airflow.PY312` is removed in Airflow 3.0
-  --> AIR301_names.py:40:39
+  --> AIR301_names.py:39:39
    |
-39 | # airflow root
-40 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
+38 | # airflow root
+39 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
    |                                       ^^^^^
-41 |
-42 | # airflow.api_connexion.security
+40 |
+41 | # airflow.api_connexion.security
    |
 help: Use `sys.version_info` instead
 
 AIR301 `airflow.api_connexion.security.requires_access` is removed in Airflow 3.0
-  --> AIR301_names.py:43:1
+  --> AIR301_names.py:42:1
    |
-42 | # airflow.api_connexion.security
-43 | requires_access
+41 | # airflow.api_connexion.security
+42 | requires_access
    | ^^^^^^^^^^^^^^^
-44 |
-45 | # airflow.contrib.*
+43 |
+44 | # airflow.contrib.*
    |
 help: Use `airflow.api_fastapi.core_api.security.requires_access_*` instead
 
 AIR301 `airflow.contrib.aws_athena_hook.AWSAthenaHook` is removed in Airflow 3.0
-  --> AIR301_names.py:46:1
+  --> AIR301_names.py:45:1
    |
-45 | # airflow.contrib.*
-46 | AWSAthenaHook()
+44 | # airflow.contrib.*
+45 | AWSAthenaHook()
    | ^^^^^^^^^^^^^
    |
 help: The whole `airflow.contrib` module has been removed.
 
 AIR301 `airflow.datasets.DatasetAliasEvent` is removed in Airflow 3.0
-  --> AIR301_names.py:50:1
+  --> AIR301_names.py:49:1
    |
-49 | # airflow.datasets
-50 | DatasetAliasEvent()
+48 | # airflow.datasets
+49 | DatasetAliasEvent()
    | ^^^^^^^^^^^^^^^^^
    |
 
 AIR301 `airflow.operators.subdag.SubDagOperator` is removed in Airflow 3.0
-  --> AIR301_names.py:54:1
+  --> AIR301_names.py:53:1
    |
-53 | # airflow.operators.subdag.*
-54 | SubDagOperator()
+52 | # airflow.operators.subdag.*
+53 | SubDagOperator()
    | ^^^^^^^^^^^^^^
-55 |
-56 | # airflow.operators.postgres_operator
    |
 help: The whole `airflow.subdag` module has been removed.
 
-AIR301 `airflow.operators.postgres_operator.Mapping` is removed in Airflow 3.0
-  --> AIR301_names.py:57:1
-   |
-56 | # airflow.operators.postgres_operator
-57 | Mapping()
-   | ^^^^^^^
-58 |
-59 | # airflow.secrets
-   |
-
 AIR301 [*] `airflow.secrets.cache.SecretCache` is removed in Airflow 3.0
-  --> AIR301_names.py:64:1
+  --> AIR301_names.py:61:1
    |
-63 | # airflow.secrets.cache
-64 | SecretCache()
+60 | # airflow.secrets.cache
+61 | SecretCache()
    | ^^^^^^^^^^^
    |
 help: Use `SecretCache` from `airflow.sdk` instead.
-14 | from airflow.datasets import DatasetAliasEvent
-15 | from airflow.operators.postgres_operator import Mapping
-16 | from airflow.operators.subdag import SubDagOperator
-   - from airflow.secrets.cache import SecretCache
-17 | from airflow.secrets.local_filesystem import LocalFilesystemBackend
-18 | from airflow.triggers.external_task import TaskStateTrigger
-19 | from airflow.utils import dates
+
+ℹ Unsafe fix
+13 13 | from airflow.contrib.aws_athena_hook import AWSAthenaHook
+14 14 | from airflow.datasets import DatasetAliasEvent
+15 15 | from airflow.operators.subdag import SubDagOperator
+16    |-from airflow.secrets.cache import SecretCache
+17 16 | from airflow.secrets.local_filesystem import LocalFilesystemBackend
+18 17 | from airflow.triggers.external_task import TaskStateTrigger
+19 18 | from airflow.utils import dates
 --------------------------------------------------------------------------------
-34 | from airflow.utils.trigger_rule import TriggerRule
-35 | from airflow.www.auth import has_access, has_access_dataset
-36 | from airflow.www.utils import get_sensitive_variables_fields, should_hide_value_for_key
-37 + from airflow.sdk import SecretCache
-38 | 
-39 | # airflow root
-40 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
-note: This is an unsafe fix and may change runtime behavior
+34 33 | from airflow.utils.trigger_rule import TriggerRule
+35 34 | from airflow.www.auth import has_access, has_access_dataset
+36 35 | from airflow.www.utils import get_sensitive_variables_fields, should_hide_value_for_key
+   36 |+from airflow.sdk import SecretCache
+37 37 | 
+38 38 | # airflow root
+39 39 | PY36, PY37, PY38, PY39, PY310, PY311, PY312
 
 AIR301 `airflow.triggers.external_task.TaskStateTrigger` is removed in Airflow 3.0
+  --> AIR301_names.py:65:1
+   |
+64 | # airflow.triggers.external_task
+65 | TaskStateTrigger()
+   | ^^^^^^^^^^^^^^^^
+66 |
+67 | # airflow.utils.date
+   |
+
+AIR301 `airflow.utils.dates.date_range` is removed in Airflow 3.0
   --> AIR301_names.py:68:1
    |
-67 | # airflow.triggers.external_task
-68 | TaskStateTrigger()
+67 | # airflow.utils.date
+68 | dates.date_range
    | ^^^^^^^^^^^^^^^^
-69 |
-70 | # airflow.utils.date
+69 | dates.days_ago
    |
 
+AIR301 `airflow.utils.dates.days_ago` is removed in Airflow 3.0
+  --> AIR301_names.py:69:1
+   |
+67 | # airflow.utils.date
+68 | dates.date_range
+69 | dates.days_ago
+   | ^^^^^^^^^^^^^^
+70 |
+71 | date_range
+   |
+help: Use `pendulum.today('UTC').add(days=-N, ...)` instead
+
 AIR301 `airflow.utils.dates.date_range` is removed in Airflow 3.0
   --> AIR301_names.py:71:1
    |
-70 | # airflow.utils.date
-71 | dates.date_range
-   | ^^^^^^^^^^^^^^^^
-72 | dates.days_ago
+69 | dates.days_ago
+70 |
+71 | date_range
+   | ^^^^^^^^^^
+72 | days_ago
+73 | infer_time_unit
    |
 
 AIR301 `airflow.utils.dates.days_ago` is removed in Airflow 3.0
   --> AIR301_names.py:72:1
    |
-70 | # airflow.utils.date
-71 | dates.date_range
-72 | dates.days_ago
-   | ^^^^^^^^^^^^^^
-73 |
-74 | date_range
-   |
-help: Use `pendulum.today('UTC').add(days=-N, ...)` instead
-
-AIR301 `airflow.utils.dates.date_range` is removed in Airflow 3.0
-  --> AIR301_names.py:74:1
-   |
-72 | dates.days_ago
-73 |
-74 | date_range
-   | ^^^^^^^^^^
-75 | days_ago
-76 | infer_time_unit
-   |
-
-AIR301 `airflow.utils.dates.days_ago` is removed in Airflow 3.0
-  --> AIR301_names.py:75:1
-   |
-74 | date_range
-75 | days_ago
+71 | date_range
+72 | days_ago
    | ^^^^^^^^
-76 | infer_time_unit
-77 | parse_execution_date
+73 | infer_time_unit
+74 | parse_execution_date
    |
 help: Use `pendulum.today('UTC').add(days=-N, ...)` instead
 
 AIR301 `airflow.utils.dates.infer_time_unit` is removed in Airflow 3.0
-  --> AIR301_names.py:76:1
+  --> AIR301_names.py:73:1
    |
-74 | date_range
-75 | days_ago
-76 | infer_time_unit
+71 | date_range
+72 | days_ago
+73 | infer_time_unit
    | ^^^^^^^^^^^^^^^
-77 | parse_execution_date
-78 | round_time
+74 | parse_execution_date
+75 | round_time
    |
 
 AIR301 `airflow.utils.dates.parse_execution_date` is removed in Airflow 3.0
-  --> AIR301_names.py:77:1
+  --> AIR301_names.py:74:1
    |
-75 | days_ago
-76 | infer_time_unit
-77 | parse_execution_date
+72 | days_ago
+73 | infer_time_unit
+74 | parse_execution_date
    | ^^^^^^^^^^^^^^^^^^^^
-78 | round_time
-79 | scale_time_units
+75 | round_time
+76 | scale_time_units
    |
 
 AIR301 `airflow.utils.dates.round_time` is removed in Airflow 3.0
-  --> AIR301_names.py:78:1
+  --> AIR301_names.py:75:1
    |
-76 | infer_time_unit
-77 | parse_execution_date
-78 | round_time
+73 | infer_time_unit
+74 | parse_execution_date
+75 | round_time
    | ^^^^^^^^^^
-79 | scale_time_units
+76 | scale_time_units
    |
 
 AIR301 `airflow.utils.dates.scale_time_units` is removed in Airflow 3.0
-  --> AIR301_names.py:79:1
+  --> AIR301_names.py:76:1
    |
-77 | parse_execution_date
-78 | round_time
-79 | scale_time_units
+74 | parse_execution_date
+75 | round_time
+76 | scale_time_units
    | ^^^^^^^^^^^^^^^^
-80 |
-81 | # This one was not deprecated.
+77 |
+78 | # This one was not deprecated.
    |
 
 AIR301 `airflow.utils.dag_cycle_tester.test_cycle` is removed in Airflow 3.0
-  --> AIR301_names.py:86:1
+  --> AIR301_names.py:83:1
    |
-85 | # airflow.utils.dag_cycle_tester
-86 | test_cycle
+82 | # airflow.utils.dag_cycle_tester
+83 | test_cycle
    | ^^^^^^^^^^
    |
 
 AIR301 `airflow.utils.db.create_session` is removed in Airflow 3.0
-  --> AIR301_names.py:90:1
+  --> AIR301_names.py:87:1
    |
-89 | # airflow.utils.db
-90 | create_session
+86 | # airflow.utils.db
+87 | create_session
    | ^^^^^^^^^^^^^^
-91 |
-92 | # airflow.utils.decorators
+88 |
+89 | # airflow.utils.decorators
    |
 
 AIR301 `airflow.utils.decorators.apply_defaults` is removed in Airflow 3.0
-  --> AIR301_names.py:93:1
+  --> AIR301_names.py:90:1
    |
-92 | # airflow.utils.decorators
-93 | apply_defaults
+89 | # airflow.utils.decorators
+90 | apply_defaults
    | ^^^^^^^^^^^^^^
-94 |
-95 | # airflow.utils.file
+91 |
+92 | # airflow.utils.file
    |
 help: `apply_defaults` is now unconditionally done and can be safely removed.
 
 AIR301 `airflow.utils.file.mkdirs` is removed in Airflow 3.0
-  --> AIR301_names.py:96:1
+  --> AIR301_names.py:93:1
    |
-95 | # airflow.utils.file
-96 | mkdirs
+92 | # airflow.utils.file
+93 | mkdirs
    | ^^^^^^
    |
 help: Use `pathlib.Path({path}).mkdir` instead
 
 AIR301 `airflow.utils.state.SHUTDOWN` is removed in Airflow 3.0
-   --> AIR301_names.py:100:1
-    |
- 99 | # airflow.utils.state
-100 | SHUTDOWN
-    | ^^^^^^^^
-101 | terminating_states
-    |
+  --> AIR301_names.py:97:1
+   |
+96 | # airflow.utils.state
+97 | SHUTDOWN
+   | ^^^^^^^^
+98 | terminating_states
+   |
 
 AIR301 `airflow.utils.state.terminating_states` is removed in Airflow 3.0
-   --> AIR301_names.py:101:1
+   --> AIR301_names.py:98:1
     |
- 99 | # airflow.utils.state
-100 | SHUTDOWN
-101 | terminating_states
+ 96 | # airflow.utils.state
+ 97 | SHUTDOWN
+ 98 | terminating_states
     | ^^^^^^^^^^^^^^^^^^
-102 |
-103 | #  airflow.utils.trigger_rule
+ 99 |
+100 | #  airflow.utils.trigger_rule
     |
 
 AIR301 `airflow.utils.trigger_rule.TriggerRule.DUMMY` is removed in Airflow 3.0
-   --> AIR301_names.py:104:1
+   --> AIR301_names.py:101:1
     |
-103 | #  airflow.utils.trigger_rule
-104 | TriggerRule.DUMMY
+100 | #  airflow.utils.trigger_rule
+101 | TriggerRule.DUMMY
     | ^^^^^^^^^^^^^^^^^
-105 | TriggerRule.NONE_FAILED_OR_SKIPPED
+102 | TriggerRule.NONE_FAILED_OR_SKIPPED
     |
 
 AIR301 `airflow.utils.trigger_rule.TriggerRule.NONE_FAILED_OR_SKIPPED` is removed in Airflow 3.0
-   --> AIR301_names.py:105:1
+   --> AIR301_names.py:102:1
     |
-103 | #  airflow.utils.trigger_rule
-104 | TriggerRule.DUMMY
-105 | TriggerRule.NONE_FAILED_OR_SKIPPED
+100 | #  airflow.utils.trigger_rule
+101 | TriggerRule.DUMMY
+102 | TriggerRule.NONE_FAILED_OR_SKIPPED
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
 
 AIR301 `airflow.www.auth.has_access` is removed in Airflow 3.0
-   --> AIR301_names.py:109:1
+   --> AIR301_names.py:106:1
     |
-108 | # airflow.www.auth
-109 | has_access
+105 | # airflow.www.auth
+106 | has_access
     | ^^^^^^^^^^
-110 | has_access_dataset
+107 | has_access_dataset
     |
 
 AIR301 `airflow.www.auth.has_access_dataset` is removed in Airflow 3.0
-   --> AIR301_names.py:110:1
+   --> AIR301_names.py:107:1
     |
-108 | # airflow.www.auth
-109 | has_access
-110 | has_access_dataset
+105 | # airflow.www.auth
+106 | has_access
+107 | has_access_dataset
     | ^^^^^^^^^^^^^^^^^^
-111 |
-112 | # airflow.www.utils
+108 |
+109 | # airflow.www.utils
     |
 
 AIR301 `airflow.www.utils.get_sensitive_variables_fields` is removed in Airflow 3.0
-   --> AIR301_names.py:113:1
+   --> AIR301_names.py:110:1
     |
-112 | # airflow.www.utils
-113 | get_sensitive_variables_fields
+109 | # airflow.www.utils
+110 | get_sensitive_variables_fields
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-114 | should_hide_value_for_key
+111 | should_hide_value_for_key
     |
 
 AIR301 `airflow.www.utils.should_hide_value_for_key` is removed in Airflow 3.0
-   --> AIR301_names.py:114:1
+   --> AIR301_names.py:111:1
     |
-112 | # airflow.www.utils
-113 | get_sensitive_variables_fields
-114 | should_hide_value_for_key
+109 | # airflow.www.utils
+110 | get_sensitive_variables_fields
+111 | should_hide_value_for_key
     | ^^^^^^^^^^^^^^^^^^^^^^^^^
     |

crates/ruff_linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR301_AIR301_provider_names_fix.py.snap

@@ -12,14 +12,16 @@ AIR301 [*] `airflow.providers.amazon.aws.auth_manager.avp.entities.AvpEntities.D
 13 | # airflow.providers.openlineage.utils.utils
    |
 help: Use `AvpEntities.ASSET` from `airflow.providers.amazon.aws.auth_manager.avp.entities` instead.
-8  | from airflow.secrets.local_filesystem import load_connections
-9  | from airflow.security.permissions import RESOURCE_DATASET
-10 | 
-   - AvpEntities.DATASET
-11 + AvpEntities
-12 | 
-13 | # airflow.providers.openlineage.utils.utils
-14 | DatasetInfo()
+
+ℹ Safe fix
+8  8  | from airflow.secrets.local_filesystem import load_connections
+9  9  | from airflow.security.permissions import RESOURCE_DATASET
+10 10 | 
+11    |-AvpEntities.DATASET
+   11 |+AvpEntities
+12 12 | 
+13 13 | # airflow.providers.openlineage.utils.utils
+14 14 | DatasetInfo()
 
 AIR301 [*] `airflow.providers.openlineage.utils.utils.DatasetInfo` is removed in Airflow 3.0
   --> AIR301_provider_names_fix.py:14:1
@@ -30,22 +32,24 @@ AIR301 [*] `airflow.providers.openlineage.utils.utils.DatasetInfo` is removed in
 15 | translate_airflow_dataset()
    |
 help: Use `AssetInfo` from `airflow.providers.openlineage.utils.utils` instead.
-4  | from airflow.providers.openlineage.utils.utils import (
-5  |     DatasetInfo,
-6  |     translate_airflow_dataset,
-7  + AssetInfo,
-8  | )
-9  | from airflow.secrets.local_filesystem import load_connections
-10 | from airflow.security.permissions import RESOURCE_DATASET
+
+ℹ Safe fix
+4  4  | from airflow.providers.openlineage.utils.utils import (
+5  5  |     DatasetInfo,
+6  6  |     translate_airflow_dataset,
+   7  |+AssetInfo,
+7  8  | )
+8  9  | from airflow.secrets.local_filesystem import load_connections
+9  10 | from airflow.security.permissions import RESOURCE_DATASET
 --------------------------------------------------------------------------------
-12 | AvpEntities.DATASET
-13 | 
-14 | # airflow.providers.openlineage.utils.utils
-   - DatasetInfo()
-15 + AssetInfo()
-16 | translate_airflow_dataset()
-17 | 
-18 | # airflow.secrets.local_filesystem
+11 12 | AvpEntities.DATASET
+12 13 | 
+13 14 | # airflow.providers.openlineage.utils.utils
+14    |-DatasetInfo()
+   15 |+AssetInfo()
+15 16 | translate_airflow_dataset()
+16 17 | 
+17 18 | # airflow.secrets.local_filesystem
 
 AIR301 [*] `airflow.providers.openlineage.utils.utils.translate_airflow_dataset` is removed in Airflow 3.0
   --> AIR301_provider_names_fix.py:15:1
@@ -58,22 +62,24 @@ AIR301 [*] `airflow.providers.openlineage.utils.utils.translate_airflow_dataset`
 17 | # airflow.secrets.local_filesystem
    |
 help: Use `translate_airflow_asset` from `airflow.providers.openlineage.utils.utils` instead.
-4  | from airflow.providers.openlineage.utils.utils import (
-5  |     DatasetInfo,
-6  |     translate_airflow_dataset,
-7  + translate_airflow_asset,
-8  | )
-9  | from airflow.secrets.local_filesystem import load_connections
-10 | from airflow.security.permissions import RESOURCE_DATASET
+
+ℹ Safe fix
+4  4  | from airflow.providers.openlineage.utils.utils import (
+5  5  |     DatasetInfo,
+6  6  |     translate_airflow_dataset,
+   7  |+translate_airflow_asset,
+7  8  | )
+8  9  | from airflow.secrets.local_filesystem import load_connections
+9  10 | from airflow.security.permissions import RESOURCE_DATASET
 --------------------------------------------------------------------------------
-13 | 
-14 | # airflow.providers.openlineage.utils.utils
-15 | DatasetInfo()
-   - translate_airflow_dataset()
-16 + translate_airflow_asset()
-17 | 
-18 | # airflow.secrets.local_filesystem
-19 | load_connections()
+12 13 | 
+13 14 | # airflow.providers.openlineage.utils.utils
+14 15 | DatasetInfo()
+15    |-translate_airflow_dataset()
+   16 |+translate_airflow_asset()
+16 17 | 
+17 18 | # airflow.secrets.local_filesystem
+18 19 | load_connections()
 
 AIR301 [*] `airflow.secrets.local_filesystem.load_connections` is removed in Airflow 3.0
   --> AIR301_provider_names_fix.py:18:1
@@ -85,23 +91,25 @@ AIR301 [*] `airflow.secrets.local_filesystem.load_connections` is removed in Air
 20 | # airflow.security.permissions
    |
 help: Use `load_connections_dict` from `airflow.secrets.local_filesystem` instead.
-5  |     DatasetInfo,
-6  |     translate_airflow_dataset,
-7  | )
-   - from airflow.secrets.local_filesystem import load_connections
-8  + from airflow.secrets.local_filesystem import load_connections, load_connections_dict
-9  | from airflow.security.permissions import RESOURCE_DATASET
-10 | 
-11 | AvpEntities.DATASET
+
+ℹ Safe fix
+5  5  |     DatasetInfo,
+6  6  |     translate_airflow_dataset,
+7  7  | )
+8     |-from airflow.secrets.local_filesystem import load_connections
+   8  |+from airflow.secrets.local_filesystem import load_connections, load_connections_dict
+9  9  | from airflow.security.permissions import RESOURCE_DATASET
+10 10 | 
+11 11 | AvpEntities.DATASET
 --------------------------------------------------------------------------------
-15 | translate_airflow_dataset()
-16 | 
-17 | # airflow.secrets.local_filesystem
-   - load_connections()
-18 + load_connections_dict()
-19 | 
-20 | # airflow.security.permissions
-21 | RESOURCE_DATASET
+15 15 | translate_airflow_dataset()
+16 16 | 
+17 17 | # airflow.secrets.local_filesystem
+18    |-load_connections()
+   18 |+load_connections_dict()
+19 19 | 
+20 20 | # airflow.security.permissions
+21 21 | RESOURCE_DATASET
 
 AIR301 [*] `airflow.security.permissions.RESOURCE_DATASET` is removed in Airflow 3.0
   --> AIR301_provider_names_fix.py:21:1
@@ -113,23 +121,25 @@ AIR301 [*] `airflow.security.permissions.RESOURCE_DATASET` is removed in Airflow
 23 | from airflow.providers.amazon.aws.datasets.s3 import (
    |
 help: Use `RESOURCE_ASSET` from `airflow.security.permissions` instead.
-6  |     translate_airflow_dataset,
-7  | )
-8  | from airflow.secrets.local_filesystem import load_connections
-   - from airflow.security.permissions import RESOURCE_DATASET
-9  + from airflow.security.permissions import RESOURCE_DATASET, RESOURCE_ASSET
-10 | 
-11 | AvpEntities.DATASET
-12 | 
+
+ℹ Safe fix
+6  6  |     translate_airflow_dataset,
+7  7  | )
+8  8  | from airflow.secrets.local_filesystem import load_connections
+9     |-from airflow.security.permissions import RESOURCE_DATASET
+   9  |+from airflow.security.permissions import RESOURCE_DATASET, RESOURCE_ASSET
+10 10 | 
+11 11 | AvpEntities.DATASET
+12 12 | 
 --------------------------------------------------------------------------------
-18 | load_connections()
-19 | 
-20 | # airflow.security.permissions
-   - RESOURCE_DATASET
-21 + RESOURCE_ASSET
-22 | 
-23 | from airflow.providers.amazon.aws.datasets.s3 import (
-24 |     convert_dataset_to_openlineage as s3_convert_dataset_to_openlineage,
+18 18 | load_connections()
+19 19 | 
+20 20 | # airflow.security.permissions
+21    |-RESOURCE_DATASET
+   21 |+RESOURCE_ASSET
+22 22 | 
+23 23 | from airflow.providers.amazon.aws.datasets.s3 import (
+24 24 |     convert_dataset_to_openlineage as s3_convert_dataset_to_openlineage,
 
 AIR301 [*] `airflow.providers.amazon.aws.datasets.s3.create_dataset` is removed in Airflow 3.0
   --> AIR301_provider_names_fix.py:28:1
@@ -141,16 +151,18 @@ AIR301 [*] `airflow.providers.amazon.aws.datasets.s3.create_dataset` is removed
 29 | s3_convert_dataset_to_openlineage()
    |
 help: Use `create_asset` from `airflow.providers.amazon.aws.assets.s3` instead.
-24 |     convert_dataset_to_openlineage as s3_convert_dataset_to_openlineage,
-25 | )
-26 | from airflow.providers.amazon.aws.datasets.s3 import create_dataset as s3_create_dataset
-27 + from airflow.providers.amazon.aws.assets.s3 import create_asset
-28 | 
-   - s3_create_dataset()
-29 + create_asset()
-30 | s3_convert_dataset_to_openlineage()
-31 | 
-32 | from airflow.providers.common.io.dataset.file import (
+
+ℹ Safe fix
+24 24 |     convert_dataset_to_openlineage as s3_convert_dataset_to_openlineage,
+25 25 | )
+26 26 | from airflow.providers.amazon.aws.datasets.s3 import create_dataset as s3_create_dataset
+   27 |+from airflow.providers.amazon.aws.assets.s3 import create_asset
+27 28 | 
+28    |-s3_create_dataset()
+   29 |+create_asset()
+29 30 | s3_convert_dataset_to_openlineage()
+30 31 | 
+31 32 | from airflow.providers.common.io.dataset.file import (
 
 AIR301 [*] `airflow.providers.amazon.aws.datasets.s3.convert_dataset_to_openlineage` is removed in Airflow 3.0
   --> AIR301_provider_names_fix.py:29:1
@@ -162,17 +174,19 @@ AIR301 [*] `airflow.providers.amazon.aws.datasets.s3.convert_dataset_to_openline
 31 | from airflow.providers.common.io.dataset.file import (
    |
 help: Use `convert_asset_to_openlineage` from `airflow.providers.amazon.aws.assets.s3` instead.
-24 |     convert_dataset_to_openlineage as s3_convert_dataset_to_openlineage,
-25 | )
-26 | from airflow.providers.amazon.aws.datasets.s3 import create_dataset as s3_create_dataset
-27 + from airflow.providers.amazon.aws.assets.s3 import convert_asset_to_openlineage
-28 | 
-29 | s3_create_dataset()
-   - s3_convert_dataset_to_openlineage()
-30 + convert_asset_to_openlineage()
-31 | 
-32 | from airflow.providers.common.io.dataset.file import (
-33 |     convert_dataset_to_openlineage as io_convert_dataset_to_openlineage,
+
+ℹ Safe fix
+24 24 |     convert_dataset_to_openlineage as s3_convert_dataset_to_openlineage,
+25 25 | )
+26 26 | from airflow.providers.amazon.aws.datasets.s3 import create_dataset as s3_create_dataset
+   27 |+from airflow.providers.amazon.aws.assets.s3 import convert_asset_to_openlineage
+27 28 | 
+28 29 | s3_create_dataset()
+29    |-s3_convert_dataset_to_openlineage()
+   30 |+convert_asset_to_openlineage()
+30 31 | 
+31 32 | from airflow.providers.common.io.dataset.file import (
+32 33 |     convert_dataset_to_openlineage as io_convert_dataset_to_openlineage,
 
 AIR301 [*] `airflow.providers.google.datasets.bigquery.create_dataset` is removed in Airflow 3.0
   --> AIR301_provider_names_fix.py:45:1
@@ -185,16 +199,18 @@ AIR301 [*] `airflow.providers.google.datasets.bigquery.create_dataset` is remove
 47 | # airflow.providers.google.datasets.gcs
    |
 help: Use `create_asset` from `airflow.providers.google.assets.bigquery` instead.
-41 | from airflow.providers.google.datasets.bigquery import (
-42 |     create_dataset as bigquery_create_dataset,
-43 | )
-44 + from airflow.providers.google.assets.bigquery import create_asset
-45 | 
-   - bigquery_create_dataset()
-46 + create_asset()
-47 | 
-48 | # airflow.providers.google.datasets.gcs
-49 | from airflow.providers.google.datasets.gcs import (
+
+ℹ Safe fix
+41 41 | from airflow.providers.google.datasets.bigquery import (
+42 42 |     create_dataset as bigquery_create_dataset,
+43 43 | )
+   44 |+from airflow.providers.google.assets.bigquery import create_asset
+44 45 | 
+45    |-bigquery_create_dataset()
+   46 |+create_asset()
+46 47 | 
+47 48 | # airflow.providers.google.datasets.gcs
+48 49 | from airflow.providers.google.datasets.gcs import (
 
 AIR301 [*] `airflow.providers.google.datasets.gcs.create_dataset` is removed in Airflow 3.0
   --> AIR301_provider_names_fix.py:53:1
@@ -206,14 +222,16 @@ AIR301 [*] `airflow.providers.google.datasets.gcs.create_dataset` is removed in
 54 | gcs_convert_dataset_to_openlineage()
    |
 help: Use `create_asset` from `airflow.providers.google.assets.gcs` instead.
-49 |     convert_dataset_to_openlineage as gcs_convert_dataset_to_openlineage,
-50 | )
-51 | from airflow.providers.google.datasets.gcs import create_dataset as gcs_create_dataset
-52 + from airflow.providers.google.assets.gcs import create_asset
-53 | 
-   - gcs_create_dataset()
-54 + create_asset()
-55 | gcs_convert_dataset_to_openlineage()
+
+ℹ Safe fix
+49 49 |     convert_dataset_to_openlineage as gcs_convert_dataset_to_openlineage,
+50 50 | )
+51 51 | from airflow.providers.google.datasets.gcs import create_dataset as gcs_create_dataset
+   52 |+from airflow.providers.google.assets.gcs import create_asset
+52 53 | 
+53    |-gcs_create_dataset()
+   54 |+create_asset()
+54 55 | gcs_convert_dataset_to_openlineage()
 
 AIR301 [*] `airflow.providers.google.datasets.gcs.convert_dataset_to_openlineage` is removed in Airflow 3.0
   --> AIR301_provider_names_fix.py:54:1
@@ -223,11 +241,13 @@ AIR301 [*] `airflow.providers.google.datasets.gcs.convert_dataset_to_openlineage
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
 help: Use `convert_asset_to_openlineage` from `airflow.providers.google.assets.gcs` instead.
-49 |     convert_dataset_to_openlineage as gcs_convert_dataset_to_openlineage,
-50 | )
-51 | from airflow.providers.google.datasets.gcs import create_dataset as gcs_create_dataset
-52 + from airflow.providers.google.assets.gcs import convert_asset_to_openlineage
-53 | 
-54 | gcs_create_dataset()
-   - gcs_convert_dataset_to_openlineage()
-55 + convert_asset_to_openlineage()
+
+ℹ Safe fix
+49 49 |     convert_dataset_to_openlineage as gcs_convert_dataset_to_openlineage,
+50 50 | )
+51 51 | from airflow.providers.google.datasets.gcs import create_dataset as gcs_create_dataset
+   52 |+from airflow.providers.google.assets.gcs import convert_asset_to_openlineage
+52 53 | 
+53 54 | gcs_create_dataset()
+54    |-gcs_convert_dataset_to_openlineage()
+   55 |+convert_asset_to_openlineage()

crates/ruff_linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR302_AIR302_amazon.py.snap

@@ -11,22 +11,23 @@ AIR302 [*] `airflow.hooks.S3_hook.S3Hook` is moved into `amazon` provider in Air
 15 | provide_bucket_name()
    |
 help: Install `apache-airflow-providers-amazon>=1.0.0` and use `S3Hook` from `airflow.providers.amazon.aws.hooks.s3` instead.
-1  | from __future__ import annotations
-2  | 
-3  | from airflow.hooks.S3_hook import (
-   -     S3Hook,
-4  |     provide_bucket_name,
-5  | )
-6  | from airflow.operators.gcs_to_s3 import GCSToS3Operator
+
+ℹ Unsafe fix
+1  1  | from __future__ import annotations
+2  2  | 
+3  3  | from airflow.hooks.S3_hook import (
+4     |-    S3Hook,
+5  4  |     provide_bucket_name,
+6  5  | )
+7  6  | from airflow.operators.gcs_to_s3 import GCSToS3Operator
 --------------------------------------------------------------------------------
-9  | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
-10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
-11 | from airflow.sensors.s3_key_sensor import S3KeySensor
-12 + from airflow.providers.amazon.aws.hooks.s3 import S3Hook
-13 | 
-14 | S3Hook()
-15 | provide_bucket_name()
-note: This is an unsafe fix and may change runtime behavior
+10 9  | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
+11 10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
+12 11 | from airflow.sensors.s3_key_sensor import S3KeySensor
+   12 |+from airflow.providers.amazon.aws.hooks.s3 import S3Hook
+13 13 | 
+14 14 | S3Hook()
+15 15 | provide_bucket_name()
 
 AIR302 [*] `airflow.hooks.S3_hook.provide_bucket_name` is moved into `amazon` provider in Airflow 3.0;
   --> AIR302_amazon.py:15:1
@@ -38,22 +39,23 @@ AIR302 [*] `airflow.hooks.S3_hook.provide_bucket_name` is moved into `amazon` pr
 17 | GCSToS3Operator()
    |
 help: Install `apache-airflow-providers-amazon>=1.0.0` and use `provide_bucket_name` from `airflow.providers.amazon.aws.hooks.s3` instead.
-2  | 
-3  | from airflow.hooks.S3_hook import (
-4  |     S3Hook,
-   -     provide_bucket_name,
-5  | )
-6  | from airflow.operators.gcs_to_s3 import GCSToS3Operator
-7  | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
+
+ℹ Unsafe fix
+2  2  | 
+3  3  | from airflow.hooks.S3_hook import (
+4  4  |     S3Hook,
+5     |-    provide_bucket_name,
+6  5  | )
+7  6  | from airflow.operators.gcs_to_s3 import GCSToS3Operator
+8  7  | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
 --------------------------------------------------------------------------------
-9  | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
-10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
-11 | from airflow.sensors.s3_key_sensor import S3KeySensor
-12 + from airflow.providers.amazon.aws.hooks.s3 import provide_bucket_name
-13 | 
-14 | S3Hook()
-15 | provide_bucket_name()
-note: This is an unsafe fix and may change runtime behavior
+10 9  | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
+11 10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
+12 11 | from airflow.sensors.s3_key_sensor import S3KeySensor
+   12 |+from airflow.providers.amazon.aws.hooks.s3 import provide_bucket_name
+13 13 | 
+14 14 | S3Hook()
+15 15 | provide_bucket_name()
 
 AIR302 [*] `airflow.operators.gcs_to_s3.GCSToS3Operator` is moved into `amazon` provider in Airflow 3.0;
   --> AIR302_amazon.py:17:1
@@ -66,20 +68,21 @@ AIR302 [*] `airflow.operators.gcs_to_s3.GCSToS3Operator` is moved into `amazon`
 19 | RedshiftToS3Operator()
    |
 help: Install `apache-airflow-providers-amazon>=1.0.0` and use `GCSToS3Operator` from `airflow.providers.amazon.aws.transfers.gcs_to_s3` instead.
-4  |     S3Hook,
-5  |     provide_bucket_name,
-6  | )
-   - from airflow.operators.gcs_to_s3 import GCSToS3Operator
-7  | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
-8  | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
-9  | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
-10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
-11 | from airflow.sensors.s3_key_sensor import S3KeySensor
-12 + from airflow.providers.amazon.aws.transfers.gcs_to_s3 import GCSToS3Operator
-13 | 
-14 | S3Hook()
-15 | provide_bucket_name()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+4  4  |     S3Hook,
+5  5  |     provide_bucket_name,
+6  6  | )
+7     |-from airflow.operators.gcs_to_s3 import GCSToS3Operator
+8  7  | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
+9  8  | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
+10 9  | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
+11 10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
+12 11 | from airflow.sensors.s3_key_sensor import S3KeySensor
+   12 |+from airflow.providers.amazon.aws.transfers.gcs_to_s3 import GCSToS3Operator
+13 13 | 
+14 14 | S3Hook()
+15 15 | provide_bucket_name()
 
 AIR302 [*] `airflow.operators.google_api_to_s3_transfer.GoogleApiToS3Operator` is moved into `amazon` provider in Airflow 3.0;
   --> AIR302_amazon.py:18:1
@@ -91,19 +94,20 @@ AIR302 [*] `airflow.operators.google_api_to_s3_transfer.GoogleApiToS3Operator` i
 20 | S3FileTransformOperator()
    |
 help: Install `apache-airflow-providers-amazon>=1.0.0` and use `GoogleApiToS3Operator` from `airflow.providers.amazon.aws.transfers.google_api_to_s3` instead.
-5  |     provide_bucket_name,
-6  | )
-7  | from airflow.operators.gcs_to_s3 import GCSToS3Operator
-   - from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
-8  | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
-9  | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
-10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
-11 | from airflow.sensors.s3_key_sensor import S3KeySensor
-12 + from airflow.providers.amazon.aws.transfers.google_api_to_s3 import GoogleApiToS3Operator
-13 | 
-14 | S3Hook()
-15 | provide_bucket_name()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+5  5  |     provide_bucket_name,
+6  6  | )
+7  7  | from airflow.operators.gcs_to_s3 import GCSToS3Operator
+8     |-from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
+9  8  | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
+10 9  | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
+11 10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
+12 11 | from airflow.sensors.s3_key_sensor import S3KeySensor
+   12 |+from airflow.providers.amazon.aws.transfers.google_api_to_s3 import GoogleApiToS3Operator
+13 13 | 
+14 14 | S3Hook()
+15 15 | provide_bucket_name()
 
 AIR302 [*] `airflow.operators.redshift_to_s3_operator.RedshiftToS3Operator` is moved into `amazon` provider in Airflow 3.0;
   --> AIR302_amazon.py:19:1
@@ -116,18 +120,19 @@ AIR302 [*] `airflow.operators.redshift_to_s3_operator.RedshiftToS3Operator` is m
 21 | S3ToRedshiftOperator()
    |
 help: Install `apache-airflow-providers-amazon>=1.0.0` and use `RedshiftToS3Operator` from `airflow.providers.amazon.aws.transfers.redshift_to_s3` instead.
-6  | )
-7  | from airflow.operators.gcs_to_s3 import GCSToS3Operator
-8  | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
-   - from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
-9  | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
-10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
-11 | from airflow.sensors.s3_key_sensor import S3KeySensor
-12 + from airflow.providers.amazon.aws.transfers.redshift_to_s3 import RedshiftToS3Operator
-13 | 
-14 | S3Hook()
-15 | provide_bucket_name()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+6  6  | )
+7  7  | from airflow.operators.gcs_to_s3 import GCSToS3Operator
+8  8  | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
+9     |-from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
+10 9  | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
+11 10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
+12 11 | from airflow.sensors.s3_key_sensor import S3KeySensor
+   12 |+from airflow.providers.amazon.aws.transfers.redshift_to_s3 import RedshiftToS3Operator
+13 13 | 
+14 14 | S3Hook()
+15 15 | provide_bucket_name()
 
 AIR302 [*] `airflow.operators.s3_file_transform_operator.S3FileTransformOperator` is moved into `amazon` provider in Airflow 3.0;
   --> AIR302_amazon.py:20:1
@@ -140,17 +145,18 @@ AIR302 [*] `airflow.operators.s3_file_transform_operator.S3FileTransformOperator
 22 | S3KeySensor()
    |
 help: Install `apache-airflow-providers-amazon>=3.0.0` and use `S3FileTransformOperator` from `airflow.providers.amazon.aws.operators.s3` instead.
-7  | from airflow.operators.gcs_to_s3 import GCSToS3Operator
-8  | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
-9  | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
-   - from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
-10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
-11 | from airflow.sensors.s3_key_sensor import S3KeySensor
-12 + from airflow.providers.amazon.aws.operators.s3 import S3FileTransformOperator
-13 | 
-14 | S3Hook()
-15 | provide_bucket_name()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+7  7  | from airflow.operators.gcs_to_s3 import GCSToS3Operator
+8  8  | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
+9  9  | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
+10    |-from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
+11 10 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
+12 11 | from airflow.sensors.s3_key_sensor import S3KeySensor
+   12 |+from airflow.providers.amazon.aws.operators.s3 import S3FileTransformOperator
+13 13 | 
+14 14 | S3Hook()
+15 15 | provide_bucket_name()
 
 AIR302 [*] `airflow.operators.s3_to_redshift_operator.S3ToRedshiftOperator` is moved into `amazon` provider in Airflow 3.0;
   --> AIR302_amazon.py:21:1
@@ -162,16 +168,17 @@ AIR302 [*] `airflow.operators.s3_to_redshift_operator.S3ToRedshiftOperator` is m
 22 | S3KeySensor()
    |
 help: Install `apache-airflow-providers-amazon>=1.0.0` and use `S3ToRedshiftOperator` from `airflow.providers.amazon.aws.transfers.s3_to_redshift` instead.
-8  | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
-9  | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
-10 | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
-   - from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
-11 | from airflow.sensors.s3_key_sensor import S3KeySensor
-12 + from airflow.providers.amazon.aws.transfers.s3_to_redshift import S3ToRedshiftOperator
-13 | 
-14 | S3Hook()
-15 | provide_bucket_name()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+8  8  | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Operator
+9  9  | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
+10 10 | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
+11    |-from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
+12 11 | from airflow.sensors.s3_key_sensor import S3KeySensor
+   12 |+from airflow.providers.amazon.aws.transfers.s3_to_redshift import S3ToRedshiftOperator
+13 13 | 
+14 14 | S3Hook()
+15 15 | provide_bucket_name()
 
 AIR302 [*] `airflow.sensors.s3_key_sensor.S3KeySensor` is moved into `amazon` provider in Airflow 3.0;
   --> AIR302_amazon.py:22:1
@@ -184,15 +191,16 @@ AIR302 [*] `airflow.sensors.s3_key_sensor.S3KeySensor` is moved into `amazon` pr
 24 | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Transfer
    |
 help: Install `apache-airflow-providers-amazon>=1.0.0` and use `S3KeySensor` from `airflow.providers.amazon.aws.sensors.s3` instead.
-9  | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
-10 | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
-11 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
-   - from airflow.sensors.s3_key_sensor import S3KeySensor
-12 + from airflow.providers.amazon.aws.sensors.s3 import S3KeySensor
-13 | 
-14 | S3Hook()
-15 | provide_bucket_name()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+9  9  | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Operator
+10 10 | from airflow.operators.s3_file_transform_operator import S3FileTransformOperator
+11 11 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftOperator
+12    |-from airflow.sensors.s3_key_sensor import S3KeySensor
+   12 |+from airflow.providers.amazon.aws.sensors.s3 import S3KeySensor
+13 13 | 
+14 14 | S3Hook()
+15 15 | provide_bucket_name()
 
 AIR302 [*] `airflow.operators.google_api_to_s3_transfer.GoogleApiToS3Transfer` is moved into `amazon` provider in Airflow 3.0;
   --> AIR302_amazon.py:26:1
@@ -205,14 +213,15 @@ AIR302 [*] `airflow.operators.google_api_to_s3_transfer.GoogleApiToS3Transfer` i
 28 | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Transfer
    |
 help: Install `apache-airflow-providers-amazon>=1.0.0` and use `GoogleApiToS3Operator` from `airflow.providers.amazon.aws.transfers.google_api_to_s3` instead.
-22 | S3KeySensor()
-23 | 
-24 | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Transfer
-25 + from airflow.providers.amazon.aws.transfers.google_api_to_s3 import GoogleApiToS3Operator
-26 | 
-27 | GoogleApiToS3Transfer()
-28 | 
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+22 22 | S3KeySensor()
+23 23 | 
+24 24 | from airflow.operators.google_api_to_s3_transfer import GoogleApiToS3Transfer
+   25 |+from airflow.providers.amazon.aws.transfers.google_api_to_s3 import GoogleApiToS3Operator
+25 26 | 
+26 27 | GoogleApiToS3Transfer()
+27 28 | 
 
 AIR302 [*] `airflow.operators.redshift_to_s3_operator.RedshiftToS3Transfer` is moved into `amazon` provider in Airflow 3.0;
   --> AIR302_amazon.py:30:1
@@ -225,14 +234,15 @@ AIR302 [*] `airflow.operators.redshift_to_s3_operator.RedshiftToS3Transfer` is m
 32 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftTransfer
    |
 help: Install `apache-airflow-providers-amazon>=1.0.0` and use `RedshiftToS3Operator` from `airflow.providers.amazon.aws.transfers.redshift_to_s3` instead.
-26 | GoogleApiToS3Transfer()
-27 | 
-28 | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Transfer
-29 + from airflow.providers.amazon.aws.transfers.redshift_to_s3 import RedshiftToS3Operator
-30 | 
-31 | RedshiftToS3Transfer()
-32 | 
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+26 26 | GoogleApiToS3Transfer()
+27 27 | 
+28 28 | from airflow.operators.redshift_to_s3_operator import RedshiftToS3Transfer
+   29 |+from airflow.providers.amazon.aws.transfers.redshift_to_s3 import RedshiftToS3Operator
+29 30 | 
+30 31 | RedshiftToS3Transfer()
+31 32 | 
 
 AIR302 [*] `airflow.operators.s3_to_redshift_operator.S3ToRedshiftTransfer` is moved into `amazon` provider in Airflow 3.0;
   --> AIR302_amazon.py:34:1
@@ -243,10 +253,11 @@ AIR302 [*] `airflow.operators.s3_to_redshift_operator.S3ToRedshiftTransfer` is m
    | ^^^^^^^^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-amazon>=1.0.0` and use `S3ToRedshiftOperator` from `airflow.providers.amazon.aws.transfers.s3_to_redshift` instead.
-30 | RedshiftToS3Transfer()
-31 | 
-32 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftTransfer
-33 + from airflow.providers.amazon.aws.transfers.s3_to_redshift import S3ToRedshiftOperator
-34 | 
-35 | S3ToRedshiftTransfer()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+30 30 | RedshiftToS3Transfer()
+31 31 | 
+32 32 | from airflow.operators.s3_to_redshift_operator import S3ToRedshiftTransfer
+   33 |+from airflow.providers.amazon.aws.transfers.s3_to_redshift import S3ToRedshiftOperator
+33 34 | 
+34 35 | S3ToRedshiftTransfer()

crates/ruff_linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR302_AIR302_celery.py.snap

@@ -12,18 +12,19 @@ AIR302 [*] `airflow.config_templates.default_celery.DEFAULT_CELERY_CONFIG` is mo
 11 | app
    |
 help: Install `apache-airflow-providers-celery>=3.3.0` and use `DEFAULT_CELERY_CONFIG` from `airflow.providers.celery.executors.default_celery` instead.
-1  | from __future__ import annotations
-2  | 
-   - from airflow.config_templates.default_celery import DEFAULT_CELERY_CONFIG
-3  | from airflow.executors.celery_executor import (
-4  |     CeleryExecutor,
-5  |     app,
-6  | )
-7  + from airflow.providers.celery.executors.default_celery import DEFAULT_CELERY_CONFIG
-8  | 
-9  | DEFAULT_CELERY_CONFIG
-10 | 
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+1 1 | from __future__ import annotations
+2 2 | 
+3   |-from airflow.config_templates.default_celery import DEFAULT_CELERY_CONFIG
+4 3 | from airflow.executors.celery_executor import (
+5 4 |     CeleryExecutor,
+6 5 |     app,
+7 6 | )
+  7 |+from airflow.providers.celery.executors.default_celery import DEFAULT_CELERY_CONFIG
+8 8 | 
+9 9 | DEFAULT_CELERY_CONFIG
+10 10 | 
 
 AIR302 [*] `airflow.executors.celery_executor.app` is moved into `celery` provider in Airflow 3.0;
   --> AIR302_celery.py:11:1
@@ -35,16 +36,17 @@ AIR302 [*] `airflow.executors.celery_executor.app` is moved into `celery` provid
 12 | CeleryExecutor()
    |
 help: Install `apache-airflow-providers-celery>=3.3.0` and use `app` from `airflow.providers.celery.executors.celery_executor_utils` instead.
-3  | from airflow.config_templates.default_celery import DEFAULT_CELERY_CONFIG
-4  | from airflow.executors.celery_executor import (
-5  |     CeleryExecutor,
-   -     app,
-6  | )
-7  + from airflow.providers.celery.executors.celery_executor_utils import app
-8  | 
-9  | DEFAULT_CELERY_CONFIG
-10 | 
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+3 3 | from airflow.config_templates.default_celery import DEFAULT_CELERY_CONFIG
+4 4 | from airflow.executors.celery_executor import (
+5 5 |     CeleryExecutor,
+6   |-    app,
+7 6 | )
+  7 |+from airflow.providers.celery.executors.celery_executor_utils import app
+8 8 | 
+9 9 | DEFAULT_CELERY_CONFIG
+10 10 | 
 
 AIR302 [*] `airflow.executors.celery_executor.CeleryExecutor` is moved into `celery` provider in Airflow 3.0;
   --> AIR302_celery.py:12:1
@@ -54,14 +56,15 @@ AIR302 [*] `airflow.executors.celery_executor.CeleryExecutor` is moved into `cel
    | ^^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-celery>=3.3.0` and use `CeleryExecutor` from `airflow.providers.celery.executors.celery_executor` instead.
-2  | 
-3  | from airflow.config_templates.default_celery import DEFAULT_CELERY_CONFIG
-4  | from airflow.executors.celery_executor import (
-   -     CeleryExecutor,
-5  |     app,
-6  | )
-7  + from airflow.providers.celery.executors.celery_executor import CeleryExecutor
-8  | 
-9  | DEFAULT_CELERY_CONFIG
-10 | 
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+2 2 | 
+3 3 | from airflow.config_templates.default_celery import DEFAULT_CELERY_CONFIG
+4 4 | from airflow.executors.celery_executor import (
+5   |-    CeleryExecutor,
+6 5 |     app,
+7 6 | )
+  7 |+from airflow.providers.celery.executors.celery_executor import CeleryExecutor
+8 8 | 
+9 9 | DEFAULT_CELERY_CONFIG
+10 10 |

crates/ruff_linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR302_AIR302_common_sql.py.snap

@@ -11,17 +11,18 @@ AIR302 [*] `airflow.hooks.dbapi.ConnectorProtocol` is moved into `common-sql` pr
 9 | DbApiHook()
   |
 help: Install `apache-airflow-providers-common-sql>=1.0.0` and use `ConnectorProtocol` from `airflow.providers.common.sql.hooks.sql` instead.
-1 | from __future__ import annotations
-2 | 
-3 | from airflow.hooks.dbapi import (
-  -     ConnectorProtocol,
-4 |     DbApiHook,
-5 | )
-6 + from airflow.providers.common.sql.hooks.sql import ConnectorProtocol
-7 | 
-8 | ConnectorProtocol()
-9 | DbApiHook()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+1 1 | from __future__ import annotations
+2 2 | 
+3 3 | from airflow.hooks.dbapi import (
+4   |-    ConnectorProtocol,
+5 4 |     DbApiHook,
+6 5 | )
+  6 |+from airflow.providers.common.sql.hooks.sql import ConnectorProtocol
+7 7 | 
+8 8 | ConnectorProtocol()
+9 9 | DbApiHook()
 
 AIR302 [*] `airflow.hooks.dbapi.DbApiHook` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:9:1
@@ -33,16 +34,17 @@ AIR302 [*] `airflow.hooks.dbapi.DbApiHook` is moved into `common-sql` provider i
 11 | from airflow.hooks.dbapi_hook import DbApiHook
    |
 help: Install `apache-airflow-providers-common-sql>=1.0.0` and use `DbApiHook` from `airflow.providers.common.sql.hooks.sql` instead.
-2 | 
-3 | from airflow.hooks.dbapi import (
-4 |     ConnectorProtocol,
-  -     DbApiHook,
-5 | )
-6 + from airflow.providers.common.sql.hooks.sql import DbApiHook
-7 | 
-8 | ConnectorProtocol()
-9 | DbApiHook()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+2 2 | 
+3 3 | from airflow.hooks.dbapi import (
+4 4 |     ConnectorProtocol,
+5   |-    DbApiHook,
+6 5 | )
+  6 |+from airflow.providers.common.sql.hooks.sql import DbApiHook
+7 7 | 
+8 8 | ConnectorProtocol()
+9 9 | DbApiHook()
 
 AIR302 [*] `airflow.hooks.dbapi_hook.DbApiHook` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:14:1
@@ -54,16 +56,17 @@ AIR302 [*] `airflow.hooks.dbapi_hook.DbApiHook` is moved into `common-sql` provi
 15 | SQLCheckOperator()
    |
 help: Install `apache-airflow-providers-common-sql>=1.0.0` and use `DbApiHook` from `airflow.providers.common.sql.hooks.sql` instead.
-8  | ConnectorProtocol()
-9  | DbApiHook()
-10 | 
-   - from airflow.hooks.dbapi_hook import DbApiHook
-11 | from airflow.operators.check_operator import SQLCheckOperator
-12 + from airflow.providers.common.sql.hooks.sql import DbApiHook
-13 | 
-14 | DbApiHook()
-15 | SQLCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+8  8  | ConnectorProtocol()
+9  9  | DbApiHook()
+10 10 | 
+11    |-from airflow.hooks.dbapi_hook import DbApiHook
+12 11 | from airflow.operators.check_operator import SQLCheckOperator
+   12 |+from airflow.providers.common.sql.hooks.sql import DbApiHook
+13 13 | 
+14 14 | DbApiHook()
+15 15 | SQLCheckOperator()
 
 AIR302 [*] `airflow.operators.check_operator.SQLCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:15:1
@@ -73,15 +76,16 @@ AIR302 [*] `airflow.operators.check_operator.SQLCheckOperator` is moved into `co
    | ^^^^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-9  | DbApiHook()
-10 | 
-11 | from airflow.hooks.dbapi_hook import DbApiHook
-   - from airflow.operators.check_operator import SQLCheckOperator
-12 + from airflow.providers.common.sql.operators.sql import SQLCheckOperator
-13 | 
-14 | DbApiHook()
-15 | SQLCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+9  9  | DbApiHook()
+10 10 | 
+11 11 | from airflow.hooks.dbapi_hook import DbApiHook
+12    |-from airflow.operators.check_operator import SQLCheckOperator
+   12 |+from airflow.providers.common.sql.operators.sql import SQLCheckOperator
+13 13 | 
+14 14 | DbApiHook()
+15 15 | SQLCheckOperator()
 
 AIR302 [*] `airflow.operators.sql.SQLCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:21:1
@@ -93,15 +97,16 @@ AIR302 [*] `airflow.operators.sql.SQLCheckOperator` is moved into `common-sql` p
 22 | CheckOperator()
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-16 | 
-17 | 
-18 | from airflow.operators.check_operator import CheckOperator
-   - from airflow.operators.sql import SQLCheckOperator
-19 + from airflow.providers.common.sql.operators.sql import SQLCheckOperator
-20 | 
-21 | SQLCheckOperator()
-22 | CheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+16 16 | 
+17 17 | 
+18 18 | from airflow.operators.check_operator import CheckOperator
+19    |-from airflow.operators.sql import SQLCheckOperator
+   19 |+from airflow.providers.common.sql.operators.sql import SQLCheckOperator
+20 20 | 
+21 21 | SQLCheckOperator()
+22 22 | CheckOperator()
 
 AIR302 [*] `airflow.operators.check_operator.CheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:22:1
@@ -111,14 +116,15 @@ AIR302 [*] `airflow.operators.check_operator.CheckOperator` is moved into `commo
    | ^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-17 | 
-18 | from airflow.operators.check_operator import CheckOperator
-19 | from airflow.operators.sql import SQLCheckOperator
-20 + from airflow.providers.common.sql.operators.sql import SQLCheckOperator
-21 | 
-22 | SQLCheckOperator()
-23 | CheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+17 17 | 
+18 18 | from airflow.operators.check_operator import CheckOperator
+19 19 | from airflow.operators.sql import SQLCheckOperator
+   20 |+from airflow.providers.common.sql.operators.sql import SQLCheckOperator
+20 21 | 
+21 22 | SQLCheckOperator()
+22 23 | CheckOperator()
 
 AIR302 [*] `airflow.operators.druid_check_operator.CheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:27:1
@@ -129,14 +135,15 @@ AIR302 [*] `airflow.operators.druid_check_operator.CheckOperator` is moved into
    | ^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-23 | 
-24 | 
-25 | from airflow.operators.druid_check_operator import CheckOperator
-26 + from airflow.providers.common.sql.operators.sql import SQLCheckOperator
-27 | 
-28 | CheckOperator()
-29 | 
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+23 23 | 
+24 24 | 
+25 25 | from airflow.operators.druid_check_operator import CheckOperator
+   26 |+from airflow.providers.common.sql.operators.sql import SQLCheckOperator
+26 27 | 
+27 28 | CheckOperator()
+28 29 | 
 
 AIR302 [*] `airflow.operators.presto_check_operator.CheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:32:1
@@ -147,14 +154,15 @@ AIR302 [*] `airflow.operators.presto_check_operator.CheckOperator` is moved into
    | ^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-28 | 
-29 | 
-30 | from airflow.operators.presto_check_operator import CheckOperator
-31 + from airflow.providers.common.sql.operators.sql import SQLCheckOperator
-32 | 
-33 | CheckOperator()
-34 | 
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+28 28 | 
+29 29 | 
+30 30 | from airflow.operators.presto_check_operator import CheckOperator
+   31 |+from airflow.providers.common.sql.operators.sql import SQLCheckOperator
+31 32 | 
+32 33 | CheckOperator()
+33 34 | 
 
 AIR302 [*] `airflow.operators.druid_check_operator.DruidCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:42:1
@@ -167,14 +175,15 @@ AIR302 [*] `airflow.operators.druid_check_operator.DruidCheckOperator` is moved
 44 | IntervalCheckOperator()
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-38 | )
-39 | from airflow.operators.druid_check_operator import DruidCheckOperator
-40 | from airflow.operators.presto_check_operator import PrestoCheckOperator
-41 + from airflow.providers.common.sql.operators.sql import SQLCheckOperator
-42 | 
-43 | DruidCheckOperator()
-44 | PrestoCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+38 38 | )
+39 39 | from airflow.operators.druid_check_operator import DruidCheckOperator
+40 40 | from airflow.operators.presto_check_operator import PrestoCheckOperator
+   41 |+from airflow.providers.common.sql.operators.sql import SQLCheckOperator
+41 42 | 
+42 43 | DruidCheckOperator()
+43 44 | PrestoCheckOperator()
 
 AIR302 [*] `airflow.operators.presto_check_operator.PrestoCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:43:1
@@ -186,14 +195,15 @@ AIR302 [*] `airflow.operators.presto_check_operator.PrestoCheckOperator` is move
 45 | SQLIntervalCheckOperator()
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-38 | )
-39 | from airflow.operators.druid_check_operator import DruidCheckOperator
-40 | from airflow.operators.presto_check_operator import PrestoCheckOperator
-41 + from airflow.providers.common.sql.operators.sql import SQLCheckOperator
-42 | 
-43 | DruidCheckOperator()
-44 | PrestoCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+38 38 | )
+39 39 | from airflow.operators.druid_check_operator import DruidCheckOperator
+40 40 | from airflow.operators.presto_check_operator import PrestoCheckOperator
+   41 |+from airflow.providers.common.sql.operators.sql import SQLCheckOperator
+41 42 | 
+42 43 | DruidCheckOperator()
+43 44 | PrestoCheckOperator()
 
 AIR302 [*] `airflow.operators.check_operator.IntervalCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:44:1
@@ -205,18 +215,19 @@ AIR302 [*] `airflow.operators.check_operator.IntervalCheckOperator` is moved int
 45 | SQLIntervalCheckOperator()
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLIntervalCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-34 | 
-35 | from airflow.operators.check_operator import (
-36 |     IntervalCheckOperator,
-   -     SQLIntervalCheckOperator,
-37 | )
-38 | from airflow.operators.druid_check_operator import DruidCheckOperator
-39 | from airflow.operators.presto_check_operator import PrestoCheckOperator
-40 + from airflow.providers.common.sql.operators.sql import SQLIntervalCheckOperator
-41 | 
-42 | DruidCheckOperator()
-43 | PrestoCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+34 34 | 
+35 35 | from airflow.operators.check_operator import (
+36 36 |     IntervalCheckOperator,
+37    |-    SQLIntervalCheckOperator,
+38 37 | )
+39 38 | from airflow.operators.druid_check_operator import DruidCheckOperator
+40 39 | from airflow.operators.presto_check_operator import PrestoCheckOperator
+   40 |+from airflow.providers.common.sql.operators.sql import SQLIntervalCheckOperator
+41 41 | 
+42 42 | DruidCheckOperator()
+43 43 | PrestoCheckOperator()
 
 AIR302 [*] `airflow.operators.check_operator.SQLIntervalCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:45:1
@@ -227,18 +238,19 @@ AIR302 [*] `airflow.operators.check_operator.SQLIntervalCheckOperator` is moved
    | ^^^^^^^^^^^^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLIntervalCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-34 | 
-35 | from airflow.operators.check_operator import (
-36 |     IntervalCheckOperator,
-   -     SQLIntervalCheckOperator,
-37 | )
-38 | from airflow.operators.druid_check_operator import DruidCheckOperator
-39 | from airflow.operators.presto_check_operator import PrestoCheckOperator
-40 + from airflow.providers.common.sql.operators.sql import SQLIntervalCheckOperator
-41 | 
-42 | DruidCheckOperator()
-43 | PrestoCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+34 34 | 
+35 35 | from airflow.operators.check_operator import (
+36 36 |     IntervalCheckOperator,
+37    |-    SQLIntervalCheckOperator,
+38 37 | )
+39 38 | from airflow.operators.druid_check_operator import DruidCheckOperator
+40 39 | from airflow.operators.presto_check_operator import PrestoCheckOperator
+   40 |+from airflow.providers.common.sql.operators.sql import SQLIntervalCheckOperator
+41 41 | 
+42 42 | DruidCheckOperator()
+43 43 | PrestoCheckOperator()
 
 AIR302 [*] `airflow.operators.presto_check_operator.IntervalCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:54:1
@@ -251,14 +263,15 @@ AIR302 [*] `airflow.operators.presto_check_operator.IntervalCheckOperator` is mo
 56 | PrestoIntervalCheckOperator()
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLIntervalCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-50 |     PrestoIntervalCheckOperator,
-51 | )
-52 | from airflow.operators.sql import SQLIntervalCheckOperator
-53 + from airflow.providers.common.sql.operators.sql import SQLIntervalCheckOperator
-54 | 
-55 | IntervalCheckOperator()
-56 | SQLIntervalCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+50 50 |     PrestoIntervalCheckOperator,
+51 51 | )
+52 52 | from airflow.operators.sql import SQLIntervalCheckOperator
+   53 |+from airflow.providers.common.sql.operators.sql import SQLIntervalCheckOperator
+53 54 | 
+54 55 | IntervalCheckOperator()
+55 56 | SQLIntervalCheckOperator()
 
 AIR302 [*] `airflow.operators.sql.SQLIntervalCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:55:1
@@ -269,15 +282,16 @@ AIR302 [*] `airflow.operators.sql.SQLIntervalCheckOperator` is moved into `commo
 56 | PrestoIntervalCheckOperator()
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLIntervalCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-49 |     IntervalCheckOperator,
-50 |     PrestoIntervalCheckOperator,
-51 | )
-   - from airflow.operators.sql import SQLIntervalCheckOperator
-52 + from airflow.providers.common.sql.operators.sql import SQLIntervalCheckOperator
-53 | 
-54 | IntervalCheckOperator()
-55 | SQLIntervalCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+49 49 |     IntervalCheckOperator,
+50 50 |     PrestoIntervalCheckOperator,
+51 51 | )
+52    |-from airflow.operators.sql import SQLIntervalCheckOperator
+   52 |+from airflow.providers.common.sql.operators.sql import SQLIntervalCheckOperator
+53 53 | 
+54 54 | IntervalCheckOperator()
+55 55 | SQLIntervalCheckOperator()
 
 AIR302 [*] `airflow.operators.presto_check_operator.PrestoIntervalCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:56:1
@@ -288,14 +302,15 @@ AIR302 [*] `airflow.operators.presto_check_operator.PrestoIntervalCheckOperator`
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLIntervalCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-50 |     PrestoIntervalCheckOperator,
-51 | )
-52 | from airflow.operators.sql import SQLIntervalCheckOperator
-53 + from airflow.providers.common.sql.operators.sql import SQLIntervalCheckOperator
-54 | 
-55 | IntervalCheckOperator()
-56 | SQLIntervalCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+50 50 |     PrestoIntervalCheckOperator,
+51 51 | )
+52 52 | from airflow.operators.sql import SQLIntervalCheckOperator
+   53 |+from airflow.providers.common.sql.operators.sql import SQLIntervalCheckOperator
+53 54 | 
+54 55 | IntervalCheckOperator()
+55 56 | SQLIntervalCheckOperator()
 
 AIR302 [*] `airflow.operators.check_operator.SQLThresholdCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:64:1
@@ -307,17 +322,18 @@ AIR302 [*] `airflow.operators.check_operator.SQLThresholdCheckOperator` is moved
 65 | ThresholdCheckOperator()
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLThresholdCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-57 | 
-58 | 
-59 | from airflow.operators.check_operator import (
-   -     SQLThresholdCheckOperator,
-60 |     ThresholdCheckOperator,
-61 | )
-62 + from airflow.providers.common.sql.operators.sql import SQLThresholdCheckOperator
-63 | 
-64 | SQLThresholdCheckOperator()
-65 | ThresholdCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+57 57 | 
+58 58 | 
+59 59 | from airflow.operators.check_operator import (
+60    |-    SQLThresholdCheckOperator,
+61 60 |     ThresholdCheckOperator,
+62 61 | )
+   62 |+from airflow.providers.common.sql.operators.sql import SQLThresholdCheckOperator
+63 63 | 
+64 64 | SQLThresholdCheckOperator()
+65 65 | ThresholdCheckOperator()
 
 AIR302 [*] `airflow.operators.check_operator.ThresholdCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:65:1
@@ -327,17 +343,18 @@ AIR302 [*] `airflow.operators.check_operator.ThresholdCheckOperator` is moved in
    | ^^^^^^^^^^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLThresholdCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-57 | 
-58 | 
-59 | from airflow.operators.check_operator import (
-   -     SQLThresholdCheckOperator,
-60 |     ThresholdCheckOperator,
-61 | )
-62 + from airflow.providers.common.sql.operators.sql import SQLThresholdCheckOperator
-63 | 
-64 | SQLThresholdCheckOperator()
-65 | ThresholdCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+57 57 | 
+58 58 | 
+59 59 | from airflow.operators.check_operator import (
+60    |-    SQLThresholdCheckOperator,
+61 60 |     ThresholdCheckOperator,
+62 61 | )
+   62 |+from airflow.providers.common.sql.operators.sql import SQLThresholdCheckOperator
+63 63 | 
+64 64 | SQLThresholdCheckOperator()
+65 65 | ThresholdCheckOperator()
 
 AIR302 [*] `airflow.operators.sql.SQLThresholdCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:70:1
@@ -348,15 +365,16 @@ AIR302 [*] `airflow.operators.sql.SQLThresholdCheckOperator` is moved into `comm
    | ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLThresholdCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-65 | ThresholdCheckOperator()
-66 | 
-67 | 
-   - from airflow.operators.sql import SQLThresholdCheckOperator
-68 + from airflow.providers.common.sql.operators.sql import SQLThresholdCheckOperator
-69 | 
-70 | SQLThresholdCheckOperator()
-71 | 
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+65 65 | ThresholdCheckOperator()
+66 66 | 
+67 67 | 
+68    |-from airflow.operators.sql import SQLThresholdCheckOperator
+   68 |+from airflow.providers.common.sql.operators.sql import SQLThresholdCheckOperator
+69 69 | 
+70 70 | SQLThresholdCheckOperator()
+71 71 | 
 
 AIR302 [*] `airflow.operators.check_operator.SQLValueCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:78:1
@@ -368,17 +386,18 @@ AIR302 [*] `airflow.operators.check_operator.SQLValueCheckOperator` is moved int
 79 | ValueCheckOperator()
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLValueCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-71 | 
-72 | 
-73 | from airflow.operators.check_operator import (
-   -     SQLValueCheckOperator,
-74 |     ValueCheckOperator,
-75 | )
-76 + from airflow.providers.common.sql.operators.sql import SQLValueCheckOperator
-77 | 
-78 | SQLValueCheckOperator()
-79 | ValueCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+71 71 | 
+72 72 | 
+73 73 | from airflow.operators.check_operator import (
+74    |-    SQLValueCheckOperator,
+75 74 |     ValueCheckOperator,
+76 75 | )
+   76 |+from airflow.providers.common.sql.operators.sql import SQLValueCheckOperator
+77 77 | 
+78 78 | SQLValueCheckOperator()
+79 79 | ValueCheckOperator()
 
 AIR302 [*] `airflow.operators.check_operator.ValueCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:79:1
@@ -388,17 +407,18 @@ AIR302 [*] `airflow.operators.check_operator.ValueCheckOperator` is moved into `
    | ^^^^^^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLValueCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-71 | 
-72 | 
-73 | from airflow.operators.check_operator import (
-   -     SQLValueCheckOperator,
-74 |     ValueCheckOperator,
-75 | )
-76 + from airflow.providers.common.sql.operators.sql import SQLValueCheckOperator
-77 | 
-78 | SQLValueCheckOperator()
-79 | ValueCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+71 71 | 
+72 72 | 
+73 73 | from airflow.operators.check_operator import (
+74    |-    SQLValueCheckOperator,
+75 74 |     ValueCheckOperator,
+76 75 | )
+   76 |+from airflow.providers.common.sql.operators.sql import SQLValueCheckOperator
+77 77 | 
+78 78 | SQLValueCheckOperator()
+79 79 | ValueCheckOperator()
 
 AIR302 [*] `airflow.operators.sql.SQLValueCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:88:1
@@ -411,15 +431,16 @@ AIR302 [*] `airflow.operators.sql.SQLValueCheckOperator` is moved into `common-s
 90 | PrestoValueCheckOperator()
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLValueCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-83 |     PrestoValueCheckOperator,
-84 |     ValueCheckOperator,
-85 | )
-   - from airflow.operators.sql import SQLValueCheckOperator
-86 + from airflow.providers.common.sql.operators.sql import SQLValueCheckOperator
-87 | 
-88 | SQLValueCheckOperator()
-89 | ValueCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+83 83 |     PrestoValueCheckOperator,
+84 84 |     ValueCheckOperator,
+85 85 | )
+86    |-from airflow.operators.sql import SQLValueCheckOperator
+   86 |+from airflow.providers.common.sql.operators.sql import SQLValueCheckOperator
+87 87 | 
+88 88 | SQLValueCheckOperator()
+89 89 | ValueCheckOperator()
 
 AIR302 [*] `airflow.operators.presto_check_operator.ValueCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:89:1
@@ -430,14 +451,15 @@ AIR302 [*] `airflow.operators.presto_check_operator.ValueCheckOperator` is moved
 90 | PrestoValueCheckOperator()
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLValueCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-84 |     ValueCheckOperator,
-85 | )
-86 | from airflow.operators.sql import SQLValueCheckOperator
-87 + from airflow.providers.common.sql.operators.sql import SQLValueCheckOperator
-88 | 
-89 | SQLValueCheckOperator()
-90 | ValueCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+84 84 |     ValueCheckOperator,
+85 85 | )
+86 86 | from airflow.operators.sql import SQLValueCheckOperator
+   87 |+from airflow.providers.common.sql.operators.sql import SQLValueCheckOperator
+87 88 | 
+88 89 | SQLValueCheckOperator()
+89 90 | ValueCheckOperator()
 
 AIR302 [*] `airflow.operators.presto_check_operator.PrestoValueCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
   --> AIR302_common_sql.py:90:1
@@ -448,14 +470,15 @@ AIR302 [*] `airflow.operators.presto_check_operator.PrestoValueCheckOperator` is
    | ^^^^^^^^^^^^^^^^^^^^^^^^
    |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLValueCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-84 |     ValueCheckOperator,
-85 | )
-86 | from airflow.operators.sql import SQLValueCheckOperator
-87 + from airflow.providers.common.sql.operators.sql import SQLValueCheckOperator
-88 | 
-89 | SQLValueCheckOperator()
-90 | ValueCheckOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+84 84 |     ValueCheckOperator,
+85 85 | )
+86 86 | from airflow.operators.sql import SQLValueCheckOperator
+   87 |+from airflow.providers.common.sql.operators.sql import SQLValueCheckOperator
+87 88 | 
+88 89 | SQLValueCheckOperator()
+89 90 | ValueCheckOperator()
 
 AIR302 [*] `airflow.operators.sql.BaseSQLOperator` is moved into `common-sql` provider in Airflow 3.0;
    --> AIR302_common_sql.py:102:1
@@ -468,21 +491,22 @@ AIR302 [*] `airflow.operators.sql.BaseSQLOperator` is moved into `common-sql` pr
 104 | SQLTableCheckOperator()
     |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `BaseSQLOperator` from `airflow.providers.common.sql.operators.sql` instead.
-91  | 
-92  | 
-93  | from airflow.operators.sql import (
-    -     BaseSQLOperator,
-94  |     BranchSQLOperator,
-95  |     SQLColumnCheckOperator,
-96  |     SQLTableCheckOperator,
-97  |     _convert_to_float_if_possible,
-98  |     parse_boolean,
-99  | )
-100 + from airflow.providers.common.sql.operators.sql import BaseSQLOperator
-101 | 
-102 | BaseSQLOperator()
-103 | BranchSQLOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+91  91  | 
+92  92  | 
+93  93  | from airflow.operators.sql import (
+94      |-    BaseSQLOperator,
+95  94  |     BranchSQLOperator,
+96  95  |     SQLColumnCheckOperator,
+97  96  |     SQLTableCheckOperator,
+98  97  |     _convert_to_float_if_possible,
+99  98  |     parse_boolean,
+100 99  | )
+    100 |+from airflow.providers.common.sql.operators.sql import BaseSQLOperator
+101 101 | 
+102 102 | BaseSQLOperator()
+103 103 | BranchSQLOperator()
 
 AIR302 [*] `airflow.operators.sql.BranchSQLOperator` is moved into `common-sql` provider in Airflow 3.0;
    --> AIR302_common_sql.py:103:1
@@ -494,20 +518,21 @@ AIR302 [*] `airflow.operators.sql.BranchSQLOperator` is moved into `common-sql`
 105 | SQLColumnCheckOperator()
     |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `BranchSQLOperator` from `airflow.providers.common.sql.operators.sql` instead.
-92  | 
-93  | from airflow.operators.sql import (
-94  |     BaseSQLOperator,
-    -     BranchSQLOperator,
-95  |     SQLColumnCheckOperator,
-96  |     SQLTableCheckOperator,
-97  |     _convert_to_float_if_possible,
-98  |     parse_boolean,
-99  | )
-100 + from airflow.providers.common.sql.operators.sql import BranchSQLOperator
-101 | 
-102 | BaseSQLOperator()
-103 | BranchSQLOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+92  92  | 
+93  93  | from airflow.operators.sql import (
+94  94  |     BaseSQLOperator,
+95      |-    BranchSQLOperator,
+96  95  |     SQLColumnCheckOperator,
+97  96  |     SQLTableCheckOperator,
+98  97  |     _convert_to_float_if_possible,
+99  98  |     parse_boolean,
+100 99  | )
+    100 |+from airflow.providers.common.sql.operators.sql import BranchSQLOperator
+101 101 | 
+102 102 | BaseSQLOperator()
+103 103 | BranchSQLOperator()
 
 AIR302 [*] `airflow.operators.sql.SQLTableCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
    --> AIR302_common_sql.py:104:1
@@ -520,18 +545,19 @@ AIR302 [*] `airflow.operators.sql.SQLTableCheckOperator` is moved into `common-s
 106 | _convert_to_float_if_possible()
     |
 help: Install `apache-airflow-providers-common-sql>=1.1.0` and use `SQLTableCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-94  |     BaseSQLOperator,
-95  |     BranchSQLOperator,
-96  |     SQLColumnCheckOperator,
-    -     SQLTableCheckOperator,
-97  |     _convert_to_float_if_possible,
-98  |     parse_boolean,
-99  | )
-100 + from airflow.providers.common.sql.operators.sql import SQLTableCheckOperator
-101 | 
-102 | BaseSQLOperator()
-103 | BranchSQLOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+94  94  |     BaseSQLOperator,
+95  95  |     BranchSQLOperator,
+96  96  |     SQLColumnCheckOperator,
+97      |-    SQLTableCheckOperator,
+98  97  |     _convert_to_float_if_possible,
+99  98  |     parse_boolean,
+100 99  | )
+    100 |+from airflow.providers.common.sql.operators.sql import SQLTableCheckOperator
+101 101 | 
+102 102 | BaseSQLOperator()
+103 103 | BranchSQLOperator()
 
 AIR302 [*] `airflow.operators.sql.SQLColumnCheckOperator` is moved into `common-sql` provider in Airflow 3.0;
    --> AIR302_common_sql.py:105:1
@@ -544,19 +570,20 @@ AIR302 [*] `airflow.operators.sql.SQLColumnCheckOperator` is moved into `common-
 107 | parse_boolean()
     |
 help: Install `apache-airflow-providers-common-sql>=1.0.0` and use `SQLColumnCheckOperator` from `airflow.providers.common.sql.operators.sql` instead.
-93  | from airflow.operators.sql import (
-94  |     BaseSQLOperator,
-95  |     BranchSQLOperator,
-    -     SQLColumnCheckOperator,
-96  |     SQLTableCheckOperator,
-97  |     _convert_to_float_if_possible,
-98  |     parse_boolean,
-99  | )
-100 + from airflow.providers.common.sql.operators.sql import SQLColumnCheckOperator
-101 | 
-102 | BaseSQLOperator()
-103 | BranchSQLOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+93  93  | from airflow.operators.sql import (
+94  94  |     BaseSQLOperator,
+95  95  |     BranchSQLOperator,
+96      |-    SQLColumnCheckOperator,
+97  96  |     SQLTableCheckOperator,
+98  97  |     _convert_to_float_if_possible,
+99  98  |     parse_boolean,
+100 99  | )
+    100 |+from airflow.providers.common.sql.operators.sql import SQLColumnCheckOperator
+101 101 | 
+102 102 | BaseSQLOperator()
+103 103 | BranchSQLOperator()
 
 AIR302 [*] `airflow.operators.sql._convert_to_float_if_possible` is moved into `common-sql` provider in Airflow 3.0;
    --> AIR302_common_sql.py:106:1
@@ -568,17 +595,18 @@ AIR302 [*] `airflow.operators.sql._convert_to_float_if_possible` is moved into `
 107 | parse_boolean()
     |
 help: Install `apache-airflow-providers-common-sql>=1.0.0` and use `_convert_to_float_if_possible` from `airflow.providers.common.sql.operators.sql` instead.
-95  |     BranchSQLOperator,
-96  |     SQLColumnCheckOperator,
-97  |     SQLTableCheckOperator,
-    -     _convert_to_float_if_possible,
-98  |     parse_boolean,
-99  | )
-100 + from airflow.providers.common.sql.operators.sql import _convert_to_float_if_possible
-101 | 
-102 | BaseSQLOperator()
-103 | BranchSQLOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+95  95  |     BranchSQLOperator,
+96  96  |     SQLColumnCheckOperator,
+97  97  |     SQLTableCheckOperator,
+98      |-    _convert_to_float_if_possible,
+99  98  |     parse_boolean,
+100 99  | )
+    100 |+from airflow.providers.common.sql.operators.sql import _convert_to_float_if_possible
+101 101 | 
+102 102 | BaseSQLOperator()
+103 103 | BranchSQLOperator()
 
 AIR302 [*] `airflow.operators.sql.parse_boolean` is moved into `common-sql` provider in Airflow 3.0;
    --> AIR302_common_sql.py:107:1
@@ -589,16 +617,17 @@ AIR302 [*] `airflow.operators.sql.parse_boolean` is moved into `common-sql` prov
     | ^^^^^^^^^^^^^
     |
 help: Install `apache-airflow-providers-common-sql>=1.0.0` and use `parse_boolean` from `airflow.providers.common.sql.operators.sql` instead.
-96  |     SQLColumnCheckOperator,
-97  |     SQLTableCheckOperator,
-98  |     _convert_to_float_if_possible,
-    -     parse_boolean,
-99  | )
-100 + from airflow.providers.common.sql.operators.sql import parse_boolean
-101 | 
-102 | BaseSQLOperator()
-103 | BranchSQLOperator()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+96  96  |     SQLColumnCheckOperator,
+97  97  |     SQLTableCheckOperator,
+98  98  |     _convert_to_float_if_possible,
+99      |-    parse_boolean,
+100 99  | )
+    100 |+from airflow.providers.common.sql.operators.sql import parse_boolean
+101 101 | 
+102 102 | BaseSQLOperator()
+103 103 | BranchSQLOperator()
 
 AIR302 [*] `airflow.sensors.sql.SqlSensor` is moved into `common-sql` provider in Airflow 3.0;
    --> AIR302_common_sql.py:112:1
@@ -609,15 +638,16 @@ AIR302 [*] `airflow.sensors.sql.SqlSensor` is moved into `common-sql` provider i
     | ^^^^^^^^^
     |
 help: Install `apache-airflow-providers-common-sql>=1.0.0` and use `SqlSensor` from `airflow.providers.common.sql.sensors.sql` instead.
-107 | parse_boolean()
-108 | 
-109 | 
-    - from airflow.sensors.sql import SqlSensor
-110 + from airflow.providers.common.sql.sensors.sql import SqlSensor
-111 | 
-112 | SqlSensor()
-113 | 
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+107 107 | parse_boolean()
+108 108 | 
+109 109 | 
+110     |-from airflow.sensors.sql import SqlSensor
+    110 |+from airflow.providers.common.sql.sensors.sql import SqlSensor
+111 111 | 
+112 112 | SqlSensor()
+113 113 | 
 
 AIR302 [*] `airflow.sensors.sql_sensor.SqlSensor` is moved into `common-sql` provider in Airflow 3.0;
    --> AIR302_common_sql.py:117:1
@@ -628,12 +658,13 @@ AIR302 [*] `airflow.sensors.sql_sensor.SqlSensor` is moved into `common-sql` pro
     | ^^^^^^^^^
     |
 help: Install `apache-airflow-providers-common-sql>=1.0.0` and use `SqlSensor` from `airflow.providers.common.sql.sensors.sql` instead.
-112 | SqlSensor()
-113 | 
-114 | 
-    - from airflow.sensors.sql_sensor import SqlSensor
-115 + from airflow.providers.common.sql.sensors.sql import SqlSensor
-116 | 
-117 | SqlSensor()
-118 | 
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+112 112 | SqlSensor()
+113 113 | 
+114 114 | 
+115     |-from airflow.sensors.sql_sensor import SqlSensor
+    115 |+from airflow.providers.common.sql.sensors.sql import SqlSensor
+116 116 | 
+117 117 | SqlSensor()
+118 118 |

crates/ruff_linter/src/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR302_AIR302_daskexecutor.py.snap

@@ -10,10 +10,11 @@ AIR302 [*] `airflow.executors.dask_executor.DaskExecutor` is moved into `daskexe
   | ^^^^^^^^^^^^
   |
 help: Install `apache-airflow-providers-daskexecutor>=1.0.0` and use `DaskExecutor` from `airflow.providers.daskexecutor.executors.dask_executor` instead.
-1 | from __future__ import annotations
-2 | 
-  - from airflow.executors.dask_executor import DaskExecutor
-3 + from airflow.providers.daskexecutor.executors.dask_executor import DaskExecutor
-4 | 
-5 | DaskExecutor()
-note: This is an unsafe fix and may change runtime behavior
+
+ℹ Unsafe fix
+1 1 | from __future__ import annotations
+2 2 | 
+3   |-from airflow.executors.dask_executor import DaskExecutor
+  3 |+from airflow.providers.daskexecutor.executors.dask_executor import DaskExecutor
+4 4 | 
+5 5 | DaskExecutor()