[red-knot] qualify function/class name with module/file

[red-knot] handle all syntax without panic (#12499 )
Extend red-knot type inference to cover all syntax, so that inferring types for a scope gives all expressions a type. This means we can run the red-knot semantic lint on all Python code without panics. It also means we can infer types for `builtins.pyi` without panics. To keep things simple, this PR intentionally doesn't add any new type inference capabilities: the expanded coverage is all achieved with `Type::Unknown`. But this puts the skeleton in place for adding better inference of all these language features. I also had to add basic Salsa cycle recovery (with just `Type::Unknown` for now), because some `builtins.pyi` definitions are cyclic. To test this, I added a comprehensive corpus of test snippets sourced from Cinder under [MIT license](https://github.com/facebookincubator/cinder/blob/cinder/3.10/cinderx/LICENSE), which matches Ruff's license. I also added to this corpus some additional snippets for newer language features: all the `27_func_generic_*` and `73_class_generic_*` files, as well as `20_lambda_default_arg.py`, and added a test which runs semantic-lint over all these files. (The test doesn't assert the test-corpus files are lint-free; just that they are able to lint without a panic.)
2024-07-25 22:18:23 -07:00 · 2024-07-25 17:38:08 -07:00 · 2024-07-25 17:46:58 -04:00 · 2024-07-25 19:28:48 +00:00 · 2024-07-25 19:29:28 +01:00 · 2024-07-25 21:50:00 +05:30
409 changed files with 10232 additions and 2509 deletions
--- a/.github/workflows/publish-docs.yml
+++ b/.github/workflows/publish-docs.yml
@@ -104,8 +104,8 @@ jobs:
        run: |
          branch_name="${{ env.branch_name }}"

-          git config user.name "$GITHUB_ACTOR"
-          git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
+          git config user.name "astral-docs-bot"
+          git config user.email "176161322+astral-docs-bot@users.noreply.github.com"

          git checkout -b $branch_name
          git add site/ruff
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -9,7 +9,8 @@ exclude: |
    crates/ruff_python_formatter/resources/.*|
    crates/ruff_python_formatter/tests/snapshots/.*|
    crates/ruff_python_resolver/resources/.*|
-    crates/ruff_python_resolver/tests/snapshots/.*
+    crates/ruff_python_resolver/tests/snapshots/.*|
+    crates/red_knot/resources/.*
  )$

 repos:
@@ -56,18 +57,13 @@ repos:
        pass_filenames: false # This makes it a lot faster

  - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.5.2
+    rev: v0.5.4
    hooks:
      - id: ruff-format
      - id: ruff
        args: [--fix, --exit-non-zero-on-fix]
        types_or: [python, pyi]
        require_serial: true
-        exclude: |
-          (?x)^(
-            crates/ruff_linter/resources/.*|
-            crates/ruff_python_formatter/resources/.*
-          )$

  # Prettier
  - repo: https://github.com/pre-commit/mirrors-prettier
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,57 @@
 # Changelog

+## 0.5.5
+
+### Preview features
+
+- \[`fastapi`\] Implement `fastapi-redundant-response-model` (`FAST001`) and `fastapi-non-annotated-dependency`(`FAST002`) ([#11579](https://github.com/astral-sh/ruff/pull/11579))
+- \[`pydoclint`\] Implement `docstring-missing-exception` (`DOC501`) and `docstring-extraneous-exception` (`DOC502`) ([#11471](https://github.com/astral-sh/ruff/pull/11471))
+
+### Rule changes
+
+- \[`numpy`\] Fix NumPy 2.0 rule for `np.alltrue` and `np.sometrue` ([#12473](https://github.com/astral-sh/ruff/pull/12473))
+- \[`numpy`\] Ignore `NPY201` inside `except` blocks for compatibility with older numpy versions ([#12490](https://github.com/astral-sh/ruff/pull/12490))
+- \[`pep8-naming`\] Avoid applying `ignore-names` to `self` and `cls` function names (`N804`, `N805`) ([#12497](https://github.com/astral-sh/ruff/pull/12497))
+
+### Formatter
+
+- Fix incorrect placement of leading function comment with type params ([#12447](https://github.com/astral-sh/ruff/pull/12447))
+
+### Server
+
+- Do not bail code action resolution when a quick fix is requested ([#12462](https://github.com/astral-sh/ruff/pull/12462))
+
+### Bug fixes
+
+- Fix `Ord` implementation of `cmp_fix` ([#12471](https://github.com/astral-sh/ruff/pull/12471))
+- Raise syntax error for unparenthesized generator expression in multi-argument call ([#12445](https://github.com/astral-sh/ruff/pull/12445))
+- \[`pydoclint`\] Fix panic in `DOC501` reported in [#12428](https://github.com/astral-sh/ruff/pull/12428) ([#12435](https://github.com/astral-sh/ruff/pull/12435))
+- \[`flake8-bugbear`\] Allow singleton tuples with starred expressions in `B013` ([#12484](https://github.com/astral-sh/ruff/pull/12484))
+
+### Documentation
+
+- Add Eglot setup guide for Emacs editor ([#12426](https://github.com/astral-sh/ruff/pull/12426))
+- Add note about the breaking change in `nvim-lspconfig` ([#12507](https://github.com/astral-sh/ruff/pull/12507))
+- Add note to include notebook files for native server ([#12449](https://github.com/astral-sh/ruff/pull/12449))
+- Add setup docs for Zed editor ([#12501](https://github.com/astral-sh/ruff/pull/12501))
+
+## 0.5.4
+
+### Rule changes
+
+- \[`ruff`\] Rename `RUF007` to `zip-instead-of-pairwise` ([#12399](https://github.com/astral-sh/ruff/pull/12399))
+
+### Bug fixes
+
+- \[`flake8-builtins`\] Avoid shadowing diagnostics for `@override` methods ([#12415](https://github.com/astral-sh/ruff/pull/12415))
+- \[`flake8-comprehensions`\] Insert parentheses for multi-argument generators ([#12422](https://github.com/astral-sh/ruff/pull/12422))
+- \[`pydocstyle`\] Handle escaped docstrings within docstring (`D301`) ([#12192](https://github.com/astral-sh/ruff/pull/12192))
+
+### Documentation
+
+- Fix GitHub link to Neovim setup ([#12410](https://github.com/astral-sh/ruff/pull/12410))
+- Fix `output-format` default in settings reference ([#12409](https://github.com/astral-sh/ruff/pull/12409))
+
 ## 0.5.3

 **Ruff 0.5.3 marks the stable release of the Ruff language server and introduces revamped
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -905,7 +905,7 @@ There are three ways in which an import can be categorized as "first-party":
    package (e.g., `from foo import bar` or `import foo.bar`), they'll be classified as first-party
    automatically. This check is as simple as comparing the first segment of the current file's
    module path to the first segment of the import.
-1. **Source roots**: Ruff supports a `[src](https://docs.astral.sh/ruff/settings/#src)` setting, which
+1. **Source roots**: Ruff supports a [`src`](https://docs.astral.sh/ruff/settings/#src) setting, which
    sets the directories to scan when identifying first-party imports. The algorithm is
    straightforward: given an import, like `import foo`, iterate over the directories enumerated in
    the `src` setting and, for each directory, check for the existence of a subdirectory `foo` or a
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1866,6 +1866,7 @@ dependencies = [
 "ruff_python_ast",
 "rustc-hash 2.0.0",
 "salsa",
+ "tempfile",
 "tracing",
 "tracing-subscriber",
 "tracing-tree",
@@ -1897,6 +1898,7 @@ version = "0.0.0"
 dependencies = [
 "anyhow",
 "bitflags 2.6.0",
+ "countme",
 "hashbrown",
 "ordermap",
 "red_knot_module_resolver",
@@ -1904,7 +1906,6 @@ dependencies = [
 "ruff_index",
 "ruff_python_ast",
 "ruff_python_parser",
- "ruff_python_trivia",
 "ruff_text_size",
 "rustc-hash 2.0.0",
 "salsa",
@@ -1992,7 +1993,7 @@ dependencies = [

 [[package]]
 name = "ruff"
-version = "0.5.3"
+version = "0.5.5"
 dependencies = [
 "anyhow",
 "argfile",
@@ -2091,6 +2092,7 @@ dependencies = [
 "ruff_notebook",
 "ruff_python_ast",
 "ruff_python_parser",
+ "ruff_python_trivia",
 "ruff_source_file",
 "ruff_text_size",
 "rustc-hash 2.0.0",
@@ -2176,7 +2178,7 @@ dependencies = [

 [[package]]
 name = "ruff_linter"
-version = "0.5.3"
+version = "0.5.5"
 dependencies = [
 "aho-corasick",
 "annotate-snippets 0.9.2",
@@ -2491,7 +2493,7 @@ dependencies = [

 [[package]]
 name = "ruff_wasm"
-version = "0.5.3"
+version = "0.5.5"
 dependencies = [
 "console_error_panic_hook",
 "console_log",
@@ -2910,9 +2912,9 @@ checksum = "81cdd64d312baedb58e21336b31bc043b77e01cc99033ce76ef539f78e965ebc"

 [[package]]
 name = "syn"
-version = "2.0.71"
+version = "2.0.72"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b146dcf730474b4bcd16c311627b31ede9ab149045db4d6088b3becaea046462"
+checksum = "dc4b9b9bf2add8093d3f2c0204471e951b2285580335de42f9d2534f3ae7a8af"
 dependencies = [
 "proc-macro2",
 "quote",
@@ -3000,18 +3002,18 @@ dependencies = [

 [[package]]
 name = "thiserror"
-version = "1.0.62"
+version = "1.0.63"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f2675633b1499176c2dff06b0856a27976a8f9d436737b4cf4f312d4d91d8bbb"
+checksum = "c0342370b38b6a11b6cc11d6a805569958d54cfa061a29969c3b5ce2ea405724"
 dependencies = [
 "thiserror-impl",
 ]

 [[package]]
 name = "thiserror-impl"
-version = "1.0.62"
+version = "1.0.63"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d20468752b09f49e909e55a5d338caa8bedf615594e9d80bc4c565d30faf798c"
+checksum = "a4558b58466b9ad7ca0f102865eccc95938dca1a74a856f2b57b6629050da261"
 dependencies = [
 "proc-macro2",
 "quote",
@@ -3075,9 +3077,9 @@ checksum = "1f3ccbac311fea05f86f61904b462b55fb3df8837a366dfc601a0161d0532f20"

 [[package]]
 name = "toml"
-version = "0.8.14"
+version = "0.8.15"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6f49eb2ab21d2f26bd6db7bf383edc527a7ebaee412d17af4d40fdccd442f335"
+checksum = "ac2caab0bf757388c6c0ae23b3293fdb463fee59434529014f85e3263b995c28"
 dependencies = [
 "serde",
 "serde_spanned",
@@ -3096,9 +3098,9 @@ dependencies = [

 [[package]]
 name = "toml_edit"
-version = "0.22.14"
+version = "0.22.16"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f21c7aaf97f1bd9ca9d4f9e73b0a6c74bd5afef56f2bc931943a6e1c37e04e38"
+checksum = "278f3d518e152219c994ce877758516bca5e118eaed6996192a774fb9fbf0788"
 dependencies = [
 "indexmap",
 "serde",
@@ -3183,9 +3185,9 @@ dependencies = [

 [[package]]
 name = "tracing-tree"
-version = "0.3.1"
+version = "0.4.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b56c62d2c80033cb36fae448730a2f2ef99410fe3ecbffc916681a32f6807dbe"
+checksum = "f459ca79f1b0d5f71c54ddfde6debfc59c8b6eeb46808ae492077f739dc7b49c"
 dependencies = [
 "nu-ansi-term 0.50.0",
 "tracing-core",
@@ -3338,9 +3340,9 @@ checksum = "711b9620af191e0cdc7468a8d14e709c3dcdb115b36f838e601583af800a370a"

 [[package]]
 name = "uuid"
-version = "1.9.1"
+version = "1.10.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5de17fd2f7da591098415cff336e12965a28061ddace43b59cb3c430179c9439"
+checksum = "81dfa00651efa65069b0b6b651f4aaa31ba9e3c3ce0137aaad053604ee7e0314"
 dependencies = [
 "getrandom",
 "rand",
@@ -3350,9 +3352,9 @@ dependencies = [

 [[package]]
 name = "uuid-macro-internal"
-version = "1.9.1"
+version = "1.10.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a3ff64d5cde1e2cb5268bdb497235b6bd255ba8244f910dbc3574e59593de68c"
+checksum = "ee1cd046f83ea2c4e920d6ee9f7c3537ef928d75dce5d84a87c2c5d6b3999a3a"
 dependencies = [
 "proc-macro2",
 "quote",
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -133,7 +133,7 @@ toml = { version = "0.8.11" }
 tracing = { version = "0.1.40" }
 tracing-indicatif = { version = "0.3.6" }
 tracing-subscriber = { version = "0.3.18", features = ["env-filter"] }
-tracing-tree = { version = "0.3.0" }
+tracing-tree = { version = "0.4.0" }
 typed-arena = { version = "2.0.2" }
 unic-ucd-category = { version = "0.9" }
 unicode-ident = { version = "1.0.12" }
--- a/25
+++ b/25
@@ -1371,3 +1371,28 @@ are:
    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
    SOFTWARE.
  """
+
+- pydoclint, licensed as follows:
+  """
+    MIT License
+
+    Copyright (c) 2023 jsh9
+
+    Permission is hereby granted, free of charge, to any person obtaining a copy
+    of this software and associated documentation files (the "Software"), to deal
+    in the Software without restriction, including without limitation the rights
+    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+    copies of the Software, and to permit persons to whom the Software is
+    furnished to do so, subject to the following conditions:
+
+    The above copyright notice and this permission notice shall be included in all
+    copies or substantial portions of the Software.
+
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+    SOFTWARE.
+  """
--- a/README.md
+++ b/README.md
@@ -136,8 +136,8 @@ curl -LsSf https://astral.sh/ruff/install.sh | sh
 powershell -c "irm https://astral.sh/ruff/install.ps1 | iex"

 # For a specific version.
-curl -LsSf https://astral.sh/ruff/0.5.3/install.sh | sh
-powershell -c "irm https://astral.sh/ruff/0.5.3/install.ps1 | iex"
+curl -LsSf https://astral.sh/ruff/0.5.5/install.sh | sh
+powershell -c "irm https://astral.sh/ruff/0.5.5/install.ps1 | iex"
 ```

 You can also install Ruff via [Homebrew](https://formulae.brew.sh/formula/ruff), [Conda](https://anaconda.org/conda-forge/ruff),
@@ -170,7 +170,7 @@ Ruff can also be used as a [pre-commit](https://pre-commit.com/) hook via [`ruff
 ```yaml
 - repo: https://github.com/astral-sh/ruff-pre-commit
  # Ruff version.
-  rev: v0.5.3
+  rev: v0.5.5
  hooks:
    # Run the linter.
    - id: ruff
@@ -434,6 +434,7 @@ Ruff is used by a number of major open-source projects and companies, including:
 - Hugging Face ([Transformers](https://github.com/huggingface/transformers),
    [Datasets](https://github.com/huggingface/datasets),
    [Diffusers](https://github.com/huggingface/diffusers))
+- IBM ([Qiskit](https://github.com/Qiskit/qiskit))
 - ING Bank ([popmon](https://github.com/ing-bank/popmon), [probatus](https://github.com/ing-bank/probatus))
 - [Ibis](https://github.com/ibis-project/ibis)
 - [ivy](https://github.com/unifyai/ivy)
--- a/crates/red_knot/Cargo.toml
+++ b/crates/red_knot/Cargo.toml
@@ -31,6 +31,9 @@ tracing = { workspace = true }
 tracing-subscriber = { workspace = true }
 tracing-tree = { workspace = true }

+[dev-dependencies]
+tempfile = { workspace = true }
+

 [lints]
 workspace = true
--- a/crates/red_knot/resources/test/corpus/00_const.py
+++ b/crates/red_knot/resources/test/corpus/00_const.py
@@ -0,0 +1,5 @@
+None
+False
+True
+Ellipsis
+...
--- a/crates/red_knot/resources/test/corpus/00_empty.py
+++ b/crates/red_knot/resources/test/corpus/00_empty.py
--- a/crates/red_knot/resources/test/corpus/00_expr_discard.py
+++ b/crates/red_knot/resources/test/corpus/00_expr_discard.py
@@ -0,0 +1,4 @@
+"str"
+1
+1.1
+b"bin"
--- a/crates/red_knot/resources/test/corpus/00_expr_var1.py
+++ b/crates/red_knot/resources/test/corpus/00_expr_var1.py
@@ -0,0 +1 @@
+a
--- a/crates/red_knot/resources/test/corpus/01_expr_unary.py
+++ b/crates/red_knot/resources/test/corpus/01_expr_unary.py
@@ -0,0 +1,4 @@
+-a
+~a
+a
+not a
--- a/crates/red_knot/resources/test/corpus/02_expr_attr.py
+++ b/crates/red_knot/resources/test/corpus/02_expr_attr.py
@@ -0,0 +1,2 @@
+a.b
+a.b.c.d
--- a/crates/red_knot/resources/test/corpus/02_expr_attr_multiline.py
+++ b/crates/red_knot/resources/test/corpus/02_expr_attr_multiline.py
@@ -0,0 +1,3 @@
+foo(
+    bar=1
+).attr
--- a/crates/red_knot/resources/test/corpus/02_expr_attr_multiline_assign.py
+++ b/crates/red_knot/resources/test/corpus/02_expr_attr_multiline_assign.py
@@ -0,0 +1,3 @@
+foo(
+    bar=1
+).attr = 1
--- a/crates/red_knot/resources/test/corpus/02_expr_bin_bool.py
+++ b/crates/red_knot/resources/test/corpus/02_expr_bin_bool.py
@@ -0,0 +1,6 @@
+a or b or c
+a and b and c
+
+a or b and c
+
+#a and b or c
--- a/crates/red_knot/resources/test/corpus/02_expr_binary.py
+++ b/crates/red_knot/resources/test/corpus/02_expr_binary.py
@@ -0,0 +1,14 @@
+a + b
+a - b
+a * b
+a @ b
+a / b
+a // b
+a % b
+a ** b
+
+a << b
+a >> b
+a | b
+a ^ b
+a & b
--- a/crates/red_knot/resources/test/corpus/02_expr_bool_op_multiline.py
+++ b/crates/red_knot/resources/test/corpus/02_expr_bool_op_multiline.py
@@ -0,0 +1,6 @@
+x == y or (
+    x is not None and x == z
+)
+
+x == y or \
+    x <= 65 or x >= 102
--- a/crates/red_knot/resources/test/corpus/02_expr_bool_op_multiline2.py
+++ b/crates/red_knot/resources/test/corpus/02_expr_bool_op_multiline2.py
@@ -0,0 +1,5 @@
+(
+    (a and aa) or
+    (b and bb) or
+    (c and cc)
+)
--- a/crates/red_knot/resources/test/corpus/02_expr_rel.py
+++ b/crates/red_knot/resources/test/corpus/02_expr_rel.py
@@ -0,0 +1,10 @@
+a == b
+a != b
+a < b
+a <= b
+a > b
+a >= b
+a is b
+a is not b
+a in b
+a not in b
--- a/crates/red_knot/resources/test/corpus/02_expr_rel_multiple.py
+++ b/crates/red_knot/resources/test/corpus/02_expr_rel_multiple.py
@@ -0,0 +1,2 @@
+a == b == 0
+0 < a < 10
--- a/crates/red_knot/resources/test/corpus/02_expr_subscr.py
+++ b/crates/red_knot/resources/test/corpus/02_expr_subscr.py
@@ -0,0 +1,2 @@
+a[b]
+a[b][c]
--- a/crates/red_knot/resources/test/corpus/03_dict.py
+++ b/crates/red_knot/resources/test/corpus/03_dict.py
@@ -0,0 +1 @@
+{a: 1, b:2}
--- a/crates/red_knot/resources/test/corpus/03_dict_ex.py
+++ b/crates/red_knot/resources/test/corpus/03_dict_ex.py
@@ -0,0 +1 @@
+{1: 2, **a, 3: 4, 5: 6}
--- a/crates/red_knot/resources/test/corpus/03_dict_literal_large.py
+++ b/crates/red_knot/resources/test/corpus/03_dict_literal_large.py
@@ -0,0 +1,20 @@
+DATA = {
+    'a': 1,
+    'b': 1,
+    'c': 1,
+    'd': 1,
+    'e': 1,
+    'f': 1,
+    'g': 1,
+    'h': 1,
+    'i': 1,
+    'j': 1,
+    'k': 1,
+    'l': 1,
+    'm': 1,
+    'n': 1,
+    'o': 1,
+    'p': 1,
+    'q': 1,
+    'r': 1,
+}
--- a/crates/red_knot/resources/test/corpus/03_dict_unpack_huge.py
+++ b/crates/red_knot/resources/test/corpus/03_dict_unpack_huge.py
@@ -0,0 +1,2 @@
+{**{0:1},**{1:2},**{2:3},**{3:4},**{4:5},**{5:6},**{6:7},**{7:8},**{8:9},**{9:10},**{10:11},**{11:12},**{12:13},**{13:14},**{14:15},**{15:16},**{16:17},**{17:18},**{18:19},**{19:20},**{20:21},**{21:22},**{22:23},**{23:24},**{24:25},**{25:26},**{26:27},**{27:28},**{28:29},**{29:30},**{30:31},**{31:32},**{32:33},**{33:34},**{34:35},**{35:36},**{36:37},**{37:38},**{38:39},**{39:40},**{40:41},**{41:42},**{42:43},**{43:44},**{44:45},**{45:46},**{46:47},**{47:48},**{48:49},**{49:50},**{50:51},**{51:52},**{52:53},**{53:54},**{54:55},**{55:56},**{56:57},**{57:58},**{58:59},**{59:60},**{60:61},**{61:62},**{62:63},**{63:64},**{64:65},**{65:66},**{66:67},**{67:68},**{68:69},**{69:70},**{70:71},**{71:72},**{72:73},**{73:74},**{74:75},**{75:76},**{76:77},**{77:78},**{78:79},**{79:80},**{80:81},**{81:82},**{82:83},**{83:84},**{84:85},**{85:86},**{86:87},**{87:88},**{88:89},**{89:90},**{90:91},**{91:92},**{92:93},**{93:94},**{94:95},**{95:96},**{96:97},**{97:98},**{98:99},**{99:100},**{100:101},**{101:102},**{102:103},**{103:104},**{104:105},**{105:106},**{106:107},**{107:108},**{108:109},**{109:110},**{110:111},**{111:112},**{112:113},**{113:114},**{114:115},**{115:116},**{116:117},**{117:118},**{118:119},**{119:120},**{120:121},**{121:122},**{122:123},**{123:124},**{124:125},**{125:126},**{126:127},**{127:128},**{128:129},**{129:130},**{130:131},**{131:132},**{132:133},**{133:134},**{134:135},**{135:136},**{136:137},**{137:138},**{138:139},**{139:140},**{140:141},**{141:142},**{142:143},**{143:144},**{144:145},**{145:146},**{146:147},**{147:148},**{148:149},**{149:150},**{150:151},**{151:152},**{152:153},**{153:154},**{154:155},**{155:156},**{156:157},**{157:158},**{158:159},**{159:160},**{160:161},**{161:162},**{162:163},**{163:164},**{164:165},**{165:166},**{166:167},**{167:168},**{168:169},**{169:170},**{170:171},**{171:172},**{172:173},**{173:174},**{174:175},**{175:176},**{176:177},**{177:178},**{178:179},**{179:180},**{180:181},**{181:182},**{182:183},**{183:184},**{184:185},**{185:186},**{186:187},**{187:188},**{188:189},**{189:190},**{190:191},**{191:192},**{192:193},**{193:194},**{194:195},**{195:196},**{196:197},**{197:198},**{198:199},**{199:200},**{200:201},**{201:202},**{202:203},**{203:204},**{204:205},**{205:206},**{206:207},**{207:208},**{208:209},**{209:210},**{210:211},**{211:212},**{212:213},**{213:214},**{214:215},**{215:216},**{216:217},**{217:218},**{218:219},**{219:220},**{220:221},**{221:222},**{222:223},**{223:224},**{224:225},**{225:226},**{226:227},**{227:228},**{228:229},**{229:230},**{230:231},**{231:232},**{232:233},**{233:234},**{234:235},**{235:236},**{236:237},**{237:238},**{238:239},**{239:240},**{240:241},**{241:242},**{242:243},**{243:244},**{244:245},**{245:246},**{246:247},**{247:248},**{248:249},**{249:250},**{250:251},**{251:252},**{252:253},**{253:254},**{254:255},**{255:256},**{256:257},**{257:258},**{258:259},**{259:260}}
+
--- a/crates/red_knot/resources/test/corpus/03_list.py
+++ b/crates/red_knot/resources/test/corpus/03_list.py
@@ -0,0 +1 @@
+[a, b]
--- a/crates/red_knot/resources/test/corpus/03_list_ex.py
+++ b/crates/red_knot/resources/test/corpus/03_list_ex.py
@@ -0,0 +1 @@
+[a, *b, *d, a, c]
--- a/crates/red_knot/resources/test/corpus/03_list_large.py
+++ b/crates/red_knot/resources/test/corpus/03_list_large.py
@@ -0,0 +1 @@
+l = [a, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31]
--- a/crates/red_knot/resources/test/corpus/03_set.py
+++ b/crates/red_knot/resources/test/corpus/03_set.py
@@ -0,0 +1 @@
+{a, b}
--- a/crates/red_knot/resources/test/corpus/03_set_multi.py
+++ b/crates/red_knot/resources/test/corpus/03_set_multi.py
@@ -0,0 +1,38 @@
+d = {
+    0: {
+        "en",
+        "es",
+        "zh",
+        "ja",
+        "de",
+        "fr",
+        "ru",
+        "ar",
+        "pt",
+        "fa",
+        "tr",
+        "ko",
+        "id",
+        None,
+        (1, "2"),
+        (1, 2),
+    },
+    1: {
+        "en",
+        "de",
+        "fr",
+        "ar",
+        "pt",
+        "ja",
+        "zh",
+        "ru",
+        None,
+        "es",
+        "fa",
+        "tr",
+        "ko",
+        "id",
+        (1, "2"),
+        (1, 2),
+    },
+}
--- a/crates/red_knot/resources/test/corpus/03_slice.py
+++ b/crates/red_knot/resources/test/corpus/03_slice.py
@@ -0,0 +1,6 @@
+arr[a:b]
+arr[a:b:c]
+arr[a:]
+arr[:b]
+arr[:]
+arr[::2]
--- a/crates/red_knot/resources/test/corpus/03_slice_ext.py
+++ b/crates/red_knot/resources/test/corpus/03_slice_ext.py
@@ -0,0 +1 @@
+arr[a:b, c:d]
--- a/crates/red_knot/resources/test/corpus/03_tuple.py
+++ b/crates/red_knot/resources/test/corpus/03_tuple.py
@@ -0,0 +1,2 @@
+(a,)
+(b, c)
--- a/crates/red_knot/resources/test/corpus/03_tuple_ex.py
+++ b/crates/red_knot/resources/test/corpus/03_tuple_ex.py
@@ -0,0 +1,2 @@
+(*b,)
+(*b, c)
--- a/crates/red_knot/resources/test/corpus/04_assign.py
+++ b/crates/red_knot/resources/test/corpus/04_assign.py
@@ -0,0 +1,4 @@
+a = 1
+b = "foo"
+c = (d, e)
+di = {f: 1, g: 2}
--- a/crates/red_knot/resources/test/corpus/04_assign_attr.py
+++ b/crates/red_knot/resources/test/corpus/04_assign_attr.py
@@ -0,0 +1,2 @@
+a.b = 1
+a.b.c.d = 2
--- a/crates/red_knot/resources/test/corpus/04_assign_attr_func.py
+++ b/crates/red_knot/resources/test/corpus/04_assign_attr_func.py
@@ -0,0 +1,2 @@
+def foo():
+    a.b = 1
--- a/crates/red_knot/resources/test/corpus/04_assign_subscr.py
+++ b/crates/red_knot/resources/test/corpus/04_assign_subscr.py
@@ -0,0 +1 @@
+a[b] = 1
--- a/crates/red_knot/resources/test/corpus/04_assign_unpack.py
+++ b/crates/red_knot/resources/test/corpus/04_assign_unpack.py
@@ -0,0 +1,2 @@
+a, b = c
+[a, b] = c
--- a/crates/red_knot/resources/test/corpus/04_assign_unpack_ex.py
+++ b/crates/red_knot/resources/test/corpus/04_assign_unpack_ex.py
@@ -0,0 +1,4 @@
+a, *b = c
+*a, b = c
+a, *b, c, d = e
+[a, *b, c] = d
--- a/crates/red_knot/resources/test/corpus/04_assign_unpack_tuple.py
+++ b/crates/red_knot/resources/test/corpus/04_assign_unpack_tuple.py
@@ -0,0 +1,5 @@
+a, = x,
+a, b = x, y
+a, b, c = x, y, z
+a, b, c, d = w, x, y, z
+a, b = 1, 2
--- a/crates/red_knot/resources/test/corpus/04_aug_assign.py
+++ b/crates/red_knot/resources/test/corpus/04_aug_assign.py
@@ -0,0 +1,14 @@
+a += 1
+a -= 2
+a *= 3
+a @= 4
+a /= 5
+a //= 6
+a %= 7
+a **= 8
+
+a <<= b
+a >>= b
+a |= b
+a ^= b
+a &= b
--- a/crates/red_knot/resources/test/corpus/04_aug_assign_attr_multiline.py
+++ b/crates/red_knot/resources/test/corpus/04_aug_assign_attr_multiline.py
@@ -0,0 +1,6 @@
+(
+    o.
+    a
+) += (
+    v
+)
--- a/crates/red_knot/resources/test/corpus/04_aug_assign_attr_sub.py
+++ b/crates/red_knot/resources/test/corpus/04_aug_assign_attr_sub.py
@@ -0,0 +1,3 @@
+a.b -= 2
+a[0] += 1
+a[0:2] += 1
--- a/crates/red_knot/resources/test/corpus/05_funcall.py
+++ b/crates/red_knot/resources/test/corpus/05_funcall.py
@@ -0,0 +1 @@
+fun()
--- a/crates/red_knot/resources/test/corpus/05_funcall_1.py
+++ b/crates/red_knot/resources/test/corpus/05_funcall_1.py
@@ -0,0 +1 @@
+fun(a)
--- a/crates/red_knot/resources/test/corpus/05_funcall_2.py
+++ b/crates/red_knot/resources/test/corpus/05_funcall_2.py
@@ -0,0 +1 @@
+fun(a, b)
--- a/crates/red_knot/resources/test/corpus/05_funcall_in_multiline_tuple.py
+++ b/crates/red_knot/resources/test/corpus/05_funcall_in_multiline_tuple.py
@@ -0,0 +1,2 @@
+a = (x,
+    foo(y))
--- a/crates/red_knot/resources/test/corpus/05_funcall_kw.py
+++ b/crates/red_knot/resources/test/corpus/05_funcall_kw.py
@@ -0,0 +1 @@
+fun(a=a, kw=2)
--- a/crates/red_knot/resources/test/corpus/05_funcall_kw_many.py
+++ b/crates/red_knot/resources/test/corpus/05_funcall_kw_many.py
@@ -0,0 +1,18 @@
+foo(
+    a=1,
+    b=1,
+    c=1,
+    d=1,
+    e=1,
+    f=1,
+    g=1,
+    h=1,
+    i=1,
+    j=1,
+    k=1,
+    l=1,
+    m=1,
+    n=1,
+    o=1,
+    p=1,
+)
--- a/crates/red_knot/resources/test/corpus/05_funcall_kw_pos.py
+++ b/crates/red_knot/resources/test/corpus/05_funcall_kw_pos.py
@@ -0,0 +1 @@
+fun(var, 10, a=a, kw=2)
--- a/crates/red_knot/resources/test/corpus/05_funcall_method_multiline.py
+++ b/crates/red_knot/resources/test/corpus/05_funcall_method_multiline.py
@@ -0,0 +1,2 @@
+("foo"
+.format())
--- a/crates/red_knot/resources/test/corpus/06_funcall_kwargs.py
+++ b/crates/red_knot/resources/test/corpus/06_funcall_kwargs.py
@@ -0,0 +1,2 @@
+c = {a: 1, b: 2}
+fun(a, b, **c)
--- a/crates/red_knot/resources/test/corpus/06_funcall_many_args.py
+++ b/crates/red_knot/resources/test/corpus/06_funcall_many_args.py
@@ -0,0 +1,32 @@
+C.meth(
+    a,
+    b,
+    c,
+    d,
+    e,
+    f,
+    g,
+    h,
+    i,
+    j,
+    k,
+    l,
+    m,
+    n,
+    o,
+    p,
+    q,
+    r,
+    s,
+    t,
+    u,
+    v,
+    w,
+    x,
+    y,
+    z,
+    aa,
+    bb,
+    cc,
+    dd,
+)
--- a/crates/red_knot/resources/test/corpus/06_funcall_starargs_ex.py
+++ b/crates/red_knot/resources/test/corpus/06_funcall_starargs_ex.py
@@ -0,0 +1,3 @@
+fun(*b, c)
+fun(a, *b, c)
+fun(a, *b, c, *d)
--- a/crates/red_knot/resources/test/corpus/06_funcall_varargs.py
+++ b/crates/red_knot/resources/test/corpus/06_funcall_varargs.py
@@ -0,0 +1,2 @@
+c = (a, b)
+fun(a, b, *c)
--- a/crates/red_knot/resources/test/corpus/06_funcall_varargs_kwargs.py
+++ b/crates/red_knot/resources/test/corpus/06_funcall_varargs_kwargs.py
@@ -0,0 +1,3 @@
+c = (a, b)
+d = {e: 1, f: 2}
+fun(a, b, *c, **d)
--- a/crates/red_knot/resources/test/corpus/06_funcall_varargs_kwargs_mixed.py
+++ b/crates/red_knot/resources/test/corpus/06_funcall_varargs_kwargs_mixed.py
@@ -0,0 +1,10 @@
+fun(a, kw=1, *c, **d)
+fun(a, *c, kw=1, **d)
+
+fun(a, kw=1, *c)
+fun(a, *c, kw=1)
+
+fun(a, *c)
+
+# Introduced in Python3.5, not supported yet
+#fun(*c, a)
--- a/crates/red_knot/resources/test/corpus/07_ifexpr.py
+++ b/crates/red_knot/resources/test/corpus/07_ifexpr.py
@@ -0,0 +1,2 @@
+a if b else c
+
--- a/crates/red_knot/resources/test/corpus/07_ifexpr_multiline.py
+++ b/crates/red_knot/resources/test/corpus/07_ifexpr_multiline.py
@@ -0,0 +1,4 @@
+(
+    x,
+    a if b else c
+)
--- a/crates/red_knot/resources/test/corpus/07_ifexpr_multiline2.py
+++ b/crates/red_knot/resources/test/corpus/07_ifexpr_multiline2.py
@@ -0,0 +1,7 @@
+a = (
+    (
+        b()
+    )
+    if c
+    else d
+)
--- a/crates/red_knot/resources/test/corpus/08_del.py
+++ b/crates/red_knot/resources/test/corpus/08_del.py
@@ -0,0 +1,3 @@
+del a
+del a[0]
+del a.b
--- a/crates/red_knot/resources/test/corpus/08_del_multi.py
+++ b/crates/red_knot/resources/test/corpus/08_del_multi.py
@@ -0,0 +1,2 @@
+del (a, b, c)
+del [a, b, c]
--- a/crates/red_knot/resources/test/corpus/09_pass.py
+++ b/crates/red_knot/resources/test/corpus/09_pass.py
@@ -0,0 +1 @@
+pass
--- a/crates/red_knot/resources/test/corpus/10_if.py
+++ b/crates/red_knot/resources/test/corpus/10_if.py
@@ -0,0 +1,2 @@
+if a:
+    b
--- a/crates/red_knot/resources/test/corpus/10_if_chained_compare.py
+++ b/crates/red_knot/resources/test/corpus/10_if_chained_compare.py
@@ -0,0 +1,2 @@
+if 0 < x < 10:
+    pass
--- a/crates/red_knot/resources/test/corpus/10_if_false.py
+++ b/crates/red_knot/resources/test/corpus/10_if_false.py
@@ -0,0 +1,28 @@
+if 0:
+    a
+
+if False:
+    b
+
+if None:
+    c
+
+if "":
+    d
+
+if 0:
+    e.f
+    g.h()
+    i.j = 1
+    del k.l
+    import m
+    from n import o
+    p = 1
+
+def f():
+    if 0:
+        q = 1
+        r.s = 1
+        t
+        import u
+        v = u.w()
--- a/crates/red_knot/resources/test/corpus/10_if_true.py
+++ b/crates/red_knot/resources/test/corpus/10_if_true.py
@@ -0,0 +1,8 @@
+if 1:
+    a
+
+if True:
+    b
+
+if "foo":
+    c
--- a/crates/red_knot/resources/test/corpus/11_if_else.py
+++ b/crates/red_knot/resources/test/corpus/11_if_else.py
@@ -0,0 +1,4 @@
+if a:
+    b
+else:
+    c
--- a/crates/red_knot/resources/test/corpus/11_if_else_deeply_nested_for.py
+++ b/crates/red_knot/resources/test/corpus/11_if_else_deeply_nested_for.py
@@ -0,0 +1,12 @@
+if a:
+    if b:
+        if c:
+            for x in y:
+                pass
+        else:
+            pass
+    else:
+        pass
+else:
+    pass
+foo()
--- a/crates/red_knot/resources/test/corpus/11_if_else_false.py
+++ b/crates/red_knot/resources/test/corpus/11_if_else_false.py
@@ -0,0 +1,4 @@
+if False:
+    b
+else:
+    c
--- a/crates/red_knot/resources/test/corpus/11_if_else_true.py
+++ b/crates/red_knot/resources/test/corpus/11_if_else_true.py
@@ -0,0 +1,4 @@
+if True:
+    b
+else:
+    c
--- a/crates/red_knot/resources/test/corpus/12_if_elif.py
+++ b/crates/red_knot/resources/test/corpus/12_if_elif.py
@@ -0,0 +1,4 @@
+if a:
+    b
+elif c:
+    d
--- a/crates/red_knot/resources/test/corpus/12_if_elif_else.py
+++ b/crates/red_knot/resources/test/corpus/12_if_elif_else.py
@@ -0,0 +1,6 @@
+if a:
+    b
+elif c:
+    d
+else:
+    e
--- a/crates/red_knot/resources/test/corpus/13_ifelse_complex1.py
+++ b/crates/red_knot/resources/test/corpus/13_ifelse_complex1.py
@@ -0,0 +1,12 @@
+if py2:
+    a
+else:
+    b
+
+if var:
+    c
+else:
+    if py3:
+        d
+    else:
+        e
--- a/crates/red_knot/resources/test/corpus/13_ifelse_many.py
+++ b/crates/red_knot/resources/test/corpus/13_ifelse_many.py
@@ -0,0 +1,8 @@
+if a:
+    a1
+elif b:
+    b1
+elif c:
+    c1
+elif d:
+    d1
--- a/crates/red_knot/resources/test/corpus/15_while.py
+++ b/crates/red_knot/resources/test/corpus/15_while.py
@@ -0,0 +1,2 @@
+while a:
+    b
--- a/crates/red_knot/resources/test/corpus/15_while_break.py
+++ b/crates/red_knot/resources/test/corpus/15_while_break.py
@@ -0,0 +1,2 @@
+while a:
+    break
--- a/crates/red_knot/resources/test/corpus/15_while_break_in_finally.py
+++ b/crates/red_knot/resources/test/corpus/15_while_break_in_finally.py
@@ -0,0 +1,5 @@
+while a:
+    try:
+        continue
+    finally:
+        break
--- a/crates/red_knot/resources/test/corpus/15_while_break_non_empty.py
+++ b/crates/red_knot/resources/test/corpus/15_while_break_non_empty.py
@@ -0,0 +1,4 @@
+while a:
+    if x:
+        break
+    y = 1
--- a/crates/red_knot/resources/test/corpus/15_while_break_non_exit.py
+++ b/crates/red_knot/resources/test/corpus/15_while_break_non_exit.py
@@ -0,0 +1,7 @@
+while a:
+    try:
+       x
+    except:
+        break
+if x:
+    z = 1
--- a/crates/red_knot/resources/test/corpus/15_while_continue.py
+++ b/crates/red_knot/resources/test/corpus/15_while_continue.py
@@ -0,0 +1,2 @@
+while a:
+    continue
--- a/crates/red_knot/resources/test/corpus/15_while_false.py
+++ b/crates/red_knot/resources/test/corpus/15_while_false.py
@@ -0,0 +1,2 @@
+while False:
+    b
--- a/crates/red_knot/resources/test/corpus/15_while_infinite.py
+++ b/crates/red_knot/resources/test/corpus/15_while_infinite.py
@@ -0,0 +1,2 @@
+while 1:
+    b
--- a/crates/red_knot/resources/test/corpus/15_while_true.py
+++ b/crates/red_knot/resources/test/corpus/15_while_true.py
@@ -0,0 +1,2 @@
+while True:
+    b
--- a/crates/red_knot/resources/test/corpus/16_for.py
+++ b/crates/red_knot/resources/test/corpus/16_for.py
@@ -0,0 +1,2 @@
+for a in b:
+    c
--- a/crates/red_knot/resources/test/corpus/16_for_break.py
+++ b/crates/red_knot/resources/test/corpus/16_for_break.py
@@ -0,0 +1,2 @@
+for a in b:
+    break
--- a/crates/red_knot/resources/test/corpus/16_for_continue.py
+++ b/crates/red_knot/resources/test/corpus/16_for_continue.py
@@ -0,0 +1,2 @@
+for a in b:
+    continue
--- a/crates/red_knot/resources/test/corpus/16_for_else.py
+++ b/crates/red_knot/resources/test/corpus/16_for_else.py
@@ -0,0 +1,4 @@
+for a in b:
+    c
+else:
+    d
--- a/crates/red_knot/resources/test/corpus/16_for_list_literal.py
+++ b/crates/red_knot/resources/test/corpus/16_for_list_literal.py
@@ -0,0 +1,2 @@
+for x in [a, b]:
+    pass
--- a/crates/red_knot/resources/test/corpus/16_for_nested_ifs.py
+++ b/crates/red_knot/resources/test/corpus/16_for_nested_ifs.py
@@ -0,0 +1,8 @@
+for x in y:
+    if a:
+        if x:
+            y
+        else:
+            x
+    else:
+        b
--- a/crates/red_knot/resources/test/corpus/20_lambda.py
+++ b/crates/red_knot/resources/test/corpus/20_lambda.py
@@ -0,0 +1,3 @@
+lambda x: y
+
+lambda x: a and b
--- a/crates/red_knot/resources/test/corpus/20_lambda_const.py
+++ b/crates/red_knot/resources/test/corpus/20_lambda_const.py
@@ -0,0 +1 @@
+lambda x: y + 1
--- a/crates/red_knot/resources/test/corpus/20_lambda_default_arg.py
+++ b/crates/red_knot/resources/test/corpus/20_lambda_default_arg.py
@@ -0,0 +1 @@
+lambda x=a: y
--- a/crates/red_knot/resources/test/corpus/20_lambda_ifelse.py
+++ b/crates/red_knot/resources/test/corpus/20_lambda_ifelse.py
@@ -0,0 +1 @@
+lambda x: 0 if x else -1
--- a/crates/red_knot/resources/test/corpus/21_func1.py
+++ b/crates/red_knot/resources/test/corpus/21_func1.py
@@ -0,0 +1,2 @@
+def foo():
+    a
--- a/crates/red_knot/resources/test/corpus/21_func1_ret.py
+++ b/crates/red_knot/resources/test/corpus/21_func1_ret.py
@@ -0,0 +1,2 @@
+def foo():
+    return a
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Carl Meyer	222805e210	[red-knot] qualify function/class name with module/file	2024-07-25 22:18:23 -07:00
Carl Meyer	2d3914296d	[red-knot] handle all syntax without panic (#12499 ) Extend red-knot type inference to cover all syntax, so that inferring types for a scope gives all expressions a type. This means we can run the red-knot semantic lint on all Python code without panics. It also means we can infer types for `builtins.pyi` without panics. To keep things simple, this PR intentionally doesn't add any new type inference capabilities: the expanded coverage is all achieved with `Type::Unknown`. But this puts the skeleton in place for adding better inference of all these language features. I also had to add basic Salsa cycle recovery (with just `Type::Unknown` for now), because some `builtins.pyi` definitions are cyclic. To test this, I added a comprehensive corpus of test snippets sourced from Cinder under [MIT license](https://github.com/facebookincubator/cinder/blob/cinder/3.10/cinderx/LICENSE), which matches Ruff's license. I also added to this corpus some additional snippets for newer language features: all the `27_func_generic_` and `73_class_generic_` files, as well as `20_lambda_default_arg.py`, and added a test which runs semantic-lint over all these files. (The test doesn't assert the test-corpus files are lint-free; just that they are able to lint without a panic.)	2024-07-25 17:38:08 -07:00
Charlie Marsh	7571da8778	Preserve trailing inline comments on import-from statements (#12498 ) ## Summary Right now, in the isort comment model, there's nowhere for trailing comments on the _statement_ to go, as in: ```python from mylib import ( MyClient, MyMgmtClient, ) # some comment ``` If the comment is on the _alias_, we do preserve it, because we attach it to the alias, as in: ```python from mylib import ( MyClient, MyMgmtClient, # some comment ) ``` Similarly, if the comment is trailing on an import statement (non-`from`), we again attach it to the alias, because it can't be parenthesized, as in: ```python import foo # some comment ``` This PR adds logic to track and preserve those trailing comments. We also no longer drop several other comments, like: ```python from mylib import ( # some comment MyClient ) ``` Closes https://github.com/astral-sh/ruff/issues/12487.	2024-07-25 17:46:58 -04:00
Alex Waygood	2ceac5f868	[red-knot] Rename some methods in the module resolver (#12517 )	2024-07-25 19:28:48 +00:00
Alex Waygood	5ce80827d2	[red-knot] Refactor `path.rs` in the module resolver (#12494 )	2024-07-25 19:29:28 +01:00
Dhruv Manilawala	e047b9685a	Use docs bot email for docs publish (#12511 ) Ref: https://github.com/astral-sh/uv/pull/5369	2024-07-25 21:50:00 +05:30
Dhruv Manilawala	fc16d8d04d	Bump version to 0.5.5 (#12510 )	2024-07-25 20:17:01 +05:30
Uriya Harpeness	175e5d7b88	Add missing traceback line in `f-string-in-exception` docstring. (#12508 ) ## Summary Add missing traceback line in `f-string-in-exception` docstring. Solves https://github.com/astral-sh/ruff/issues/12504.	2024-07-25 10:22:05 -04:00
Dhruv Manilawala	c03f257ed7	Add note about the breaking change in `nvim-lspconfig` (#12507 ) Refer https://github.com/astral-sh/ruff/issues/12408	2024-07-25 14:01:16 +00:00
Dhruv Manilawala	6bbb4a28c2	Add setup docs for Zed editor (#12501 ) ## Summary This PR adds the setup documentation for using Ruff with the Zed editor. Closes: #12388	2024-07-25 13:09:17 +00:00
Micha Reiser	2ce3e3ae60	Fix the search path tests on MacOS (#12503 )	2024-07-25 08:21:38 +02:00
Charlie Marsh	2a64cccb61	Avoid applying `ignore-names` to `self` and `cls` function names (#12497 ) ## Summary Closes https://github.com/astral-sh/ruff/issues/12465.	2024-07-24 18:08:23 -04:00
Alex Waygood	928ffd6650	Ignore `NPY201` inside `except` blocks for compatibility with older numpy versions (#12490 )	2024-07-24 20:03:23 +00:00
Alex Waygood	e52be0951a	[red-knot] Improve validation for search paths (#12376 )	2024-07-24 15:02:25 +01:00
Dylan	889073578e	[flake8-bugbear] Allow singleton tuples with starred expressions in B013 (#12484 )	2024-07-24 15:19:30 +02:00
Micha Reiser	eac965ecaf	[red-knot] Watch search paths (#12407 )	2024-07-24 07:38:50 +00:00
Auguste Lalande	8659f2f4ea	[`pydoclint`] Fix documentation for `DOC501` (#12483 ) ## Summary The doc was written backwards. mb.	2024-07-24 00:08:53 -04:00
Alex Waygood	c1b292a0dc	Refactor NPY201 (#12479 )	2024-07-23 18:24:20 +01:00
Micha Reiser	3af6ccb720	Fix `Ord` of `cmp_fix` (#12471 )	2024-07-23 15:14:22 +02:00
Micha Reiser	f0fc6a95fe	[red-knot] Lazy package file discovery (#12452 ) Co-authored-by: Carl Meyer <carl@astral.sh>	2024-07-23 08:47:15 +00:00
Mateusz Sokół	f96a3c71ff	Fix NumPy 2.0 rule for `np.alltrue` and `np.sometrue` (#12473 ) Co-authored-by: Micha Reiser <micha@reiser.io>	2024-07-23 08:34:43 +00:00
Micha Reiser	b9b7deff17	Implement `upcast_mut` for new `TestDb` (#12470 )	2024-07-23 07:11:00 +00:00
Micha Reiser	40d9324f5a	[red-knot] Improved file watching (#12382 )	2024-07-23 08:18:59 +02:00
Pathompong Kwangtong	a9f8bd59b2	Add Eglot setup guide for Emacs editor (#12426 ) ## Summary The purpose of this change is to explain how to use ruff as a language server in Eglot with automatic formatting because I've struggle to use it with Eglot. I've search it online and found that there are some people also struggle too. (See [this reddit post](https://www.reddit.com/r/emacs/comments/118mo6w/eglot_automatic_formatting/) and https://github.com/astral-sh/ruff-lsp/issues/19#issuecomment-1435138828) ## Test Plan I've use this setting myself. And I will continue maintain this part as long as I use it. --------- Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>	2024-07-23 10:50:51 +05:30
Piotr Osiewicz	143e172431	Do not bail code action resolution when a quick fix is requested (#12462 ) ## Summary When working on improving Ruff integration with Zed I noticed that it errors out when we try to resolve a code action of a `QUICKFIX` kind; apparently, per @dhruvmanila we shouldn't need to resolve it, as the edit is provided in the initial response for the code action. However, it's possible for the `resolve` call to fill out other fields (such as `command`). AFAICT Helix also tries to resolve the code actions unconditionally (as in, when either `edit` or `command` is absent); so does VSC. They can still apply the quickfixes though, as they do not error out on a failed call to resolve code actions - Zed does. Following suit on Zed's side does not cut it though, as we still get a log request from Ruff for that failure (which is surfaced in the UI). There are also other language servers (such as [rust-analyzer](`c1c9e10f72/crates/rust-analyzer/src/handlers/request.rs (L1257)`)) that fill out both `command` and `edit` fields as a part of code action resolution. This PR makes the resolve calls for quickfix actions return the input value. ## Test Plan N/A	2024-07-23 10:30:03 +05:30
Auguste Lalande	b2d3a05ee4	[`flake8-async`] Fix references in documentation not displaying (#12467 ) ## Summary Fix references in documentation of several `ASYNC` rules not displaying ## Test Plan Validated documentation now displays correctly	2024-07-22 19:38:13 -04:00
Josh Cannon	ef1ca0dd38	Fix bad markdown in CONTRIBUTING.md (#12466 ) See https://github.com/astral-sh/ruff/blob/main/CONTRIBUTING.md#import-categorization	2024-07-23 00:03:30 +01:00
Carl Meyer	c7b13bb8fc	[red-knot] add cycle-free while-loop control flow (#12413 ) Add support for while-loop control flow. This doesn't yet include general support for terminals and reachability; that is wider than just while loops and belongs in its own PR. This also doesn't yet add support for cyclic definitions in loops; that comes with enough of its own complexity in Salsa that I want to handle it separately.	2024-07-22 14:27:33 -07:00
Carl Meyer	dbbe3526ef	[red-knot] add while-loop to benchmark (#12464 ) So we can get some signal from the benchmark result on https://github.com/astral-sh/ruff/pull/12413	2024-07-22 14:16:56 -07:00
Carl Meyer	f22c8ab811	[red-knot] add maybe-undefined lint rule (#12414 ) Add a lint rule to detect if a name is definitely or possibly undefined at a given usage. If I create the file `undef/main.py` with contents: ```python x = int def foo(): z return x if flag: y = x y ``` And then run `cargo run --bin red_knot -- --current-directory ../ruff-examples/undef`, I get the output: ``` Name 'z' used when not defined. Name 'flag' used when not defined. Name 'y' used when possibly not defined. ``` If I modify the file to add `y = 0` at the top, red-knot re-checks it and I get the new output: ``` Name 'z' used when not defined. Name 'flag' used when not defined. ``` Note that `int` is not flagged, since it's a builtin, and `return x` in the function scope is not flagged, since it refers to the global `x`.	2024-07-22 13:53:59 -07:00
Alex Waygood	2a8f95c437	[red-knot] Use a distinct type for module search paths in the module resolver (#12379 )	2024-07-22 19:44:27 +00:00
Dhruv Manilawala	ea2d51c2bb	Add note to include notebook files for native server (#12449 ) ## Summary Similar to https://github.com/astral-sh/ruff-vscode/pull/547 but for the online docs. Refer to https://github.com/astral-sh/ruff-vscode/issues/546 ## Preview <img width="1728" alt="Screenshot 2024-07-22 at 14 51 40" src="https://github.com/user-attachments/assets/39014278-c868-45b0-9058-42858a060fd8">	2024-07-22 21:40:30 +05:30
Micha Reiser	ed238e0c76	Fix incorrect placement of leading function comment with type params (#12447 )	2024-07-22 14:17:00 +02:00
Micha Reiser	3ace12943e	Ignore more open ai notebooks for now (#12448 )	2024-07-22 14:16:48 +02:00
Dhruv Manilawala	978909fcf4	Raise syntax error for unparenthesized generator expr in multi-argument call (#12445 ) ## Summary This PR fixes a bug to raise a syntax error when an unparenthesized generator expression is used as an argument to a call when there are more than one argument. For reference, the grammar is: ``` primary: \| ... \| primary genexp \| primary '(' [arguments] ')' \| ... genexp: \| '(' ( assignment_expression \| expression !':=') for_if_clauses ')' ``` The `genexp` requires the parenthesis as mentioned in the grammar. So, the grammar for a call expression is either a name followed by a generator expression or a name followed by a list of argument. In the former case, the parenthesis are excluded because the generator expression provides them while in the later case, the parenthesis are explicitly provided for a list of arguments which means that the generator expression requires it's own parenthesis. This was discovered in https://github.com/astral-sh/ruff/issues/12420. ## Test Plan Add test cases for valid and invalid syntax. Make sure that the parser from CPython also raises this at the parsing step: ```console $ python3.13 -m ast parser/_.py File "parser/_.py", line 1 total(1, 2, x for x in range(5), 6) ^^^^^^^^^^^^^^^^^^^ SyntaxError: Generator expression must be parenthesized $ python3.13 -m ast parser/_.py File "parser/_.py", line 1 sum(x for x in range(10), 10) ^^^^^^^^^^^^^^^^^^^^ SyntaxError: Generator expression must be parenthesized ```	2024-07-22 14:44:20 +05:30
Dhruv Manilawala	f8735e1ee8	Remove unused dependencies, sync existing versions (#12446 ) ## Summary This PR removes unused dependencies from `fuzz` crate and syncs the `similar` crate to the workspace version. This will help in resolve https://github.com/astral-sh/ruff/pull/12442. ## Test Plan Build the fuzz crate: For Mac (it requires the nightly build): ``` cargo +nightly fuzz build ```	2024-07-22 10:49:05 +05:30
renovate[bot]	d70ceb6a56	Update Rust crate uuid to v1.10.0 (#12444 )	2024-07-21 21:50:53 -04:00
renovate[bot]	fc7d9e95b8	Update Rust crate tracing-tree to 0.4.0 (#12443 )	2024-07-21 21:50:46 -04:00
renovate[bot]	b578fca9cb	Update NPM Development dependencies (#12441 )	2024-07-21 21:50:32 -04:00
renovate[bot]	8d3146c2b2	Update pre-commit hook astral-sh/ruff-pre-commit to v0.5.4 (#12440 )	2024-07-21 21:50:27 -04:00
renovate[bot]	fa5c841154	Update Rust crate thiserror to v1.0.63 (#12437 )	2024-07-21 21:49:42 -04:00
renovate[bot]	f8fcbc19d9	Update dependency react-resizable-panels to v2.0.22 (#12439 )	2024-07-21 21:49:33 -04:00
renovate[bot]	97fdd48208	Update Rust crate toml to v0.8.15 (#12438 )	2024-07-21 21:49:23 -04:00
renovate[bot]	731ed2e40b	Update Rust crate syn to v2.0.72 (#12436 )	2024-07-21 21:49:16 -04:00
Auguste Lalande	3a742c17f8	[`pydoclint`] Fix `DOC501` panic #12428 (#12435 ) ## Summary Fix panic reported in #12428. Where a string would sometimes get split within a character boundary. This bypasses the need to split the string. This does not guarantee the correct formatting of the docstring, but neither did the previous implementation. Resolves #12428 ## Test Plan Test case added to fixture	2024-07-21 19:30:06 +00:00
TomerBin	053243635c	[`fastapi`] Implement `FAST001` (`fastapi-redundant-response-model`) and `FAST002` (`fastapi-non-annotated-dependency`) (#11579 ) ## Summary Implements ruff specific role for fastapi routes, and its autofix. ## Test Plan `cargo test` / `cargo insta review`	2024-07-21 18:28:10 +00:00
Ivan Carvalho	82355712c3	Add IBM to Who is Using ruff (#12433 ) <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary Just updating the README to reflect that IBM has been using ruff for a year already: https://github.com/Qiskit/qiskit/pull/10116.	2024-07-21 11:17:24 -05:00
Auguste Lalande	4bc73dd87e	[`pydoclint`] Implement `docstring-missing-exception` and `docstring-extraneous-exception` (`DOC501`, `DOC502`) (#11471 ) ## Summary These are the first rules implemented as part of #458, but I plan to implement more. Specifically, this implements `docstring-missing-exception` which checks for raised exceptions not documented in the docstring, and `docstring-extraneous-exception` which checks for exceptions in the docstring not present in the body. ## Test Plan Test fixtures added for both google and numpy style.	2024-07-20 19:41:51 +00:00
T-256	53b84ab054	Cleanup redundant spaces from changelog (#12424 )	2024-07-20 17:46:15 +00:00
Charlie Marsh	3664f85f45	Bump version to v0.5.4 (#12423 )	2024-07-20 17:28:13 +00:00
Charlie Marsh	2c1926beeb	Insert parentheses for multi-argument generators (#12422 ) ## Summary Closes https://github.com/astral-sh/ruff/issues/12420.	2024-07-20 16:41:55 +00:00
Charlie Marsh	4bcc96ae51	Avoid shadowing diagnostics for `@override` methods (#12415 ) Closes https://github.com/astral-sh/ruff/issues/12412.	2024-07-19 21:32:33 -04:00
FishAlchemist	c0a2b49bac	Fix the Github link error for Neovim in the setup for editors in the docs. (#12410 ) ## Summary Fix Github link error for Neovim setup editors . ## Test Plan Click Neovim Github link with mkdocs on local.	2024-07-19 16:24:12 -04:00
Sashko	ca22248628	Update docs Settings output-format default (#12409 ) ## Update docs Settings output-format default Fixes https://github.com/astral-sh/ruff/issues/12350 ## Test Plan Run all automation mentioned here `fe04f2b09d/CONTRIBUTING.md (development)` Manually verified changes in the generated MkDocs site. Co-authored-by: Oleksandr Zavertniev <oleksandr.zavertniev@yellowbrick.com>	2024-07-19 17:51:46 +00:00
Alex Waygood	d8cf8ac2ef	[red-knot] Resolve symbols from `builtins.pyi` in the stdlib if they cannot be found in other scopes (#12390 ) Co-authored-by: Carl Meyer <carl@astral.sh>	2024-07-19 17:44:56 +01:00
Carl Meyer	1c7b84059e	[red-knot] fix incremental benchmark (#12400 ) We should write `BAR_CODE` to `bar.py`, not to `foo.py`.	2024-07-19 08:32:37 -07:00
Carl Meyer	f82bb67555	[red-knot] trace file when inferring types (#12401 ) When poring over traces, the ones that just include a definition or symbol or expression ID aren't very useful, because you don't know which file it comes from. This adds that information to the trace. I guess the downside here is that if calling `.file(db)` on a scope/definition/expression would execute other traced code, it would be marked as outside the span? I don't think that's a concern, because I don't think a simple field access on a tracked struct should ever execute our code. If I'm wrong and this is a problem, it seems like the tracing crate has this feature where you can record a field as `tracing::field::Empty` and then fill in its value later with `span.record(...)`, but when I tried this it wasn't working for me, not sure why. I think there's a lot more we can do to make our tracing output more useful for debugging (e.g. record an event whenever a definition/symbol/expression/use id is created with the details of that definition/symbol/expression/use), this is just dipping my toes in the water.	2024-07-19 07:13:51 -07:00
				`@@ -0,0 +1,2 @@`
				{{0:1},{1:2},{2:3},{3:4},{4:5},{5:6},{6:7},{7:8},{8:9},{9:10},{10:11},{11:12},{12:13},{13:14},{14:15},{15:16},{16:17},{17:18},{18:19},{19:20},{20:21},{21:22},{22:23},{23:24},{24:25},{25:26},{26:27},{27:28},{28:29},{29:30},{30:31},{31:32},{32:33},{33:34},{34:35},{35:36},{36:37},{37:38},{38:39},{39:40},{40:41},{41:42},{42:43},{43:44},{44:45},{45:46},{46:47},{47:48},{48:49},{49:50},{50:51},{51:52},{52:53},{53:54},{54:55},{55:56},{56:57},{57:58},{58:59},{59:60},{60:61},{61:62},{62:63},{63:64},{64:65},{65:66},{66:67},{67:68},{68:69},{69:70},{70:71},{71:72},{72:73},{73:74},{74:75},{75:76},{76:77},{77:78},{78:79},{79:80},{80:81},{81:82},{82:83},{83:84},{84:85},{85:86},{86:87},{87:88},{88:89},{89:90},{90:91},{91:92},{92:93},{93:94},{94:95},{95:96},{96:97},{97:98},{98:99},{99:100},{100:101},{101:102},{102:103},{103:104},{104:105},{105:106},{106:107},{107:108},{108:109},{109:110},{110:111},{111:112},{112:113},{113:114},{114:115},{115:116},{116:117},{117:118},{118:119},{119:120},{120:121},{121:122},{122:123},{123:124},{124:125},{125:126},{126:127},{127:128},{128:129},{129:130},{130:131},{131:132},{132:133},{133:134},{134:135},{135:136},{136:137},{137:138},{138:139},{139:140},{140:141},{141:142},{142:143},{143:144},{144:145},{145:146},{146:147},{147:148},{148:149},{149:150},{150:151},{151:152},{152:153},{153:154},{154:155},{155:156},{156:157},{157:158},{158:159},{159:160},{160:161},{161:162},{162:163},{163:164},{164:165},{165:166},{166:167},{167:168},{168:169},{169:170},{170:171},{171:172},{172:173},{173:174},{174:175},{175:176},{176:177},{177:178},{178:179},{179:180},{180:181},{181:182},{182:183},{183:184},{184:185},{185:186},{186:187},{187:188},{188:189},{189:190},{190:191},{191:192},{192:193},{193:194},{194:195},{195:196},{196:197},{197:198},{198:199},{199:200},{200:201},{201:202},{202:203},{203:204},{204:205},{205:206},{206:207},{207:208},{208:209},{209:210},{210:211},{211:212},{212:213},{213:214},{214:215},{215:216},{216:217},{217:218},{218:219},{219:220},{220:221},{221:222},{222:223},{223:224},{224:225},{225:226},{226:227},{227:228},{228:229},{229:230},{230:231},{231:232},{232:233},{233:234},{234:235},{235:236},{236:237},{237:238},{238:239},{239:240},{240:241},{241:242},{242:243},{243:244},{244:245},{245:246},{246:247},{247:248},{248:249},{249:250},{250:251},{251:252},{252:253},{253:254},{254:255},{255:256},{256:257},{257:258},{258:259},{259:260}}
				`@@ -0,0 +1 @@`
				`l = [a, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31]`