Bump version to 0.0.29

.github/workflows/release.yaml

@@ -1,6 +1,8 @@
 name: Release
 
 on:
+  pull_request:
+    branches: [main]
   create:
     tags:
       - v*
@@ -127,7 +129,7 @@ jobs:
         with:
           target: ${{ matrix.target }}
           manylinux: auto
-          args: --release --out dist
+          args: --no-default-features --release --out dist
           maturin-version: "v0.13.0"
       - uses: uraimo/run-on-arch-action@v2.0.5
         if: matrix.target != 'ppc64'

.pre-commit-config.yaml

@@ -1,5 +1,5 @@
 repos:
   - repo: https://github.com/charliermarsh/ruff
-    rev: v0.0.27
+    rev: v0.0.29
     hooks:
       - id: lint

Cargo.lock

@@ -1744,7 +1744,7 @@ dependencies = [
 
 [[package]]
 name = "ruff"
-version = "0.0.27"
+version = "0.0.29"
 dependencies = [
  "anyhow",
  "bincode",
@@ -1787,7 +1787,7 @@ dependencies = [
 [[package]]
 name = "rustpython-ast"
 version = "0.1.0"
-source = "git+https://github.com/charliermarsh/RustPython.git?rev=ff6112d7c70729be76eaad8c9e5b8ef24d13de99#ff6112d7c70729be76eaad8c9e5b8ef24d13de99"
+source = "git+https://github.com/charliermarsh/RustPython.git?rev=8cc3d23ddaa6339bf56608adaeefabff3ad329e7#8cc3d23ddaa6339bf56608adaeefabff3ad329e7"
 dependencies = [
  "num-bigint",
  "rustpython-compiler-core",
@@ -1796,7 +1796,7 @@ dependencies = [
 [[package]]
 name = "rustpython-compiler-core"
 version = "0.1.2"
-source = "git+https://github.com/charliermarsh/RustPython.git?rev=ff6112d7c70729be76eaad8c9e5b8ef24d13de99#ff6112d7c70729be76eaad8c9e5b8ef24d13de99"
+source = "git+https://github.com/charliermarsh/RustPython.git?rev=8cc3d23ddaa6339bf56608adaeefabff3ad329e7#8cc3d23ddaa6339bf56608adaeefabff3ad329e7"
 dependencies = [
  "bincode",
  "bitflags",
@@ -1813,7 +1813,7 @@ dependencies = [
 [[package]]
 name = "rustpython-parser"
 version = "0.1.2"
-source = "git+https://github.com/charliermarsh/RustPython.git?rev=ff6112d7c70729be76eaad8c9e5b8ef24d13de99#ff6112d7c70729be76eaad8c9e5b8ef24d13de99"
+source = "git+https://github.com/charliermarsh/RustPython.git?rev=8cc3d23ddaa6339bf56608adaeefabff3ad329e7#8cc3d23ddaa6339bf56608adaeefabff3ad329e7"
 dependencies = [
  "ahash",
  "anyhow",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ruff"
-version = "0.0.27"
+version = "0.0.29"
 edition = "2021"
 
 [lib]
@@ -25,13 +25,17 @@ notify = { version = "4.0.17" }
 once_cell = { version = "1.13.1" }
 rayon = { version = "1.5.3" }
 regex = { version = "1.6.0" }
-rustpython-parser = { features = ["lalrpop"], git = "https://github.com/charliermarsh/RustPython.git", rev = "ff6112d7c70729be76eaad8c9e5b8ef24d13de99" }
+rustpython-parser = { features = ["lalrpop"], git = "https://github.com/charliermarsh/RustPython.git", rev = "8cc3d23ddaa6339bf56608adaeefabff3ad329e7" }
 serde = { version = "1.0.143", features = ["derive"] }
 serde_json = { version = "1.0.83" }
 toml = { version = "0.5.9" }
-update-informer = { version = "0.5.0", default_features = false, features = ["pypi"] }
+update-informer = { version = "0.5.0", default_features = false, features = ["pypi"], optional = true }
 walkdir = { version = "2.3.2" }
 
+[features]
+default = ["update-informer"]
+update-informer = ["dep:update-informer"]
+
 [profile.release]
 panic = "abort"
 lto = "thin"

README.md

@@ -57,7 +57,7 @@ ruff also works with [Pre-Commit](https://pre-commit.com) (requires Cargo on sys
 ```yaml
 repos:
 - repo: https://github.com/charliermarsh/ruff
-  rev: v0.0.27
+  rev: v0.0.29
   hooks:
     - id: lint
 ```
@@ -86,7 +86,7 @@ ruff path/to/code/ --select F401 F403
 See `ruff --help` for more:
 
 ```shell
-ruff (v0.0.27)
+ruff (v0.0.29)
 An extremely fast Python linter.
 
 USAGE:

resources/test/fixtures/E731.py

@@ -1,2 +1,6 @@
+from typing import Callable, Iterable
+
 a = lambda x: x**2
 b = map(lambda x: 2 * x, range(3))
+c: Callable = lambda x: x**2
+d: Iterable = map(lambda x: 2 * x, range(3))

resources/test/fixtures/F821.py

@@ -33,6 +33,7 @@ def ternary_optarg(prec, exp_range, itr):
 class Foo:
     CLASS_VAR = 1
     REFERENCES_CLASS_VAR = {"CLASS_VAR": CLASS_VAR}
+    ANNOTATED_CLASS_VAR: int = 2
 
 
 class Class:
@@ -40,7 +41,11 @@ class Class:
         # TODO(charlie): This should be recognized as a defined variable.
         Class  # noqa: F821
 
+
 try:
     x = 1 / 0
 except Exception as e:
     print(e)
+
+
+y: int = 1

src/check_ast.rs

@@ -391,7 +391,22 @@ impl Visitor for Checker<'_> {
                     }
                 }
             }
-            StmtKind::Delete { .. } | StmtKind::AnnAssign { .. } => {
+            StmtKind::AnnAssign { value, .. } => {
+                self.seen_non_import = true;
+                if self
+                    .settings
+                    .select
+                    .contains(CheckKind::DoNotAssignLambda.code())
+                {
+                    if let Some(v) = value {
+                        if let ExprKind::Lambda { .. } = v.node {
+                            self.checks
+                                .push(Check::new(CheckKind::DoNotAssignLambda, stmt.location));
+                        }
+                    }
+                }
+            }
+            StmtKind::Delete { .. } => {
                 self.seen_non_import = true;
             }
             _ => {}

src/linter.rs

@@ -268,11 +268,18 @@ mod tests {
             },
             &autofix::Mode::Generate,
         )?;
-        let expected = vec![Check {
-            kind: CheckKind::DoNotAssignLambda,
-            location: Location::new(1, 1),
-            fix: None,
-        }];
+        let expected = vec![
+            Check {
+                kind: CheckKind::DoNotAssignLambda,
+                location: Location::new(3, 1),
+                fix: None,
+            },
+            Check {
+                kind: CheckKind::DoNotAssignLambda,
+                location: Location::new(5, 1),
+                fix: None,
+            },
+        ];
 
         assert_eq!(actual.len(), expected.len());
         for i in 0..actual.len() {

src/main.rs

@@ -12,13 +12,13 @@ use rayon::prelude::*;
 use walkdir::DirEntry;
 
 use ::ruff::checks::CheckCode;
+use ::ruff::checks::CheckKind;
 use ::ruff::fs::iter_python_files;
 use ::ruff::linter::lint_path;
 use ::ruff::logging::set_up_logging;
 use ::ruff::message::Message;
 use ::ruff::settings::Settings;
 use ::ruff::tell_user;
-use ruff::checks::CheckKind;
 
 const CARGO_PKG_NAME: &str = env!("CARGO_PKG_NAME");
 const CARGO_PKG_VERSION: &str = env!("CARGO_PKG_VERSION");
@@ -55,6 +55,30 @@ struct Cli {
     ignore: Vec<CheckCode>,
 }
 
+#[cfg(feature = "update-informer")]
+fn check_for_updates() {
+    use update_informer::{registry, Check};
+
+    let informer = update_informer::new(registry::PyPI, CARGO_PKG_NAME, CARGO_PKG_VERSION);
+
+    if let Some(new_version) = informer.check_version().ok().flatten() {
+        let msg = format!(
+            "A new version of {pkg_name} is available: v{pkg_version} -> {new_version}",
+            pkg_name = CARGO_PKG_NAME.italic().cyan(),
+            pkg_version = CARGO_PKG_VERSION,
+            new_version = new_version.to_string().green()
+        );
+
+        let cmd = format!(
+            "Run to update: {cmd} {pkg_name}",
+            cmd = "pip3 install --upgrade".green(),
+            pkg_name = CARGO_PKG_NAME.green()
+        );
+
+        println!("\n{msg}\n{cmd}");
+    }
+}
+
 fn run_once(
     files: &[PathBuf],
     settings: &Settings,
@@ -210,6 +234,7 @@ fn inner_main() -> Result<ExitCode> {
             report_once(&messages)?;
         }
 
+        #[cfg(feature = "update-informer")]
         check_for_updates();
 
         if !messages.is_empty() && !cli.exit_zero {
@@ -220,29 +245,6 @@ fn inner_main() -> Result<ExitCode> {
     Ok(ExitCode::SUCCESS)
 }
 
-fn check_for_updates() {
-    use update_informer::{registry, Check};
-
-    let informer = update_informer::new(registry::PyPI, CARGO_PKG_NAME, CARGO_PKG_VERSION);
-
-    if let Some(new_version) = informer.check_version().ok().flatten() {
-        let msg = format!(
-            "A new version of {pkg_name} is available: v{pkg_version} -> {new_version}",
-            pkg_name = CARGO_PKG_NAME.italic().cyan(),
-            pkg_version = CARGO_PKG_VERSION,
-            new_version = new_version.to_string().green()
-        );
-
-        let cmd = format!(
-            "Run to update: {cmd} {pkg_name}",
-            cmd = "pip3 install --upgrade".green(),
-            pkg_name = CARGO_PKG_NAME.green()
-        );
-
-        println!("\n{msg}\n{cmd}");
-    }
-}
-
 fn main() -> ExitCode {
     match inner_main() {
         Ok(code) => code,