Bump version to 0.0.37

.github/workflows/release.yaml

@@ -16,7 +16,7 @@ env:
   PYTHON_VERSION: "3.7" # to build abi3 wheels
 
 jobs:
-  macos:
+  macos-x86_64:
     runs-on: macos-latest
     steps:
       - uses: actions/checkout@v3
@@ -39,6 +39,25 @@ jobs:
       - name: Install built wheel - x86_64
         run: |
           pip install dist/${{ env.PACKAGE_NAME }}-*.whl --force-reinstall
+      - name: Upload wheels
+        uses: actions/upload-artifact@v2
+        with:
+          name: wheels
+          path: dist
+  macos-universal:
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-python@v4
+        with:
+          python-version: ${{ env.PYTHON_VERSION }}
+          architecture: x64
+      - name: Install Rust toolchain
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          profile: minimal
+          default: true
       - name: Build wheels - universal2
         uses: messense/maturin-action@v1
         with:
@@ -261,7 +280,8 @@ jobs:
     name: Release
     runs-on: ubuntu-latest
     needs:
-      - macos
+      - macos-universal
+      - macos-x86_64
       - windows
       - linux
       - linux-cross

.pre-commit-config.yaml

@@ -1,5 +1,5 @@
 repos:
   - repo: https://github.com/charliermarsh/ruff
-    rev: v0.0.35
+    rev: v0.0.37
     hooks:
       - id: lint

Cargo.lock

@@ -1744,7 +1744,7 @@ dependencies = [
 
 [[package]]
 name = "ruff"
-version = "0.0.35"
+version = "0.0.37"
 dependencies = [
  "anyhow",
  "bincode",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ruff"
-version = "0.0.35"
+version = "0.0.37"
 edition = "2021"
 
 [lib]

README.md

@@ -57,7 +57,7 @@ ruff also works with [Pre-Commit](https://pre-commit.com) (requires Cargo on sys
 ```yaml
 repos:
 - repo: https://github.com/charliermarsh/ruff
-  rev: v0.0.35
+  rev: v0.0.37
   hooks:
     - id: lint
 ```
@@ -86,7 +86,7 @@ ruff path/to/code/ --select F401 F403
 See `ruff --help` for more:
 
 ```shell
-ruff (v0.0.35)
+ruff (v0.0.37)
 An extremely fast Python linter.
 
 USAGE:
@@ -123,18 +123,15 @@ ruff's goal is to achieve feature-parity with Flake8 when used (1) without any p
 (2) alongside Black, and (3) on Python 3 code. (Using Black obviates the need for many of Flake8's
 stylistic checks; limiting to Python 3 obviates the need for certain compatibility checks.)
 
-Under those conditions, Flake8 implements about 58 rules, give or take. At time of writing, ruff
-implements 33 rules. (Note that these 33 rules likely cover a disproportionate share of errors:
+Under those conditions, Flake8 implements about 60 rules, give or take. At time of writing, ruff
+implements 38 rules. (Note that these 38 rules likely cover a disproportionate share of errors:
 unused imports, undefined variables, etc.)
 
-Of the unimplemented rules, ruff is missing:
+The unimplemented rules are tracked in #170, and include:
 
-- 15 rules related to string `.format` calls.
-- 6 rules related to misplaced `yield`, `break`, and `return` statements.
-- 3 rules related to syntax errors in doctests and annotations.
-- 2 rules related to redefining unused names.
-
-...along with a variety of others that don't fit neatly into any specific category.
+- 14 rules related to string `.format` calls.
+- 1 rule related to parsing and syntax.
+- 6 logical rules.
 
 Beyond rule-set parity, ruff suffers from the following limitations vis-à-vis Flake8:
 
@@ -147,19 +144,21 @@ Beyond rule-set parity, ruff suffers from the following limitations vis-à-vis F
 | Code | Name | Message |
 | ---- | ----- | ------- |
 | E402 | ModuleImportNotAtTopOfFile | Module level import not at top of file |
-| E501 | LineTooLong | Line too long |
+| E501 | LineTooLong | Line too long (89 > 88 characters) |
 | E711 | NoneComparison | Comparison to `None` should be `cond is None` |
 | E712 | TrueFalseComparison | Comparison to `True` should be `cond is True` |
 | E713 | NotInTest | Test for membership should be `not in` |
 | E714 | NotIsTest | Test for object identity should be `is not` |
+| E722 | DoNotUseBareExcept | Do not use bare `except` |
 | E731 | DoNotAssignLambda | Do not assign a lambda expression, use a def |
 | E741 | AmbiguousVariableName | ambiguous variable name '...' |
 | E742 | AmbiguousClassName | ambiguous class name '...' |
 | E743 | AmbiguousFunctionName | ambiguous function name '...' |
 | E902 | IOError | No such file or directory: `...` |
 | F401 | UnusedImport | `...` imported but unused |
-| F403 | ImportStarUsage | Unable to detect undefined names |
+| F403 | ImportStarUsage | `from ... import *` used; unable to detect undefined names |
 | F404 | LateFutureImport | from __future__ imports must occur at the beginning of the file |
+| F406 | ImportStarNotPermitted | `from ... import *` only allowed at module level |
 | F407 | FutureFeatureNotDefined | future feature '...' is not defined |
 | F541 | FStringMissingPlaceholders | f-string without any placeholders |
 | F601 | MultiValueRepeatedKeyLiteral | Dictionary key literal repeated |
@@ -168,9 +167,12 @@ Beyond rule-set parity, ruff suffers from the following limitations vis-à-vis F
 | F622 | TwoStarredExpressions | two starred expressions in assignment |
 | F631 | AssertTuple | Assert test is a non-empty tuple, which is always `True` |
 | F634 | IfTuple | If test is a tuple, which is always `True` |
+| F701 | BreakOutsideLoop | `break` outside loop |
+| F702 | ContinueOutsideLoop | `continue` not properly in loop |
 | F704 | YieldOutsideFunction | a `yield` or `yield from` statement outside of a function/method |
 | F706 | ReturnOutsideFunction | a `return` statement outside of a function/method |
 | F707 | DefaultExceptNotLast | an `except:` block as not the last exception handler |
+| F722 | ForwardAnnotationSyntaxError | syntax error in forward annotation '...' |
 | F821 | UndefinedName | Undefined name `...` |
 | F822 | UndefinedExport | Undefined name `...` in `__all__` |
 | F823 | UndefinedLocal | Local variable `...` referenced before assignment |

examples/generate_rules_table.rs

@@ -3,20 +3,25 @@ use ruff::checks::{CheckKind, RejectedCmpop};
 
 fn main() {
     let mut check_kinds: Vec<CheckKind> = vec![
-        CheckKind::AmbiguousVariableName("...".to_string()),
         CheckKind::AmbiguousClassName("...".to_string()),
         CheckKind::AmbiguousFunctionName("...".to_string()),
+        CheckKind::AmbiguousVariableName("...".to_string()),
         CheckKind::AssertTuple,
+        CheckKind::BreakOutsideLoop,
+        CheckKind::ContinueOutsideLoop,
         CheckKind::DefaultExceptNotLast,
         CheckKind::DoNotAssignLambda,
+        CheckKind::DoNotUseBareExcept,
         CheckKind::DuplicateArgumentName,
+        CheckKind::ForwardAnnotationSyntaxError("...".to_string()),
         CheckKind::FStringMissingPlaceholders,
         CheckKind::FutureFeatureNotDefined("...".to_string()),
         CheckKind::IOError("...".to_string()),
         CheckKind::IfTuple,
-        CheckKind::ImportStarUsage,
+        CheckKind::ImportStarNotPermitted("...".to_string()),
+        CheckKind::ImportStarUsage("...".to_string()),
         CheckKind::LateFutureImport,
-        CheckKind::LineTooLong,
+        CheckKind::LineTooLong(89, 88),
         CheckKind::ModuleImportNotAtTopOfFile,
         CheckKind::MultiValueRepeatedKeyLiteral,
         CheckKind::MultiValueRepeatedKeyVariable("...".to_string()),

pyproject.toml

@@ -19,10 +19,12 @@ classifiers = [
 ]
 author = "Charlie Marsh"
 author_email = "charlie.r.marsh@gmail.com"
-url = "https://github.com/charliermarsh/ruff"
 description = "An extremely fast Python linter, written in Rust."
 requires-python = ">=3.7"
 
+[project.urls]
+repository = "https://github.com/charliermarsh/ruff"
+
 [build-system]
 requires = ["maturin>=0.13,<0.14"]
 build-backend = "maturin"

resources/test/fixtures/E722.py

@@ -0,0 +1,9 @@
+try:
+    pass
+except:
+    pass
+
+try:
+    pass
+except Exception:
+    pass

resources/test/fixtures/E741.py

@@ -70,3 +70,6 @@ try:
     pass
 except ValueError as l:
     pass
+
+if (l := 5) > 0:
+    pass

resources/test/fixtures/F406.py

@@ -0,0 +1,9 @@
+from F634 import *
+
+
+def f():
+    from F634 import *
+
+
+class F:
+    from F634 import *

resources/test/fixtures/F701.py

@@ -0,0 +1,23 @@
+for i in range(10):
+    break
+else:
+    break
+
+i = 0
+while i < 10:
+    i += 1
+    break
+
+
+def f():
+    for i in range(10):
+        break
+
+    break
+
+
+class Foo:
+    break
+
+
+break

resources/test/fixtures/F702.py

@@ -0,0 +1,23 @@
+for i in range(10):
+    continue
+else:
+    continue
+
+i = 0
+while i < 10:
+    i += 1
+    continue
+
+
+def f():
+    for i in range(10):
+        continue
+
+    continue
+
+
+class Foo:
+    continue
+
+
+continue

resources/test/fixtures/F722.py

@@ -0,0 +1,10 @@
+class A:
+    pass
+
+
+def f() -> "A":
+    pass
+
+
+def g() -> "///":
+    pass

resources/test/fixtures/pyproject.toml

@@ -8,6 +8,7 @@ select = [
     "E712",
     "E713",
     "E714",
+    "E722",
     "E731",
     "E741",
     "E742",
@@ -16,6 +17,7 @@ select = [
     "F401",
     "F403",
     "F404",
+    "F406",
     "F407",
     "F541",
     "F601",
@@ -24,9 +26,12 @@ select = [
     "F622",
     "F631",
     "F634",
+    "F701",
+    "F702",
     "F704",
     "F706",
     "F707",
+    "F722",
     "F821",
     "F822",
     "F823",

src/ast/checks.rs

@@ -3,7 +3,7 @@ use std::collections::BTreeSet;
 use itertools::izip;
 use rustpython_parser::ast::{
     Arg, Arguments, Cmpop, Constant, Excepthandler, ExcepthandlerKind, Expr, ExprKind, Keyword,
-    Location, Stmt, Unaryop,
+    Location, Stmt, StmtKind, Unaryop,
 };
 
 use crate::ast::operations::SourceCodeLocator;
@@ -468,3 +468,77 @@ pub fn check_starred_expressions(
 
     None
 }
+
+/// Check BreakOutsideLoop compliance.
+pub fn check_break_outside_loop(
+    stmt: &Stmt,
+    parents: &[&Stmt],
+    parent_stack: &[usize],
+) -> Option<Check> {
+    let mut allowed: bool = false;
+    let mut parent = stmt;
+    for index in parent_stack.iter().rev() {
+        let child = parent;
+        parent = parents[*index];
+        match &parent.node {
+            StmtKind::For { orelse, .. }
+            | StmtKind::AsyncFor { orelse, .. }
+            | StmtKind::While { orelse, .. } => {
+                if !orelse.contains(child) {
+                    allowed = true;
+                    break;
+                }
+            }
+
+            StmtKind::FunctionDef { .. }
+            | StmtKind::AsyncFunctionDef { .. }
+            | StmtKind::ClassDef { .. } => {
+                break;
+            }
+            _ => {}
+        }
+    }
+
+    if !allowed {
+        Some(Check::new(CheckKind::BreakOutsideLoop, stmt.location))
+    } else {
+        None
+    }
+}
+
+/// Check ContinueOutsideLoop compliance.
+pub fn check_continue_outside_loop(
+    stmt: &Stmt,
+    parents: &[&Stmt],
+    parent_stack: &[usize],
+) -> Option<Check> {
+    let mut allowed: bool = false;
+    let mut parent = stmt;
+    for index in parent_stack.iter().rev() {
+        let child = parent;
+        parent = parents[*index];
+        match &parent.node {
+            StmtKind::For { orelse, .. }
+            | StmtKind::AsyncFor { orelse, .. }
+            | StmtKind::While { orelse, .. } => {
+                if !orelse.contains(child) {
+                    allowed = true;
+                    break;
+                }
+            }
+
+            StmtKind::FunctionDef { .. }
+            | StmtKind::AsyncFunctionDef { .. }
+            | StmtKind::ClassDef { .. } => {
+                break;
+            }
+            _ => {}
+        }
+    }
+
+    if !allowed {
+        Some(Check::new(CheckKind::ContinueOutsideLoop, stmt.location))
+    } else {
+        None
+    }
+}

src/check_ast.rs

@@ -194,6 +194,24 @@ where
                     }));
                 }
             }
+            StmtKind::Break => {
+                if self.settings.select.contains(&CheckCode::F701) {
+                    if let Some(check) =
+                        checks::check_break_outside_loop(stmt, &self.parents, &self.parent_stack)
+                    {
+                        self.checks.push(check);
+                    }
+                }
+            }
+            StmtKind::Continue => {
+                if self.settings.select.contains(&CheckCode::F702) {
+                    if let Some(check) =
+                        checks::check_continue_outside_loop(stmt, &self.parents, &self.parent_stack)
+                    {
+                        self.checks.push(check);
+                    }
+                }
+            }
             StmtKind::FunctionDef {
                 name,
                 decorator_list,
@@ -430,8 +448,25 @@ where
                         );
 
                         if self.settings.select.contains(&CheckCode::F403) {
-                            self.checks
-                                .push(Check::new(CheckKind::ImportStarUsage, stmt.location));
+                            self.checks.push(Check::new(
+                                CheckKind::ImportStarUsage(
+                                    module.clone().unwrap_or_else(|| "module".to_string()),
+                                ),
+                                stmt.location,
+                            ));
+                        }
+
+                        if self.settings.select.contains(&CheckCode::F406) {
+                            let scope = &self.scopes
+                                [*(self.scope_stack.last().expect("No current scope found."))];
+                            if !matches!(scope.kind, ScopeKind::Module) {
+                                self.checks.push(Check::new(
+                                    CheckKind::ImportStarNotPermitted(
+                                        module.clone().unwrap_or_else(|| "module".to_string()),
+                                    ),
+                                    stmt.location,
+                                ));
+                            }
                         }
                     } else {
                         let binding = Binding {
@@ -813,20 +848,45 @@ where
 
     fn visit_excepthandler(&mut self, excepthandler: &'b Excepthandler) {
         match &excepthandler.node {
-            ExcepthandlerKind::ExceptHandler { name, .. } => match name {
-                Some(name) => {
-                    if self.settings.select.contains(&CheckCode::E741) {
-                        if let Some(check) =
-                            checks::check_ambiguous_variable_name(name, excepthandler.location)
-                        {
-                            self.checks.push(check);
+            ExcepthandlerKind::ExceptHandler { type_, name, .. } => {
+                if self.settings.select.contains(&CheckCode::E722) && type_.is_none() {
+                    self.checks.push(Check::new(
+                        CheckKind::DoNotUseBareExcept,
+                        excepthandler.location,
+                    ));
+                }
+                match name {
+                    Some(name) => {
+                        if self.settings.select.contains(&CheckCode::E741) {
+                            if let Some(check) =
+                                checks::check_ambiguous_variable_name(name, excepthandler.location)
+                            {
+                                self.checks.push(check);
+                            }
                         }
-                    }
-                    let scope =
-                        &self.scopes[*(self.scope_stack.last().expect("No current scope found."))];
-                    if scope.values.contains_key(name) {
+                        let scope = &self.scopes
+                            [*(self.scope_stack.last().expect("No current scope found."))];
+                        if scope.values.contains_key(name) {
+                            let parent = self.parents
+                                [*(self.parent_stack.last().expect("No parent found."))];
+                            self.handle_node_store(
+                                &Expr::new(
+                                    excepthandler.location,
+                                    ExprKind::Name {
+                                        id: name.to_string(),
+                                        ctx: ExprContext::Store,
+                                    },
+                                ),
+                                parent,
+                            );
+                            self.parents.push(parent);
+                        }
+
                         let parent =
                             self.parents[*(self.parent_stack.last().expect("No parent found."))];
+                        let scope = &self.scopes
+                            [*(self.scope_stack.last().expect("No current scope found."))];
+                        let definition = scope.values.get(name).cloned();
                         self.handle_node_store(
                             &Expr::new(
                                 excepthandler.location,
@@ -838,45 +898,29 @@ where
                             parent,
                         );
                         self.parents.push(parent);
-                    }
 
-                    let parent =
-                        self.parents[*(self.parent_stack.last().expect("No parent found."))];
-                    let scope =
-                        &self.scopes[*(self.scope_stack.last().expect("No current scope found."))];
-                    let definition = scope.values.get(name).cloned();
-                    self.handle_node_store(
-                        &Expr::new(
-                            excepthandler.location,
-                            ExprKind::Name {
-                                id: name.to_string(),
-                                ctx: ExprContext::Store,
-                            },
-                        ),
-                        parent,
-                    );
-                    self.parents.push(parent);
+                        walk_excepthandler(self, excepthandler);
 
-                    walk_excepthandler(self, excepthandler);
+                        let scope = &mut self.scopes
+                            [*(self.scope_stack.last().expect("No current scope found."))];
+                        if let Some(binding) = &scope.values.remove(name) {
+                            if self.settings.select.contains(&CheckCode::F841)
+                                && binding.used.is_none()
+                            {
+                                self.checks.push(Check::new(
+                                    CheckKind::UnusedVariable(name.to_string()),
+                                    excepthandler.location,
+                                ));
+                            }
+                        }
 
-                    let scope = &mut self.scopes
-                        [*(self.scope_stack.last().expect("No current scope found."))];
-                    if let Some(binding) = &scope.values.remove(name) {
-                        if self.settings.select.contains(&CheckCode::F841) && binding.used.is_none()
-                        {
-                            self.checks.push(Check::new(
-                                CheckKind::UnusedVariable(name.to_string()),
-                                excepthandler.location,
-                            ));
+                        if let Some(binding) = definition {
+                            scope.values.insert(name.to_string(), binding);
                         }
                     }
-
-                    if let Some(binding) = definition {
-                        scope.values.insert(name.to_string(), binding);
-                    }
+                    None => walk_excepthandler(self, excepthandler),
                 }
-                None => walk_excepthandler(self, excepthandler),
-            },
+            }
         }
     }
 
@@ -1137,6 +1181,11 @@ impl<'a> Checker<'a> {
             if let Ok(mut expr) = parser::parse_expression(expression, path) {
                 relocate_expr(&mut expr, location);
                 allocator.push(expr);
+            } else if self.settings.select.contains(&CheckCode::F722) {
+                self.checks.push(Check::new(
+                    CheckKind::ForwardAnnotationSyntaxError(expression.to_string()),
+                    location,
+                ));
             }
         }
         for expr in allocator {

src/check_lines.rs

@@ -1,11 +1,11 @@
 use rustpython_parser::ast::Location;
 
-use crate::checks::{Check, CheckKind};
+use crate::checks::{Check, CheckCode, CheckKind};
 use crate::settings::Settings;
 
 /// Whether the given line is too long and should be reported.
-fn should_enforce_line_length(line: &str, limit: usize) -> bool {
-    if line.len() > limit {
+fn should_enforce_line_length(line: &str, length: usize, limit: usize) -> bool {
+    if length > limit {
         let mut chunks = line.split_whitespace();
         if let (Some(first), Some(_)) = (chunks.next(), chunks.next()) {
             // Do not enforce the line length for commented lines with a single word
@@ -20,7 +20,7 @@ fn should_enforce_line_length(line: &str, limit: usize) -> bool {
 }
 
 pub fn check_lines(checks: &mut Vec<Check>, contents: &str, settings: &Settings) {
-    let enforce_line_too_long = settings.select.contains(CheckKind::LineTooLong.code());
+    let enforce_line_too_long = settings.select.contains(&CheckCode::E501);
 
     let mut line_checks = vec![];
     let mut ignored = vec![];
@@ -34,13 +34,16 @@ pub fn check_lines(checks: &mut Vec<Check>, contents: &str, settings: &Settings)
         }
 
         // Enforce line length.
-        if enforce_line_too_long && should_enforce_line_length(line, settings.line_length) {
-            let check = Check::new(
-                CheckKind::LineTooLong,
-                Location::new(row + 1, settings.line_length + 1),
-            );
-            if !check.is_inline_ignored(line) {
-                line_checks.push(check);
+        if enforce_line_too_long {
+            let line_length = line.len();
+            if should_enforce_line_length(line, line_length, settings.line_length) {
+                let check = Check::new(
+                    CheckKind::LineTooLong(line_length, settings.line_length),
+                    Location::new(row + 1, settings.line_length + 1),
+                );
+                if !check.is_inline_ignored(line) {
+                    line_checks.push(check);
+                }
             }
         }
     }

src/checks.rs

@@ -14,6 +14,7 @@ pub enum CheckCode {
     E712,
     E713,
     E714,
+    E722,
     E731,
     E741,
     E742,
@@ -22,6 +23,7 @@ pub enum CheckCode {
     F401,
     F403,
     F404,
+    F406,
     F407,
     F541,
     F601,
@@ -30,9 +32,12 @@ pub enum CheckCode {
     F622,
     F631,
     F634,
+    F701,
+    F702,
     F704,
     F706,
     F707,
+    F722,
     F821,
     F822,
     F823,
@@ -53,6 +58,7 @@ impl FromStr for CheckCode {
             "E711" => Ok(CheckCode::E711),
             "E712" => Ok(CheckCode::E712),
             "E713" => Ok(CheckCode::E713),
+            "E722" => Ok(CheckCode::E722),
             "E714" => Ok(CheckCode::E714),
             "E731" => Ok(CheckCode::E731),
             "E741" => Ok(CheckCode::E741),
@@ -62,6 +68,7 @@ impl FromStr for CheckCode {
             "F401" => Ok(CheckCode::F401),
             "F403" => Ok(CheckCode::F403),
             "F404" => Ok(CheckCode::F404),
+            "F406" => Ok(CheckCode::F406),
             "F407" => Ok(CheckCode::F407),
             "F541" => Ok(CheckCode::F541),
             "F601" => Ok(CheckCode::F601),
@@ -70,6 +77,8 @@ impl FromStr for CheckCode {
             "F622" => Ok(CheckCode::F622),
             "F631" => Ok(CheckCode::F631),
             "F634" => Ok(CheckCode::F634),
+            "F701" => Ok(CheckCode::F701),
+            "F702" => Ok(CheckCode::F702),
             "F704" => Ok(CheckCode::F704),
             "F706" => Ok(CheckCode::F706),
             "F707" => Ok(CheckCode::F707),
@@ -95,6 +104,7 @@ impl CheckCode {
             CheckCode::E712 => "E712",
             CheckCode::E713 => "E713",
             CheckCode::E714 => "E714",
+            CheckCode::E722 => "E722",
             CheckCode::E731 => "E731",
             CheckCode::E741 => "E741",
             CheckCode::E742 => "E742",
@@ -103,6 +113,7 @@ impl CheckCode {
             CheckCode::F401 => "F401",
             CheckCode::F403 => "F403",
             CheckCode::F404 => "F404",
+            CheckCode::F406 => "F406",
             CheckCode::F407 => "F407",
             CheckCode::F541 => "F541",
             CheckCode::F601 => "F601",
@@ -111,9 +122,12 @@ impl CheckCode {
             CheckCode::F622 => "F622",
             CheckCode::F631 => "F631",
             CheckCode::F634 => "F634",
+            CheckCode::F701 => "F701",
+            CheckCode::F702 => "F702",
             CheckCode::F704 => "F704",
             CheckCode::F706 => "F706",
             CheckCode::F707 => "F707",
+            CheckCode::F722 => "F722",
             CheckCode::F821 => "F821",
             CheckCode::F822 => "F822",
             CheckCode::F823 => "F823",
@@ -125,42 +139,12 @@ impl CheckCode {
         }
     }
 
-    /// The source for the check (either the AST, or the physical lines).
+    /// The source for the check (either the AST, the filesystem, or the physical lines).
     pub fn lint_source(&self) -> &'static LintSource {
         match self {
-            CheckCode::E402 => &LintSource::AST,
             CheckCode::E501 => &LintSource::Lines,
-            CheckCode::E711 => &LintSource::AST,
-            CheckCode::E712 => &LintSource::AST,
-            CheckCode::E713 => &LintSource::AST,
-            CheckCode::E714 => &LintSource::AST,
-            CheckCode::E731 => &LintSource::AST,
-            CheckCode::E741 => &LintSource::AST,
-            CheckCode::E742 => &LintSource::AST,
-            CheckCode::E743 => &LintSource::AST,
             CheckCode::E902 => &LintSource::FileSystem,
-            CheckCode::F401 => &LintSource::AST,
-            CheckCode::F403 => &LintSource::AST,
-            CheckCode::F404 => &LintSource::AST,
-            CheckCode::F407 => &LintSource::AST,
-            CheckCode::F541 => &LintSource::AST,
-            CheckCode::F601 => &LintSource::AST,
-            CheckCode::F602 => &LintSource::AST,
-            CheckCode::F621 => &LintSource::AST,
-            CheckCode::F622 => &LintSource::AST,
-            CheckCode::F631 => &LintSource::AST,
-            CheckCode::F634 => &LintSource::AST,
-            CheckCode::F704 => &LintSource::AST,
-            CheckCode::F706 => &LintSource::AST,
-            CheckCode::F707 => &LintSource::AST,
-            CheckCode::F821 => &LintSource::AST,
-            CheckCode::F822 => &LintSource::AST,
-            CheckCode::F823 => &LintSource::AST,
-            CheckCode::F831 => &LintSource::AST,
-            CheckCode::F841 => &LintSource::AST,
-            CheckCode::F901 => &LintSource::AST,
-            CheckCode::R001 => &LintSource::AST,
-            CheckCode::R002 => &LintSource::AST,
+            _ => &LintSource::AST,
         }
     }
 }
@@ -180,20 +164,25 @@ pub enum RejectedCmpop {
 
 #[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub enum CheckKind {
-    AssertTuple,
-    AmbiguousVariableName(String),
     AmbiguousClassName(String),
     AmbiguousFunctionName(String),
+    AmbiguousVariableName(String),
+    AssertTuple,
+    BreakOutsideLoop,
+    ContinueOutsideLoop,
     DefaultExceptNotLast,
     DoNotAssignLambda,
+    DoNotUseBareExcept,
     DuplicateArgumentName,
+    ForwardAnnotationSyntaxError(String),
     FStringMissingPlaceholders,
     FutureFeatureNotDefined(String),
     IOError(String),
     IfTuple,
-    ImportStarUsage,
+    ImportStarNotPermitted(String),
+    ImportStarUsage(String),
     LateFutureImport,
-    LineTooLong,
+    LineTooLong(usize, usize),
     ModuleImportNotAtTopOfFile,
     MultiValueRepeatedKeyLiteral,
     MultiValueRepeatedKeyVariable(String),
@@ -219,20 +208,25 @@ impl CheckKind {
     /// The name of the check.
     pub fn name(&self) -> &'static str {
         match self {
-            CheckKind::AssertTuple => "AssertTuple",
-            CheckKind::AmbiguousVariableName(_) => "AmbiguousVariableName",
             CheckKind::AmbiguousClassName(_) => "AmbiguousClassName",
             CheckKind::AmbiguousFunctionName(_) => "AmbiguousFunctionName",
+            CheckKind::AmbiguousVariableName(_) => "AmbiguousVariableName",
+            CheckKind::AssertTuple => "AssertTuple",
+            CheckKind::BreakOutsideLoop => "BreakOutsideLoop",
+            CheckKind::ContinueOutsideLoop => "ContinueOutsideLoop",
             CheckKind::DefaultExceptNotLast => "DefaultExceptNotLast",
+            CheckKind::DoNotAssignLambda => "DoNotAssignLambda",
+            CheckKind::DoNotUseBareExcept => "DoNotUseBareExcept",
             CheckKind::DuplicateArgumentName => "DuplicateArgumentName",
+            CheckKind::ForwardAnnotationSyntaxError(_) => "ForwardAnnotationSyntaxError",
             CheckKind::FStringMissingPlaceholders => "FStringMissingPlaceholders",
             CheckKind::FutureFeatureNotDefined(_) => "FutureFeatureNotDefined",
             CheckKind::IOError(_) => "IOError",
             CheckKind::IfTuple => "IfTuple",
-            CheckKind::ImportStarUsage => "ImportStarUsage",
+            CheckKind::ImportStarNotPermitted(_) => "ImportStarNotPermitted",
+            CheckKind::ImportStarUsage(_) => "ImportStarUsage",
             CheckKind::LateFutureImport => "LateFutureImport",
-            CheckKind::LineTooLong => "LineTooLong",
-            CheckKind::DoNotAssignLambda => "DoNotAssignLambda",
+            CheckKind::LineTooLong(_, _) => "LineTooLong",
             CheckKind::ModuleImportNotAtTopOfFile => "ModuleImportNotAtTopOfFile",
             CheckKind::MultiValueRepeatedKeyLiteral => "MultiValueRepeatedKeyLiteral",
             CheckKind::MultiValueRepeatedKeyVariable(_) => "MultiValueRepeatedKeyVariable",
@@ -260,20 +254,25 @@ impl CheckKind {
     /// A four-letter shorthand code for the check.
     pub fn code(&self) -> &'static CheckCode {
         match self {
+            CheckKind::AmbiguousClassName(_) => &CheckCode::E742,
+            CheckKind::AmbiguousFunctionName(_) => &CheckCode::E743,
+            CheckKind::AmbiguousVariableName(_) => &CheckCode::E741,
             CheckKind::AssertTuple => &CheckCode::F631,
+            CheckKind::BreakOutsideLoop => &CheckCode::F701,
+            CheckKind::ContinueOutsideLoop => &CheckCode::F702,
             CheckKind::DefaultExceptNotLast => &CheckCode::F707,
+            CheckKind::DoNotAssignLambda => &CheckCode::E731,
+            CheckKind::DoNotUseBareExcept => &CheckCode::E722,
             CheckKind::DuplicateArgumentName => &CheckCode::F831,
+            CheckKind::ForwardAnnotationSyntaxError(_) => &CheckCode::F722,
             CheckKind::FStringMissingPlaceholders => &CheckCode::F541,
             CheckKind::FutureFeatureNotDefined(_) => &CheckCode::F407,
             CheckKind::IOError(_) => &CheckCode::E902,
             CheckKind::IfTuple => &CheckCode::F634,
-            CheckKind::ImportStarUsage => &CheckCode::F403,
+            CheckKind::ImportStarNotPermitted(_) => &CheckCode::F406,
+            CheckKind::ImportStarUsage(_) => &CheckCode::F403,
             CheckKind::LateFutureImport => &CheckCode::F404,
-            CheckKind::LineTooLong => &CheckCode::E501,
-            CheckKind::DoNotAssignLambda => &CheckCode::E731,
-            CheckKind::AmbiguousVariableName(_) => &CheckCode::E741,
-            CheckKind::AmbiguousClassName(_) => &CheckCode::E742,
-            CheckKind::AmbiguousFunctionName(_) => &CheckCode::E743,
+            CheckKind::LineTooLong(_, _) => &CheckCode::E501,
             CheckKind::ModuleImportNotAtTopOfFile => &CheckCode::E402,
             CheckKind::MultiValueRepeatedKeyLiteral => &CheckCode::F601,
             CheckKind::MultiValueRepeatedKeyVariable(_) => &CheckCode::F602,
@@ -299,15 +298,33 @@ impl CheckKind {
     /// The body text for the check.
     pub fn body(&self) -> String {
         match self {
+            CheckKind::AmbiguousClassName(name) => {
+                format!("ambiguous class name '{}'", name)
+            }
+            CheckKind::AmbiguousFunctionName(name) => {
+                format!("ambiguous function name '{}'", name)
+            }
+            CheckKind::AmbiguousVariableName(name) => {
+                format!("ambiguous variable name '{}'", name)
+            }
             CheckKind::AssertTuple => {
                 "Assert test is a non-empty tuple, which is always `True`".to_string()
             }
+            CheckKind::BreakOutsideLoop => "`break` outside loop".to_string(),
+            CheckKind::ContinueOutsideLoop => "`continue` not properly in loop".to_string(),
             CheckKind::DefaultExceptNotLast => {
                 "an `except:` block as not the last exception handler".to_string()
             }
+            CheckKind::DoNotAssignLambda => {
+                "Do not assign a lambda expression, use a def".to_string()
+            }
+            CheckKind::DoNotUseBareExcept => "Do not use bare `except`".to_string(),
             CheckKind::DuplicateArgumentName => {
                 "Duplicate argument name in function definition".to_string()
             }
+            CheckKind::ForwardAnnotationSyntaxError(body) => {
+                format!("syntax error in forward annotation '{body}'")
+            }
             CheckKind::FStringMissingPlaceholders => {
                 "f-string without any placeholders".to_string()
             }
@@ -318,22 +335,17 @@ impl CheckKind {
                 format!("No such file or directory: `{name}`")
             }
             CheckKind::IfTuple => "If test is a tuple, which is always `True`".to_string(),
-            CheckKind::ImportStarUsage => "Unable to detect undefined names".to_string(),
+            CheckKind::ImportStarNotPermitted(name) => {
+                format!("`from {name} import *` only allowed at module level")
+            }
+            CheckKind::ImportStarUsage(name) => {
+                format!("`from {name} import *` used; unable to detect undefined names")
+            }
             CheckKind::LateFutureImport => {
                 "from __future__ imports must occur at the beginning of the file".to_string()
             }
-            CheckKind::LineTooLong => "Line too long".to_string(),
-            CheckKind::DoNotAssignLambda => {
-                "Do not assign a lambda expression, use a def".to_string()
-            }
-            CheckKind::AmbiguousClassName(name) => {
-                format!("ambiguous class name '{}'", name)
-            }
-            CheckKind::AmbiguousFunctionName(name) => {
-                format!("ambiguous function name '{}'", name)
-            }
-            CheckKind::AmbiguousVariableName(name) => {
-                format!("ambiguous variable name '{}'", name)
+            CheckKind::LineTooLong(length, limit) => {
+                format!("Line too long ({length} > {limit} characters)")
             }
             CheckKind::ModuleImportNotAtTopOfFile => {
                 "Module level import not at top of file".to_string()
@@ -386,12 +398,12 @@ impl CheckKind {
             CheckKind::UndefinedExport(name) => {
                 format!("Undefined name `{name}` in `__all__`")
             }
-            CheckKind::UndefinedName(name) => {
-                format!("Undefined name `{name}`")
-            }
             CheckKind::UndefinedLocal(name) => {
                 format!("Local variable `{name}` referenced before assignment")
             }
+            CheckKind::UndefinedName(name) => {
+                format!("Undefined name `{name}`")
+            }
             CheckKind::UnusedImport(name) => format!("`{name}` imported but unused"),
             CheckKind::UnusedVariable(name) => {
                 format!("Local variable `{name}` is assigned to but never used")
@@ -407,41 +419,10 @@ impl CheckKind {
 
     /// Whether the check kind is (potentially) fixable.
     pub fn fixable(&self) -> bool {
-        match self {
-            CheckKind::AmbiguousClassName(_) => true,
-            CheckKind::AmbiguousFunctionName(_) => true,
-            CheckKind::AmbiguousVariableName(_) => false,
-            CheckKind::AssertTuple => false,
-            CheckKind::DefaultExceptNotLast => false,
-            CheckKind::DoNotAssignLambda => false,
-            CheckKind::DuplicateArgumentName => false,
-            CheckKind::FStringMissingPlaceholders => false,
-            CheckKind::FutureFeatureNotDefined(_) => false,
-            CheckKind::IOError(_) => false,
-            CheckKind::IfTuple => false,
-            CheckKind::ImportStarUsage => false,
-            CheckKind::LateFutureImport => false,
-            CheckKind::LineTooLong => false,
-            CheckKind::ModuleImportNotAtTopOfFile => false,
-            CheckKind::MultiValueRepeatedKeyLiteral => false,
-            CheckKind::MultiValueRepeatedKeyVariable(_) => false,
-            CheckKind::NoAssertEquals => true,
-            CheckKind::NoneComparison(_) => false,
-            CheckKind::NotInTest => false,
-            CheckKind::NotIsTest => false,
-            CheckKind::RaiseNotImplemented => false,
-            CheckKind::ReturnOutsideFunction => false,
-            CheckKind::TooManyExpressionsInStarredAssignment => false,
-            CheckKind::TrueFalseComparison(_, _) => false,
-            CheckKind::TwoStarredExpressions => false,
-            CheckKind::UndefinedExport(_) => false,
-            CheckKind::UndefinedLocal(_) => false,
-            CheckKind::UndefinedName(_) => false,
-            CheckKind::UnusedImport(_) => false,
-            CheckKind::UnusedVariable(_) => false,
-            CheckKind::UselessObjectInheritance(_) => true,
-            CheckKind::YieldOutsideFunction => false,
-        }
+        matches!(
+            self,
+            CheckKind::NoAssertEquals | CheckKind::UselessObjectInheritance(_)
+        )
     }
 }
 

src/linter.rs

@@ -128,7 +128,7 @@ mod tests {
         )?;
         actual.sort_by_key(|check| check.location);
         let expected = vec![Check {
-            kind: CheckKind::LineTooLong,
+            kind: CheckKind::LineTooLong(123, 88),
             location: Location::new(5, 89),
             fix: None,
         }];
@@ -240,6 +240,31 @@ mod tests {
         Ok(())
     }
 
+    #[test]
+    fn e722() -> Result<()> {
+        let mut actual = check_path(
+            Path::new("./resources/test/fixtures/E722.py"),
+            &settings::Settings {
+                line_length: 88,
+                exclude: vec![],
+                select: BTreeSet::from([CheckCode::E722]),
+            },
+            &fixer::Mode::Generate,
+        )?;
+        actual.sort_by_key(|check| check.location);
+        let expected = vec![Check {
+            kind: CheckKind::DoNotUseBareExcept,
+            location: Location::new(3, 1),
+            fix: None,
+        }];
+        assert_eq!(actual.len(), expected.len());
+        for i in 0..actual.len() {
+            assert_eq!(actual[i], expected[i]);
+        }
+
+        Ok(())
+    }
+
     #[test]
     fn e714() -> Result<()> {
         let mut actual = check_path(
@@ -431,6 +456,11 @@ mod tests {
                 location: Location::new(71, 1),
                 fix: None,
             },
+            Check {
+                kind: CheckKind::AmbiguousVariableName("l".to_string()),
+                location: Location::new(74, 5),
+                fix: None,
+            },
         ];
 
         assert_eq!(actual.len(), expected.len());
@@ -568,12 +598,12 @@ mod tests {
         actual.sort_by_key(|check| check.location);
         let expected = vec![
             Check {
-                kind: CheckKind::ImportStarUsage,
+                kind: CheckKind::ImportStarUsage("F634".to_string()),
                 location: Location::new(1, 1),
                 fix: None,
             },
             Check {
-                kind: CheckKind::ImportStarUsage,
+                kind: CheckKind::ImportStarUsage("F634".to_string()),
                 location: Location::new(2, 1),
                 fix: None,
             },
@@ -611,6 +641,38 @@ mod tests {
         Ok(())
     }
 
+    #[test]
+    fn f406() -> Result<()> {
+        let mut actual = check_path(
+            Path::new("./resources/test/fixtures/F406.py"),
+            &settings::Settings {
+                line_length: 88,
+                exclude: vec![],
+                select: BTreeSet::from([CheckCode::F406]),
+            },
+            &fixer::Mode::Generate,
+        )?;
+        actual.sort_by_key(|check| check.location);
+        let expected = vec![
+            Check {
+                kind: CheckKind::ImportStarNotPermitted("F634".to_string()),
+                location: Location::new(5, 5),
+                fix: None,
+            },
+            Check {
+                kind: CheckKind::ImportStarNotPermitted("F634".to_string()),
+                location: Location::new(9, 5),
+                fix: None,
+            },
+        ];
+        assert_eq!(actual.len(), expected.len());
+        for i in 0..actual.len() {
+            assert_eq!(actual[i], expected[i]);
+        }
+
+        Ok(())
+    }
+
     #[test]
     fn f407() -> Result<()> {
         let mut actual = check_path(
@@ -821,6 +883,90 @@ mod tests {
         Ok(())
     }
 
+    #[test]
+    fn f701() -> Result<()> {
+        let mut actual = check_path(
+            Path::new("./resources/test/fixtures/F701.py"),
+            &settings::Settings {
+                line_length: 88,
+                exclude: vec![],
+                select: BTreeSet::from([CheckCode::F701]),
+            },
+            &fixer::Mode::Generate,
+        )?;
+        actual.sort_by_key(|check| check.location);
+        let expected = vec![
+            Check {
+                kind: CheckKind::BreakOutsideLoop,
+                location: Location::new(4, 5),
+                fix: None,
+            },
+            Check {
+                kind: CheckKind::BreakOutsideLoop,
+                location: Location::new(16, 5),
+                fix: None,
+            },
+            Check {
+                kind: CheckKind::BreakOutsideLoop,
+                location: Location::new(20, 5),
+                fix: None,
+            },
+            Check {
+                kind: CheckKind::BreakOutsideLoop,
+                location: Location::new(23, 1),
+                fix: None,
+            },
+        ];
+        assert_eq!(actual.len(), expected.len());
+        for i in 0..actual.len() {
+            assert_eq!(actual[i], expected[i]);
+        }
+
+        Ok(())
+    }
+
+    #[test]
+    fn f702() -> Result<()> {
+        let mut actual = check_path(
+            Path::new("./resources/test/fixtures/F702.py"),
+            &settings::Settings {
+                line_length: 88,
+                exclude: vec![],
+                select: BTreeSet::from([CheckCode::F702]),
+            },
+            &fixer::Mode::Generate,
+        )?;
+        actual.sort_by_key(|check| check.location);
+        let expected = vec![
+            Check {
+                kind: CheckKind::ContinueOutsideLoop,
+                location: Location::new(4, 5),
+                fix: None,
+            },
+            Check {
+                kind: CheckKind::ContinueOutsideLoop,
+                location: Location::new(16, 5),
+                fix: None,
+            },
+            Check {
+                kind: CheckKind::ContinueOutsideLoop,
+                location: Location::new(20, 5),
+                fix: None,
+            },
+            Check {
+                kind: CheckKind::ContinueOutsideLoop,
+                location: Location::new(23, 1),
+                fix: None,
+            },
+        ];
+        assert_eq!(actual.len(), expected.len());
+        for i in 0..actual.len() {
+            assert_eq!(actual[i], expected[i]);
+        }
+
+        Ok(())
+    }
+
     #[test]
     fn f704() -> Result<()> {
         let mut actual = check_path(
@@ -927,6 +1073,31 @@ mod tests {
         Ok(())
     }
 
+    #[test]
+    fn f722() -> Result<()> {
+        let mut actual = check_path(
+            Path::new("./resources/test/fixtures/F722.py"),
+            &settings::Settings {
+                line_length: 88,
+                exclude: vec![],
+                select: BTreeSet::from([CheckCode::F722]),
+            },
+            &fixer::Mode::Generate,
+        )?;
+        actual.sort_by_key(|check| check.location);
+        let expected = vec![Check {
+            kind: CheckKind::ForwardAnnotationSyntaxError("///".to_string()),
+            location: Location::new(9, 13),
+            fix: None,
+        }];
+        assert_eq!(actual.len(), expected.len());
+        for i in 0..actual.len() {
+            assert_eq!(actual[i], expected[i]);
+        }
+
+        Ok(())
+    }
+
     #[test]
     fn f821() -> Result<()> {
         let mut actual = check_path(

src/pyproject.rs

@@ -265,6 +265,7 @@ other-attribute = 1
                     CheckCode::E712,
                     CheckCode::E713,
                     CheckCode::E714,
+                    CheckCode::E722,
                     CheckCode::E731,
                     CheckCode::E741,
                     CheckCode::E742,
@@ -273,6 +274,7 @@ other-attribute = 1
                     CheckCode::F401,
                     CheckCode::F403,
                     CheckCode::F404,
+                    CheckCode::F406,
                     CheckCode::F407,
                     CheckCode::F541,
                     CheckCode::F601,
@@ -281,9 +283,12 @@ other-attribute = 1
                     CheckCode::F622,
                     CheckCode::F631,
                     CheckCode::F634,
+                    CheckCode::F701,
+                    CheckCode::F702,
                     CheckCode::F704,
                     CheckCode::F706,
                     CheckCode::F707,
+                    CheckCode::F722,
                     CheckCode::F821,
                     CheckCode::F822,
                     CheckCode::F823,

src/settings.rs

@@ -50,6 +50,7 @@ impl Settings {
                     CheckCode::E712,
                     CheckCode::E713,
                     CheckCode::E714,
+                    CheckCode::E722,
                     CheckCode::E731,
                     CheckCode::E741,
                     CheckCode::E742,
@@ -57,6 +58,7 @@ impl Settings {
                     CheckCode::E902,
                     CheckCode::F401,
                     CheckCode::F403,
+                    CheckCode::F406,
                     CheckCode::F407,
                     CheckCode::F541,
                     CheckCode::F601,
@@ -65,9 +67,12 @@ impl Settings {
                     CheckCode::F622,
                     CheckCode::F631,
                     CheckCode::F634,
+                    CheckCode::F701,
+                    CheckCode::F702,
                     CheckCode::F704,
                     CheckCode::F706,
                     CheckCode::F707,
+                    CheckCode::F722,
                     CheckCode::F821,
                     CheckCode::F822,
                     CheckCode::F823,