Bump version to 0.0.61

Cargo.lock

@@ -1907,7 +1907,7 @@ dependencies = [
 
 [[package]]
 name = "ruff"
-version = "0.0.57"
+version = "0.0.61"
 dependencies = [
  "anyhow",
  "bincode",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ruff"
-version = "0.0.57"
+version = "0.0.61"
 edition = "2021"
 
 [lib]

README.md

@@ -130,6 +130,8 @@ Options:
           Enable automatic additions of noqa directives to failing lines
       --dummy-variable-rgx <DUMMY_VARIABLE_RGX>
           Regular expression matching the name of dummy variables
+      --target-version <TARGET_VERSION>
+          The minimum Python version that should be supported
   -h, --help
           Print help information
   -V, --version
@@ -213,6 +215,7 @@ ruff also implements some of the most popular Flake8 plugins natively, including
 - [`flake8-builtins`](https://pypi.org/project/flake8-builtins/)
 - [`flake8-super`](https://pypi.org/project/flake8-super/)
 - [`flake8-print`](https://pypi.org/project/flake8-print/)
+- [`flake8-comprehensions`](https://pypi.org/project/flake8-comprehensions/) (partial)
 - [`pyupgrade`](https://pypi.org/project/pyupgrade/) (partial)
 
 Beyond rule-set parity, ruff suffers from the following limitations vis-à-vis Flake8:
@@ -243,6 +246,7 @@ The 🛠 emoji indicates that a rule is automatically fixable by the `--fix` com
 | E743 | AmbiguousFunctionName | Ambiguous function name: `...` | ✅ |  |
 | E902 | IOError | IOError: `...` | ✅ |  |
 | E999 | SyntaxError | SyntaxError: `...` | ✅ |  |
+| W292 | NoNewLineAtEndOfFile | No newline at end of file | ✅ |  |
 | F401 | UnusedImport | `...` imported but unused | ✅ | 🛠 |
 | F402 | ImportShadowedByLoopVar | Import `...` from line 1 shadowed by loop variable | ✅ |  |
 | F403 | ImportStarUsed | `from ... import *` used; unable to detect undefined names | ✅ |  |
@@ -274,14 +278,25 @@ The 🛠 emoji indicates that a rule is automatically fixable by the `--fix` com
 | A001 | BuiltinVariableShadowing | Variable `...` is shadowing a python builtin |  |  |
 | A002 | BuiltinArgumentShadowing | Argument `...` is shadowing a python builtin |  |  |
 | A003 | BuiltinAttributeShadowing | Class attribute `...` is shadowing a python builtin |  |  |
+| C400 | UnnecessaryGeneratorList | Unnecessary generator - rewrite as a list comprehension |  |  |
+| C401 | UnnecessaryGeneratorSet | Unnecessary generator - rewrite as a set comprehension |  |  |
+| C402 | UnnecessaryGeneratorDict | Unnecessary generator - rewrite as a dict comprehension |  |  |
+| C403 | UnnecessaryListComprehensionSet | Unnecessary list comprehension - rewrite as a set comprehension |  |  |
+| C404 | UnnecessaryListComprehensionDict | Unnecessary list comprehension - rewrite as a dict comprehension |  |  |
+| C405 | UnnecessaryLiteralSet | Unnecessary <list/tuple> literal - rewrite as a set literal |  |  |
+| C406 | UnnecessaryLiteralDict | Unnecessary <list/tuple> literal - rewrite as a dict literal |  |  |
+| C408 | UnnecessaryCollectionCall | Unnecessary <dict/list/tuple> call - rewrite as a literal |  |  |
 | SPR001 | SuperCallWithParameters | Use `super()` instead of `super(__class__, self)` |  | 🛠 |
 | T201 | PrintFound | `print` found |  | 🛠 |
 | T203 | PPrintFound | `pprint` found |  | 🛠 |
 | U001 | UselessMetaclassType | `__metaclass__ = type` is implied |  | 🛠 |
-| R001 | UselessObjectInheritance | Class `...` inherits from object |  | 🛠 |
-| R002 | NoAssertEquals | `assertEquals` is deprecated, use `assertEqual` instead |  | 🛠 |
+| U002 | UnnecessaryAbspath | `abspath(__file__)` is unnecessary in Python 3.9 and later |  | 🛠 |
+| U003 | TypeOfPrimitive | Use `str` instead of `type(...)` |  | 🛠 |
+| U004 | UselessObjectInheritance | Class `...` inherits from object |  | 🛠 |
+| U005 | NoAssertEquals | `assertEquals` is deprecated, use `assertEqual` instead |  | 🛠 |
 | M001 | UnusedNOQA | Unused `noqa` directive |  | 🛠 |
 
+
 ## Integrations
 
 ### PyCharm
@@ -307,9 +322,9 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Install Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: "3.10"
       - name: Install dependencies

output.py

@@ -1,37 +0,0 @@
-from collections import Counter
-
-
-def f() -> None:
-    """Docstring goes here."""
-    for x in range(5):
-        print(x)
-    else:
-        print("Nope!")
-
-
-a = {
-    "a",
-    "b",
-    "c",
-    "a",
-    "b",
-    "c",
-    "a",
-    "b",
-    "c",
-    "a",
-    "b",
-    "c",
-    "a",
-    "b",
-    "c",
-    "a",
-    "b",
-    "c",
-    "a",
-    "b",
-    "c",
-}
-
-cls(title=title, before_text=before_text, after_text=after_text, before_description=before_description, after_description=after_description, transform_type=transform_type)
-

resources/test/fixtures/C400.py

@@ -0,0 +1 @@
+x = list(x for x in range(3))

resources/test/fixtures/C401.py

@@ -0,0 +1 @@
+x = set(x for x in range(3))

resources/test/fixtures/C402.py

@@ -0,0 +1 @@
+d = dict((x, x) for x in range(3))

resources/test/fixtures/C403.py

@@ -0,0 +1 @@
+s = set([x for x in range(3)])

resources/test/fixtures/C404.py

@@ -0,0 +1 @@
+d = dict([(i, i) for i in range(3)])

resources/test/fixtures/C405.py

@@ -0,0 +1,5 @@
+s1 = set([1, 2])
+s2 = set((1, 2))
+s3 = set([])
+s4 = set(())
+s5 = set()

resources/test/fixtures/C406.py

@@ -0,0 +1,5 @@
+d1 = dict([(1, 2)])
+d2 = dict(((1, 2),))
+d3 = dict([])
+d4 = dict(())
+d5 = dict()

resources/test/fixtures/C408.py

@@ -0,0 +1,5 @@
+t = tuple()
+l = list()
+d1 = dict()
+d2 = dict(a=1)
+d3 = dict(**d2)

resources/test/fixtures/U002.py

@@ -0,0 +1,15 @@
+from os.path import abspath
+
+x = abspath(__file__)
+
+
+import os
+
+
+y = os.path.abspath(__file__)
+
+
+from os import path
+
+
+z = path.abspath(__file__)

resources/test/fixtures/U003.py

@@ -0,0 +1,5 @@
+type('')
+type(b'')
+type(0)
+type(0.)
+type(0j)

resources/test/fixtures/W292_0.py

@@ -0,0 +1,2 @@
+def fn() -> None:
+    pass

resources/test/fixtures/W292_1.py

@@ -0,0 +1,2 @@
+def fn() -> None:
+    pass  # noqa: W292

resources/test/fixtures/W292_2.py

@@ -0,0 +1,2 @@
+def fn() -> None:
+    pass

src/ast/checks.rs

@@ -4,8 +4,9 @@ use itertools::izip;
 use regex::Regex;
 use rustpython_parser::ast::{
     Arg, ArgData, Arguments, Cmpop, Constant, Excepthandler, ExcepthandlerKind, Expr, ExprKind,
-    Stmt, StmtKind, Unaryop,
+    KeywordData, Located, Stmt, StmtKind, Unaryop,
 };
+use serde::{Deserialize, Serialize};
 
 use crate::ast::types::{
     Binding, BindingKind, CheckLocator, FunctionScope, Range, Scope, ScopeKind,
@@ -134,6 +135,86 @@ pub fn check_useless_metaclass_type(
     None
 }
 
+/// Check UnnecessaryAbspath compliance.
+pub fn check_unnecessary_abspath(func: &Expr, args: &Vec<Expr>, location: Range) -> Option<Check> {
+    // Validate the arguments.
+    if args.len() == 1 {
+        if let ExprKind::Name { id, .. } = &args[0].node {
+            if id == "__file__" {
+                match &func.node {
+                    ExprKind::Attribute { attr: id, .. } | ExprKind::Name { id, .. } => {
+                        if id == "abspath" {
+                            return Some(Check::new(CheckKind::UnnecessaryAbspath, location));
+                        }
+                    }
+                    _ => {}
+                }
+            }
+        }
+    }
+
+    None
+}
+
+#[derive(Debug, PartialEq, Eq, Serialize, Deserialize)]
+pub enum Primitive {
+    Bool,
+    Str,
+    Bytes,
+    Int,
+    Float,
+    Complex,
+}
+
+impl Primitive {
+    fn from_constant(constant: &Constant) -> Option<Self> {
+        match constant {
+            Constant::Bool(_) => Some(Primitive::Bool),
+            Constant::Str(_) => Some(Primitive::Str),
+            Constant::Bytes(_) => Some(Primitive::Bytes),
+            Constant::Int(_) => Some(Primitive::Int),
+            Constant::Float(_) => Some(Primitive::Float),
+            Constant::Complex { .. } => Some(Primitive::Complex),
+            _ => None,
+        }
+    }
+
+    pub fn builtin(&self) -> String {
+        match self {
+            Primitive::Bool => "bool".to_string(),
+            Primitive::Str => "str".to_string(),
+            Primitive::Bytes => "bytes".to_string(),
+            Primitive::Int => "int".to_string(),
+            Primitive::Float => "float".to_string(),
+            Primitive::Complex => "complex".to_string(),
+        }
+    }
+}
+
+/// Check TypeOfPrimitive compliance.
+pub fn check_type_of_primitive(func: &Expr, args: &Vec<Expr>, location: Range) -> Option<Check> {
+    // Validate the arguments.
+    if args.len() == 1 {
+        match &func.node {
+            ExprKind::Attribute { attr: id, .. } | ExprKind::Name { id, .. } => {
+                if id == "type" {
+                    if let ExprKind::Constant { value, .. } = &args[0].node {
+                        if let Some(primitive) = Primitive::from_constant(value) {
+                            return Some(Check::new(
+                                CheckKind::TypeOfPrimitive(primitive),
+                                location,
+                            ));
+                        }
+                    }
+                }
+            }
+            _ => {}
+        }
+    }
+
+    None
+}
+
 fn is_ambiguous_name(name: &str) -> bool {
     name == "l" || name == "I" || name == "O"
 }
@@ -692,6 +773,218 @@ pub fn is_super_call_with_arguments(func: &Expr, args: &Vec<Expr>) -> bool {
     }
 }
 
+// flakes8-comprehensions
+/// Check `list(generator)` compliance.
+pub fn unnecessary_generator_list(expr: &Expr, func: &Expr, args: &Vec<Expr>) -> Option<Check> {
+    if args.len() == 1 {
+        if let ExprKind::Name { id, .. } = &func.node {
+            if id == "list" {
+                if let ExprKind::GeneratorExp { .. } = &args[0].node {
+                    return Some(Check::new(
+                        CheckKind::UnnecessaryGeneratorList,
+                        Range::from_located(expr),
+                    ));
+                }
+            }
+        }
+    }
+    None
+}
+
+/// Check `set(generator)` compliance.
+pub fn unnecessary_generator_set(expr: &Expr, func: &Expr, args: &Vec<Expr>) -> Option<Check> {
+    if args.len() == 1 {
+        if let ExprKind::Name { id, .. } = &func.node {
+            if id == "set" {
+                if let ExprKind::GeneratorExp { .. } = &args[0].node {
+                    return Some(Check::new(
+                        CheckKind::UnnecessaryGeneratorList,
+                        Range::from_located(expr),
+                    ));
+                }
+            }
+        }
+    }
+    None
+}
+
+/// Check `dict((x, y) for x, y in iterable)` compliance.
+pub fn unnecessary_generator_dict(expr: &Expr, func: &Expr, args: &Vec<Expr>) -> Option<Check> {
+    if args.len() == 1 {
+        if let ExprKind::Name { id, .. } = &func.node {
+            if id == "dict" {
+                if let ExprKind::GeneratorExp { elt, .. } = &args[0].node {
+                    match &elt.node {
+                        ExprKind::Tuple { elts, .. } if elts.len() == 2 => {
+                            return Some(Check::new(
+                                CheckKind::UnnecessaryListComprehensionDict,
+                                Range::from_located(expr),
+                            ));
+                        }
+                        _ => {}
+                    }
+                }
+            }
+        }
+    }
+    None
+}
+
+/// Check `set([...])` compliance.
+pub fn unnecessary_list_comprehension_set(
+    expr: &Expr,
+    func: &Expr,
+    args: &Vec<Expr>,
+) -> Option<Check> {
+    if args.len() == 1 {
+        if let ExprKind::Name { id, .. } = &func.node {
+            if id == "set" {
+                if let ExprKind::ListComp { .. } = &args[0].node {
+                    return Some(Check::new(
+                        CheckKind::UnnecessaryListComprehensionSet,
+                        Range::from_located(expr),
+                    ));
+                }
+            }
+        }
+    }
+    None
+}
+
+/// Check `dict([...])` compliance.
+pub fn unnecessary_list_comprehension_dict(
+    expr: &Expr,
+    func: &Expr,
+    args: &Vec<Expr>,
+) -> Option<Check> {
+    if args.len() == 1 {
+        if let ExprKind::Name { id, .. } = &func.node {
+            if id == "dict" {
+                if let ExprKind::ListComp { elt, .. } = &args[0].node {
+                    match &elt.node {
+                        ExprKind::Tuple { elts, .. } if elts.len() == 2 => {
+                            return Some(Check::new(
+                                CheckKind::UnnecessaryListComprehensionDict,
+                                Range::from_located(expr),
+                            ));
+                        }
+                        _ => {}
+                    }
+                }
+            }
+        }
+    }
+    None
+}
+
+/// Check `set([1, 2])` compliance.
+pub fn unnecessary_literal_set(expr: &Expr, func: &Expr, args: &Vec<Expr>) -> Option<Check> {
+    if args.len() == 1 {
+        if let ExprKind::Name { id, .. } = &func.node {
+            if id == "set" {
+                match &args[0].node {
+                    ExprKind::List { .. } => {
+                        return Some(Check::new(
+                            CheckKind::UnnecessaryLiteralSet("list".to_string()),
+                            Range::from_located(expr),
+                        ));
+                    }
+                    ExprKind::Tuple { .. } => {
+                        return Some(Check::new(
+                            CheckKind::UnnecessaryLiteralSet("tuple".to_string()),
+                            Range::from_located(expr),
+                        ));
+                    }
+                    _ => {}
+                }
+            }
+        }
+    }
+    None
+}
+
+/// Check `dict([(1, 2)])` compliance.
+pub fn unnecessary_literal_dict(expr: &Expr, func: &Expr, args: &Vec<Expr>) -> Option<Check> {
+    if args.len() == 1 {
+        if let ExprKind::Name { id, .. } = &func.node {
+            if id == "dict" {
+                match &args[0].node {
+                    ExprKind::Tuple { elts, .. } => {
+                        if let Some(elt) = elts.first() {
+                            match &elt.node {
+                                // dict((1, 2), ...))
+                                ExprKind::Tuple { elts, .. } if elts.len() == 2 => {
+                                    return Some(Check::new(
+                                        CheckKind::UnnecessaryLiteralDict("tuple".to_string()),
+                                        Range::from_located(expr),
+                                    ));
+                                }
+                                _ => {}
+                            }
+                        } else {
+                            // dict(())
+                            return Some(Check::new(
+                                CheckKind::UnnecessaryLiteralDict("tuple".to_string()),
+                                Range::from_located(expr),
+                            ));
+                        }
+                    }
+                    ExprKind::List { elts, .. } => {
+                        if let Some(elt) = elts.first() {
+                            match &elt.node {
+                                // dict([(1, 2), ...])
+                                ExprKind::Tuple { elts, .. } if elts.len() == 2 => {
+                                    return Some(Check::new(
+                                        CheckKind::UnnecessaryLiteralDict("list".to_string()),
+                                        Range::from_located(expr),
+                                    ));
+                                }
+                                _ => {}
+                            }
+                        } else {
+                            // dict([])
+                            return Some(Check::new(
+                                CheckKind::UnnecessaryLiteralDict("list".to_string()),
+                                Range::from_located(expr),
+                            ));
+                        }
+                    }
+                    _ => {}
+                }
+            }
+        }
+    }
+    None
+}
+
+pub fn unnecessary_collection_call(
+    expr: &Expr,
+    func: &Expr,
+    args: &Vec<Expr>,
+    keywords: &Vec<Located<KeywordData>>,
+) -> Option<Check> {
+    if args.is_empty() {
+        if let ExprKind::Name { id, .. } = &func.node {
+            if id == "list" || id == "tuple" {
+                // list() or tuple()
+                return Some(Check::new(
+                    CheckKind::UnnecessaryCollectionCall(id.to_string()),
+                    Range::from_located(expr),
+                ));
+            } else if id == "dict" {
+                // dict() or dict(a=1)
+                if keywords.is_empty() || keywords.iter().all(|kw| kw.node.arg.is_some()) {
+                    return Some(Check::new(
+                        CheckKind::UnnecessaryCollectionCall(id.to_string()),
+                        Range::from_located(expr),
+                    ));
+                }
+            }
+        }
+    }
+    None
+}
+
 // flake8-super
 /// Check that `super()` has no args
 pub fn check_super_args(

src/check_ast.rs

@@ -25,7 +25,7 @@ use crate::plugins;
 use crate::python::builtins::{BUILTINS, MAGIC_GLOBALS};
 use crate::python::future::ALL_FEATURE_NAMES;
 use crate::python::typing;
-use crate::settings::Settings;
+use crate::settings::{PythonVersion, Settings};
 
 pub const GLOBAL_SCOPE_INDEX: usize = 0;
 
@@ -388,7 +388,7 @@ where
                 decorator_list,
                 ..
             } => {
-                if self.settings.enabled.contains(&CheckCode::R001) {
+                if self.settings.enabled.contains(&CheckCode::U004) {
                     plugins::useless_object_inheritance(self, stmt, name, bases, keywords);
                 }
 
@@ -748,8 +748,13 @@ where
                 }
                 ExprContext::Del => self.handle_node_delete(expr),
             },
-            ExprKind::Call { func, args, .. } => {
-                if self.settings.enabled.contains(&CheckCode::R002) {
+            ExprKind::Call {
+                func,
+                args,
+                keywords,
+                ..
+            } => {
+                if self.settings.enabled.contains(&CheckCode::U005) {
                     plugins::assert_equals(self, func);
                 }
 
@@ -765,6 +770,72 @@ where
                     plugins::print_call(self, expr, func);
                 }
 
+                // flake8-comprehensions
+                if self.settings.enabled.contains(&CheckCode::C400) {
+                    if let Some(check) = checks::unnecessary_generator_list(expr, func, args) {
+                        self.checks.push(check);
+                    };
+                }
+
+                if self.settings.enabled.contains(&CheckCode::C401) {
+                    if let Some(check) = checks::unnecessary_generator_set(expr, func, args) {
+                        self.checks.push(check);
+                    };
+                }
+
+                if self.settings.enabled.contains(&CheckCode::C402) {
+                    if let Some(check) = checks::unnecessary_generator_dict(expr, func, args) {
+                        self.checks.push(check);
+                    };
+                }
+
+                if self.settings.enabled.contains(&CheckCode::C403) {
+                    if let Some(check) =
+                        checks::unnecessary_list_comprehension_set(expr, func, args)
+                    {
+                        self.checks.push(check);
+                    };
+                }
+
+                if self.settings.enabled.contains(&CheckCode::C404) {
+                    if let Some(check) =
+                        checks::unnecessary_list_comprehension_dict(expr, func, args)
+                    {
+                        self.checks.push(check);
+                    };
+                }
+
+                if self.settings.enabled.contains(&CheckCode::C405) {
+                    if let Some(check) = checks::unnecessary_literal_set(expr, func, args) {
+                        self.checks.push(check);
+                    };
+                }
+
+                if self.settings.enabled.contains(&CheckCode::C406) {
+                    if let Some(check) = checks::unnecessary_literal_dict(expr, func, args) {
+                        self.checks.push(check);
+                    };
+                }
+
+                if self.settings.enabled.contains(&CheckCode::C408) {
+                    if let Some(check) =
+                        checks::unnecessary_collection_call(expr, func, args, keywords)
+                    {
+                        self.checks.push(check);
+                    };
+                }
+
+                // pyupgrade
+                if self.settings.enabled.contains(&CheckCode::U002)
+                    && self.settings.target_version >= PythonVersion::Py310
+                {
+                    plugins::unnecessary_abspath(self, expr, func, args);
+                }
+
+                if self.settings.enabled.contains(&CheckCode::U003) {
+                    plugins::type_of_primitive(self, expr, func, args);
+                }
+
                 if let ExprKind::Name { id, ctx } = &func.node {
                     if id == "locals" && matches!(ctx, ExprContext::Load) {
                         let scope = &mut self.scopes[*(self
@@ -1662,7 +1733,7 @@ impl<'a> Checker<'a> {
                                         context.defined_by,
                                         context.defined_in,
                                     ))
-                                    .or_insert(vec![]);
+                                    .or_default();
                                 full_names.push(full_name);
                             }
                             BindingKind::Importation(full_name, context)
@@ -1673,7 +1744,7 @@ impl<'a> Checker<'a> {
                                         context.defined_by,
                                         context.defined_in,
                                     ))
-                                    .or_insert(vec![]);
+                                    .or_default();
                                 full_names.push(full_name);
                             }
                             _ => {}
@@ -1685,12 +1756,8 @@ impl<'a> Checker<'a> {
                     let child = self.parents[defined_by];
                     let parent = defined_in.map(|defined_in| self.parents[defined_in]);
 
-                    let mut check = Check::new(
-                        CheckKind::UnusedImport(full_names.join(", ")),
-                        self.locate_check(Range::from_located(child)),
-                    );
-
-                    if matches!(self.autofix, fixer::Mode::Generate | fixer::Mode::Apply) {
+                    let fix = if matches!(self.autofix, fixer::Mode::Generate | fixer::Mode::Apply)
+                    {
                         let deleted: Vec<&Stmt> = self
                             .deletions
                             .iter()
@@ -1703,14 +1770,22 @@ impl<'a> Checker<'a> {
                         };
 
                         match removal_fn(&mut self.locator, &full_names, child, parent, &deleted) {
-                            Ok(fix) => {
-                                if fix.content.is_empty() || fix.content == "pass" {
-                                    self.deletions.insert(defined_by);
-                                }
-                                check.amend(fix)
+                            Ok(fix) => Some(fix),
+                            Err(e) => {
+                                error!("Failed to fix unused imports: {}", e);
+                                None
                             }
-                            Err(e) => error!("Failed to fix unused imports: {}", e),
                         }
+                    } else {
+                        None
+                    };
+
+                    let mut check = Check::new(
+                        CheckKind::UnusedImport(full_names.into_iter().map(String::from).collect()),
+                        self.locate_check(Range::from_located(child)),
+                    );
+                    if let Some(fix) = fix {
+                        check.amend(fix);
                     }
 
                     self.checks.push(check);

src/check_lines.rs

@@ -113,6 +113,45 @@ pub fn check_lines(
         }
     }
 
+    // Enforce newlines at end of files.
+    if settings.enabled.contains(&CheckCode::W292) && !contents.ends_with('\n') {
+        // Note: if `lines.last()` is `None`, then `contents` is empty (and so we don't want to
+        // raise W292 anyway).
+        if let Some(line) = lines.last() {
+            let lineno = lines.len() - 1;
+            let noqa_lineno = noqa_line_for
+                .get(lineno)
+                .map(|lineno| lineno - 1)
+                .unwrap_or(lineno);
+
+            let noqa = noqa_directives
+                .entry(noqa_lineno)
+                .or_insert_with(|| (noqa::extract_noqa_directive(lines[noqa_lineno]), vec![]));
+
+            let check = Check::new(
+                CheckKind::NoNewLineAtEndOfFile,
+                Range {
+                    location: Location::new(lines.len(), line.len() + 1),
+                    end_location: Location::new(lines.len(), line.len() + 1),
+                },
+            );
+
+            match noqa {
+                (Directive::All(_, _), matches) => {
+                    matches.push(check.kind.code().as_str());
+                }
+                (Directive::Codes(_, _, codes), matches) => {
+                    if codes.contains(&check.kind.code().as_str()) {
+                        matches.push(check.kind.code().as_str());
+                    } else {
+                        line_checks.push(check);
+                    }
+                }
+                (Directive::None, _) => line_checks.push(check),
+            }
+        }
+    }
+
     // Enforce that the noqa directive was actually used.
     if enforce_noqa {
         for (row, (directive, matches)) in noqa_directives {

src/checks.rs

@@ -1,13 +1,15 @@
 use std::str::FromStr;
 
-use crate::ast::types::Range;
+use crate::ast::checks::Primitive;
 use anyhow::Result;
 use itertools::Itertools;
 use rustpython_parser::ast::Location;
 use serde::{Deserialize, Serialize};
 
-pub const DEFAULT_CHECK_CODES: [CheckCode; 42] = [
-    // pycodestyle
+use crate::ast::types::Range;
+
+pub const DEFAULT_CHECK_CODES: [CheckCode; 43] = [
+    // pycodestyle errors
     CheckCode::E402,
     CheckCode::E501,
     CheckCode::E711,
@@ -22,6 +24,8 @@ pub const DEFAULT_CHECK_CODES: [CheckCode; 42] = [
     CheckCode::E743,
     CheckCode::E902,
     CheckCode::E999,
+    // pycodestyle warnings
+    CheckCode::W292,
     // pyflakes
     CheckCode::F401,
     CheckCode::F402,
@@ -53,8 +57,8 @@ pub const DEFAULT_CHECK_CODES: [CheckCode; 42] = [
     CheckCode::F901,
 ];
 
-pub const ALL_CHECK_CODES: [CheckCode; 52] = [
-    // pycodestyle
+pub const ALL_CHECK_CODES: [CheckCode; 63] = [
+    // pycodestyle errors
     CheckCode::E402,
     CheckCode::E501,
     CheckCode::E711,
@@ -69,6 +73,8 @@ pub const ALL_CHECK_CODES: [CheckCode; 52] = [
     CheckCode::E743,
     CheckCode::E902,
     CheckCode::E999,
+    // pycodestyle warnings
+    CheckCode::W292,
     // pyflakes
     CheckCode::F401,
     CheckCode::F402,
@@ -102,6 +108,15 @@ pub const ALL_CHECK_CODES: [CheckCode; 52] = [
     CheckCode::A001,
     CheckCode::A002,
     CheckCode::A003,
+    // flake8-comprehensions
+    CheckCode::C400,
+    CheckCode::C401,
+    CheckCode::C402,
+    CheckCode::C403,
+    CheckCode::C404,
+    CheckCode::C405,
+    CheckCode::C406,
+    CheckCode::C408,
     // flake8-super
     CheckCode::SPR001,
     // flake8-print
@@ -109,16 +124,17 @@ pub const ALL_CHECK_CODES: [CheckCode; 52] = [
     CheckCode::T203,
     // pyupgrade
     CheckCode::U001,
-    // Refactor
-    CheckCode::R001,
-    CheckCode::R002,
+    CheckCode::U002,
+    CheckCode::U003,
+    CheckCode::U004,
+    CheckCode::U005,
     // Meta
     CheckCode::M001,
 ];
 
 #[derive(Debug, PartialEq, Eq, Clone, Serialize, Deserialize, Hash, PartialOrd, Ord)]
 pub enum CheckCode {
-    // pycodestyle
+    // pycodestyle errors
     E402,
     E501,
     E711,
@@ -133,6 +149,8 @@ pub enum CheckCode {
     E743,
     E902,
     E999,
+    // pycodestyle warnings
+    W292,
     // pyflakes
     F401,
     F402,
@@ -166,6 +184,15 @@ pub enum CheckCode {
     A001,
     A002,
     A003,
+    // flake8-comprehensions
+    C400,
+    C401,
+    C402,
+    C403,
+    C404,
+    C405,
+    C406,
+    C408,
     // flake8-super
     SPR001,
     // flake8-print
@@ -173,9 +200,10 @@ pub enum CheckCode {
     T203,
     // pyupgrade
     U001,
-    // Refactor
-    R001,
-    R002,
+    U002,
+    U003,
+    U004,
+    U005,
     // Meta
     M001,
 }
@@ -185,7 +213,7 @@ impl FromStr for CheckCode {
 
     fn from_str(s: &str) -> Result<Self> {
         match s {
-            // pycodestyle
+            // pycodestyle errors
             "E402" => Ok(CheckCode::E402),
             "E501" => Ok(CheckCode::E501),
             "E711" => Ok(CheckCode::E711),
@@ -200,6 +228,8 @@ impl FromStr for CheckCode {
             "E743" => Ok(CheckCode::E743),
             "E902" => Ok(CheckCode::E902),
             "E999" => Ok(CheckCode::E999),
+            // pycodestyle warnings
+            "W292" => Ok(CheckCode::W292),
             // pyflakes
             "F401" => Ok(CheckCode::F401),
             "F402" => Ok(CheckCode::F402),
@@ -233,6 +263,15 @@ impl FromStr for CheckCode {
             "A001" => Ok(CheckCode::A001),
             "A002" => Ok(CheckCode::A002),
             "A003" => Ok(CheckCode::A003),
+            // flake8-comprehensions
+            "C400" => Ok(CheckCode::C400),
+            "C401" => Ok(CheckCode::C401),
+            "C402" => Ok(CheckCode::C402),
+            "C403" => Ok(CheckCode::C403),
+            "C404" => Ok(CheckCode::C404),
+            "C405" => Ok(CheckCode::C405),
+            "C406" => Ok(CheckCode::C406),
+            "C408" => Ok(CheckCode::C408),
             // flake8-super
             "SPR001" => Ok(CheckCode::SPR001),
             // flake8-print
@@ -240,9 +279,10 @@ impl FromStr for CheckCode {
             "T203" => Ok(CheckCode::T203),
             // pyupgrade
             "U001" => Ok(CheckCode::U001),
-            // Refactor
-            "R001" => Ok(CheckCode::R001),
-            "R002" => Ok(CheckCode::R002),
+            "U002" => Ok(CheckCode::U002),
+            "U003" => Ok(CheckCode::U003),
+            "U004" => Ok(CheckCode::U004),
+            "U005" => Ok(CheckCode::U005),
             // Meta
             "M001" => Ok(CheckCode::M001),
             _ => Err(anyhow::anyhow!("Unknown check code: {s}")),
@@ -253,7 +293,7 @@ impl FromStr for CheckCode {
 impl CheckCode {
     pub fn as_str(&self) -> &str {
         match self {
-            // pycodestyle
+            // pycodestyle errors
             CheckCode::E402 => "E402",
             CheckCode::E501 => "E501",
             CheckCode::E711 => "E711",
@@ -268,6 +308,8 @@ impl CheckCode {
             CheckCode::E743 => "E743",
             CheckCode::E902 => "E902",
             CheckCode::E999 => "E999",
+            // pycodestyle warnings
+            CheckCode::W292 => "W292",
             // pyflakes
             CheckCode::F401 => "F401",
             CheckCode::F402 => "F402",
@@ -301,6 +343,15 @@ impl CheckCode {
             CheckCode::A001 => "A001",
             CheckCode::A002 => "A002",
             CheckCode::A003 => "A003",
+            // flake8-comprehensions
+            CheckCode::C400 => "C400",
+            CheckCode::C401 => "C401",
+            CheckCode::C402 => "C402",
+            CheckCode::C403 => "C403",
+            CheckCode::C404 => "C404",
+            CheckCode::C405 => "C405",
+            CheckCode::C406 => "C406",
+            CheckCode::C408 => "C408",
             // flake8-super
             CheckCode::SPR001 => "SPR001",
             // flake8-print
@@ -308,9 +359,10 @@ impl CheckCode {
             CheckCode::T203 => "T203",
             // pyupgrade
             CheckCode::U001 => "U001",
-            // Refactor
-            CheckCode::R001 => "R001",
-            CheckCode::R002 => "R002",
+            CheckCode::U002 => "U002",
+            CheckCode::U003 => "U003",
+            CheckCode::U004 => "U004",
+            CheckCode::U005 => "U005",
             // Meta
             CheckCode::M001 => "M001",
         }
@@ -328,7 +380,7 @@ impl CheckCode {
     /// A placeholder representation of the CheckKind for the check.
     pub fn kind(&self) -> CheckKind {
         match self {
-            // pycodestyle
+            // pycodestyle errors
             CheckCode::E402 => CheckKind::ModuleImportNotAtTopOfFile,
             CheckCode::E501 => CheckKind::LineTooLong(89, 88),
             CheckCode::E711 => CheckKind::NoneComparison(RejectedCmpop::Eq),
@@ -343,8 +395,10 @@ impl CheckCode {
             CheckCode::E743 => CheckKind::AmbiguousFunctionName("...".to_string()),
             CheckCode::E902 => CheckKind::IOError("IOError: `...`".to_string()),
             CheckCode::E999 => CheckKind::SyntaxError("`...`".to_string()),
+            // pycodestyle warnings
+            CheckCode::W292 => CheckKind::NoNewLineAtEndOfFile,
             // pyflakes
-            CheckCode::F401 => CheckKind::UnusedImport("...".to_string()),
+            CheckCode::F401 => CheckKind::UnusedImport(vec!["...".to_string()]),
             CheckCode::F402 => CheckKind::ImportShadowedByLoopVar("...".to_string(), 1),
             CheckCode::F403 => CheckKind::ImportStarUsed("...".to_string()),
             CheckCode::F404 => CheckKind::LateFutureImport,
@@ -378,6 +432,17 @@ impl CheckCode {
             CheckCode::A001 => CheckKind::BuiltinVariableShadowing("...".to_string()),
             CheckCode::A002 => CheckKind::BuiltinArgumentShadowing("...".to_string()),
             CheckCode::A003 => CheckKind::BuiltinAttributeShadowing("...".to_string()),
+            // flake8-comprehensions
+            CheckCode::C400 => CheckKind::UnnecessaryGeneratorList,
+            CheckCode::C401 => CheckKind::UnnecessaryGeneratorSet,
+            CheckCode::C402 => CheckKind::UnnecessaryGeneratorDict,
+            CheckCode::C403 => CheckKind::UnnecessaryListComprehensionSet,
+            CheckCode::C404 => CheckKind::UnnecessaryListComprehensionDict,
+            CheckCode::C405 => CheckKind::UnnecessaryLiteralSet("<list/tuple>".to_string()),
+            CheckCode::C406 => CheckKind::UnnecessaryLiteralDict("<list/tuple>".to_string()),
+            CheckCode::C408 => {
+                CheckKind::UnnecessaryCollectionCall("<dict/list/tuple>".to_string())
+            }
             // flake8-super
             CheckCode::SPR001 => CheckKind::SuperCallWithParameters,
             // flake8-print
@@ -385,9 +450,10 @@ impl CheckCode {
             CheckCode::T203 => CheckKind::PPrintFound,
             // pyupgrade
             CheckCode::U001 => CheckKind::UselessMetaclassType,
-            // Refactor
-            CheckCode::R001 => CheckKind::UselessObjectInheritance("...".to_string()),
-            CheckCode::R002 => CheckKind::NoAssertEquals,
+            CheckCode::U002 => CheckKind::UnnecessaryAbspath,
+            CheckCode::U003 => CheckKind::TypeOfPrimitive(Primitive::Str),
+            CheckCode::U004 => CheckKind::UselessObjectInheritance("...".to_string()),
+            CheckCode::U005 => CheckKind::NoAssertEquals,
             // Meta
             CheckCode::M001 => CheckKind::UnusedNOQA(None),
         }
@@ -436,7 +502,6 @@ pub enum CheckKind {
     ModuleImportNotAtTopOfFile,
     MultiValueRepeatedKeyLiteral,
     MultiValueRepeatedKeyVariable(String),
-    NoAssertEquals,
     NoneComparison(RejectedCmpop),
     NotInTest,
     NotIsTest,
@@ -449,21 +514,37 @@ pub enum CheckKind {
     UndefinedExport(String),
     UndefinedLocal(String),
     UndefinedName(String),
-    UnusedImport(String),
-    UnusedNOQA(Option<String>),
+    UnusedImport(Vec<String>),
     UnusedVariable(String),
-    UselessMetaclassType,
-    UselessObjectInheritance(String),
     YieldOutsideFunction,
+    // More style
+    NoNewLineAtEndOfFile,
     // flake8-builtin
     BuiltinVariableShadowing(String),
     BuiltinArgumentShadowing(String),
     BuiltinAttributeShadowing(String),
+    // flakes8-comprehensions
+    UnnecessaryGeneratorList,
+    UnnecessaryGeneratorSet,
+    UnnecessaryGeneratorDict,
+    UnnecessaryListComprehensionSet,
+    UnnecessaryListComprehensionDict,
+    UnnecessaryLiteralSet(String),
+    UnnecessaryLiteralDict(String),
+    UnnecessaryCollectionCall(String),
     // flake8-super
     SuperCallWithParameters,
     // flake8-print
     PrintFound,
     PPrintFound,
+    // pyupgrade
+    TypeOfPrimitive(Primitive),
+    UnnecessaryAbspath,
+    UselessMetaclassType,
+    NoAssertEquals,
+    UselessObjectInheritance(String),
+    // Meta
+    UnusedNOQA(Option<String>),
 }
 
 impl CheckKind {
@@ -512,18 +593,30 @@ impl CheckKind {
             CheckKind::UnusedImport(_) => "UnusedImport",
             CheckKind::UnusedVariable(_) => "UnusedVariable",
             CheckKind::YieldOutsideFunction => "YieldOutsideFunction",
+            // More style
+            CheckKind::NoNewLineAtEndOfFile => "NoNewLineAtEndOfFile",
             // flake8-builtins
             CheckKind::BuiltinVariableShadowing(_) => "BuiltinVariableShadowing",
             CheckKind::BuiltinArgumentShadowing(_) => "BuiltinArgumentShadowing",
             CheckKind::BuiltinAttributeShadowing(_) => "BuiltinAttributeShadowing",
+            // flake8-comprehensions
+            CheckKind::UnnecessaryGeneratorList => "UnnecessaryGeneratorList",
+            CheckKind::UnnecessaryGeneratorSet => "UnnecessaryGeneratorSet",
+            CheckKind::UnnecessaryGeneratorDict => "UnnecessaryGeneratorDict",
+            CheckKind::UnnecessaryListComprehensionSet => "UnnecessaryListComprehensionSet",
+            CheckKind::UnnecessaryListComprehensionDict => "UnnecessaryListComprehensionDict",
+            CheckKind::UnnecessaryLiteralSet(_) => "UnnecessaryLiteralSet",
+            CheckKind::UnnecessaryLiteralDict(_) => "UnnecessaryLiteralDict",
+            CheckKind::UnnecessaryCollectionCall(_) => "UnnecessaryCollectionCall",
             // flake8-super
             CheckKind::SuperCallWithParameters => "SuperCallWithParameters",
             // flake8-print
             CheckKind::PrintFound => "PrintFound",
             CheckKind::PPrintFound => "PPrintFound",
             // pyupgrade
+            CheckKind::TypeOfPrimitive(_) => "TypeOfPrimitive",
+            CheckKind::UnnecessaryAbspath => "UnnecessaryAbspath",
             CheckKind::UselessMetaclassType => "UselessMetaclassType",
-            // Refactor
             CheckKind::NoAssertEquals => "NoAssertEquals",
             CheckKind::UselessObjectInheritance(_) => "UselessObjectInheritance",
             // Meta
@@ -576,20 +669,32 @@ impl CheckKind {
             CheckKind::UnusedImport(_) => &CheckCode::F401,
             CheckKind::UnusedVariable(_) => &CheckCode::F841,
             CheckKind::YieldOutsideFunction => &CheckCode::F704,
+            // More style
+            CheckKind::NoNewLineAtEndOfFile => &CheckCode::W292,
             // flake8-builtins
             CheckKind::BuiltinVariableShadowing(_) => &CheckCode::A001,
             CheckKind::BuiltinArgumentShadowing(_) => &CheckCode::A002,
             CheckKind::BuiltinAttributeShadowing(_) => &CheckCode::A003,
+            // flake8-comprehensions
+            CheckKind::UnnecessaryGeneratorList => &CheckCode::C400,
+            CheckKind::UnnecessaryGeneratorSet => &CheckCode::C401,
+            CheckKind::UnnecessaryGeneratorDict => &CheckCode::C402,
+            CheckKind::UnnecessaryListComprehensionSet => &CheckCode::C403,
+            CheckKind::UnnecessaryListComprehensionDict => &CheckCode::C404,
+            CheckKind::UnnecessaryLiteralSet(_) => &CheckCode::C405,
+            CheckKind::UnnecessaryLiteralDict(_) => &CheckCode::C406,
+            CheckKind::UnnecessaryCollectionCall(_) => &CheckCode::C408,
             // flake8-super
             CheckKind::SuperCallWithParameters => &CheckCode::SPR001,
             // flake8-print
             CheckKind::PrintFound => &CheckCode::T201,
             CheckKind::PPrintFound => &CheckCode::T203,
             // pyupgrade
+            CheckKind::TypeOfPrimitive(_) => &CheckCode::U003,
+            CheckKind::UnnecessaryAbspath => &CheckCode::U002,
             CheckKind::UselessMetaclassType => &CheckCode::U001,
-            // Refactor
-            CheckKind::NoAssertEquals => &CheckCode::R002,
-            CheckKind::UselessObjectInheritance(_) => &CheckCode::R001,
+            CheckKind::NoAssertEquals => &CheckCode::U005,
+            CheckKind::UselessObjectInheritance(_) => &CheckCode::U004,
             // Meta
             CheckKind::UnusedNOQA(_) => &CheckCode::M001,
         }
@@ -715,14 +820,18 @@ impl CheckKind {
             CheckKind::UndefinedName(name) => {
                 format!("Undefined name `{name}`")
             }
-            CheckKind::UnusedImport(name) => format!("`{name}` imported but unused"),
+            CheckKind::UnusedImport(names) => {
+                let names = names.iter().map(|name| format!("`{name}`")).join(", ");
+                format!("{names} imported but unused")
+            }
             CheckKind::UnusedVariable(name) => {
                 format!("Local variable `{name}` is assigned to but never used")
             }
             CheckKind::YieldOutsideFunction => {
                 "`yield` or `yield from` statement outside of a function/method".to_string()
             }
-
+            // More style
+            CheckKind::NoNewLineAtEndOfFile => "No newline at end of file".to_string(),
             // flake8-builtins
             CheckKind::BuiltinVariableShadowing(name) => {
                 format!("Variable `{name}` is shadowing a python builtin")
@@ -733,6 +842,31 @@ impl CheckKind {
             CheckKind::BuiltinAttributeShadowing(name) => {
                 format!("Class attribute `{name}` is shadowing a python builtin")
             }
+            // flake8-comprehensions
+            CheckKind::UnnecessaryGeneratorList => {
+                "Unnecessary generator - rewrite as a list comprehension".to_string()
+            }
+            CheckKind::UnnecessaryGeneratorSet => {
+                "Unnecessary generator - rewrite as a set comprehension".to_string()
+            }
+            CheckKind::UnnecessaryGeneratorDict => {
+                "Unnecessary generator - rewrite as a dict comprehension".to_string()
+            }
+            CheckKind::UnnecessaryListComprehensionSet => {
+                "Unnecessary list comprehension - rewrite as a set comprehension".to_string()
+            }
+            CheckKind::UnnecessaryListComprehensionDict => {
+                "Unnecessary list comprehension - rewrite as a dict comprehension".to_string()
+            }
+            CheckKind::UnnecessaryLiteralSet(obj_type) => {
+                format!("Unnecessary {obj_type} literal - rewrite as a set literal")
+            }
+            CheckKind::UnnecessaryLiteralDict(obj_type) => {
+                format!("Unnecessary {obj_type} literal - rewrite as a dict literal")
+            }
+            CheckKind::UnnecessaryCollectionCall(obj_type) => {
+                format!("Unnecessary {obj_type} call - rewrite as a literal")
+            }
             // flake8-super
             CheckKind::SuperCallWithParameters => {
                 "Use `super()` instead of `super(__class__, self)`".to_string()
@@ -741,8 +875,13 @@ impl CheckKind {
             CheckKind::PrintFound => "`print` found".to_string(),
             CheckKind::PPrintFound => "`pprint` found".to_string(),
             // pyupgrade
+            CheckKind::TypeOfPrimitive(primitive) => {
+                format!("Use `{}` instead of `type(...)`", primitive.builtin())
+            }
+            CheckKind::UnnecessaryAbspath => {
+                "`abspath(__file__)` is unnecessary in Python 3.9 and later".to_string()
+            }
             CheckKind::UselessMetaclassType => "`__metaclass__ = type` is implied".to_string(),
-            // Refactor
             CheckKind::NoAssertEquals => {
                 "`assertEquals` is deprecated, use `assertEqual` instead".to_string()
             }
@@ -765,6 +904,8 @@ impl CheckKind {
                 | CheckKind::PPrintFound
                 | CheckKind::PrintFound
                 | CheckKind::SuperCallWithParameters
+                | CheckKind::TypeOfPrimitive(_)
+                | CheckKind::UnnecessaryAbspath
                 | CheckKind::UnusedImport(_)
                 | CheckKind::UnusedNOQA(_)
                 | CheckKind::UselessMetaclassType

src/cli.rs

@@ -0,0 +1,136 @@
+use std::fmt;
+use std::path::PathBuf;
+
+use clap::{command, Parser};
+use log::warn;
+use regex::Regex;
+
+use crate::checks::CheckCode;
+use crate::printer::SerializationFormat;
+use crate::pyproject::StrCheckCodePair;
+use crate::settings::PythonVersion;
+use crate::RawSettings;
+
+#[derive(Debug, Parser)]
+#[command(author, about = "ruff: An extremely fast Python linter.")]
+#[command(version)]
+pub struct Cli {
+    #[arg(required = true)]
+    pub files: Vec<PathBuf>,
+    /// Enable verbose logging.
+    #[arg(short, long)]
+    pub verbose: bool,
+    /// Disable all logging (but still exit with status code "1" upon detecting errors).
+    #[arg(short, long)]
+    pub quiet: bool,
+    /// Exit with status code "0", even upon detecting errors.
+    #[arg(short, long)]
+    pub exit_zero: bool,
+    /// Run in watch mode by re-running whenever files change.
+    #[arg(short, long)]
+    pub watch: bool,
+    /// Attempt to automatically fix lint errors.
+    #[arg(short, long)]
+    pub fix: bool,
+    /// Disable cache reads.
+    #[arg(short, long)]
+    pub no_cache: bool,
+    /// List of error codes to enable.
+    #[arg(long, value_delimiter = ',')]
+    pub select: Vec<CheckCode>,
+    /// Like --select, but adds additional error codes on top of the selected ones.
+    #[arg(long, value_delimiter = ',')]
+    pub extend_select: Vec<CheckCode>,
+    /// List of error codes to ignore.
+    #[arg(long, value_delimiter = ',')]
+    pub ignore: Vec<CheckCode>,
+    /// Like --ignore, but adds additional error codes on top of the ignored ones.
+    #[arg(long, value_delimiter = ',')]
+    pub extend_ignore: Vec<CheckCode>,
+    /// List of paths, used to exclude files and/or directories from checks.
+    #[arg(long, value_delimiter = ',')]
+    pub exclude: Vec<String>,
+    /// Like --exclude, but adds additional files and directories on top of the excluded ones.
+    #[arg(long, value_delimiter = ',')]
+    pub extend_exclude: Vec<String>,
+    /// List of mappings from file pattern to code to exclude
+    #[arg(long, value_delimiter = ',')]
+    pub per_file_ignores: Vec<StrCheckCodePair>,
+    /// Output serialization format for error messages.
+    #[arg(long, value_enum, default_value_t=SerializationFormat::Text)]
+    pub format: SerializationFormat,
+    /// See the files ruff will be run against with the current settings.
+    #[arg(long)]
+    pub show_files: bool,
+    /// See ruff's settings.
+    #[arg(long)]
+    pub show_settings: bool,
+    /// Enable automatic additions of noqa directives to failing lines.
+    #[arg(long)]
+    pub add_noqa: bool,
+    /// Regular expression matching the name of dummy variables.
+    #[arg(long)]
+    pub dummy_variable_rgx: Option<Regex>,
+    /// The minimum Python version that should be supported.
+    #[arg(long)]
+    pub target_version: Option<PythonVersion>,
+    /// Round-trip auto-formatting.
+    // TODO(charlie): This should be a sub-command.
+    #[arg(long, hide = true)]
+    pub autoformat: bool,
+}
+
+pub enum Warnable {
+    Select,
+    ExtendSelect,
+}
+
+impl fmt::Display for Warnable {
+    fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
+        match self {
+            Warnable::Select => fmt.write_str("--select"),
+            Warnable::ExtendSelect => fmt.write_str("--extend-select"),
+        }
+    }
+}
+
+/// Warn the user if they attempt to enable a code that won't be respected.
+pub fn warn_on(
+    flag: Warnable,
+    codes: &Vec<CheckCode>,
+    cli_ignore: &Vec<CheckCode>,
+    cli_extend_ignore: &Vec<CheckCode>,
+    pyproject_settings: &RawSettings,
+    pyproject_path: &Option<PathBuf>,
+) {
+    for code in codes {
+        if !cli_ignore.is_empty() {
+            if cli_ignore.contains(code) {
+                warn!("{code:?} was passed to {flag}, but ignored via --ignore")
+            }
+        } else if pyproject_settings.ignore.contains(code) {
+            if let Some(path) = pyproject_path {
+                warn!(
+                    "{code:?} was passed to {flag}, but ignored by the `ignore` field in {}",
+                    path.to_string_lossy()
+                )
+            } else {
+                warn!("{code:?} was passed to {flag}, but ignored by the default `ignore` field",)
+            }
+        }
+        if !cli_extend_ignore.is_empty() {
+            if cli_extend_ignore.contains(code) {
+                warn!("{code:?} was passed to {flag}, but ignored via --extend-ignore")
+            }
+        } else if pyproject_settings.extend_ignore.contains(code) {
+            if let Some(path) = pyproject_path {
+                warn!(
+                    "{code:?} was passed to {flag}, but ignored by the `extend_ignore` field in {}",
+                    path.to_string_lossy()
+                )
+            } else {
+                warn!("{code:?} was passed to {flag}, but ignored by the default `extend_ignore` field")
+            }
+        }
+    }
+}

src/lib.rs

@@ -15,6 +15,7 @@ pub mod cache;
 pub mod check_ast;
 mod check_lines;
 pub mod checks;
+pub mod cli;
 pub mod code_gen;
 pub mod fs;
 pub mod linter;
@@ -41,7 +42,7 @@ pub fn check(path: &Path, contents: &str) -> Result<Vec<Message>> {
         None => debug!("Unable to find pyproject.toml; using default settings..."),
     };
 
-    let settings = Settings::from_raw(RawSettings::from_pyproject(pyproject, project_root)?);
+    let settings = Settings::from_raw(RawSettings::from_pyproject(&pyproject, &project_root)?);
 
     // Tokenize once.
     let tokens: Vec<LexResult> = tokenize(contents);

src/linter.rs

@@ -339,6 +339,42 @@ mod tests {
         Ok(())
     }
 
+    #[test]
+    fn w292_0() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/W292_0.py"),
+            &settings::Settings::for_rule(CheckCode::W292),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn w292_1() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/W292_1.py"),
+            &settings::Settings::for_rule(CheckCode::W292),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn w292_2() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/W292_2.py"),
+            &settings::Settings::for_rule(CheckCode::W292),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
     #[test]
     fn f401() -> Result<()> {
         let mut checks = check_path(
@@ -690,30 +726,6 @@ mod tests {
         Ok(())
     }
 
-    #[test]
-    fn r001() -> Result<()> {
-        let mut checks = check_path(
-            Path::new("./resources/test/fixtures/R001.py"),
-            &settings::Settings::for_rule(CheckCode::R001),
-            &fixer::Mode::Generate,
-        )?;
-        checks.sort_by_key(|check| check.location);
-        insta::assert_yaml_snapshot!(checks);
-        Ok(())
-    }
-
-    #[test]
-    fn r002() -> Result<()> {
-        let mut checks = check_path(
-            Path::new("./resources/test/fixtures/R002.py"),
-            &settings::Settings::for_rule(CheckCode::R002),
-            &fixer::Mode::Generate,
-        )?;
-        checks.sort_by_key(|check| check.location);
-        insta::assert_yaml_snapshot!(checks);
-        Ok(())
-    }
-
     #[test]
     fn init() -> Result<()> {
         let mut checks = check_path(
@@ -786,6 +798,102 @@ mod tests {
         Ok(())
     }
 
+    #[test]
+    fn c400() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/C400.py"),
+            &settings::Settings::for_rule(CheckCode::C400),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn c401() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/C401.py"),
+            &settings::Settings::for_rule(CheckCode::C401),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn c402() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/C402.py"),
+            &settings::Settings::for_rule(CheckCode::C402),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn c403() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/C403.py"),
+            &settings::Settings::for_rule(CheckCode::C403),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn c404() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/C404.py"),
+            &settings::Settings::for_rule(CheckCode::C404),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn c405() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/C405.py"),
+            &settings::Settings::for_rule(CheckCode::C405),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn c406() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/C406.py"),
+            &settings::Settings::for_rule(CheckCode::C406),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn c408() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/C408.py"),
+            &settings::Settings::for_rule(CheckCode::C408),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
     #[test]
     fn spr001() -> Result<()> {
         let mut checks = check_path(
@@ -833,4 +941,52 @@ mod tests {
         insta::assert_yaml_snapshot!(checks);
         Ok(())
     }
+
+    #[test]
+    fn u002() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/U002.py"),
+            &settings::Settings::for_rule(CheckCode::U002),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn u003() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/U003.py"),
+            &settings::Settings::for_rule(CheckCode::U003),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn u004() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/U004.py"),
+            &settings::Settings::for_rule(CheckCode::U004),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
+
+    #[test]
+    fn u005() -> Result<()> {
+        let mut checks = check_path(
+            Path::new("./resources/test/fixtures/U005.py"),
+            &settings::Settings::for_rule(CheckCode::U005),
+            &fixer::Mode::Generate,
+        )?;
+        checks.sort_by_key(|check| check.location);
+        insta::assert_yaml_snapshot!(checks);
+        Ok(())
+    }
 }

src/main.rs

@@ -5,98 +5,33 @@ use std::sync::mpsc::channel;
 use std::time::Instant;
 
 use anyhow::Result;
-use clap::{command, Parser};
+use clap::Parser;
 use colored::Colorize;
 use log::{debug, error};
 use notify::{raw_watcher, RecursiveMode, Watcher};
 use rayon::prelude::*;
-use regex::Regex;
 use walkdir::DirEntry;
 
-use ::ruff::cache;
-use ::ruff::checks::CheckCode;
-use ::ruff::checks::CheckKind;
-use ::ruff::fs::iter_python_files;
-use ::ruff::linter::add_noqa_to_path;
-use ::ruff::linter::lint_path;
-use ::ruff::logging::set_up_logging;
-use ::ruff::message::Message;
-use ::ruff::printer::{Printer, SerializationFormat};
-use ::ruff::pyproject::{self, StrCheckCodePair};
-use ::ruff::settings::CurrentSettings;
-use ::ruff::settings::{FilePattern, PerFileIgnore, Settings};
-use ::ruff::tell_user;
+use ruff::cache;
+use ruff::checks::CheckCode;
+use ruff::checks::CheckKind;
+use ruff::cli::{warn_on, Cli, Warnable};
+use ruff::fs::iter_python_files;
+use ruff::linter::add_noqa_to_path;
 use ruff::linter::autoformat_path;
+use ruff::linter::lint_path;
+use ruff::logging::set_up_logging;
+use ruff::message::Message;
+use ruff::printer::{Printer, SerializationFormat};
+use ruff::pyproject::{self};
+use ruff::settings::CurrentSettings;
 use ruff::settings::RawSettings;
+use ruff::settings::{FilePattern, PerFileIgnore, Settings};
+use ruff::tell_user;
 
 const CARGO_PKG_NAME: &str = env!("CARGO_PKG_NAME");
 const CARGO_PKG_VERSION: &str = env!("CARGO_PKG_VERSION");
 
-#[derive(Debug, Parser)]
-#[command(author, about = "ruff: An extremely fast Python linter.")]
-#[command(version)]
-struct Cli {
-    #[arg(required = true)]
-    files: Vec<PathBuf>,
-    /// Enable verbose logging.
-    #[arg(short, long)]
-    verbose: bool,
-    /// Disable all logging (but still exit with status code "1" upon detecting errors).
-    #[arg(short, long)]
-    quiet: bool,
-    /// Exit with status code "0", even upon detecting errors.
-    #[arg(short, long)]
-    exit_zero: bool,
-    /// Run in watch mode by re-running whenever files change.
-    #[arg(short, long)]
-    watch: bool,
-    /// Attempt to automatically fix lint errors.
-    #[arg(short, long)]
-    fix: bool,
-    /// Disable cache reads.
-    #[arg(short, long)]
-    no_cache: bool,
-    /// List of error codes to enable.
-    #[arg(long, value_delimiter = ',')]
-    select: Vec<CheckCode>,
-    /// Like --select, but adds additional error codes on top of the selected ones.
-    #[arg(long, value_delimiter = ',')]
-    extend_select: Vec<CheckCode>,
-    /// List of error codes to ignore.
-    #[arg(long, value_delimiter = ',')]
-    ignore: Vec<CheckCode>,
-    /// Like --ignore, but adds additional error codes on top of the ignored ones.
-    #[arg(long, value_delimiter = ',')]
-    extend_ignore: Vec<CheckCode>,
-    /// List of paths, used to exclude files and/or directories from checks.
-    #[arg(long, value_delimiter = ',')]
-    exclude: Vec<String>,
-    /// Like --exclude, but adds additional files and directories on top of the excluded ones.
-    #[arg(long, value_delimiter = ',')]
-    extend_exclude: Vec<String>,
-    /// List of mappings from file pattern to code to exclude
-    #[arg(long, value_delimiter = ',')]
-    per_file_ignores: Vec<StrCheckCodePair>,
-    /// Output serialization format for error messages.
-    #[arg(long, value_enum, default_value_t=SerializationFormat::Text)]
-    format: SerializationFormat,
-    /// See the files ruff will be run against with the current settings.
-    #[arg(long)]
-    show_files: bool,
-    /// See ruff's settings.
-    #[arg(long)]
-    show_settings: bool,
-    /// Enable automatic additions of noqa directives to failing lines.
-    #[arg(long)]
-    add_noqa: bool,
-    /// Enable automatic formatting.
-    #[arg(long)]
-    autoformat: bool,
-    /// Regular expression matching the name of dummy variables.
-    #[arg(long)]
-    dummy_variable_rgx: Option<Regex>,
-}
-
 #[cfg(feature = "update-informer")]
 fn check_for_updates() {
     use update_informer::{registry, Check};
@@ -121,8 +56,11 @@ fn check_for_updates() {
     }
 }
 
-fn show_settings(settings: RawSettings) {
-    println!("{:#?}", CurrentSettings::from_settings(settings));
+fn show_settings(settings: RawSettings, project_root: Option<PathBuf>, pyproject: Option<PathBuf>) {
+    println!(
+        "{:#?}",
+        CurrentSettings::from_settings(settings, project_root, pyproject)
+    );
 }
 
 fn show_files(files: &[PathBuf], settings: &Settings) {
@@ -288,7 +226,7 @@ fn inner_main() -> Result<ExitCode> {
         .map(|pair| PerFileIgnore::new(pair, &project_root))
         .collect();
 
-    let mut settings = RawSettings::from_pyproject(pyproject, project_root)?;
+    let mut settings = RawSettings::from_pyproject(&pyproject, &project_root)?;
     if !exclude.is_empty() {
         settings.exclude = exclude;
     }
@@ -299,9 +237,25 @@ fn inner_main() -> Result<ExitCode> {
         settings.per_file_ignores = per_file_ignores;
     }
     if !cli.select.is_empty() {
+        warn_on(
+            Warnable::Select,
+            &cli.select,
+            &cli.ignore,
+            &cli.extend_ignore,
+            &settings,
+            &pyproject,
+        );
         settings.select = cli.select;
     }
     if !cli.extend_select.is_empty() {
+        warn_on(
+            Warnable::ExtendSelect,
+            &cli.extend_select,
+            &cli.ignore,
+            &cli.extend_ignore,
+            &settings,
+            &pyproject,
+        );
         settings.extend_select = cli.extend_select;
     }
     if !cli.ignore.is_empty() {
@@ -310,6 +264,9 @@ fn inner_main() -> Result<ExitCode> {
     if !cli.extend_ignore.is_empty() {
         settings.extend_ignore = cli.extend_ignore;
     }
+    if let Some(target_version) = cli.target_version {
+        settings.target_version = target_version;
+    }
     if let Some(dummy_variable_rgx) = cli.dummy_variable_rgx {
         settings.dummy_variable_rgx = dummy_variable_rgx;
     }
@@ -319,7 +276,7 @@ fn inner_main() -> Result<ExitCode> {
         return Ok(ExitCode::FAILURE);
     }
     if cli.show_settings {
-        show_settings(settings);
+        show_settings(settings, project_root, pyproject);
         return Ok(ExitCode::SUCCESS);
     }
 
@@ -403,7 +360,7 @@ fn inner_main() -> Result<ExitCode> {
         #[cfg(feature = "update-informer")]
         check_for_updates();
 
-        if !messages.is_empty() && !cli.exit_zero {
+        if messages.iter().any(|message| !message.fixed) && !cli.exit_zero {
             return Ok(ExitCode::FAILURE);
         }
     }

src/noqa.rs

@@ -104,9 +104,7 @@ fn add_noqa_inner(
             .unwrap_or(lineno);
 
         if !codes.is_empty() {
-            let matches = matches_by_line
-                .entry(noqa_lineno)
-                .or_insert_with(BTreeSet::new);
+            let matches = matches_by_line.entry(noqa_lineno).or_default();
             matches.append(&mut codes);
         }
     }

src/plugins.rs

@@ -4,6 +4,8 @@ mod if_tuple;
 mod invalid_print_syntax;
 mod print_call;
 mod super_call_with_parameters;
+mod type_of_primitive;
+mod unnecessary_abspath;
 mod useless_metaclass_type;
 mod useless_object_inheritance;
 
@@ -13,5 +15,7 @@ pub use if_tuple::if_tuple;
 pub use invalid_print_syntax::invalid_print_syntax;
 pub use print_call::print_call;
 pub use super_call_with_parameters::super_call_with_parameters;
+pub use type_of_primitive::type_of_primitive;
+pub use unnecessary_abspath::unnecessary_abspath;
 pub use useless_metaclass_type::useless_metaclass_type;
 pub use useless_object_inheritance::useless_object_inheritance;

src/plugins/type_of_primitive.rs

@@ -0,0 +1,25 @@
+use rustpython_ast::Expr;
+
+use crate::ast::checks;
+use crate::ast::types::{CheckLocator, Range};
+use crate::autofix::fixer;
+use crate::check_ast::Checker;
+use crate::checks::{CheckKind, Fix};
+
+pub fn type_of_primitive(checker: &mut Checker, expr: &Expr, func: &Expr, args: &Vec<Expr>) {
+    if let Some(mut check) =
+        checks::check_type_of_primitive(func, args, checker.locate_check(Range::from_located(expr)))
+    {
+        if matches!(checker.autofix, fixer::Mode::Generate | fixer::Mode::Apply) {
+            if let CheckKind::TypeOfPrimitive(primitive) = &check.kind {
+                check.amend(Fix {
+                    content: primitive.builtin(),
+                    location: expr.location,
+                    end_location: expr.end_location,
+                    applied: false,
+                });
+            }
+        }
+        checker.add_check(check);
+    }
+}

src/plugins/unnecessary_abspath.rs

@@ -0,0 +1,25 @@
+use rustpython_ast::Expr;
+
+use crate::ast::checks;
+use crate::ast::types::{CheckLocator, Range};
+use crate::autofix::fixer;
+use crate::check_ast::Checker;
+use crate::checks::Fix;
+
+pub fn unnecessary_abspath(checker: &mut Checker, expr: &Expr, func: &Expr, args: &Vec<Expr>) {
+    if let Some(mut check) = checks::check_unnecessary_abspath(
+        func,
+        args,
+        checker.locate_check(Range::from_located(expr)),
+    ) {
+        if matches!(checker.autofix, fixer::Mode::Generate | fixer::Mode::Apply) {
+            check.amend(Fix {
+                content: "__file__".to_string(),
+                location: expr.location,
+                end_location: expr.end_location,
+                applied: false,
+            });
+        }
+        checker.add_check(check);
+    }
+}

src/pyproject.rs

@@ -9,6 +9,7 @@ use serde::{Deserialize, Deserializer};
 
 use crate::checks::CheckCode;
 use crate::fs;
+use crate::settings::PythonVersion;
 
 pub fn load_config(pyproject: &Option<PathBuf>) -> Result<Config> {
     match pyproject {
@@ -41,6 +42,7 @@ pub struct Config {
     #[serde(default)]
     pub per_file_ignores: Vec<StrCheckCodePair>,
     pub dummy_variable_rgx: Option<String>,
+    pub target_version: Option<PythonVersion>,
 }
 
 #[derive(Clone, Debug, PartialEq, Eq)]
@@ -189,6 +191,7 @@ mod tests {
                     extend_ignore: vec![],
                     per_file_ignores: vec![],
                     dummy_variable_rgx: None,
+                    target_version: None,
                 })
             })
         );
@@ -213,6 +216,7 @@ line-length = 79
                     extend_ignore: vec![],
                     per_file_ignores: vec![],
                     dummy_variable_rgx: None,
+                    target_version: None,
                 })
             })
         );
@@ -237,6 +241,7 @@ exclude = ["foo.py"]
                     extend_ignore: vec![],
                     per_file_ignores: vec![],
                     dummy_variable_rgx: None,
+                    target_version: None,
                 })
             })
         );
@@ -261,6 +266,7 @@ select = ["E501"]
                     extend_ignore: vec![],
                     per_file_ignores: vec![],
                     dummy_variable_rgx: None,
+                    target_version: None,
                 })
             })
         );
@@ -286,6 +292,7 @@ ignore = ["E501"]
                     extend_ignore: vec![],
                     per_file_ignores: vec![],
                     dummy_variable_rgx: None,
+                    target_version: None,
                 })
             })
         );
@@ -354,6 +361,7 @@ other-attribute = 1
                 extend_ignore: vec![],
                 per_file_ignores: vec![],
                 dummy_variable_rgx: None,
+                target_version: None,
             }
         );
 

src/settings.rs

@@ -1,16 +1,50 @@
 use std::collections::BTreeSet;
 use std::hash::{Hash, Hasher};
 use std::path::{Path, PathBuf};
+use std::str::FromStr;
 
 use anyhow::{anyhow, Result};
 use glob::Pattern;
 use once_cell::sync::Lazy;
 use regex::Regex;
+use serde::{Deserialize, Serialize};
 
 use crate::checks::{CheckCode, DEFAULT_CHECK_CODES};
 use crate::fs;
 use crate::pyproject::{load_config, StrCheckCodePair};
 
+#[derive(Clone, Debug, PartialOrd, PartialEq, Eq, Serialize, Deserialize)]
+pub enum PythonVersion {
+    Py33,
+    Py34,
+    Py35,
+    Py36,
+    Py37,
+    Py38,
+    Py39,
+    Py310,
+    Py311,
+}
+
+impl FromStr for PythonVersion {
+    type Err = anyhow::Error;
+
+    fn from_str(string: &str) -> Result<Self, Self::Err> {
+        match string {
+            "py33" => Ok(PythonVersion::Py33),
+            "py34" => Ok(PythonVersion::Py34),
+            "py35" => Ok(PythonVersion::Py35),
+            "py36" => Ok(PythonVersion::Py36),
+            "py37" => Ok(PythonVersion::Py37),
+            "py38" => Ok(PythonVersion::Py38),
+            "py39" => Ok(PythonVersion::Py39),
+            "py310" => Ok(PythonVersion::Py310),
+            "py311" => Ok(PythonVersion::Py311),
+            _ => Err(anyhow!("Unknown version: {}", string)),
+        }
+    }
+}
+
 #[derive(Debug, Clone, Hash)]
 pub enum FilePattern {
     Simple(&'static str),
@@ -60,9 +94,8 @@ pub struct RawSettings {
     pub ignore: Vec<CheckCode>,
     pub line_length: usize,
     pub per_file_ignores: Vec<PerFileIgnore>,
-    pub project_root: Option<PathBuf>,
-    pub pyproject: Option<PathBuf>,
     pub select: Vec<CheckCode>,
+    pub target_version: PythonVersion,
 }
 
 static DEFAULT_EXCLUDE: Lazy<Vec<FilePattern>> = Lazy::new(|| {
@@ -94,44 +127,43 @@ static DEFAULT_DUMMY_VARIABLE_RGX: Lazy<Regex> =
 
 impl RawSettings {
     pub fn from_pyproject(
-        pyproject: Option<PathBuf>,
-        project_root: Option<PathBuf>,
+        pyproject: &Option<PathBuf>,
+        project_root: &Option<PathBuf>,
     ) -> Result<Self> {
-        let config = load_config(&pyproject)?;
+        let config = load_config(pyproject)?;
         Ok(RawSettings {
             dummy_variable_rgx: match config.dummy_variable_rgx {
                 Some(pattern) => Regex::new(&pattern)
                     .map_err(|e| anyhow!("Invalid dummy-variable-rgx value: {e}"))?,
                 None => DEFAULT_DUMMY_VARIABLE_RGX.clone(),
             },
+            target_version: config.target_version.unwrap_or(PythonVersion::Py310),
             exclude: config
                 .exclude
                 .map(|paths| {
                     paths
                         .iter()
-                        .map(|path| FilePattern::from_user(path, &project_root))
+                        .map(|path| FilePattern::from_user(path, project_root))
                         .collect()
                 })
                 .unwrap_or_else(|| DEFAULT_EXCLUDE.clone()),
             extend_exclude: config
                 .extend_exclude
                 .iter()
-                .map(|path| FilePattern::from_user(path, &project_root))
+                .map(|path| FilePattern::from_user(path, project_root))
                 .collect(),
             extend_ignore: config.extend_ignore,
+            select: config
+                .select
+                .unwrap_or_else(|| DEFAULT_CHECK_CODES.to_vec()),
             extend_select: config.extend_select,
             ignore: config.ignore,
             line_length: config.line_length.unwrap_or(88),
             per_file_ignores: config
                 .per_file_ignores
                 .into_iter()
-                .map(|pair| PerFileIgnore::new(pair, &project_root))
+                .map(|pair| PerFileIgnore::new(pair, project_root))
                 .collect(),
-            project_root,
-            pyproject,
-            select: config
-                .select
-                .unwrap_or_else(|| DEFAULT_CHECK_CODES.to_vec()),
         })
     }
 }
@@ -144,6 +176,7 @@ pub struct Settings {
     pub extend_exclude: Vec<FilePattern>,
     pub line_length: usize,
     pub per_file_ignores: Vec<PerFileIgnore>,
+    pub target_version: PythonVersion,
 }
 
 impl Settings {
@@ -165,6 +198,7 @@ impl Settings {
             extend_exclude: settings.extend_exclude,
             line_length: settings.line_length,
             per_file_ignores: settings.per_file_ignores,
+            target_version: PythonVersion::Py310,
         }
     }
 
@@ -176,6 +210,7 @@ impl Settings {
             extend_exclude: vec![],
             line_length: 88,
             per_file_ignores: vec![],
+            target_version: PythonVersion::Py310,
         }
     }
 
@@ -187,6 +222,7 @@ impl Settings {
             extend_exclude: vec![],
             line_length: 88,
             per_file_ignores: vec![],
+            target_version: PythonVersion::Py310,
         }
     }
 }
@@ -238,13 +274,18 @@ pub struct CurrentSettings {
     pub ignore: Vec<CheckCode>,
     pub line_length: usize,
     pub per_file_ignores: Vec<PerFileIgnore>,
+    pub select: Vec<CheckCode>,
+    pub target_version: PythonVersion,
     pub project_root: Option<PathBuf>,
     pub pyproject: Option<PathBuf>,
-    pub select: Vec<CheckCode>,
 }
 
 impl CurrentSettings {
-    pub fn from_settings(settings: RawSettings) -> Self {
+    pub fn from_settings(
+        settings: RawSettings,
+        project_root: Option<PathBuf>,
+        pyproject: Option<PathBuf>,
+    ) -> Self {
         Self {
             dummy_variable_rgx: settings.dummy_variable_rgx,
             exclude: settings
@@ -262,9 +303,10 @@ impl CurrentSettings {
             ignore: settings.ignore,
             line_length: settings.line_length,
             per_file_ignores: settings.per_file_ignores,
-            project_root: settings.project_root,
-            pyproject: settings.pyproject,
             select: settings.select,
+            target_version: settings.target_version,
+            project_root,
+            pyproject,
         }
     }
 }

src/snapshots/ruff__linter__tests__c400.snap

@@ -0,0 +1,13 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind: UnnecessaryGeneratorList
+  location:
+    row: 1
+    column: 5
+  end_location:
+    row: 1
+    column: 30
+  fix: ~
+

src/snapshots/ruff__linter__tests__c401.snap

@@ -0,0 +1,13 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind: UnnecessaryGeneratorList
+  location:
+    row: 1
+    column: 5
+  end_location:
+    row: 1
+    column: 29
+  fix: ~
+

src/snapshots/ruff__linter__tests__c402.snap

@@ -0,0 +1,13 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind: UnnecessaryListComprehensionDict
+  location:
+    row: 1
+    column: 5
+  end_location:
+    row: 1
+    column: 35
+  fix: ~
+

src/snapshots/ruff__linter__tests__c403.snap

@@ -0,0 +1,13 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind: UnnecessaryListComprehensionSet
+  location:
+    row: 1
+    column: 5
+  end_location:
+    row: 1
+    column: 31
+  fix: ~
+

src/snapshots/ruff__linter__tests__c404.snap

@@ -0,0 +1,13 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind: UnnecessaryListComprehensionDict
+  location:
+    row: 1
+    column: 5
+  end_location:
+    row: 1
+    column: 37
+  fix: ~
+

src/snapshots/ruff__linter__tests__c405.snap

@@ -0,0 +1,41 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind:
+    UnnecessaryLiteralSet: list
+  location:
+    row: 1
+    column: 6
+  end_location:
+    row: 1
+    column: 17
+  fix: ~
+- kind:
+    UnnecessaryLiteralSet: tuple
+  location:
+    row: 2
+    column: 6
+  end_location:
+    row: 2
+    column: 17
+  fix: ~
+- kind:
+    UnnecessaryLiteralSet: list
+  location:
+    row: 3
+    column: 6
+  end_location:
+    row: 3
+    column: 13
+  fix: ~
+- kind:
+    UnnecessaryLiteralSet: tuple
+  location:
+    row: 4
+    column: 6
+  end_location:
+    row: 4
+    column: 13
+  fix: ~
+

src/snapshots/ruff__linter__tests__c406.snap

@@ -0,0 +1,41 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind:
+    UnnecessaryLiteralDict: list
+  location:
+    row: 1
+    column: 6
+  end_location:
+    row: 1
+    column: 20
+  fix: ~
+- kind:
+    UnnecessaryLiteralDict: tuple
+  location:
+    row: 2
+    column: 6
+  end_location:
+    row: 2
+    column: 21
+  fix: ~
+- kind:
+    UnnecessaryLiteralDict: list
+  location:
+    row: 3
+    column: 6
+  end_location:
+    row: 3
+    column: 14
+  fix: ~
+- kind:
+    UnnecessaryLiteralDict: tuple
+  location:
+    row: 4
+    column: 6
+  end_location:
+    row: 4
+    column: 14
+  fix: ~
+

src/snapshots/ruff__linter__tests__c408.snap

@@ -0,0 +1,41 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind:
+    UnnecessaryCollectionCall: tuple
+  location:
+    row: 1
+    column: 5
+  end_location:
+    row: 1
+    column: 12
+  fix: ~
+- kind:
+    UnnecessaryCollectionCall: list
+  location:
+    row: 2
+    column: 5
+  end_location:
+    row: 2
+    column: 11
+  fix: ~
+- kind:
+    UnnecessaryCollectionCall: dict
+  location:
+    row: 3
+    column: 6
+  end_location:
+    row: 3
+    column: 12
+  fix: ~
+- kind:
+    UnnecessaryCollectionCall: dict
+  location:
+    row: 4
+    column: 6
+  end_location:
+    row: 4
+    column: 15
+  fix: ~
+

src/snapshots/ruff__linter__tests__f401.snap

@@ -3,7 +3,8 @@ source: src/linter.rs
 expression: checks
 ---
 - kind:
-    UnusedImport: functools
+    UnusedImport:
+      - functools
   location:
     row: 2
     column: 1
@@ -20,7 +21,8 @@ expression: checks
       column: 21
     applied: false
 - kind:
-    UnusedImport: collections.OrderedDict
+    UnusedImport:
+      - collections.OrderedDict
   location:
     row: 4
     column: 1
@@ -37,7 +39,8 @@ expression: checks
       column: 2
     applied: false
 - kind:
-    UnusedImport: logging.handlers
+    UnusedImport:
+      - logging.handlers
   location:
     row: 12
     column: 1
@@ -54,7 +57,8 @@ expression: checks
       column: 24
     applied: false
 - kind:
-    UnusedImport: shelve
+    UnusedImport:
+      - shelve
   location:
     row: 33
     column: 5
@@ -71,7 +75,8 @@ expression: checks
       column: 1
     applied: false
 - kind:
-    UnusedImport: importlib
+    UnusedImport:
+      - importlib
   location:
     row: 34
     column: 5
@@ -79,16 +84,17 @@ expression: checks
     row: 34
     column: 21
   fix:
-    content: pass
+    content: ""
     location:
       row: 34
-      column: 5
+      column: 1
     end_location:
-      row: 34
-      column: 21
+      row: 35
+      column: 1
     applied: false
 - kind:
-    UnusedImport: pathlib
+    UnusedImport:
+      - pathlib
   location:
     row: 38
     column: 5
@@ -105,7 +111,8 @@ expression: checks
       column: 1
     applied: false
 - kind:
-    UnusedImport: pickle
+    UnusedImport:
+      - pickle
   location:
     row: 53
     column: 9

src/snapshots/ruff__linter__tests__future_annotations.snap

@@ -3,7 +3,8 @@ source: src/linter.rs
 expression: checks
 ---
 - kind:
-    UnusedImport: models.Nut
+    UnusedImport:
+      - models.Nut
   location:
     row: 5
     column: 1

src/snapshots/ruff__linter__tests__u002.snap

@@ -0,0 +1,53 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind: UnnecessaryAbspath
+  location:
+    row: 3
+    column: 5
+  end_location:
+    row: 3
+    column: 22
+  fix:
+    content: __file__
+    location:
+      row: 3
+      column: 5
+    end_location:
+      row: 3
+      column: 22
+    applied: false
+- kind: UnnecessaryAbspath
+  location:
+    row: 9
+    column: 5
+  end_location:
+    row: 9
+    column: 30
+  fix:
+    content: __file__
+    location:
+      row: 9
+      column: 5
+    end_location:
+      row: 9
+      column: 30
+    applied: false
+- kind: UnnecessaryAbspath
+  location:
+    row: 15
+    column: 5
+  end_location:
+    row: 15
+    column: 27
+  fix:
+    content: __file__
+    location:
+      row: 15
+      column: 5
+    end_location:
+      row: 15
+      column: 27
+    applied: false
+

src/snapshots/ruff__linter__tests__u003.snap

@@ -0,0 +1,90 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind:
+    TypeOfPrimitive: Str
+  location:
+    row: 1
+    column: 1
+  end_location:
+    row: 1
+    column: 9
+  fix:
+    content: str
+    location:
+      row: 1
+      column: 1
+    end_location:
+      row: 1
+      column: 9
+    applied: false
+- kind:
+    TypeOfPrimitive: Bytes
+  location:
+    row: 2
+    column: 1
+  end_location:
+    row: 2
+    column: 10
+  fix:
+    content: bytes
+    location:
+      row: 2
+      column: 1
+    end_location:
+      row: 2
+      column: 10
+    applied: false
+- kind:
+    TypeOfPrimitive: Int
+  location:
+    row: 3
+    column: 1
+  end_location:
+    row: 3
+    column: 8
+  fix:
+    content: int
+    location:
+      row: 3
+      column: 1
+    end_location:
+      row: 3
+      column: 8
+    applied: false
+- kind:
+    TypeOfPrimitive: Float
+  location:
+    row: 4
+    column: 1
+  end_location:
+    row: 4
+    column: 9
+  fix:
+    content: float
+    location:
+      row: 4
+      column: 1
+    end_location:
+      row: 4
+      column: 9
+    applied: false
+- kind:
+    TypeOfPrimitive: Complex
+  location:
+    row: 5
+    column: 1
+  end_location:
+    row: 5
+    column: 9
+  fix:
+    content: complex
+    location:
+      row: 5
+      column: 1
+    end_location:
+      row: 5
+      column: 9
+    applied: false
+

src/snapshots/ruff__linter__tests__w292.snap

@@ -0,0 +1,13 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind: NoNewLineAtEndOfFile
+  location:
+    row: 2
+    column: 9
+  end_location:
+    row: 2
+    column: 9
+  fix: ~
+

src/snapshots/ruff__linter__tests__w292_0.snap

@@ -0,0 +1,13 @@
+---
+source: src/linter.rs
+expression: checks
+---
+- kind: NoNewLineAtEndOfFile
+  location:
+    row: 2
+    column: 9
+  end_location:
+    row: 2
+    column: 9
+  fix: ~
+

src/snapshots/ruff__linter__tests__w292_1.snap

@@ -0,0 +1,6 @@
+---
+source: src/linter.rs
+expression: checks
+---
+[]
+

src/snapshots/ruff__linter__tests__w292_2.snap

@@ -0,0 +1,6 @@
+---
+source: src/linter.rs
+expression: checks
+---
+[]
+