Merge pull request #9588 from kareem-wolfssl/ghAlerts

Fix incorrect alerts.

src/internal.c

@@ -35268,6 +35268,8 @@ static int DoSessionTicket(WOLFSSL* ssl, const byte* input, word32* inOutIdx,
                 return wolfssl_alert_protocol_version;
             case WC_NO_ERR_TRACE(BAD_CERTIFICATE_STATUS_ERROR):
                 return bad_certificate_status_response;
+            case WC_NO_ERR_TRACE(OUT_OF_ORDER_E):
+                return unexpected_message;
             default:
                 return invalid_alert;
         }

src/tls.c

@@ -11607,7 +11607,7 @@ static int TLSX_PreSharedKey_Parse(WOLFSSL* ssl, const byte* input,
         /* Find the list of identities sent to server. */
         extension = TLSX_Find(ssl->extensions, TLSX_PRE_SHARED_KEY);
         if (extension == NULL)
-            return PSK_KEY_ERROR;
+            return INCOMPLETE_DATA;
         list = (PreSharedKey*)extension->data;
 
         /* Mark the identity as chosen. */

src/x509.c

@@ -3448,25 +3448,25 @@ int wolfSSL_X509_pubkey_digest(const WOLFSSL_X509 *x509,
     const char* wolfSSL_X509_get_default_cert_file_env(void)
     {
         WOLFSSL_STUB("X509_get_default_cert_file_env");
-        return NULL;
+        return "";
     }
 
     const char* wolfSSL_X509_get_default_cert_file(void)
     {
         WOLFSSL_STUB("X509_get_default_cert_file");
-        return NULL;
+        return "";
     }
 
     const char* wolfSSL_X509_get_default_cert_dir_env(void)
     {
         WOLFSSL_STUB("X509_get_default_cert_dir_env");
-        return NULL;
+        return "";
     }
 
     const char* wolfSSL_X509_get_default_cert_dir(void)
     {
         WOLFSSL_STUB("X509_get_default_cert_dir");
-        return NULL;
+        return "";
     }
     #endif
 

tests/api/test_ossl_x509.c

@@ -528,10 +528,10 @@ int test_wolfSSL_X509(void)
     ExpectIntEQ(X509_verify_cert(ctx), SSL_SUCCESS);
 
 #ifndef NO_WOLFSSL_STUB
-    ExpectNull(X509_get_default_cert_file_env());
-    ExpectNull(X509_get_default_cert_file());
-    ExpectNull(X509_get_default_cert_dir_env());
-    ExpectNull(X509_get_default_cert_dir());
+    ExpectStrEQ(X509_get_default_cert_file_env(), "");
+    ExpectStrEQ(X509_get_default_cert_file(), "");
+    ExpectStrEQ(X509_get_default_cert_dir_env(), "");
+    ExpectStrEQ(X509_get_default_cert_dir(), "");
 #endif
 
     ExpectNull(wolfSSL_X509_get_der(NULL, NULL));